Re: [edk2-devel] [edk2-rfc] MdeModulePkg/StatusCodeHandler: Separate NULL class libraries for Memory and serial handlers from MdeModulePkg/Universal/StatusCodeHandler modules

From: devel@edk2.groups.io On Behalf Of Brian J. Johnson Sent: Saturday, June 20, 2020 1:29 AM To: devel@edk2.groups.io; Bi, Dandan ; r...@edk2.groups.io Cc: Dong, Eric ; Ni, Ray ; Wang, Jian J ; Wu, Hao A ; Tan, Ming Subject: Re: [edk2-devel] [edk2-rfc] MdeModulePkg/StatusCodeHandler:

[edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Do not write a local commit template when a global one is defined.

Signed-off-by: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Erik Bjorge Cc: Prince Agyeman Cc: Isaac Oram --- edkrepo/common/common_repo_functions.py | 39 - 1 file changed, 26 insertions(+), 13 deletions(-) diff --git

[edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: EdkRepo Sync Fails to Update Local Manifest

Only use the new manifests default combination if the current manifest is not present in the list of new combos Remove the extranous comparison of repo sources as that content is checked later in the function. Signed-off-by: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Erik Bjorge

Re: [edk2-devel] [PATCH v5 4/4] UefiCpuPkg: PiSmmCpuDxeSmm skip MSR_IA32_MISC_ENABLE manipulation on AMD

On 06/19/20 18:56, Garrett Kirkendall wrote: > AMD does not support MSR_IA32_MISC_ENABLE. Accessing that register > causes and exception on AMD processors. If Execution Disable is > supported, but if the processor is an AMD processor, skip manipulating > MSR_IA32_MISC_ENABLE[34] XD Disable bit.

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v2 3/3] EdkRepo: Fix submodule failures when switching combos.

Pushed as: 2392e3fa84883958822e056ae35f5b4afade5a80 -Original Message- From: devel@edk2.groups.io On Behalf Of Bjorge, Erik C Sent: Wednesday, June 10, 2020 3:14 PM To: devel@edk2.groups.io Cc: Desimone, Ashley E ; Desimone, Nathaniel L ; Pandya, Puja ; Bret Barkelew ; Agyeman, Prince

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v2 2/3] EdkRepo: Adding backwards compatibility for old pin files

Pushed as: a1ae934c28b5781b358a270fed77e35d23b205b0 -Original Message- From: Bjorge, Erik C Sent: Wednesday, June 10, 2020 3:14 PM To: devel@edk2.groups.io Cc: Desimone, Ashley E ; Desimone, Nathaniel L ; Pandya, Puja ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-staging/EdkRepo]

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v2 1/3] EdkRepo: Add force flag when removing submodules

Pushed as: be6fadb6b0398cbcdf8ddbd40f5c16b67d17e551 -Original Message- From: Bjorge, Erik C Sent: Wednesday, June 10, 2020 3:14 PM To: devel@edk2.groups.io Cc: Desimone, Ashley E ; Desimone, Nathaniel L ; Pandya, Puja ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-staging/EdkRepo]

Re: [edk2-devel] [edk2-rfc] MdeModulePkg/StatusCodeHandler: Separate NULL class libraries for Memory and serial handlers from MdeModulePkg/Universal/StatusCodeHandler modules

> On Jun 19, 2020, at 10:29 AM, Brian J. Johnson wrote: > > On 6/18/20 2:01 AM, Dandan Bi wrote: >> Hi All, >> >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2816 >> >> >> We plan to separate two kinds of NULL class libraries for

[edk2-devel] EDK2 code standard question

Hi, I am a new to this group and I found something I think it is a problem in the documentation for code standards of edk2. Can you help me understand who/how I can request a revision on such detail in the documentation?

[edk2-devel] [PATCH] FmpDevicePkg: Enhance capsule verification with secure boot keys

This commit enhances the FmpDevicePkg package to optionally verify capsule with the secure boot keys when PcdFmpDevicePkcs7CertBufferXdr is not set and the new PCD variable PcdFmpDeviceAllowSecureBootKeys is configured. Below is the check logic: - Pass if verified with PK key, or PK key not set

Re: [edk2-devel] [edk2-rfc] MdeModulePkg/StatusCodeHandler: Separate NULL class libraries for Memory and serial handlers from MdeModulePkg/Universal/StatusCodeHandler modules

On 6/18/20 2:01 AM, Dandan Bi wrote: Hi All, REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2816 We plan to separate two kinds of NULL class libraries for Memory and serial handlers from *MdeModulePkg/Universal/StatusCodeHandler/…/

[edk2-devel] [PATCH v5 1/4] PcAtChipsetPkg: PcAtChipsetPkg.dsc add UefiCpuLib LibraryClass

In preparation for moving StandardSignatureIsAuthenticAMD to UefiCpuLib in UefiCpuPkg, PcAtChipset/PcAtChipsetPkg.dsc needs LibraryClass UefiCpuLib. LocalApicLib|UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf will need UefiCpuLib LibraryClass. Likely most "real" platforms will be using

[edk2-devel] [PATCH v5 2/4] SourceLevelDebugPkg: SourceLevelDebugPkg.dsc add UefiCpuLib LibraryClass

In preparation for moving StandardSignatureIsAuthenticAMD to UefiCpuLib in UefiCpuPkg, SourceLevelDebugPkg/SourceLevelDebugPkg.dsc needs LibraryClass UefiCpuLib. LocalApicLib|UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf will need UefiCpuLib LibraryClass. Likely most "real" platforms will be

[edk2-devel] [PATCH v5 3/4] UefiCpuPkg: Move StandardSignatureIsAuthenticAMD to BaseUefiCpuLib

Refactor StandardSignatureIsAuthenticAMD into BaseUefiCpuLib from separate copies in BaseXApicLib, BaseXApicX2ApicLib, and MpInitLib. This allows for future use of StandarSignatureIsAuthinticAMD without creating more instances in other modules. This function allows IA32/X64 code to determine if

[edk2-devel] [PATCH v5 4/4] UefiCpuPkg: PiSmmCpuDxeSmm skip MSR_IA32_MISC_ENABLE manipulation on AMD

AMD does not support MSR_IA32_MISC_ENABLE. Accessing that register causes and exception on AMD processors. If Execution Disable is supported, but if the processor is an AMD processor, skip manipulating MSR_IA32_MISC_ENABLE[34] XD Disable bit. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek

[edk2-devel] [PATCH v5 0/4] AMD processor MSR_IA32_MISC_ENABLE

AMD processor does not support MSR_IA32_MISC_ENABLE register. Accessing this register on AMD causes an unhandled exception in SmmEntry.nasm and a subsequent failure to boot since this is too early in SMM path for the exception handler to be loaded. 1. Prepare PcAtChipsetPkg/PcAtChipsetPkg.dsc to

Re: [edk2-devel] [PATCH v9 08/46] UefiCpuPkg: Implement library support for VMGEXIT

On 06/19/20 15:50, Tom Lendacky wrote: > On 6/19/20 2:47 AM, Dong, Eric via groups.io wrote: >> >> >>> -Original Message- >>> From: devel@edk2.groups.io On Behalf Of >>> Lendacky, Thomas >>> Sent: Thursday, June 18, 2020 10:09 PM >>> To: Dong, Eric ; devel@edk2.groups.io >>> Cc: Brijesh

Re: [edk2-devel] [PATCH v2 2/2] UefiCpuPkg: PiSmmCpuDxeSmm skip MSR_IA32_MISC_ENABLE manipulation on AMD

On 06/18/20 17:22, Kirkendall, Garrett wrote: > AMD does not support MSR_IA32_MISC_ENABLE. Accessing that register > causes and exception on AMD processors. If Execution Disable is > supported, but if the processor is an AMD processor, skip manipulating > MSR_IA32_MISC_ENABLE[34] XD Disable bit.

Re: [edk2-devel] [PATCH v2 0/2] AMD procesor MSR_IA32_MISC_ENABLE

Hi Garrett, On 06/19/20 03:00, Dong, Eric wrote: > Hi Garrett, > > I create a pull request to verify your changes and it reports some > errors for your changes. https://github.com/tianocore/edk2/pull/710 > > please help to resolve these errors before sending your new version > changes, also you

Re: [edk2-devel] [PATCH v9 08/46] UefiCpuPkg: Implement library support for VMGEXIT

> -Original Message- > From: devel@edk2.groups.io On Behalf Of > Lendacky, Thomas > Sent: Friday, June 19, 2020 9:51 PM > To: devel@edk2.groups.io; Dong, Eric > Cc: Brijesh Singh ; Ard Biesheuvel > ; Justen, Jordan L ; > Laszlo Ersek ; Gao, Liming ; > Kinney, Michael D ; Ni, Ray >

[edk2-devel] [PATCH v4 3/3] UefiCpuPkg: PiSmmCpuDxeSmm skip MSR_IA32_MISC_ENABLE manipulation on AMD

AMD does not support MSR_IA32_MISC_ENABLE. Accessing that register causes and exception on AMD processors. If Execution Disable is supported, but if the processor is an AMD processor, skip manipulating MSR_IA32_MISC_ENABLE[34] XD Disable bit. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek

[edk2-devel] [PATCH v4 0/3] AMD processor MSR_IA32_MISC_ENABLE

AMD processor does not support MSR_IA32_MISC_ENABLE register. Accessing this register on AMD causes an unhandled exception in SmmEntry.nasm and a subsequent failure to boot since this is too early in SMM path for the exception handler to be loaded. 1. Prepare PcAtChipsetPkg/PcAtChipsetPkg.dsc to

[edk2-devel] [PATCH v4 2/3] UefiCpuPkg: Move StandardSignatureIsAuthenticAMD to BaseUefiCpuLib

Refactor StandardSignatureIsAuthenticAMD into BaseUefiCpuLib from separate copies in BaseXApicLib, BaseXApicX2ApicLib, and MpInitLib. This allows for future use of StandarSignatureIsAuthinticAMD without creating more instances in other modules. This function allows IA32/X64 code to determine if

[edk2-devel] [PATCH v4 1/3] PcAtChipsetPkg: PcAtChipsetPkg.dsc add UefiCpuLib LibraryClass

In preparation for moving StandardSignatureIsAuthenticAMD to UefiCpuLib in UefiCpuPkg, PcAtChipset/PcAtChipsetPkg.dsc needs LibraryClass UefiCpuLib. LocalApicLib|UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf will need UefiCpuLib LibraryClass. Likely most "real" platforms will be using

Re: [edk2-devel] [PATCH v2] MdePkg: Include Acpi header file

PR: https://github.com/tianocore/edk2/pull/713 > -Original Message- > From: devel@edk2.groups.io On Behalf Of Liming Gao > Sent: Friday, June 19, 2020 5:12 PM > To: Philippe Mathieu-Daudé ; Wasim Khan > ; devel@edk2.groups.io > Cc: Kinney, Michael D ; Varun Sethi > > Subject: Re:

Re: [edk2-devel] [PATCH v9 08/46] UefiCpuPkg: Implement library support for VMGEXIT

On 6/19/20 2:47 AM, Dong, Eric via groups.io wrote: -Original Message- From: devel@edk2.groups.io On Behalf Of Lendacky, Thomas Sent: Thursday, June 18, 2020 10:09 PM To: Dong, Eric ; devel@edk2.groups.io Cc: Brijesh Singh ; Ard Biesheuvel ; Justen, Jordan L ; Laszlo Ersek ; Gao,

[edk2-devel] [PATCH] MdeModulePkg: Upon BootOption failure, Destroy RamDisk memory before RSC.

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2818 For better memory management, re-ordered the DestroyRamDisk and ReportStatusCode calls inside the EfiBootManagerBoot() function. This will help to clean the unused memory before reporting the failure status, so that OEMs can use RSC

Re: [edk2-devel] [edk2-rfc] MdeModulePkg/StatusCodeHandler: Separate NULL class libraries for Memory and serial handlers from MdeModulePkg/Universal/StatusCodeHandler modules

On 06/18/20 09:01, Dandan Bi wrote: > Hi All, > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2816 > > We plan to separate two kinds of NULL class libraries for Memory and serial > handlers from MdeModulePkg/Universal/StatusCodeHandler/.../ > StatusCodeHandlerPei/RuntimeDxe/Smm

Re: [edk2-devel] Build error for UefiPayloadPkgIa32.dsc

Hello Guo, Thank you for your quick answer. I am asking on a testing perspective, I am not using a pure IA32 UEFI payload image. However, would it be possible to increase the FV size for the NOOPT build type, or not to advertise it in the DSC file? I believe the build configuration should work

Re: [edk2-devel] [PATCH v2] MdePkg: Include Acpi header file

Reviewed-by: Liming Gao -Original Message- From: Philippe Mathieu-Daudé Sent: 2020年6月1日 19:18 To: Wasim Khan ; devel@edk2.groups.io Cc: Kinney, Michael D ; Gao, Liming ; Varun Sethi Subject: Re: [edk2-devel] [PATCH v2] MdePkg: Include Acpi header file On 6/1/20 1:16 PM, Wasim Khan

Re: [edk2-devel] [PATCH v2 0/3] add DwMmcHcDxe driver

Hi Leif, Ard, Can you help on the questions I have below? Thanks! > -Original Message- > From: Loh, Tien Hock > Sent: Tuesday, June 16, 2020 4:39 PM > To: 'Haojian Zhuang' ; 'leif.lindh...@linaro.org' > ; 'ard.biesheu...@linaro.org' > ; 'christopher...@microsoft.com' > > Cc:

Re: [edk2-devel] [PATCH v9 08/46] UefiCpuPkg: Implement library support for VMGEXIT

> -Original Message- > From: devel@edk2.groups.io On Behalf Of > Lendacky, Thomas > Sent: Thursday, June 18, 2020 10:09 PM > To: Dong, Eric ; devel@edk2.groups.io > Cc: Brijesh Singh ; Ard Biesheuvel > ; Justen, Jordan L ; > Laszlo Ersek ; Gao, Liming ; > Kinney, Michael D ; Ni, Ray >

Re: [edk2-devel] [PATCH v9 43/46] OvmfPkg: Use the SEV-ES work area for the SEV-ES AP reset vector

> -Original Message- > From: devel@edk2.groups.io On Behalf Of > Lendacky, Thomas > Sent: Thursday, June 18, 2020 10:51 PM > To: Dong, Eric ; devel@edk2.groups.io > Cc: Brijesh Singh ; Ard Biesheuvel > ; Justen, Jordan L ; > Laszlo Ersek ; Gao, Liming ; > Kinney, Michael D ; Ni, Ray >

Re: [edk2-devel] [PATCH v2 1/4] BaseTools: Generate multiple rules when multiple output files

Hi, Pierre The patch looks good. Thanks, Yuwei > -Original Message- > From: devel@edk2.groups.io On Behalf Of > PierreGondois > Sent: Thursday, June 18, 2020 10:27 PM > To: devel@edk2.groups.io > Cc: Pierre Gondois ; sami.muja...@arm.com; > tomas.pi...@arm.com; Feng, Bob C ; Gao, Liming