Hello,
I would like to announce DeviceSimPkg branch creation in edk2-staging
repository.
Branch will be used to develop DeviceSimPkg, a package for developing OS
executable tests
for device focused code.
Branch owner: Maciej Czajkowski , GitHub ID:
81293748 (https://github.com/mczaj)
Signed
Hello,
I would like to request for a write access to edk2-staging repository to create
a new branch for DeviceSimPkg. Its goal is to provide an environment to write
OS-executable tests for code that interacts directly with devices.
Regards,
Maciej Czajkowski
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4041
There is a mistake in getting MMIO base using PciDevicePpi that
can lead to the data corruption.
Cc: Hao A Wu
Cc: Ray Ni
Signed-off-by: Maciej Czajkowski
---
MdeModulePkg/Bus/Ata/AhciPei/AhciPei.c | 5 +++--
1 file changed, 3
is change modifies AhciPei library to allow usage both
> EDKII_PCI_DEVICE_PPI and EDKII_PEI_ATA_AHCI_HOST_CONTROLLER_PPI
> to manage ATA HDD working under AHCI mode.
>
> Cc: Hao A Wu
> Cc: Ray Ni
> Cc: Liming Gao
> Signed-off-by: Maciej Czajkowski
> ---
>
> Notes:
> v2 changes:
>
:
- collected Acked-by tag for no.1 commit
- followed-up with change suggestions in no.2 commit
v3 changes:
- no.1 commit: picked up reviewed-by tag
- no.2 commit: a few fixes based on v2 review
Maciej Czajkowski (2):
MdeModulePkg: Add EDKII_PCI_DEVICE_PPI definition
MdeModulePkg/AhciPei: Use
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3907
This change modifies AhciPei library to allow usage both EDKII_PCI_DEVICE_PPI
and EDKII_PEI_ATA_AHCI_HOST_CONTROLLER_PPI to manage ATA HDD working under
AHCI mode.
Cc: Hao A Wu
Cc: Ray Ni
Cc: Liming Gao
Signed-off-by: Maciej Czajkowski
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3907
This commit introduces EDKII_PCI_DEVICE_PPI. The purpose of this PPI is
to provide a way of accessing PCI devices to drvice drivers such as
NvmExpressPei or AhciPei.
Cc: Hao A Wu
Cc: Ray Ni
Cc: Liming Gao
Signed-off-by: Maciej
with change suggestions in no.2 commit
Maciej Czajkowski (2):
MdeModulePkg: Add EDKII_PCI_DEVICE_PPI definition
MdeModulePkg/AhciPei: Use PCI_DEVICE_PPI to manage AHCI device
MdeModulePkg/Bus/Ata/AhciPei/AhciPei.c| 585 ++--
MdeModulePkg/Bus/Ata/AhciPei/DevicePath.c | 44
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3907
This change modifies AhciPei library to allow usage both EDKII_PCI_DEVICE_PPI
and EDKII_PEI_ATA_AHCI_HOST_CONTROLLER_PPI to manage ATA HDD working under
AHCI mode.
Cc: Hao A Wu
Cc: Ray Ni
Cc: Liming Gao
Signed-off-by: Maciej Czajkowski
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3907
This commit introduces EDKII_PCI_DEVICE_PPI. The purpose of this PPI is
to provide a way of accessing PCI devices to drvice drivers such as
NvmExpressPei or AhciPei.
Cc: Hao A Wu
Cc: Ray Ni
Cc: Liming Gao
Signed-off-by: Maciej
t that performs the enumeration will be implemented in
> the silicon code.
> Sample code can be seen here: https://github.com/mczaj/edk2-
> platforms/commit/d443062e58f9fba228869b54f2546d9735b3b506
>
> Cc: Hao A Wu
> Cc: Ray Ni
> Cc: Liming Gao
>
> Maciej Czajkowski (2):
h
> > EDKII_PCI_DEVICE_PPI and EDKII_PEI_ATA_AHCI_HOST_CONTROLLER_PPI to
> > manage ATA HDD working under AHCI mode.
> >
> > Cc: Hao A Wu
> > Cc: Ray Ni
> > Signed-off-by: Maciej Czajkowski
> > ---
> > MdeModulePkg/Bus/Ata/AhciPei/AhciPei.c
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3907
This commit introduces EDKII_PCI_DEVICE_PPI. The purpose of this PPI is
to provide a way of accessing PCI devices to drvice drivers such as
NvmExpressPei or AhciPei.
Cc: Hao A Wu
Cc: Ray Ni
Cc: Liming Gao
Signed-off-by: Maciej
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3907
This change modifies AhciPei library to allow usage both EDKII_PCI_DEVICE_PPI
and EDKII_PEI_ATA_AHCI_HOST_CONTROLLER_PPI to manage ATA HDD working under
AHCI mode.
Cc: Hao A Wu
Cc: Ray Ni
Signed-off-by: Maciej Czajkowski
that performs the enumeration will be implemented in the
silicon code.
Sample code can be seen here:
https://github.com/mczaj/edk2-platforms/commit/d443062e58f9fba228869b54f2546d9735b3b506
Cc: Hao A Wu
Cc: Ray Ni
Cc: Liming Gao
Maciej Czajkowski (2):
MdeModulePkg: Add EDKII_PCI_DEVICE_PPI definition
to interface
- removed GUID definitons from .h file
- corrected descriptions
- made PPI/protocol GUIDs unique
v2 changes:
- added interface description
- added die specific GUIDs into .dec file
Cc: Ray Ni
Cc: Rangasai V Chaganty
Maciej Czajkowski (1):
IntelSiliconPkg: Add IntelDieInfoProtocol
Added IntelDieInfo header into IntelSiliconPkg tree.
The purpose is to have generic and unified interface for getting
information about dies installed in the system.
It will be implemented by silicon code.
Cc: Ray Ni
Cc: Rangasai V Chaganty
Signed-off-by: Maciej Czajkowski
---
Notes:
v4
gt; Cc: Ray Ni
> Cc: Rangasai V Chaganty
> Signed-off-by: Maciej Czajkowski
> ---
>
> Notes:
> v3:
> - added EDKII_ prefix to interface
> - removed GUID definitons from .h file
> - corrected descriptions
> - made PPI/protocol GUIDs unique
>
>
Added IntelDieInfo header into IntelSiliconPkg tree.
The purpose is to have generic and unified interface for getting
information about dies installed in the system.
It will be implemented by silicon code.
Cc: Ray Ni
Cc: Rangasai V Chaganty
Signed-off-by: Maciej Czajkowski
---
Notes:
v3
from .h file
- corrected descriptions
- made PPI/protocol GUIDs unique
v2 changes:
- added interface description
- added die specific GUIDs into .dec file
Cc: Ray Ni
Cc: Rangasai V Chaganty
Maciej Czajkowski (1):
IntelSiliconPkg: Add IntelDieInfoProtocol
Silicon/Intel/IntelSiliconPkg
Hi Ray, Sai,
Could you take a look on this patch?
Pasting below questions and answers from previous patch for a reference.
What's the difference between SOC and CPU?
SOC die differs from typical CPU die in Intel's chiplet design.
What the purpose of "DieIndex"?
We want to have an indication
Chaganty
Signed-off-by: Maciej Czajkowski
---
Notes:
v2:
- added interface description
- added die specific GUIDs into .dec file
Silicon/Intel/IntelSiliconPkg/Include/Protocol/IntelDieInfoProtocol.h | 117
Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec
into .dec file
Cc: Ray Ni
Cc: Rangasai V Chaganty
Maciej Czajkowski (1):
IntelSiliconPkg: Add IntelDieInfoProtocol
Silicon/Intel/IntelSiliconPkg/Include/Protocol/IntelDieInfoProtocol.h | 117
Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec | 9 ++
2
Can you add some details on how a producer of this interface would know the
values to be assigned here? Does this contain any sort of encoding of
generation and Die specific ID in a single UINT64?
Yes, in order to have a generic field regardless of the die type and
per-generation changes it
Can you add some details on how a producer of this interface would know the
values to be assigned here? Does this contain any sort of encoding of
generation and Die specific ID in a single UINT64?
Yes, in order to have a generic field regardless of the die type and
per-generation changes it
What's the difference between SOC and CPU?
SOC die differs from typical CPU die in Intel's chiplet design.
What the purpose of "DieIndex"?
We want to have an indication to which exactly die given protocol instance is
referring to (in example in multi socket/multi PCH designs).
Have you
Chaganty
Signed-off-by: Maciej Czajkowski
---
Silicon/Intel/IntelSiliconPkg/Include/Protocol/IntelDieInfoProtocol.h | 109
Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec | 2 +
2 files changed, 111 insertions(+)
diff --git
a/Silicon/Intel
This commit will add a protocol/PPI definition which will provide a generic and
unified way to get information about dies installed in the system(PCH, SoC,
CPU).
It will be implemented per generation in silicon packages.
Cc: Ray Ni
Cc: Rangasai V Chaganty
Maciej Czajkowski (1
28 matches
Mail list logo
