On 5/29/2024 8:18 PM, Leif Lindholm via groups.io wrote:
> +Nhi,
>
> Could you check/verify these work fine on your systems?
Yes, I can. Thanks Leif for reaching out to me.
Hi Tommy Huang - Could you please create a Pull Request (PR) or share a
branch so I can easily apply and test the AArch64
On 5/17/2024 4:49 PM, duntan via groups.io wrote:
This patch set defines a new VARIABLE_RUNTIME_CACHE_INFO HOB. The HOB is used
to store the address and size of the buffer that will be used for variable
runtime service when the PcdEnableVariableRuntimeCache is TRUE.
In following patches, when
Hi Abner,
It' hard to say actually. I don't spend full-time for open-source work.
But I will try to complete it within 2 weeks or sooner.
Most of Ampere Altra drivers including IPMI SSIF are living at
https://github.com/AmpereComputing/edk2-platforms. The effort now is to
port to be
Hi Nickle,
Please see my comments inline...
P/s: I just realized that I can not test this protocol without IPMI SSIF
to be compatible with ManageabilityPkg framework.
On 5/15/2024 10:06 PM, Nickle Wang wrote:
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4773
This change implements
On 5/16/2024 3:44 PM, Chang, Abner wrote:
[AMD Official Use Only - AMD Internal Distribution Only]
Hi Nhi,
Are you using SSIF as the transport interface based on the ManabeabilityPkg
framework? If yes, will you contribute that driver?
yes, we are. I will need to update the SSIF driver to be
Thanks Nickle. I'm reviewing and testing it. Will get back to you soon.
On 5/15/2024 10:14 PM, Nickle Wang via groups.io wrote:
Hi Nhi,
Version 2 patch files are sent for review here:
https://edk2.groups.io/g/devel/message/118914 and
https://edk2.groups.io/g/devel/message/118922
For your
Thanks Nickle. I will help review and verify your patch.
On 5/14/2024 8:56 AM, Nickle Wang wrote:
Hi Nhi,
This task is on my list but with lower priority. I will try to provide version
2 patch for review here by the end of this week.
Thanks,
Nickle
-Original Message-
From: Nhi Pham
On 2/9/2024 11:37 PM, Chang, Abner via groups.io wrote:
[AMD Official Use Only - General]
Yeah, I forget this patch set and seems we don't have any follow up
conversation after below feedbacks from community.
https://edk2.groups.io/g/devel/message/103116
On 5/2/2024 4:31 AM, Oliver Smith-Denny via groups.io wrote:
Hi folks, returning to this thread because I noticed that HOB
creation still exists in StandaloneMmCore for ARM:
On 2/1/2024 9:09 AM, Yao, Jiewen via groups.io wrote:
Hi Nhi
Would you please:
1) File an issue in Bugzilla - https://bugzilla.tianocore.org/
2) Share with us the usage of this new API.
We are trying to understand why it is needed.
Hi Jiewen,
Sorry for late response. I've just been back from
On 1/19/2024 6:51 PM, levi.yun wrote:
Except, 8bit transfer encoding.
Tested-by: levi.yun
Reviewed-by: levi.yun
Thanks Levi Yun for testing.
-Nhi
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114131):
From: Laszlo Ersek
The current dependency evaluator violates the memory access permission
when patching depex grammar directly in the read-only depex memory area.
Laszlo pointed out the optimization issue in the thread (1) "Memory
Attribute for depex section" and provided suggested patch to
On 1/19/2024 5:39 PM, Ard Biesheuvel wrote:
Thanks for the patch. This looks good to me in principle, only the
patch got mangled by your MTA
Please resend using 8bit transfer encoding. (You can use
BaseTools/Scripts/SetupGit.py to configure Git for you)
Thanks Ard, I will resend the patch
From: Laszlo Ersek
The current dependency evaluator violates the memory access permission
when patching depex grammar directly in the read-only depex memory area.
Laszlo pointed out the optimization issue in the thread (1) "Memory
Attribute for depex section" and provided suggested patch to
On 1/18/2024 9:49 PM, Laszlo Ersek wrote:
but I'd prefer to just remove this
optimization from standalone MM, given that not only a) it shouldn't
have to deal with a large number of protocol GUIDs, but also b) the
driver dispatch is much more straight-forward. (Typically, StMM
drivers can be
Hi Laszlo,
On 1/16/2024 2:00 AM, Laszlo Ersek wrote:
On 1/15/24 15:04, Ard Biesheuvel wrote:
On Mon, 15 Jan 2024 at 14:07, Nhi Pham wrote:
On 1/12/2024 4:45 PM, Laszlo Ersek wrote:
(Independently: I think that's a valid thing to do for *SMM* drivers,
because the entry point functions of
On 1/12/2024 4:45 PM, Laszlo Ersek wrote:
> (Independently: I think that's a valid thing to do for *SMM* drivers,
> because the entry point functions of those drivers are permitted to use
> both SMM and DXE/UEFI protocols. But whether the same is valid for the
> *standalone* MM drivers -- that
++ disc...@edk2.groups.io
On 1/8/2024 5:11 PM, Nhi Pham wrote:
> Hi Ard, all,
>
> Could you please help explain how the depex section in an image is
> mapped in terms of memory attribute?
>
> As my observation, dispatcher locates[1] the depex section inside the
> module image and write[2] an
Hi Ard, all,
Could you please help explain how the depex section in an image is
mapped in terms of memory attribute?
As my observation, dispatcher locates[1] the depex section inside the
module image and write[2] an evaluated data to the depex if necessary
for scheduled boot order. The
Thanks for update.
Reviewed-by: Nhi Pham
On 12/1/2023 7:34 AM, Taylor Beebe wrote:
ImagePropertiesRecordLib is used by DxeMain and PiSmmCore, so it
needs to be added to most platforms.
Signed-off-by: Taylor Beebe
Cc: Nhi Pham
Cc: Chuong Tran
Cc: Leif Lindholm
Cc: Rebecca Cran
---
On 9/7/2023 10:38 PM, Nhi Pham wrote:
> On 9/6/2023 11:22 PM, Oliver Smith-Denny wrote:
>> On 9/6/2023 1:50 AM, Ard Biesheuvel wrote:
>>> On Wed, 6 Sept 2023 at 09:56, Nhi Pham
>>> wrote:
On 9/6/2023 1:33 PM, Ni, Ray wrote:
> [EXTERNAL EMAIL NOTICE: This email originated from an
On 11/23/2023 3:36 PM, Ard Biesheuvel wrote:
On Thu, 23 Nov 2023 at 05:49, Nhi Pham wrote:
If the SetVirtualAddressMap() is not called, mIsVirtualAddrConverted
is FALSE and the kernel crash occurs in IsNestedFmpCapsule() when
executing gBS->LocateProtocol () in the else case.
To serve the
If the SetVirtualAddressMap() is not called, mIsVirtualAddrConverted
is FALSE and the kernel crash occurs in IsNestedFmpCapsule() when
executing gBS->LocateProtocol () in the else case.
To serve the omitted SetVirtualAddressMap() call, we could just check
mEsrtTable presence instead of relying on
Hi Liming,
Could you please help review and get this patch merged within the next
edk2-stable tag?
Thanks,
Nhi
On 10/23/2023 11:27 AM, Nhi Pham via groups.io wrote:
> This looks good to me. I also build-tested this patch.
>
> Reviewed-by: Nhi Pham
> Tested-by: Nhi Pham
>
&g
This looks good to me. I also build-tested this patch.
Reviewed-by: Nhi Pham
Tested-by: Nhi Pham
On 10/3/2023 10:04 PM, Jake Garver via groups.io wrote:
Ignore old style declaration warnings in oniguruma/src/st.c. This was
already ignored for MSFT, but newer versions of clang complain as
Hi Girish,
I missed your reply. Sorry if I chime in very late, and you started to
develop toward option 1. There are some cases that we can leverage your
work here.
Please see inline...
On 9/21/2023 10:58 PM, Girish Mahadevan wrote:
Hello Nhi,
On 9/21/2023 1:41 AM, Nhi Pham via groups.io
Acked-by: Nhi Pham
Nit: I think you want to run uncrustify for Patch 3 as well :)
Regards,
Nhi
On 10/18/2023 5:07 PM, Marcin Juszkiewicz wrote:
We need platform version to be at least 0.3 to have XHCI
in virtual hardware. On older platforms there is non-working
EHCI which we ignore.
Set
Hi Marcin,
There is a nitpicking below.
Other than, it looks good to me.
Acked-by: Nhi Pham
Regards,
Nhi
On 10/17/2023 8:23 PM, Marcin Juszkiewicz wrote:
We need platform version to be at least 0.3 to have XHCI
in virtual hardware. On older platforms there is non-working
EHCI which we
Hi Marcin,
On 10/16/2023 5:06 PM, Marcin Juszkiewicz wrote:
Platform version 0.3 introduced XHCI USB controller instead of EHCI one.
But we did it in a way that there is no in-EDK2 check for platform
version (XHCI is always given).
This behaviour works with Linux as it complains about being
Thanks, Laszlo for this patch.
Reviewed-by: Nhi Pham
Regards,
Nhi
On 10/17/2023 5:05 PM, Laszlo Ersek via groups.io wrote:
Nhi says that reading LINK_CONTROL_LINK_STATUS_REG is redundant; its only
use was debugging (before commit 380b4b40c60d). Thus, we can go farther
than commit
HI Lazslo,
I was not reviewing carefully. The MmioRead32 is redundant code. Can you
help me get rid of that code?
Thanks,
Nhi
On 10/13/2023 9:20 AM, Nhi Pham wrote:
Thanks for fixing it.
Reviewed-by: Nhi Pham
Regards,
Nhi
On 10/12/2023 4:09 PM, Laszlo Ersek wrote:
Commit 380b4b40c60d
It looks good to me.
Reviewed-by: Nhi Pham
Thanks,
Nhi
On 10/12/2023 4:09 PM, Laszlo Ersek wrote:
The RealTimeClockLib class header in edk2 mistakenly declares a function
called LibRtcVirtualNotifyEvent(). No component ever calls this function
crossing module boundaries; all RealTimeClockLib
Thanks for fixing it.
Reviewed-by: Nhi Pham
Regards,
Nhi
On 10/12/2023 4:09 PM, Laszlo Ersek wrote:
Commit 380b4b40c60d ("AmpereAltraPkg: Update Ampere specific platform PCIe
core", 2023-03-29) removed the DEBUG macro call from
Ac01PcieCoreUpdateLink() that was the only reader of "Val".
Thanks for writing this patch.
Reviewed-by: Nhi Pham
Tested-by: Nhi Pham
Regards,
Nhi
On 10/11/2023 10:49 AM, Nickle Wang wrote:
Reviewed-by: Nickle Wang
Regards,
Nickle
-Original Message-
From: abner.ch...@amd.com
Sent: Wednesday, October 11, 2023 11:41 AM
To:
Hi Ard, Oliver,
I'm investigating the crash on grub2/shim loader due to the added
EFI_MEMORY_ATTRIBUTE_PROTOCOL when rebasing. I found this interesting
patch and went through on the discussion, I am still not sure the
conclusion on this patch.
This issue impacts many platforms, and any
Can we write a DXE_RUNTIME driver to override the pointers of UEFI
Runtime Get/SetVariable() services? Then, we can add platform specific
or custom implementation before/after calling the original
Get/SetVariable()?
Regards,
Nhi
On 9/21/2023 3:27 AM, Girish Mahadevan via groups.io wrote:
Reviewed-by: Nhi Pham
Thanks,
Nhi
On 9/12/2023 12:44 AM, Rebecca Cran wrote:
Improve the Readme.md in Platform/Ampere:
- At this point eMAG is irrelevant, and most people are likely
using Altra systems. Drop mention of it.
- Instead of mentioning the 'latest' versions of CentOS and
This adds Rebecca Cran as reviewer, updates myself as maintainer, and
Leif as reviewer. Also, removes Vu Nguyen and Thang Nguyen due to no
longer working on EDK2.
Signed-off-by: Nhi Pham
---
Maintainers.txt | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git
On 9/6/2023 11:22 PM, Oliver Smith-Denny wrote:
On 9/6/2023 1:50 AM, Ard Biesheuvel wrote:
On Wed, 6 Sept 2023 at 09:56, Nhi Pham
wrote:
On 9/6/2023 1:33 PM, Ni, Ray wrote:
[EXTERNAL EMAIL NOTICE: This email originated from an external sender.
Please be mindful of safe email handling and
] StandaloneMmPkg: Fix HOB
space and heap space conflicted issue
On 9/4/2023 7:20 PM, Nhi Pham wrote:
On 9/2/2023 3:43 AM, Oliver Smith-Denny wrote:
On 8/31/2023 1:20 AM, Nhi Pham via groups.io wrote:
If I am understanding this correctly, this is only an issue when
HOBs are created in StMM, i.e
On 9/6/2023 4:29 AM, Oliver Smith-Denny wrote:
On 9/4/2023 7:20 PM, Nhi Pham wrote:
On 9/2/2023 3:43 AM, Oliver Smith-Denny wrote:
On 8/31/2023 1:20 AM, Nhi Pham via groups.io wrote:
If I am understanding this correctly, this is only an issue when
HOBs are created in StMM, i.e. not from HOBs
Hi Oliver, thank you for taking a look at this patch.
On 9/2/2023 3:43 AM, Oliver Smith-Denny wrote:
On 8/31/2023 1:20 AM, Nhi Pham via groups.io wrote:
Hi Ard,
Thanks for your response on this patch. Please see my reply inline...
On 8/30/2023 8:10 PM, Ard Biesheuvel wrote:
[EXTERNAL EMAIL
Hi Ard,
Thanks for your response on this patch. Please see my reply inline...
On 8/30/2023 8:10 PM, Ard Biesheuvel wrote:
[EXTERNAL EMAIL NOTICE: This email originated from an external sender. Please
be mindful of safe email handling and proprietary information protection
practices.]
On
Just a gentle ping!
Hi Ard, can you provide your feedback on this patch?
Thanks,
-Nhi
On 8/16/2023 3:55 PM, Nhi Pham via groups.io wrote:
Hi Ard and Ming,
I have been seeing an issue with StandaloneMM HobLib that can be fixed
by this patch as well.
The function CreateHob() in the HobLib
Thanks Zhichao, I updated the commit message and also created a PR at
https://github.com/tianocore/edk2/pull/4767
Please help check.
Regards,
-Nhi
On 8/21/2023 2:01 PM, Gao, Zhichao wrote:
Better to update the commit message with specific SMBIOS version.
Others looks good to me.
Thanks,
A faulty PCI device has the Option ROM image size set to 0. UEFI reads
two headers PCI_EXPANSION_ROM_HEADER and PCI_DATA_STRUCTURE to get the
Option ROM information. Because the image size is 0, the Option ROM
header address never changes. As a result, UEFI keeps reading the same
two headers
A faulty PCI device has the Option ROM image size set to 0. UEFI reads
two headers PCI_EXPANSION_ROM_HEADER and PCI_DATA_STRUCTURE to get the
Option ROM information. Because the image size is 0, the Option ROM
header address never changes. As a result, UEFI keeps reading the same
two headers
This updates the system slot ID up to SlotTypePCIExpressGen6andBeyond
(0xC4) to cover modern PCIe Gen.
Cc: Zhichao Gao
Signed-off-by: Nhi Pham
---
ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Hi Ard and Ming,
I have been seeing an issue with StandaloneMM HobLib that can be fixed
by this patch as well.
The function CreateHob() in the HobLib instance
StandaloneMmPkg/Library/StandaloneMmCoreHobLib/StandaloneMmCoreHobLib.inf
does not work at all. The HobList is early created by the
This fixes an unused variable 'Index' error in release build.
Cc: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
Signed-off-by: Nhi Pham
---
PR: https://github.com/tianocore/edk2/pull/4742
RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c | 3 ++-
1 file
Hi Ard,
The error is created by this commit
https://github.com/tianocore/edk2/commit/e6447d2a08f5ca585816d093e79a01dad3781f98.
We are investigating and will get back to you soon.
Thanks for merging our patches.
-Nhi
On 6/2/2023 7:48 PM, Ard Biesheuvel wrote:
On Wed, 24 May 2023 at 02:41,
This patch series looks good to me.
Reviewed-by: Nhi Pham
Thanks,
Nhi
On 5/16/2023 2:08 PM, Minh Nguyen wrote:
These patches help to fix an issue in SmbiosMiscDxe and remove redundant asign
for SmbiosHandle.
Minh Nguyen (2):
ArmPkg/SmbiosMiscDxe: Fix procedure to get handle of SMBIOS
Hi Minh,
Thanks for this patchset. It looks good to me.
Reviewed-by: Nhi Pham
Hi Leif, Ard - Could you please help merge this series?
Thanks,
Nhi
On 5/11/2023 2:51 PM, Minh Nguyen wrote:
These patches help to improve PCIe core for Link training sequence and
add logic to check PCIe card is
Thanks Minh for this series. It looks good to me.
Reviewed-by: Nhi Pham
Hi Leif, Ard - Could you please help merge this series?
Thanks,
Nhi
On 5/5/2023 9:49 AM, Minh Nguyen wrote:
These patches support for PCIe Auto Bifurcation feature of Ampere
silicon (Altra and Altra Max).
Vu Nguyen
Thanks Yao Jiewen for reviewing. I will make further investigation for
other cases based on your findings.
In the meantime, could you help merge my patch?
-Nhi
On 4/27/2023 3:19 PM, Yao, Jiewen wrote:
Thanks Nhi, to provide the fix.
The UEFI specification
Thanks Min.
Could you help merge this patch to edk2?
Regards,
Nhi
On 4/26/2023 2:54 PM, Xu, Min M wrote:
It's good to me.
Reviewed-by: Min Xu
Thanks
-Original Message-
From: Nhi Pham
Sent: Thursday, April 20, 2023 11:49 AM
To: Xu, Min M ; devel@edk2.groups.io;
Hi Min,
This SEI test passes:
SecureBoot - TestImage2.bin in Image Execution Info Table with
SIG_NOT_FOUND. -- PASS
00C3C2F2-39D5-4D35-B7E7-587CA0F3CB75
SctPkg/TestCase/UEFI/EFI/RuntimeServices/SecureBoot/BlackBoxTest/ImageLoadingBBTest.c:1103:Status
- Success
The test image binary is
Hi,
Ping for reviewing.
Let me know if I need anything for this patch.
Thanks,
Nhi
On 4/12/2023 4:21 PM, Nhi Pham wrote:
Add the AUTH_SIG_NOT_FOUND Action to the Image Execution Info Table
when the Image is signed but signature is not allowed by DB and the
hash of image is not found in
Add the AUTH_SIG_NOT_FOUND Action to the Image Execution Info Table
when the Image is signed but signature is not allowed by DB and the
hash of image is not found in DB/DBX.
This is documented in the UEFI spec 2.10, table 32.5.
This issue is found by the SIE SCT with the error message as
Thanks a lot Leif for the quick review and merging.
Best regards,
Nhi
On 3/29/2023 11:07 PM, Leif Lindholm wrote:
Hi Nhi,
Thanks - this was a lot easier to review.
For the series:
Reviewed-by: Leif Lindholm
Pushed as 4811c37ae347..d8d167f11ac5.
/
Leif
On Wed, Mar 29, 2023 at 11:32:37
Hi Leif,
Sorry to have kept you waiting. I was not able to send the v2 out sooner
than I wanted as the large refactor changes has been well-tested. I have
just sent the v2. I hope all your comments are addressed.
Thanks so much.
Nhi
On 1/13/2023 11:25 AM, Nhi Pham wrote:
This patchset
From: Vu Nguyen
This change helps to update the following:
- Add logic to get SubNUMA node region for Ampere silicons
(Altra and Altra Max processor) as a common API in AmpereCpuLibCommon.
- Leverage the added API of AmpereCpuLibCommon accordingly.
Signed-off-by: Nhi Pham
---
From: Vu Nguyen
This updates the platform specific PCIe modules to
add support for Ampere Altra Max processor which
features 128 PCIe Gen4 lanes (distributed across
eight x16 RCAs) using 32 controllers.
Signed-off-by: Nhi Pham
---
.../Library/BoardPcieLib/BoardPcieLib.c | 75 +++-
From: Vu Nguyen
This adds PHY preset NVParams definition for each Root complex
to support Ampere Altra Max platform.
Signed-off-by: Nhi Pham
---
.../AmpereAltraPkg/Include/NVParamDef.h | 36 +--
1 file changed, 34 insertions(+), 2 deletions(-)
diff --git
From: Vu Nguyen
This updates the number of cores and clusters to add support
for the Ampere Altra Max processor.
Signed-off-by: Nhi Pham
---
Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 6 +++---
Silicon/Ampere/AmpereAltraPkg/Include/Platform/Ac01.h | 5 -
2 files changed, 7
From: Vu Nguyen
This patch updates the following:
- Check End Point configuration space is accessible or
not before getting its capability.
- Add new function to check PCIe card is present or not.
- Set CRS (Configuration Request Retry Status) to follow
PCIe specifications.
Signed-off-by:
From: Vu Nguyen
This fixes the memory attribute of the first
RC Type B (RCB0).
Signed-off-by: Nhi Pham
---
Silicon/Ampere/AmpereAltraPkg/Include/Platform/Ac01.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Silicon/Ampere/AmpereAltraPkg/Include/Platform/Ac01.h
From: Vu Nguyen
According to PCIe specification, following exit from a Conventional Reset,
some devices may require additional time before they are able to respond
to Requests they receive, so this patch adds a delay after releasing the
PERST signal.
Signed-off-by: Nhi Pham
---
From: Vu Nguyen
This corrects the high devmap of Root Complex (RC)
that should be fetched from a high bifurcation.
Signed-off-by: Nhi Pham
---
.../Ampere/AmpereAltraPkg/Drivers/PcieInitPei/PcieInitPei.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
This patchset adds support for Ampere Altra Max processor and updates for some
bugfixes.
Changes since v1:
+ Improved readability per Leif's feedback, such as: Add helper functions.
split out the supports, bugfixes, and code refactor.
Tinh Nguyen (1):
JadePkg: ACPI: Support ACPI tables for
Hi Leif,
On 2/15/2023 7:03 PM, Leif Lindholm via groups.io wrote:
On Fri, Jan 13, 2023 at 11:25:17 +0700, Nhi Pham via groups.io wrote:
From: Tinh Nguyen
This adds ACPI DSDT tables and updates ACPI MADT table
to support Ampere Altra Max processor.
Signed-off-by: Nhi Pham
Ideally, I would
Hi Leif,
Thanks for your reviewing. Most of your feedback is valid. I will fix
them. There is a comment that need your more explanation.
Please see the inline reply for more details.
On 2/15/2023 6:59 PM, Leif Lindholm wrote:
On Fri, Jan 13, 2023 at 11:25:16 +0700, Nhi Pham wrote:
From: Vu
Sorry, just a gentle ping Leif as you may have missed my previous email :)
On 1/17/2023 5:09 PM, Nhi Pham wrote:
Hi Ard and Leif,
Just a friendly ping on the patches recently posted.
Below are links to the patches including the new introduction to the
Ampere Altra Max support that we need
Hi Rebecca,
++ Harb who can give more insights on this. FYI, the original concern is
https://edk2.groups.io/g/devel/message/98482
On 1/18/2023 1:21 AM, Rebecca Cran wrote:
On 1/17/23 09:40, Ard Biesheuvel wrote:
On Tue, 17 Jan 2023 at 13:55, Rebecca Cran wrote:
I was under the impression
Hi Ard and Leif,
Just a friendly ping on the patches recently posted.
Below are links to the patches including the new introduction to the
Ampere Altra Max support that we need you to review and merge them in order:
1/ https://edk2.groups.io/g/devel/message/97671
2/
Hi Rebecca,
That's Ampere Altra Family specific MPIDR encoding. So, we could not
leverage the definitions in the ArmPkg/Include/Library/ArmLib.h.
-Nhi
On 1/13/2023 9:40 PM, Rebecca Cran wrote:
On 1/12/23 21:21, Nhi Pham via groups.io wrote:
+//
+// MPIDR manipulation
+//
+#define
From: Vu Nguyen
This updates the PCIe modules to add support for
Ampere Altra Max processor which features 128 PCIe
Gen4 lanes (distributed across eight x16 RCAs) using
32 controllers.
Signed-off-by: Nhi Pham
---
.../AmpereAltraPkg/Include/NVParamDef.h | 64 ++--
This patchset adds support for Ampere Altra Max processor.
Tinh Nguyen (1):
JadePkg: ACPI: Support ACPI tables for Ampere Altra Max
Vu Nguyen (1):
Ampere: PCIe: Add support for Ampere Altra Max
.../AmpereAltraPkg/AmpereAltraPkg.dsc.inc |6 +-
Platform/Ampere/JadePkg/Jade.dsc
From: Tinh Nguyen
Since the commit 103fa647d159e3d76be2634d2653c2d215dd0d46 instead
("ArmPkg: Replace CoreId and ClusterId with Mpidr in ARM_CORE_INFO
struct") has updated the ARM_CORE_INFO structure so the MPIDR is now a
single field instead of separate cluster/core fields. This patch
updates
Thanks Ard for reviewing them.
Sorry, I'm not aware of the SetTime() issue since I have not setup my
mailbox for receiving the Linux kernel mails. Let me forward this issue
to appropriate UEFI team and Linux kernel team to investigate.
Thanks,
-Nhi
On 12/23/2022 9:37 PM, Ard Biesheuvel
From: Vu Nguyen
The hob was built but wasn't consumed yet. This change will let the DXE
Main shift the memory space consumed by DXE modules to the region
specified by the PcdSystemMemoryBase and PcdSystemMemorySize.
Signed-off-by: Nhi Pham
---
.../Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
From: Tinh Nguyen
PrePeiCore's Arm module just added a requirement to run all library
constructors that PrePeiCore uses. One of them is included in the
constructor of the ExtractGuidedSectionLib. This constructor will build
a HOB that is not supported "at this time" and causes an error.
We don't
From: Minh Nguyen
In some scenarios, the information of Bios Version, Bios Release
and Embedded Controller Firmware Release are fetched during UEFI
booting. This patch supports updating those fields dynamically
when the PCDs are empty.
Signed-off-by: Nhi Pham
Reviewed-by: Rebecca Cran
From: Minh Nguyen
This patch removes redundant updates of "BoardManufacturerType02"
and "SerialNumberType02".
Signed-off-by: Nhi Pham
Reviewed-by: Rebecca Cran
Reviewed-by: Sami Mujawar
Acked-by: Ard Biesheuvel
Acked-by: Leif Lindholm
---
From: Minh Nguyen
This patch fixes typo from "AssertTagType02"
to "AssetTagType02".
Signed-off-by: Nhi Pham
Reviewed-by: Rebecca Cran
Reviewed-by: Sami Mujawar
Acked-by: Ard Biesheuvel
Acked-by: Leif Lindholm
---
ArmPkg/Include/Library/OemMiscLib.h
This adds an API to OemMiscLib for fetching the system UUID according to
the platform.
Signed-off-by: Nhi Pham
Reviewed-by: Rebecca Cran
Reviewed-by: Sami Mujawar
Acked-by: Ard Biesheuvel
Acked-by: Leif Lindholm
---
ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf
From: Minh Nguyen
According to "SMC Calling Convention" specification, section 7.4,
return value of Arm Architecture Calls is stored at first argument of
SMC aguments (ARM_SMC_ARGS). This value can be negative values indicating
error or positive values (including zero) indicating success.
From: Minh Nguyen
In some scenarios, the processor version may be updated dynamically
from pre-UEFI firmware during booting. But the processor version is
fixed with PCD (PcdProcessorVersion), so it can not be updated it
dynamically. This patch will support setting that value both
statically and
This patchset is to update the ArmPkg/SMBIOS for fixes and improvements.
Changes since v3:
+ Update for OemGetBiosRelease and
OemGetEmbeddedControllerFirmwareRelease functions [Leif, Sami]
Changes since v2:
+ Add tags from Ard and Sami
+ Fix patch 3 for compilation error with
This fixes the typo of AssetTagType02 according to the recent changes
from OemMiscLib.h in the edk2.
Signed-off-by: Nhi Pham
Reviewed-by: Leif Lindholm
---
Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
This is to reflect the new APIs added to edk2/OemMiscLib library.
Signed-off-by: Nhi Pham
---
Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.inf | 5 +++
Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c | 42
2 files changed, 47 insertions(+)
diff --git
This patchset is to update SbsaQemu/OemMiscLib to reflect the recent
changes in edk2/OemMiscLib.
Changes since v1:
+ Update OemGetBiosRelease and
OemGetEmbeddedControllerFirmwareRelease functions [Leif, Sami]
Nhi Pham (2):
SbsaQemu/OemMiscLib: Update for new OemMiscLib APIs
Hi Sami,
On 9/16/2022 2:32 PM, Sami Mujawar wrote:
Hi Nhi,
Please see my response inline marked [SAMI].
Regards,
Sami Mujawar
On 15/09/2022, 19:23, "Nhi Pham" wrote:
Thanks Leif. I will fix as your suggestion.
-Nhi
On 9/15/2022 5:54 PM, Leif Lindholm wrote:
> On
Thanks Leif. I will fix as your suggestion.
-Nhi
On 9/15/2022 5:54 PM, Leif Lindholm wrote:
On Tue, Sep 13, 2022 at 13:19:47 +0700, Nhi Pham wrote:
From: Minh Nguyen
In some scenarios, the information of Bios Version, Bios Release
and Embedded Controller Firmware Release are fetched during
From: Minh Nguyen
In some scenarios, the information of Bios Version, Bios Release
and Embedded Controller Firmware Release are fetched during UEFI
booting. This patch supports updating those fields dynamically
when the PCDs are empty.
Signed-off-by: Nhi Pham
Reviewed-by: Rebecca Cran
From: Minh Nguyen
This patch removes redundant updates of "BoardManufacturerType02"
and "SerialNumberType02".
Signed-off-by: Nhi Pham
Reviewed-by: Rebecca Cran
Reviewed-by: Sami Mujawar
Acked-by: Ard Biesheuvel
---
From: Minh Nguyen
This patch fixes typo from "AssertTagType02"
to "AssetTagType02".
Signed-off-by: Nhi Pham
Reviewed-by: Rebecca Cran
Reviewed-by: Sami Mujawar
Acked-by: Ard Biesheuvel
---
ArmPkg/Include/Library/OemMiscLib.h
| 2 +-
This adds an API to OemMiscLib for fetching the system UUID according to
the platform.
Signed-off-by: Nhi Pham
Reviewed-by: Rebecca Cran
Reviewed-by: Sami Mujawar
Acked-by: Ard Biesheuvel
---
ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf
| 4
From: Minh Nguyen
According to "SMC Calling Convention" specification, section 7.4,
return value of Arm Architecture Calls is stored at first argument of
SMC aguments (ARM_SMC_ARGS). This value can be negative values indicating
error or positive values (including zero) indicating success.
From: Minh Nguyen
In some scenarios, the processor version may be updated dynamically
from pre-UEFI firmware during booting. But the processor version is
fixed with PCD (PcdProcessorVersion), so it can not be updated it
dynamically. This patch will support setting that value both
statically and
1 - 100 of 307 matches
Mail list logo
