Re: [edk2-devel] Strange behavior between GCC 11 and GCC 12

On Behalf Of Ni, Ray Sent: Saturday, April 15, 2023 8:50 AM To: devel@edk2.groups.io; thomas.lenda...@amd.com; Ard Biesheuvel Cc: devel@edk2.groups.io; Gerd Hoffmann Subject: Re: [edk2-devel] Strange behavior between GCC 11 and GCC 12 Why does OVMF choose to migrate the content from NEM to MEM

Re: [edk2-devel] [PATCH 2/2] UefiCpuPkg: Support 5 level page table in ResetVector

> > But with 5-level paging enabled the reset vector should be able to > fallback to 4-level paging in case the CPU does not support 5-level > paging. The fallback makes sense. Otherwise, forcing to use 5L in an incapable CPU would be a silent failure because IDT and debug log are not enabled at

Re: [edk2-devel] Strange behavior between GCC 11 and GCC 12

Why does OVMF choose to migrate the content from NEM to MEM itself? PEI core can do the migration well. thanks, ray From: devel@edk2.groups.io on behalf of Lendacky, Thomas via groups.io Sent: Saturday, April 15, 2023 5:50:25 AM To: Ard Biesheuvel Cc: devel@edk

Re: [edk2-devel] [Patch V2 0/8] Use CpuPageTableLib to create and update smm page table

doesn't set c bit to non leaf entries. then who sets the c bit? thanks, ray thanks, ray From: devel@edk2.groups.io on behalf of Lendacky, Thomas via groups.io Sent: Friday, April 14, 2023 9:43:52 PM To: Ni, Ray ; Tan, Dun ; devel@edk2.groups.io Subjec

Re: [edk2-devel] [Patch V2 5/8] MdeModulePkg: Add UefiCpuPkg.dec to pass DependencyCheck

Mike, What's the rule regarding content in mdepkg and cpupkg? thanks, ray From: Kinney, Michael D Sent: Friday, April 14, 2023 11:16:45 PM To: devel@edk2.groups.io ; Wang, Jian J ; Tan, Dun Cc: Gao, Liming ; Ni, Ray ; Kinney, Michael D Subject: RE:

Re: [edk2-devel] [Patch V2 0/8] Use CpuPageTableLib to create and update smm page table

> -Original Message- > From: Tom Lendacky > Sent: Friday, April 14, 2023 12:19 AM > To: Tan, Dun ; devel@edk2.groups.io > Cc: Ni, Ray > Subject: Re: [edk2-devel] [Patch V2 0/8] Use CpuPageTableLib to create and > update smm page table > > On 4/13/23 04:14,

Re: [edk2-devel] [PATCH v2] SimicsOpenBoardPkg: Remove duplicated SmmLockBox.inf

Reviewed-by: Ray Ni > -Original Message- > From: Liu, Zhiguang > Sent: Wednesday, April 12, 2023 4:32 PM > To: devel@edk2.groups.io > Cc: Liu, Zhiguang ; Desimone, Nathaniel L > ; Ni, Ray > Subject: [PATCH v2] SimicsOpenBoardPkg: Remove duplicated > Sm

Re: [edk2-devel] [PATCH] SimicsOpenBoardPkg: Remove duplicated SmmLockBox.inf

Zhiguang, Can you please remove it from Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc? Thanks, Ray > -Original Message- > From: Liu, Zhiguang > Sent: Wednesday, April 12, 2023 2:40 PM > To: devel@edk2.groups.io > Cc: Liu, Zhiguang ; Desimone, Nathanie

Re: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses SmmSmramSaveStateLib library

yes thanks, ray From: Attar, AbdulLateef (Abdul Lateef) Sent: Tuesday, April 11, 2023 7:17:03 PM To: Ni, Ray ; devel@edk2.groups.io ; kra...@redhat.com Cc: Grimes, Paul ; Kirkendall, Garrett ; Chang, Abner ; Dong, Eric ; Kumar, Rahul R ; Ard Biesheuvel ; Yao

Re: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses SmmSmramSaveStateLib library

alf Of Gerd > Hoffmann > Sent: Tuesday, April 11, 2023 5:43 PM > To: Abdul Lateef Attar > Cc: devel@edk2.groups.io; Abdul Lateef Attar > ; Paul Grimes ; > Garrett Kirkendall ; Abner Chang > ; Dong, Eric ; Ni, Ray > ; Kumar, Rahul R ; Ard > Biesheuvel ; Yao, Jiewen > ; Jus

Re: [edk2-devel] [PATCH v8 8/9] UefiCpuPkg: Uses SmmSmramSaveStateLib library

>Status = SmmCpuFeaturesReadSaveStateRegister (CpuIndex, Register, > Width, Buffer); >if (Status == EFI_UNSUPPORTED) { > -Status = ReadSaveStateRegister (CpuIndex, Register, Width, Buffer); > +Status = SmramSaveStateReadRegister (CpuIndex, Register, Width, > Buffer); >} > I

Re: [edk2-devel] [PATCH v8 7/9] UefiCpuPkg: Implements SmmSmramSaveStateLib for Intel

> + > SmmSmramSaveStateLib|UefiCpuPkg/Library/SmmSmramSaveStateLib/Intel > SmmSmramSaveStateLib.inf 1. Can you rename it to "IntelMmSaveStateLib"? > + INF_VERSION= 1.29 > + BASE_NAME = IntelSmmSmramSaveStateLib > + FILE_GUID = 37E8

Re: [edk2-devel] [PATCH v8 6/9] UefiCpuPkg: Implements SmmCpuFeaturesLib for AMD Family

Acked-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io On Behalf Of Abdul > Lateef Attar via groups.io > Sent: Monday, April 10, 2023 7:10 PM > To: devel@edk2.groups.io > Cc: Abdul Lateef Attar ; Paul Grimes > ; Garrett Kirkendall ; > Abner Chang

Re: [edk2-devel] [PATCH v8 5/9] UefiCpuPkg: Initial implementation of AMD's SmmCpuFeaturesLib

Reviewed-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io On Behalf Of Abdul > Lateef Attar via groups.io > Sent: Monday, April 10, 2023 7:10 PM > To: devel@edk2.groups.io > Cc: Abdul Lateef Attar ; Paul Grimes > ; Garrett Kirkendall ; > Abner Chang

Re: [edk2-devel] [PATCH v8 3/9] UefiCpuPkg: Implements SmmSmramSaveStateLib library class

> + > SmmSmramSaveStateLib|UefiCpuPkg/Library/SmmSmramSaveStateLib/Am > dSmmSmramSaveStateLib.inf 1. The lib instance name can be AmdMmSaveStateLib inside X86MmSaveStateLib folder. > +[Defines] > + INF_VERSION= 1.29 > + BASE_NAME = AmdSmmSmramSaveStateL

Re: [edk2-devel] [PATCH v8 2/9] UefiCpuPkg: Adds SmmSmramSaveStateLib library class

> + ## @libraryclass Provides functions for manipulating Smram savestate > registers. > + SmmSmramSaveSateLib|Include/Library/SmmSmramSaveStateLib.h 1. Can you please rename the lib class to MmSaveStateLib? So the lib can be potentially linked with standalone MM CPU driver. 2. Also the lib he

Re: [edk2-devel] [PATCH v8 1/9] MdePkg: Adds AMD SMRAM save state map

The patch looks good in general. @Kinney, Michael D, I think it's ok to use "SmramSaveStateMap.h" instead of "MmramSaveStateMap.h" because it matches to the CPU spec. Do you agree? "MM" is more like a general term that applies to all archs, X86, ARM, etc. Abdul, just curious why do you add prefi

Re: [edk2-devel] [PATCH 1/2] SimicsOpenBoardPkg: Fix bug in DSDT

Nate, can you help to give the R-B and push? Thanks, Ray > -Original Message- > From: Ni, Ray > Sent: Saturday, October 8, 2022 3:32 PM > To: devel@edk2.groups.io; Guenzel, Robert > Subject: RE: [PATCH 1/2] SimicsOpenBoardPkg: Fix bug in DSDT > > Thanks for fixin

Re: [edk2-devel] [PATCH 03/18] UefiCpuPkg: Update code to be more C11 compliant by using __func__

Reviewed-by: Ray Ni > -Original Message- > From: Rebecca Cran > Sent: Friday, April 7, 2023 6:23 AM > To: devel@edk2.groups.io; Gao, Liming ; > Kinney, Michael D ; Jiang, Guomin > ; Xu, Wei6 ; Dong, Guo > ; Ni, Ray ; Rhodes, Sean > ; Lu, James ; Guo, Gua >

Re: [edk2-devel] [PATCH 15/18] SourceLevelDebugPkg: Update code to be more C11 compliant by using __func__

Reviewed-by: Ray Ni > -Original Message- > From: Rebecca Cran > Sent: Friday, April 7, 2023 6:23 AM > To: devel@edk2.groups.io; Gao, Liming ; > Kinney, Michael D ; Jiang, Guomin > ; Xu, Wei6 ; Dong, Guo > ; Ni, Ray ; Rhodes, Sean > ; Lu, James ; Guo, Gua >

Re: [edk2-devel] [PATCH 16/18] EmulatorPkg: Update code to be more C11 compliant by using __func__

Reviewed-by: Ray Ni > -Original Message- > From: Rebecca Cran > Sent: Friday, April 7, 2023 6:23 AM > To: devel@edk2.groups.io; Gao, Liming ; > Kinney, Michael D ; Jiang, Guomin > ; Xu, Wei6 ; Dong, Guo > ; Ni, Ray ; Rhodes, Sean > ; Lu, James ; Guo, Gua >

Re: [edk2-devel] [PATCH v4 0/6] UefiCpuPkg, OvmfPkg: Simplify CpuExceptionHandlerLib

Reviewed. Merged. Thank you Ard! > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ard > Biesheuvel > Sent: Tuesday, April 4, 2023 5:46 PM > To: devel@edk2.groups.io; mhaeu...@posteo.de; Ni, Ray > Cc: Andrew Fish ; Kinney, Michael D > ; Liu, Zhiguang ;

Re: [edk2-devel] [PATCH v4 3/6] UefiCpuPkg/PeiCpuExceptionHandlerLib: Use SEC/PEI specific asm component

Reviewed-by: Ray Ni > -Original Message- > From: Ard Biesheuvel > Sent: Monday, April 3, 2023 10:29 PM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Ni, Ray ; Andrew > Fish ; Kinney, Michael D ; > Liu, Zhiguang ; Rebecca Cran > ; Tom Lendacky ; > Marvin H

Re: [edk2-devel] [PATCH v4 2/6] UefiCpuPkg/CpuExceptionHandlerLib: Use single SEC/PEI version

Reviewed-by: Ray Ni > -Original Message- > From: Ard Biesheuvel > Sent: Monday, April 3, 2023 10:29 PM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Ni, Ray ; Andrew > Fish ; Kinney, Michael D ; > Liu, Zhiguang ; Rebecca Cran > ; Tom Lendacky ; > Marvin H

Re: [edk2-devel] [PATCH v4] IntelFsp2Pkg: LoadMicrocodeDefault() causing unnecessary delay.

Reviewed-by: Ray Ni > -Original Message- > From: Chiu, Chasel > Sent: Tuesday, April 4, 2023 2:34 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star ; Ni, > Ray ; Kuo, Ted > Subject: [PATCH v4] IntelFsp2Pkg: LoadMi

Re: [edk2-devel] [PATCH v3] IntelFsp2Pkg: LoadMicrocodeDefault() causing unnecessary delay.

pril 1, 2023 6:57 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star ; Ni, > Ray > Subject: [edk2-devel] [PATCH v3] IntelFsp2Pkg: LoadMicrocodeDefault() > causing unnecessary delay. > > REF: https://bugzilla.tianocore.org/show_bu

Re: [edk2-devel] [PATCH] UefiCpuPkg/Test: Disable random test cases

> -Original Message- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Saturday, April 1, 2023 2:22 AM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH] UefiCpuPkg/Test: Disable random test cases > > The random test cases just run for too long t

[edk2-devel] [PATCH] UefiCpuPkg/Test: Disable random test cases

The random test cases just run for too long that may cause timeout in CI test. Disable them for now. Signed-off-by: Ray Ni --- .../UnitTest/CpuPageTableLibUnitTestHost.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/UefiCpuPkg/Library/CpuPageTableLib

Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/CI: Revert SMP mode

Anyone knows why the job status is "queued" for all the CI jobs? > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > D Kinney > Sent: Saturday, April 1, 2023 12:13 AM > To: devel@edk2.groups.io; mikub...@linux.microsoft.com > Cc: Ard Biesheuvel ; Yao, Jiewen > ; Just

[edk2-devel] PR fails due to OVMF time out

Hi, I found several of my PRs cannot pass the CI due to OVMF boot timeout. e.g.: Mktme fix by niruiyu * Pull Request #4072 * tianocore/edk2 (github.com) I also one PR from Ard (X64 text reloc fixes by ardbiesheuvel * Pull Request #4216 * tianocore/edk

Re: [edk2-devel] [PATCH 2/3] BaseTools/Conf/tools_def: Fix CLANGDWARF_IA32_X64

Why ELF header overflows into .text section? > -Original Message- > From: Patrick Rudolph > Sent: Friday, March 17, 2023 10:06 PM > Cc: devel@edk2.groups.io; Dong, Guo ; Guo, Gua > ; Lu, James ; Ni, Ray > ; mhaeu...@posteo.de; a...@kernel.org > Subject: [PATC

Re: [edk2-devel] [RFT PATCH v3 0/5] UefiCpuPkg, OvmfPkg: Simplify CpuExceptionHandlerLib

> -Original Message- > From: devel@edk2.groups.io On Behalf Of Marvin > Häuser > Sent: Friday, March 31, 2023 7:10 PM > To: Ard Biesheuvel > Cc: Ni, Ray ; devel@edk2.groups.io; Andrew Fish > ; Kinney, Michael D ; Liu, > Zhiguang ; Rebecca Cran ; > Tom Len

Re: [edk2-devel] [Patch V2 8/8] MdeModulePkg/DxeIpl: Refinement to the code to set PageTable as RO

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Friday, March 31, 2023 5:34 PM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Gao, Liming > ; Ni, Ray ; Wang, Jian J > > Subject: [Patch V2 8/8] MdeModulePkg/DxeIpl: Refinement to the code

Re: [edk2-devel] [Patch V2 6/8] MdeModulePkg/DxeIpl: Create page table by CpuPageTableLib

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Friday, March 31, 2023 5:34 PM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Gao, Liming > ; Ni, Ray ; Wang, Jian J > > Subject: [Patch V2 6/8] MdeModulePkg/DxeIpl: Create page table by >

Re: [edk2-devel] [Patch V2 1/8] EmulatorPkg: Add CpuPageTableLib required by DxeIpl in DSC

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Friday, March 31, 2023 5:34 PM > To: devel@edk2.groups.io > Cc: Andrew Fish ; Ni, Ray > Subject: [Patch V2 1/8] EmulatorPkg: Add CpuPageTableLib required by > DxeIpl in DSC > > Add CpuPageTa

Re: [edk2-devel] [RFT PATCH v3 3/5] UefiCpuPkg/CpuExceptionHandlerLib: Make runtime fixups XCODE-only

Ok I see that the macro is added to PP flags. I thought it's added to NASM build flags. Reviewed-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ard > Biesheuvel > Sent: Friday, March 31, 2023 5:15 PM > To: devel@edk2.groups.io > Cc: A

Re: [edk2-devel] [RFT PATCH v3 2/5] UefiCpuPkg/CpuExceptionHandlerLib: Use single SEC/PEI version

> -Original Message- > From: devel@edk2.groups.io On Behalf Of Ard > Biesheuvel > Sent: Friday, March 31, 2023 6:13 PM > To: devel@edk2.groups.io; Ni, Ray > Cc: Andrew Fish ; Kinney, Michael D > ; Liu, Zhiguang ; > Rebecca Cran ; Tom Lendacky > ; Marvin H

Re: [edk2-devel] [RFT PATCH v3 2/5] UefiCpuPkg/CpuExceptionHandlerLib: Use single SEC/PEI version

So, for nasm advanced macros (rep), use "%". Otherwise, either is fine. > -Original Message- > From: Ard Biesheuvel > Sent: Friday, March 31, 2023 6:14 PM > To: Ni, Ray > Cc: devel@edk2.groups.io; Andrew Fish ; Kinney, > Michael D ; Liu, Zhiguang >

Re: [edk2-devel] [RFT PATCH v3 0/5] UefiCpuPkg, OvmfPkg: Simplify CpuExceptionHandlerLib

iesheuvel > Sent: Friday, March 31, 2023 5:15 PM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Ni, Ray ; Andrew > Fish ; Kinney, Michael D ; > Liu, Zhiguang ; Rebecca Cran > ; Tom Lendacky ; > Marvin Häuser > Subject: [edk2-devel] [RFT PATCH v3 0/5] UefiCpuPkg, OvmfPkg:

Re: [edk2-devel] [RFT PATCH v3 3/5] UefiCpuPkg/CpuExceptionHandlerLib: Make runtime fixups XCODE-only

Friday, March 31, 2023 5:15 PM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Ni, Ray ; Andrew > Fish ; Kinney, Michael D ; > Liu, Zhiguang ; Rebecca Cran > ; Tom Lendacky ; > Marvin Häuser > Subject: [edk2-devel] [RFT PATCH v3 3/5] > UefiCpuPkg/CpuExceptionHandlerLib: Mak

Re: [edk2-devel] [RFT PATCH v3 2/5] UefiCpuPkg/CpuExceptionHandlerLib: Use single SEC/PEI version

By the way, which ("%" or "#") should be used for def check in NASM? I thought we need to use "%" but your patch uses "#". > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Friday, March 31, 2023 5:56 PM

Re: [edk2-devel] [RFT PATCH v3 2/5] UefiCpuPkg/CpuExceptionHandlerLib: Use single SEC/PEI version

- > From: Ard Biesheuvel > Sent: Friday, March 31, 2023 5:15 PM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Ni, Ray ; Andrew > Fish ; Kinney, Michael D ; > Liu, Zhiguang ; Rebecca Cran > ; Tom Lendacky ; > Marvin Häuser > Subject: [RFT PATCH v3 2/5] UefiCpuPkg/CpuE

Re: [edk2-devel] [PATCH 0/6] Substract TME-MK KEY_ID_BITS from CPU max PA

Gerd, Can you give a Reviewed-by/Acked-by for the patch series? > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Friday, March 31, 2023 3:25 PM > To: kra...@redhat.com; Xu, Min M ; Liu, Zhiguang > > Cc: devel@edk2.groups.io; Tom Lenda

Re: [edk2-devel] [RFT PATCH v2 3/6] UefiCpuPkg/CpuExceptionHandlerLib: Use single SEC/PEI version

el > Sent: Friday, March 31, 2023 3:41 PM > To: devel@edk2.groups.io; Ni, Ray > Cc: Andrew Fish ; Kinney, Michael D > ; Liu, Zhiguang ; > Rebecca Cran ; Tom Lendacky > > Subject: Re: [edk2-devel] [RFT PATCH v2 3/6] > UefiCpuPkg/CpuExceptionHandlerLib: Use single SEC/PEI versi

Re: [edk2-devel] [PATCH v6 6/6] UefiCpuPkg: Implements SmmCpuFeaturesLib for AMD Family

teef Attar via groups.io > Sent: Saturday, March 25, 2023 1:39 PM > To: devel@edk2.groups.io > Cc: Abdul Lateef Attar ; Paul Grimes > ; Garrett Kirkendall ; > Abner Chang ; Dong, Eric ; > Ni, Ray ; Kumar, Rahul R ; > Abdul Lateef Attar > Subject: [edk2-devel]

Re: [edk2-devel] [PATCH v2 0/2] SEV-SNP guest support fixes

Acked-by: Ray Ni > -Original Message- > From: Gerd Hoffmann > Sent: Thursday, March 30, 2023 3:36 PM > To: devel@edk2.groups.io; thomas.lenda...@amd.com > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Michael > Roth ; Ashish Kalra > Subject: Re: [edk2-devel

Re: [edk2-devel] [PATCH 0/6] Substract TME-MK KEY_ID_BITS from CPU max PA

; From: kra...@redhat.com > Sent: Thursday, March 30, 2023 5:03 PM > To: Ni, Ray > Cc: devel@edk2.groups.io; Tom Lendacky > Subject: Re: [edk2-devel] [PATCH 0/6] Substract TME-MK KEY_ID_BITS from CPU > max PA > > Hi, > > > For tdx, the actual max physical address bits

Re: [edk2-devel] [PATCH 6/9] MdeModulePkg: Add UefiCpuPkg.dec to pass DependencyCheck

e can loosen the dependency for the DxeIpl because it's really arch specific? Thanks, Ray > -Original Message- > From: Tan, Dun > Sent: Tuesday, March 28, 2023 10:43 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Ni, Ray ; Wang, > Jian J > Subject: [PATCH 6/9] M

Re: [edk2-devel] [PATCH 9/9] MdeModulePkg/DxeIpl: Refinement to the code to set PageTable as RO

> + MapAttribute.Uint64= 0; [Ray] Can you add "MapAttribute.Bits.ReadWrite = 0"? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#102238): https://edk2.groups.io/g/devel/message/102238 Mute This Topic: https://groups.io/mt/97897987/216

Re: [edk2-devel] [PATCH 8/9] MdeModulePkg/DxeIpl: Remove duplicated code to enable NX

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Tuesday, March 28, 2023 10:43 AM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Gao, Liming ; > Ni, Ray ; Wang, Jian > J > Subject: [PATCH 8/9] MdeModulePkg/DxeIpl: Remove duplicated code to ena

Re: [edk2-devel] [PATCH 7/9] MdeModulePkg/DxeIpl: Create page table by CpuPageTableLib

Thanks for the cleanup: 166(+) 679(-). 2 minor comments: > UINTN > CreateIdentityMappingPageTables ( > + IN BOOLEAN Is32BitPageTable, [Ray] Can you change the parameter name as Is64bitPageTable? Because 64bit is the trend, I don't like to say future is "FALSE". > + MapAttribute

Re: [edk2-devel] [RFT PATCH v2 4/6] UefiCpuPkg/CpuExceptionHandlerLib: Remove needless runtime fixups

diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/Xcode5ExceptionH= andlerAsm.nasm b/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ExceptionHan= dlerAsm.nasm similarity index 92% rename from UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/Xcode5ExceptionHa= ndlerAsm.nasm rename to UefiCpuPk

Re: [edk2-devel] [RFT PATCH v2 4/6] UefiCpuPkg/CpuExceptionHandlerLib: Remove needless runtime fixups

Reviewed-by: Ray Ni -Original Message- From: devel@edk2.groups.io On Behalf Of Ard Biesheuvel Sent: Friday, March 31, 2023 5:21 AM To: devel@edk2.groups.io Cc: Ard Biesheuvel ; Ni; Ni, Ray ; Andrew Fish ; Kinney, Michael D ; Liu, Zhiguang ; Rebecca Cran ; Tom Lendacky Subject: [edk2

Re: [edk2-devel] [RFT PATCH v2 3/6] UefiCpuPkg/CpuExceptionHandlerLib: Use single SEC/PEI version

limitation in the SecPeiCpuExceptionHandlerLib.inf file. Thanks, Ray -Original Message- From: Ard Biesheuvel Sent: Friday, March 31, 2023 5:21 AM To: devel@edk2.groups.io Cc: Ard Biesheuvel ; Ni; Ni, Ray ; Andrew Fish ; Kinney, Michael D ; Liu, Zhiguang ; Rebecca Cran ; Tom Lendack

Re: [edk2-devel] [RFT PATCH v2 6/6] UefiCpuPkg/CpuExceptionHandlerLib: Drop special XCODE5 version

Reviewed-by: Ray Ni -Original Message- From: devel@edk2.groups.io On Behalf Of Ard Biesheuvel Sent: Friday, March 31, 2023 5:21 AM To: devel@edk2.groups.io Cc: Ard Biesheuvel ; Ni; Ni, Ray ; Andrew Fish ; Kinney, Michael D ; Liu, Zhiguang ; Rebecca Cran ; Tom Lendacky Subject: [edk2

Re: [edk2-devel] Is Xcode5ExceptionHandlerAsm.nasm still needed?

I am afraid they are not template code. That means if nx is set for data section, they can not be executed. thanks, ray From: Ard Biesheuvel Sent: Thursday, March 30, 2023 7:47:03 PM To: devel@edk2.groups.io ; Ni, Ray ; Rebecca Cran Cc: Andrew Fish ; Kinney

[edk2-devel] Is Xcode5ExceptionHandlerAsm.nasm still needed?

Andrew, In UefiCpuPkg\Library\CpuExceptionHandlerLib\X64\, there are two nasm files: ExceptionHandlerAsm.nasm and the other XCODE version. The major diff between the two is the second operand in "mov rax, ASM_PFX(CommonInterruptEntry)" is patched at runtime by code, instead of relying on linker

Re: [edk2-devel] [PATCH 0/6] Substract TME-MK KEY_ID_BITS from CPU max PA

ec-1.4.pdf > -Original Message- > From: devel@edk2.groups.io On Behalf Of Gerd > Hoffmann > Sent: Thursday, March 30, 2023 3:25 PM > To: Ni, Ray > Cc: Tom Lendacky ; devel@edk2.groups.io > Subject: Re: [edk2-devel] [PATCH 0/6] Substract TME-MK KEY_ID_BITS from > CP

Re: [edk2-devel] [PATCH v2] IntelFsp2Pkg: LoadMicrocodeDefault() causing unnecessary delay.

> > + mov eax, 1 > > + cpuid > > + mov ecx, MSR_IA32_BIOS_SIGN_ID > > + rdmsr ; Get current microcode signature > > + xor eax, eax > > + test edx, edx > > + jnz Exit2 > 1. SDM uses following assembly to read current microcode signature. Exampl

Re: [edk2-devel] [PATCH 0/6] Substract TME-MK KEY_ID_BITS from CPU max PA

Tom, I would assume this won't break any AMD system because the CPUID bit doesn't declare this feature. Gerd, This is needed by Intel platform for TME-MK. Can you help to analyze if it has any impact to OVMF? I assume no. Thanks, Ray From: devel@edk2.groups.io On Behalf Of Ni

Re: [edk2-devel] [Patch 1/1] PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe: PcdRtcDefaultYear bounds

Reviewed-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > D Kinney > Sent: Thursday, March 30, 2023 6:37 AM > To: devel@edk2.groups.io > Cc: Ni, Ray > Subject: [edk2-devel] [Patch 1/1] > PcAtChipsetPkg/PcatRealTimeClockRunti

Re: [edk2-devel] [PATCH 0/6] Substract TME-MK KEY_ID_BITS from CPU max PA

Mike, Eric, Ca you kindly review? thanks, ray From: devel@edk2.groups.io on behalf of Ni, Ray Sent: Wednesday, March 22, 2023 7:56:44 AM To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH 0/6] Substract TME-MK KEY_ID_BITS from CPU max PA Ray Ni (6

Re: [edk2-devel] [PATCH 0/6] Substract TME-MK KEY_ID_BITS from CPU max PA

Gerd, Tom, Can you please review this patch series? thanks, ray From: devel@edk2.groups.io on behalf of Ni, Ray Sent: Wednesday, March 22, 2023 7:56:44 AM To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH 0/6] Substract TME-MK KEY_ID_BITS from CPU max PA

Re: [edk2-devel] [PATCH v2 1/1] UefiCpuPkg/PiSmmCpuDxeSmm: fix format string

Reviewed-by: Ray Ni > -Original Message- > From: Gerd Hoffmann > Sent: Monday, March 27, 2023 4:02 PM > To: devel@edk2.groups.io > Cc: Gerd Hoffmann ; Dong, Eric ; > Kumar, Rahul R ; Oliver Steffen > ; Pawel Polawski ; Ni, Ray > ; Laszlo Ersek > Subject

Re: [edk2-devel] [Patch 1/1] PcAtChipsetPkg: Add PCD for RTC default year

I see. Thanks for explanation. Reviewed-by: Ray Ni > -Original Message- > From: Kinney, Michael D > Sent: Monday, March 27, 2023 1:06 AM > To: Ni, Ray ; devel@edk2.groups.io > Cc: Kinney, Michael D > Subject: RE: [Patch 1/1] PcAtChipsetPkg: Add PCD for RTC defaul

Re: [edk2-devel] [Patch 1/1] PcAtChipsetPkg: Add PCD for RTC default year

Kinney, Michael D > Sent: Sunday, March 26, 2023 11:23 AM > To: devel@edk2.groups.io > Cc: Ni, Ray > Subject: [Patch 1/1] PcAtChipsetPkg: Add PCD for RTC default year > > Add PcdRtcDefaultYear to specify the default year to use when > the RTC is in an invalid state. Mak

Re: [edk2-devel] [Patch V6 06/22] UefiCpuPkg/CpuPageTableLib: Fix issue when splitting leaf entry

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Friday, March 24, 2023 4:52 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann > Subject: [Patch V6 06/22] UefiCpuPkg/CpuPageTableLib: Fix issue when &

Re: [edk2-devel] [Patch V6 04/22] UefiCpuPkg/CpuPageTableLib: Fix the non-1:1 mapping issue

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Friday, March 24, 2023 4:52 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann > Subject: [Patch V6 04/22] UefiCpuPkg/CpuPageTableLib: Fix the non-1:1 &g

Re: [edk2-devel] [PATCH 1/1] UefiCpuPkg/PiSmmCpuDxeSmm: fix format string

content in 64bit mode. But it may print random value in the stack as high-32 bit in 32bit mode. @Kinney, Michael D, any comments? Thanks, Ray > -Original Message- > From: Gerd Hoffmann > Sent: Friday, March 24, 2023 9:42 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; G

Re: [edk2-devel] [Patch V5 19/22] UefiCpuPkg: Combine branch for non-present and leaf ParentEntry

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Friday, March 24, 2023 2:00 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann > Subject: [Patch V5 19/22] UefiCpuPkg: Combine branch for non-present a

Re: [edk2-devel] [Patch V5 20/22] UefiCpuPkg/CpuPageTableLib: Enable PAE paging

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Friday, March 24, 2023 2:00 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann > Subject: [Patch V5 20/22] UefiCpuPkg/CpuPageTableLib: Enable P

Re: [edk2-devel] [Patch V5 14/22] UefiCpuPkg/CpuPageTableLib: Add OUTPUT IsModified parameter.

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Friday, March 24, 2023 2:00 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann > Subject: [Patch V5 14/22] UefiCpuPkg/CpuPageTableLib: Add OUTPUT > IsModi

Re: [edk2-devel] [Patch V5 12/22] UefiCpuPkg/CpuPageTableLib:Modify RandomTest to check Mask/Attr

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Friday, March 24, 2023 2:00 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann ; > Liu, Zhiguang > Subject: [Patch V5 12/22] UefiCpuPkg/CpuPageTableLi

Re: [edk2-devel] [Patch V5 11/22] UefiCpuPkg/CpuPageTableLib: Add LastMapEntry pointer

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Friday, March 24, 2023 2:00 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann > Subject: [Patch V5 11/22] UefiCpuPkg/CpuPageTableLib: Add LastMapEnt

Re: [edk2-devel] [Patch V5 09/22] UefiCpuPkg/CpuPageTableLib: Add manual test to check Mask and Attr

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Friday, March 24, 2023 2:00 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann > Subject: [Patch V5 09/22] UefiCpuPkg/CpuPageTableLib: Add manual test to

Re: [edk2-devel] [Patch V5 08/22] UefiCpuPkg/CpuPageTableLib:Add check for Mask and Attr

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Friday, March 24, 2023 2:00 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann > Subject: [Patch V5 08/22] UefiCpuPkg/CpuPageTableLib:Add check for Mas

Re: [edk2-devel] [Patch V4 06/21] UefiCpuPkg/CpuPageTableLib: Fix issue when splitting leaf entry

i > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Thursday, March 23, 2023 8:35 PM > To: Tan, Dun ; devel@edk2.groups.io > Cc: Dong, Eric ; Kumar, Rahul R > ; Gerd Hoffmann > Subject: Re: [edk2-devel] [Patch V4 06/21] UefiCpuPkg/CpuPageT

Re: [edk2-devel] [Patch V4 21/21] UefiCpuPkg/CpuPageTableLib: Reduce the number of random tests

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Thursday, March 23, 2023 3:41 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann > Subject: [Patch V4 21/21] UefiCpuPkg/CpuPageTableLib: Reduce the num

Re: [edk2-devel] [Patch V4 19/21] UefiCpuPkg/CpuPageTableLib: Enable PAE paging

Overall logics look good to me. 2 minor comments. > -#define IA32_PE_BASE_ADDRESS_MASK_40 0xFF000ull > -#define IA32_PE_BASE_ADDRESS_MASK_39 0xFE000ull > +#define IA32_PE_BASE_ADDRESS_MASK_40 0xFF000ull > +#define IA32_PE_BASE_ADDRESS_MASK_39 0xFE0

Re: [edk2-devel] [Patch V4 18/21] UefiCpuPkg: Combine branch for non-present and leaf ParentEntry

> -// > -// The parent entry is CR3 or PML5E/PML4E/PDPTE/PDE. > +// When ParentPagingEntry is non-present, parent entry is CR3 or > PML5E/PML4E/PDPTE/PDE. > // It does NOT point to an existing page directory. > +// When ParentPagingEntry is present, parent entry is leaf PDPTE_1

Re: [edk2-devel] [Patch V4 17/21] UefiCpuPkg/CpuPageTableLib: Add check for page table creation

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Thursday, March 23, 2023 3:41 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann > Subject: [Patch V4 17/21] UefiCpuPkg/CpuPageTableLib: Add check for

Re: [edk2-devel] [Patch V4 20/21] UefiCpuPkg/CpuPageTableLib: Add RandomTest for PAE paging

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Thursday, March 23, 2023 3:41 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann > Subject: [Patch V4 20/21] UefiCpuPkg/CpuPageTableLib: Add RandomTest >

Re: [edk2-devel] [Patch V4 15/21] UefiCpuPkg: Fix IA32 build failure in CpuPageTableLib.inf

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Thursday, March 23, 2023 3:41 PM > To: devel@edk2.groups.io > Cc: Liu, Zhiguang ; Dong, Eric > ; Ni, Ray ; Kumar, Rahul R > > Subject: [Patch V4 15/21] UefiCpuPkg: Fix IA32 build failure

Re: [edk2-devel] [Patch V4 14/21] UefiCpuPkg/CpuPageTableLib: Modify RandomTest to check IsModified

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Thursday, March 23, 2023 3:41 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann ; > Liu, Zhiguang > Subject: [Patch V4 14/21] UefiCpuPkg/CpuPageTableLib

Re: [edk2-devel] [Patch V4 13/21] UefiCpuPkg/CpuPageTableLib: Add OUTPUT IsModified parameter.

> @@ -290,7 +291,8 @@ PageTableLibMapInLevel ( >IN UINT64 Length, >IN UINT64 Offset, >IN IA32_MAP_ATTRIBUTE *Attribute, > - IN IA32_MAP_ATTRIBUTE *Mask > + IN IA32_MAP_ATTRIBUTE *Mask, > + OUTBOOLEAN *IsModified >)

Re: [edk2-devel] [Patch V4 11/21] UefiCpuPkg/CpuPageTableLib:Modify RandomTest to check Mask/Attr

> -Original Message- > From: Tan, Dun > Sent: Thursday, March 23, 2023 3:41 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann ; > Liu, Zhiguang > Subject: [Patch V4 11/21] UefiCpuPkg/CpuPageTableLib:Modify RandomT

Re: [edk2-devel] [Patch V4 10/21] UefiCpuPkg/CpuPageTableLib:Modify RandomBoolean() in RandomTest

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Thursday, March 23, 2023 3:41 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann > Subject: [Patch V4 10/21] UefiCpuPkg/CpuPageTableLib:Modify > Rando

Re: [edk2-devel] [Patch V4 09/21] UefiCpuPkg/CpuPageTableLib: Add manual test to check Mask and Attr

> + PageTableBufferSize = 0; > + PageTable = 0; > + Buffer= NULL; > + MapAttribute.Uint64 = 0; > + MapAttribute.Bits.Present = 1; > + MapMask.Uint64= 0; > + MapMask.Bits.Present = 1; > + // > + // Create Page table to cover [

Re: [edk2-devel] [Patch V4 08/21] UefiCpuPkg/CpuPageTableLib:Add check for Mask and Attr

The commit message is very detailed. But the function header comments are not. Can you please update the function header comments to add 4 lines of @retval RETURN_INVALID_PARAMETER, each line describes one invalid case. It's ok to have multiple lines starting with @retval RETURN_INVALID_PARAMETER

Re: [edk2-devel] [Patch V4 07/21] UefiCpuPkg/MpInitLib: Add code to initialize MapMask

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Thursday, March 23, 2023 3:41 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann > Subject: [Patch V4 07/21] UefiCpuPkg/MpInitLib: Add code to initial

Re: [edk2-devel] [Patch V4 06/21] UefiCpuPkg/CpuPageTableLib: Fix issue when splitting leaf entry

> + ParentPagingEntry->Uint64 = ((UINTN)(VOID *)PagingEntry) | > (ParentPagingEntry->Uint64 & (~IA32_PE_BASE_ADDRESS_MASK_40)); In this branch, ParentPagingEntry is a leaf entry covering 2M or 1G physical address range. Then, why not use IA32_PE_BASE_ADDRESS_MASK_39? Because for the two type

Re: [edk2-devel] [Patch V4 05/21] UefiCpuPkg/CpuPageTableLib:Clear PageSize bit(Bit7) for non-leaf

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Thursday, March 23, 2023 3:41 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann > Subject: [Patch V4 05/21] UefiCpuPkg/CpuPageTableLib:Clear PageSize >

Re: [edk2-devel] [Patch V4 04/21] UefiCpuPkg/CpuPageTableLib: Fix the non-1:1 mapping issue

> + PhysicalAddrInEntry = > IA32_MAP_ATTRIBUTE_PAGE_TABLE_BASE_ADDRESS (&PleBAttribute) + > PagingEntryIndex * RegionLength; Overall logic looks good to me. But above code might fail to build in IA32 build due to UINT32 * UINT64. > + PhysicalAddrInAttr = > (IA32_MAP_ATTRIBUTE_PAGE_TABL

Re: [edk2-devel] [Patch V4 03/21] UefiCpuPkg/CpuPageTableLib:Initialize some LocalVariable at beginning

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Thursday, March 23, 2023 3:41 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann > Subject: [Patch V4 03/21] UefiCpuPkg/CpuPageTableLib:Initialize so

Re: [edk2-devel] [Patch V4 02/21] UefiCpuPkg/CpuPageTableLib: Add check for input Length

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Thursday, March 23, 2023 3:41 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann > Subject: [Patch V4 02/21] UefiCpuPkg/CpuPageTableLib: Add check for in

Re: [edk2-devel] [PATCH] UefiCpuPkg: Solve that stack top address is not mapped in pagetable

Reviewed-by: Ray Ni > -Original Message- > From: Xie, Yuanhao > Sent: Tuesday, March 21, 2023 3:30 PM > To: devel@edk2.groups.io > Cc: Dong, Guo ; Ni, Ray ; Rhodes, > Sean ; Lu, James ; Guo, Gua > ; Kuo, Ted > Subject: [PATCH] UefiCpuPkg: Solve that stack top

Re: [edk2-devel] [PATCH 1/1] UefiCpuPkg/MpInitLib: fix apic mode for cpu hotplug

Thanks for confirming that. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Gerd > Hoffmann > Sent: Tuesday, March 21, 2023 7:54 PM > To: Ni, Ray > Cc: devel@edk2.groups.io; Pawel Polawski ; Kumar, > Rahul R ; Oliver Steffen ; > Dong, Eric &g

Re: [edk2-devel] [PATCH v2 6/6] UefiCpuPkg/MtrrLib: use new IS_POW2() macro.

; Gerd Hoffmann ; Yao, Jiewen ; Wang, Jian J ; Ard Biesheuvel ; Justen, Jordan L ; Wu, Hao A ; Liu, Zhiguang ; Ni, Ray ; Xu, Min M ; Oliver Steffen Subject: [PATCH v2 6/6] UefiCpuPkg/MtrrLib: use new IS_POW2() macro. Drop MtrrLibIsPowerOfTwo function, use the new IS_POW2() macro instead. The

Re: [edk2-devel] [PATCH 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: fix error handling

Just found "if (!Buffer)" doesn't follow EDK2 coding style. I changed to "if (Buffer == NULL) {" in final merge PR. > -Original Message- > From: Gerd Hoffmann > Sent: Friday, March 10, 2023 8:49 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Oliver

Re: [edk2-devel] [PATCH 3/5] MdePkg/Base.h: Introduce various alignment-related macros

== 0); } From: Kinney, Michael D Sent: Wednesday, March 22, 2023 6:51 AM To: Marvin Häuser Cc: Gerd Hoffmann ; devel@edk2.groups.io; Ard Biesheuvel ; Wang, Jian J ; Yao, Jiewen ; James Bottomley ; Michael Roth ; Wu, Hao A ; Oliver Steffen ; Xu, Min M ; Gao, Liming ; Ni, Ray ; Tom Lendacky ; A

<    2   3   4   5   6   7   8   9   10   11   >