Re: [edk2-devel] [PATCH v4 7/8] PciHostBridgeDxe: Extend service to get base addresses before allocation

2022-02-14 Thread Ojeda Leon, Nicolas via groups.io
>> > Hmm, so you are hiding the #define here to avoid updating >> > Protocol/PciHostBridgeResourceAllocation.h ... >> > >> > I suspect if this can't be implemented in the pci enumerator alone there >> > is just no way around actually extending uefi protocols. But it's also >> > not fully clear

Re: [edk2-devel] [PATCH v4 7/8] PciHostBridgeDxe: Extend service to get base addresses before allocation

2022-02-14 Thread Gerd Hoffmann
On Fri, Feb 04, 2022 at 09:17:48AM +, Ojeda Leon, Nicolas wrote: > Hi Gerd, > > > Hmm, so you are hiding the #define here to avoid updating > > Protocol/PciHostBridgeResourceAllocation.h ... > > > > I suspect if this can't be implemented in the pci enumerator alone there is > > just no

Re: [edk2-devel] [PATCH v4 7/8] PciHostBridgeDxe: Extend service to get base addresses before allocation

2022-02-04 Thread Ojeda Leon, Nicolas via groups.io
Hi Gerd, > Hmm, so you are hiding the #define here to avoid updating > Protocol/PciHostBridgeResourceAllocation.h ... > > I suspect if this can't be implemented in the pci enumerator alone there is > just no way around actually extending uefi protocols. But it's also not > fully clear to me

Re: [edk2-devel] [PATCH v4 7/8] PciHostBridgeDxe: Extend service to get base addresses before allocation

2022-02-04 Thread Ojeda Leon, Nicolas via groups.io
Hi Gerd, > Also: Maybe split this series into two? One for the host-provided bridges, > and another for the pre-populated bars? So the former can already be merged > while the later is still sorted? Is it already possible for someone to merge the first 5 patches or should I submit a new

Re: [edk2-devel] [PATCH v4 7/8] PciHostBridgeDxe: Extend service to get base addresses before allocation

2022-02-04 Thread Gerd Hoffmann
Hi, > -if (ResStatus == EFI_RESOURCE_SATISFIED) { > +if ((ResStatus == EFI_RESOURCE_SATISFIED) || > +(ResStatus == PCI_RESOURCE_PARTIAL)) > +{ > +++ b/MdeModulePkg/Include/Library/PciResourceLib.h > @@ -0,0 +1,20 @@ > +/** @file > + Pci resource library consumed by

[edk2-devel] [PATCH v4 7/8] PciHostBridgeDxe: Extend service to get base addresses before allocation

2022-02-03 Thread Ojeda Leon, Nicolas via groups.io
Enhance the PCI Resource Allocation services to include a new state in which only the base address of each root bridge is set. This new, partial state is used in conjunction with GetProposedResources to retrieve the Base Addresses of the resources before the allocation takes place, and is reached