Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-04-07 Thread Laszlo Ersek
On 04/06/20 12:11, Ard Biesheuvel wrote: > On 4/5/20 8:39 AM, Sean via groups.io wrote: >> Platform and Core CI patches are ready for review.  I have 14 commits >> here. >> https://github.com/spbrogan/edk2/tree/PlatformAndCoreCIForOvmfArmVirtEmulatorPackages >> >> >> This adds support for

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-04-06 Thread Ard Biesheuvel
On 4/5/20 8:39 AM, Sean via groups.io wrote: Platform and Core CI patches are ready for review.  I have 14 commits here. https://github.com/spbrogan/edk2/tree/PlatformAndCoreCIForOvmfArmVirtEmulatorPackages This adds support for "Platform CI" for ArmVirtPkg, OvmfPkg, and EmulatorPkg. Each

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-04-05 Thread Sean via groups.io
Platform and Core CI patches are ready for review.  I have 14 commits here. https://github.com/spbrogan/edk2/tree/PlatformAndCoreCIForOvmfArmVirtEmulatorPackages This adds support for "Platform CI" for ArmVirtPkg, OvmfPkg, and EmulatorPkg. Each readme has live status and links to the builds as

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-31 Thread Ard Biesheuvel
On 3/31/20 6:26 PM, Sean via Groups.Io wrote: On Mon, Mar 30, 2020 at 11:41 PM, Ard Biesheuvel wrote: Not sure I follow. Which command line are we talking about? @Ard - In this Platform CI, ArmVirt is building and running AARCH64 but not ARM 32bit.  Would it be valuable to build for ARM

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-31 Thread Sean via Groups.Io
On Mon, Mar 30, 2020 at 11:41 PM, Ard Biesheuvel wrote: > > Not sure I follow. Which command line are we talking about? @Ard - In this Platform CI, ArmVirt is building and running AARCH64 but not ARM 32bit.  Would it be valuable to build for ARM too? I prototyped it but want to make sure I am

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-31 Thread Laszlo Ersek
Mike > >> -Original Message- >> From: devel@edk2.groups.io On >> Behalf Of Laszlo Ersek >> Sent: Monday, March 30, 2020 2:11 PM >> To: devel@edk2.groups.io; ard.biesheu...@linaro.org; Sean >> Brogan >> Subject: Re: [edk2-devel] [PATCH] .azurepipelines

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-31 Thread Laszlo Ersek
On 03/30/20 23:22, Ard Biesheuvel wrote: > On Mon, 30 Mar 2020 at 22:56, Laszlo Ersek wrote: >> >> On 03/30/20 19:44, Ard Biesheuvel wrote: >>> On Mon, 30 Mar 2020 at 19:11, Sean via Groups.Io >>> wrote: On Mon, Mar 30, 2020 at 10:04 AM, Ard Biesheuvel wrote: Is there any way

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-31 Thread Ard Biesheuvel
On Tue, 31 Mar 2020 at 08:31, Sean via Groups.Io wrote: > > @Ard - > pflash change: https://github.com/spbrogan/edk2/pull/12 > > Logging change - I actually switched OVMF to use stdio since the log is > captured either way and now it shows up in the web log output. >

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-31 Thread Sean via Groups.Io
@Ard - pflash change: https://github.com/spbrogan/edk2/pull/12 Logging change - I actually switched OVMF to use stdio since the log is captured either way and now it shows up in the web log output. https://github.com/spbrogan/edk2/pull/13 Do you have instructions for the cmdline for Qemu for

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-30 Thread Michael D Kinney
From: sean.brogan via [] Sent: Monday, March 30, 2020 2:42 PM To: Kinney, Michael D ; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg @Rebecca - Agree. I need to package up a newer version. I have treated this as lower priority

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-30 Thread Rebecca Cran
On 3/30/20 3:42 PM, Sean via Groups.Io wrote: @Rebecca - Agree.  I need to package up a newer version.  I have treated this as lower priority.  Is there a feature you need or just best practices on keeping current? Just best practices around keeping current. I don't think it's a problem

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-30 Thread Ard Biesheuvel
On Mon, 30 Mar 2020 at 23:42, Sean via Groups.Io wrote: > > @Rebecca - Agree. I need to package up a newer version. I have treated this > as lower priority. Is there a feature you need or just best practices on > keeping current? > @Ard - Padding in python is easy. I just need to understand

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-30 Thread Sean via Groups.Io
@Rebecca - Agree.  I need to package up a newer version.  I have treated this as lower priority.  Is there a feature you need or just best practices on keeping current? @Ard - Padding in python is easy.  I just need to understand the requirements. @Mike - I would like to get to read/write

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-30 Thread Michael D Kinney
h 30, 2020 2:11 PM > To: devel@edk2.groups.io; ard.biesheu...@linaro.org; Sean > Brogan > Subject: Re: [edk2-devel] [PATCH] .azurepipelines: Enable > CI for OvmfPkg and EmulatorPkg > > On 03/30/20 08:07, Ard Biesheuvel wrote: > > On Mon, 30 Mar 2020 at 01:16, Sean via

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-30 Thread Ard Biesheuvel
On Mon, 30 Mar 2020 at 22:56, Laszlo Ersek wrote: > > On 03/30/20 19:44, Ard Biesheuvel wrote: > > On Mon, 30 Mar 2020 at 19:11, Sean via Groups.Io > > wrote: > >> > >> On Mon, Mar 30, 2020 at 10:04 AM, Ard Biesheuvel wrote: > >> > >> Is there any way I could contribute ArmVirtQemu to this? Or

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-30 Thread Rebecca Cran
On 3/30/20 3:03 PM, Sean via Groups.Io wrote: Laszlo/Ard - I have cleaned up git history and pushed to https://github.com/spbrogan/edk2 master. If you want you can create a PR against that branch and it should kick OVMF, Emulator, and ArmVirt to build and run. Looking for feedback. The

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-30 Thread Laszlo Ersek
On 03/30/20 08:07, Ard Biesheuvel wrote: > On Mon, 30 Mar 2020 at 01:16, Sean via Groups.Io > wrote: >> >> Ard/Laszlo or anyone familiar with QEMU. >> >> I read up on the ovmf readme and the qemu wiki but still have a few issues i >> am hoping for quick/easy answers. >> >> 1. How do i

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-30 Thread Sean via Groups.Io
Laszlo/Ard - I have cleaned up git history and pushed to https://github.com/spbrogan/edk2 master. If you want you can create a PR against that branch and it should kick OVMF, Emulator, and ArmVirt to build and run. Looking for feedback. @Laszlo - I followed Ard's parameters but feel free to

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-30 Thread Laszlo Ersek
On 03/30/20 19:44, Ard Biesheuvel wrote: > On Mon, 30 Mar 2020 at 19:11, Sean via Groups.Io > wrote: >> >> On Mon, Mar 30, 2020 at 10:04 AM, Ard Biesheuvel wrote: >> >> Is there any way I could contribute ArmVirtQemu to this? Or would it >> be easier if I provided comments/instructions? >> >>

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-30 Thread Ard Biesheuvel
On Mon, 30 Mar 2020 at 21:07, Sean via Groups.Io wrote: > > > > On Mon, Mar 30, 2020 at 10:44 AM, Ard Biesheuvel wrote: > > Thanks. But can I get these actions to trigger from my branch as well? > Or do I need special powers for that? > > Right now it requires manually running so it requires

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-30 Thread Sean via Groups.Io
On Mon, Mar 30, 2020 at 10:44 AM, Ard Biesheuvel wrote: > > Thanks. But can I get these actions to trigger from my branch as well? > Or do I need special powers for that? Right now it requires manually running so it requires "special powers". :) I am happy to get this into a branch that you can

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-30 Thread Ard Biesheuvel
On Mon, 30 Mar 2020 at 19:11, Sean via Groups.Io wrote: > > On Mon, Mar 30, 2020 at 10:04 AM, Ard Biesheuvel wrote: > > Is there any way I could contribute ArmVirtQemu to this? Or would it > be easier if I provided comments/instructions? > > Either way. > Any instructions you provide would be

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-30 Thread Sean via Groups.Io
On Mon, Mar 30, 2020 at 10:04 AM, Ard Biesheuvel wrote: > > Is there any way I could contribute ArmVirtQemu to this? Or would it > be easier if I provided comments/instructions? Either way. Any instructions you provide would be great.  I was going to hack something up for feedback but happy

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-30 Thread Ard Biesheuvel
On Mon, 30 Mar 2020 at 19:01, Sean via Groups.Io wrote: > > On Mon, Mar 30, 2020 at 02:36 AM, Ard Biesheuvel wrote: > > It should be trivial to extend this to ARM, using TCG emulation. > > One question though: what happens if the boot does not make it to the > shell, and crashes for some reason?

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-30 Thread Sean via Groups.Io
On Mon, Mar 30, 2020 at 02:36 AM, Ard Biesheuvel wrote: > > It should be trivial to extend this to ARM, using TCG emulation. > > One question though: what happens if the boot does not make it to the > shell, and crashes for some reason? The QEMU process will hang, so I'd > assume some kind of

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-30 Thread Ard Biesheuvel
On Mon, 30 Mar 2020 at 11:31, Sean via Groups.Io wrote: > > Thanks. I was missing the "-s" and Andrew you solution worked for the > filesystem. > > OVMF: Windows builds and Linux builds and boot to shell. IA32, X64 and > IA32x64 - >

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-30 Thread Sean via Groups.Io
Thanks.  I was missing the "-s" and Andrew you solution worked for the filesystem. OVMF: Windows builds and Linux builds and boot to shell. IA32, X64 and IA32x64 - https://dev.azure.com/tianocore/edk2-ci-play/_build/results?buildId=4950=results Emulator: Windows and linux builds and boots to

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-30 Thread Ard Biesheuvel
On Mon, 30 Mar 2020 at 01:16, Sean via Groups.Io wrote: > > Ard/Laszlo or anyone familiar with QEMU. > > I read up on the ovmf readme and the qemu wiki but still have a few issues i > am hoping for quick/easy answers. > > 1. How do i programmatically exit the emulator. Seems like uefi shell >

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-29 Thread Andrew Fish via Groups.Io
> On Mar 29, 2020, at 4:16 PM, Sean via Groups.Io > wrote: > > Ard/Laszlo or anyone familiar with QEMU. > > I read up on the ovmf readme and the qemu wiki but still have a few issues i > am hoping for quick/easy answers. > > 1. How do i programmatically exit the emulator. Seems like

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-29 Thread Sean via Groups.Io
Ard/Laszlo or anyone familiar with QEMU. I read up on the ovmf readme and the qemu wiki but still have a few issues i am hoping for quick/easy answers. 1. How do i programmatically exit the emulator.   Seems like uefi shell > reset just reboots.  Other ideas? 2. Is there an easy way to map a

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-29 Thread Ard Biesheuvel
On Sat, 28 Mar 2020 at 22:47, Sean via Groups.Io wrote: > > Ard, > I agree. How would we do this with AARCH64? I don't believe azure devops > pipelines has a native AARCH64 platform available. I briefly looked over > ArmVirtPkg but not sure where to start. OVMF readme only talks about >

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-28 Thread Sean via Groups.Io
Ard, I agree.  How would we do this with AARCH64?  I don't believe azure devops pipelines has a native AARCH64 platform available.  I briefly looked over ArmVirtPkg but not sure where to start. OVMF readme only talks about ia32/x64.  I could also see a scenario for a self hosted agent that is

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-28 Thread Ard Biesheuvel
On Sat, 28 Mar 2020 at 20:29, Sean via Groups.Io wrote: > > Added support for EmulatorPkg running to UEFI shell. > Segmentation fault on GCC / Ubuntu x64. Works on Windows. > > Could very easily be user error. > https://bugzilla.tianocore.org/show_bug.cgi?id=2639 > > Laszlo - can you point me to

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-28 Thread Sean via Groups.Io
Added support for EmulatorPkg running to UEFI shell. Segmentation fault on GCC / Ubuntu x64.  Works on Windows. Could very easily be user error. https://bugzilla.tianocore.org/show_bug.cgi?id=2639 Laszlo - can you point me to any docs, scripts, examples of how i would do the same thing with

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-27 Thread Sean via Groups.Io
"Stuart" gives the system a lot of structure and flexibility.  It lets us maintain the build process consistently in a cross platform way and allows platforms to use python instead of shell scripting.  This takes advantage of our investments in dependency management, optimized submodule

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-27 Thread Rebecca Cran
On 3/27/20 8:29 PM, Sean via Groups.Io wrote: Feedback wanted.   Happy to add more if there is some agreement that you like this direction. I see the OVMF build is running for example: /opt/hostedtoolcache/Python/3.8.2/x64/bin/stuart_build -c OvmfPkg/PlatformBuild.py TOOL_CHAIN_TAG=GCC5

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-27 Thread Sean via Groups.Io
There are two parts of this I think should be discussed. 1. Core-Ci for emulator, ovmf, armvirt packages. a. I think there is some value here for those package maintainers.  The core ci does spell checks, char encoding checks, lib class declaration, etc.  Those seem valuable to help keep the

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-27 Thread Laszlo Ersek
On 03/27/20 15:36, Laszlo Ersek wrote: > (+Phil, +Anthony) > > On 03/26/20 09:43, Ard Biesheuvel wrote: >> (+ Laszlo) >> >> On Thu, 26 Mar 2020 at 08:04, Zhang, Shenglei >> wrote: >>> >>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2570 >>> OvmfPkg and EmulatorPkg are mostly used by the

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-27 Thread Laszlo Ersek
(+Phil, +Anthony) On 03/26/20 09:43, Ard Biesheuvel wrote: > (+ Laszlo) > > On Thu, 26 Mar 2020 at 08:04, Zhang, Shenglei > wrote: >> >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2570 >> OvmfPkg and EmulatorPkg are mostly used by the developers, so add >> them to target list. >> >>

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-26 Thread Zhang, Shenglei
ng > Subject: Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg > and EmulatorPkg > > (+ Laszlo) > > On Thu, 26 Mar 2020 at 08:04, Zhang, Shenglei > wrote: > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2570 > > OvmfPkg and EmulatorP

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-26 Thread Ard Biesheuvel
(+ Laszlo) On Thu, 26 Mar 2020 at 08:04, Zhang, Shenglei wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2570 > OvmfPkg and EmulatorPkg are mostly used by the developers, so add > them to target list. > > Cc: Sean Brogan > Cc: Bret Barkelew > Cc: Michael D Kinney > Cc: Liming

Re: [EXTERNAL] Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-26 Thread Bret Barkelew via Groups.Io
, Michael D ; Liming Gao Subject: [EXTERNAL] Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg On 3/26/20 1:04 AM, Zhang, Shenglei wrote: > Build.Targets: 'DEBUG,RELEASE,NO-TARGET' > + TARGET_OVMF: > +Build.Pkgs:

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-26 Thread Rebecca Cran
On 3/26/20 1:04 AM, Zhang, Shenglei wrote: Build.Targets: 'DEBUG,RELEASE,NO-TARGET' + TARGET_OVMF: +Build.Pkgs: 'OvmfPkg' +Build.Targets: 'DEBUG,RELEASE,NO-TARGET' + TARGET_EMULATOR: +Build.Pkgs: 'EmulatorPkg' +Build.Targets: