Re: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib

2024-04-26 Thread Lendacky, Thomas via groups.io
On 4/25/24 01:58, Gerd Hoffmann wrote: Hi, That means the SMMRevId is 0_xx64h for AMD64 processor. But I am not sure what the value is for AMD32 processor. Maybe 0 according to the OVMF logic. The smm emulation in the linux kernel uses 0 and 0x64. But, I am very suspicious about the

Re: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib

2024-04-26 Thread Ni, Ray
; Abner Chang ; Tom Lendacky Subject: Re: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib Hi, > That means the SMMRevId is 0_xx64h for AMD64 processor. But I am not > sure what the value is for AMD32 processor. Maybe 0 according to the > OVMF logic. The smm emulation in the linux kern

Re: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib

2024-04-25 Thread Gerd Hoffmann
Hi, > That means the SMMRevId is 0_xx64h for AMD64 processor. But I am not > sure what the value is for AMD32 processor. Maybe 0 according to the > OVMF logic. The smm emulation in the linux kernel uses 0 and 0x64. > But, I am very suspicious about the logic in AMD's version as below: > ---

Re: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib

2024-04-24 Thread Ni, Ray
ul R ; Dong, Guo ; Rhodes, Sean ; Lu, James ; Guo, Gua ; Ard Biesheuvel ; Yao, Jiewen ; Abdul Lateef Attar ; Abner Chang ; Tom Lendacky Subject: RE: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib > > > > AMD version is not work for IA32X64 ovmf. > > > > I checked

Re: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib

2024-04-24 Thread Wu, Jiaxin
> > > > AMD version is not work for IA32X64 ovmf. > > > > I checked the detailed: CpuSaveState->x64 is always used for OVMF no > matter IA32 or X64, while AMD is not, which is decided by the MSR > EFER_ADDRESS LMA bit check. > > Hmm, probably because only PEI runs in 32-bit mode whereas DXE and

Re: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib

2024-04-24 Thread Gerd Hoffmann
On Wed, Apr 24, 2024 at 03:56:56AM +, Wu, Jiaxin wrote: > Hi Gerd, > > AMD version is not work for IA32X64 ovmf. > > I checked the detailed: CpuSaveState->x64 is always used for OVMF no matter > IA32 or X64, while AMD is not, which is decided by the MSR EFER_ADDRESS LMA > bit check. Hmm,

Re: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib

2024-04-23 Thread Wu, Jiaxin
Kumar, Rahul R ; Dong, > Guo ; Rhodes, Sean ; Lu, > James ; Guo, Gua ; Ard Biesheuvel > ; Yao, Jiewen ; Abdul > Lateef Attar ; Abner Chang > ; Tom Lendacky > Subject: RE: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib > > As I documented in the comment: > > This p

Re: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib

2024-04-23 Thread Wu, Jiaxin
; Ard Biesheuvel > ; Yao, Jiewen ; Abdul > Lateef Attar ; Abner Chang > ; Tom Lendacky > Subject: Re: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib > > On Tue, Apr 23, 2024 at 07:31:18AM +, Wu, Jiaxin wrote: > > Thanks Gerd, I will try the S3 on OVMF. > >

Re: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib

2024-04-23 Thread Gerd Hoffmann
On Tue, Apr 23, 2024 at 07:31:18AM +, Wu, Jiaxin wrote: > Thanks Gerd, I will try the S3 on OVMF. > > And for AmdSmmRelocationLib usage in OVMF, do you prefer: > 1. use the AmdSmmRelocationLib directly in this patch set? Or > 2. still keep the original to create the OvmfPkg/SmmRelocationLib,

Re: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib

2024-04-23 Thread Wu, Jiaxin
> ; Yao, Jiewen ; Abdul > Lateef Attar ; Abner Chang > ; Tom Lendacky > Subject: Re: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib > > On Thu, Apr 18, 2024 at 08:02:43AM +, Wu, Jiaxin wrote: > > Hi Gerd, > > > > Could you help review & check below

Re: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib

2024-04-22 Thread Gerd Hoffmann
On Thu, Apr 18, 2024 at 08:02:43AM +, Wu, Jiaxin wrote: > Hi Gerd, > > Could you help review & check below OVMF related patches? > > > OvmfPkg/SmmRelocationLib: Add library instance for OVMF > > OvmfPkg/PlatformInitLib: Create gEfiSmmSmramMemoryGuid > > OvmfPkg: Refine SmmAccess

Re: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib

2024-04-18 Thread Wu, Jiaxin
Guo, Gua ; Ard Biesheuvel ; Yao, Jiewen ; Attar, AbdulLateef (Abdul Lateef) ; Lendacky, Thomas Subject: Re: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib [AMD Official Use Only - General] Right, Abdul's RB is sufficient! Thanks Abner From: Ni, Ray ma

Re: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib

2024-04-18 Thread Chang, Abner via groups.io
, James ; Guo, Gua ; Ard Biesheuvel ; Yao, Jiewen ; Attar, AbdulLateef (Abdul Lateef) ; Chang, Abner ; Lendacky, Thomas Subject: Re: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking

Re: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib

2024-04-18 Thread Ni, Ray
; Dong, Guo ; Rhodes, Sean ; Lu, James ; Guo, Gua ; Ard Biesheuvel ; Yao, Jiewen ; Abdul Lateef Attar ; Abner Chang ; Tom Lendacky Subject: RE: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib Hi Tom & Abner, Could you help check & review AMD related patch? > UefiCpuPkg/SmmRe

Re: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib

2024-04-18 Thread Wu, Jiaxin
Hi Tom & Abner, Could you help check & review AMD related patch? > UefiCpuPkg/SmmRelocationLib: Add library instance for AMD Thanks, Jiaxin > -Original Message- > From: devel@edk2.groups.io On Behalf Of Wu, > Jiaxin > Sent: Thursday, April 18, 2024 2:56 PM > To: devel@edk2.groups.io

Re: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib

2024-04-18 Thread Wu, Jiaxin
Hi Gerd, Could you help review & check below OVMF related patches? > OvmfPkg/SmmRelocationLib: Add library instance for OVMF > OvmfPkg/PlatformInitLib: Create gEfiSmmSmramMemoryGuid > OvmfPkg: Refine SmmAccess implementation > OvmfPkg/SmmCpuFeaturesLib: Check Smbase Relocation is done or