Reviewed-by: Supreeth Venkatesh
-Original Message-
From: Eric Jin
Sent: Friday, June 14, 2019 1:06 AM
To: devel@edk2.groups.io
Cc: Supreeth Venkatesh
Subject: [edk2-test][Patch 1/1] Library/SctLib: Remove Ipf source files from
inf file
Remove source and header files required for
Hi Christian,
I think about BZ 1895 again, and your suggestion of "change the hash to include
the arch" is better. I've sent the v2 patch to enhance it.
BTW, the CopyFileOnChange() is still necessary for BZ 1894.
Thanks
Steven Shi
Intel\SSG\FID\Firmware Infrastructure
From: Rodriguez,
Thank you for converting to Python.
Please use python argparse module to parse arguments and make
sure the tool supports the standard EDK II tool command line
arguments. BinToPcd is a good example:
https://github.com/tianocore/edk2/blob/master/BaseTools/Scripts/BinToPcd.py
Mike
>
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1868
Build need output the cache miss or hit notification
message when consume the build cache. Current build does not
output any message which is not clear for user to know
whether the module built result is from cache or not.
This patch adds
V2:
Only output message for the driver module and not for library, which can
filter duplicated library messages from different driver modules, and
make the cache messages look more concise.
V1:
Initial fix from Zhiju
Steven Shi (1):
BaseTools:Build Cache output notification message
V2:
Follow the Christian suggestion, Still keep the set() usage, but instead to
enahnce the AutoGen object __hash__ definition to be unique by including
the AutoGen object arch string into the __hash_ values.
V1:
Avoid to use the set() as the container to save the library and module objects
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1894
Basetool need a CopyFileOnChange() function to avoid cache
file writing race in multi-thread build. Some platforms
build fail with file IO writing race issue when the
build cache is enabled to store cache files in multi-threads.
This is
https://bugzilla.tianocore.org/show_bug.cgi?id=1895
Build cache cannot store cache for the same library modules
in different arch together. E.g. Both the below IA32 and X64
arch BaseLib caches should exist after build Ovmf3264, but now
only the one in X64 arch exist.
The reason is the current
On Fri, 14 Jun 2019 at 21:17, Laszlo Ersek wrote:
>
> +Ard, +devel
>
> On 06/13/19 17:29, Russell Peterson wrote:
> > Hello,
> >
> > We are in the process of upgrading our gcc toolchain to gcc 8.3 (from 7.3).
> > In the process of doing that we have hit an error building edk2:
> >
> > make[2]:
These changes add OS boot support to N1xxWU platforms
Test: N1xxWU currently boots to windows 10
Cc: Liming Gao
Cc: David Y Wei
Cc: Michael Kubacki
Cc: Nate DeSimone
Cc: Chasel Chiu
Co-authored-by: David Y Wei
Signed-off-by: Agyeman
---
.../Features/Tbt/TbtInit/Smm/TbtSmm.inf |
Jiewen,
See my comments below.
> -Original Message-
> From: Yao, Jiewen
> Sent: Friday, June 14, 2019 6:41 PM
> To: Wang, Jian J ; devel@edk2.groups.io
> Cc: Zhang, Chao B ; Hernandez Beltran, Jorge
> ; Han, Harry
> Subject: RE: [PATCH v2 0/3] Common OBB verification feature
>
>
On 06/06/19 15:14, Anthony PERARD wrote:
> The macro SERIAL_DXE_FILE_GUID is been defined twice and the GUID is been used
> once without defining the macro. This patch series define a macro in
> MdeModulePkg where the SerialDxe is, and replace all other use by this new
> one,
>
Add comment describing new F: and X: tags for associating maintainership
sections with specific filesystem paths, including wildcards.
Add global section associating *all* code with devel@edk2.groups.io,
and add a magic '' F: tag directing all modifications that
do not hit a rule to the stewards.
Add a new script GetMaintainer.py that uses the new Maintainer.txt format
to determine which addresses to cc on patch submission.
Signed-off-by: Leif Lindholm
---
BaseTools/Scripts/GetMaintainer.py | 181 +
1 file changed, 181 insertions(+)
create mode
Changes are available directly from:
https://git.linaro.org/people/leif.lindholm/edk2.git/log/?h=upstreaming/git-maintainer-rfc
This series adds new tags to the Maintainers.txt format, making it possible
to describe which filesystem paths are looked after by which people, and
hence automating the
Add Ard and Leif as responsible for any path matching
F: */Arm/
F: */AArch64/
Signed-off-by: Leif Lindholm
---
Maintainers.txt | 8
1 file changed, 8 insertions(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index cd32f9b00170..e415f51468d5 100644
--- a/Maintainers.txt
+++
Hi Hao,
Please give me some time to try and review - I hope to find some slot next
week.
Best regards,
Marcin
pt., 14 cze 2019 o 03:46 Wu, Hao A napisał(a):
> Loop in Ard and Marcin.
>
>
>
>
>
> Hello Ard and Marcin,
>
>
>
> We are proposing to make an extension to the SDMMC Override protocol
+Ard, +devel
On 06/13/19 17:29, Russell Peterson wrote:
> Hello,
>
> We are in the process of upgrading our gcc toolchain to gcc 8.3 (from 7.3).
> In the process of doing that we have hit an error building edk2:
>
> make[2]: ***
>
On 06/14/19 07:18, Wu, Hao A wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1843
>
> Currently, the file GUID reference of the UEFI Shell app is indirected
> via the PCD gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile,
> which is set to a fixed value for OvmfPkg.
>
> So
Reviewed-by: Sami Mujawar
-Original Message-
From: Krzysztof Koch
Sent: 12 June 2019 10:32 AM
To: devel@edk2.groups.io
Cc: Ard Biesheuvel ; Leif Lindholm
; Michael D Kinney ; Sami
Mujawar ; Matteo Carlini ;
Stephanie Hughes-Fitt ; nd
Subject: [edk2-platforms PATCH v1 1/1 -resend]
I've come across a crash when fetching files over HTTPS: on both OVMF
and MACCHIATObin, I get an unhandled exception. I've tracked down the
point of failure to where code tries to call SetSessionData, but the
pointer has changed since the previous connection and is no longer valid.
I've created
Nate,
I agree with Laszlo that the section name in Maintainer.txt
is a bit confusing. Maybe change "EDK II Packages" section
title to "Tools" for this initial version. With that update:
Series Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: devel@edk2.groups.io
Hello, Ard.
The tools_def.txt was updated and both the -fno-pie and -fno-pic are specified
when executing gcc. I don’t have access to the code at the moment but I will
post the exact gcc command line as soon as I can.
Regards,
Russell
On Jun 14, 2019, at 3:43 PM, Ard Biesheuvel
Here is a sample of the gcc command line:
"/x/sdk/sysroots/x86_64-pokysdk-linux/usr/bin/aarch64-poky-linux/aarch64-poky-linux-gcc"
-I/x/edk2/edk2/MlxPlatformPkg/Include -march=armv8-a+crc -g -fshort-wchar
-fno-builtin -fno-strict-aliasing -Wall -Werror -Wno-array-bounds
-ffunction-sections
Hi Supreeth,
I have already pushed this series of patches into repo since we don't want to
leave the build issue to next week.
I also sent a patch to remove source and header files required for building Ipf
library from sctlib.inf file. Please help to review and push if it is good to
you.
When running 2nd instance of WinHost.exe, below error is printed:
ERROR : Can not open Firmware Device File ../FV/FV_RECOVERY.fd...
The root cause is "RECOVERY.FD" is exclusively opened by the first
instance of WinHost.exe.
The patch changes to open "RECOVERY.FD" in shared way so that
2nd+
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1916
In Dispatch mode PeiMain from FSP Binary will be launched
so the one from boot loader can be removed.
Test: Verified the PeiMain is removed in Dispatch mode
and included in API mode.
Cc: Michael Kubacki
Cc: Nate DeSimone
Cc:
From: Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1902
Add the missing instances to the [Components] of dsc file
for build only.
Cc: Chao Zhang
Cc: Jiewen Yao
Cc: Jian Wang
Cc: Liming Gao
Cc: Sean Brogan
Cc: Michael Turner
Cc: Bret Barkelew
Cc: Leif Lindholm
> -Original Message-
> From: Gao, Zhichao
> Sent: Monday, June 10, 2019 3:29 PM
> To: devel@edk2.groups.io
> Cc: Bret Barkelew; Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, Liming
> Subject: [PATCH 2/6] MdeModule/PeiMain: Add performance code
>
> From: Bret Barkelew
>
> REF:
> -Original Message-
> From: Gao, Zhichao
> Sent: Monday, June 10, 2019 3:29 PM
> To: devel@edk2.groups.io
> Cc: Bret Barkelew; Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, Liming
> Subject: [PATCH 3/6] MdeModulePkg/UefiBootManagerLib: Change
> performance code
>
> From: Bret
Hi
It is good to support 2nd instance.
But the risk is that 2 instances may access to the same variable region.
It might cause unpredictable behavior in the variable driver later.
Do we have investigate that impact?
Thank you
Yao Jiewen
> -Original Message-
> From:
> -Original Message-
> From: Gao, Zhichao
> Sent: Monday, June 10, 2019 3:29 PM
> To: devel@edk2.groups.io
> Cc: Bret Barkelew; Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, Liming;
> Sean Brogan; Michael Turner
> Subject: [PATCH 1/6] MdeModulePkg/DxeMain: Add performance code
I
Yes I agree.
Since UID feature was completely dropped early this year, this is a missing
library that should be
removed together with UID.
Zhichao,
Can you help submit a BZ for this removal?
I am ok with your current patch to include this library. This library can be
removed by further patch
I agree this patch only removes the limitation that blocks running 2nd instance
of WinHost.exe.
I will investigate the impact on variable storage part.
> -Original Message-
> From: Yao, Jiewen
> Sent: Friday, June 14, 2019 4:44 PM
> To: devel@edk2.groups.io; Ni, Ray
> Cc: Justen,
Thanks.
Comment below:
> -Original Message-
> From: Wang, Jian J
> Sent: Friday, June 14, 2019 8:30 AM
> To: Yao, Jiewen ; devel@edk2.groups.io
> Cc: Zhang, Chao B ; Hernandez Beltran, Jorge
> ; Han, Harry
> Subject: RE: [PATCH v2 0/3] Common OBB verification feature
>
> Jiewen,
>
> >
Remove source and header files required for building Ipf library from
inf file as edk2 (edk2-stable201905) has removed IPF support.
Cc: Supreeth Venkatesh
Signed-off-by: Eric Jin
---
uefi-sct/SctPkg/Library/SctLib/SctLib.inf | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1883
Add header file for FSP_TEMP_RAM_EXIT_PPI which is
defined by FSP 2.1 spec.
Test: Build successfully.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
---
IntelFsp2Pkg/Include/Ppi/TempRamExitPpi.h | 50
From: "Fan, Zhiju"
GenBiosId is a tool to generate the BIOS ID binary file which uses
the data from the configuration file.
https://bugzilla.tianocore.org/show_bug.cgi?id=1846
v2:v1 is a tool of C type and v2 is python type.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
38 matches
Mail list logo
