[edk2-devel] Problem with decompression on EDK2

Hi I have an issue while porting a new platform to EDK2. After porting the Stratix 10 platform (ARM) to EDK2 it works correctly. However, when I tried to add more INF to the FDF file, it failed to decompress the image during boot time, log as below INFO: DDR: DRAM calibration success. INFO:

Re: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: Auto gen result of "EFICompliantTest".

Hi Avrin, > -Original Message- > From: devel@edk2.groups.io On Behalf Of Eric Jin > Sent: Monday, September 9, 2019 3:23 PM > To: EDK II Development > Cc: Supreeth Venkatesh ; Jin, Eric > > Subject: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: Auto gen > result of

Re: [edk2-devel] Redfish Package in Main Branch

Hi, Siva We don’t have plan for that so far. Best Regards Siyuan From: Sivaraman Nainar Sent: 2019年9月25日 18:16 To: devel@edk2.groups.io Cc: Wu, Jiaxin ; Fu, Siyuan ; Arun Subramanian B Subject: reg: Redfish Package in Main Branch Hello, May we know when the RestEx driver will be available

Re: [edk2-devel] [RFC PATCH v2 10/44] OvmfPkg: A per-CPU variable area for #VC usage

On 09/19/19 21:52, Lendacky, Thomas wrote: > From: Tom Lendacky > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 > > A per-CPU implementation for holding values specific to a CPU when > running as an SEV-ES guest, specifically to hold the Debug Register > value. Allocate an extra page

Re: [edk2-devel] [PATCH wave 1 00/10] support QEMU's "SMRAM at default SMBASE" feature

Hi Laszlo May I know if you want to support legacy BIOS? The legacy BIOS memory map is reported in E820, which is different with UEFI memory map. In OvmfPkg\Csm\LegacyBiosDxe\LegacyBootSupport.c, LegacyBiosBuildE820() will hardcode below 640K address to be OS usage without consulting UEFI

[edk2-devel] Problem with decompression on EDK2

Hi I have an issue while porting a new platform to EDK2. After porting the Stratix 10 platform (ARM) to EDK2 it works correctly. However, when I tried to add more INF to the FDF file, it failed to decompress the image during boot time, log as below INFO:DDR: DRAM calibration success. INFO:

Re: [edk2-devel] [PATCH 0/1] Fix eMMC bus timing switch issue

Hi Mateusz, For the v2, could you please push the patches to some repo, so that it would be easy to fetch and test? Best regards, Marcin pon., 23 wrz 2019 o 10:37 Albecki, Mateusz napisał(a): > SD host controller specification section 3.9 recommends that controller's > bus timing > should be

Re: [edk2-devel] [PATCH 32/35] ShellPkg/UefiShellLib: clarify workaround for unfixable EdkShell bug

Reviewed-by: Jaben Carsey Given the time gap between now and when this library was originally written, I think that we should revisit maintaining support for EFI Shell. Do we still need to have UEFI Applications that can go between EFI and UEFI versions of the shell? Are there really many EFI

Re: [edk2-devel] [PATCH] BaseTools:"--exclude" don't apply if parameter ends with separator

Reviewed-by: Liming Gao > -Original Message- > From: Fan, ZhijuX > Sent: Thursday, September 19, 2019 3:45 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Feng, Bob C > Subject: [PATCH] BaseTools:"--exclude" don't apply if parameter ends with > separator > > >

Re: [edk2-devel] [PATCH wave 1 00/10] support QEMU's "SMRAM at default SMBASE" feature

On 09/26/19 10:46, Yao, Jiewen wrote: > Hi Laszlo > May I know if you want to support legacy BIOS? No, thanks. The end-goal is to implement VCPU hotplug at OS runtime, when the OS is booted with OVMF, Secure Boot is enabled, and the firmware is protected with SMM. In other words, the goal is to

Re: [edk2-devel] [PATCH] WinHost: Add SimplePointer support

Good day, I have tested cursor movement (including initial window entry) extensively and left mouse button functionality. As the right mouse button works analoguously, I expect it to work. This was all from the GetState() function of the SP protocol. Thanks, Marvin Am 26.09.2019 um 00:32

[edk2-devel] [PATCHv2 3/3] MdeModulePkg/SdMmcPciHcDxe: Fix SdMmcMmcLegacy bus timing handling

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2218 There is a bug in current driver code that makes it impossible for it to work with devices that only work in legacy speed mode since the function EmmcSwitchToHighSpeed will return with EFI_INVALID_ARGUMENT for such bus mode. Since the logic

[edk2-devel] [PATCHv2 1/3] MdeModulePkg/SdMmcPciHcDxe: Remove clock stop from HS200 switch

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2218 Stopping the SD clock before switching host controller bus timing is only neccessary if preset value enable is set in host controller. Code that performs switch to HS200 doesn't check this condition right now and we also don't do the SD

Re: [edk2-devel] [edk2-platforms] Update Packages on Bugzilla

Michael, Thank you for the reminder. I have added the 3 new components. Mike From: Kubacki, Michael A Sent: Monday, September 23, 2019 7:30 PM To: 'devel@edk2.groups.io' ; Kinney, Michael D Cc: Wei, David Y ; Agyeman, Prince Subject: RE: [edk2-platforms] Update Packages on Bugzilla Mike,

Re: [edk2-devel] [PATCH 30/35] ShellPkg: stop taking EFI_HANDLE in place of SHELL_FILE_HANDLE

OK. I didn't view the whole calling stack. Thanks for your clear explain. Then why we need two exact same handle type? May be we should keep only one of them. Same with the DEBUG_XXX and EFI_D_XXX. Back to the patch, it is OK to me now. Reviewed-by: Zhichao Gao > -Original Message- >

[edk2-devel] [PATCHv2 0/3] Fix eMMC bus timing switch issue

SD host controller specification section 3.9 recommends that controller's bus timing should be switched after card's bus timing has been switched. In current eMMC driver implementation every host controller switch has been done before call to EmmcSwitchBusTiming which is causing issues on some

[edk2-devel] [PATCHv2 2/3] MdeModulePkg/SdMmcPciHcDxe: Fix bus timing switch sequence

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2218 SD specification recommends switching card bus timing before switching bus timing in controller. Emmc driver used to do this switch other way around. This commit adds controller timing switch in EmmcSwitchBusTiming function to enforce this

Re: [edk2-devel] [RFC PATCH v2 10/44] OvmfPkg: A per-CPU variable area for #VC usage

On 9/26/19 3:17 AM, Laszlo Ersek wrote: > On 09/19/19 21:52, Lendacky, Thomas wrote: >> From: Tom Lendacky >> >> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 >> >> A per-CPU implementation for holding values specific to a CPU when >> running as an SEV-ES guest, specifically to hold the

Re: [edk2-devel] [RFC PATCH v2 08/44] OvmfPkg: Create GHCB pages for use during Pei and Dxe phase

On 9/26/19 3:00 AM, Laszlo Ersek wrote: > Hi Tom, > > On 09/19/19 21:52, Lendacky, Thomas wrote: >> From: Tom Lendacky >> >> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 >> >> Allocate memory for the GHCB pages during SEV initialization for use >> during Pei and Dxe phases. The GHCB

Re: [edk2-devel] [PATCH 23/35] OvmfPkg/VirtioNetDxe: fix SignalEvent() call

On Tue, 17 Sep 2019 at 21:50, Laszlo Ersek wrote: > > The SignalEvent() boot service takes an EFI_EVENT, not an (EFI_EVENT*). > Fix the call in the notification function of > "EFI_SIMPLE_NETWORK_PROTOCOL.WaitForPacket". > > This is an actual bug. The reason it's never been triggered is likely

Re: [edk2-devel] [PATCH 03/35] EmbeddedPkg/AndroidFastbootTransportTcpDxe: fix DestroyChild() call

On Tue, 17 Sep 2019 at 21:49, Laszlo Ersek wrote: > > - The 2nd parameter of EFI_SERVICE_BINDING_CREATE_CHILD is: > > IN OUT EFI_HANDLE *ChildHandle > > - The 2nd parameter of EFI_SERVICE_BINDING_DESTROY_CHILD is: > > IN EFI_HANDLE ChildHandle > > Fix the DestroyChild() call in

Re: [edk2-devel] [PATCH 32/35] ShellPkg/UefiShellLib: clarify workaround for unfixable EdkShell bug

Sorry for miss this. The comment is nice to help understand the type conversion. Reviewed-by: Zhichao Gao > -Original Message- > From: Laszlo Ersek > Sent: Thursday, September 26, 2019 8:47 PM > To: Carsey, Jaben ; Ni, Ray ; > Gao, Zhichao > Cc: edk2-devel-groups-io > Subject: Re:

[edk2-devel] [PATCH 1/4] MdeModulePkg DxeCore: Fix typo in function name

An extra 's' slipped into the FvIsBeingProcessed function name. Drop it to fix the typo. Signed-off-by: Philippe Mathieu-Daude --- MdeModulePkg/Core/Dxe/Dispatcher/Dispatcher.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Core/Dxe/Dispatcher/Dispatcher.c

[edk2-devel] [PATCH 3/4] StandaloneMmPkg/Core: Fix typo in function name

An extra 's' slipped into the FvIsBeingProcessed function name. Drop it to fix the typo. Signed-off-by: Philippe Mathieu-Daude --- StandaloneMmPkg/Core/Dispatcher.c | 4 ++-- StandaloneMmPkg/Core/FwVol.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git

[edk2-devel] [PATCH 2/4] MdeModulePkg/PiSmmCore: Fix typo in function name

An extra 's' slipped into the FvIsBeingProcessed function name. Drop it to fix the typo. Signed-off-by: Philippe Mathieu-Daude --- MdeModulePkg/Core/PiSmmCore/Dispatcher.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Core/PiSmmCore/Dispatcher.c

[edk2-devel] [PATCH 4/4] NetworkPkg/Ip6Dxe: Fix typo in comment

An extra 's' slipped into the 'processing' word. Drop it to fix the typo. Signed-off-by: Philippe Mathieu-Daude --- NetworkPkg/Ip6Dxe/Ip6Option.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NetworkPkg/Ip6Dxe/Ip6Option.c b/NetworkPkg/Ip6Dxe/Ip6Option.c index

[edk2-devel] [PATCH 0/4] trivial: Fix typos in "processing/processed"

Some "processing/processed" words are written with an extra 's'. Properly write them. Unrelated note, I'm sending this series using git-publish with a 'cc.cmd' script which build the Cc list of each patch calling BaseTools/Scripts/GetMaintainer.py, appologies if it fails :) Philippe

Re: [edk2-devel] [PATCH 18/35] NetworkPkg/DxeNetLib: fix type typo in NetLibGetMacAddress()

Jiaxin, Siyuan, can you please review this patch? Thanks Laszlo On 09/17/19 21:49, Laszlo Ersek wrote: > NetLibGetSnpHandle() returns an EFI_HANDLE, not an (EFI_HANDLE*). > NetLibGetMacAddress() only uses the return value ("SnpHandle") for a > NULL-check. Fix the type of "SnpHandle". > > This

Re: [edk2-devel] [PATCH 20/35] NetworkPkg/Ip4Dxe: fix NetLibDestroyServiceChild() call

Jiaxin, Siyuan, can you please review this patch? Thanks Laszlo On 09/17/19 21:49, Laszlo Ersek wrote: > Both NetLibDestroyServiceChild() and EFI_SERVICE_BINDING_DESTROY_CHILD > take an EFI_HANDLE for the "ChildHandle" parameter, not an (EFI_HANDLE*). > > This patch fixes a real bug. > > Cc:

Re: [edk2-devel] [PATCH 29/35] ShellPkg: stop using EFI_HANDLE in place of EFI_HII_HANDLE

On 09/25/19 20:04, Philippe Mathieu-Daudé wrote: > On 9/17/19 9:49 PM, Laszlo Ersek wrote: >> 25 files changed, 33 insertions(+), 33 deletions(-) > I checked every case, entertaining. > Reviewed-by: Philippe Mathieu-Daude Many thanks for the effort! :) Laszlo -=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 23/35] OvmfPkg/VirtioNetDxe: fix SignalEvent() call

Jordan, Ard, may I please get an R-b for this patch? It's quite simple. (Sorry if it's already in your queue.) Thank you, Laszlo On 09/17/19 21:49, Laszlo Ersek wrote: > The SignalEvent() boot service takes an EFI_EVENT, not an (EFI_EVENT*). > Fix the call in the notification function of >

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/SdMmcPciHcDxe: Fix bus timing switch sequence

> -Original Message- > From: Wu, Hao A > Sent: Thursday, September 26, 2019 3:36 AM > To: Albecki, Mateusz ; devel@edk2.groups.io > Cc: Marcin Wojtas > Subject: RE: [PATCH 1/1] MdeModulePkg/SdMmcPciHcDxe: Fix bus timing > switch sequence > > > -Original Message- > > From:

Re: [edk2-devel] [PATCH v2] MdeModulePkg: Enable/Disable S3BootScript dynamically.

On 09/26/19 03:52, Chiu, Chasel wrote: > > Thanks Laszlo for your time on detail reviewing and very good feedbacks! > Please see my reply inline below. > >> -Original Message- >> From: Laszlo Ersek >> Sent: Thursday, September 26, 2019 2:58 AM >> To: devel@edk2.groups.io; Chiu, Chasel

Re: [edk2-devel] [PATCH 30/35] ShellPkg: stop taking EFI_HANDLE in place of SHELL_FILE_HANDLE

On 09/26/19 04:53, Gao, Zhichao wrote: > > >> -Original Message- >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >> Laszlo Ersek >> Sent: Wednesday, September 18, 2019 3:50 AM >> To: edk2-devel-groups-io >> Cc: Carsey, Jaben ; Ni, Ray ; >> Gao, Zhichao >>

Re: [edk2-devel] [PATCH 03/35] EmbeddedPkg/AndroidFastbootTransportTcpDxe: fix DestroyChild() call

Leif, Ard, On 09/17/19 21:49, Laszlo Ersek wrote: > - The 2nd parameter of EFI_SERVICE_BINDING_CREATE_CHILD is: > > IN OUT EFI_HANDLE *ChildHandle > > - The 2nd parameter of EFI_SERVICE_BINDING_DESTROY_CHILD is: > > IN EFI_HANDLE ChildHandle > > Fix the DestroyChild() call in

Re: [edk2-devel] [PATCH 27/35] SecurityPkg: stop abusing EFI_EVENT for protocol notify registration

Chao, Jian, Jiewen, can you please review this patch? Thanks, Laszlo On 09/17/19 21:49, Laszlo Ersek wrote: > EfiCreateProtocolNotifyEvent() takes a (VOID**) for "Registration", > similarly to gBS->RegisterProtocolNotify(). We should pass the address of > an actual pointer-to-VOID, and not the

Re: [edk2-devel] [PATCH 25/35] OvmfPkg/VideoDxe: document EFI_EDID_OVERRIDE_PROTOCOL.GetEdid() call

On 09/23/19 17:59, Philippe Mathieu-Daudé wrote: > Hi Laszlo, > > On 9/17/19 9:49 PM, Laszlo Ersek wrote: >> According to the UEFI spec -- and to the edk2 header >> "MdePkg/Include/Protocol/EdidOverride.h" too --, >> EFI_EDID_OVERRIDE_PROTOCOL_GET_EDID takes an (EFI_HANDLE*), and not an >>

Re: [edk2-devel] [PATCH 19/35] NetworkPkg: fix CloseProtocol & UninstallMultipleProtocolInterfaces calls

Hi Laszlo, On 9/17/19 9:49 PM, Laszlo Ersek wrote: > Both the "ControllerHandle" parameter of CloseProtocol() Maybe worth adding "of type EFI_CLOSE_PROTOCOL" > and the "Handle" > parameter of UninstallMultipleProtocolInterfaces() "of type EFI_UNINSTALL_MULTIPLE_PROTOCOL_INTERFACES" have type

Re: [edk2-devel] [PATCH 09/35] MdeModulePkg: stop abusing EFI_EVENT for protocol notify registration

On 09/25/19 18:02, Philippe Mathieu-Daudé wrote: > On 9/17/19 9:49 PM, Laszlo Ersek wrote: >> EfiCreateProtocolNotifyEvent() takes a (VOID**) for "Registration", >> similarly to gBS->RegisterProtocolNotify(). We should pass the address of >> an actual pointer-to-VOID, and not the address of an

Re: [edk2-devel] [PATCH 32/35] ShellPkg/UefiShellLib: clarify workaround for unfixable EdkShell bug

Jaben, Ray, Zhichao, can one of you guys please review this patch? Thanks Laszlo On 09/17/19 21:49, Laszlo Ersek wrote: > The EDK 1 Shell (available at ) > has a bug in its EFI_SHELL_ENVIRONMENT2.Execute() implementation that > edk2's UefiShellLib has no

Re: [edk2-devel] [PATCH 33/35] StandaloneMmPkg/Core: stop abusing EFI_HANDLE for FwVolHeader tracking

Achin, Jiewen, Supreeth, can one of you guys please review this patch? Thanks Laszlo On 09/17/19 21:49, Laszlo Ersek wrote: > The FvHasBeenProcessed() and FvIsBeingProcesssed() functions make sure > that every firmware volume is processed only once (every driver in every > firmware volume

Re: [edk2-devel] [PATCH 26/35] SecurityPkg: fix UninstallMultipleProtocolInterfaces() calls

Chao, Jian, Jiewen, can you please review this patch? Thanks, Laszlo On 09/17/19 21:49, Laszlo Ersek wrote: > Unlike the InstallMultipleProtocolInterfaces() boot service, which takes > an (EFI_HANDLE*) as first parameter, the > UninstallMultipleProtocolInterfaces() boot service takes an

Re: [edk2-devel] [PATCH 34/35] UefiPayloadPkg/BlSupportPei: fix MMCONFIG assignment from XSDT

On 9/17/19 9:49 PM, Laszlo Ersek wrote: > (This patch is unrelated to the rest of this series; its purpose is to > enable building the UefiPayloadPkg DSC files with GCC.) > > When building "UefiPayloadPkg/UefiPayloadPkgIa32.dsc" with GCC48 for the > DEBUG target, the compiler reports that

Re: [edk2-devel] [PATCH V1 0/5] UEFI Variable SMI Reduction

Hello Michael, On 09/26/19 06:50, Michael Kubacki wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2220 > > Overview > - > This patch series reduces SMM usage when using VariableSmmRuntimeDxe with > VariableSmm. It does so by eliminating SMM usage for runtime service >

Re: [edk2-devel] [PATCH 1/2] UefiCpuPkg/PiSmmCpu: Remove hard code when getting physical line size

Laszlo, I agree with your comments. I will: 1. separate the patch into 2 2. remove the unneeded "else" after getting from HOB. Thanks, Ray > -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo Ersek > Sent: Thursday, September 26, 2019 10:54 AM > To: Ni, Ray ;

[edk2-devel] [PATCH 1/1] BaseTools: use stdint.h for GCC ProcessorBind.h typedefs

The AArch64 definitions of UINT64/INT64 differ from the X64 ones. Since this is on the tool side, doing like X64 and picking the definitions from stdint.h feels like a better idea than hardcoding them. So copy the pattern from X64/ProcesorBind.h. Cc: Ard Biesheuvel Cc: Bob Feng Cc: Liming Gao

Re: [edk2-devel] [PATCH 2/2] UefiCpuPkg/PiSmmCpuDxe: Honor the physical address size in CpuInfo HOB

Laszlo, I agree to reverse the order of the two conditions. thanks for the suggestions. Thanks, Ray > -Original Message- > From: Laszlo Ersek > Sent: Thursday, September 26, 2019 11:02 AM > To: Ni, Ray ; devel@edk2.groups.io > Cc: Dong, Eric > Subject: Re: [PATCH 2/2]

Re: [edk2-devel] [PATCH] WinHost: Add SimplePointer support

Reviewed-by: Ray Ni > -Original Message- > From: Marvin Häuser > Sent: Thursday, September 26, 2019 9:38 AM > To: Ni, Ray ; Marvin Häuser ; > devel@edk2.groups.io > Cc: Justen, Jordan L ; Andrew Fish > > Subject: Re: [PATCH] WinHost: Add SimplePointer support > > Good day, > > I

Re: [edk2-devel] [PATCH 1/2] UefiCpuPkg/PiSmmCpu: Remove hard code when getting physical line size

Hi Ray, On 09/26/19 02:09, Ray Ni wrote: > The code replaces the hard code with macros defined in > MdePkg\Include\Register\Intel\CpuId.h. > > No functionality impact. > > Signed-off-by: Ray Ni > Cc: Eric Dong > Cc: Laszlo Ersek > --- > UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c | 24

Re: [edk2-devel] [PATCH 2/2] UefiCpuPkg/PiSmmCpuDxe: Honor the physical address size in CpuInfo HOB

On 09/26/19 02:09, Ray Ni wrote: > Today's logic is to only enable 5-level paging when CPU supports it > and the maximum physical address size > 48. > The patch changes to get the maximum physical address size firstly > from CpuInfo HOB then CPUID result. It aligns to the behavior of > existing

Re: [edk2-devel] Problem with decompression on EDK2

On 09/26/19 11:27, Loh, Tien Hock wrote: > Hi > > I have an issue while porting a new platform to EDK2. After porting the > Stratix 10 platform (ARM) to EDK2 it works correctly. However, when I tried > to add more INF to the FDF file, it failed to decompress the image during > boot time, log

Re: [edk2-devel] [PATCH V1 0/5] UEFI Variable SMI Reduction

Hi Laszlo, In short, it would not complicate the code beyond a reasonable level to support the runtime cache with a FeaturePCD. I had considered this but dismissed it with lack of a practical use case (which you provided) that could justify adding another configuration option to the variable

Re: [edk2-devel] [PATCH 0/4] trivial: Fix typos in "processing/processed"

On 09/26/19 14:04, Philippe Mathieu-Daudé wrote: > Some "processing/processed" words are written with an extra 's'. > Properly write them. > > Unrelated note, I'm sending this series using git-publish with > a 'cc.cmd' script which build the Cc list of each patch calling >

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/BdsDxe: Also call PlatformBootManagerWaitCallback on 0

On 09/25/19 17:50, Pete Batard wrote: > The existing loop is set to call PlatformBootManagerWaitCallback every > second except the last one. We believe this is a mistake as it prevents > the called code from performing timeout expiration tasks such as, for > instance, ensuring that the last

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 02/29] RiscVPkg/Include: Add header files of RISC-V CPU package

On Mon, Sep 23, 2019 at 08:31:27AM +0800, Abner Chang wrote: > RISC-V package library definitions. > > IndustryStandard/RiscV.h > -Add RiscV.h which conform with RISC-V Privilege Spec v1.10. > > RiscV.h > -Definition of EDK2 RISC-V implementation. > > Signed-off-by: Abner Chang > --- >

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 04/29] MdePkg: RISC-V RV64 binding in MdePkg

On Mon, Sep 23, 2019 at 08:31:29AM +0800, Abner Chang wrote: > Add RISCV64 sections in MdePkg.dec and RISCV64 ProcessorBind.h > Signed-off-by: Abner Chang Reviewed-by: Leif Lindholm > --- > MdePkg/Include/RiscV64/ProcessorBind.h | 173 > + > MdePkg/MdePkg.dec

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 07/29] MdePkg/BaseLib: BaseLib for RISC-V RV64 Processor.

On Mon, Sep 23, 2019 at 08:31:32AM +0800, Abner Chang wrote: > Add RISC-V RV64 BaseLib functions. > > Signed-off-by: Abner Chang > --- > MdePkg/Include/Library/BaseLib.h | 26 ++ > MdePkg/Library/BaseLib/BaseLib.inf | 18 +- >

Re: [edk2-devel] [PATCH 1/4] MdeModulePkg DxeCore: Fix typo in function name

Reviewed-by: Liming Gao >-Original Message- >From: Philippe Mathieu-Daude [mailto:phi...@redhat.com] >Sent: Thursday, September 26, 2019 8:05 PM >To: devel@edk2.groups.io >Cc: Philippe Mathieu-Daude ; Wang, Jian J >; Wu, Hao A ; Bi, Dandan >; Gao, Liming >Subject: [PATCH 1/4]

Re: [edk2-devel] [PATCH 0/1] Fix eMMC bus timing switch issue

Hello Marcin, I have uploaded the V2 series to my fork. You can get the patch at: https://github.com/hwu25/edk2/tree/emmc_busmode_v2 Best Regards, Hao Wu From: Marcin Wojtas [mailto:m...@semihalf.com] Sent: Thursday, September 26, 2019 3:25 PM To: Albecki, Mateusz Cc: edk2-devel-groups-io; Wu,

Re: [edk2-devel] [edk2-test][Patch] uefi-sct/SctPkg: Add MediaPresentSupported check

Hi Heinrich, Any concern about it? Thanks. Best Regards Xianhui Liu > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > xianhui liu > Sent: Wednesday, September 25, 2019 10:18 AM > To: devel@edk2.groups.io; xypron.g...@gmx.de > Cc: Supreeth

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 00/29] RISC-V EDK2 Port on

On Mon, Sep 23, 2019 at 08:31:25AM +0800, Abner Chang wrote: > This branch "RISC-V-V2" is used to contribute RISC-V architecture on EDK2. > Compare to the old branch "RISC-V", this branch "RISC-V-V2" is created based > on > the most recent edk2/master @37eef910. This is easier for reviewers to

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 05/29] MdePkg/Include: RISC-V definitions.

On Mon, Sep 23, 2019 at 08:31:30AM +0800, Abner Chang wrote: > Add RISC-V processor related definitions. > > Signed-off-by: Abner Chang Reviewed-by: Leif Lindholm > --- > MdePkg/Include/IndustryStandard/PeImage.h | 12 +++ > MdePkg/Include/Protocol/DebugSupport.h| 55 >

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 06/29] MdeModulePkg/CapsuleRuntimeDxe: Add RISCV64 arch.

On Mon, Sep 23, 2019 at 08:31:31AM +0800, Abner Chang wrote: > Add RISC-V in INF for building CapsuleRuntimeDxe RISCV64 image. > > Signed-off-by: Abner Chang Reviewed-by: Leif Lindholm > --- > MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf | 9 + > 1 file changed, 5

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 08/29] MdePkg/BaseCacheMaintenanceLib: RISC-V cache maintenance implementation.

On Mon, Sep 23, 2019 at 08:31:34AM +0800, Abner Chang wrote: > Implement RISC-V cache maintenance functions in > BaseCacheMaintenanceLib. > > Signed-off-by: Abner Chang I can't comment on their correctness, but the code looks fine. Acked-by: Leif Lindholm > --- >

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 12/29] MdePkg/BaseSynchronizationLib: RISC-V cache related code.

On Mon, Sep 23, 2019 at 08:31:38AM +0800, Abner Chang wrote: > Support RISC-V cache related functions. > > Signed-off-by: Abner Chang What is the purpose of the .c file? Currently all I see it doing it printing some messages before calling into assembly, and forcing Hungarian notation on the

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 25/29] BaseTools/Scripts

On Mon, Sep 23, 2019 at 08:31:51AM +0800, Abner Chang wrote: > Add RISC-V specific LD scripts. ."rela(INFO)" in the latest GccBase.lds > causes PE32 relocation error. > This is the temporaty solution untill we find the root casue. I presume you mean that having a separate version for RISCV is

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 24/29] BaseTools: BaseTools changes for RISC-V platform.

On Mon, Sep 23, 2019 at 08:31:50AM +0800, Abner Chang wrote: > BaseTools changes for building EDK2 RISC-V platform. > The changes made to build_rule.template is to avoid build errors > cause by GCC711RISCV tool chain. Thank you, this is much cleaner. There are however some issues in this patch

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 27/29] edk2-staging/RISC-V-V2: Add submodule

On Mon, Sep 23, 2019 at 08:31:53AM +0800, Abner Chang wrote: > Add submodule opensbi under RiscVPkg. The current supported opensbi > version for RISC-V edk2 port is commit ID:ce228ee (tags/v0.4). > > Signed-off-by: Abner Chang > --- > .gitmodules | 16 ++-- > RiscVPkg/opensbi |

Re: [edk2-devel] [PATCH V1 0/5] UEFI Variable SMI Reduction

After thinking a bit more, this test is based on a side effect of implementation. I'd prefer to avoid this being the sole cause of additional complexity in an already complex driver. Are one of these two options acceptable? 1. Use the Runtime Services QueryVariableInfo () API In this patch

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 10/29] MdePkg/BasePeCoff: Add RISC-V PE/Coff related code.

On Mon, Sep 23, 2019 at 08:31:36AM +0800, Abner Chang wrote: > Support RISC-V image relocation. > > Signed-off-by: Abner Chang > --- > MdePkg/Library/BasePeCoffLib/BasePeCoff.c | 3 +- > MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf | 5 + >

[edk2-devel] [PATCH V2] MdeModulePkg/TerminalDxe: Enhance the arrow keys support

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2219 First previous patch remove the VT100Plus's arrow keys' support. Add it back. The arrow keys would send ESC [A through to ESC [D. Add this support for the new introduced terminal type. Cc: Jian J Wang Cc: Hao A Wu Cc: Ray Ni Cc: Liming

[edk2-devel] [PATCH] BaseTools:fix Ecc tool issue for check StructPcd

BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2142 gAdvancedFeaturePkgTokenSpaceGuid.PcdSmbiosType0BiosInformation| {0x0}|SMBIOS_TABLE_TYPE0|0x8001 { IndustryStandard/SmBios.h MdePkg/MdePkg.dec AdvancedFeaturePkg/AdvancedFeaturePkg.dec } If there's a

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 01/29] RiscVPkg: RISC-V processor package.

On Mon, Sep 23, 2019 at 08:31:26AM +0800, Abner Chang wrote: > - Add RiscVPkg package which provides RISC-V processor related > drivers and libraries. > - Support RISC-V OpenSBI and RISC-V platforms > > Signed-off-by: Abner Chang > --- > RiscVPkg/RiscVPkg.dec | 27

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 09/29] MdePkg/BaseIoLibIntrinsic: RISC-V I/O intrinsic functions.

On Mon, Sep 23, 2019 at 08:31:35AM +0800, Abner Chang wrote: > RISC-V MMIO library instance. RISC-V only supports memory map I/O. We need fewer, not more, C implementations of MMIO accessors. While this set doesn't need to wait for upstream to get sorted, please just use IoLibArm.c which should

Re: [edk2-devel] [PATCH 21/35] NetworkPkg/TcpDxe: fix SockFreeFoo() parameter list

Reviewed-by: Siyuan Fu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo > Ersek > Sent: 2019年9月18日 3:49 > To: edk2-devel-groups-io > Cc: Wu, Jiaxin ; Fu, Siyuan > Subject: [edk2-devel] [PATCH 21/35] NetworkPkg/TcpDxe: fix SockFreeFoo() > parameter list > > The

Re: [edk2-devel] [PATCH 20/35] NetworkPkg/Ip4Dxe: fix NetLibDestroyServiceChild() call

Reviewed-by: Siyuan Fu > -Original Message- > From: Philippe Mathieu-Daudé > Sent: 2019年9月24日 0:04 > To: devel@edk2.groups.io; ler...@redhat.com > Cc: Wu, Jiaxin ; Fu, Siyuan > Subject: Re: [edk2-devel] [PATCH 20/35] NetworkPkg/Ip4Dxe: fix > NetLibDestroyServiceChild() call > > On

Re: [edk2-devel] Problem with decompression on EDK2

Can you share the generated FD image? I can help check whether it is generated correctly with compression. Thanks Liming >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Laszlo Ersek >Sent: Friday, September 27, 2019 3:22 AM >To:

[edk2-devel] [Patch v2] Maintainers.txt: Move ShellBin maintainers to EDK II Releases section

ShellBinPkg is generated for each edk2 stable tag release. Cc: Andrew Fish Cc: Laszlo Ersek Cc: Leif Lindholm Cc: Michael D Kinney Signed-off-by: Liming Gao --- In v2, use real URL for edk2 release Maintainers.txt | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff

Re: [edk2-devel] [Patch 5/6] MdeModulePkg: Remove PCD gEfiMdeModulePkgTokenSpaceGuid.PcdTftpBlockSize

> -Original Message- > From: Gao, Liming > Sent: Tuesday, September 17, 2019 10:59 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J; Wu, Hao A > Subject: [Patch 5/6] MdeModulePkg: Remove PCD > gEfiMdeModulePkgTokenSpaceGuid.PcdTftpBlockSize > > BZ:

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 03/29] RiscVPkg/opensbi: EDK2 RISC-V OpenSBI support

On Mon, Sep 23, 2019 at 08:31:28AM +0800, Abner Chang wrote: > Add EDK2 RISC-V OpenSBI header files and opensbi-HOWTO.txt for users to build > RISC-V platform with RISC-V OpenSBI library. > > Signed-off-by: Abner Chang > --- > RiscVPkg/Include/sbi/SbiFirmwareContext.h | 38 >

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 11/29] MdePkg/BaseCpuLib: RISC-V Base CPU library implementation.

On Mon, Sep 23, 2019 at 08:31:37AM +0800, Abner Chang wrote: > Implement RISC-V CPU related functions in BaseCpuLib. > > Signed-off-by: Abner Chang Reviewed-by: Leif Lindholm > --- > MdePkg/Library/BaseCpuLib/BaseCpuLib.inf | 6 +- > MdePkg/Library/BaseCpuLib/BaseCpuLib.uni | 5 +++-- >

Re: [edk2-devel] [PATCH 1/1] BaseTools: use stdint.h for GCC ProcessorBind.h typedefs

Reviewed-by: Liming Gao >-Original Message- >From: Leif Lindholm [mailto:leif.lindh...@linaro.org] >Sent: Friday, September 27, 2019 3:28 AM >To: devel@edk2.groups.io >Cc: Ard Biesheuvel ; Feng, Bob C >; Gao, Liming ; Laszlo Ersek > >Subject: [PATCH 1/1] BaseTools: use stdint.h for GCC

Re: [edk2-devel] [PATCH 1/1] BaseTools: use stdint.h for GCC ProcessorBind.h typedefs

Reviewed-by: Bob Feng -Original Message- From: Leif Lindholm [mailto:leif.lindh...@linaro.org] Sent: Friday, September 27, 2019 3:28 AM To: devel@edk2.groups.io Cc: Ard Biesheuvel ; Feng, Bob C ; Gao, Liming ; Laszlo Ersek Subject: [PATCH 1/1] BaseTools: use stdint.h for GCC

Re: [edk2-devel] [PATCH 0/4] trivial: Fix typos in "processing/processed"

> -Original Message- > From: Philippe Mathieu-Daude [mailto:phi...@redhat.com] > Sent: Thursday, September 26, 2019 8:05 PM > To: devel@edk2.groups.io > Cc: Philippe Mathieu-Daude; Achin Gupta; Wu, Jiaxin; Dong, Eric; Bi, Dandan; > Fu, Siyuan; Ni, Ray; Wang, Jian J; Yao, Jiewen; Supreeth

Re: [edk2-devel] [PATCH wave 1 00/10] support QEMU's "SMRAM at default SMBASE" feature

Sounds good. Maybe you can write that info in the commit message. A simple sentence such as : No CSM support is needed because legacy BIOS boot don't use SMM. So other people won't have same question in the future. With the commit message change, the series reviewed-by: jiewen@intel.com

Re: [edk2-devel] [PATCH V2] MdeModulePkg/TerminalDxe: Enhance the arrow keys support

Reviewed-by: Ray Ni > -Original Message- > From: Gao, Zhichao > Sent: Thursday, September 26, 2019 6:09 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; Ni, > Ray ; Gao, Liming > > Subject: [PATCH V2] MdeModulePkg/TerminalDxe: Enhance the arrow keys support > > REF:

[edk2-devel] [PATCH v7 2/4] MdeModulePkg/UfsPassThruDxe: Check for RPMB W-LUN (SecurityLun)

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1546 Currently UfsPassThru only checks for 8 common LUNs. This adds a check for the RPMB Well-known LUN and sets the corresponding bit-mask. Further handling of the WLUN is already present in the driver. Cc: Michael D Kinney Cc: Jiewen Yao Cc:

[edk2-devel] [PATCH v7 4/4] MdeModulePkg/ScsiDiskDxe: Support Storage Security Command Protocol

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1546 This patch implements the EFI_STORAGE_SECURITY_COMMAND_PROTOCOL in the ScsiDiskDxe driver. Support is currently limited to the RPMB Well-known LUN for UFS devices. Cc: Michael D Kinney Cc: Jiewen Yao Cc: Jian J Wang Cc: Liming Gao

[edk2-devel] [PATCH v7 3/4] MdeModulePkg/ScsiBusDxe: Clean up Peripheral Type check

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1546 Replacing "magic numbers" in the Peripheral Type check with defines for the reserved range from IndustryStandard/Scsi.h Cc: Michael D Kinney Cc: Jiewen Yao Cc: Jian J Wang Cc: Liming Gao Signed-off-by: Christopher J Zurcher ---

[edk2-devel] [PATCH v7 1/4] MdePkg: Implement SCSI commands for Security Protocol In/Out

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1546 This patch implements the Security Protocol In and Security Protocol Out commands in UefiScsiLib to prepare support for the Storage Security Command Protocol. Cc: Jiewen Yao Cc: Jian J Wang Cc: Liming Gao Signed-off-by: Christopher J

[edk2-devel] [PATCH v7 0/4] Add SCSI Support for Storage Security Command Protocol

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1546 V7 changes: Changed Inc512 behavior to always take DataLength as bytes, and divide by 512 only in the CDB. V6 changes: Restore EFI_SCSI_TYPE defines for ASC IT8 devices. Revert EFI_SCSI_IO_TYPE changes in Protocol\ScsiIo.h. Add INC_512

[edk2-devel] [PATCH v8 1/4] MdePkg: Implement SCSI commands for Security Protocol In/Out

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1546 This patch implements the Security Protocol In and Security Protocol Out commands in UefiScsiLib to prepare support for the Storage Security Command Protocol. Cc: Jiewen Yao Cc: Jian J Wang Cc: Liming Gao Signed-off-by: Christopher J

[edk2-devel] [PATCH v8 0/4] Add SCSI Support for Storage Security Command Protocol

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1546 V8 changes: Align Inc512 definition in UefiScsiLib.h with that in UefiScsiLib.c. V7 changes: Changed Inc512 behavior to always take DataLength as bytes, and divide by 512 only in the CDB. V6 changes: Restore EFI_SCSI_TYPE defines for ASC

[edk2-devel] [PATCH v8 3/4] MdeModulePkg/ScsiBusDxe: Clean up Peripheral Type check

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1546 Replacing "magic numbers" in the Peripheral Type check with defines for the reserved range from IndustryStandard/Scsi.h Cc: Michael D Kinney Cc: Jiewen Yao Cc: Jian J Wang Cc: Liming Gao Signed-off-by: Christopher J Zurcher ---

[edk2-devel] [PATCH v8 4/4] MdeModulePkg/ScsiDiskDxe: Support Storage Security Command Protocol

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1546 This patch implements the EFI_STORAGE_SECURITY_COMMAND_PROTOCOL in the ScsiDiskDxe driver. Support is currently limited to the RPMB Well-known LUN for UFS devices. Cc: Michael D Kinney Cc: Jiewen Yao Cc: Jian J Wang Cc: Liming Gao

Re: [edk2-devel] [PATCHv2 0/3] Fix eMMC bus timing switch issue

> -Original Message- > From: Albecki, Mateusz > Sent: Thursday, September 26, 2019 10:28 PM > To: devel@edk2.groups.io > Cc: Albecki, Mateusz; Wu, Hao A; Marcin Wojtas > Subject: [PATCHv2 0/3] Fix eMMC bus timing switch issue > > SD host controller specification section 3.9 recommends

[edk2-devel] [PATCH v1 3/4] NetworkPkg/TlsDxe: Add the support of host validation to TlsDxe driver(CVE-2019-14553)

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=960 CVE: CVE-2019-14553 The new data type named "EfiTlsVerifyHost" and the EFI_TLS_VERIFY_HOST_FLAG are supported in TLS protocol. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Wu Jiaxin Reviewed-by: Ye Ting

[edk2-devel] [PATCH v1 1/4] MdePkg/Include/Protocol/Tls.h: Add the data type of EfiTlsVerifyHost(CVE-2019-14553)

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=960 CVE: CVE-2019-14553 In the patch, we add the new data type named "EfiTlsVerifyHost" and the EFI_TLS_VERIFY_HOST_FLAG for the TLS protocol consumer (HTTP) to enable the host name check so as to avoid the potential Man-In-The-Middle attack.

[edk2-devel] [PATCH v1 4/4] NetworkPkg/HttpDxe: Set the HostName for the verification(CVE-2019-14553)

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=960 CVE: CVE-2019-14553 Set the HostName by consuming TLS protocol to enable the host name check so as to avoid the potential Man-In-The-Middle attack. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Wu Jiaxin

[edk2-devel] [PATCH v1 0/4] Support HTTPS HostName validation feature(CVE-2019-14553)

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=960 CVE: CVE-2019-14553 The series patches are to support HTTPS hostname validation feature. It fixes the issue exposed @ https://bugzilla.tianocore.org/show_bug.cgi?id=960. In the patches, we add the new data type named "EfiTlsVerifyHost" and

  1   2   >