Re: [edk2-devel] [PATCH edk2-platforms 04/16] Silicon/NXP: PciHostBridgeLib: CFG Shift feature support for PCIeLS Ctrl

2020-05-22 Thread Ard Biesheuvel
On 5/22/20 1:02 AM, Wasim Khan wrote: From: Wasim Khan PCIe layerscape controller supports CFG Shift feature. It can be enabled by setting BIT[28] of iATU Control 2 Register. Check PcdPciCfgShiftEnable to enable 'CFG Shift feature' in PCIe controller. if enable, PCIe layerscape controller

Re: [edk2-devel] [PATCH edk2-platforms 08/16] Silicon/NXP: PciHostBridgeLib: Dump Layerscale iATU windows

2020-05-22 Thread Ard Biesheuvel
On 5/22/20 1:02 AM, Wasim Khan wrote: From: Wasim Khan Dump ATU windows for PCIe Layerscape controller if PcdPciDebug is enabled. Signed-off-by: Wasim Khan --- .../Library/PciHostBridgeLib/PciHostBridgeLib.c| 42 ++ 1 file changed, 42 insertions(+) diff --git

[edk2-devel] Hard Feature Freeze starts now for edk2-stable202005

2020-05-22 Thread Liming Gao
Hi, all Today, we enter into Hard Feature Freeze phase until edk2-stable202005 tag is created at 2020-05-29. In this phase, there is no feature to be pushed. The critical bug fix is still allowed. If the patch is sent after Hard Feature Freeze, and plans to catch this stable tag, please

Re: [edk2-devel] [PATCH edk2-platforms 01/16] Silicon/NXP/NxpQoriqLs.dec: Add PCIe related PCDs.

2020-05-22 Thread Ard Biesheuvel
On 5/22/20 1:02 AM, Wasim Khan wrote: From: Wasim Khan Add PCIe related PCDs. Signed-off-by: Vabhav Sharma Please drop this signoff. This is not the correct way to acknowledge (co-)authorship. Signed-off-by: Wasim Khan --- Silicon/NXP/NxpQoriqLs.dec | 9 + 1 file changed, 9

Re: [edk2-devel] [PATCH edk2-platforms 05/16] Silicon/NXP: PciHostBridgeLib: Setup PCIe LsGen4 Controller and ATU Windows

2020-05-22 Thread Ard Biesheuvel
On 5/22/20 1:02 AM, Wasim Khan wrote: From: Wasim Khan Setup PCIe LayerscapeGen4 controller and setup CFG, IO, MMIO and MMIO64 iATU windows. Check for PcdPciLsGen4Ctrl to enable LsGen4 PCIe controller. Signed-off-by: Vabhav Sharma Signed-off-by: Wasim Khan How much overlap is there

Re: [edk2-devel] [PATCH edk2-platforms 11/16] Silicon/NXP: PciSegmentLib: Add support PCIe LsGen4 Controller

2020-05-22 Thread Ard Biesheuvel
On 5/22/20 1:02 AM, Wasim Khan wrote: From: Wasim Khan PCIe Layerscape Gen4 controller is not ECAM complaint and have compliant different PCI config space region for bus 0 (Controller space) and bus[0x1-0xff] on NXP SoCs. For config transactions for Bus0: - Config transaction address =

[edk2-devel] [PATCH v2] ArmPkg/PlatformBootManagerLib: connect non-discoverable USB hosts

2020-05-22 Thread Ard Biesheuvel
The way the BDS handles the short-form USB device path of the console keyboard relies on USB host controllers to be locatable via their PCI metadata, which implies that these controllers already have a PCI I/O protocol installed on their handle. This is not the case for non-discoverable USB host

Re: [edk2-devel] [PATCH edk2-platforms 07/16] Silicon/NXP: PciHostBridgeLib: Dump Layerscale Gen4 ATU windows

2020-05-22 Thread Ard Biesheuvel
On 5/22/20 1:02 AM, Wasim Khan wrote: From: Wasim Khan Dump ATU windows for PCIe LsGen4 controller if PcdPciDebug is enabled. Signed-off-by: Vabhav Sharma Signed-off-by: Wasim Khan --- .../Library/PciHostBridgeLib/PciHostBridgeLib.inf | 1 +

Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

2020-05-22 Thread Ard Biesheuvel
On 5/21/20 10:22 PM, Laszlo Ersek wrote: On 05/21/20 16:16, Leif Lindholm wrote: OK, then I would vote *for* merging the patch regardless. We know how long some toolchain versions can stick around simply because they were mentioned in some blog post somewhere that ended up high in search

Re: [edk2-devel] [PATCH edk2-platforms 09/16] Silicon/NXP: Implement PciSegmentLib for PCIe Layerscape Controller

2020-05-22 Thread Ard Biesheuvel
On 5/22/20 1:02 AM, Wasim Khan wrote: From: Wasim Khan We have different PCI config space region for bus 0 (Controller space) and bus[0x1-0xff] on NXP SoCs with PCIe LS controller. Add PciSegmentLib for PCIe LS controller. For config transactions for Bus0: - Config transaction address =

Re: [edk2-devel] [PATCH edk2-platforms 13/16] Silicon/NXP/Drivers: Implement PciCpuIo2Dxe Driver

2020-05-22 Thread Ard Biesheuvel
On 5/22/20 1:02 AM, Wasim Khan wrote: From: Wasim Khan NXP SoC has multiple PCIe RCs and there is no fix translation offset between I/O port accesses and MMIO accesses. Add PciCpuIo2Dxe driver to implement EFI_CPU_IO2_PROTOCOL to add the translation for different RCs for IO access.

Re: [edk2-devel] [PATCH edk2-platforms 12/16] Silicon/NXP: PciSegmentLib: LsGen4Ctrl: Add Workaround for A-011264

2020-05-22 Thread Ard Biesheuvel
On 5/22/20 1:02 AM, Wasim Khan wrote: From: Wasim Khan With PCIe LsGen4 controller, clearing the Bus Master Enable bit in Command register blocks all outbound transactions to be sent out in RC mode. According to PCI Express base specification, the Command register’s Bus Master Enable bit of a

Re: [edk2-devel] [PATCH edk2-platforms 03/16] Silicon/NXP: Implement PciHostBridgeLib support

2020-05-22 Thread Ard Biesheuvel
On 5/22/20 1:02 AM, Wasim Khan wrote: From: Wasim Khan Implement PciHostBridgeLib that exposes the PCIe root complexes to the generic PCI host bridge driver. Setup PCIe Layerscape Controller and setup CFG, IO, MMIO and MMIO64 iATU windows. Signed-off-by: Vabhav Sharma Signed-off-by: Wasim

Re: [edk2-devel] [PATCH edk2-platforms 10/16] Silicon/NXP: PciSegmentLib: Add ECAM config support for PCIe LS Controller

2020-05-22 Thread Ard Biesheuvel
On 5/22/20 1:02 AM, Wasim Khan wrote: From: Wasim Khan PCIe Layerscape controller can be enabled for ECAM style configuration access using CFG SHIFT Feature. Check for PcdPciCfgShiftEnable to decide the configuration access scheme to be used with PCIe LS controller. Signed-off-by: Wasim Khan

Re: [edk2-devel] [PATCH edk2-platforms 14/16] Platform/NXP: LS1043aRdbPkg: Enable NetworkPkg

2020-05-22 Thread Ard Biesheuvel
On 5/22/20 1:02 AM, Wasim Khan wrote: From: Wasim Khan Enable NetworkPkg for LS1043aRdb Platform. Signed-off-by: Meenakshi Aggarwal Drop the signoff please. If Meenakshi wrote the patch, make them the author not the submitter. Signed-off-by: Wasim Khan ---

Re: [edk2-devel] [PATCH edk2-platforms 16/16] Platform/NXP: LS1043aRdbPkg : Increase fv image size

2020-05-22 Thread Ard Biesheuvel
On 5/22/20 1:02 AM, Wasim Khan wrote: From: Wasim Khan Increase fv image size to pass debug build. Signed-off-by: Wasim Khan Acked-by: Ard Biesheuvel --- Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git

Re: [edk2-devel] [PATCH v8 14/46] OvmfPkg/VmgExitLib: Support string IO for IOIO_PROT NAE events

2020-05-22 Thread Laszlo Ersek
On 05/19/20 23:50, Lendacky, Thomas wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 > > Add support to the #VC exception handler to handle string IO. This > requires expanding the IO instruction parsing to recognize string based > IO instructions as well as preparing an

Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

2020-05-22 Thread Leif Lindholm
On Thu, May 21, 2020 at 22:22:58 +0200, Laszlo Ersek wrote: > On 05/21/20 16:16, Leif Lindholm wrote: > > > OK, then I would vote *for* merging the patch regardless. We know how > > long some toolchain versions can stick around simply because they were > > mentioned in some blog post somewhere

Re: [edk2-devel] [PATCH v1 0/3] Compile AML bytecode array into OBJ file

2020-05-22 Thread PierreGondois
Hello Bob and Liming, What do you think about the patch? Do you think it goes in the right direction? Regards, Pierre -Original Message- From: devel@edk2.groups.io On Behalf Of PierreGondois via groups.io Sent: Monday, May 18, 2020 3:32 PM To: Pierre Gondois ; devel@edk2.groups.io Cc:

Re: [edk2-devel] [PATCH] MdePkg/Include: AARCH64: disable outline atomics on GCC 10.2+

2020-05-22 Thread Leif Lindholm
On Fri, May 22, 2020 at 12:12:02 +0200, Ard Biesheuvel wrote: > GCC 10 enabled a feature by default that was introduced in GCC 9, > which results in atomic operations to be emitted as function calls > to intrinsics provided by a runtime library. > > Atomics are hardly used in EDK2, which runs on

Re: [edk2-devel] [PATCH] MdePkg/Include: AARCH64: disable outline atomics on GCC 10.2+

2020-05-22 Thread Leif Lindholm
On Fri, May 22, 2020 at 14:05:02 +0200, Ard Biesheuvel wrote: > On 5/22/20 1:41 PM, Leif Lindholm wrote: > > On Fri, May 22, 2020 at 12:12:02 +0200, Ard Biesheuvel wrote: > > > GCC 10 enabled a feature by default that was introduced in GCC 9, > > > which results in atomic operations to be emitted

Re: [edk2-devel] [PATCH] MdePkg/Include: AARCH64: disable outline atomics on GCC 10.2+

2020-05-22 Thread Ard Biesheuvel
On 5/22/20 2:14 PM, Leif Lindholm wrote: On Fri, May 22, 2020 at 14:05:02 +0200, Ard Biesheuvel wrote: On 5/22/20 1:41 PM, Leif Lindholm wrote: On Fri, May 22, 2020 at 12:12:02 +0200, Ard Biesheuvel wrote: GCC 10 enabled a feature by default that was introduced in GCC 9, which results in

Re: [edk2-devel] [PATCH v2] ArmPkg/PlatformBootManagerLib: connect non-discoverable USB hosts

2020-05-22 Thread Ard Biesheuvel
On 5/22/20 2:03 PM, Leif Lindholm wrote: On Fri, May 22, 2020 at 10:40:06 +0200, Ard Biesheuvel wrote: The way the BDS handles the short-form USB device path of the console keyboard relies on USB host controllers to be locatable via their PCI metadata, which implies that these controllers

Re: [edk2-devel] [PATCH v8 13/46] OvmfPkg/VmgExitLib: Add support for IOIO_PROT NAE events

2020-05-22 Thread Laszlo Ersek
On 05/21/20 19:25, Laszlo Ersek wrote: > On 05/19/20 23:50, Lendacky, Thomas wrote: >> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 >> >> Under SEV-ES, a IOIO_PROT intercept generates a #VC exception. VMGEXIT >> must be used to allow the hypervisor to handle this intercept. >> >> Add

Re: [edk2-devel] [PATCH v8 16/46] OvmfPkg/VmgExitLib: Add support for MSR_PROT NAE events

2020-05-22 Thread Laszlo Ersek
On 05/19/20 23:50, Lendacky, Thomas wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 > > Under SEV-ES, a MSR_PROT intercept generates a #VC exception. VMGEXIT must > be used to allow the hypervisor to handle this intercept. > > Add support to construct the required GHCB values to

[edk2-devel] [PATCH edk2-platforms 10/16] Silicon/NXP: PciSegmentLib: Add ECAM config support for PCIe LS Controller

2020-05-22 Thread Wasim Khan
From: Wasim Khan PCIe Layerscape controller can be enabled for ECAM style configuration access using CFG SHIFT Feature. Check for PcdPciCfgShiftEnable to decide the configuration access scheme to be used with PCIe LS controller. Signed-off-by: Wasim Khan ---

[edk2-devel] [PATCH edk2-platforms 13/16] Silicon/NXP/Drivers: Implement PciCpuIo2Dxe Driver

2020-05-22 Thread Wasim Khan
From: Wasim Khan NXP SoC has multiple PCIe RCs and there is no fix translation offset between I/O port accesses and MMIO accesses. Add PciCpuIo2Dxe driver to implement EFI_CPU_IO2_PROTOCOL to add the translation for different RCs for IO access. Signed-off-by: Wasim Khan ---

[edk2-devel] [PATCH edk2-platforms 09/16] Silicon/NXP: Implement PciSegmentLib for PCIe Layerscape Controller

2020-05-22 Thread Wasim Khan
From: Wasim Khan We have different PCI config space region for bus 0 (Controller space) and bus[0x1-0xff] on NXP SoCs with PCIe LS controller. Add PciSegmentLib for PCIe LS controller. For config transactions for Bus0: - Config transaction address = PCIe controller address + offset For

[edk2-devel] [PATCH edk2-platforms 04/16] Silicon/NXP: PciHostBridgeLib: CFG Shift feature support for PCIeLS Ctrl

2020-05-22 Thread Wasim Khan
From: Wasim Khan PCIe layerscape controller supports CFG Shift feature. It can be enabled by setting BIT[28] of iATU Control 2 Register. Check PcdPciCfgShiftEnable to enable 'CFG Shift feature' in PCIe controller. if enable, PCIe layerscape controller shifts BDF from bits[27:12] to bits[31:16]

[edk2-devel] [PATCH edk2-platforms 03/16] Silicon/NXP: Implement PciHostBridgeLib support

2020-05-22 Thread Wasim Khan
From: Wasim Khan Implement PciHostBridgeLib that exposes the PCIe root complexes to the generic PCI host bridge driver. Setup PCIe Layerscape Controller and setup CFG, IO, MMIO and MMIO64 iATU windows. Signed-off-by: Vabhav Sharma Signed-off-by: Wasim Khan ---

[edk2-devel] [PATCH edk2-platforms 08/16] Silicon/NXP: PciHostBridgeLib: Dump Layerscale iATU windows

2020-05-22 Thread Wasim Khan
From: Wasim Khan Dump ATU windows for PCIe Layerscape controller if PcdPciDebug is enabled. Signed-off-by: Wasim Khan --- .../Library/PciHostBridgeLib/PciHostBridgeLib.c| 42 ++ 1 file changed, 42 insertions(+) diff --git

[edk2-devel] [PATCH edk2-platforms 16/16] Platform/NXP: LS1043aRdbPkg : Increase fv image size

2020-05-22 Thread Wasim Khan
From: Wasim Khan Increase fv image size to pass debug build. Signed-off-by: Wasim Khan --- Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf

[edk2-devel] [PATCH edk2-platforms 14/16] Platform/NXP: LS1043aRdbPkg: Enable NetworkPkg

2020-05-22 Thread Wasim Khan
From: Wasim Khan Enable NetworkPkg for LS1043aRdb Platform. Signed-off-by: Meenakshi Aggarwal Signed-off-by: Wasim Khan --- Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc | 11 +++ Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf | 5 + 2 files changed, 16 insertions(+) diff --git

[edk2-devel] [PATCH edk2-platforms 05/16] Silicon/NXP: PciHostBridgeLib: Setup PCIe LsGen4 Controller and ATU Windows

2020-05-22 Thread Wasim Khan
From: Wasim Khan Setup PCIe LayerscapeGen4 controller and setup CFG, IO, MMIO and MMIO64 iATU windows. Check for PcdPciLsGen4Ctrl to enable LsGen4 PCIe controller. Signed-off-by: Vabhav Sharma Signed-off-by: Wasim Khan --- Silicon/NXP/NxpQoriqLs.dec | 1 +

[edk2-devel] [PATCH edk2-platforms 06/16] Silicon/NXP: PciHostBridgeLib: add Workaround for A-011451

2020-05-22 Thread Wasim Khan
From: Wasim Khan When PCIe Layerscape Gen4 controller is sending multiple split completions and ACK latency expires indicating that ACK should be send at priority. But because of large number of split completions and FC update DLLP,the controller does not give priority to ACK transmission. This

[edk2-devel] [PATCH edk2-platforms 12/16] Silicon/NXP: PciSegmentLib: LsGen4Ctrl: Add Workaround for A-011264

2020-05-22 Thread Wasim Khan
From: Wasim Khan With PCIe LsGen4 controller, clearing the Bus Master Enable bit in Command register blocks all outbound transactions to be sent out in RC mode. According to PCI Express base specification, the Command register’s Bus Master Enable bit of a PCI Express RC controller can only

[edk2-devel] [PATCH edk2-platforms 15/16] Platform/NXP: LS1043aRdbPkg: Enable PCIE support

2020-05-22 Thread Wasim Khan
From: Wasim Khan Enable generic PCIe drivers and Wire up PciHostBridgeLib, PciSegmentLib and PciCpuIo2Dxe. Signed-off-by: Wasim Khan --- Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc | 9 + Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf | 7 +++ 2 files changed, 16 insertions(+)

[edk2-devel] [PATCH edk2-platforms 02/16] Silicon/NXP: LS1043A: Define PCIe related PCDs

2020-05-22 Thread Wasim Khan
From: Wasim Khan Define PCIe related PCDs for LS1043A. Signed-off-by: Vabhav Sharma Signed-off-by: Wasim Khan --- Silicon/NXP/LS1043A/LS1043A.dsc.inc | 8 1 file changed, 8 insertions(+) diff --git a/Silicon/NXP/LS1043A/LS1043A.dsc.inc b/Silicon/NXP/LS1043A/LS1043A.dsc.inc index

[edk2-devel] [PATCH edk2-platforms 07/16] Silicon/NXP: PciHostBridgeLib: Dump Layerscale Gen4 ATU windows

2020-05-22 Thread Wasim Khan
From: Wasim Khan Dump ATU windows for PCIe LsGen4 controller if PcdPciDebug is enabled. Signed-off-by: Vabhav Sharma Signed-off-by: Wasim Khan --- .../Library/PciHostBridgeLib/PciHostBridgeLib.inf | 1 + .../Library/PciHostBridgeLib/PciHostBridgeLib.c| 34 ++ 2

[edk2-devel] [PATCH edk2-platforms 01/16] Silicon/NXP/NxpQoriqLs.dec: Add PCIe related PCDs.

2020-05-22 Thread Wasim Khan
From: Wasim Khan Add PCIe related PCDs. Signed-off-by: Vabhav Sharma Signed-off-by: Wasim Khan --- Silicon/NXP/NxpQoriqLs.dec | 9 + 1 file changed, 9 insertions(+) diff --git a/Silicon/NXP/NxpQoriqLs.dec b/Silicon/NXP/NxpQoriqLs.dec index 0722f59ef4f6..bafdfd9f4298 100644 ---

[edk2-devel] [PATCH edk2-platforms 00/16] Add PCIe Support

2020-05-22 Thread Wasim Khan
From: Wasim Khan Add PCIe Support for NXP Layerscape SoC which supports different PCIe controllers. Use generic PCIe drivers and wire up PciHostBridgeLib, PciSegmentLib and PciCpuIo2Dxe driver for controller specific implementation. Wasim Khan (16): Silicon/NXP/NxpQoriqLs.dec: Add PCIe

[edk2-devel] [PATCH edk2-platforms 11/16] Silicon/NXP: PciSegmentLib: Add support PCIe LsGen4 Controller

2020-05-22 Thread Wasim Khan
From: Wasim Khan PCIe Layerscape Gen4 controller is not ECAM complaint and have different PCI config space region for bus 0 (Controller space) and bus[0x1-0xff] on NXP SoCs. For config transactions for Bus0: - Config transaction address = PCIe controller address + offset For config

Re: [edk2-devel] [PATCH v2] ArmPkg/PlatformBootManagerLib: connect non-discoverable USB hosts

2020-05-22 Thread Leif Lindholm
On Fri, May 22, 2020 at 14:06:16 +0200, Ard Biesheuvel wrote: > On 5/22/20 2:03 PM, Leif Lindholm wrote: > > On Fri, May 22, 2020 at 10:40:06 +0200, Ard Biesheuvel wrote: > > > The way the BDS handles the short-form USB device path of the console > > > keyboard relies on USB host controllers to be

Re: [edk2-devel] [PATCH] MdePkg/Include: AARCH64: disable outline atomics on GCC 10.2+

2020-05-22 Thread Leif Lindholm
On Fri, May 22, 2020 at 14:42:34 +0200, Ard Biesheuvel wrote: > > > > > --- > > > > > The GCC support for this pragma has already been pulled into the 10.2 > > > > > release branch. I think we should consider adding this to the stable > > > > > tag, so that the issue can easily be resolved by

Re: [edk2-devel] [PATCH edk2-platforms 00/16] Add PCIe Support

2020-05-22 Thread Ard Biesheuvel
On 5/22/20 1:02 AM, Wasim Khan wrote: From: Wasim Khan Add PCIe Support for NXP Layerscape SoC which supports different PCIe controllers. Use generic PCIe drivers and wire up PciHostBridgeLib, PciSegmentLib and PciCpuIo2Dxe driver for controller specific implementation. Thanks. This is

Re: [edk2-devel] [PATCH v2] ArmPkg/PlatformBootManagerLib: connect non-discoverable USB hosts

2020-05-22 Thread Leif Lindholm
On Fri, May 22, 2020 at 10:40:06 +0200, Ard Biesheuvel wrote: > The way the BDS handles the short-form USB device path of the console > keyboard relies on USB host controllers to be locatable via their PCI > metadata, which implies that these controllers already have a PCI I/O > protocol installed

Re: [edk2-devel] [PATCH] MdePkg/Include: AARCH64: disable outline atomics on GCC 10.2+

2020-05-22 Thread Ard Biesheuvel
On 5/22/20 1:41 PM, Leif Lindholm wrote: On Fri, May 22, 2020 at 12:12:02 +0200, Ard Biesheuvel wrote: GCC 10 enabled a feature by default that was introduced in GCC 9, which results in atomic operations to be emitted as function calls to intrinsics provided by a runtime library. Atomics are

[edk2-devel] [PATCH V4] SbsaQemu: EFI implementation for SbsaQemu platform

2020-05-22 Thread Tanmay Jagdale
From: Radoslaw Biernacki Linaro LDCG group is coordinating work for adding SBSA compliant virtual platform for QEMU. This patch adds initial support for this platform with nondiscoverable AHCI, VGA and single DRAM window over 32bit address space. We are using FDF to compose EFI flash images

[edk2-devel] [PATCH] MdePkg/Include: AARCH64: disable outline atomics on GCC 10.2+

2020-05-22 Thread Ard Biesheuvel
GCC 10 enabled a feature by default that was introduced in GCC 9, which results in atomic operations to be emitted as function calls to intrinsics provided by a runtime library. Atomics are hardly used in EDK2, which runs on a single CPU anyway, and any benefit that would result from reusing

Re: [edk2-devel] [PATCH v8 15/46] OvmfPkg/VmgExitLib: Add support for CPUID NAE events

2020-05-22 Thread Laszlo Ersek
On 05/19/20 23:50, Lendacky, Thomas wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 > > Under SEV-ES, a CPUID intercept generates a #VC exception. VMGEXIT must be > used to allow the hypervisor to handle this intercept. > > Add support to construct the required GHCB values to

Re: [edk2-devel] [PATCH edk2-platforms 00/16] Add PCIe Support

2020-05-22 Thread Leif Lindholm
On Fri, May 22, 2020 at 11:46:07 +0200, Ard Biesheuvel wrote: > On 5/22/20 1:02 AM, Wasim Khan wrote: > > From: Wasim Khan > > > > Add PCIe Support for NXP Layerscape SoC which supports > > different PCIe controllers. > > Use generic PCIe drivers and wire up PciHostBridgeLib, > > PciSegmentLib

Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

2020-05-22 Thread Ard Biesheuvel
On 5/22/20 12:54 PM, Leif Lindholm wrote: On Thu, May 21, 2020 at 22:22:58 +0200, Laszlo Ersek wrote: On 05/21/20 16:16, Leif Lindholm wrote: OK, then I would vote *for* merging the patch regardless. We know how long some toolchain versions can stick around simply because they were mentioned

Re: [edk2-devel] [PATCH v8 17/46] OvmfPkg/VmgExitLib: Add support for NPF NAE events (MMIO)

2020-05-22 Thread Laszlo Ersek
On 05/22/20 16:14, Laszlo Ersek wrote: > INT64 Displacement; > Displacement *= (1 << Ext->Sib.Scale); > (10c) Multiplying a negative INT64 by 1, 2, 4, or 8 is well-defined > (assuming again that the initial Displacement value is small enough, > which depends on the original instruction). >

Re: [edk2-devel] [PATCH v8 19/46] OvmfPkg/VmgExitLib: Add support for RDTSC NAE events

2020-05-22 Thread Laszlo Ersek
On 05/19/20 23:50, Lendacky, Thomas wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 > > Under SEV-ES, a RDTSC intercept generates a #VC exception. VMGEXIT must be > used to allow the hypervisor to handle this intercept. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard

Re: [edk2-devel] [PATCH v8 22/46] OvmfPkg/VmgExitLib: Add support for VMMCALL NAE events

2020-05-22 Thread Laszlo Ersek
On 05/19/20 23:50, Lendacky, Thomas wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 > > Under SEV-ES, a VMMCALL intercept generates a #VC exception. VMGEXIT must > be used to allow the hypervisor to handle this intercept. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard

Re: [edk2-devel] [PATCH v8 18/46] OvmfPkg/VmgExitLib: Add support for WBINVD NAE events

2020-05-22 Thread Laszlo Ersek
On 05/19/20 23:50, Lendacky, Thomas wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 > > Under SEV-ES, a WBINVD intercept generates a #VC exception. VMGEXIT must be > used to allow the hypervisor to handle this intercept. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard

Re: [edk2-devel] [PATCH v8 20/46] OvmfPkg/VmgExitLib: Add support for RDPMC NAE events

2020-05-22 Thread Laszlo Ersek
On 05/19/20 23:50, Lendacky, Thomas wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 > > Under SEV-ES, a RDPMC intercept generates a #VC exception. VMGEXIT must be > used to allow the hypervisor to handle this intercept. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard

Re: [edk2-devel] [PATCH v8 21/46] OvmfPkg/VmgExitLib: Add support for INVD NAE events

2020-05-22 Thread Laszlo Ersek
On 05/19/20 23:50, Lendacky, Thomas wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 > > Under SEV-ES, a INVD intercept generates a #VC exception. VMGEXIT must be > used to allow the hypervisor to handle this intercept. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard

Re: [edk2-devel] Hard Feature Freeze starts now for edk2-stable202005

2020-05-22 Thread Bret Barkelew via groups.io
We’d like to ask that this patch be considered for the stable tag: [PATCH v1 1/1] UnitTestFrameworkPkg/UnitTestResultReportLib: Use AsciiStrnCpyS() https://bugzilla.tianocore.org/show_bug.cgi?id=2721 The patch was reviewed prior to the hard freeze date, and is a small change that affects

Re: [edk2-devel] [PATCH v8 22/46] OvmfPkg/VmgExitLib: Add support for VMMCALL NAE events

2020-05-22 Thread Laszlo Ersek
On 05/22/20 16:48, Laszlo Ersek wrote: > On 05/19/20 23:50, Lendacky, Thomas wrote: >> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 >> >> Under SEV-ES, a VMMCALL intercept generates a #VC exception. VMGEXIT must >> be used to allow the hypervisor to handle this intercept. >> >> Cc:

Re: [edk2-devel] [PATCH v8 25/46] OvmfPkg/VmgExitLib: Add support for MWAIT/MWAITX NAE events

2020-05-22 Thread Laszlo Ersek
On 05/19/20 23:50, Lendacky, Thomas wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 > > Under SEV-ES, a MWAIT/MWAITX intercept generates a #VC exception. > VMGEXIT must be used to allow the hypervisor to handle this intercept. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard

Re: [edk2-devel] [PATCH v8 13/46] OvmfPkg/VmgExitLib: Add support for IOIO_PROT NAE events

2020-05-22 Thread Lendacky, Thomas
On 5/22/20 5:05 AM, Laszlo Ersek wrote: On 05/21/20 19:25, Laszlo Ersek wrote: On 05/19/20 23:50, Lendacky, Thomas wrote: BZ:

Re: [edk2-devel] [PATCH v8 23/46] OvmfPkg/VmgExitLib: Add support for RDTSCP NAE events

2020-05-22 Thread Laszlo Ersek
On 05/19/20 23:50, Lendacky, Thomas wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 > > Under SEV-ES, a RDTSCP intercept generates a #VC exception. VMGEXIT must be > used to allow the hypervisor to handle this intercept. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard

Re: [edk2-devel] [PATCH v8 13/46] OvmfPkg/VmgExitLib: Add support for IOIO_PROT NAE events

2020-05-22 Thread Lendacky, Thomas
On 5/21/20 12:25 PM, Laszlo Ersek wrote: On 05/19/20 23:50, Lendacky, Thomas wrote: BZ:

Re: [edk2-devel] [PATCH v8 17/46] OvmfPkg/VmgExitLib: Add support for NPF NAE events (MMIO)

2020-05-22 Thread Laszlo Ersek
On 05/19/20 23:50, Lendacky, Thomas wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 > > Under SEV-ES, a NPF intercept for an NPT entry with a reserved bit set > generates a #VC exception. This condition is assumed to be an MMIO access. > VMGEXIT must be used to allow the

Re: [edk2-devel] [PATCH v8 24/46] OvmfPkg/VmgExitLib: Add support for MONITOR/MONITORX NAE events

2020-05-22 Thread Laszlo Ersek
On 05/19/20 23:50, Lendacky, Thomas wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 > > Under SEV-ES, a MONITOR/MONITORX intercept generates a #VC exception. > VMGEXIT must be used to allow the hypervisor to handle this intercept. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc:

Re: [edk2-devel] [PATCH v8 26/46] OvmfPkg/VmgExitLib: Add support for DR7 Read/Write NAE events

2020-05-22 Thread Laszlo Ersek
On 05/19/20 23:50, Lendacky, Thomas wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 > > Under SEV-ES, a DR7 read or write intercept generates a #VC exception. > The #VC handler must provide special support to the guest for this. On > a DR7 write, the #VC handler must cache the

Re: [EXTERNAL] Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

2020-05-22 Thread Laszlo Ersek
On 05/22/20 07:48, Bret Barkelew wrote: > In Mu we have a similar problem of keeping track of what features/bugs > have already been upstreamed and when can they be dropped during an > upstream integration, so that's the more personal interest I have in > such automation. Proposal: - Whenever

Re: [edk2-devel] [PATCH] MdeModulePkg/NonDiscoverablePciDeviceDxe: connect handles on registration

2020-05-22 Thread Laszlo Ersek
On 05/21/20 23:58, Ard Biesheuvel wrote: > ConnectController() does not work for these handles - that will result > in the created PciIo protocol to be connected immediately as well (the > non-recursive bit about ConnectController() appears to refer to > connecting newly created handles by bus

Re: [edk2-devel] [PATCH] MdeModulePkg/NonDiscoverablePciDeviceDxe: connect handles on registration

2020-05-22 Thread Laszlo Ersek
On 05/22/20 18:46, Laszlo Ersek wrote: > the spec led me to believe Well, if I had read a few more pages from the spec... It's totally my fault! :) sorry, it's Friday! :) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#60159):

Re: [edk2-devel] [PATCH] MdeModulePkg/NonDiscoverablePciDeviceDxe: connect handles on registration

2020-05-22 Thread Laszlo Ersek
On 05/22/20 18:36, Laszlo Ersek wrote: > On 05/21/20 23:58, Ard Biesheuvel wrote: > >> ConnectController() does not work for these handles - that will result >> in the created PciIo protocol to be connected immediately as well (the >> non-recursive bit about ConnectController() appears to refer

Re: [edk2-devel] [PATCH] MdeModulePkg/NonDiscoverablePciDeviceDxe: connect handles on registration

2020-05-22 Thread Ard Biesheuvel
On 5/22/20 6:48 PM, Laszlo Ersek wrote: On 05/22/20 18:46, Laszlo Ersek wrote: the spec led me to believe Well, if I had read a few more pages from the spec... It's totally my fault! :) sorry, it's Friday! :) No worries, thanks for taking the time to dig into this. I had already noticed

Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

2020-05-22 Thread Laszlo Ersek
On 05/22/20 15:27, Ard Biesheuvel wrote: > On 5/22/20 12:54 PM, Leif Lindholm wrote: >> On Thu, May 21, 2020 at 22:22:58 +0200, Laszlo Ersek wrote: >>> On 05/21/20 16:16, Leif Lindholm wrote: >>> OK, then I would vote *for* merging the patch regardless. We know how long some toolchain

Re: [edk2-devel] [edk2][PATCH 1/1] HttpBoot: handle servers which may FIN after file sizing in HttpBootLoadFile

2020-05-22 Thread Andrei Warkentin
Thank you. I made the updates and will now send v2. A From: devel@edk2.groups.io on behalf of Maciej Rabeda via groups.io Sent: Tuesday, May 19, 2020 7:02 AM To: Andrei Warkentin ; devel@edk2.groups.io Cc: jiaxin...@intel.com ; siyuan...@intel.com Subject:

[edk2-devel] [edk2][PATCH 1/1] NetworkPkg/HttpBootDxe: handle servers which may FIN after file sizing in HttpBootLoadFile

2020-05-22 Thread Andrei Warkentin
This is v2 with Maciej Rabeda's feedback. Python http.server seems to FIN after the first HEAD request to size the loaded file is completed and ACKed. What happens next is interesting. On low latency connections, the GET request to download may get sent after the server sends the FIN but before

Re: [edk2-devel] [PATCH v8 17/46] OvmfPkg/VmgExitLib: Add support for NPF NAE events (MMIO)

2020-05-22 Thread Lendacky, Thomas
On 5/22/20 9:14 AM, Laszlo Ersek wrote: On 05/19/20 23:50, Lendacky, Thomas wrote: BZ:

Re: [edk2-devel] [PATCH v2] ArmPkg/PlatformBootManagerLib: connect non-discoverable USB hosts

2020-05-22 Thread Laszlo Ersek
On 05/22/20 10:40, Ard Biesheuvel wrote: > The way the BDS handles the short-form USB device path of the console > keyboard relies on USB host controllers to be locatable via their PCI > metadata, which implies that these controllers already have a PCI I/O > protocol installed on their handle. >

Re: [edk2-devel] [PATCH v2] ArmPkg/PlatformBootManagerLib: connect non-discoverable USB hosts

2020-05-22 Thread Ard Biesheuvel
On 5/22/20 8:57 PM, Laszlo Ersek via groups.io wrote: On 05/22/20 10:40, Ard Biesheuvel wrote: The way the BDS handles the short-form USB device path of the console keyboard relies on USB host controllers to be locatable via their PCI metadata, which implies that these controllers already have

Re: [edk2-devel] [PATCH v8 15/46] OvmfPkg/VmgExitLib: Add support for CPUID NAE events

2020-05-22 Thread Lendacky, Thomas
On 5/22/20 5:27 AM, Laszlo Ersek wrote: On 05/19/20 23:50, Lendacky, Thomas wrote: BZ:

Re: [edk2-devel] [PATCH v8 16/46] OvmfPkg/VmgExitLib: Add support for MSR_PROT NAE events

2020-05-22 Thread Lendacky, Thomas
On 5/22/20 5:31 AM, Laszlo Ersek wrote: On 05/19/20 23:50, Lendacky, Thomas wrote: BZ:

Re: [edk2-devel] [PATCH] MdePkg/Include: AARCH64: disable outline atomics on GCC 10.2+

2020-05-22 Thread Laszlo Ersek
On 05/22/20 12:12, Ard Biesheuvel wrote: > GCC 10 enabled a feature by default that was introduced in GCC 9, > which results in atomic operations to be emitted as function calls > to intrinsics provided by a runtime library. > > Atomics are hardly used in EDK2, which runs on a single CPU anyway,

Re: [edk2-devel] [PATCH] MdePkg/Include: AARCH64: disable outline atomics on GCC 10.2+

2020-05-22 Thread Laszlo Ersek
On 05/22/20 22:01, Laszlo Ersek wrote: > On 05/22/20 12:12, Ard Biesheuvel wrote: >> GCC 10 enabled a feature by default that was introduced in GCC 9, >> which results in atomic operations to be emitted as function calls >> to intrinsics provided by a runtime library. >> >> Atomics are hardly used

Re: [edk2-devel] [PATCH v3 09/14] MdeModulePkg: Connect VariablePolicy business logic to VariableServices

2020-05-22 Thread Laszlo Ersek
Hello, (+Ard) this patch does not apply (with "master" being at 74f90d38c446). Because: On 05/22/20 00:43, Michael Kubacki wrote: > diff --git > a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.inf > b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.inf >

Re: [edk2-devel] [PATCH v8 18/46] OvmfPkg/VmgExitLib: Add support for WBINVD NAE events

2020-05-22 Thread Lendacky, Thomas
On 5/22/20 9:19 AM, Laszlo Ersek wrote: On 05/19/20 23:50, Lendacky, Thomas wrote: BZ:

[edk2-devel] [FIXUPS edk2-platforms 0/3] SbsaQemu layout changes and minor cleanup

2020-05-22 Thread Leif Lindholm
The SbsaQemu platform port has been in flight for a long time now, so to facilitate getting it merged, here is a set of proposed layout changes and minor tweaks that I would prefer to have included. I also propose changing the commit message as follows: --- SbsaQemu: add port for SbsaQemu

[edk2-devel] [FIXUPS edk2-platforms 3/3] Maintainers.txt: update format

2020-05-22 Thread Leif Lindholm
Since this set started, edk2-platforms has migrated to the new Maintainers.txt format - adjust the entry accordingly. As part of this, squash Platform and Silicon portions into a single section entry. Also, flip Graeme Gregory from M: to R:, since he does not have repository write access.

[edk2-devel] [FIXUPS edk2-platforms 1/3] Silicon/Qemu: mirror Platform layout

2020-05-22 Thread Leif Lindholm
Platform/Qemu is empty, apart from the SbsaQemu dirctory, which holds SbsaQemu.dsc and SbsaQemu.fdf. Silicon/Qemu held Drivers, Library and a file called SbsaQemuPkg.dec. Move them all into a subdirectory called SbsaQemu, and drop the Pkg but from the .dec name. Signed-off-by: Leif Lindholm ---

[edk2-devel] [FIXUPS edk2-platforms 2/3] Silicon/Qemu: clean up SbsaQemu.dec

2020-05-22 Thread Leif Lindholm
For some reason, SbsaQemu.dec holds a spurious LibraryClasses declaration for ArmPlatformLib - nuke it. Signed-off-by: Leif Lindholm --- Silicon/Qemu/SbsaQemu/SbsaQemu.dec | 3 --- 1 file changed, 3 deletions(-) diff --git a/Silicon/Qemu/SbsaQemu/SbsaQemu.dec

Re: [edk2-devel] [PATCH v8 22/46] OvmfPkg/VmgExitLib: Add support for VMMCALL NAE events

2020-05-22 Thread Lendacky, Thomas
On 5/22/20 9:50 AM, Laszlo Ersek via groups.io wrote: On 05/22/20 16:48, Laszlo Ersek wrote: On 05/19/20 23:50, Lendacky, Thomas wrote: BZ:

Re: [edk2-devel] [PATCH] MdePkg/Include: AARCH64: disable outline atomics on GCC 10.2+

2020-05-22 Thread Ard Biesheuvel
On 5/22/20 10:05 PM, Laszlo Ersek via groups.io wrote: On 05/22/20 22:01, Laszlo Ersek wrote: On 05/22/20 12:12, Ard Biesheuvel wrote: GCC 10 enabled a feature by default that was introduced in GCC 9, which results in atomic operations to be emitted as function calls to intrinsics provided by

Re: [edk2-devel] [PATCH v3 05/14] OvmfPkg: Add VariablePolicy engine to OvmfPkg platform

2020-05-22 Thread Laszlo Ersek
Hello Michael / Bret, I don't understand the (lack of) updates in this patch: On 05/22/20 00:43, Michael Kubacki wrote: > From: Bret Barkelew > > https://bugzilla.tianocore.org/show_bug.cgi?id=2522 > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Bret Barkelew >

Re: [edk2-devel] [PATCH v3 07/14] ArmVirtPkg: Add VariablePolicy engine to ArmVirtPkg platform

2020-05-22 Thread Laszlo Ersek
Hi, On 05/22/20 00:43, Michael Kubacki wrote: > From: Bret Barkelew > > https://bugzilla.tianocore.org/show_bug.cgi?id=2522 > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Bret Barkelew > Signed-off-by: Michael Kubacki > --- > ArmVirtPkg/ArmVirt.dsc.inc | 7 +++ >

Re: [EXTERNAL] Re: [edk2-devel] [PATCH v3 05/14] OvmfPkg: Add VariablePolicy engine to OvmfPkg platform

2020-05-22 Thread Bret Barkelew via groups.io
“Maybe you entirely missed my message that I posted in response to version 2 of this specific patch (i.e. you may have fully missed the message I link at the top). That could be the case because I mentioned "OvmfXen.dsc" under the v2 blurb as well.” Yup. That’s the one. Saw this request, but not