Re: [edk2-devel] [PATCH v2 11/12] OvmfPkg/LsiScsiDxe: Calculate the transferred bytes

On Thu, Jul 16, 2020 at 08:21:46PM +0200, Laszlo Ersek wrote: > On 07/16/20 09:46, Gary Lin wrote: > > Calculate the transferred bytes during data phases based on the > > Cumulative SCSI Byte Count (CSBC) and update > > InTransferLength/OutTransferLength of the request packet. > > > > Cc: Jordan

Re: [edk2-devel] [PATCH v2 10/12] OvmfPkg/LsiScsiDxe: Process the SCSI Request Packet

On Thu, Jul 16, 2020 at 07:37:09PM +0200, Laszlo Ersek wrote: > On 07/16/20 09:46, Gary Lin wrote: > > This is the second part of LsiScsiPassThru(). LsiScsiProcessRequest() is > > added to translate the SCSI Request Packet into the LSI 53C895A > > commands. This function utilizes the so-called

Re: [edk2-devel] [PATCH] MdeModulePkg: Upon BootOption failure, Destroy RamDisk memory before RSC.

With the patchcheck issue fixed. Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: Veliyathuparambil Prakashan, KrishnadasX > > Sent: Friday, July 17, 2020 12:09 PM > To: Gao, Liming ; Gao, Zhichao > Cc: Ni, Ray ; T V, Krishnamoorthy > ; devel@edk2.groups.io;

Re: [edk2-devel] [PATCH v3 1/1] MdeModulePkg/UsbBusDxe: Rebuild the description table after Reset Device

Hi Jeremy, I know that you want to continue booting without ASSERT. But what I care is that why the device error happened and if the change is the correct error handing. The change can make the ASSERT disappear, but the device still not work after it, so there are some other potential issue

Re: [edk2-devel] [PATCH V3 3/3] MdeModulePkg/PartitionDxe: Add already start check for child hanldes

Zhichao, What does the SUSE MBR table look like? Thanks, Ray > -Original Message- > From: Gao, Zhichao > Sent: Thursday, July 16, 2020 1:09 PM > To: Gary Lin ; devel@edk2.groups.io > Cc: Wu, Hao A ; Ni, Ray > Subject: RE: [edk2-devel] [PATCH V3 3/3] MdeModulePkg/PartitionDxe: Add >

Re: [edk2-devel] [PATCH] BaseTools/PatchCheck.py: Skip length check for user name in xxx-by

Reviewed-by: Liming Gao -Original Message- From: Zhang, Shenglei Sent: 2020年7月16日 11:14 To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming Subject: [PATCH] BaseTools/PatchCheck.py: Skip length check for user name in xxx-by REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2836

Re: [edk2-devel] [PATCH 1/1] CryptoPkg/OpensslLib: Upgrade OpenSSL to 1.1.1g

Guomin, Thank you very much for this upgrade. Just one comment. The opensslconf.h and dso_conf.h generated after calling process_files.pl are unix EOL. But the EOL in the patch is correct. I guess you converted them manually. I'd suggest that you update process_files.pl to do it automatically.

Re: [edk2-devel] [PATCH v2 1/7] SecurityPkg/TcgPpi: Add TcgPpi header file.

Hi Qi Please move the PRE_HASH flag here, and add description on PreHashData format. Thank you Yao Jiewen > -Original Message- > From: Zhang, Qi1 > Sent: Thursday, July 16, 2020 3:44 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J ; > Chao Zhang ; Zhang, Qi1 > Subject:

Re: [edk2-devel] [PATCH v2 3/7] SecurityPkg/Tcg: Add TcgPpi

Hi Qi Per the conversation between Bret Barkelew and I, we should install the TCG_PPI *before* any measurement. Please move it earlier. Thank you Yao Jiewen > -Original Message- > From: Zhang, Qi1 > Sent: Thursday, July 16, 2020 3:44 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ;

Re: [edk2-devel] [PATCH v2 4/7] SecurityPkg/Tcg2: Add TcgPpi

Hi Qi Per the conversation between Bret Barkelew and I, we should install the TCG_PPI *before* any measurement. Please move it earlier. Thank you Yao Jiewen > -Original Message- > From: Zhang, Qi1 > Sent: Thursday, July 16, 2020 3:44 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ;

Re: [edk2-devel] [PATCH V2 1/2] BaseTools: Add gcc flag to warn on void* pointer arithmetic

Reviewed-by: Yuwei Chen > -Original Message- > From: devel@edk2.groups.io On Behalf Of > PierreGondois > Sent: Tuesday, July 7, 2020 4:35 PM > To: devel@edk2.groups.io > Cc: Pierre Gondois ; Feng, Bob C > ; Gao, Liming ; > tomas.pi...@arm.com; n...@arm.com > Subject: [edk2-devel] [PATCH

[edk2-devel] [PATCH] Maintainers.txt: Remove invalid email address and a few other role changes

- Remove the address of Zhang, Chao from maintainer and reviewer list since he has left the community. Many thanks to his great contributions to edk2. - Add Yao, Jiewen as maintainer of CryptoPkg, but remove him from SignedCapsulePkg. - Add Wang, Jian J to maintainer list of SignedCapsulePkg

Re: [edk2-devel] [PATCH] Maintainers.txt: Remove invalid email address and a few other role changes

Reviewed-by: Jiewen Yao > -Original Message- > From: Wang, Jian J > Sent: Thursday, July 16, 2020 5:32 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Andrew Fish ; > Laszlo Ersek ; Leif Lindholm ; Kinney, > Michael D > Subject: [PATCH] Maintainers.txt: Remove invalid email address

Re: [edk2-devel] [PATCH] SignedCapsulePkg: Address NULL pointer dereference case.

Reviewed-by: Jiewen Yao > -Original Message- > From: Vin Xue > Sent: Tuesday, July 14, 2020 10:10 AM > To: devel@edk2.groups.io > Cc: Vin Xue ; Yao, Jiewen ; > Zhang, Chao B > Subject: [PATCH] SignedCapsulePkg: Address NULL pointer dereference case. > > Original code

Re: [edk2-devel] [PATCH v2 7/7] MdePkg/Tcg2Protocol: define Flag EFI_TCG2_PRE_HASH

Hi Qi We should not add this attribute to TCG2_PROTOCOL, which is defined by TCG. This attribute should be only applied to TCG_PPI. Please move it there. > -Original Message- > From: Zhang, Qi1 > Sent: Thursday, July 16, 2020 3:44 PM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 ; Kinney,

Re: [edk2-devel] [PATCH] BaseTools/PatchCheck.py: Skip length check for user name in xxx-by

Reviewed-by: Yuwei Chen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Zhang, > Shenglei > Sent: Thursday, July 16, 2020 11:14 AM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming > Subject: [edk2-devel] [PATCH] BaseTools/PatchCheck.py: Skip length check > for

Re: [edk2-devel] [PATCH] Maintainers.txt: Remove invalid email address and a few other role changes

Reviewed-by: Liming Gao -Original Message- From: devel@edk2.groups.io On Behalf Of Wang, Jian J Sent: 2020年7月16日 17:32 To: devel@edk2.groups.io Cc: Yao, Jiewen ; Andrew Fish ; Laszlo Ersek ; Leif Lindholm ; Kinney, Michael D Subject: [edk2-devel] [PATCH] Maintainers.txt: Remove

[edk2-devel] [PATCH v2 04/12] OvmfPkg/LsiScsiDxe: Probe PCI devices and look for LsiScsi

Implement LsiScsiControllerSupported() to probe the PCI ID and look for LSI 53C895A. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Signed-off-by: Gary Lin Reviewed-by: Laszlo Ersek --- OvmfPkg/Include/IndustryStandard/LsiScsi.h | 20 + OvmfPkg/LsiScsiDxe/LsiScsi.c

[edk2-devel] [PATCH v2 05/12] OvmfPkg/LsiScsiDxe: Install stubbed EXT_SCSI_PASS_THRU

Partially implement LsiScsiControllerStart() and LsiScsiControllerStop() to insert the scaffolding of EXT_SCSI_PASS_THRU functions. v2: Remove the closing of PciIo protocol from LsiScsiControllerStop(). Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Signed-off-by: Gary Lin

[edk2-devel] [PATCH v2 02/12] OvmfPkg/LsiScsiDxe: Install the skeleton of driver binding

Implement the dummy functions for EFI Driver Binding protocol. v2: Remove "STATIC" from LsiScsiControllerSupported() Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Signed-off-by: Gary Lin Reviewed-by: Laszlo Ersek --- OvmfPkg/LsiScsiDxe/LsiScsi.c | 72

[edk2-devel] [PATCH v2 08/12] OvmfPkg/LsiScsiDxe: Map DMA buffer

Map DMA buffer and perpare for the implementation of LsiScsiPassThru(). v2: - Replace 0x1 with SIZE_64KB macro for the DMA buffer data array - Remove DUAL_ADDRESS_CYCLE from PciIo since we don't really need 64-bit DMA address Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel

[edk2-devel] [PATCH v2 03/12] OvmfPkg/LsiScsiDxe: Report the name of the driver

Implement LsiScsiGetDriverName() and LsiScsiGetDeviceName() to report the name of the driver. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Signed-off-by: Gary Lin Reviewed-by: Laszlo Ersek --- OvmfPkg/LsiScsiDxe/LsiScsi.c | 69 ++--

[edk2-devel] [PATCH v2 00/12] Introduce LsiScsi driver to OvmfPkg

This patch series implement the driver for LSI 53C895A SCSI controller for OVMF so that the user can access the storage devices connected to QEMU "lsi" controller. The driver is disabled by default since LSI 53C895A is considered as a legacy device. To enable the driver, please add "-D

[edk2-devel] [PATCH v2 06/12] OvmfPkg/LsiScsiDxe: Report Targets and LUNs

Implement LsiScsiGetNextTargetLun(), LsiScsiBuildDevicePath(), LsiScsiGetTargetLun(), and LsiScsiGetNextTarget() to report Targets and LUNs and build the device path. This commit also introduces two PCD value: PcdLsiScsiMaxTargetLimit and PcdLsiScsiMaxLunLimit as the limits for Targets and LUNs.

[edk2-devel] [PATCH v2 07/12] OvmfPkg/LsiScsiDxe: Open PciIo protocol and initialize the device

Open PciIo protocol and use it to initialize the device. The initialization of LSI 53C895A is simple: just set the SRST bit in Interrupt Status Zero register to reset the device. v2: - Use the BITx macros for the bit constants - Add the closing of PciIo protocol in LsiScsiControllerStop()

[edk2-devel] [PATCH v2 01/12] OvmfPkg/LsiScsiDxe: Create the empty driver

Create the driver with only a dummy LsiScsiEntryPoint() for the further implementation of the driver for LSI 53C895A SCSI controller. v2: Fix the mixed-case GUID string Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Signed-off-by: Gary Lin Reviewed-by: Laszlo Ersek ---

[edk2-devel] [PATCH v2 12/12] Maintainers.txt: Add Gary Lin as the reviewer for LsiScsi driver

Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Signed-off-by: Gary Lin Reviewed-by: Laszlo Ersek --- Maintainers.txt | 4 1 file changed, 4 insertions(+) diff --git a/Maintainers.txt b/Maintainers.txt index 32c9003a6209..075a8d0ea763 100644 --- a/Maintainers.txt +++

[edk2-devel] [PATCH v2 11/12] OvmfPkg/LsiScsiDxe: Calculate the transferred bytes

Calculate the transferred bytes during data phases based on the Cumulative SCSI Byte Count (CSBC) and update InTransferLength/OutTransferLength of the request packet. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Signed-off-by: Gary Lin --- OvmfPkg/Include/IndustryStandard/LsiScsi.h

[edk2-devel] [PATCH v2 10/12] OvmfPkg/LsiScsiDxe: Process the SCSI Request Packet

This is the second part of LsiScsiPassThru(). LsiScsiProcessRequest() is added to translate the SCSI Request Packet into the LSI 53C895A commands. This function utilizes the so-called Script buffer to transmit a series of commands to the chip and then polls the DMA Status (DSTAT) register until

[edk2-devel] [PATCH v2 09/12] OvmfPkg/LsiScsiDxe: Examine the incoming SCSI Request Packet

This is the first part of LsiScsiPassThru(). Before processing the SCSI Request packet, we have to make sure whether the packet is valid or not. v2: Make LsiScsiPassThru() return EFI_UNSUPPORTED since this function is half-implemented Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel

[edk2-devel] [PATCH v2 0/2] UefiPayloadPkg: Runtime MMCONF

Support arbitrary platforms with different or even no MMCONF space. Fixes crash on platforms not exposing 256 buses. Tested on: * AMD Stoney Ridge v2: * rebased with regards to commit 3900a63e3a1b9ba9a4105bedead7b986188cec2c * add MdePkg Maintainer Branch:

[edk2-devel] [PATCH v2 2/2] MdePkg: Add support for variable size MMCONF space

From: Patrick Rudolph On embedded AMD platforms the MMCONF window is usually only 64MiB. Add support for arbitrary sized MMCONF by introducing a new PCD. The default size is still 256MiB, but will be overwritten by UefiPayloadPkg with the real MMCONF size. Fixes crash on platforms not exposing

[edk2-devel] [PATCH v2 1/2] UefiPayloadPkg: Store the real size of the MMCONF window

From: Patrick Rudolph This will fix issues with the PciBusDxe. Signed-off-by: Patrick Rudolph Signed-off-by: Marcello Sylvester Bauer Cc: Patrick Rudolph Cc: Christian Walter Cc: Maurice Ma Cc: Nate DeSimone Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao ---

Re: [edk2-devel] File in the build question. I'm working on a smart git grep

On 07/16/20 03:41, Andrew Fish via groups.io wrote: > I think I mentioned before on the list that I think a smart git grep that > only scopes to a give target would be useful. For our internal repo we have > lots of targets and lots of generations of platforms so lots of code that > hits in a

Re: [edk2-devel] Extremely long delays with UDF support?

On 07/15/20 22:37, Tim Lewis wrote: > Has anyone else seen extremely long delays with UDF support on USB > CD-ROMs/DVDs? We found that PartitionDxe can add seconds because of the > number blocks being read. ... is this perhaps related to what Zhichao has been working on?

[edk2-devel] [PATCH v1 1/1] UefiPayloadPkg: Scan for PCI devices after end of DXE

From: Patrick Rudolph This allows EFI applications to iterate over those devices. An example is iPXE.efi that requires those devices to be present. Signed-off-by: Patrick Rudolph Signed-off-by: Marcello Sylvester Bauer Cc: Patrick Rudolph Cc: Christian Walter Cc: Maurice Ma Cc: Nate

Re: [edk2-devel] [PATCH v3 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

On 07/15/20 19:09, Vladimir Olovyannikov wrote: > Hi Laszlo, > > Thank you for supporting this. > I can add required support. Thanks! > But shouldn't we wait until the patch is reviewed and approved first? > I don't know the proper procedure. Please advise. If a v4 of your patch becomes

Re: [edk2-devel] [PATCH] Maintainers.txt: Remove invalid email address and a few other role changes

On 07/16/20 11:31, Jian J Wang wrote: > - Remove the address of Zhang, Chao from maintainer and reviewer list since > he has left the community. Many thanks to his great contributions to edk2. > - Add Yao, Jiewen as maintainer of CryptoPkg, but remove him from > SignedCapsulePkg. > - Add Wang,

[edk2-devel] [Patch] BaseTools: Remove the file timestamp checking during parsing

During build, the meta files are not changed, so it's no need to check file timestamp. This patch is to remove useless logic. Signed-off-by: Bob Feng Cc: Liming Gao --- .../Source/Python/Workspace/MetaFileTable.py | 12 ++-- .../Source/Python/Workspace/WorkspaceDatabase.py | 16

Re: [edk2-devel] [edk2-non-osi] Platform/Qemu/Sbssa: Add TF-A binaries

On Wed, Jul 15, 2020 at 06:54:47 +0530, Tanmay Jagdale wrote: > Add fip.bin and bl1.bin binaries for the Qemu Sbsa model > > Signed-off-by: Tanmay Jagdale Reviewed-by: Leif Lindholm Pushed as 4f8871802831. For future submissions of binary files, please generate the patches with --no-binary,

[edk2-devel] [PATCH v1 0/1] UefiPayloadPkg: Scan for PCI devices

Scan for PCI devices after end of DXE. This allows EFI applications to iterate over those devices. An example is iPXE.efi that requires those devices to be present. Branch: https://github.com/9elements/edk2-1/tree/UefiPayloadPkg-PCI_scan PR: https://github.com/tianocore/edk2/pull/800 Patrick

Re: [edk2-devel] [PATCH 1/1] CryptoPkg/OpensslLib: Upgrade OpenSSL to 1.1.1g

On 07/16/20 10:12, Wang, Jian J wrote: > Guomin, > > Thank you very much for this upgrade. > > Just one comment. The opensslconf.h and dso_conf.h generated after calling > process_files.pl are unix EOL. But the EOL in the patch is correct. I guess > you > converted them manually. This answers

[edk2-devel] [PATCH 1/1] BaseLib:Fix RISC-V Supervisor mode (S-Mode) trap handler reentry issue.

While RISC-V hart is trapped into S-Mode, the S-Mode interrupt CSR (SIE) is disabled by RISC-V hart. However the (SIE) is enabled again by RestoreTPL, this causes the second S-Mode trap is triggered by the machine mode (M-Mode)timer interrupt redirection. The SRET instruction clear Supervisor

[edk2-devel] [PATCH v2 5/7] SecurityPkg/PeiTpmMeasurementLib: Add PEI instance.

From: Jiewen Yao REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2841 Cc: Jiewen Yao Cc: Jian J Wang Cc: Chao Zhang Cc: Qi Zhang Signed-off-by: Jiewen Yao --- .../PeiTpmMeasurementLib.c| 74 +++ .../PeiTpmMeasurementLib.inf | 50

[edk2-devel] [PATCH v2 4/7] SecurityPkg/Tcg2: Add TcgPpi

From: Jiewen Yao REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2841 Cc: Jiewen Yao Cc: Jian J Wang Cc: Chao Zhang Cc: Qi Zhang Cc: Rahul Kumar Signed-off-by: Jiewen Yao --- SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 100 +--- SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf |

[edk2-devel] [PATCH v2 0/7] Add capability to let PEIM extend TcgEvent

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2841 Currently, we have TCG/TCG2 protocol and DxeTpmMeasurementLib to let DXE module extend the TCG event. There is more and more use case in PEI phase that a PEIM need extend TCG event, such as BootGuard, FSP, Microcode measurement. Currently,

[edk2-devel] [PATCH v2 2/7] SecurityPkg/dec: Add TcgPpi.

From: Jiewen Yao REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2841 Cc: Jiewen Yao Cc: Jian J Wang Cc: Chao Zhang Signed-off-by: Jiewen Yao --- SecurityPkg/SecurityPkg.dec | 3 +++ 1 file changed, 3 insertions(+) diff --git a/SecurityPkg/SecurityPkg.dec b/SecurityPkg/SecurityPkg.dec

[edk2-devel] [PATCH v2 1/7] SecurityPkg/TcgPpi: Add TcgPpi header file.

From: Jiewen Yao REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2841 Cc: Jiewen Yao Cc: Jian J Wang Cc: Chao Zhang Cc: Qi Zhang Signed-off-by: Jiewen Yao --- SecurityPkg/Include/Ppi/Tcg.h | 52 +++ 1 file changed, 52 insertions(+) create mode 100644

[edk2-devel] [PATCH v2 7/7] MdePkg/Tcg2Protocol: define Flag EFI_TCG2_PRE_HASH

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2841 Cc: Michael D Kinney Cc: Liming Gao Cc: Jiewen Yao Cc: Qi Zhang Signed-off-by: Qi Zhang --- MdePkg/Include/Protocol/Tcg2Protocol.h | 4 1 file changed, 4 insertions(+) diff --git a/MdePkg/Include/Protocol/Tcg2Protocol.h

[edk2-devel] [PATCH v2 3/7] SecurityPkg/Tcg: Add TcgPpi

From: Jiewen Yao REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2841 Cc: Jiewen Yao Cc: Jian J Wang Cc: Chao Zhang Cc: Qi Zhang Cc: Rahul Kumar Signed-off-by: Jiewen Yao --- SecurityPkg/Tcg/TcgPei/TcgPei.c | 61 --- SecurityPkg/Tcg/TcgPei/TcgPei.inf |

[edk2-devel] [PATCH v2 6/7] SecurityPkg/dsc: Add PeiTpmMeasurementLib.

From: Jiewen Yao REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2841 Cc: Jiewen Yao Cc: Jian J Wang Cc: Chao Zhang Cc: Qi Zhang Signed-off-by: Jiewen Yao --- SecurityPkg/SecurityPkg.dsc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/SecurityPkg/SecurityPkg.dsc

[edk2-devel] [PATCH 1/1] CryptoPkg/Library: Remove the redundant build option

Remove the redundant build option for RISCV64 architecture. BZ:2848 Signed-off-by: Abner Chang Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Laszlo Ersek --- CryptoPkg/Library/OpensslLib/OpensslLib.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [edk2-devel] [PATCH v2 08/12] OvmfPkg/LsiScsiDxe: Map DMA buffer

On 07/16/20 09:46, Gary Lin wrote: > Map DMA buffer and perpare for the implementation of LsiScsiPassThru(). > > v2: > - Replace 0x1 with SIZE_64KB macro for the DMA buffer data array > - Remove DUAL_ADDRESS_CYCLE from PciIo since we don't really need > 64-bit DMA address > > Cc:

Re: [edk2-devel] [PATCH v3 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

Adding to Laszlo's feedback, yes thank you for this feature! I have been using this tool on some systems (like the Raspberry Pi) for some time now. It is *very* useful for some use cases (such as transferring files from/to a remote system running in the UEFI Shell). What is surprising is the

Re: [edk2-devel] File in the build question. I'm working on a smart git grep

> On Jul 16, 2020, at 6:18 AM, Laszlo Ersek wrote: > > On 07/16/20 03:41, Andrew Fish via groups.io wrote: >> I think I mentioned before on the list that I think a smart git grep that >> only scopes to a give target would be useful. For our internal repo we have >> lots

Re: [edk2-devel] [PATCH v2 06/12] OvmfPkg/LsiScsiDxe: Report Targets and LUNs

On 07/16/20 17:04, Laszlo Ersek wrote: > On 07/16/20 09:46, Gary Lin wrote: >> Implement LsiScsiGetNextTargetLun(), LsiScsiBuildDevicePath(), >> LsiScsiGetTargetLun(), and LsiScsiGetNextTarget() to report Targets and >> LUNs and build the device path. >> >> This commit also introduces two PCD

Re: [edk2-devel] [PATCH v2 06/12] OvmfPkg/LsiScsiDxe: Report Targets and LUNs

On 07/16/20 09:46, Gary Lin wrote: > Implement LsiScsiGetNextTargetLun(), LsiScsiBuildDevicePath(), > LsiScsiGetTargetLun(), and LsiScsiGetNextTarget() to report Targets and > LUNs and build the device path. > > This commit also introduces two PCD value: PcdLsiScsiMaxTargetLimit and >

Re: [edk2-devel] [PATCH 0/2] BaseTools: Convert ReadMe.txt to reStructuredText

On 7/7/20 5:13 PM, Rebecca Cran wrote: I noticed ReadMe.txt was a little outdated. I updated it to match current functionality (e.g. BaseTools works on both 32-bit and 64-bit Windows). Since the formatting was neither RST or MD, I converted it to RST and renamed to ReadMe.rst to match the edk2

Re: [edk2-devel] [PATCH v2 07/12] OvmfPkg/LsiScsiDxe: Open PciIo protocol and initialize the device

On 07/16/20 09:46, Gary Lin wrote: > Open PciIo protocol and use it to initialize the device. The > initialization of LSI 53C895A is simple: just set the SRST bit in > Interrupt Status Zero register to reset the device. > > v2: > - Use the BITx macros for the bit constants > - Add the closing

Re: [edk2-devel] [PATCH v3 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

> -Original Message- > From: Samer El-Haj-Mahmoud > Sent: Thursday, July 16, 2020 8:26 AM > > Adding to Laszlo's feedback, yes thank you for this feature! I have been > using > this tool on some systems (like the Raspberry Pi) for some time now. It is > *very* useful for some use cases

Re: [edk2-devel] [PATCH v3 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

> -Original Message- > From: Laszlo Ersek > Sent: Thursday, July 16, 2020 5:20 AM > To: Vladimir Olovyannikov ; > devel@edk2.groups.io > Cc: Samer El-Haj-Mahmoud ; Zhichao > Gao ; Maciej Rabeda > ; Jiaxin Wu ; Siyuan > Fu ; Ray Ni ; Liming Gao > ; Nd > Subject: Re: [edk2-devel] [PATCH v3

Re: [edk2-devel] [PATCH v2 10/12] OvmfPkg/LsiScsiDxe: Process the SCSI Request Packet

On 07/16/20 09:46, Gary Lin wrote: > This is the second part of LsiScsiPassThru(). LsiScsiProcessRequest() is > added to translate the SCSI Request Packet into the LSI 53C895A > commands. This function utilizes the so-called Script buffer to transmit > a series of commands to the chip and then

Re: [edk2-devel] [PATCH v2 11/12] OvmfPkg/LsiScsiDxe: Calculate the transferred bytes

On 07/16/20 09:46, Gary Lin wrote: > Calculate the transferred bytes during data phases based on the > Cumulative SCSI Byte Count (CSBC) and update > InTransferLength/OutTransferLength of the request packet. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Signed-off-by: Gary

[edk2-devel] HiiDatabaseDxe, ConfigRouting.c, GetElementsFromRequest.

Hi All, I recently encountered an ASSERT in the GetElementsFromRequest function in HiiDatabaseDxe that caused me some vexation. Specifically, this function ASSERTs (TmpRequest != NULL) if L"PATH=" is not found in a ConfigRequest string. The problem here is that it's possible for code that is

Re: [edk2-devel] [PATCH 1/1] CryptoPkg/Library: Remove the redundant build option

Can you explain the -Wno-error=format? I haven't search the switch from google. Appreciate it. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Abner > Chang > Sent: Thursday, July 16, 2020 10:55 PM > To: devel@edk2.groups.io > Cc: abner.ch...@hpe.com; Wang, Jian J ; Lu, >

Re: [edk2-devel] Extremely long delays with UDF support?

Can you give more detail of the issue? Thanks, Zhichao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo Ersek > Sent: Thursday, July 16, 2020 9:21 PM > To: devel@edk2.groups.io; tim.le...@insyde.com > Cc: Gao, Zhichao ; Ni, Ray ; Gary > Lin > Subject: Re:

[edk2-devel] [PATCH v2 0/1] Upgrade the OpenSSL to 1.1.1g

v2: Change the process_files.pl to convert the EOL automatically so the generated file will be CRLF format. Cc: Jian J Wang Cc: Xiaoyu Lu Guomin Jiang (1): CryptoPkg/OpensslLib: Upgrade OpenSSL to 1.1.1g CryptoPkg/CryptoPkg.dec | 1 -

[edk2-devel] [PATCH v2 1/1] CryptoPkg/OpensslLib: Upgrade OpenSSL to 1.1.1g

Upgrade openssl to 1.1.1g. the directory have been reorganized, openssl moved crypto/include/internal to include/crypto folder. So we change directory to match the re-organization. The dso_conf.h and opensslconf.h will generated in UNIX format, change process_files.pl to covent the EOL

Re: [edk2-devel] [PATCH v2 1/1] CryptoPkg/OpensslLib: Upgrade OpenSSL to 1.1.1g

Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Jiang, Guomin > Sent: Friday, July 17, 2020 9:36 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Lu, XiaoyuX ; > Laszlo Ersek > Subject: [PATCH v2 1/1] CryptoPkg/OpensslLib: Upgrade OpenSSL to 1.1.1g > > Upgrade

Re: [edk2-devel] [PATCH 1/1] CryptoPkg/Library: Remove the redundant build option

Hi Liming, what I know about "format" is the switch used to check if the proper arguments are assigned printf(). The build option I omitted could be copied from somewhere in the same INF file but actually -Wno-format has done the same thing. Abner > -Original Message- > From: