Re: [edk2-devel] [PATCH v4] UefiCpuPkg/MpInitLib DXE: Add PCD to control AP status check interval

Reviewed-by: Ray Ni > -Original Message- > From: Wu, Hao A > Sent: Wednesday, March 25, 2020 1:07 PM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Dong, Eric ; Ni, Ray > ; Laszlo Ersek > ; Kinney, Michael D ; Zeng, > Star ; Brian J . > Johnson > Subject: [PATCH v4]

Re: [edk2-devel] Questions about UEFI MAT / PcdPropertiesTableEnable

> > The properties table should not be used. It has been superseded by the memory > attributes table, per spec. > > In edk2, the properties table is controlled by the PCD, regardless of the > memory attributes table. > > In edk2, the memory attributes table is always produced, regardless of

Re: [edk2-devel] [edk2-rfc] [RFCv2] code-first process for UEFI-forum specifications

> > ## Github > New repositories will be added for holding the text changes and the source > code. > > Specification text changes will be held within the affected source repository, > in the Github flavour of markdown, in a file (or split across several files) > with .md suffix. What's the

[edk2-devel] [PATCH v4] UefiCpuPkg/MpInitLib DXE: Add PCD to control AP status check interval

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2627 The commit will introduce a static PCD to specify the periodic interval for checking the AP status when MP services StartupAllAPs() and StartupThisAP() are being executed in a non-blocking manner. Or in other words, specifies the interval

Re: [edk2-devel] [PATCH v3] UefiCpuPkg/MpInitLib DXE: Add PCD to control AP status check interval

> -Original Message- > From: Ni, Ray > Sent: Wednesday, March 25, 2020 11:36 AM > To: Wu, Hao A; devel@edk2.groups.io > Cc: Dong, Eric; Laszlo Ersek; Kinney, Michael D; Zeng, Star; Brian J . Johnson > Subject: RE: [PATCH v3] UefiCpuPkg/MpInitLib DXE: Add PCD to control AP > status check

Re: [edk2-devel] [PATCH v3] UefiCpuPkg/MpInitLib DXE: Add PCD to control AP status check interval

> + TriggerTime = EFI_TIMER_PERIOD_MICROSECONDS ( > + PcdGet32 (PcdCpuApStatusCheckIntervalInMicroSeconds) > + ); >Status = gBS->SetTimer ( >mCheckAllApsEvent, >TimerPeriodic, > - AP_CHECK_INTERVAL > +

Re: [edk2-devel] Questions about UEFI MAT / PcdPropertiesTableEnable

Hi, Laszlo: Got it. Thanks Best wishes, -邮件原件- 发件人: devel@edk2.groups.io 代表 Laszlo Ersek 发送时间: 2020年3月23日 21:22 收件人: devel@edk2.groups.io; Tiger Liu(BJ-RD) 主题: Re: [edk2-devel] Questions about UEFI MAT / PcdPropertiesTableEnable On 03/17/20 10:27, Tiger Liu(BJ-RD) wrote: > Hi,

[edk2-devel] Event: TianoCore Design Meeting - APAC/NAMO - Wednesday, 25 March 2020 #cal-invite

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH CALSCALE:GREGORIAN BEGIN:VEVENT UID:xc8f.1585106024590449175.o...@groups.io DTSTAMP:20200325T031344Z ORGANIZER;CN=Ray Ni:mailto:Ray Ni ray...@intel.com DTSTART:20200325T15Z DTEND:20200325T16Z

[edk2-devel] [PATCH v3] UefiCpuPkg/MpInitLib DXE: Add PCD to control AP status check interval

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2627 The commit will introduce a static PCD to specify the periodic interval for checking the AP status when MP services StartupAllAPs() and StartupThisAP() are being executed in a non-blocking manner. Or in other words, specifies the interval

Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg/Variable: Return GetVariable() attr if EFI_BUFFER_TOO_SMALL

Hi Laszlo, I sent a v2 patch series with that commit reverted as patch 2/2. Thanks, Michael On 3/24/2020 6:57 PM, Laszlo Ersek wrote: Hello Michael, On 03/24/20 23:04, Michael Kubacki wrote: From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2062 The UEFI

[edk2-devel] [PATCH v2 1/2] MdeModulePkg/Variable: Return GetVariable() attr if EFI_BUFFER_TOO_SMALL

From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2062 The UEFI specification v2.8 Errata A Section 8.2 "GetVariable()" "Attributes" parameter description states: "If not NULL, a pointer to the memory location to return the attributes bitmask for the variable. See

[edk2-devel] [PATCH v2 2/2] Revert "NetworkPkg/TlsAuthConfigDxe: fix TlsCaCertificate attributes retrieval"

From: Michael Kubacki This reverts commit 6896efdec2709e530b23c688cf0f31706709a0c5. REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2062 GetVariable() now returns attributes when it fails with EFI_BUFFER_TOO_SMALL. Therefore, commit 6896efdec270 is reverted since it is no longer relevant.

[edk2-devel] [PATCH v2 0/2] Return GetVariable() attr if EFI_BUFFER_TOO_SMALL

From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2062 This is a two-part patch series to update the GetVariable() implementation to return Attributes in the case EFI_BUFFER_TOO_SMALL is returned. * [PATCH v2 1/2] Makes the actual functional change in the variable

[edk2-devel] [Patch V2] Features/Intel: Add LogoFeaturePkg to provide logo images and drivers

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2584 1. LogoDxe.inf includes a BMP logo in the EFI file, the driver decodes the BMP file and provide the image via EDKII_PLATFORM_LOGO_PROTOCOL. 2. JpegLogoDxe.inf includes a JPEG logo in the EFI file, the driver use

Re: [edk2-devel] [PATCH 1/1] MdePkg/UefiScsiLib: Set FUA bit for synchronous SCSI Write operations

Hi Christopher Could you please give more information about this code change? For example, which Spec the code change is based on. Thanks Zhiguang > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Zurcher, Christopher J > Sent: Saturday,

Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms

Thanks Laszlo, I will wait for the maintainers to accept the patch, then submit an amended version for ArmVirtQemu. -Original Message- From: Laszlo Ersek Sent: Tuesday, March 24, 2020 7:03 PM To: Samer El-Haj-Mahmoud ; devel@edk2.groups.io; sa...@elhajmahmoud.com Cc: Dandan Bi ;

[edk2-devel] [PATCH] SecurityPkg/TcgStorageOpalLib: add transaction interface

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2625 Add the interface OpalStartTransaction. Add the interface OpalEndTransaction. Add the interface TcgCreateStartTransaction. Add the interface TcgCreateEndTransaction. Change-Id: I9cfa43ce005d65ba65cc6c1ffc8a6b754266189b Signed-off-by:

Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg/Variable: Return GetVariable() attr if EFI_BUFFER_TOO_SMALL

Hello Michael, On 03/24/20 23:04, Michael Kubacki wrote: > From: Michael Kubacki > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2062 > > The UEFI specification v2.8 Errata A Section 8.2 "GetVariable()" > "Attributes" parameter description states: > > "If not NULL, a pointer to the

Re: [edk2-devel] [PATCH 09/17] OvmfPkg/PvScsiDxe: Backup/Restore PCI attributes on Init/UnInit

On 03/24/20 16:35, Liran Alon wrote: > > On 24/03/2020 17:14, Laszlo Ersek wrote: >> On 03/16/20 16:01, Liran Alon wrote: >> I'm going to stop reviewing this iteration now; please rework the rest >> of the series for v2 with this resource management pattern. >> >> Thanks! >> Laszlo > > Thanks

Re: [edk2-devel] [PATCH v2] UefiCpuPkg/MpInitLib DXE: Add PCD to control AP status check interval

On 03/24/20 16:59, Kinney, Michael D wrote: > How was the milliseconds units selected? I suggested msecs for continuity with the pre-patch unit: #define AP_CHECK_INTERVAL (EFI_TIMER_PERIOD_MILLISECONDS (100)) > We have other PCDs that provide timer intervals in > 100ns unit and my

Re: [edk2-devel] [PATCH v2] UefiCpuPkg/MpInitLib DXE: Add PCD to control AP status check interval

> -Original Message- > From: Ni, Ray > Sent: Wednesday, March 25, 2020 8:46 AM > To: Kinney, Michael D; Zeng, Star; Wu, Hao A; devel@edk2.groups.io > Cc: Dong, Eric; Laszlo Ersek; Brian J . Johnson > Subject: RE: [edk2-devel] [PATCH v2] UefiCpuPkg/MpInitLib DXE: Add PCD to > control AP

Re: [edk2-devel] [PATCH 15/17] OvmfPkg/PvScsiDxe: Support sending SCSI request and receive response

On 24/03/2020 18:43, Laszlo Ersek wrote: On 03/16/20 16:01, Liran Alon wrote: +STATIC +BOOLEAN +PvScsiIsReqRingFull ( + IN CONST PVSCSI_DEV *Dev + ) +{ + PVSCSI_RINGS_STATE *RingsState; + UINT64 ReqNumEntries; + + RingsState = Dev->RingDesc.RingState; + ReqNumEntries = 1

[edk2-devel] Upcoming Event: TianoCore Bug Triage - APAC / NAMO - Wed, 03/25/2020 9:30am-10:30am #cal-reminder

*Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Wednesday, 25 March 2020, 9:30am to 10:30am, (GMT+08:00) Asia/Chongqing *Where:* https://zoom.com.cn/j/493235016 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=758249 ) *Organizer:* Brian Richardson

Re: [edk2-devel] [PATCH 12/17] OvmfPkg/PvScsiDxe: Reset adapter on init

On 24/03/2020 18:00, Laszlo Ersek wrote: On 03/16/20 16:01, Liran Alon wrote: +STATIC +EFI_STATUS +PvScsiWriteCmdDesc ( + IN CONST PVSCSI_DEV *Dev, + IN UINT32 Cmd, + IN VOID *Desc, + IN UINTN Length + ) +{ + EFI_STATUS Status; + UINTN

[edk2-devel] Updated Event: TianoCore Bug Triage - APAC / NAMO #cal-invite

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH CALSCALE:GREGORIAN BEGIN:VEVENT UID:mlda.1580078539586725120.r...@groups.io DTSTAMP:20200325T010039Z ORGANIZER;CN=Brian Richardson:mailto:brian.richard...@intel.com

Re: [edk2-devel] [PATCH] Features/Intel: Add LogoFeaturePkg to provide logo images and drivers

Hi Liming, I have passed build with VS2015, do I have to pass build with GCC5? I have no Ubuntu environment so far, is there a easy way to verify the build with GCC5? Best Regards Heng > -Original Message- > From: Gao, Liming > Sent: Tuesday, March 24, 2020 11:13 PM > To:

Re: [edk2-devel] [PATCH v2] UefiCpuPkg/MpInitLib DXE: Add PCD to control AP status check interval

Mike, Hao, I searched all edk2 code using regex pattern "Pcd.*Timeout.*", "Pcd.*Timer.*", "Pcd.*Delay.*" and found below PCDs: gEfiMdePkgTokenSpaceGuid.PcdSpinLockTimeout: in tick unit depending on the TimerLib used gEfiMdePkgTokenSpaceGuid.PcdUsbTransferTimeoutValue: in 1ms unit

Re: [edk2-devel] Adding Bhyve support into upstream EDK2

On 03/24/20 02:34, Rebecca Cran wrote: > On 3/6/20 6:29 PM, Yao, Jiewen wrote: >> Can you post the patch? :-) > > Thanks, It's just about ready for review I think. There's perhaps a bit > more deduplication between BhyvePkg and OvmfPkg to be done. > > Since the patch is 1.7MB, I've uploaded it

Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms

On 03/23/20 13:53, Samer El-Haj-Mahmoud wrote: > Thanks Laszlo > > I agree. But shouldn't we remove the PCD settings from all Arm64 platforms > that have this override value of 0x20? > > Namely: > > edk2/ArmVirtPkg/ArmVirtQemu.dsc > edk2-platforms/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc

[edk2-devel] [PATCH v1 1/1] MdeModulePkg/Variable: Return GetVariable() attr if EFI_BUFFER_TOO_SMALL

From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2062 The UEFI specification v2.8 Errata A Section 8.2 "GetVariable()" "Attributes" parameter description states: "If not NULL, a pointer to the memory location to return the attributes bitmask for the variable. See

Re: [edk2-devel] [[edk2-platform][PATCH 1/1] Platform/RaspberryPi/RPi4: Enable HTTP Boot

Tested with USB NICs (both ASIX AX88772C and Realtek gigabit ethernet). Both work pretty well (tested IPv4 and IPv6). -Original Message- From: devel@edk2.groups.io On Behalf Of Ard Biesheuvel via Groups.Io Sent: Tuesday, March 24, 2020 5:55 PM To: Samer El-Haj-Mahmoud Cc:

Re: [edk2-devel] [[edk2-platform][PATCH 1/1] Platform/RaspberryPi/RPi4: Enable HTTP Boot

On Tue, 24 Mar 2020 at 22:53, Samer El-Haj-Mahmoud wrote: > > Enable HTTP Boot (with and without TLS) on RPi4 > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > > Signed-off-by: Samer El-Haj-Mahmoud Which NIC are you HTTP booting from? > --- > Platform/RaspberryPi/RPi4/RPi4.dsc | 9 +++-- > 1

[edk2-devel] [[edk2-platform][PATCH 1/1] Platform/RaspberryPi/RPi4: Enable HTTP Boot

Enable HTTP Boot (with and without TLS) on RPi4 Cc: Leif Lindholm Cc: Ard Biesheuvel Signed-off-by: Samer El-Haj-Mahmoud --- Platform/RaspberryPi/RPi4/RPi4.dsc | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc

Re: [edk2-devel] EDK II Python development process specification -draft

Thanks for the feedback and your view points Bob. I totally agree on your points and the  base tools issues. I think together we can fix the issues you mentioned and apply best software design principles to  base tools . -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to

[edk2-devel] [PATCH v1 1/1] ArmPlatformPkg/ArmPlatformPkg.dsc: Add missing components

From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2575 The following components are currently missing from the [Components] section of ArmPlatformPkg.dsc: * ArmPlatformPkg/Library/HdLcd/HdLcd.inf * ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.inf This commit includes the

[edk2-devel] [PATCH v6 35/42] OvmfPkg/Sec: Enable cache early to speed up booting

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Currently, the OVMF code relies on the hypervisor to enable the cache support on the processor in order to improve the boot speed. However, with SEV-ES, the hypervisor is not allowed to change the CR0 register to enable caching. Update the

[edk2-devel] [PATCH v6 41/42] OvmfPkg: Move the GHCB allocations into reserved memory

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 After having transitioned from UEFI to the OS, the OS will need to boot the APs. For an SEV-ES guest, the APs will have been parked by UEFI using GHCB pages allocated by UEFI. The hypervisor will write to the GHCB SW_EXITINFO2 field of the

[edk2-devel] [PATCH v6 42/42] UefiCpuPkg/MpInitLib: Prepare SEV-ES guest APs for OS use

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Before UEFI transfers control to the OS, it must park the AP. This is done using the AsmRelocateApLoop function to transition into 32-bit non-paging mode. For an SEV-ES guest, a few additional things must be done: - AsmRelocateApLoop must

Re: [EXTERNAL] [edk2-devel] [PATCH v4 1/3] SecurityPkg: add RpmcLib and VariableKeyLib public headers

Is there a reason this needs to be called “VariableKeyLib” rather than any other “KeyLib”? It seems general-purpose as an interface. - Bret From: devel@edk2.groups.io on behalf of Wang, Jian J via Groups.Io Sent: Monday, March 23, 2020 11:35:21 PM To:

[edk2-devel] [PATCH v6 36/42] OvmfPkg/QemuFlashFvbServicesRuntimeDxe: Bypass flash detection with SEV-ES is enabled

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 The flash detection routine will attempt to determine how the flash device behaves (e.g. ROM, RAM, Flash). But when SEV-ES is enabled and the flash device behaves as a ROM device (meaning it is marked read-only by the hypervisor), this check

[edk2-devel] [PATCH v6 39/42] UefiCpuPkg: Allow AP booting under SEV-ES

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Typically, an AP is booted using the INIT-SIPI-SIPI sequence. This sequence is intercepted by the hypervisor, which sets the AP's registers to the values requested by the sequence. At that point, the hypervisor can start the AP, which will

[edk2-devel] [PATCH v6 31/42] UefiCpuPkg: Create an SEV-ES workarea PCD

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Create an SEV-ES workarea PCD. This PCD will be used for BSP communication during SEC and for AP startup during PEI and DXE phases, the latter is the reason for creating it in the UefiCpuPkg. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek

[edk2-devel] [PATCH v6 37/42] UefiCpuPkg: Add a 16-bit protected mode code segment descriptor

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 A hypervisor is not allowed to update an SEV-ES guests register state, so when booting an SEV-ES guest AP, the hypervisor is not allowed to set the RIP to the guest requested value. Instead, an SEV-ES AP must be transition from 64-bit long

[edk2-devel] [PATCH v6 30/42] OvmfPkg/PlatformPei: Move early GDT into ram when SEV-ES is enabled

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 The SEV support will clear the C-bit from non-RAM areas. The early GDT lives in a non-RAM area, so when an exception occurs (like a #VC) the GDT will be read as un-encrypted even though it is encrypted. This will result in a failure to be

[edk2-devel] [PATCH v6 33/42] OvmfPkg/ResetVector: Add support for a 32-bit SEV check

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 During BSP startup, the reset vector code will issue a CPUID instruction while in 32-bit mode. When running as an SEV-ES guest, this will trigger a #VC exception. Add exception handling support to the early reset vector code to catch these

[edk2-devel] [PATCH v6 32/42] OvmfPkg: Reserve a page in memory for the SEV-ES usage

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Reserve a fixed area of memory for SEV-ES use and set a fixed PCD, PcdSevEsWorkAreaBase, to this value. This area will be used by SEV-ES support for two purposes: 1. Communicating the SEV-ES status during BSP boot to SEC: Using a

[edk2-devel] [PATCH v6 40/42] OvmfPkg: Use the SEV-ES work area for the SEV-ES AP reset vector

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 A hypervisor is not allowed to update an SEV-ES guest's register state, so when booting an SEV-ES guest AP, the hypervisor is not allowed to set the RIP to the guest requested value. Instead an SEV-ES AP must be re-directed from within the

[edk2-devel] [PATCH v6 34/42] OvmfPkg/Sec: Add #VC exception handling for Sec phase

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 An SEV-ES guest will generate a #VC exception when it encounters a non-automatic exit (NAE) event. It is expected that the #VC exception handler will communicate with the hypervisor using the GHCB to handle the NAE event. NAE events can

[edk2-devel] [PATCH v6 38/42] UefiCpuPkg/MpInitLib: Add CPU MP data flag to indicate if SEV-ES is enabled

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 When starting APs in an SMP configuration, the AP needs to know if it is running as an SEV-ES guest in order to assign a GHCB page. Add a field to the CPU_MP_DATA structure that will indicate if SEV-ES is enabled. This new field is set

[edk2-devel] [PATCH v6 28/42] OvmfPkg/PlatformPei: Reserve GHCB-related areas if S3 is supported

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Protect the memory used by an SEV-ES guest when S3 is supported. This includes the page table used to break down the 2MB page that contains the GHCB so that it can be marked un-encrypted, as well as the GHCB area. Regarding the lifecycle of

[edk2-devel] [PATCH v6 22/42] UefiCpuPkg/CpuExceptionHandler: Add support for MONITOR/MONITORX NAE events

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Under SEV-ES, a MONITOR/MONITORX intercept generates a #VC exception. VMGEXIT must be used to allow the hypervisor to handle this intercept. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Tom Lendacky ---

[edk2-devel] [PATCH v6 24/42] UefiCpuPkg/CpuExceptionHandler: Add support for DR7 Read/Write NAE events

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Under SEV-ES, a DR7 read or write intercept generates a #VC exception. The #VC handler must provide special support to the guest for this. On a DR7 write, the #VC handler must cache the value and issue a VMGEXIT to notify the hypervisor of

[edk2-devel] [PATCH v6 25/42] OvmfPkg/MemEncryptSevLib: Add an SEV-ES guest indicator function

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Create a function that can be used to determine if the VM is running as an SEV-ES guest. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Reviewed-by: Laszlo Ersek Signed-off-by: Tom Lendacky ---

[edk2-devel] [PATCH v6 26/42] OvmfPkg: Add support to perform SEV-ES initialization

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 When SEV-ES is enabled, then SEV is also enabled. Add support to the SEV initialization function to also check for SEV-ES being enabled, and if enabled, set the SEV-ES enabled PCD (PcdSevEsIsEnabled). Cc: Jordan Justen Cc: Laszlo Ersek

[edk2-devel] [PATCH v6 19/42] UefiCpuPkg/CpuExceptionHandler: Add support for INVD NAE events

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Under SEV-ES, a INVD intercept generates a #VC exception. VMGEXIT must be used to allow the hypervisor to handle this intercept. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Tom Lendacky --- .../X64/ArchAMDSevVcHandler.c

[edk2-devel] [PATCH v6 17/42] UefiCpuPkg/CpuExceptionHandler: Add support for RDTSC NAE events

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Under SEV-ES, a RDTSC intercept generates a #VC exception. VMGEXIT must be used to allow the hypervisor to handle this intercept. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Tom Lendacky --- .../X64/ArchAMDSevVcHandler.c

[edk2-devel] [PATCH v6 23/42] UefiCpuPkg/CpuExceptionHandler: Add support for MWAIT/MWAITX NAE events

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Under SEV-ES, a MWAIT/MWAITX intercept generates a #VC exception. VMGEXIT must be used to allow the hypervisor to handle this intercept. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Tom Lendacky ---

[edk2-devel] [PATCH v6 27/42] OvmfPkg: Create a GHCB page for use during Sec phase

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 A GHCB page is needed during the Sec phase, so this new page must be created. Since the #VC exception handler routines assume that a per-CPU variable area is immediately after the GHCB, this per-CPU variable area must also be created. Since

[edk2-devel] [PATCH v6 20/42] UefiCpuPkg/CpuExceptionHandler: Add support for VMMCALL NAE events

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Under SEV-ES, a VMMCALL intercept generates a #VC exception. VMGEXIT must be used to allow the hypervisor to handle this intercept. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Tom Lendacky --- .../X64/ArchAMDSevVcHandler.c

[edk2-devel] [PATCH v6 18/42] UefiCpuPkg/CpuExceptionHandler: Add support for RDPMC NAE events

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Under SEV-ES, a RDPMC intercept generates a #VC exception. VMGEXIT must be used to allow the hypervisor to handle this intercept. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Tom Lendacky --- .../X64/ArchAMDSevVcHandler.c

[edk2-devel] [PATCH v6 29/42] OvmfPkg: Create GHCB pages for use during Pei and Dxe phase

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Allocate memory for the GHCB pages and the per-CPU variable pages during SEV initialization for use during Pei and Dxe phases. The GHCB page(s) must be shared pages, so clear the encryption mask from the current page table entries. Upon

[edk2-devel] [PATCH v6 05/42] MdePkg/BaseLib: Add support for the XGETBV instruction

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Under SEV-ES, a CPUID instruction requires the current value of the XCR0 register. In order to retrieve that value, the XGETBV instruction needs to be executed. Provide the necessary support to execute the XGETBV instruction. Cc: Michael D

[edk2-devel] [PATCH v6 13/42] UefiCpuPkg/CpuExceptionHandler: Add support for CPUID NAE events

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Under SEV-ES, a CPUID intercept generates a #VC exception. VMGEXIT must be used to allow the hypervisor to handle this intercept. Add support to construct the required GHCB values to support a CPUID NAE event. Additionally, CPUID

[edk2-devel] [PATCH v6 16/42] UefiCpuPkg/CpuExceptionHandler: Add support for WBINVD NAE events

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Under SEV-ES, a WBINVD intercept generates a #VC exception. VMGEXIT must be used to allow the hypervisor to handle this intercept. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Tom Lendacky --- .../X64/ArchAMDSevVcHandler.c

[edk2-devel] [PATCH v6 15/42] UefiCpuPkg/CpuExceptionHandler: Add support for NPF NAE events (MMIO)

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Under SEV-ES, a NPF intercept for an NPT entry with a reserved bit set generates a #VC exception. This condition is assumed to be an MMIO access. VMGEXIT must be used to allow the hypervisor to handle this intercept. Add support to

[edk2-devel] [PATCH v6 08/42] OvmfPkg: Prepare OvmfPkg to use the VmgExitLib library

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Various CpuExceptionHandlerLib libraries will updated to use the new VmgExitLib library. To prevent any build breakage, update the OvmfPkg DSC files that use a form of the CpuExceptionHandlerLib library to include the VmgExitLib library.

[edk2-devel] [PATCH v6 02/42] MdePkg: Add the MSR definition for the GHCB register

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 For SEV-ES, the GHCB page address is stored in the GHCB MSR register (0xc0010130). Define the register and the format used for register during GHCB protocol negotiation. Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Tom Lendacky ---

[edk2-devel] [PATCH v6 10/42] UefiCpuPkg/CpuExceptionHandler: Add base support for the #VC exception

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Add base support to handle #VC exceptions. This includes a stub routine to invoke when a #VC exception occurs and special checks in the common exception handlers to invoke the #VC exception handler routine. Cc: Eric Dong Cc: Ray Ni Cc:

[edk2-devel] [PATCH v6 14/42] UefiCpuPkg/CpuExceptionHandler: Add support for MSR_PROT NAE events

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Under SEV-ES, a MSR_PROT intercept generates a #VC exception. VMGEXIT must be used to allow the hypervisor to handle this intercept. Add support to construct the required GHCB values to support an MSR_PROT NAE event. Parse the instruction

[edk2-devel] [PATCH v6 06/42] MdePkg/BaseLib: Add support for the VMGEXIT instruction

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 VMGEXIT is a new instruction used for Hypervisor/Guest communication when running as an SEV-ES guest. A VMGEXIT will cause an automatic exit (AE) to occur, resulting in a #VMEXIT with an exit code value of 0x403. Provide the necessary

[edk2-devel] [PATCH v6 04/42] MdeModulePkg/DxeIplPeim: Support GHCB pages when creating page tables

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 GHCB pages must be mapped as shared pages, so modify the process of creating identity mapped pagetable entries so that GHCB entries are created without the encryption bit set. Cc: Jian J Wang Cc: Hao A Wu Cc: Dandan Bi Cc: Liming Gao

[edk2-devel] [PATCH v6 12/42] UefiCpuPkg/CpuExceptionHandler: Support string IO for IOIO_PROT NAE events

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Add support to the #VC exception handler to handle string IO. This requires expanding the IO instruction parsing to recognize string based IO instructions as well as preparing an un-encrypted buffer to be used to transfer (either to or from

[edk2-devel] [PATCH v6 11/42] UefiCpuPkg/CpuExceptionHandler: Add support for IOIO_PROT NAE events

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Under SEV-ES, a IOIO_PROT intercept generates a #VC exception. VMGEXIT must be used to allow the hypervisor to handle this intercept. Add support to construct the required GHCB values to support a IOIO_PROT NAE event. Parse the instruction

[edk2-devel] [PATCH v6 01/42] MdePkg: Create PCDs to be used in support of SEV-ES

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Three new dynamic PCDs are needed to support SEV-ES under OVMF: - PcdSevEsIsEnabled: BOOLEAN value used to indicate if SEV-ES is enabled - PcdGhcbBase: UINT64 value that is the base address of the GHCB

[edk2-devel] [PATCH v6 03/42] MdePkg: Add a structure definition for the GHCB

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 The GHCB is used by an SEV-ES guest for communicating between the guest and the hypervisor. Create the GHCB definition as defined by the GHCB protocol definition. Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Tom Lendacky ---

[edk2-devel] [PATCH v6 00/42] SEV-ES guest support

This patch series provides support for running EDK2/OVMF under SEV-ES. Secure Encrypted Virtualization - Encrypted State (SEV-ES) expands on the SEV support to protect the guest register state from the hypervisor. See "AMD64 Architecture Programmer's Manual Volume 2: System Programming", section

[edk2-devel] [PATCH v6 09/42] UefiPayloadPkg: Prepare UefiPayloadPkg to use the VmgExitLib library

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Various CpuExceptionHandlerLib libraries will updated to use the new VmgExitLib library. To prevent any build breakage, update the UefiPayloadPkg DSC files that use a form of the CpuExceptionHandlerLib library to include the VmgExitLib

Re: [edk2-devel] [EXTERNAL] [Patch 1/1] BaseTools: Add .map file as a target in makefile

Updated the Bugzilla with feedback on this. I don’t think this is a good final solution. It creates two new empty dependencies: one for the binary blob, but one for the parent driver. The parent driver dependency causes a warning in compiling. - Bret From: Bob Feng

Re: [EXTERNAL] [edk2-devel] [PATCH v4] MdePkg/UnitTestBaseLib: Add check for pointer BinData

Reviewed-by: Bret Barkelew - Bret From: devel@edk2.groups.io on behalf of Guomin Jiang via Groups.Io Sent: Monday, March 23, 2020 6:42:41 PM To: devel@edk2.groups.io Cc: Kinney, Michael D ; Liming Gao Subject: [EXTERNAL] [edk2-devel] [PATCH v4]

Re: [EXTERNAL] [edk2-devel] [edk2-platforms][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR

Reviewed-by: Bret Barkelew - Bret From: devel@edk2.groups.io on behalf of Michael D Kinney via Groups.Io Sent: Monday, March 23, 2020 1:14:28 PM To: devel@edk2.groups.io ; Bret Barkelew ; Jiang, Guomin ; Kinney, Michael D Subject: Re: [EXTERNAL]

Re: [edk2-devel] [PATCH] UnitTestFrameworkPkg: Invalid index may be used.

Reviewed-by: Bret Barkelew - Bret From: devel@edk2.groups.io on behalf of Michael D Kinney via Groups.Io Sent: Monday, March 23, 2020 10:32:59 AM To: Jiang, Guomin ; devel@edk2.groups.io ; Zhang, Shenglei ; newexplor...@gmail.com ; Kinney, Michael D Cc:

Re: [edk2-devel] [PATCH 16/17] OvmfPkg/PvScsiDxe: Reset device on ExitBootServices()

On 03/16/20 16:01, Liran Alon wrote: > This causes the device to forget about the request/completion rings. > We allocated said rings in EfiBootServicesData type memory, and code > executing after ExitBootServices() is permitted to overwrite it. > > Ref:

Re: [edk2-devel] [PATCH 15/17] OvmfPkg/PvScsiDxe: Support sending SCSI request and receive response

There are many style problems with this patch. I'm going to focus on those, for now. I might not catch everything in a single review run, though (there are quite a few warts), so please don't be annoyed if I end up pointing out further style problems under v2. On 03/16/20 16:01, Liran Alon

Re: [edk2-devel] [PATCH 11/17] OvmfPkg/PvScsiDxe: Define device interface structures and constants

On 03/24/20 16:35, Laszlo Ersek wrote: > On 03/16/20 16:01, Liran Alon wrote: >> These definitions will be used by the following commits to complete the >> implementation of PVSCSI device driver. >> >> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567 >> Reviewed-by: Nikita Leshenko >>

Re: [edk2-devel] [PATCH 14/17] OvmfPkg/PvScsiDxe: Introduce DMA communication buffer

On 03/16/20 16:01, Liran Alon wrote: > In case device is constrained by IOMMU or guest is running under AMD SEV, > input/output buffers provided to device (DataBuffer and SenseData) needs > to be explicitly mapped to device by PciIo->Map(). > > To avoid the overhead of mapping/unmapping the

Re: [edk2-devel] [PATCH 13/17] OvmfPkg/PvScsiDxe: Setup requests and completions rings

really trivial style comments, for now (I intend to look at this in more detail in v2): On 03/16/20 16:01, Liran Alon wrote: > These rings are shared memory buffers between host and device in which > a cyclic buffer is managed to send request descriptors from host to > device and receive

Re: [edk2-devel] [PATCH 12/17] OvmfPkg/PvScsiDxe: Reset adapter on init

a bit more superficial comments, for now: On 03/16/20 16:01, Liran Alon wrote: > The following commits will complete the implementation of > device initialization. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567 > Reviewed-by: Nikita Leshenko > Signed-off-by: Liran Alon > --- >

Re: [edk2-devel] [PATCH v4] MdePkg/UnitTestBaseLib: Add check for pointer BinData

Reviewed-by: Michael D Kinney Mike > -Original Message- > From: Jiang, Guomin > Sent: Monday, March 23, 2020 6:43 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; > Gao, Liming > Subject: [PATCH v4] MdePkg/UnitTestBaseLib: Add check > for pointer BinData > > REF: >

Re: [edk2-devel] [PATCH 09/17] OvmfPkg/PvScsiDxe: Backup/Restore PCI attributes on Init/UnInit

On 24/03/2020 17:14, Laszlo Ersek wrote: On 03/16/20 16:01, Liran Alon wrote: I'm going to stop reviewing this iteration now; please rework the rest of the series for v2 with this resource management pattern. Thanks! Laszlo Thanks for the very detailed review! I have read all your comments

Re: [edk2-devel] [PATCH 11/17] OvmfPkg/PvScsiDxe: Define device interface structures and constants

On 03/16/20 16:01, Liran Alon wrote: > These definitions will be used by the following commits to complete the > implementation of PVSCSI device driver. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567 > Reviewed-by: Nikita Leshenko > Signed-off-by: Liran Alon > --- >

Re: [edk2-devel] [PATCH 17/17] OvmfPkg/PvScsiDxe: Enable device 64-bit DMA addresses

On 03/16/20 16:01, Liran Alon wrote: > Enable PCI dual-address cycle attribute to signal device supports > 64-bit DMA addresses. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567 > Reviewed-by: Nikita Leshenko > Signed-off-by: Liran Alon > --- > OvmfPkg/PvScsiDxe/PvScsi.c | 21

Re: [edk2-devel] [PATCH 09/17] OvmfPkg/PvScsiDxe: Backup/Restore PCI attributes on Init/UnInit

On 03/16/20 16:01, Liran Alon wrote: > This commit doesn't change semantics. > It is done as a preparation for future commits which will modify > PCI attributes. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567 > Reviewed-by: Nikita Leshenko > Signed-off-by: Liran Alon > --- >

Re: [edk2-devel] [PATCH] MdeModulePkg/HiiDatabase: Do not modify CONST string

Thanks for the update. Reviewed-by: Dandan Bi Thanks, Dandan > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Jeff Brasen > Sent: Friday, March 20, 2020 1:21 AM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Dong, Eric ; > Jeff Brasen >

Re: [edk2-devel] [PATCH 08/17] OvmfPkg/PvScsiDxe: Open PciIo protocol for later use

On 03/16/20 16:01, Liran Alon wrote: > This will give us an exclusive access to the PciIo of this device > after it was started and until is will be stopped. (1) typo: s/is will be/it will be/ > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567 > Reviewed-by: Nikita Leshenko >

Re: [edk2-devel] [PATCH 07/17] OvmfPkg/PvScsiDxe: Translate Target & LUN to/from DevicePath

On 03/16/20 16:01, Liran Alon wrote: > Implement EXT_SCSI_PASS_THRU.BuildDevicePath() and > EXT_SCSI_PASS_THRU.GetTargetLun(). > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567 > Reviewed-by: Nikita Leshenko > Signed-off-by: Liran Alon > --- > OvmfPkg/PvScsiDxe/PvScsi.c | 60

Re: [edk2-devel] [PATCH 06/17] OvmfPkg/PvScsiDxe: Report the number of targets and LUNs

On 03/16/20 16:01, Liran Alon wrote: > Implement EXT_SCSI_PASS_THRU.GetNextTarget() and > EXT_SCSI_PASS_THRU.GetNextTargetLun(). > > ScsiBusDxe scans all MaxTarget * MaxLun possible devices. > This can take unnecessarily long for large number of targets. > To deal with this, VirtioScsiDxe has

Re: [edk2-devel] [PATCH 05/17] OvmfPkg/PvScsiDxe: Install stubbed EXT_SCSI_PASS_THRU

On 03/24/20 13:27, Laszlo Ersek wrote: > On 03/16/20 16:01, Liran Alon wrote: >> Support dynamic insertion and removal of the protocol. >> >> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567 >> Reviewed-by: Nikita Leshenko >> Signed-off-by: Liran Alon >> --- >>

Re: [edk2-devel] [PATCH 05/17] OvmfPkg/PvScsiDxe: Install stubbed EXT_SCSI_PASS_THRU

On 03/16/20 16:01, Liran Alon wrote: > Support dynamic insertion and removal of the protocol. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567 > Reviewed-by: Nikita Leshenko > Signed-off-by: Liran Alon > --- > OvmfPkg/PvScsiDxe/PvScsi.c | 209 ++- >

Re: [edk2-devel] [PATCH 04/17] OvmfPkg/PvScsiDxe: Probe PCI devices and look for PvScsi

On 03/16/20 16:01, Liran Alon wrote: > PvScsiControllerSupported() is called on handles passed in > by the ConnectController() boot service and if the handle is the > PVSCSI controller, the function would return success. A success > return value will attach our driver to the device. > > Ref:

Re: [edk2-devel] [PATCH 03/17] OvmfPkg/PvScsiDxe: Report name of driver

On 03/16/20 16:00, Liran Alon wrote: > Install Component Name protocols to have a nice display name for the > driver in places such as UEFI shell. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567 > Reviewed-by: Nikita Leshenko > Signed-off-by: Liran Alon > --- >

  1   2   >