REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3908
Fix the build failure in CryptoPkg caused by this commit:
fab6285a73("CryptoPkg/CrtLibSupport: fix strcpy")
Remove the 'restrict' keyword which starts in VS2019.
Signed-off-by: Dun Tan
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc:
Hi,
I tested it locally. I just created a PR. Here is the link
https://github.com/tianocore/edk2/pull/2800
Thanks,
Dun
-Original Message-
From: Yao, Jiewen
Sent: Wednesday, April 20, 2022 11:40 AM
To: Tan, Dun ; devel@edk2.groups.io
Cc: Wang, Jian J ; Lu, Xiaoyu1 ;
Jiang, Guomin
Hi
May I know if you have run EDKII CI for this patch?
> -Original Message-
> From: Tan, Dun
> Sent: Wednesday, April 20, 2022 11:35 AM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen ; Wang, Jian J ;
> Lu, Xiaoyu1 ; Jiang, Guomin
> Subject: [PATCH] CryptoPkg: Fix the build failure in
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3908
Fix the build failure in CryptoPkg caused by this commit:
fab6285a73("CryptoPkg/CrtLibSupport: fix strcpy")
Remove the 'restrict' keyword which starts in VS2019.
Signed-off-by: Dun Tan
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc:
Hi Gerd
Do you have any comment for the regression issue?
I think we should remove "restrict" keyword.
Thank you
Yao Jiewen
> -Original Message-
> From: Tan, Dun
> Sent: Tuesday, April 19, 2022 5:27 PM
> To: devel@edk2.groups.io; Yao, Jiewen ; Gerd
> Hoffmann
> Cc: Oliver Steffen ;
The TianoCore wiki page is updated:
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Code-Formatting#how-to-find-uncrustify-formatting-errors-in-continuous-integration-ci
The patch to point to that section is here:
https://edk2.groups.io/g/devel/message/89098
Regards,
Michael
On
Hi Chao,
Are you referring to the change I made to put the link to the
instructions in the build log. Here's an example of what that will look
like:
This patch series is still missing reviews from some package
maintainers. Please review it when possible.
Thanks,
Michael
On 4/13/2022 10:21 PM, Michael Kubacki wrote:
A friendly reminder to those on the CC line to help review your
respective packages in this patch series.
Some of the
Hi Micheal,
Using the way your provided the link, I found the detail log, thanks, but this
way is not friendly to newbies, because they don't know how to find the
tutorial.:)
--
Thanks,
Chao
On 4月 20 2022, at 7:43 早上, "Michael Kubacki"
wrote:
> The wiki update is
From: Michael Kubacki
The NOOPT build target is used for host-based unit tests. This
change adds the NOOPT target for all packages to ensure that tests
are executed if present.
If the host-based DSC is not specified in the packages CI YAML file,
the host-based compiler plugin will be reported
From: Michael Kubacki
Adds a link to the log output that contains instructions on how find
detailed file formatting errors in the Azure DevOps UI.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Sean Brogan
Cc: Bret Barkelew
Signed-off-by: Michael Kubacki
---
BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Groups.io Inc//Groups.io Calendar//EN
METHOD:PUBLISH
REFRESH-INTERVAL;VALUE=DURATION:PT1H
X-PUBLISHED-TTL:PT1H
CALSCALE:GREGORIAN
BEGIN:VTIMEZONE
TZID:America/Los_Angeles
LAST-MODIFIED:20220317T223602Z
Hi Michael,
I'm in the exact same situation as Ard. My timezone + my lack of
availability (I do this as one of my hobbies, and not as a job) make it
very hard to attend meetings,
although I really don't mind discussing these issues on the mailing list.
I do have something to say about point 2)
Could I get some reviews on this please?
--
Rebecca Cran
On 4/10/22 19:16, Rebecca Cran wrote:
I ran into some problems debugging EDK2 code using Development Studio with
the files under ArmPlatformPkg/Scripts and these patches fix them.
I'm using Arm Development Studio 2021.2 and not DS-5,
Could I get some reviews on this please?
--
Rebecca Cran
On 4/13/22 16:45, Rebecca Cran wrote:
Copy code from PrePi to PrePeiCore that prints the firmware version
and build date early in the boot process.
Signed-off-by: Rebecca Cran
---
ArmPlatformPkg/PrePeiCore/PrePeiCore.c | 17
PR https://github.com/tianocore/edk2/pull/2797 is created.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Gao, Zhichao
> 发送时间: 2022年4月19日 13:09
> 收件人: devel@edk2.groups.io; Gao, Liming ; Ke,
> Bo-ChangX
> 抄送: Liu, Zhiguang ; Bi, Dandan
> ; Zeng, Star ; Kinney, Michael D
>
> 主题:
The wiki update is here:
https://github.com/makubacki/tianocore.github.io/blob/add_ci_uncrustify_instructions/EDK-II-Code-Formatting.md#how-to-find-uncrustify-formatting-errors-in-continuous-integration-ci
I am waiting for permissions to be updated so I can update the actual
wiki page and then
For Q2, if key word is defined in public spec, they can be handled as the
exception. You can see MdePkg\MdePkg.ci.yaml EccCheck section that has
ExceptionList and IgnoreFiles.
Thanks
Liming
发件人: devel@edk2.groups.io 代表 Sean
发送时间: 2022年4月20日 0:39
收件人: Chao Li ; devel@edk2.groups.io
主题:
GCC Stack Protector options come from GCC4.9.3. But, there is GCC48 in
tools_def. I am not sure whether GCC48 is still used.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Oliver Steffen
> 发送时间: 2022年4月19日 22:47
> 收件人: devel@edk2.groups.io
> 抄送: bob.c.f...@intel.com;
I agree that is ideal but I'm not aware of how to do that at the moment.
Thanks,
Michael
On 4/19/2022 4:52 PM, Michael D Kinney wrote:
Hi Michael,
Can the build log provide a direct link to the log file artifact if an error is
detected?
Mike
-Original Message-
From:
On Tue, 19 Apr 2022 at 09:35, Oliver Steffen wrote:
>
> PR: https://github.com/tianocore/edk2/pull/2711
>
> Update CI, run all Linux (aka Ubuntu-GCC5) based jobs in a custom
> Fedora 35 container.
Why?
> The image provides gcc 11 from Fedora for all
> architectures. The external dependencies
Hi Michael,
Can the build log provide a direct link to the log file artifact if an error is
detected?
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael Kubacki
> Sent: Tuesday, April 19, 2022 12:42 PM
> To: devel@edk2.groups.io; quic_rc...@quicinc.com;
Hello Michael,
On Tue, 19 Apr 2022 at 17:17, Michael Kubacki
wrote:
>
> Hello edk2-platforms maintainers,
>
> There is a TianoCore community meeting on Tools and CI that takes place
> weekly on Mondays from 19:30 - 20:30 PDT.
>
That is 4:30 AM my time, unfortunately.
> Meeting Details:
>
Hi Rebecca,
We are trying to keep the results reporting experience consistent with
other plugins and prevent an overwhelming amount of information being
printed to the build log.
In case other errors are present, providing high-level information from
each plugin can help point the user in
Reviewed-by: Rebecca Cran
On 4/12/22 10:29, mikub...@linux.microsoft.com wrote:
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds an instance of VariableFlashInfoLib to the platform build as
it is a new library class introduced in MdeModulePkg.
Cc: Anthony
Since people are going to keep running into this, could we just output
the file diff to the console? That would avoid having to go hunting for
the log file.
--
Rebecca Cran
On 4/19/22 10:39, Sean wrote:
Q1 - There should be more details in the actual log file, but your
code has formatting
Q1 - There should be more details in the actual log file, but your code has
formatting errors. In the last few months, the uncrusitfy tool has been
introduced to get common formatting errors fixed. See details here: EDK II
Code Formatting · tianocore/tianocore.github.io Wiki (
Hello edk2-platforms maintainers,
There is a TianoCore community meeting on Tools and CI that takes place
weekly on Mondays from 19:30 - 20:30 PDT.
Meeting Details:
https://github.com/tianocore/edk2/discussions/2614
Several recurring topics have come up regarding edk2-platforms:
1.
Explicity disable the stack protection with
-fno-stack-protection for builds using GCC on
AARCH64.
The gcc on Ubuntu enables -fstack-protector-strong
by default starting with Ubuntu 21.10.
GenFw fails if stack protection is enabled.
Signed-off-by: Oliver Steffen
---
PR: https://github.com/tianocore/edk2/pull/2795
Explicity disable the stack protection with
-fno-stack-protection for builds using GCC on
AARCH64.
The gcc on Ubuntu enables -fstack-protector-strong
by default starting with Ubuntu 21.10.
GenFw fails if stack protection is enabled.
Oliver
From: Yi Li
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3679
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3828
Tls/Base/Pei/Smm/RuntimeCryptLib.inf will use OpensslLib,
and the opensslconf.h in openssllib will use PcdEcEnabled,
but it is not declared in the inf file now,
it will
Inlined
> -Original Message-
> From: Gerd Hoffmann
> Sent: Tuesday, April 19, 2022 8:49 PM
> To: devel@edk2.groups.io; Xu, Min M
> Cc: Ard Biesheuvel ; Yao, Jiewen
> ; Justen, Jordan L ; Brijesh
> Singh ; Aktas, Erdem ;
> James Bottomley ; Tom Lendacky
>
> Subject: Re: [edk2-devel]
On 4/18/22 23:47, Yao, Jiewen wrote:
Can SEV clear the C-bit in SEC phase?
Not really. IIRC, even if cleared in the SEC phase, the DXE phase replaces
the page tables and it has to be cleared again.
Thanks,
Tom
I think that is right way to ensure PCI Express can always be accessed by
On 4/19/22 08:16, Tom Lendacky wrote:
On 4/18/22 19:26, Min Xu wrote:
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3902
CcProbeLib is imported in BaseIoLibIntrinsicSev.
OvmfPkg/Library/CcProbeLib is the OvmfPkg version which checks
OvmfWorkArea to return the Cc guest type. It is included
On 4/18/22 19:26, Min Xu wrote:
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3902
CcProbeLib is imported in BaseIoLibIntrinsicSev.
OvmfPkg/Library/CcProbeLib is the OvmfPkg version which checks
OvmfWorkArea to return the Cc guest type. It is included
in OvmfPkgX64.dsc and
On Wed, Apr 13, 2022 at 01:44:55PM +, Abner Chang wrote:
>
>
> > -Original Message-
> > From: Gerd Hoffmann
> > Sent: Wednesday, April 13, 2022 4:12 PM
> > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> >
> > Cc: Leif Lindholm ; Ard Biesheuvel
> > ; Jordan Justen
On Tue, Apr 19, 2022 at 11:12:39AM +, Min Xu wrote:
> On April 19, 2022 2:59 PM, Gerd Hoffmann wrote:
> > On Mon, Apr 18, 2022 at 07:59:56AM +0800, Min Xu wrote:
> > > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3853
> > >
> > > TdHobList and Configuration FV are external data provided
The patch is upstreamed through the commit-id:
https://github.com/tianocore/edk2-test/commit/dedfd87f76a9b48bfc03511c19beba285c4f5a81
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89071): https://edk2.groups.io/g/devel/message/89071
Hi, Michael
I carefully think about your comments and study the PCD. This PCD is to
enable/disable families and individual services produced by the EDK2 crypto
Protocols/PPIs.
SecCryptoLib is designed to be called in SEC phase and there is no
Protocol/PPIs in SEC phase. Shall we still use the
On April 19, 2022 2:59 PM, Gerd Hoffmann wrote:
> On Mon, Apr 18, 2022 at 07:59:56AM +0800, Min Xu wrote:
> > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3853
> >
> > TdHobList and Configuration FV are external data provided by Host VMM.
> > These are not trusted in Td guest. So they
Hi Hoffmann,
When building CryptoPkg, I found a build failure caused by this patch "
CryptoPkg/CrtLibSupport: fix strcpy"
https://github.com/tianocore/edk2/commit/fab6285a73c4c73bb131792d0afb20be369082d1.
When building CryptoPkg with the command " build -p CryptoPkg/CryptoPkg.dsc -b
DEBUG -t
Fix pip install.
Signed-off-by: Oliver Steffen
---
.azurepipelines/templates/platform-build-run-steps.yml | 6 ++
.azurepipelines/templates/pr-gate-steps.yml| 6 ++
2 files changed, 12 insertions(+)
diff --git a/.azurepipelines/templates/platform-build-run-steps.yml
Remove BaseTools/Bin/gcc*_linux_ext_dep.yaml to stop
downloading gcc from external locations; use the
toolchains provided by the container image instead.
The image needs to set the GCC5_*_PREFIX accordingly.
Signed-off-by: Oliver Steffen
---
BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml | 21
Run all Linux based jobs in a container, using a custom Fedora 35 image
(gcc 11). The image is hosted on ghcr.io and the container-files are
here: https://github.com/osteffenrh/edk2-build-images.
Do not run apt-get to install qemu and gcc dependencies. Assume the
container image provides these.
Use the Python supplied by the container image.
Signed-off-by: Oliver Steffen
---
.azurepipelines/templates/platform-build-run-steps.yml | 1 +
.azurepipelines/templates/pr-gate-steps.yml| 1 +
2 files changed, 2 insertions(+)
diff --git
PR: https://github.com/tianocore/edk2/pull/2711
Update CI, run all Linux (aka Ubuntu-GCC5) based jobs in a custom
Fedora 35 container. The image provides gcc 11 from Fedora for all
architectures. The external dependencies for gcc have been removed
so stuart does not download them. iasl and nasm
Remove BaseTools/Bin/gcc*_linux_ext_dep.yaml to stop
downloading gcc from external locations; use the
toolchains provided by the container image instead.
The image needs to set the GCC5_*_PREFIX accordingly.
Signed-off-by: Oliver Steffen
---
BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml | 21
Run all Linux based jobs in a container, using a custom Fedora 35 image
(gcc 11). The image is hosted on ghcr.io and the container-files are
here: https://github.com/osteffenrh/edk2-build-images.
Do not run apt-get to install qemu and gcc dependencies. Assume the
container image provides these.
Use the Python supplied by the container image.
Signed-off-by: Oliver Steffen
---
.azurepipelines/templates/platform-build-run-steps.yml | 1 +
.azurepipelines/templates/pr-gate-steps.yml| 1 +
2 files changed, 2 insertions(+)
diff --git
Fix pip install.
Signed-off-by: Oliver Steffen
---
.azurepipelines/templates/platform-build-run-steps.yml | 6 ++
.azurepipelines/templates/pr-gate-steps.yml| 6 ++
2 files changed, 12 insertions(+)
diff --git a/.azurepipelines/templates/platform-build-run-steps.yml
PR: https://github.com/tianocore/edk2/pull/2711
Update CI, run all Linux (aka Ubuntu-GCC5) based jobs in a custom
Fedora 35 container. The image provides gcc 11 from Fedora for all
architectures. The external dependencies for gcc have been removed
so stuart does not download them. iasl and nasm
On Mon, Apr 18, 2022 at 07:59:56AM +0800, Min Xu wrote:
> RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3853
>
> TdHobList and Configuration FV are external data provided by Host VMM.
> These are not trusted in Td guest. So they should be validated , measured
> and extended to Td RTMR
Hi Pu,
When would you expect having CpuLib merged to edk2 mainstream?
Regards,
Abner
From: devel@edk2.groups.io on behalf of Abner Chang
Sent: Friday, April 1, 2022 9:45 PM
To: devel@edk2.groups.io ; yu...@intel.com
Subject: Re: [edk2-devel] [PATCH v1 00/15]
Hi,
> As the first step CC_GUEST_TYPE is defined in this patch. In the
> next patch GUEST_TYPE will be deleted. This is to make sure the
> bisect work correctly.
Hmm, what exactly went wrong? Splitting into two patches looks
pointless. If the change is too big for an all-in-one patch typical
54 matches
Mail list logo
