Re: [edk2-devel] I cant build edk2 for taimen please help!

2024-05-15 Thread Andrew Fish via groups.io
Egor, The edk2 build tools have a tendency to throw if they find syntax errors, just like if they had internal errors. In this case I think the issue is in the repo? '/home/edk2-msm/Platform/goole/msm8998/taimen.dsc’ Maybe `goole` should be `Google` ? Thanks, Andrew Fish > On May 13, 2024,

Re: [edk2-devel] Synchronous Exception at ArmGicDxe

2024-04-24 Thread Andrew Fish via groups.io
The fault address is 0x0004AC14. Is that in the address range of the GIC for this platform? What does that Physical address map to you on the STM32MP25? Thanks, Andrew Fish > On Apr 21, 2024, at 10:07 PM, Ba Gia Bao Phan > wrote: > > Hi Everyone, > > I'm working on a project with

Re: [edk2-devel] Is there a way to create filesystem in UEFI Shell ?

2024-04-17 Thread Andrew Fish via groups.io
FYI you can have much larger files in the newer version of the filesystem. See EFI_COMMON_SECTION_HEADER2 https://uefi.org/specs/PI/1.8A/V3_Code_Definitions.html#firmware-file-system https://uefi.org/specs/PI/1.8A/V3_Code_Definitions.html#firmware-file-section Thanks, Andrew Fish > On Apr 3,

Re: [edk2-devel] bootloader build error

2024-04-05 Thread Andrew Fish via groups.io
Bill, The Python tools can tend to throw vs.flagging errors in the config files. Did you happen to edit anything in *.inf,*.dsc, or *.fdf files? This could just be a syntax error in those changes. This error looks like trying to make the FV (Firmware Volume) and Ffs would be one of the files

Re: [edk2-devel] Is there a way to create filesystem in UEFI Shell ?

2024-04-01 Thread Andrew Fish via groups.io
> On Mar 31, 2024, at 8:39 PM, John Chew wrote: > > On Sat, Mar 30, 2024 at 06:10 AM, Andrew Fish wrote: > You can make a ReadOnly file system out of contents on an FV (Firmware > Volume): > https://github.com/tianocore/edk2/tree/master/MdeModulePkg/Universal/FvSimpleFileSystemDxe > FV is

Re: [edk2-devel] Is there a way to create filesystem in UEFI Shell ?

2024-03-29 Thread Andrew Fish via groups.io
MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf is a virtual storage device, so it just emulates an unformatted disk. You would need to partition or initialize the file system given you have a RAM disk. The file system driver lives here:

Re: [edk2-devel] test message - my messages aren't showing up?

2024-03-28 Thread Andrew Fish via groups.io
David, You have to be subscribed to the list for the mails to got directly to the list. I think you just subscribed so I had to clear you as OK to post. Basically your posts were going to moderation and a human had to approve them. Thanks, Andrew Fish > On Mar 28, 2024, at 9:48 AM, David F.

Re: [edk2-devel] Memory Attribute for depex section

2024-01-12 Thread Andrew Fish via groups.io
> On Jan 12, 2024, at 11:04 AM, Kinney, Michael D > wrote: > > Agreed. Basically every API that takes an EF_HANDLE as input calls that API > to make sure it is a valid handle. > > The first question is if we get value from making sure the EFI_HANDLE is a > member of the active set of

Re: [edk2-devel] Memory Attribute for depex section

2024-01-12 Thread Andrew Fish via groups.io
> On Jan 12, 2024, at 8:37 AM, Michael D Kinney > wrote: > > Hi Pedro, > > Thank you for evaluating this idea change from linked list to improve > performance of the handle database. > > The concept of using integers for an EFI_HANDLE has been considered before. > One advantage over

Re: [edk2-devel] Memory Attribute for depex section

2024-01-12 Thread Andrew Fish via groups.io
> On Jan 12, 2024, at 6:46 AM, Pedro Falcato wrote: > > On Fri, Jan 12, 2024 at 9:35 AM Laszlo Ersek wrote: >> >> On 1/12/24 03:10, Pedro Falcato wrote: >>> My idea was to make each handle an index - like a file descriptor - >>> AFAIK there's no reason why it *needs* to be an actual

Re: [edk2-devel] Memory Attribute for depex section

2024-01-11 Thread Andrew Fish via groups.io
Sorry need some more time to digest this…. First thoughts. 1) The actual performance issue we hit was the explosion of CoreValidateHandle() calls as the number of protocols got large for some diags. The newer handles tended to be at the end of the list if I remember correctly. a) It looks

Re: [edk2-devel] UDK2022 stable202211 - GCC compiler for Windows for building X64 EFI

2023-09-27 Thread Andrew Fish via groups.io
There is info about toolchains checked in here:edk2/BaseTools/Conf/tools_def.template at master · tianocore/edk2github.comOn Sep 27, 2023, at 8:10 PM, Daniel Samuelraj wrote:We tried GCC at https://sourceforge.net/projects/gcc-win64/And then we tried GCC ver5.4We are getting the following

Re: [edk2-devel] Maybe it is time to update code style?

2023-09-25 Thread Andrew Fish via groups.io
It took me 2-3 weeks to flip my brain over to the 2 space indent. It was not so bad when I was just working on EFI stuff but if switch around between projects my editor having the wrong settings gets a lit old sometimes. The history of this was some of the old Intel legacy BIOS devs really

Re: [edk2-devel] [PATCH v1] EmulatorPkg: Fix Source Level Debug on Windows

2023-09-23 Thread Andrew Fish via groups.io
Very cool. Thank You! Thanks, Andrew Fish > On Sep 22, 2023, at 3:49 PM, Nate DeSimone > wrote: > > The Visual Studio Windows debugger will only load symbols for PE/COFF images > that Windows is aware of. Therefore, to enable source level debugging, all > PEI/DXE modules must be loaded via

Re: [edk2-devel] How i can fix this build error VariableRuntimeDxe.inf

2023-09-11 Thread Andrew Fish via groups.io
Well NintendoSwitchPkg is a project we are not involved in…. Looks like you are missing a line in your DSC file: VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf The build failure is VariableRuntimeDxe.inf has a dependency on on a

Re: [edk2-devel] VT100 terminal for UEFI shell

2023-09-07 Thread Andrew Fish via groups.io
> On Sep 7, 2023, at 12:11 PM, Marcin Juszkiewicz > wrote: > > W dniu 7.09.2023 o 19:40, Andrew (EFI) Fish pisze: >>> On Sep 7, 2023, at 8:00 AM, Marcin Juszkiewicz wrote: >>> >>> Is there a way to have VT100 (or any other black/white, non-ANSI) terminal >>> for UEFI Shell? >>> >>> I do

Re: [edk2-devel] VT100 terminal for UEFI shell

2023-09-07 Thread Andrew Fish via groups.io
> On Sep 7, 2023, at 8:00 AM, Marcin Juszkiewicz > wrote: > > Is there a way to have VT100 (or any other black/white, non-ANSI) terminal > for UEFI Shell? > > I do many runs of QEMU/sbsa-ref with logging and all those ANSI colour codes > only make problems. > These are the supported

Re: [edk2-devel] [PATCH] Use C99 flexible arrays

2023-08-22 Thread Andrew Fish via groups.io
My understanding is zero length arrays have not been legal C code since C89. They may still function as a compiler extension. struct foo { size_t len; char. Str[]0]; }; I seem to remember the reason we did not use the C99 flexible array members is back in the day as Visual Studio 2003

Re: [edk2-devel] About EDK2 supports Self Modifying Code

2023-08-17 Thread Andrew Fish via groups.io
> On Aug 17, 2023, at 12:53 PM, Michael D Kinney > wrote: > > How many different integer values are needed by FW for use of the csrrd > instruction? > MIke, I’m no expert on this and I just tried to site read a specification for the 1st time…. It looks to me the like the arch spec does

Re: [edk2-devel] Error F001: Module SmmLockBox.inf NOT found

2023-08-17 Thread Andrew Fish via groups.io
I think I may have botched this message in moderation…. Andrew, Did you update the submodule? git submodule update —init See Submodules under this section of the ReadMe.rst: https://github.com/tianocore/edk2 What were you trying to build? Thanks, Andrew Fish > Subject: Error F001: Module

Re: [edk2-devel] Can RELEASE target disable -Werror CC_FLAG?

2023-08-17 Thread Andrew Fish via groups.io
Can you add -Wno-maybe-uninitialized to compiler flags to work around the error?On Aug 16, 2023, at 11:31 PM, 汪流 wrote: This is the failed build log: 

Re: [edk2-devel] Can RELEASE target disable -Werror CC_FLAG?

2023-08-16 Thread Andrew Fish via groups.io
Mike, I seem to remember it was a maybe-uninitialized compiler error. The DEBUG build did not hit it due to the NULL check in the ASSERT. The NULL check only exists if ASSERT() is enabled. So if ASSERT is disabled this code in the DXE Core will dereference a NULL pointer. > ASSERT

Re: [edk2-devel] About EDK2 supports Self Modifying Code

2023-08-15 Thread Andrew Fish via groups.io
> On Aug 15, 2023, at 11:48 AM, Ard Biesheuvel wrote: > > On Tue, 15 Aug 2023 at 18:31, Andrew Fish via groups.io <http://groups.io/> > mailto:afish=apple@groups.io>> wrote: >> >> >> >>> On Aug 15, 2023, at 8:39 AM, Pedro Falcato wro

Re: [edk2-devel] About EDK2 supports Self Modifying Code

2023-08-15 Thread Andrew Fish via groups.io
> On Aug 15, 2023, at 8:39 AM, Pedro Falcato wrote: > > On Tue, Aug 15, 2023 at 4:05 PM Andrew Fish via groups.io > wrote: >> >> Chao, >> >> From a quick google it looks like CSR* is used to access banks of registers >> that relate to

Re: [edk2-devel] About EDK2 supports Self Modifying Code

2023-08-15 Thread Andrew Fish via groups.io
Chao, >From a quick google it looks like CSR* is used to access banks of registers >that relate to things like performance counters and debug infrastructure and >the number of banks of these register sets is likely implementation defined. >Seems like we could introduce some Fixed At Build PCD

Re: [edk2-devel] About EDK2 supports Self Modifying Code

2023-08-14 Thread Andrew Fish via groups.io
We also support Xcode clang so that means we also support Mach-O executables that get converted to PE/COFF. The is a tool called mtoc (mach-o to coff) in a crufty old open source project that does the conversion. The reason you are having issues is due to security hardening as the self

Re: [edk2-devel] [PATCH v1 0/7] Add DebugMacroCheck

2023-08-14 Thread Andrew Fish via groups.io
> On Aug 14, 2023, at 5:26 PM, Michael Kubacki > wrote: > > On 8/14/2023 8:23 PM, Andrew Fish via groups.io wrote: >>> On Aug 14, 2023, at 3:51 PM, Pedro Falcato wrote: >>> >>> On Mon, Aug 14, 2023 at 9:49 PM Michael Kubacki >>> mailto:mikub

Re: [edk2-devel] [PATCH v1 0/7] Add DebugMacroCheck

2023-08-14 Thread Andrew Fish via groups.io
> On Aug 14, 2023, at 3:51 PM, Pedro Falcato wrote: > > On Mon, Aug 14, 2023 at 9:49 PM Michael Kubacki > mailto:mikub...@linux.microsoft.com>> wrote: >> >> From: Michael Kubacki >> >> Adds a new script and build plugin called DebugMacroCheck. >> >> The script verifies that the number of

Re: [edk2-devel] Can RELEASE target disable -Werror CC_FLAG?

2023-08-10 Thread Andrew Fish via groups.io
I think that you are advocating that since we have code that error checks on DEBUG and not RELEASE builds we should relax the RELEASE build compiler flags? /home/abuild/rpmbuild/BUILD/edk2-edk2-stable202305/MdeModulePkg/Core/Dxe/Hand/Handle.c:1183:24: error: ‘Prot’ may be used uninitialized

Re: [edk2-devel] Runtime Page Granularity on ARM64

2023-08-09 Thread Andrew Fish via groups.io
Oliver, My understanding is that AArch64 (ARMv8) supports 3 page table granules: 4KB, 16KB, and 64KB [1]. These granules represent the smallest range for a page table, and this granule changes which bits of the VA index into what level of paging. On x86 this indexing was fixed an a 2 MiB page

Re: [edk2-devel] [edk2-test]

2023-07-18 Thread Andrew Fish via groups.io
John, The UEFI Forum (https://uefi.org/) is the industry trade group that owns the UEFI and ACPI specifications. It also hosts the SCTs: https://uefi.org/testtools Thanks, Andrew Fish > On Jul 17, 2023, at 9:31 AM, Sellock, John via groups.io > wrote: > > Hello, > > I am John Sellock, an

Re: [edk2-devel] Managing boot order dependencies with ResetNotification Protocol

2023-07-11 Thread Andrew Fish via groups.io
Ajay, In general the order of dispatch when all the DEPEX evaluate to TRUE and the oder of events are not defined by the specification. I think you are trying to say stuff that dispatches later is higher up the stack and it would make more sense to send the rest to things higher up the

Re: [edk2-devel] CpuDeadLoop() is optimized by compiler

2023-05-19 Thread Andrew Fish via groups.io
I don’t think the atomic is going to help. The compiler honored the volatile by doing a read, but assumed it would never change due to scoping. As you can see in my example if the compiler thinks DeadLoopCount can be changed it will put the check back in and assume the function can return. So

Re: [edk2-devel] CpuDeadLoop() is optimized by compiler

2023-05-18 Thread Andrew Fish via groups.io
VQCSrTNCALUklApxtSQNDlGhaCdYgXTdMMPWYYhQ19FT/QIIMQ2VCMoxjdk4xvPAkxTdk02QDNiOzQRc2VAsixLDAVnZCsqxrPh6ybFt207LMh2EURxEHHt5CUNRlV0AIdJnPi51CxcIGXVc0k3bdd33ZBDzJY9T3PS9bBg28IFcND7RfRCpmQnJki/dJIN/Qa8jSLD%2BvQ9rqlQ0aZvsMDMNfbCUM6bqBk6Kb3xk%2BZFmWPQK0wALSI4ZlSFZdlKJo%2BjGNOHT2Mkb4NBe7jeKsOcNkEogpKFe0NnEy1YkFMkzFk0VxUUpB8C

Re: [edk2-devel] CpuDeadLoop() is optimized by compiler

2023-05-18 Thread Andrew Fish via groups.io
rew Fish via groups.io > wrote: > > Mike, > > This is a good way to play around with fixes, and to report bugs. You can see > the assembler for different compilers with different flag. >

Re: [edk2-devel] CpuDeadLoop() is optimized by compiler

2023-05-18 Thread Andrew Fish via groups.io
Mike, This is a good way to play around with fixes, and to report bugs. You can see the assembler for different compilers with different flag.

Re: [edk2-devel] CpuDeadLoop() is optimized by compiler

2023-05-18 Thread Andrew Fish via groups.io
Rebecca, It looks like VC++ is trying to honor the volatile by reading the variable, incase that has side effects. But the loop is not checking the value of the variable and it is just doing an unconditional jump. This is why I think it is likely a compiler bug. Since the compiler emitted a

Re: [edk2-devel] CpuDeadLoop() is optimized by compiler

2023-05-18 Thread Andrew Fish via groups.io
Mike, I guess my other question… If this turns out to be a compiler bug should we scope the change to the broken toolchain. I’m not sure what the right answer is for that, but I want to ask the question? Thanks, Andrew Fish > On May 18, 2023, at 10:19 AM, Michael D Kinney > wrote: > >

Re: [edk2-devel] CpuDeadLoop() is optimized by compiler

2023-05-18 Thread Andrew Fish via groups.io
Yea, but I think you want static and volatile on the global. But good idea as for the non XIP case you can just modify the global. It might be a good idea to document the debugging flow in the header for CpuDeadLoop()... Thanks, Andrew Fish > On May 18, 2023, at 10:19 AM, Kinney, Michael D

Re: [edk2-devel] CpuDeadLoop() is optimized by compiler

2023-05-18 Thread Andrew Fish via groups.io
Mike, Good point, that is why we are using the stack …. The only other thing I can think of is to pass the address of Index to some inline assembler, or an asm no op function, to give it a side effect the compiler can’t resolve. Thanks, Andrew Fish > On May 18, 2023, at 10:05 AM, Kinney,

Re: [edk2-devel] CpuDeadLoop() is optimized by compiler

2023-05-18 Thread Andrew Fish via groups.io
Mike, I pinged some compiler experts to see if our code is correct, or if the compiler has an issue. Seems to be trending compiler issue right now, but I’ve NOT gotten feedback from anyone on the spec committee yet. If we move Index to a static global that would likely work around the

Re: [edk2-devel] Building error

2023-05-18 Thread Andrew Fish via groups.io
In the WmiAwcc.asl file it looks like the 1109th byte has some invalid UTF-8 encoding. So it looks like the file got edited with an editor that us using an encoding other than ASCII or UTF-8? Thanks, Andrew Fish > On May 18, 2023, at 1:43 AM, Eva.Ss.Feng (ńTÉșÉș) > wrote: > > HI Devel > I

Re: [edk2-devel] DSC nightmare

2023-02-22 Thread Andrew Fish via groups.io
Ben, I’d say the tools are optimized to be general purpose. So they are not really designed to be the easy button. In terms of things like SEC/PEI or DXE it is very common for this code on x86 to be compiled for different architectures. SEC/PEI is usually i386 and DXE is x86_64. Crazy I know

Re: [edk2-devel] regarding calling UEFI runtime services (mainly SetVariable) from linux or android OS which is running on xen+tianocore UEFI

2023-02-06 Thread Andrew Fish via groups.io
> On Feb 6, 2023, at 10:25 AM, ritul guru wrote: > > Thanks, > so as it is memory, does it mean if anything written in variable store, and > VM reboot happens then variable store will be flushed? > It looks like it is saved if you do an S3. S3 is ACPI speak for a sleep state that puts RAM

Re: [edk2-devel] USB: reducing/removing EHCI and XHCI logging when bulk transfer requests timeout

2022-11-29 Thread Andrew Fish via groups.io
> On Nov 29, 2022, at 11:47 AM, Rebecca Cran wrote: > > On 11/29/22 12:43, Andrew Fish via groups.io wrote: >>> On Nov 29, 2022, at 11:12 AM, Rebecca Cran wrote: >>> >>> I've been working on the UsbNetworkPkg drivers that Richard Ho submitted. >>&g

Re: [edk2-devel] USB: reducing/removing EHCI and XHCI logging when bulk transfer requests timeout

2022-11-29 Thread Andrew Fish via groups.io
> On Nov 29, 2022, at 11:12 AM, Rebecca Cran wrote: > > I've been working on the UsbNetworkPkg drivers that Richard Ho submitted. One > problem I've run into is that since we poll for bulk requests, most of the > time they will timeout - and currently both EHCI and XHCI drivers log errors

Re: [edk2-devel] On RPi4 and Juno, gBS->Stall(1) takes 10us and 100us respectively

2022-11-28 Thread Andrew Fish via groups.io
Rebecca, gBS->Stall() is built on top [1] of the Metronome Architectural Protocol [2]. You should look at how the platform implements the Metronome Architectural Protocol. It looks like most platform implement a generic Metronome Driver[3] that just sits on top of the platforms TimerLib [4]

Re: [edk2-devel] Access 64bit address space in 32bit mode

2022-11-09 Thread Andrew Fish via groups.io
tree/master/MdeModulePkg/Universal/CapsulePei > > On Wed, Nov 9, 2022 at 9:21 AM Andrew Fish via groups.io <http://groups.io/> > mailto:apple@groups.io>> wrote: >> >>> On Nov 7, 2022, at 7:16 PM, Yoshinoya >> <mailto:yoshinoyat...@163.com>> wrot

Re: [edk2-devel] How to add a DXE driver to an OVMF image?

2022-11-09 Thread Andrew Fish via groups.io
> On Nov 9, 2022, at 10:29 AM, d.meneses via groups.io > wrote: > > Thank you Andrew for your reply. > > Your explanation about the Driver Binding protocol cleared up some questions > of mine. > > Regarding the BDS, I recon I have some reading to do before I understand what > you said

Re: [edk2-devel] How to add a DXE driver to an OVMF image?

2022-11-09 Thread Andrew Fish via groups.io
> On Nov 4, 2022, at 6:20 AM, d.meneses via groups.io > wrote: > > Using DebugLib instead to print a message, I was able to confirm that my > driver is now running properly: > cat debug.log | grep Hello > This works both when adding it in the OVMF build and also when inserted by > UEFITool.

Re: [edk2-devel] How to add a DXE driver to an OVMF image?

2022-11-03 Thread Andrew Fish via groups.io
> On Nov 3, 2022, at 12:11 PM, d.meneses via groups.io > wrote: > > Yes I also believe I'm threading a XY problem. > > Let's simplify my learning and set the goal to: add an UEFI application to > OVMF so that it runs natively on startup. > > Does this make more sense? > > I followed the

Re: [edk2-devel] How to add a DXE driver to an OVMF image?

2022-11-02 Thread Andrew Fish via groups.io
If you are building with the firmware use the DebugLib in the INF and DEBUG(); macros. DEBUG((DEBUG_ERROR, “It works\n”)); Also by setting your Depex to TRUE you are basically asking to run before the console is available. If you want to depend on all UEFI Services being present don’t set a

Re: [edk2-devel] TPM2 EventLog EFI vs. ACPI

2022-09-17 Thread Andrew Fish via groups.io
> On Sep 17, 2022, at 11:31 AM, Jason Andryuk wrote: > > On Fri, Sep 16, 2022 at 10:28 PM Andrew Fish via groups.io > wrote: >> >> Is it possible to query the address from fw_cfg? > > Hi, Andrew, > > I believe QEMU puts "commands" into

Re: [edk2-devel] TPM2 EventLog EFI vs. ACPI

2022-09-16 Thread Andrew Fish via groups.io
Is it possible to query the address from fw_cfg? Thanks, Andrew Fish > On Sep 16, 2022, at 12:45 PM, Jason Andryuk wrote: > > Hi, > > I've noticed an issue with the TPM2 EventLog. OVMF exposes the TPM > Event Log via EFI and ACPI, but they have different addresses. The > EFI one

Re: [edk2-devel] [PATCH] Maintainers.txt: Update email address

2022-09-15 Thread Andrew Fish via groups.io
Reviewed-by: Andrew Fish > On Sep 15, 2022, at 9:58 AM, Michael D Kinney > wrote: > > Reviewed-by: Michael D Kinney > > > >> -Original Message- >> From: Nickle Wang mailto:nick...@nvidia.com>> >> Sent: Wednesday, September 14, 2022 7:20 PM >> To:

Re: [edk2-devel] Error building MdeModulePkg.dsc with CLANG38 (clang 11.0.1)

2022-09-06 Thread Andrew Fish via groups.io
That is a missing EFIAPI. > On Sep 6, 2022, at 4:46 PM, Rebecca Cran wrote: > > I noticed that MdeModulePkg/MdeModulePkg.dsc doesn't build with clang 11: I > get an error in CapsuleApp: > > > build -p MdeModulePkg/MdeModulePkg.dsc -a X64 -t CLANG38 -b DEBUG > > ... > >

Re: [edk2-devel] [PATCH 1/1] MdePkg: Use ANSI colors to indicate debug message severity

2022-09-01 Thread Andrew Fish via groups.io
> On Sep 1, 2022, at 4:52 PM, Rebecca Cran wrote: > > Thanks. I've just sent out a v2 that introduces a > > PcdTerminalSupportsAnsiSequences FeatureFlag. > > Let me know if you'd prefer a different name: I wondered about something like > PcdConOutAnsiSeqSupport for example. > Rebecca, I

Re: [edk2-devel] How to restrict HTTPS boot to a single address

2022-08-26 Thread Andrew Fish via groups.io
Rafael, I’m not sure this matches exactly what you are looking for, but the OVMF (Virtual Machine) has some configuration options around HTTPS boot [1]. That might be a good place to start. [1] https://github.com/tianocore/edk2/blob/master/OvmfPkg/README#L232 Thanks, Andrew Fish > On Aug

Re: [edk2-devel] BaseTools no longer builds on macOS: "error: unknown warning option '-Werror=stringop-overflow'"

2022-08-25 Thread Andrew Fish via groups.io
erflow endif endif +endif LIBS = -lCommon ifeq ($(CYGWIN), CYGWIN) Thanks, Andrew Fish > On Aug 25, 2022, at 10:45 AM, Andrew Fish via groups.io > wrote: > > Rebecca, > > FYI /usr/bin/gcc has been a redirector into clang for a lot of years. > > The build picks di

Re: [edk2-devel] BaseTools no longer builds on macOS: "error: unknown warning option '-Werror=stringop-overflow'"

2022-08-25 Thread Andrew Fish via groups.io
Rebecca, FYI /usr/bin/gcc has been a redirector into clang for a lot of years. The build picks different default sets of complier flags based on build type. There is already code that assumes gcc == clang here [1] I think the issue is the check that is wrapping "BUILD_CFLAGS +=

Re: [edk2-devel] [PATCH 1/2] Mde Pkg: Support for MPAM ACPI Table

2022-08-23 Thread Andrew Fish via groups.io
Rohit, FYI I seem to remember when we added the bitfield verbiage to the UEFI Spec it was because there was lots of platform code that was using it. We did not really want to encourage its use it in public interfaces. Given there is lots of code 1st kind of things going on I’d figured I’d

Re: [edk2-devel] [PATCH 1/2] Mde Pkg: Support for MPAM ACPI Table

2022-08-23 Thread Andrew Fish via groups.io
> On Aug 19, 2022, at 1:26 AM, Rohit Mathew wrote: > > Hi Swatisri, > > Thanks for the patch. Please find my comments inline marked [Rohit] - > >> -Original Message- >> From: devel@edk2.groups.io >> mailto:devel@edk2.groups.io>> On Behalf Of Name >> via

Re: [edk2-devel] Building C static Library for UEFI

2022-08-09 Thread Andrew Fish via groups.io
Did you figure this out? The per compiler flags come from BaseTools/Conf/tools_def.template. When you do the edksetup.sh it gets copied to Conf/tools_def.ttxt and that is what the build uses. The rules to generate makefiles come from BaseTools/Conf/build_rule.template[2] and gets copied to

Re: [edk2-devel] Casting i128 into f64 in UEFI Rust pagefaults

2022-07-26 Thread Andrew Fish via groups.io
adcq >>> %rax, %rdx >>> hello_world_std.efi[0x140001b6c]: 48 31 c1 xorq >>> %rax, %rcx >>> hello_world_std.efi[0x140001b6f]: 48 31 c2 xorq >>> %rax, %rdx >>> hello_world_std.efi[0x140001b72]: 4

Re: [edk2-devel] [Patch v3 3/3] Maintainers.txt: Remove reviewer Harry Han

2022-07-25 Thread Andrew Fish via groups.io
Reviewed-by: Andrew Fish > On Jul 21, 2022, at 2:07 PM, Michael D Kinney > wrote: > > Cc: Harry Han > Cc: Andrew Fish > Cc: Leif Lindholm > Signed-off-by: Michael D Kinney > Reviewed-by: Harry Han > --- > Maintainers.txt | 2 -- > 1 file changed, 2 deletions(-) > > diff --git

Re: [edk2-devel] [Patch v3 0/3] Update Maintainers.txt

2022-07-25 Thread Andrew Fish via groups.io
Reviewed-by: Andrew Fish > On Jul 21, 2022, at 2:07 PM, Michael D Kinney > wrote: > > Cc: Anthony Perard > Cc: Julien Grall > Cc: Daniel Schaefer > Cc: Sean Rhodes > Cc: Debkumar De > Cc: Erdem Aktas > Cc: Harry Han > Cc: Gary Lin > Cc: Andrew Fish > Cc: Leif Lindholm >

Re: [edk2-devel] Casting i128 into f64 in UEFI Rust pagefaults

2022-07-25 Thread Andrew Fish via groups.io
Again sorry I don’t have anything installed to crack PDB files. > > Thanks, > > Andrew Fish > >> On Jul 25, 2022, at 10:51 AM, Andrew Fish via groups.io >> wrote: >> >> Ayush, >> >> CR2 is the fault address so 0x. Given

Re: [edk2-devel] Casting i128 into f64 in UEFI Rust pagefaults

2022-07-25 Thread Andrew Fish via groups.io
Jul 25, 2022, at 10:51 AM, Andrew Fish via groups.io > wrote: > > Ayush, > > CR2 is the fault address so 0x. Given for EFI Virt == > Physical the fault address looks like a bad pointer. > > Sorry I’ve not used VC++ in a long time so I don’t k

Re: [edk2-devel] Casting i128 into f64 in UEFI Rust pagefaults

2022-07-25 Thread Andrew Fish via groups.io
Ayush, CR2 is the fault address so 0x. Given for EFI Virt == Physical the fault address looks like a bad pointer. Sorry I’ve not used VC++ in a long time so I don’t know how to debug with VC++, but If I was using clang/lldb I’d look at the source and assembly for the fault

Re: [edk2-devel] Clarification of Memory management in PEI phase

2022-06-22 Thread Andrew Fish via groups.io
Brian, I think all the PEI Allocate Pool does is make a HOB [1]. I don’t think we can remove HOBs when memory is freed as that would change pointers to pool. It may be possible to mark a region as free and allocate from that list batch 1st, and just over allocate space if needed. It could be

Re: [edk2-devel] Aurora build failure

2022-06-22 Thread Andrew Fish via groups.io
I’m guessing all the CI testing is on Python 3.8.x I noticed one of the CI pipes is asking for Python 3.8 [1] [1] https://github.com/tianocore/edk2/blob/master/.azurepipelines/Ubuntu-PatchCheck.yml Thanks, Andrew Fish > On Jun 22, 2022, at 7:34 AM, Andrew (EFI) Fish wrote: > > That looks

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Suppress read only relocs errors on XCODE5 X64 toolchain

2022-06-22 Thread Andrew Fish via groups.io
;> >> Thanks, >> >> Andrew Fish >> >>> On Jun 18, 2022, at 8:19 PM, Andrew Fish via groups.io >>> wrote: >>> >>> Marvin, >>> >>> I’ll look into this. >>> >>> The history here is the original

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Suppress read only relocs errors on XCODE5 X64 toolchain

2022-06-22 Thread Andrew Fish via groups.io
I reached out to the Xcode ld64 maintainer to make sure it is safe to use -read_only_relocs suppress this way. Thanks, Andrew Fish > On Jun 18, 2022, at 8:19 PM, Andrew Fish via groups.io > wrote: > > Marvin, > > I’ll look into this. > > The history here is

Re: [edk2-devel] Aurora build failure

2022-06-22 Thread Andrew Fish via groups.io
That looks like an issue with using Python 3.9 as it changed tostring to tobyte. > On Jun 22, 2022, at 7:25 AM, Shivraj Patil wrote: > >  > Hello, > I am observing the following failure while trying to build Aurora > AU_LINUX_EMBEDDED_LE.PRODUCT.1.0_TARGET_ALL.01.318.215. Please have a look

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Suppress read only relocs errors on XCODE5 X64 toolchain

2022-06-18 Thread Andrew Fish via groups.io
Marvin, I’ll look into this. The history here is the original ld64 flags are what was required for proper function. I got them directly from the main ld64 maintainer. Big picture ld64 is the macOS and iOS linker, and it does not have official support for other targets, especially embedded.

Re: [edk2-devel] Windows 10 build failing

2022-06-17 Thread Andrew Fish via groups.io
> On Jun 17, 2022, at 9:55 AM, M.T. wrote: > > I think I'm getting somewhere now. > > I set everything up and I started getting a consistent error (see logfile > from my last email) > I had to comment out BrDummyMalloc from BrotliDecUefiSupport.h, and now I am > able to build MdeModulePkg.

Re: [edk2-devel] Running OVMF on crosvm

2022-06-16 Thread Andrew Fish via groups.io
Mike, FYI you are not subscribed to the mailing list so all your posts require a humans approval, so that is the delay in them showing up.. > On Jun 16, 2022, at 4:29 PM, Mike Gerow via groups.io > wrote: > > Hi Folks, > > For the last few months I've been using OVMF with crosvm >

Re: [edk2-devel] Does edk2 also link to crt0-efi like GNU-EFI *

2022-06-16 Thread Andrew Fish via groups.io
> On Jun 16, 2022, at 1:17 PM, Ayush Singh wrote: > > Thanks for the great answer. After some discussion in the zulip [1], I > have some approaches that I will try first. > > As for calling C, EFIABI from Rust, yes, it is quite well supported. > Rust also has a specific EFIABI now, since some

Re: [edk2-devel] Does edk2 also link to crt0-efi like GNU-EFI

2022-06-16 Thread Andrew Fish via groups.io
> On Jun 16, 2022, at 7:20 AM, Ayush Singh wrote: > > Hello everyone, I wanted to ask if the edk2 build system also links to > crt0-efi, like GNU-EFI? > > If yes, I would also like to see how that is actually implemented. If > not, how does edk2 support custom entry functions? It is possible

Re: [edk2-devel] Clarification of Memory management in PEI phase

2022-06-09 Thread Andrew Fish via groups.io
> On Jun 9, 2022, at 10:28 AM, Ayush Singh wrote: > > Hello everyone, > > Can anyone help me with understanding dynamic memory management in PEI > phase? In the UEFI Platform Integration Specification, version 1.7 > Errata A, Section 4.6, PEI Memory services are given which include: > > 1.

Re: [edk2-devel] ovmf miscompiles with gcc-12

2022-06-08 Thread Andrew Fish via groups.io
Mike, This sounds like a conversation we had years ago? I think we concluded we needed to write stuff in assembler and not depend on implementation choices of the compiler with regard to registers usage? I want to say something broke with Xcode clang. I think it might have been the Emulator

[edk2-devel] [ArmVirtPkg] So in 2014 would could not start an ARM FV @ address 0x00000000, why is that still true today?

2022-06-03 Thread Andrew Fish via groups.io
I’m a little confused on why we can’t put an ARM FV at address 0x [1]? Obviously the zero vector for the FV is getting patch as this ARM code is jumping to the 1st byte of the FV when it is present at 0x1000. I don’t know of any generic limitation in our tools. This kind of feels like

Re: [edk2-devel] including redfish libs results in multiple definitions of symbols

2022-05-25 Thread Andrew Fish via groups.io
native. Then again, I might be wrong, > too... > > On 5/25/22 23:04, Andrew Fish via groups.io wrote: >>> On May 25, 2022, at 9:23 AM, M.T. >> <mailto:xzavierpo...@gmail.com>> wrote: >>> >>> Hello >>> >>> I'm working on a smal

Re: [edk2-devel] including redfish libs results in multiple definitions of symbols

2022-05-25 Thread Andrew Fish via groups.io
> On May 25, 2022, at 9:23 AM, M.T. wrote: > > Hello > > I'm working on a small UEFI shell app. > I was hoping to make use of the JsonLib found in the Redfish Package. > > When I include the Redfish JsonLib and it's dependencies: > JsonLib|RedfishPkg/Library/JsonLib/JsonLib.inf >

Re: [edk2-devel] [edk2] [PATCH v1 1/1] OvmfPkg/TdxDxe: Remove AsmRelocateApMailBoxLoopStart prefix at call

2022-05-25 Thread Andrew Fish via groups.io
I think we need to -D OPENSSL_NO_APPLE_CRYPTO_RANDOM in the INF. Thanks, Andrew Fish > On May 25, 2022, at 7:39 PM, Rebecca Cran wrote: > > It's Library/OpensslLib/openssl/include/crypto/rand.h > > # include > > # if defined(__APPLE__) && !defined(OPENSSL_NO_APPLE_CRYPTO_RANDOM) > #

Re: [edk2-devel] [edk2] [PATCH v1 1/1] OvmfPkg/TdxDxe: Remove AsmRelocateApMailBoxLoopStart prefix at call

2022-05-25 Thread Andrew Fish via groups.io
What is pulling in Availability.h? That sound more like and #ifdef issue in some 3rd party header? I think I might have seen that in SSL headers? > On May 25, 2022, at 6:26 PM, Rebecca Cran wrote: > > Reviewed-by: Rebecca Cran > Tested-by: Rebecca Cran > > This lets the build get further,

[edk2-devel] Can you create a PCI Option ROM and place it in an FV in a single build?

2022-05-24 Thread Andrew Fish via groups.io
I realize I can use syntax like this to control the construction of an option ROM from an FDF file. 1 [OptionRom.AtapiPassThru] 2 INF USE = IA32 OptionRomPkg/AtapiPassThruDxe/AtapiPassThruDxe.inf { 3 PCI_REVISION = 0x0020 4 PCI_DEVICE_ID = 0x0A03 0x0B03 5 } 6 INF USE = EBC

Re: [edk2-devel] Question about PCD and FW_BASE_ADDRESS

2022-05-09 Thread Andrew Fish via groups.io
> On May 9, 2022, at 2:42 AM, Boeuf, Sebastien > wrote: > > Hi, > > I have a question related to the MMIO accesses performed by OVMF that I > can see are happening whenever PcdGet() is invoked. Could you tell me > how PCD works that can explain why I can see some MMIO read accesses on >

Re: [edk2-devel] Debug OVMF

2022-05-09 Thread Andrew Fish via groups.io
Sebastien, The UEFI ROMs generally contain sets of PE/COFF images (drivers, apps, etc) that execute not at their linked address. These PE/COFF images have been stripped of debug information and optionally contain a PE/COFF debug directory entry that points to a file that contains the debug

Re: [edk2-devel] [rfc] Remove support for unsupported tool_chain_tags

2022-05-04 Thread Andrew Fish via groups.io
I can sign up to maintain XCODE. I think Rebecca has been running test builds with XCODE. The XCODE5 names comes from the compiler flags needing to change for Xcode 5. Yes 2013 called and wants it compiler back. Thanks, Andrew Fish > On May 2, 2022, at 4:24 PM, Sean wrote: > > As

Re: [edk2-devel] [edk2-discuss] GSoC Proposal

2022-04-14 Thread Andrew Fish via groups.io
> On Apr 14, 2022, at 6:06 PM, Nate DeSimone > wrote: > > Hi Marvin, > >> -Original Message- >> From: devel@edk2.groups.io On Behalf Of Marvin >> Häuser >> Sent: Thursday, April 14, 2022 12:56 AM >> To: disc...@edk2.groups.io; Desimone, Nathaniel L >> >> Cc: Pedro Falcato ;

Re: [edk2-devel][PATCH v3 1/8] IntelFsp2Pkg: X64 compatible changes to support PEI in 64bit

2022-04-06 Thread Andrew Fish via groups.io
> On Apr 6, 2022, at 4:57 PM, Ni, Ray wrote: > >> -; UINT32 >> +; UINTN >> ; EFIAPI >> -; AsmReadEsp ( >> +; AsmReadStackPointer ( >> ; VOID >> ; ); >> ;-- >> -global ASM_PFX(AsmReadEsp) >> -ASM_PFX(AsmReadEsp):

Re: [edk2-devel] need help - edk2 build issue

2022-04-05 Thread Andrew Fish via groups.io
Sukumar, The LongJump.iii is just the nasm file after it has been post processed you should be able to look at it. If I look at mine I see. 44: rdsspq rax ... 49:incsspq rax Those are some funky x86 instructions maybe your nasm is too old? This should be the required version I

Re: [edk2-devel] CryptoPkg build broken using XCODE5 (Availability.h not found)

2022-03-29 Thread Andrew Fish via groups.io
Rebecca, I got it to compile by doing this diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf index cdeed0d073eb..72dbeb2795e8 100644 --- a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf +++

Re: [edk2-devel] [PATCH 3/3] Basetools: turn off gcc12 warning

2022-03-29 Thread Andrew Fish via groups.io
> On Mar 29, 2022, at 2:38 PM, Andrew Fish via groups.io > wrote: > > > >> On Mar 29, 2022, at 11:14 AM, gr...@grantlmul.xyz >> <mailto:gr...@grantlmul.xyz> wrote: >> >> While I can't test this myself, the following does appear to result i

Re: [edk2-devel] [PATCH 3/3] Basetools: turn off gcc12 warning

2022-03-29 Thread Andrew Fish via groups.io
> On Mar 29, 2022, at 11:14 AM, gr...@grantlmul.xyz wrote: > > While I can't test this myself, the following does appear to result in a > successful build using the same clang version: > > > diff --git a/BaseTools/Source/C/DevicePath/GNUmakefile > b/BaseTools/Source/C/DevicePath/GNUmakefile

Re: [edk2-devel] Question about UEFI, AddressSanitizer and MMU mappings

2022-03-25 Thread Andrew Fish via groups.io
>From an UEFI point of view if you own the memory you can do what you want with >it. The UEFI Spec does not deal with paging but the PI Spec does have >abstractions for how the CPU operates via the CPU ARCH Protocol [1]. So for example if you want to write protect the page tables, add guard

Re: [edk2-devel] Debugging scripts: "Add support for gdb and lldb"

2022-03-15 Thread Andrew Fish via groups.io
Rebecca, That would be awesome. I’m happy to help, and answer questions. I’ve been kind of swamped in my day job lately so this would really help. Thanks, Andrew Fish > On Mar 15, 2022, at 8:48 PM, Rebecca Cran wrote: > > Given the lack of progress on this for many months, I was

[edk2-devel] Unit Test and sanitizers

2022-02-23 Thread Andrew Fish via groups.io
Just throwing out an idea for the edk2 unit tests. At least for clang you can turn on the sanitizer via a simple command line flag to the compiler. So seems it would make sense to turn on it for unit tests? I’m not sure if the Linux clang, and maybe even some versions of gcc support this too?

Re: [edk2-devel] PcdDebugPropertyMask in DSC: How to I set different values for PEI and DXE?

2022-02-17 Thread Andrew Fish via groups.io
it probably makes more sense to have PEI, DXE, and SMM. RT would also > make sense to have different settings. I have mixed feelings about BDS. I > think it makes sense to see it as a potentially independent phase that isn't > currently. But also probably won't ever be independent from

  1   2   3   4   5   >