[edk2-devel] [RFC] BZ 2067 BaseTools/Scripts: Add GetUtcDateTime.py for edk2-stable201908 stable tag.

2019-08-12 Thread Chiu, Chasel
Hello, I would like to add below simple script to 201908 stable tag, review was sent on August 8th: A script that can return UTC date and time in ascii format which is convenient for patching build time information in any binary. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2067

Re: [edk2-devel][edk2-platfoms][PATCH v2 06/22] Platform/CoreDxeInclude.dsc: Add ResetUtilityLib to dsc file

2019-08-11 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Gao, Zhichao > Sent: Monday, August 12, 2019 11:05 AM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Leif Lindholm > ; Kinney, Michael D ; > Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L &g

Re: [edk2-devel] [edk2-platforms][PATCH V1 02/37] CoffeelakeSiliconPkg/Cpu: Add Include headers

2019-08-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, August 17, 2019 8:15 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming ; > Kinney, Michael D ; Sinha, A

Re: [edk2-devel] [edk2-platforms][PATCH V1 01/37] CoffeelakeSiliconPkg: Add package and Include headers

2019-08-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, August 17, 2019 8:15 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming ; > Kinney, Michael D ; Sinha, A

Re: [edk2-devel] [edk2-platforms][PATCH V1 05/37] CoffeelakeSiliconPkg/Pch: Add ConfigBlock headers

2019-08-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, August 17, 2019 8:16 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming ; > Kinney, Michael D ; Sinha, A

Re: [edk2-devel] [edk2-platforms][PATCH V1 07/37] CoffeelakeSiliconPkg/Pch: Add PPI and Protocol include headers

2019-08-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, August 17, 2019 8:16 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming ; > Kinney, Michael D ; Sinha, A

Re: [edk2-devel] [edk2-platforms][PATCH V1 04/37] CoffeelakeSiliconPkg/Pch: Add include headers

2019-08-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, August 17, 2019 8:16 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming ; > Kinney, Michael D ; Sinha, A

Re: [edk2-devel] [edk2-platforms][PATCH V1 03/37] CoffeelakeSiliconPkg/Me: Add Include headers

2019-08-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, August 17, 2019 8:15 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming ; > Kinney, Michael D ; Sinha, A

Re: [edk2-devel] [edk2-platforms][PATCH V1 10/37] CoffeelakeSiliconPkg/Pch: Add Private/Library include headers

2019-08-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, August 17, 2019 8:16 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming ; > Kinney, Michael D ; Sinha, A

Re: [edk2-devel] [edk2-platforms][PATCH V1 06/37] CoffeelakeSiliconPkg/Pch: Add Library include headers

2019-08-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, August 17, 2019 8:16 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming ; > Kinney, Michael D ; Sinha, A

Re: [edk2-devel] [edk2-platforms][PATCH V1 11/37] CoffeelakeSiliconPkg/Pch: Add Private/Protocol include headers

2019-08-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, August 17, 2019 8:16 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming ; > Kinney, Michael D ; Sinha, A

Re: [edk2-devel] [edk2-non-osi][PATCH V2 2/2] edk2-non-osi: Add CoffeelakeSiliconBinPkg maintainers

2019-08-14 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Kubacki, Michael A > Sent: Thursday, August 15, 2019 12:15 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ;

Re: [edk2-devel] [PATCH v2] BaseTools/Scripts: Add GetUtcDateTime script.

2019-08-14 Thread Chiu, Chasel
V2 re-wrote the script to use ArgumentParser and remove sys.exit(). Regards, Chasel > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Chiu, Chasel > Sent: Wednesday, August 14, 2019 6:21 PM > To: devel@edk2.groups.io > Cc:

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] Platform/Intel/Readme.md: Content update

2019-08-19 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Kubacki, Michael A > Sent: Tuesday, August 20, 2019 10:03 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; G

Re: [edk2-devel] [edk2-platforms: PATCH v2] Python run fail if env variable PYTHON_HOME is not set

2019-08-19 Thread Chiu, Chasel
Pushed: https://github.com/tianocore/edk2-platforms/commit/05e9ca3abfcf89795d90e31415bac28a9f350299 > -Original Message- > From: Cheng, Ching JenX > Sent: Monday, August 19, 2019 5:24 PM > To: devel@edk2.groups.io > Cc: Chan, Amy ; Kubacki, Michael A > ; Chiu, C

Re: [edk2-devel] [PATCH] Python run fail if env variable PYTHON_HOME is not set

2019-08-19 Thread Chiu, Chasel
l@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Cheng, Ching JenX > Sent: Monday, August 19, 2019 3:21 PM > To: devel@edk2.groups.io > Cc: Chan, Amy ; Kubacki, Michael A > ; Chiu, Chasel ; > Desimone, Nathaniel L ; Gao, Liming > > Subject: [edk2-devel] [PATCH] Pyt

Re: [edk2-devel] [PATCH v2] BaseTools/Scripts: Add GetUtcDateTime script.

2019-08-14 Thread Chiu, Chasel
@edk2.groups.io; Chiu, Chasel > Cc: Feng, Bob C ; Gao, Liming ; > Leif Lindholm > Subject: Re: [edk2-devel] [PATCH v2] BaseTools/Scripts: Add GetUtcDateTime > script. > > On 2019-08-14 04:21, Chiu, Chasel wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2067 &g

Re: [edk2-devel] [edk2-platforms] [PATCH v2] Platform/Intel: Update Readme.md to point to edk2-non-osi master branch

2019-08-11 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Desimone, Nathaniel L > Sent: Monday, August 12, 2019 7:45 AM > To: devel@edk2.groups.io > Cc: Andrew Fish ; Laszlo Ersek ; Leif > Lindholm ; Kinney, Michael D > ; Kubacki, Michael A > ; Sinha, Ankit ; C

Re: [edk2-devel] [edk2-platforms][PATCH V1 36/37] WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Add DSC and build files

2019-08-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, August 17, 2019 8:16 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Gao, Liming ; Desimone, > Nathaniel L ; Kinney, Michael D > ; Sinha,

Re: [edk2-devel] [edk2-platforms][PATCH V1 24/37] CoffeelakeSiliconPkg/Pch: Add SMM private library instances

2019-08-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, August 17, 2019 8:16 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming ; > Kinney, Michael D ; Sinha, A

Re: [edk2-devel] [edk2-platforms][PATCH V1 30/37] Maintainers.txt: Add CoffeelakeSiliconPkg maintainers

2019-08-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, August 17, 2019 8:16 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming ; > Kinney, Michael D > Subject

Re: [edk2-devel] [edk2-platforms][PATCH V1 12/37] CoffeelakeSiliconPkg/SampleCode: Add Include headers

2019-08-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, August 17, 2019 8:16 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming ; > Kinney, Michael D ; Sinha, A

Re: [edk2-devel] [edk2-platforms][PATCH V1 37/37] Add WhiskeylakeOpenBoardPkg to global build config and documentation

2019-08-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, August 17, 2019 8:16 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Gao, Liming ; Desimone, > Nathaniel L ; Kinney, Michael D > ; Sinha,

Re: [edk2-devel] [edk2-platforms][PATCH V1 15/37] CoffeelakeSiliconPkg/Cpu: Add library instances

2019-08-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, August 17, 2019 8:16 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming ; > Kinney, Michael D ; Sinha, A

Re: [edk2-devel] [edk2-platforms][PATCH V1 29/37] CoffeelakeSiliconPkg: Add package DSC files

2019-08-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, August 17, 2019 8:16 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming ; > Kinney, Michael D ; Sinha, A

Re: [edk2-devel] [edk2-platforms][PATCH V1 20/37] CoffeelakeSiliconPkg/Pch: Add SMM library instances

2019-08-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, August 17, 2019 8:16 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming ; > Kinney, Michael D ; Sinha, A

Re: [edk2-devel] [edk2-platforms][PATCH V1 32/37] WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Add headers

2019-08-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, August 17, 2019 8:16 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Gao, Liming ; Desimone, > Nathaniel L ; Kinney, Michael D > ; Sinha,

Re: [edk2-devel] [edk2-platforms][PATCH V1 21/37] CoffeelakeSiliconPkg/Pch: Add Base library instances

2019-08-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, August 17, 2019 8:16 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming ; > Kinney, Michael D ; Sinha, A

Re: [edk2-devel] [edk2-platforms][PATCH V1 17/37] CoffeelakeSiliconPkg/Pch: Add Base library instances

2019-08-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, August 17, 2019 8:16 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming ; > Kinney, Michael D ; Sinha, A

Re: [edk2-devel] [edk2-platforms][PATCH V1 22/37] CoffeelakeSiliconPkg/Pch: Add DXE private library instances

2019-08-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, August 17, 2019 8:16 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming ; > Kinney, Michael D ; Sinha, A

Re: [edk2-devel] [edk2-platforms][PATCH V1 09/37] CoffeelakeSiliconPkg/Pch: Add Private include headers

2019-08-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, August 17, 2019 8:16 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming ; > Kinney, Michael D ; Sinha, A

Re: [edk2-devel] [edk2-platforms][PATCH V1 16/37] CoffeelakeSiliconPkg/Me: Add library instances

2019-08-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, August 17, 2019 8:16 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming ; > Kinney, Michael D ; Sinha, A

Re: [edk2-devel] [edk2-platforms][PATCH V1 14/37] CoffeelakeSiliconPkg: Add package common library instances

2019-08-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, August 17, 2019 8:16 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming ; > Kinney, Michael D ; Sinha, A

Re: [edk2-devel] [edk2-platforms][PATCH V1 18/37] CoffeelakeSiliconPkg/Pch: Add DXE library instances

2019-08-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, August 17, 2019 8:16 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming ; > Kinney, Michael D ; Sinha, A

Re: [edk2-devel] [edk2-platforms: PATCH v2] Python run fail if env variable PYTHON_HOME is not set

2019-08-19 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Cheng, Ching JenX > Sent: Monday, August 19, 2019 5:24 PM > To: devel@edk2.groups.io > Cc: Chan, Amy ; Kubacki, Michael A > ; Chiu, Chasel ; > Desimone, Nathaniel L ; Gao, Liming > > Subject: [edk2-plat

Re: [edk2-devel] [edk2-platform PATCH 2/2] Platform/MinPlatformPkg: Add missing header files in INF files

2019-08-21 Thread Chiu, Chasel
Some of files touched by this patch still having old copyright year, please help to extend. With above update: Reviewed-by: Chasel Chiu > -Original Message- > From: Zhang, Shenglei > Sent: Wednesday, August 21, 2019 4:01 PM > To: devel@edk2.groups.io > Cc: Kubacki, M

Re: [edk2-devel] [PATCH] Intel/* clean up duplicated files in Edk2Platforms

2019-08-22 Thread Chiu, Chasel
> From: Chen, Marc W > Sent: Thursday, August 22, 2019 1:28 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Gao, Liming ; Desimone, > Nathaniel L ; Steele, Kelly > ; Gillispie, Thad ; Bu, > Daocheng ; Oram, Isaac W > > Subject: [PATCH] Intel/*

Re: [edk2-devel] [edk2-platforms][PATCH V3 1/2] CoffeelakeSiliconPkg: Fix GCC Build Failures

2019-08-26 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Tuesday, August 27, 2019 2:48 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Chaganty, Rangasai V > > Subject: [edk2-platforms][PATCH V3 1/2] CoffeelakeSiliconPkg: Fix

Re: [edk2-devel] [edk2-platforms][PATCH V3 2/2] WhiskeylakeOpenBoardPkg: Fix GCC Build Failures

2019-08-26 Thread Chiu, Chasel
Please see 3 questions below inline. (tagged by [chasel]) Thanks! Chasel > -Original Message- > From: Kubacki, Michael A > Sent: Tuesday, August 27, 2019 2:48 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Gao, Liming > Subject: [edk

Re: [edk2-devel] [edk2-platforms][PATCH V3 2/2] WhiskeylakeOpenBoardPkg: Fix GCC Build Failures

2019-08-27 Thread Chiu, Chasel
Sorry that I overlooked that the last part I questioned was just a cleanup. I'm ok with what you are going to do. Thanks for clarification! > -Original Message- > From: Desimone, Nathaniel L > Sent: Wednesday, August 28, 2019 6:54 AM > To: Kubacki, Michael A ; Chiu, Chas

Re: [edk2-devel] [PATCH] IntelFsp2Pkg/FspSecCore: Remove unneeded MdeModulePkg dependency

2019-08-27 Thread Chiu, Chasel
Same findings as Nate, with FspSecCoreT.inf copyright updated, Reviewed-by: Chasel Chiu > -Original Message- > From: Desimone, Nathaniel L > Sent: Wednesday, August 28, 2019 7:21 AM > To: Ni, Ray ; devel@edk2.groups.io > Cc: Chiu, Chasel ; Zeng, Star > S

Re: [edk2-devel] [edk2-platforms][PATCH V5 1/2] CoffeelakeSiliconPkg: Fix GCC Build Failures

2019-08-27 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Wednesday, August 28, 2019 12:17 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Chaganty, Rangasai V > > Subject: [edk2-platforms][PATCH V5 1/2] CoffeelakeSiliconPkg: Fix

Re: [edk2-devel] [edk2-platforms][PATCH V5 2/2] WhiskeylakeOpenBoardPkg: Fix GCC Build Failures

2019-08-27 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Wednesday, August 28, 2019 12:17 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Gao, Liming > Subject: [edk2-platforms][PATCH V5 2/2] WhiskeylakeOpenBoar

Re: [edk2-devel] [edk2-platforms] ClevoOpenBoardPkg: Update board gpios

2019-08-30 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Agyeman, Prince > Sent: Friday, August 30, 2019 9:12 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Wei, David Y > ; Kubacki, Michael A ; > Desimone, Nathaniel L ; Chiu, Chasel > > Subject: [edk2-p

Re: [edk2-devel] [PATCH] CoffeelakeSiliconPkg: Add a needed ZeroMem ()

2019-08-30 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Friday, August 30, 2019 7:16 AM > To: devel@edk2.groups.io; Desimone, Nathaniel L > > Cc: Chiu, Chasel ; Chaganty, Rangasai V > > Subject: RE: [edk2-devel] [PATCH] Coffeelake

Re: [edk2-devel] [edk2-platforms][PATCH V2 1/6] MinPlatformPkg: Clean up duplicated SmramMemoryReserve.h files

2019-09-03 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Chen, Marc W > Sent: Monday, September 2, 2019 11:36 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming > Subject: [edk2-platforms][PATCH V2 1/6]

Re: [edk2-devel] [edk2-platforms][PATCH V2 4/6] KabylakeSiliconPkg: Clean up duplicated SmramMemoryReserve.h files

2019-09-03 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Chen, Marc W > Sent: Monday, September 2, 2019 11:36 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > ; Chaganty, Rangasai V > ; Desimone, Nathaniel L > > Subject: [e

Re: [edk2-devel] [edk2-platforms][PATCH V2 3/6] CoffeelakeSiliconPkg: Clean up duplicated SmramMemoryReserve.h files

2019-09-03 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Chen, Marc W > Sent: Monday, September 2, 2019 11:36 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > ; Chaganty, Rangasai V > ; Desimone, Nathaniel L > > Subject: [e

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] MinPlatformPkg/MultiBoardInitSupportLib: Fix NULL pointer dereferences

2019-08-26 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Kubacki, Michael A > Sent: Saturday, August 24, 2019 7:24 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Gao, Lim

Re: [edk2-devel] [edk2-platforms][PATCH V2 1/2] CoffeelakeSiliconPkg: Fix GCC Build Failures

2019-08-26 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, August 24, 2019 5:23 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Chaganty, Rangasai V > > Subject: [edk2-platforms][PATCH V2 1/2] CoffeelakeSiliconPkg: Fix

Re: [edk2-devel] [PATCH 1/2] MinPlatformPkg/AcpiTables: Initialize variables before used

2019-09-02 Thread Chiu, Chasel
Please extend copyright. With this update, Reviewed-by: Chasel Chiu > -Original Message- > From: Zhang, Shenglei > Sent: Monday, September 2, 2019 8:30 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming

Re: [edk2-devel] [PATCH 2/2] MinPlatformPkg/AcpiTables: Add error handling to SortCpuLocalApicInTable

2019-09-02 Thread Chiu, Chasel
Same with 1/2 patch, please extend copyright. With above update, Reviewed-by: Chasel Chiu > -Original Message- > From: Zhang, Shenglei > Sent: Monday, September 2, 2019 8:30 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel

Re: [edk2-devel] [PATCH] MinPlatformPkg/TestPointCheckLib: Add check for pointers

2019-09-02 Thread Chiu, Chasel
Please extend copyright for files you touched, and one more update in below inline. > -Original Message- > From: Zhang, Shenglei > Sent: Monday, September 2, 2019 8:35 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel

Re: [edk2-devel] [PATCH] MinPlatformPkg/TestPointCheckLib: Add check for pointer Variable

2019-09-02 Thread Chiu, Chasel
Please extend copyright, with this update Reviewed-by: Chasel Chiu > -Original Message- > From: Zhang, Shenglei > Sent: Monday, September 2, 2019 8:35 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Limi

Re: [edk2-devel] [edk2-platforms] [PATCH v2 1/1] MinPlatformPkg/Acpi: MADT NMI default flag set to Edge-Triggered

2019-09-02 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Sinha, Ankit > Sent: Saturday, August 31, 2019 6:28 AM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming > Subject: [edk2-platforms] [PATCH v2

Re: [edk2-devel] [PATCH] MinPlatformPkg/TestPointCheckLib: Add return value when OutTable is NULL

2019-09-02 Thread Chiu, Chasel
Extend copyright and please follow the coding style: if () { ... } else { ... } > -Original Message- > From: Zhang, Shenglei > Sent: Monday, September 2, 2019 8:35 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > ; G

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/2] KabylakeOpenBoardPkg: Fix GCC Build Failures

2019-08-22 Thread Chiu, Chasel
2019 1:40 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Gao, Liming > Subject: [edk2-devel] [edk2-platforms][PATCH V1 1/2] KabylakeOpenBoardPkg: > Fix GCC Build Failures > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2109 > > Fixes build

Re: [edk2-devel] [edk2-platforms PATCH 3/4] Platform/MinPlatformPkg.dsc: Add build option

2019-08-22 Thread Chiu, Chasel
To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming ; > Zhang, Shenglei > Subject: [edk2-devel] [edk2-platforms PATCH 3/4] > Platform/MinPlatformPkg.dsc: Add build option > > Add the build option "/D DISABLE_NEW_

Re: [edk2-devel] [edk2-platforms][PATCH V2 1/2] KabylakeOpenBoardPkg: Fix GCC Build Failures

2019-08-23 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Friday, August 23, 2019 2:17 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Gao, Liming > Subject: [edk2-platforms][PATCH V2 1/2] KabylakeOpenBoar

[edk2-devel] [PATCH] UefiCpuPkg: support single EFI_PEI_CORE_FV_LOCATION_PPI in PpiList

2019-09-04 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2153 Current logic will skip searching EFI_PEI_CORE_FV_LOCATION_PPI when the PPI in PpiList having EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST flag, but platform may pass single PPI in PpiList that should be supported. Changed the logic to verify

Re: [edk2-devel] [PATCH v2] UefiCpuPkg: support single EFI_PEI_CORE_FV_LOCATION_PPI in PpiList

2019-09-05 Thread Chiu, Chasel
Thanks Laszlo! Pushed: 8a1305a11f3bda2d6c1ab758e4aea79ee021dd1c > -Original Message- > From: Laszlo Ersek > Sent: Thursday, September 5, 2019 9:16 PM > To: Ni, Ray ; Dong, Eric ; Chiu, > Chasel ; devel@edk2.groups.io > Subject: Re: [PATCH v2] UefiCpuP

Re: [edk2-devel] [edk2-platforms] [PATCH] ClevoOpenBoardPkg: Fix GCC5 build issue

2019-09-04 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Agyeman, > Prince > Sent: Wednesday, September 4, 2019 2:18 AM > To: devel@edk2.groups.io > Cc: Agyeman, Prince ; Sinha, Ankit > ; Desimone, Nathaniel L > ; Kubacki, Michael

Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg: Remove unneeded MdeModulePkg dependency

2019-09-04 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Wednesday, September 4, 2019 2:18 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [edk2-devel] [PATCH

Re: [edk2-devel] [PATCH] MinPlatformPkg/SecFspWrapperPlatformSecLib: Change TopOfTemporaryRam type

2019-09-04 Thread Chiu, Chasel
2, 2019 8:35 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming > Subject: [edk2-devel] [PATCH] MinPlatformPkg/SecFspWrapperPlatformSecLib: > Change TopOfTemporaryRam type > > Cast TopOfTemporaryRam's fr

Re: [edk2-devel] [PATCH] UefiCpuPkg: support single EFI_PEI_CORE_FV_LOCATION_PPI in PpiList

2019-09-04 Thread Chiu, Chasel
> -Original Message- > From: Ni, Ray > Sent: Thursday, September 5, 2019 2:04 AM > To: devel@edk2.groups.io; Chiu, Chasel > Cc: Dong, Eric ; Laszlo Ersek > Subject: RE: [edk2-devel] [PATCH] UefiCpuPkg: support single > EFI_PEI_CORE_FV_LOCATION_PPI in PpiList

Re: [edk2-devel] [PATCH] MinPlatformPkg/SecFspWrapperPlatformSecLib: Change TopOfTemporaryRam type

2019-09-04 Thread Chiu, Chasel
age- > From: Zhang, Shenglei > Sent: Thursday, September 5, 2019 10:11 AM > To: Chiu, Chasel ; devel@edk2.groups.io > Cc: Kubacki, Michael A ; Desimone, Nathaniel > L ; Gao, Liming > Subject: RE: [edk2-devel] [PATCH] > MinPlatformPkg/SecFspWrapperPlatformSecLib: Change > Top

[edk2-devel] [edk2-platforms: PATCH] KabylakeOpenBoardPkg: Missed 64KB Temporary RAM in Dispatch mode.

2019-09-06 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2159 FSP Dispatch mode will share same stack and heap with bootloader so we should not reserve separate temporary ram for FSP. Set PcdFspTemporaryRamSize to 0 in Dispatch mode. Test: internal platform can boot with FSP Dispatch mode with

Re: [edk2-devel] [edk2-platforms] [PATCH v3 1/1] MinPlatformPkg/Acpi: MADT NMI default flag set to Edge-Triggered

2019-09-04 Thread Chiu, Chasel
I do not see change on top of V2, why we need V3? Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Sinha, > Ankit > Sent: Thursday, September 5, 2019 6:18 AM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, C

Re: [edk2-devel] [edk2-platforms] [PATCH v2] ClevoOpenBoardPkg: Fix GCC5 build issue

2019-09-04 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Agyeman, Prince > Sent: Wednesday, September 4, 2019 11:48 PM > To: devel@edk2.groups.io > Cc: Agyeman, Prince ; Sinha, Ankit > ; Desimone, Nathaniel L > ; Kubacki, Michael A > ; Chiu, Chasel ; Bi, &g

[edk2-devel] [PATCH v2] UefiCpuPkg: support single EFI_PEI_CORE_FV_LOCATION_PPI in PpiList

2019-09-04 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2153 Current logic will skip searching EFI_PEI_CORE_FV_LOCATION_PPI when the PPI in PpiList having EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST flag, but platform may pass single PPI in PpiList that should be supported. Changed the logic to verify

Re: [edk2-devel] [PATCH v2 2/2] MinPlatformPkg/AcpiTables: Add error handling to SortCpuLocalApicInTable

2019-09-11 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Zhang, Shenglei > Sent: Thursday, September 12, 2019 11:27 AM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming > Subject: [PATCH v2 2/2] MinPla

Re: [edk2-devel] [PATCH v2 1/2] MinPlatformPkg/AcpiTables: Initialize variables before used

2019-09-11 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Zhang, Shenglei > Sent: Thursday, September 12, 2019 11:27 AM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming > Subject: [PATCH v2 1/2] M

Re: [edk2-devel] [PATCH v4] MinPlatformPkg/TestPointCheckLib: Add check for pointers

2019-09-18 Thread Chiu, Chasel
ber 18, 2019 2:34 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming > Subject: [edk2-devel] [PATCH v4] MinPlatformPkg/TestPointCheckLib: Add > check for pointers > > In DxeCheckBootVariable.c, add check for

Re: [edk2-devel] [edk2-platforms][PATCH V2 1/1] Platform/Intel/Readme.md: Content update

2019-09-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Kubacki, > Michael A > Sent: Saturday, September 14, 2019 10:09 AM > To: devel@edk2.groups.io > Cc: Agyeman, Prince ; Bi, Dandan > ; Chaganty, Rangasai V > ; Chiu, Chasel ;

Re: [edk2-devel] [PATCH v2] MinPlatformPkg/TestPointCheckLib: Add return value when OutTable is NULL

2019-09-15 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Zhang, Shenglei > Sent: Monday, September 16, 2019 9:09 AM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming > Subject: [PATCH v2] MinPlatformPk

Re: [edk2-devel] [PATCH v2] MinPlatformPkg/SecFspWrapperPlatformSecLib: Change TopOfTemporaryRam type

2019-09-05 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Zhang, Shenglei > Sent: Thursday, September 5, 2019 2:20 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming > Subject: [

Re: [edk2-devel] [edk2-platforms PATCH v5] MinPlatformPkg/TestPointCheckLib: Add check for pointers

2019-09-19 Thread Chiu, Chasel
gt; Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming > Subject: [edk2-platforms PATCH v5] MinPlatformPkg/TestPointCheckLib: Add > check for pointers > > In DxeCheckBootVariable.c, add check for BootOrder and Variable that > return EFI_NOT_FOUND wh

Re: [edk2-devel] [edk2-platforms][PATCH V1 2/2] KabylakeOpenBoardPkg: Fix duplicate GUID in DSC

2019-08-07 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Thursday, August 8, 2019 5:15 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Gao, Liming > Subject: [edk2-platforms][PATCH V1 2/2] KabylakeOpenBoardPkg:

Re: [edk2-devel] [PATCH 3/3] IntelFsp2Pkg/FspSecCore: Add missing header file in INF file

2019-08-08 Thread Chiu, Chasel
Please extend copyright to 2019 of this file. With above change Reviewed-by: Chasel Chiu > -Original Message- > From: Zhang, Shenglei > Sent: Thursday, August 8, 2019 2:25 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star >

Re: [edk2-devel] [PATCH] * IntelFsp2Pkg: Improve FSP Python scripts to support 3.x.

2019-08-01 Thread Chiu, Chasel
Please help to update the commit message to explain a little more about what you are fixing. Thanks! Chasel > -Original Message- > From: Cheng, Ching JenX > Sent: Thursday, August 1, 2019 3:02 PM > To: devel@edk2.groups.io > Cc: Chan, Amy ; Chiu, Chasel ; > Des

Re: [edk2-devel] [PATCH v2] * IntelFsp2Pkg: Improve FSP Python scripts to support 3.x.

2019-08-02 Thread Chiu, Chasel
Patch submitted: 5e4ebd9ea5d72c1a2824d23a5dc92c7b50694719 Thanks! Chasel > -Original Message- > From: Cheng, Ching JenX > Sent: Thursday, August 1, 2019 6:07 PM > To: devel@edk2.groups.io > Cc: Chan, Amy ; Chiu, Chasel ; > Desimone, Nathaniel L ; Zeng, Star >

Re: [edk2-devel] [PATCH v2] * IntelFsp2Pkg: Improve FSP Python scripts to support 3.x.

2019-08-02 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Cheng, Ching JenX > Sent: Thursday, August 1, 2019 6:07 PM > To: devel@edk2.groups.io > Cc: Chan, Amy ; Chiu, Chasel ; > Desimone, Nathaniel L ; Zeng, Star > > Subject: [PATCH v2] * IntelFsp2Pkg: Im

Re: [edk2-devel] [edk2-platforms] [PATCH] ClevoOpenBoardPkg: Add display support

2019-07-28 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Agyeman, Prince > Sent: Friday, July 26, 2019 11:40 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Sinha, Ankit ; > Desimone, Nathaniel L ; Kubacki, Michael A > ; Chiu, Chasel ; > Agyeman, Prince &g

[edk2-devel] [PATCH 1/4] MinPlatformPkg: Auto configure Fsp*BaseAddress PCD

2019-07-29 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1863 Add python script which will rebase FSP binary without patching platform DSC for Fsp*BaseAddress PCDs. Those base address PCD will be updated in FDF basing on flash map. Cc: Michael Kubacki Cc: Nate DeSimone Cc: Liming Gao

[edk2-devel] [PATCH 4/4] ClevoOpenBoardPkg: Auto configure Fsp*BaseAddress PCD

2019-07-29 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1863 PcdFsp*BaseAddress now will be updated in FDF basing on flash map. DSC will only define types of those PCDs and always having 0 as default. Test: interanl platform booted with this patch. Cc: Michael Kubacki Cc: Ankit Sinha Cc: Nate

[edk2-devel] [PATCH 2/4] Platform/Intel: Auto configure Fsp*BaseAddress PCD

2019-07-29 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1863 Consume RebaseFspBinBaseAddress.py which will only rebase FSP binary without patching platform DSC. Cc: Michael Kubacki Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Chasel Chiu --- Platform/Intel/build_bios.py | 7 ++- 1 file

[edk2-devel] [PATCH 0/4] Auto configure Fsp*BaseAddress PCD

2019-07-29 Thread Chiu, Chasel
booted with this patch. Cc: Michael Kubacki Cc: Ankit Sinha Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Chasel Chiu Chasel Chiu (4): MinPlatformPkg: Auto configure Fsp*BaseAddress PCD Platform/Intel: Auto configure Fsp*BaseAddress PCD KabylakeOpenBoardPkg: Auto configure Fsp*BaseAddress

[edk2-devel] [PATCH 3/4] KabylakeOpenBoardPkg: Auto configure Fsp*BaseAddress PCD

2019-07-29 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1863 PcdFsp*BaseAddress now will be updated in FDF basing on flash map. DSC will only define types of those PCDs and always having 0 as default. Test: interanl platform booted with this patch. Cc: Michael Kubacki Cc: Nate DeSimone Cc: Liming

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] MinPlatformPkg: Fix duplicate GUID

2019-08-08 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Kubacki, Michael A > Sent: Wednesday, August 7, 2019 4:34 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Gao, Lim

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/2] ClevoOpenBoardPkg: Fix duplicate GUID in DSC

2019-08-08 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Kubacki, Michael A > Sent: Thursday, August 8, 2019 5:15 AM > To: devel@edk2.groups.io > Cc: Sinha, Ankit ; Desimone, Nathaniel L > ; Gao, Liming > Subject:

[edk2-devel] [PATCH] BaseTools/Scripts: Add GetUtcDateTimer script.

2019-08-08 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2067 A script that can return UTC date and time in ascii format which is convenient for patching build time information in any binary. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Chasel Chiu --- BaseTools/Scripts/GetUtcDateTime.py | 47

Re: [edk2-devel] [edk2-platforms] [PATCH v2] KabylakeSiliconPkg: Possible out-of-bounds memory writes

2019-07-18 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Nate > DeSimone > Sent: Thursday, July 18, 2019 2:49 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > ; Chaganty, Rangasai

Re: [edk2-devel] [edk2-platforms] [PATCH] KabylakeSiliconPkg: Possible out-of-bounds memory writes

2019-07-15 Thread Chiu, Chasel
Please extend copyright to 2019, with that change, Reviewed-by: Chasel Chiu > -Original Message- > From: Desimone, Nathaniel L > Sent: Tuesday, July 16, 2019 4:40 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > ; Chaganty, Rangasai V &

Re: [edk2-devel] [PATCH] ClevoOpenBoardPkg: Added NVMe boot support

2019-07-15 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Agyeman, Prince > Sent: Tuesday, July 16, 2019 6:24 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Sinha, Ankit ; > Kubacki, Michael A ; Desimone, Nathaniel L > ; Chiu, Chasel > Subject: [PATCH] Clevo

[edk2-devel] [PATCH] IntelFsp2Pkg: PeiService pointer not reset to 0 in SecMain

2019-07-25 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2018 Current FSP SEC_IDT_TABLE structure is not natural aligned: typedef struct _SEC_IDT_TABLE { EFI_PEI_SERVICES *PeiService; UINT64IdtTable[]; } SEC_IDT_TABLE; Compiler will insert DWORD padding between 2 elements and

Re: [edk2-devel] [edk2-non-osi] [PATCH 6/6] Cleanup maintainers, contributions, and licenses

2019-07-25 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Desimone, Nathaniel L > Sent: Friday, July 26, 2019 1:36 AM > To: devel@edk2.groups.io > Cc: Andrew Fish ; Laszlo Ersek ; Leif > Lindholm ; Kinney, Michael D > ; Kubacki, Michael A > ; Sinha, Ankit ; Chiu

Re: [edk2-devel] [PATCH v3] MdeModulePkg: Enable/Disable S3BootScript dynamically.

2019-09-30 Thread Chiu, Chasel
Change pushed: ed9db1b91ceba7d3a24743d4d9314c6fbe11c4b3 Thanks! Chasel > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chiu, > Chasel > Sent: Friday, September 27, 2019 3:51 PM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Dong, Eric ; > Desimo

[edk2-devel] [PATCH v3] MdeModulePkg: Enable/Disable S3BootScript dynamically.

2019-09-27 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2212 In binary model the same binary may have to support both S3 enabled and disabled scenarios, however not all DXE drivers linking PiDxeS3BootScriptLib can return error to invoke library DESTRUCTOR for releasing resource. To support this

Re: [edk2-devel] [PATCH v2] MdeModulePkg: Enable/Disable S3BootScript dynamically.

2019-09-27 Thread Chiu, Chasel
> -Original Message- > From: Laszlo Ersek > Sent: Thursday, September 26, 2019 9:58 PM > To: Chiu, Chasel ; devel@edk2.groups.io > Cc: Wu, Hao A ; Dong, Eric ; > Desimone, Nathaniel L ; Gao, Liming > > Subject: Re: [edk2-devel] [PATCH v2] MdeModulePkg: Enabl

Re: [edk2-devel] [edk2-platforms][PATCH V1 05/12] KabylakeOpenBoardPkg: Move EcCommands.h to KabylakeRvp3 board

2019-09-23 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Kubacki, > Michael A > Sent: Saturday, September 21, 2019 2:40 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Sinha, Ankit ; > Jeremy Soller

<    1   2   3   4   5   6   7   8   9   10   >