Re: [edk2-devel] [edk2] [EmulatorPkg] using __debugbreak()

Kilian: I think this idea is good. It can be enabled when the developer wants to do the source level debug. So, one PCD may be introduced to control the logic. By default, there is no change. When PCD is enabled, WinHost will wait for the developer input. Can you submit BZ for this request, an

Re: [edk2-devel] [edk2] NOOPT and PcdOptimizeCompilerEnable

NOOPT is build target. It includes the compiler option to disable optimization. If the platform supports NOOPT target, it can be built with -b NOOPT. PcdOptimizeCompilerEnable is one feature PCD defined in edk2-platforms. It can be used to control the compiler option in [BuildOptions] section. I

Re: [edk2-devel] [PATCH] MdePkg-UefiSpec.h: Add UEFI 2.8 new memory attributes

Qing: Thanks for your update. Reviewed-by: Liming Gao Thanks Liming >-Original Message- >From: Huang, Qing >Sent: Wednesday, October 30, 2019 12:55 PM >To: devel@edk2.groups.io >Cc: Gao, Liming >Subject: [PATCH] MdePkg-UefiSpec.h: Add UEFI 2.8 new memory attri

Re: [edk2-devel] [edk2] [EmulatorPkg] using __debugbreak()

Kilian: I normally modify the source code and insert CpuBreakpoint() function. That will trig VS debugger for the source code. Thanks Liming From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Kilian Kegel Sent: Monday, October 28, 2019 9:01 PM To: Gao, Liming Cc: devel@edk

Re: [edk2-devel] [PATCH] MdePkg-UefiSpec.h: Add UEFI 2.8 new memory attributes

; devel@edk2.groups.io >> Subject: RE: [PATCH] MdePkg-UefiSpec.h: Add UEFI 2.8 new memory >> attributes >> >> Reviewed-by: Liming Gao >> >> >-Original Message- >> >From: Huang, Qing >> >Sent: Thursday, October 24, 2019 10:34 A

Re: [edk2-devel] [PATCH] MdePkg-UefiSpec.h: Add UEFI 2.8 new memory attributes

Reviewed-by: Liming Gao >-Original Message- >From: Huang, Qing >Sent: Thursday, October 24, 2019 10:34 AM >To: devel@edk2.groups.io >Cc: Gao, Liming >Subject: [PATCH] MdePkg-UefiSpec.h: Add UEFI 2.8 new memory attributes > >BZ: https://bugzilla.tianocore.org/s

[edk2-devel] [Patch v5 10/11] EmulatorPkg: Enable CLANG9 tool chain

to generate windows HOST. 3. Fix WinHost issue to call GetProcessAffinityMask() API. The input parameter should be UINTN pointer instead of UINT32 pointer. Cc: Jordan Justen Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Liming Gao Reviewed-by: Ray Ni --- In v5, update commit message and fix

Re: [edk2-devel] [Patch] FmpDevicePkg: Fix spelling errors

Reviewed-by: Liming Gao >-Original Message- >From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com] >Sent: Tuesday, October 22, 2019 8:44 PM >To: devel@edk2.groups.io; Kinney, Michael D >Cc: Sean Brogan ; Gao, Liming > >Subject: Re: [edk2-devel] [Patch] FmpDe

[edk2-devel] [Patch 03/11] BaseTools GenFw: Fix the issue to update the wrong size as SectionSize

. Signed-off-by: Liming Gao Cc: Bob Feng Reviewed-by: Philippe Mathieu-Daude --- BaseTools/Source/C/GenFw/GenFw.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/BaseTools/Source/C/GenFw/GenFw.c b/BaseTools/Source/C/GenFw/GenFw.c index c99782b78e..8cab70ba4d 100644

[edk2-devel] [Patch 00/11] New Cross OS tool chain CLANG9

Cc: Jordan Justen Cc: Laszlo Ersek Cc: Andrew Fish Cc: Ray Ni Cc: Ard Biesheuvel Cc: Jian J Wang Cc: Hao A Wu Cc: Bob Feng Cc: Michael D Kinney Cc: Leif Lindholm Liming Gao (11): BaseTools tools_def.template: Remove unnecessary $(DEST_DIR_DEBUG) path BaseTools tools_def: Add CLANG9

[edk2-devel] [Patch 06/11] MdeModulePkg LzmaCustomDecompressLib: Update macro to be same in CLANG tool

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603 Define the same macro in the different OS. It can make CLANG generate the same image in the different host OS. Signed-off-by: Liming Gao Reviewed-by: Hao A Wu --- MdeModulePkg/Library/LzmaCustomDecompressLib/Sdk/C/7zTypes.h | 2 +- 1 file

[edk2-devel] [Patch 02/11] BaseTools tools_def: Add CLANG9 tool chain to directly generate PE image

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603 Signed-off-by: Liming Gao Cc: Bob Feng --- BaseTools/Conf/build_rule.template | 26 ++ BaseTools/Conf/tools_def.template | 102 + 2 files changed, 118 insertions(+), 10 deletions(-) diff

[edk2-devel] [Patch 04/11] MdePkg Base.h: Add definition for CLANG9 tool chain

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603 CLANG9 tool chain defines __clang__ macro only, doesn't define __GNUC__ macro. But, it uses some same definitions with GCC. So, update base definition for CLANG9 tool chain. Signed-off-by: Liming Gao Cc: Michael Kinney Review

[edk2-devel] [Patch 07/11] MdeModulePkg RegularExpressionDxe: Disable warning for CLANG9 tool chain

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603 Signed-off-by: Liming Gao Reviewed-by: Hao A Wu --- MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MdeModulePkg/Universal/RegularExpressionDxe

[edk2-devel] [Patch 05/11] MdePkg BaseIoLibIntrinsic: Remove __inline__ attribute for IO functions

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603 __inline__ has no functional difference effect with the GCC48 / GCC49 / GCC5 toolchains, but it breaks the build with CLANG9. Remove __inline__. Signed-off-by: Liming Gao Acked-by: Laszlo Ersek Cc: Michael Kinney Reviewed-by: Philippe

[edk2-devel] [Patch 08/11] CryptoPkg: Append options to make CLANG9 tool chain pass build

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603 Disable warning reported from CLANG9. Signed-off-by: Liming Gao Reviewed-by: Jian J Wang --- CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf| 1 + CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 1 + CryptoPkg/Library

[edk2-devel] [Patch 09/11] CryptoPkg IntrinsicLib: Make _fltused always be used

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603 With this change, global variable _fltused will not be removed by LTO Signed-off-by: Liming Gao Reviewed-by: Jian J Wang Reviewed-by: Philippe Mathieu-Daude --- CryptoPkg/Library/IntrinsicLib/MemoryIntrinsics.c | 10 -- 1 file

[edk2-devel] [Patch 01/11] BaseTools tools_def.template: Remove unnecessary $(DEST_DIR_DEBUG) path

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603 $(DEST_DIR_DEBUG) path is in Include directory. It is not required to be specified again. Signed-off-by: Liming Gao Reviewed-by: Bob Feng --- BaseTools/Conf/tools_def.template | 22 +++--- 1 file changed, 11 insertions

[edk2-devel] [Patch 11/11] OvmfPkg: Enable CLANG9 tool chain

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603 1. Apply CLANG9 Linker option. 2. Exclude -mno-mmx -mno-sse compiler option for CLANG9 These two options will cause CLANG Linker crush. Signed-off-by: Liming Gao Reviewed-by: Laszlo Ersek --- OvmfPkg/OvmfPkgIa32.dsc| 4 +++- OvmfPkg

[edk2-devel] [Patch 10/11] EmulatorPkg: Enable CLANG9 tool chain

generate windows HOST. 3. Fix WinHost issue to call GetProcessAffinityMask() API. The input parameter should be UINTN pointer instead of UINT32 pointer. Cc: Jordan Justen Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Liming Gao Reviewed-by: Ray Ni --- EmulatorPkg/Win/Host/WinHost.c | 6

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH V4] MdePkg/Protocols: New interface, EFI encodings to PCI Plat protocol

Ashraf: I have no comments for this patch on edk2-staging. Reviewed-by: Liming Gao Thanks Liming > -Original Message- > From: Javeed, Ashraf > Sent: Tuesday, October 22, 2019 11:06 AM > To: devel@edk2.groups.io; Javeed, Ashraf > Cc: Kinney, Michael D ; Gao, Limi

Re: [edk2-devel] [PATCH] CryptoPkg: Upgrade OpenSSL to 1.1.1d

Shenglei: Those header files are added as the missing header file @8906f076de35b222a7d62bcf6ed1a4a2498a5791. Please keep them in INF file. Thanks Liming > -Original Message- > From: devel@edk2.groups.io On Behalf Of Zhang, Shenglei > Sent: Monday, October 21, 2019 4:07 PM > To: dev

Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Add PCD to disable safe string constraint assertions

Include more people. Basically, to keep the compatible behavior, PcdAssertOnSafeStringConstraints default value should be TRUE. The different platform can configure it. Thanks Liming >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Vitaly Che

Re: [edk2-devel] [PATCH] MdePkg/UefiFileHandleLib: Fix potential NULL dereference

Reviewed-by: Liming Gao >-Original Message- >From: Marvin Häuser [mailto:marvin.haeu...@outlook.com] >Sent: Sunday, October 20, 2019 8:09 PM >To: devel@edk2.groups.io >Cc: vit9...@protonmail.com; Kinney, Michael D >; Gao, Liming >Subject: [PATCH] MdePkg/UefiFileHan

Re: [edk2-devel] [PATCH] MdePkg/UefiDebugLibStdErr: Pass the correct buffer size

Reviewed-by: Liming Gao >-Original Message- >From: Marvin Häuser [mailto:marvin.haeu...@outlook.com] >Sent: Monday, October 21, 2019 1:28 AM >To: devel@edk2.groups.io >Cc: vit9...@protonmail.com; Kinney, Michael D >; Gao, Liming >Subject: [PATCH] MdePkg/UefiDeb

Re: [edk2-devel] [PATCH] MdePkg/UefiDebugLibConOut: Pass the correct buffer size

Reviewed-by: Liming Gao >-Original Message- >From: Marvin Häuser [mailto:marvin.haeu...@outlook.com] >Sent: Sunday, October 20, 2019 8:09 PM >To: devel@edk2.groups.io >Cc: vit9...@protonmail.com; Kinney, Michael D >; Gao, Liming >Subject: [PATCH] MdePkg/UefiDeb

Re: [edk2-devel] [Patch] MdePkg: Add UefiFileHandleLib to DSC file

Reviewed-by: Liming Gao >-Original Message- >From: Kinney, Michael D >Sent: Saturday, October 19, 2019 4:38 AM >To: devel@edk2.groups.io >Cc: Sean Brogan ; Gao, Liming > >Subject: [Patch] MdePkg: Add UefiFileHandleLib to DSC file > >From: Sean Brogan > &

Re: [edk2-devel] [Patch v3 10/11] EmulatorPkg: Enable CLANG9 tool chain

nd LINK flags to generate windows HOST. 3. Fix WinHost issue to call GetProcessAffinityMask() API. The input parameter should be UINTN pointer instead of UINT32 pointer. Cc: Jordan Justen mailto:jordan.l.jus...@intel.com>> Cc: Andrew Fish mailto:af...@apple.com>> Cc: Ray Ni mailto:ray...

Re: [edk2-devel] [Patch v3 00/11] New Cross OS tool chain CLANG9

esheuvel ; Wang, Jian >J ; Wu, Hao A ; Feng, Bob C >; Kinney, Michael D >Subject: Re: [edk2-devel] [Patch v3 00/11] New Cross OS tool chain CLANG9 > >Hi Liming, > >I had missed that this set was out for review (I would appreciate a cc >on any future revisions). Yes. > &g

[edk2-devel] [Patch v3 09/11] CryptoPkg IntrinsicLib: Make _fltused always be used

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603 With this change, global variable _fltused will not be removed by LTO Signed-off-by: Liming Gao Reviewed-by: Jian J Wang Reviewed-by: Philippe Mathieu-Daude --- CryptoPkg/Library/IntrinsicLib/MemoryIntrinsics.c | 10 -- 1 file

[edk2-devel] [Patch v3 07/11] MdeModulePkg RegularExpressionDxe: Disable warning for CLANG9 tool chain

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603 Signed-off-by: Liming Gao Reviewed-by: Hao A Wu --- MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MdeModulePkg/Universal/RegularExpressionDxe

[edk2-devel] [Patch v3 11/11] OvmfPkg: Enable CLANG9 tool chain

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603 1. Apply CLANG9 Linker option. 2. Exclude -mno-mmx -mno-sse compiler option for CLANG9 These two options will cause CLANG Linker crush. Signed-off-by: Liming Gao Reviewed-by: Laszlo Ersek --- OvmfPkg/OvmfPkgIa32.dsc| 4 +++- OvmfPkg

[edk2-devel] [Patch v3 10/11] EmulatorPkg: Enable CLANG9 tool chain

generate windows HOST. 3. Fix WinHost issue to call GetProcessAffinityMask() API. The input parameter should be UINTN pointer instead of UINT32 pointer. Cc: Jordan Justen Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Liming Gao --- EmulatorPkg/Win/Host/WinHost.c | 6 +++--- EmulatorPkg

[edk2-devel] [Patch v3 00/11] New Cross OS tool chain CLANG9

inux OS. Cc: Jiewen Yao Cc: Steven Shi Cc: Jordan Justen Cc: Laszlo Ersek Cc: Andrew Fish Cc: Ray Ni Cc: Ard Biesheuvel Cc: Jian J Wang Cc: Hao A Wu Cc: Bob Feng Cc: Michael D Kinney Liming Gao (11): BaseTools tools_def.template: Remove unnecessary $(DEST_DIR_DEBUG) path BaseT

[edk2-devel] [Patch v3 08/11] CryptoPkg: Append options to make CLANG9 tool chain pass build

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603 Disable warning reported from CLANG9. Signed-off-by: Liming Gao Reviewed-by: Jian J Wang --- CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf| 1 + CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 1 + CryptoPkg/Library

[edk2-devel] [Patch v3 04/11] MdePkg Base.h: Add definition for CLANG9 tool chain

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603 CLANG9 tool chain defines __clang__ macro only, doesn't define __GNUC__ macro. But, it uses some same definitions with GCC. So, update base definition for CLANG9 tool chain. Signed-off-by: Liming Gao Cc: Michael Kinney Review

[edk2-devel] [Patch v3 06/11] MdeModulePkg LzmaCustomDecompressLib: Update macro to be same in CLANG tool

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603 Define the same macro in the different OS. It can make CLANG generate the same image in the different host OS. Signed-off-by: Liming Gao Reviewed-by: Hao A Wu --- MdeModulePkg/Library/LzmaCustomDecompressLib/Sdk/C/7zTypes.h | 2 +- 1 file

[edk2-devel] [Patch v3 02/11] BaseTools tools_def: Add CLANG9 tool chain to directly generate PE image

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603 Signed-off-by: Liming Gao Cc: Bob Feng --- BaseTools/Conf/build_rule.template | 26 ++ BaseTools/Conf/tools_def.template | 102 + 2 files changed, 118 insertions(+), 10 deletions(-) diff

[edk2-devel] [Patch v3 05/11] MdePkg BaseIoLibIntrinsic: Remove __inline__ attribute for IO functions

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603 __inline__ has no functional difference effect with the GCC48 / GCC49 / GCC5 toolchains, but it breaks the build with CLANG9. Remove __inline__. Signed-off-by: Liming Gao Acked-by: Laszlo Ersek Cc: Michael Kinney Reviewed-by: Philippe

[edk2-devel] [Patch v3 01/11] BaseTools tools_def.template: Remove unnecessary $(DEST_DIR_DEBUG) path

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603 $(DEST_DIR_DEBUG) path is in Include directory. It is not required to be specified again. Signed-off-by: Liming Gao Reviewed-by: Bob Feng --- BaseTools/Conf/tools_def.template | 22 +++--- 1 file changed, 11 insertions

[edk2-devel] [Patch v3 03/11] BaseTools GenFw: Fix the issue to update the wrong size as SectionSize

. Signed-off-by: Liming Gao Cc: Bob Feng Reviewed-by: Philippe Mathieu-Daude --- BaseTools/Source/C/GenFw/GenFw.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/BaseTools/Source/C/GenFw/GenFw.c b/BaseTools/Source/C/GenFw/GenFw.c index c99782b78e..8cab70ba4d 100644

Re: [edk2-devel] [PATCH v7 3/3] ShellPkg/UefiShellDebug1CommandsLib: Update to support SmBios 3.3.0

Push @b8fc5c03e5b5551b083f7efe91a051faa00c1e27..e797a806a8d090a09a782fe10ba2765154579d4b Please close BZ 2202. Thanks Liming >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Gao, Zhichao >Sent: Wednesday, October 16, 2019 8:45 AM >To: Abner Chang

Re: [edk2-devel] [Patch v2 10/11] EmulatorPkg: Enable CLANG9 tool chain

ing, >You missed the Cc tag so Andrew and I were not CCed. I CC you in the cover letter, not single patch. I will add you in next version. > >3 comments in below. > >> -Original Message- >> From: devel@edk2.groups.io On Behalf Of Liming >> Gao >> Sent:

Re: [edk2-devel] [Patch v2 03/11] BaseTools GenFw: Fix the issue to update the wrong size as SectionSize

nship between CLANG9 and this fix and why the original code is wrong. > >Thanks >Bob > >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Liming Gao >Sent: Tuesday, October 15, 2019 8:27 AM >To: devel@edk2.groups.io >S

Re: [edk2-devel] [Patch v2 00/11] New Cross OS tool chain CLANG9

and Linux OS. >Emulator can boot to Shell on Windows only with CLANG9. >OVMF Ia32X64 RELEASE build generates the same BIOS images on Windows >and Linux OS. > >Cc: Jiewen Yao >Cc: Steven Shi >Cc: Jordan Justen >Cc: Laszlo Ersek >Cc: Andrew Fish >Cc: Ray Ni >Cc:

[edk2-devel] [Patch] SecurityPkg Tcg2Dxe: Add Variable Arch protocol dependency

. Cc: Jiewen Yao Cc: Jian J Wang Cc: Chao Zhang Signed-off-by: Liming Gao --- SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf index c41c50a7a2..0127a31e97

Re: [edk2-devel] [Patch v2 00/11] New Cross OS tool chain CLANG9

Fish ; Ni, Ray ; Ard Biesheuvel >; Wang, Jian J ; Wu, Hao >A ; Feng, Bob C ; Kinney, >Michael D >Subject: Re: [edk2-devel] [Patch v2 00/11] New Cross OS tool chain CLANG9 > >On 10/15/19 02:26, Liming Gao wrote: >> In v2, drop patch 12, and update commit message for 5 & 1

Re: [edk2-devel] [PATCH V4 00/10] UEFI Variable SMI Reduction

eCachePendingUpdate flag is cleared > 3. Perform read from RuntimeCache > 4. Release RuntimeCacheReadLock > >Proposed FlushRuntimeCachePendingUpdate SMI >-------- > 1. If RuntimeCachePendingUpdate flag is not set: > 1.a. Return > 2. Co

[edk2-devel] [Patch v2 09/11] CryptoPkg IntrinsicLib: Make _fltused always be used

With this change, global variable _fltused will not be removed by LTO Signed-off-by: Liming Gao --- CryptoPkg/Library/IntrinsicLib/MemoryIntrinsics.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/CryptoPkg/Library/IntrinsicLib/MemoryIntrinsics.c b/CryptoPkg

[edk2-devel] [Patch v2 07/11] MdeModulePkg RegularExpressionDxe: Disable warning for CLANG9 tool chain

Signed-off-by: Liming Gao --- MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf

[edk2-devel] [Patch v2 03/11] BaseTools GenFw: Fix the issue to update the wrong size as SectionSize

Signed-off-by: Liming Gao --- BaseTools/Source/C/GenFw/GenFw.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/BaseTools/Source/C/GenFw/GenFw.c b/BaseTools/Source/C/GenFw/GenFw.c index c99782b78e..d8d3360c24 100644 --- a/BaseTools/Source/C/GenFw/GenFw.c +++ b

[edk2-devel] [Patch v2 11/11] OvmfPkg: Enable CLANG9 tool chain

1. Apply CLANG9 Linker option. 2. Exclude -mno-mmx -mno-sse compiler option for CLANG9 These two options will cause CLANG Linker crush. Signed-off-by: Liming Gao Reviewed-by: Laszlo Ersek --- OvmfPkg/OvmfPkgIa32.dsc| 4 +++- OvmfPkg/OvmfPkgIa32X64.dsc | 4 +++- OvmfPkg/OvmfPkgX64.dsc

[edk2-devel] [Patch v2 05/11] MdePkg BaseIoLibIntrinsic: Remove __inline__ attribute for IO functions

__inline__ has no functional difference effect with the GCC48 / GCC49 / GCC5 toolchains, but it breaks the build with CLANG9. Remove __inline__. Signed-off-by: Liming Gao Acked-by: Laszlo Ersek --- MdePkg/Library/BaseIoLibIntrinsic/IoLibGcc.c | 6 -- 1 file changed, 6 deletions(-) diff

[edk2-devel] [Patch v2 01/11] BaseTools tools_def.template: Remove unnecessary $(DEST_DIR_DEBUG) path

$(DEST_DIR_DEBUG) path is in Include directory. It is not required to be specified again. Signed-off-by: Liming Gao --- BaseTools/Conf/tools_def.template | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/BaseTools/Conf/tools_def.template b/BaseTools

[edk2-devel] [Patch v2 08/11] CryptoPkg: Append options to make CLANG9 tool chain pass build

Disable warning reported from CLANG9. Signed-off-by: Liming Gao --- CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf| 1 + CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 1 + CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf | 1 + CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf

[edk2-devel] [Patch v2 10/11] EmulatorPkg: Enable CLANG9 tool chain

1. Append CLANG CC and LINK flags to generate windows HOST. 2. Modify WinHost to move PCD getting in the late position Signed-off-by: Liming Gao --- EmulatorPkg/Win/Host/WinHost.c | 11 +++ EmulatorPkg/EmulatorPkg.dsc | 8 ++-- EmulatorPkg/EmulatorPkg.fdf | 2

[edk2-devel] [Patch v2 02/11] BaseTools tools_def: Add CLANG9 tool chain to directly generate PE image

Signed-off-by: Liming Gao --- BaseTools/Conf/build_rule.template | 26 ++ BaseTools/Conf/tools_def.template | 102 + 2 files changed, 118 insertions(+), 10 deletions(-) diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf

[edk2-devel] [Patch v2 06/11] MdeModulePkg LzmaCustomDecompressLib: Update macro to be same in CLANG tool

Define the same macro in the different OS. It can make CLANG generate the same image in the different host OS. Signed-off-by: Liming Gao --- MdeModulePkg/Library/LzmaCustomDecompressLib/Sdk/C/7zTypes.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Library

[edk2-devel] [Patch v2 00/11] New Cross OS tool chain CLANG9

Cc: Ard Biesheuvel Cc: Jian J Wang Cc: Hao A Wu Cc: Bob Feng Cc: Michael D Kinney Liming Gao (11): BaseTools tools_def.template: Remove unnecessary $(DEST_DIR_DEBUG) path BaseTools tools_def: Add CLANG9 tool chain to directly generate PE image BaseTools GenFw: Fix the issu

[edk2-devel] [Patch v2 04/11] MdePkg Base.h: Add definition for CLANG9 tool chain

CLANG9 tool chain defines __clang__ macro only, doesn't define __GNUC__ macro. But, it uses some same definitions with GCC. So, update base definition for CLANG9 tool chain. Signed-off-by: Liming Gao --- MdePkg/Include/Base.h | 6 +++--- MdePkg/Include/Ia32/ProcessorBind.

Re: [edk2-devel] [PATCH] Add support for FuSA ACM in FitGen tool

t;A new FIT entry type (FIT Type 0x3) has been allocated for FuSa ACM. >FitGen tool is updated to add support for this FuSa ACM. > >Cc: Bob Feng >Cc: Liming Gao > >Signed-off-by: Sachin Agrawal >--- > Silicon/Intel/Tools/FitGen/FitGen.c | 82 >+

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/BdsDxe: Fix calling PlatformBootManagerWaitCallback on 0

apple.com >Subject: Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/BdsDxe: Fix calling >PlatformBootManagerWaitCallback on 0 > >Hi Liming, > >On 10/12/19 03:44, Gao, Liming wrote: >> Reviewed-by: Liming Gao > >can you please add > > Ref: https://bugzilla.tianocore.org

Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain

Laszlo: >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Laszlo Ersek >Sent: Friday, October 11, 2019 5:37 PM >To: Gao, Liming >Cc: Andrew Fish ; devel@edk2.groups.io; Tom Lendacky > >Subject: Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9

Re: [edk2-devel] [RFC PATCH v2 38/44] UefiCpuPkg: Allow AP booting under SEV-ES

Andrew: Can you give more detail on how to update nasm source code to put the 64bit absolute address from .text section to .data section? I will verify it. Now, the patching way doesn't support X64 SEC/PEI. This is a gab in XCODE tool chain. Thanks Liming From: devel@edk2.groups.io [mailto:dev

Re: [edk2-devel] [Patch 05/12] MdePkg BaseIoLibIntrinsic: Remove __inline__ attribute for IO functions

or IO functions > >On 2019-10-10 09:32:19, Laszlo Ersek wrote: >> Hi Liming, Andrew, >> >> On 10/10/19 14:32, Liming Gao wrote: >> > Laszlo: >> > >> >> -Original Message- >> >> From: Laszlo Ersek >> >> Sent

Re: [edk2-devel] [Patch 1/1] BaseTools: Fix a bug of genffs command generation

ke command. Reviewed-by: Liming Gao Thanks Liming >-Original Message- >From: Feng, Bob C >Sent: Friday, September 27, 2019 10:30 AM >To: devel@edk2.groups.io >Cc: Gao, Liming ; Feng, Bob C >Subject: [Patch 1/1] BaseTools: Fix a bug of genffs command generation > >R

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/BdsDxe: Fix calling PlatformBootManagerWaitCallback on 0

Reviewed-by: Liming Gao >-Original Message- >From: Pete Batard [mailto:p...@akeo.ie] >Sent: Friday, October 11, 2019 11:44 PM >To: devel@edk2.groups.io >Cc: af...@apple.com; ler...@redhat.com; Gao, Liming >Subject: [PATCH 1/1] MdeModulePkg/B

Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain -

chain - > >Hi Liming, > >On 10/10/19 14:18, Liming Gao wrote: >>> -Original Message- >>> From: devel@edk2.groups.io On Behalf Of Laszlo >Ersek >>> Sent: Thursday, October 10, 2019 3:35 PM >>> To: Andrew Fish ; Gao, Liming >>> Cc:

Re: [edk2-devel] [Patch 12/12] OvmfPkg SecMain: Add build option "-fno-omit-frame-pointer" for CLANG9 X64

-frame-pointer" for CLANG9 X64 > >Hi Liming, > >On 10/10/19 16:08, Liming Gao wrote: >> Laszlo: >> Option (a) works. Jordan patch can fix this issue. >> Option (b) doesn't work. Even if disable optimization, CLANG doesn't >generate the code wit

Re: [edk2-devel] [Patch 05/12] MdePkg BaseIoLibIntrinsic: Remove __inline__ attribute for IO functions

oLibIntrinsic: Remove >__inline__ attribute for IO functions > >Hi Liming, Andrew, > >On 10/10/19 14:32, Liming Gao wrote: >> Laszlo: >> >>> -Original Message- >>> From: Laszlo Ersek >>> Sent: Wednesday, October 9, 2019 4:22 AM >>

Re: [edk2-devel] OVMF is crashing for me in master

Andrew: I verify the change (2de1f611be06ded3a59726a4052a9039be7d459b MdeModulePkg/BdsDxe: Also call PlatformBootManagerWaitCallback on 0) in Emulator. It works, because PCD value is set to 10 in Emulator. Before this change, if TimeOut PCD is zero, BdsEntry doesn't call PlatformBootManag

Re: [edk2-devel] [Patch 12/12] OvmfPkg SecMain: Add build option "-fno-omit-frame-pointer" for CLANG9 X64

is the block issue to add new CLANG9 tool chain. I will try to add CLANG9 tool chain patch without this change, and use BZ 2024 to track this issue. Thanks Liming > -Original Message- > From: devel@edk2.groups.io On Behalf Of Liming Gao > Sent: Tuesday, October 8, 2019 11:10 P

Re: [edk2-devel] [Patch 05/12] MdePkg BaseIoLibIntrinsic: Remove __inline__ attribute for IO functions

Laszlo: > -Original Message- > From: Laszlo Ersek > Sent: Wednesday, October 9, 2019 4:22 AM > To: Gao, Liming ; devel@edk2.groups.io; af...@apple.com > Subject: Re: [edk2-devel] [Patch 05/12] MdePkg BaseIoLibIntrinsic: Remove > __inline__ attribute for IO functions > > On 10/08/19 16:4

Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain -

> -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo Ersek > Sent: Thursday, October 10, 2019 3:35 PM > To: Andrew Fish ; Gao, Liming > Cc: devel@edk2.groups.io > Subject: Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain - > > Hi Andrew, > > On 10/09/

Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain

Laszlo: > -Original Message- > From: Laszlo Ersek > Sent: Wednesday, October 9, 2019 9:44 PM > To: Andrew Fish ; devel@edk2.groups.io > Cc: Gao, Liming > Subject: Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain > > On 10/09/19 01:08, Andrew Fish wrote: > > > So I guess

Re: [edk2-devel] [PATCH edk2-platforms 3/6] Maintainers.txt: revamp file to machine-readable format

t; Platform/Intel/Vlv2TbltDevicePkg > +F: Platform/Intel/Vlv2TbltDevicePkg/ > M: Zailiang Sun > M: Yi Qian > > Platform/Intel/AdvancedFeaturePkg > +F: Platform/Intel/AdvancedFeaturePkg/ > M: Michael Kubacki > M: Sai Chaganty > R: Liming Gao > &g

Re: [edk2-devel] Patch for Bug 2236 on Bugzilla

Kenji: Please use git format-patch -1 to generate the patch, then use git send-email xxx.patch to send this patch to devel@edk2.groups.io Besides, is there the track in edk2 https://bugzilla.tianocore.org/? If no, can you submit one? Thanks Liming From: devel@ed

Re: [edk2-devel] [Patch 12/12] OvmfPkg SecMain: Add build option "-fno-omit-frame-pointer" for CLANG9 X64

tion > "-fno-omit-frame-pointer" for CLANG9 X64 > > + Jordan > > On 09/27/19 09:46, Liming Gao wrote: > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2024 > > > > Signed-off-by: Liming Gao > > --- > > OvmfPkg/Sec/SecMain.inf | 4 +

Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain

Laszlo: > -Original Message- > From: Laszlo Ersek > Sent: Tuesday, October 1, 2019 4:42 AM > To: devel@edk2.groups.io; Gao, Liming > Subject: Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain > > Hi Liming, > > On 09/27/19 09:46, Liming Gao

Re: [edk2-devel] [Patch 05/12] MdePkg BaseIoLibIntrinsic: Remove __inline__ attribute for IO functions

, 2019, at 3:35 PM, Laszlo Ersek mailto:ler...@redhat.com>> wrote: Hi Liming, On 09/27/19 09:46, Liming Gao wrote: __inline__ attribute will make the functions not be exposed as the library interface. It will cause CLANG9 compiler fail. Signed-off-by: Liming Gao mailto:liming@int

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/BdsDxe: Also call PlatformBootManagerWaitCallback on 0

Push @2de1f611be06ded3a59726a4052a9039be7d459b > -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo Ersek > Sent: Tuesday, October 1, 2019 7:12 AM > To: devel@edk2.groups.io; Ni, Ray ; p...@akeo.ie > Cc: Gao, Zhichao > Subject: Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/B

Re: [edk2-devel] Problem with decompression on EDK2

BaseTools VolInfo tool. Its input is the binary FvImage file. In the same directory, GuidedSectionTools.txt (built in the FV directory) should be here. Thanks Liming > -Original Message- > From: Loh, Tien Hock > Sent: Tuesday, October 1, 2019 10:34 AM > To: Gao, Liming ; devel@edk2.grou

Re: [edk2-devel] [PATCH v2] MdePkg:Include: Update SmBios header file

are a > prerequisite for the code destined to go in there. > > Best Regards, > > Leif > > On Tue, Oct 08, 2019 at 01:14:35AM +, Gao, Liming wrote: > > Abner: > > Thanks for your notice. I see the public SMBIOS 3.3.0. > > > > For this patch s

Re: [edk2-devel] [PATCH v5 0/3] Update to support SmBios 3.3.0

Reviewed-by: Liming Gao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Abner Chang > Sent: Tuesday, October 8, 2019 4:04 PM > To: devel@edk2.groups.io > Cc: abner.ch...@hpe.com > Subject: [edk2-devel] [PATCH v5 0/3] Update to support SmBios 3.3.0 >

Re: [edk2-devel] [PATCH v2] MdePkg:Include: Update SmBios header file

Abner: Thanks for your notice. I see the public SMBIOS 3.3.0. For this patch set, I have two minor comments. For other part, Reviewed-by: Liming Gao 1) Please add BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2202 in the commit message. 2) The comment for

[edk2-devel] Mike will be the back up maintainers for Edk2 packages when Chinese National Holiday (Oct.1 ~ Oct.7)

Hi, all Some Edk2 package maintainers are in China. We will take Chinese National Holiday (Oct.1 ~ Oct.7). In this period, Michael D Kinney will be the backup maintainers for those Edk2 packages. Thanks for Mike great support. Thanks Liming -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive a

Re: [edk2-devel] [PATCH 1/3] MdePkg/Include: correct Lasa in Tpm2Acpi.

Reviewed-by: Liming Gao >-Original Message- >From: Yao, Jiewen >Sent: Sunday, September 29, 2019 2:16 PM >To: devel@edk2.groups.io >Cc: Kinney, Michael D ; Gao, Liming > >Subject: [PATCH 1/3] MdePkg/Include: correct Lasa in Tpm2Acpi. > >Correct Lasa accord

Re: [edk2-devel] [PATCH] BaseTools/LzmaCompress: Fix the option "d" dictionary size

Reviewed-by: Liming Gao >-Original Message- >From: Zhang, Shenglei >Sent: Monday, September 30, 2019 11:52 AM >To: devel@edk2.groups.io >Cc: Feng, Bob C ; Gao, Liming >Subject: [PATCH] BaseTools/LzmaCompress: Fix the option "d" dictionary size > >The ra

Re: [edk2-devel] [PATCH v8 0/4] Add SCSI Support for Storage Security Command Protocol

I have no other comments. Reviewed-by: Liming Gao >-Original Message- >From: Wu, Hao A >Sent: Sunday, September 29, 2019 3:31 PM >To: devel@edk2.groups.io; Zurcher, Christopher J >; Gao, Liming >Cc: Kinney, Michael D ; Yao, Jiewen >; Wang, Jian J >Subject: RE:

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/BdsDxe: Also call PlatformBootManagerWaitCallback on 0

This change is good to me. I also verify it in Emulator platform. Reviewed-by: Liming Gao Thanks Liming >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Laszlo Ersek >Sent: Friday, September 27, 2019 3:30 AM >To: devel@ed

Re: [edk2-devel] Problem with decompression on EDK2

Tien Hock: The image is correct. It can be decompressed by lzma. When FD is loaded into 0x5, I suspect that the image data can't fully read. Then, the decompress will failure. FD image last valid byte offset is 0xC1B8F. Its value is 0x83. When FD base address is 0x5, this positio

Re: [edk2-devel] [Patch 09/12] CryptoPkg IntrinsicLib: Make _fltused always be used

sage? > >+#if defined(__GNUC__) || defined(__clang__) >+ #define GLOBAL_USED __attribute__((used)) >+#else >+ #define GLOBAL_USED >+#endif > >> -----Original Message- >> From: devel@edk2.groups.io On Behalf Of Liming >Gao >> Sent: Friday, Septembe

Re: [edk2-devel] [Patch 1/1] BaseTools: Fix the lib order in static_library_files.lst

Reviewed-by: Liming Gao >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Bob Feng >Sent: Friday, September 27, 2019 7:35 PM >To: devel@edk2.groups.io >Cc: Gao, Liming ; dann frazier >; Feng, Bob C >Subject: [edk2-deve

Re: [edk2-devel] [Patch 1/1] BaseTools: Fix a bug of genffs command generation

gt;It should be based on the OS type. > >Cc: Liming Gao >Signed-off-by: Bob Feng >--- > BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py >

Re: [edk2-devel] [PATCH V2] MdeModulePkg/TerminalDxe: Enhance the arrow keys support

keys would send ESC [A through to ESC [D. Add this >> support for the new introduced terminal type. >> >> Cc: Jian J Wang >> Cc: Hao A Wu >> Cc: Ray Ni >> Cc: Liming Gao >> Signed-off-by: Zhichao Gao >> --- >> .../Universal/Conso

[edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain

1. Apply CLANG9 Linker option. 2. Add -mno-mmx -mno-sse compiler option Signed-off-by: Liming Gao --- OvmfPkg/OvmfPkgIa32.dsc| 4 +++- OvmfPkg/OvmfPkgIa32X64.dsc | 4 +++- OvmfPkg/OvmfPkgX64.dsc | 4 +++- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/OvmfPkg/OvmfPkgIa32

[edk2-devel] [Patch 00/12] New Cross OS tool chain CLANG9

Cc: Michael D Kinney Liming Gao (12): BaseTools tools_def.template: Remove unnecessary $(DEST_DIR_DEBUG) path BaseTools tools_def: Add CLANG9 tool chain to directly generate PE image BaseTools GenFw: Fix the issue to update the wrong size as SectionSize MdePkg Base.h: Add

[edk2-devel] [Patch 02/12] BaseTools tools_def: Add CLANG9 tool chain to directly generate PE image

Signed-off-by: Liming Gao --- BaseTools/Conf/build_rule.template | 26 +-- BaseTools/Conf/tools_def.template | 102 + 2 files changed, 118 insertions(+), 10 deletions(-) diff --git a/BaseTools/Conf/build_rule.template b

[edk2-devel] [Patch 10/12] EmulatorPkg: Enable CLANG9 tool chain

1. Append CLANG CC and LINK flags to generate windows HOST. 2. Modify WinHost to move PCD getting in the late position Signed-off-by: Liming Gao --- EmulatorPkg/Win/Host/WinHost.c | 11 +++ EmulatorPkg/EmulatorPkg.dsc | 8 ++-- EmulatorPkg/EmulatorPkg.fdf | 2

[edk2-devel] [Patch 03/12] BaseTools GenFw: Fix the issue to update the wrong size as SectionSize

Signed-off-by: Liming Gao --- BaseTools/Source/C/GenFw/GenFw.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/BaseTools/Source/C/GenFw/GenFw.c b/BaseTools/Source/C/GenFw/GenFw.c index c99782b78e..d8d3360c24 100644 --- a/BaseTools/Source/C/GenFw/GenFw.c +++ b

<    2   3   4   5   6   7   8   9   10   11   >