Re: [edk2-devel] [PATCH v2] ArmVirtPkg: increase FD/FV size for NOOPT builds

On 9/12/19 7:13 PM, Ard Biesheuvel wrote: > On Thu, 12 Sep 2019 at 18:05, Philippe Mathieu-Daudé > wrote: >> >> On 9/12/19 6:50 PM, Ard Biesheuvel wrote: >>> On Thu, 12 Sep 2019 at 16:20, Philippe Mathieu-Daudé >>> wrote: >>>> >>>>

Re: [edk2-devel] [PATCH v2] ArmVirtPkg: increase FD/FV size for NOOPT builds

Hi Ard, On 9/11/19 6:23 PM, Ard Biesheuvel wrote: > After upgrading the CI system we use for building the ArmVirtPkg > targets, we started seeing failures due to the NOOPT build running > out of space when using the CLANG38 toolchain definition combined > with clang 7. > > We really don't want

Re: [edk2-devel] [edk2-platforms] [PATCH 0/3] Fix SimicsOpenBoardPkg GCC Build

Hi Prince, On 9/10/19 1:15 AM, Agyeman, Prince wrote: > This patch series fix gcc build issues seen > in SimicsOpenBoardPkg. > Patches were tested on GCC 5 > > Prince Agyeman (3): > AdvancedFeaturePkg: Fix GCC build > SimicsOpenBoardPkg: Fix GCC build issues > SimicsIch10Pkg: Fix GCC build

Re: [edk2-devel] [PATCH v3 1/1] MdePkg: Add STATIC_ASSERT macro

On 8/17/19 1:28 AM, Vitaly Cheptsov via Groups.Io wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2048 > > Provide a macro for compile time assertions. > Equivalent to C11 static_assert macro from assert.h. > > Signed-off-by: Vitaly Cheptsov > --- > MdePkg/Include/Base.h | 14

Re: [edk2-devel] [PATCH] ArmVirtPkg: increase FD/FV size for NOOPT builds

Hi Ard, On 9/7/19 12:20 AM, Ard Biesheuvel wrote: > After upgrading the CI system we use for building the ArmVirtPkg > targets, we started seeing failures due to the NOOPT build running > out of space when using the CLANG38 toolchain definition combined > with clang 7. > > We really don't want

Re: [edk2-devel] [PATCH edk2-CCSS 3/3] must comment: add rule for documenting spurious variable assignments

On 9/9/19 2:25 PM, Laszlo Ersek wrote: > On 09/06/19 10:13, Philippe Mathieu-Daudé wrote: >> Hi Laszlo, >> >> (Cc'ing Ard) >> >> On 9/5/19 8:38 PM, Laszlo Ersek wrote: >>> Problem statement from Ard: >>> >>>> Sometimes, the GCC com

Re: [edk2-devel] [PATCH edk2-CCSS 3/3] must comment: add rule for documenting spurious variable assignments

Hi Laszlo, (Cc'ing Ard) On 9/5/19 8:38 PM, Laszlo Ersek wrote: > Problem statement from Ard: > >> Sometimes, the GCC compiler warns about variables potentially being used >> without having been initialized, while visual inspection reveals that >> this is impossible. In such cases, we need to

Re: [edk2-devel] [PATCH edk2-CCSS 2/3] comments: restrict and clarify applicability of "/*" comments

On 9/5/19 8:38 PM, Laszlo Ersek wrote: > Section "6.2 Comments" seems to permit "/*" for multi-line comments in > general. That's incorrect; "/*" comments are permitted only for a subset > of multi-line comments (namely Doxygen-style file and function header > comment blocks). Update the rule

Re: [edk2-devel] [PATCH] ArmVirtPkg/PlatformBootManagerLib: unload image on EFI_SECURITY_VIOLATION

On 9/3/19 6:38 PM, Laszlo Ersek wrote: > The LoadImage() boot service is a bit unusual in that it allocates > resources in a particular failure case; namely, it produces a valid > "ImageHandle" when it returns EFI_SECURITY_VIOLATION. This is supposed to > happen e.g. when Secure Boot verification

Re: Microsoft imports - was Re: [edk2-devel] [PATCH V2] BaseTools:Add extra debugging message

On 8/2/19 11:55 AM, Leif Lindholm wrote: > So, I'm not going to give any of the reviewers a hard time about this > - the patch *looks* right and we've all occasionally given R-b on > things we haven't actually tested because we don't always have the > time. And by the time I hit it, it had already

Re: [edk2-devel] [Patch] BaseTools: Fixed a typo in Trim.py

On 8/1/19 3:23 PM, Bob Feng wrote: > This is a regression issue introduced > by commit 307e1650be267b67db7be1089e0979ace460d83 > > This patch is to fix this issue. > > Cc: Liming Gao > Signed-off-by: Bob Feng > --- > BaseTools/Source/Python/Trim/Trim.py | 2 +- > 1 file changed, 1

Re: [edk2-devel] [Patch 02/10 V5] BaseTools: Split WorkspaceAutoGen._InitWorker into multiple functions

On 7/31/19 7:52 AM, Bob Feng wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 > > The WorkspaceAutoGen.__InitWorker function is too long, it's hard > to read and understand. > This patch is to separate the __InitWorker into multiple small ones. > > Cc: Liming Gao >

Re: [edk2-devel] [PATCH 0/2] ArmPkg: DebugPeCoffExtraActionLib: debugger commands are not errors

idea, thanks. > > Reviewed-by: Leif Lindholm > Pushed as 8fed4e47d9a6..3d34b5f32692. Thanks Laszlo and Leif! > > Thanks! > >> Regards, >> >> Phil. >> >> Philippe Mathieu-Daudé (2): >> ArmPkg: DebugPeCoffExtraActionLib: debugger comm

Re: [edk2-devel] [Patch 02/11] BaseTools: Split WorkspaceAutoGen._InitWorker into multiple functions

anks, > Bob > > -Original Message- > From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com] > Sent: Monday, July 29, 2019 11:03 PM > To: devel@edk2.groups.io; Feng, Bob C > Cc: Gao, Liming > Subject: Re: [edk2-devel] [Patch 02/11] BaseTools: Split > Workspa

Re: [edk2-devel] [PATCH 1/3] MdeModulePkg: Fix typos and add periods

On 7/30/19 10:37 AM, Zhang, Shenglei wrote: > para in Presentation.c is spelled incorrectly. 'param' > Add periods in CapsuleLib.h and Presentation.c. > > Cc: Jian J Wang > Cc: Hao A Wu > Signed-off-by: Shenglei Zhang > --- > MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c | 4 ++-- >

[edk2-devel] [PATCH 1/2] ArmPkg: DebugPeCoffExtraActionLib: debugger commands are not errors

In commit 1fce963d89f3e we reduced the level of information printed by PeCoffLoaderRelocateImageExtraAction() but we did not update the similar PeCoffLoaderUnloadImageExtraAction() function. PeCoffLoaderUnloadImageExtraAction() prints helpful debugger commands for source level debugging. These

[edk2-devel] [PATCH 2/2] ArmPkg: DebugPeCoffExtraActionLib: fix trivial typos

Fix a pair of trivial typos by inserting a space. Cc: Leif Lindholm Cc: Ard Biesheuvel Signed-off-by: Philippe Mathieu-Daude --- .../DebugPeCoffExtraActionLib/DebugPeCoffExtraActionLib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [edk2-devel][Patch 1/3] MdePkg/UefiDebugLibConOut: Add destructor to CloseEvent

On 7/29/19 6:09 PM, Laszlo Ersek wrote: > On 07/29/19 16:38, Philippe Mathieu-Daudé wrote: >> Hi, >> >> On 7/26/19 5:10 AM, Xu, Wei6 wrote: >>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2012 >>> >>> When driver is unloaded, the ExitBoot

Re: [edk2-devel] [Patch 02/11] BaseTools: Split WorkspaceAutoGen._InitWorker into multiple functions

Hi Bob, On 7/29/19 10:44 AM, Bob Feng wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 > > The WorkspaceAutoGen.__InitWorker function is too long, it's hard > to read and understand. > This patch is to separate the __InitWorker into multiple small ones. Patch looks good, however

Re: [edk2-devel] [PATCH] SecurityPkg/SecurityPkg.dec: Remove trailing white space

On 7/29/19 5:40 AM, Zhang, Shenglei wrote: > Cc: Jiewen Yao > Cc: Jian Wang > Cc: Chao Zhang > Signed-off-by: Shenglei Zhang > --- > SecurityPkg/SecurityPkg.dec | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/SecurityPkg/SecurityPkg.dec b/SecurityPkg/SecurityPkg.dec

Re: [edk2-devel] [edk2-non-osi] [PATCH 4/6] replace FSP license file.

Hi, On 7/25/19 7:35 PM, Nate DeSimone wrote: > From: Jiewen Yao > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jiewen Yao > Reviewed-by: Vincent Zimmer > --- > ... Production RULAC click-through_3-14-18.pdf | Bin 487917 -> 0 bytes >

Re: [edk2-devel][Patch 1/3] MdePkg/UefiDebugLibConOut: Add destructor to CloseEvent

Hi, On 7/26/19 5:10 AM, Xu, Wei6 wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2012 > > When driver is unloaded, the ExitBootSerivesEvent must be closed at > the same time. Otherwise exception will occur when ExitBootServices. > > Cc: Michael D Kinney > Cc: Liming Gao >

Re: [edk2-devel] [PATCH v2 1/3] OvmfPkg/build.sh: use POSIX 'command -v' instead of 'which'.

On 7/25/19 2:45 PM, rebe...@bsdio.com wrote: > On 2019-07-25 05:07, Philippe Mathieu-Daudé wrote: >> It would be quicker to reply to your series if you use a cover letter. >> (I'd have replied "series: Reviewed-by" instead of going thru each patch). > >

Re: [edk2-devel] [PATCH V2] BaseTools: replace the chinese quotation mark with unicode "

On 7/25/19 5:00 AM, Fan, ZhijuX wrote: > From: Sean Brogan > > BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2013 > > chinese quotation mark are used in the file > This patch is going to fix that issue. > > Cc: Bob Feng > Cc: Liming Gao > Signed-off-by: Zhiju.Fan > --- >

Re: [edk2-devel] [PATCH v2 3/3] OvmfPkg/build.sh: remove $ADD_QEMU_HDA

On 7/24/19 11:44 PM, rebe...@bsdio.com wrote: > $ADD_QEMU_HDA was added because QEMU used to refuse to run without a > disk. Since newer versions run without any disks, remove it. Finally :) Should we also update the wiki documentation? Reviewed-by: Philippe Mathieu-Daude > > Signed-off-by:

Re: [edk2-devel] [PATCH v2 2/3] OvmfPkg/build.sh: use newer '-drive if=pflash' syntax when running qemu

On 7/24/19 11:44 PM, rebe...@bsdio.com wrote: > Specify the firmware to use via the newer '-drive if=pflash' syntax > which allows specifying the raw format parameter. This > avoids warnings with newer version of QEMU. > > Signed-off-by: Rebecca Cran > --- > OvmfPkg/build.sh | 2 +- > 1 file

Re: [edk2-devel] [PATCH v2 1/3] OvmfPkg/build.sh: use POSIX 'command -v' instead of 'which'.

Hi Rebecca, It would be quicker to reply to your series if you use a cover letter. (I'd have replied "series: Reviewed-by" instead of going thru each patch). On 7/24/19 11:44 PM, rebe...@bsdio.com wrote: > Signed-off-by: Rebecca Cran > --- > OvmfPkg/build.sh | 10 +- > 1 file changed,

Re: [edk2-devel] [PATCH V2] BaseTools:Add extra debugging message

Nit in subject, "BaseTools:Add extra debugging message" On 7/25/19 5:02 AM, Fan, ZhijuX wrote: > From: Max Knutsen > > BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2014 > > Add extra debugging to improve error identification. > Error while processing file if the file is read incorrectly >

Re: [edk2-devel] [PATCH V2] BaseTools:Added arch output to build report

Hi Fan, On 7/25/19 5:04 AM, Fan, ZhijuX wrote: > From: Matthew Carlson > > BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2016 > > Added arch output to build report so it's easy to tell > which arch is being generated. Useful when multiple versions > of a single module is being emitted for

Re: [edk2-devel] [PATCH 1/2] OvmfPkg/build.sh: use newer '-drive if=pflash' syntax when running qemu

On 7/24/19 7:26 PM, Jordan Justen wrote: > On 2019-07-24 05:27:28, Philippe Mathieu-Daudé wrote: >> On 7/24/19 4:54 AM, Jordan Justen wrote: >>> On 2019-07-23 18:51:00, wrote: >>>> Specify the firmware to use via the newer '-drive if=pflash' syntax >>>&

Re: [edk2-devel] [PATCH] OvmfPkg/build.sh: use POSIX 'command -v' instead of 'which'.

Hi Rebecca, On 7/24/19 2:49 AM, rebe...@bsdio.com wrote: > Signed-off-by: Rebecca Cran > --- > OvmfPkg/build.sh | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh > index e94aa2a37e..1c28e65404 100755 > --- a/OvmfPkg/build.sh

Re: [edk2-devel] [PATCH 1/2] OvmfPkg/build.sh: use newer '-drive if=pflash' syntax when running qemu

On 7/24/19 4:54 AM, Jordan Justen wrote: > On 2019-07-23 18:51:00, wrote: >> Specify the firmware to use via the newer '-drive if=pflash' syntax >> which allows specifying the raw format and readonly parameters. This >> avoids warnings with newer version of QEMU. >> >> Signed-off-by: Rebecca Cran

Re: [edk2-devel] [Patch] BaseTools: Sort file list in Makefile

On 7/18/19 9:34 AM, Bob Feng wrote: > This patch is going to sort the file list in generated > Makefile. This change make the autogen makefile easy to > compare. Good idea. > > Cc: Liming Gao > Signed-off-by: Bob Feng Reviewed-by: Philippe Mathieu-Daude > --- >

Re: [edk2-devel] [PATCH v2] OvmfPkg/build.sh: enable multitheaded build by default

On 7/23/19 2:32 AM, rebe...@bsdio.com wrote: > Enable multithreaded builds by default when building OvmfPkg > using build.sh. > This can drastically reduce build times. For example, on a > modern ThreadRipper system the time required to build decreases > from 3 minutes to 1 minute. > >

Re: [edk2-devel] [PATCH 3/4] CryptoPkg/BaseCryptLib: list module-internal header files in INF [Sources]

On 7/19/19 6:43 PM, Laszlo Ersek wrote: > The BaseTools build feature introduced for TianoCore#1804 / in commit > 1fa6699e6cd4 ("BaseTools: Add a checking for Sources section in INF file", > 2019-06-10) logs some (non-fatal) warnings about unlisted internal header > files. List those files

Re: [edk2-devel] [PATCH 4/4] EmbeddedPkg: list module-internal header files in INF [Sources]

On 7/19/19 6:43 PM, Laszlo Ersek wrote: > The BaseTools build feature introduced for TianoCore#1804 / in commit > 1fa6699e6cd4 ("BaseTools: Add a checking for Sources section in INF file", > 2019-06-10) logs some (non-fatal) warnings about unlisted internal header > files. List those files

Re: [edk2-devel] [PATCH 0/3] add GetMaintainer.py helper script

On 7/18/19 7:40 PM, Leif Lindholm wrote: > On Thu, Jul 18, 2019 at 07:01:40PM +0200, Philippe Mathieu-Daudé wrote: >> Hi Leif, >> >> On 7/18/19 6:27 PM, Leif Lindholm wrote: >>> Laszlo, Hao - I have prepared a set for pushing as below. >>> >>> (

Re: [edk2-devel] [PATCH 0/3] add GetMaintainer.py helper script

Hi Leif, On 7/18/19 6:27 PM, Leif Lindholm wrote: > Laszlo, Hao - I have prepared a set for pushing as below. > > (Reviewed-by: Leif Lindholm > for all of your patches.) > *But*, I need a review from  Bob and/or Liming before I push the final one: > "BaseTools:

Re: [edk2-devel] [PATCH 0/4] Maintainers.txt: formalize ArmVirtPkg and OvmfPkg subsystem pathnames

Fish > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: David Woodhouse > Cc: Jordan Justen > Cc: Julien Grall > Cc: Leif Lindholm > Cc: Marc-André Lureau > Cc: Michael D Kinney > Cc: Philippe Mathieu-Daudé > Cc: Stefan Berger > > Thanks > Laszlo &

Re: [edk2-devel] [PATCH] MdePkg/BaseLib: Base64Decode(): don't declare variables in nested blocks

y, >> this type of declaration is strongly discouraged. > > Hoist such variable declarations in Base64Decode() to the outermost > function scope. > > Cc: Liming Gao > Cc: Michael D Kinney > Cc: Philippe Mathieu-Daudé > Cc: Zhichao Gao > Fixes: 35e242b698cdc6205e99a6d6a18

Re: [edk2-devel] [PATCH 1/3] MdePkg/BaseLib: re-specify Base64Decode(), and add temporary stub impl

On 7/16/19 4:14 PM, Laszlo Ersek wrote: > On 07/16/19 11:41, Philippe Mathieu-Daudé wrote: >> Hi Laszlo, >> >> On 7/16/19 10:38 AM, Philippe Mathieu-Daudé wrote: >>> On 7/2/19 12:28 PM, Laszlo Ersek wrote: >>>> Rewrite Base64Decode() from scratch, due to r

Re: [edk2-devel] [PATCH 2/3] MdePkg/BaseLib: rewrite Base64Decode()

ollow (well described) and certainly safer. > Cc: Liming Gao > Cc: Marvin Häuser > Cc: Michael D Kinney > Cc: Philippe Mathieu-Daudé > Cc: Zhichao Gao > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1891 > Ref: > c495bd0b-ea4d-7206-8a4f-a7149760d19a@redhat.com"&g

Re: [edk2-devel] [PATCH 1/3] MdePkg/BaseLib: re-specify Base64Decode(), and add temporary stub impl

Hi Laszlo, On 7/16/19 10:38 AM, Philippe Mathieu-Daudé wrote: > On 7/2/19 12:28 PM, Laszlo Ersek wrote: >> Rewrite Base64Decode() from scratch, due to reasons listed in the second >> reference below. >> >> As first step, redo the interface contract, and replace th

Re: [edk2-devel] [PATCH 1/3] MdePkg/BaseLib: re-specify Base64Decode(), and add temporary stub impl

Cc: Liming Gao > Cc: Marvin Häuser > Cc: Michael D Kinney > Cc: Philippe Mathieu-Daudé > Cc: Zhichao Gao > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1891 > Ref: > c495bd0b-ea4d-7206-8a4f-a7149760d19a@redhat.com">http://mid.mail-archive.com/c495bd0b-e

Re: [edk2-devel] [PATCH 4/4] Maintainers.txt: split out section "OvmfPkg: CSM modules"

format. > > Cc: Andrew Fish > Cc: Ard Biesheuvel > Cc: David Woodhouse > Cc: Jordan Justen > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Philippe Mathieu-Daudé > Signed-off-by: Laszlo Ersek > --- > Maintainers.txt | 6 -- > 1 file changed, 4 insert

Re: [edk2-devel] [PATCH 3/4] Maintainers.txt: split out section "OvmfPkg: TCG- and TPM2-related modules"

; in > machine-readable format. > > Cc: Andrew Fish > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Leif Lindholm > Cc: Marc-André Lureau > Cc: Michael D Kinney > Cc: Philippe Mathieu-Daudé > Cc: Stefan Berger > Signed-off-by: Laszlo Ersek > --- > Main

Re: [edk2-devel] [Patch 1/1] BaseTools: Detect the change of env variable used in tooldef.txt

On 6/28/19 5:32 AM, Bob Feng wrote: > BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1921 > > Add TOOLS_DEF.ARCH file to all workspace meta files list. > TOOLS_DEF.ARCH include the evaluated Tool definition information > which is filtered by current tool_chain. > > With this change, when the

Re: [edk2-devel] [Patch] BaseTools: Fix GCC compiler failure in new added tools.

Hi, On 7/5/19 9:51 AM, Liming Gao wrote: > From: gaozhic > > GCC 7 or 8 reports some warnings in new added FCE/FMMT/BlmLib. > > Signed-off-by: Liming Gao > Cc: Bob Feng > --- > BaseTools/Source/C/BfmLib/BfmLib.c | 2 +- > BaseTools/Source/C/FCE/BinaryParse.c |

Re: [edk2-devel] [PATCH 0/5] MdePkg, SecurityPkg, OvmfPkg: revert unreviewed SM3 patches

On 7/4/19 6:05 PM, Laszlo Ersek wrote: > On 07/04/19 11:46, Laszlo Ersek wrote: >> Repo: https://github.com/lersek/edk2.git >> Branch: revert_unreviewed_bz1781 >> >> The MdePkg patch and the OvmfPkg patch committed for >> had not been >>

Re: [edk2-devel] [PATCH] BaseTools: Fix various typos

On 7/4/19 1:16 PM, Philippe Mathieu-Daudé wrote: > Hi Antoine, > > On 7/3/19 5:08 PM, Cœur wrote: >> Fix various typos in BaseTools. >>   >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Coeur >> --- >>  BaseTools/Conf/X

Re: [edk2-devel] [PATCH 0/5] MdePkg, SecurityPkg, OvmfPkg: revert unreviewed SM3 patches

On 7/4/19 11:46 AM, Laszlo Ersek wrote: > Repo: https://github.com/lersek/edk2.git > Branch: revert_unreviewed_bz1781 > > The MdePkg patch and the OvmfPkg patch committed for > had not been > reviewed appropriately, so they must be reverted.

Re: [edk2-devel] [PATCH] ArmVirtPkg: handle NETWORK_TLS_ENABLE in ArmVirtQemu*

On 6/24/19 9:13 PM, Laszlo Ersek wrote: > Port the [LibraryClasses], [PcdsFixedAtBuild] and [Components] settings > that are related to NETWORK_TLS_ENABLE from OvmfPkg to ArmVirtPkg. > ArmVirtXen is not modified because it doesn't include the edk2 network > stack. > > (This change is now simpler

Re: [edk2-devel] [PATCH v2] OvmfPkg: Use DxeRuntimeCapsuleLib from DxeCapsuleLibFmp in X64 builds

Hi Tomas, On 6/24/19 5:53 PM, Tomas Pilar (tpilar) wrote: > Switching to this library enables capsule support for FMP devices. > This will allow testing of FMP for PCI devices using OVMF and PCI > passthrough as well as software parts of the FMP API. > > Simple tests show that a capsule with an

Re: [edk2-devel] [PATCH 0/2] BaseTools: add script to set up git environment

On 6/10/19 1:54 PM, Leif Lindholm wrote: > https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers > is a great resource, but it's a lot of manual steps to go through for > each repository (especially as the number seems to grow).

Re: [edk2-devel] [RFC PATCH 0/3] add GetMaintainer.py helper script

On 6/14/19 10:21 PM, Leif Lindholm wrote: > Changes are available directly from: > https://git.linaro.org/people/leif.lindholm/edk2.git/log/?h=upstreaming/git-maintainer-rfc > > This series adds new tags to the Maintainers.txt format, making it possible > to describe which filesystem paths are

Re: [edk2-devel] [RFC PATCH 1/3] Maintainers.txt: update for filesystem area descriptions

On 6/14/19 10:21 PM, Leif Lindholm wrote: > Add comment describing new F: and X: tags for associating maintainership > sections with specific filesystem paths, including wildcards. > > Add global section associating *all* code with devel@edk2.groups.io, > and add a magic '' F: tag directing all

Re: [edk2-devel] [PATCH 0/2] EmbeddedPkg,ArmPlatformPkg: fix VS2017 TimeBaseLib build errors

On 6/13/19 6:18 PM, Leif Lindholm wrote: > TimeBaseLib EfiTimeToEpoch returns a UINTN, meaning its behaviour differs > between architectures. This upsets VS2017 when building for 32-bit ARM > (and likely would if building for IA32 too). Similarly, some internal > calculations used UINTN for

Re: [edk2-devel] [PATCH for-next] MdeModulePkg/PciBusDxe: catch unimplemented extended config space reads

On 6/4/19 11:44 PM, Laszlo Ersek wrote: > When assigning a physical PCIe device to a QEMU/KVM guest, PciBusDxe may > find that the extended config space is not (fully) implemented. In > LocatePciExpressCapabilityRegBlock(), "CapabilityEntry" may be read as > 0x_ at a given config space

Re: [edk2-devel] [Patch V3] edk2: Update additional licenses in Readme.md

On 6/5/19 3:15 AM, Michael D Kinney wrote: > Update the list of additional licenses in Readme.md. For additional > licenses from a git submodule, provide a link to the license file > in the remote git repository. This makes the links in Readme.md > when viewed from the edk2 repository GitHub

Re: [edk2-devel] [PATCH for-edk2-stable201905 6/6] OvmfPkg/PlatformPei: set 32-bit UC area at PciBase / PciExBarBase (pc/q35)

On 5/29/19 5:12 PM, Laszlo Ersek wrote: > (This is a replacement for commit 39b9a5ffe661 ("OvmfPkg/PlatformPei: fix > MTRR for low-RAM sizes that have many bits clear", 2019-05-16).) > > Reintroduce the same logic as seen in commit 39b9a5ffe661 for the pc > (i440fx) board type. > > For q35, the

Re: [edk2-devel] [PATCH v2 7/7] ArmPkg/ArmLib ARM: set .fpu to let Clang 7 assemble ArmV7Support.S

Hi Ard, On 5/27/19 10:51 PM, Ard Biesheuvel wrote: > Clang 7 complains about the vmsr instruction in ArmV7Support.S, > which is only available on cores that implement some flavour of > VFP. So set the .fpu to NEON like we do in some other places. > > Signed-off-by: Ard Biesheuvel > --- > Note

Re: [edk2-devel] [PATCH for-edk2-stable201905 5/6] OvmfPkg: raise the PCIEXBAR base to 2816 MB on Q35

On 5/29/19 5:12 PM, Laszlo Ersek wrote: > (This is a replacement for commit 75136b29541b, "OvmfPkg/PlatformPei: > reorder the 32-bit PCI window vs. the PCIEXBAR on q35", 2019-05-16). > > Commit 7b8fe63561b4 ("OvmfPkg: PlatformPei: enable PCIEXBAR (aka MMCONFIG > / ECAM) on Q35", 2016-03-10)

Re: [edk2-devel] [PATCH for-edk2-stable201905 4/6] Revert "OvmfPkg/PlatformPei: assign PciSize on both i440fx/q35 branches explicitly"

On 5/29/19 5:12 PM, Laszlo Ersek wrote: > This reverts commit 60e95bf5094fbb9b728729ccfaf32184b3662317. > > The original fix for > triggered a bug / incorrect assumption in QEMU. > > QEMU assumes that the PCIEXBAR is below the 32-bit PCI

Re: [edk2-devel] [PATCH for-edk2-stable201905 2/6] Revert "OvmfPkg/PlatformPei: reorder the 32-bit PCI window vs. the PCIEXBAR on q35"

On 5/29/19 5:12 PM, Laszlo Ersek wrote: > This reverts commit 75136b29541b0e093a51d2e2c2af8d19855c2b60. > > The original fix for > triggered a bug / incorrect assumption in QEMU. > > QEMU assumes that the PCIEXBAR is below the 32-bit PCI

Re: [edk2-devel] [PATCH for-edk2-stable201905 3/6] Revert "OvmfPkg/PlatformPei: hoist PciBase assignment above the i440fx/q35 branching"

On 5/29/19 5:12 PM, Laszlo Ersek wrote: > This reverts commit 9a2e8d7c65ef7f39c6754d27e52954b616bc6628. > > The original fix for > triggered a bug / incorrect assumption in QEMU. > > QEMU assumes that the PCIEXBAR is below the 32-bit PCI

Re: [edk2-devel] [PATCH for-edk2-stable201905 1/6] Revert "OvmfPkg/PlatformPei: fix MTRR for low-RAM sizes that have many bits clear"

On 5/29/19 5:12 PM, Laszlo Ersek wrote: > This reverts commit 39b9a5ffe6618b7870be2a54fe7725000249c33a. > > The original fix for > triggered a bug / incorrect assumption in QEMU. > > QEMU assumes that the PCIEXBAR is below the 32-bit PCI

Re: [edk2-devel] [PATCH 3/4] OvmfPkg/PlatformPei: reorder the 32-bit PCI hole vs. the PCIEXBAR on q35

Hi Laszlo, On 5/16/19 2:18 PM, Laszlo Ersek wrote: > On 05/16/19 10:00, Ard Biesheuvel wrote: >> On Sat, 4 May 2019 at 02:07, Laszlo Ersek wrote: >>> >>> Commit 7b8fe63561b4 ("OvmfPkg: PlatformPei: enable PCIEXBAR (aka MMCONFIG >>> / ECAM) on Q35", 2016-03-10) claimed that, >>> >>> On Q35

Re: [edk2-devel] [PATCH 4/4] OvmfPkg/PlatformPei: fix MTRR for low-RAM sizes that have many bits clear

On 5/4/19 2:07 AM, Laszlo Ersek wrote: > Assume that we boot OVMF in a QEMU guest with 1025 MB of RAM. The > following assertion will fire: > >> ASSERT_EFI_ERROR (Status = Out of Resources) >> ASSERT OvmfPkg/PlatformPei/MemDetect.c(696): !EFI_ERROR (Status) > > That's because the range [1025 MB,

Re: [edk2-devel] [PATCH 2/4] OvmfPkg/PlatformPei: hoist PciBase assignment above the i440fx/q35 branching

edhat.com/show_bug.cgi?id=1666941 > Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1701710 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Laszlo Ersek Reviewed-by: Philippe Mathieu-Daudé > --- > OvmfPkg/PlatformPei/Platform.c | 2 +- > 1 file changed, 1 i

Re: [edk2-devel] [PATCH 1/4] OvmfPkg/PlatformPei: assign PciSize on both i440fx/q35 branches explicitly

'Contributed-under' tag from your git config. It has been removed from the wiki: https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format/_compare/03d738e...ee27b0b > Signed-off-by: Laszlo Ersek Reviewed-by: Philippe Mathieu-Daudé > --- > OvmfPkg/PlatformPei/Platform

Re: [edk2-devel] [PATCH 15/16] OvmfPkg/EnrollDefaultKeys: enroll PK/KEK1 from the Type 11 SMBIOS table

On 4/27/19 2:53 AM, Laszlo Ersek wrote: > Disconnect the certificate that is enrolled as both Platform Key and first > Key Exchange Key from Red Hat: expect the hypervisor to specify it, as > part of SMBIOS. > > Example usage with QEMU: > > * Generate self-signed X509 certificate: > > openssl

Re: [edk2-devel] [PATCH 14/16] OvmfPkg: introduce OVMF_PK_KEK1_APP_PREFIX_GUID

On 4/27/19 2:53 AM, Laszlo Ersek wrote: > For the EnrollDefaultKeys application, the hypervisor is expected to add a > string entry to the "OEM Strings" (Type 11) SMBIOS table, with the > following format: > > 4e32566d-8e9e-4f52-81d3-5bb9715f9727: > > The string representation of the GUID at the

Re: [edk2-devel] [PATCH 01/16] OvmfPkg: introduce EnrollDefaultKeys application

On 4/27/19 2:53 AM, Laszlo Ersek wrote: > Add the OvmfPkg/EnrollDefaultKeys shell application source as it is at the > "edk2-20190308git89910a39dcfd-2.el8" tag in RHEL8's downstream "edk2" > package. > > Further patches in this series will replace Red Hat-specific bits in the > application, with

Re: [edk2-devel] [PATCH 02/16] OvmfPkg/EnrollDefaultKeys: update @file comment blocks

On 4/27/19 2:53 AM, Laszlo Ersek wrote: > Refresh the sentence that states the purpose of the application. > > Extend the copyright notice to the year 2019. > > Replace the 2-clause BSD License banner with the BSD-2-Clause-Patent SPDX > ID. > > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc:

Re: [edk2-devel] [PATCH 12/16] OvmfPkg/EnrollDefaultKeys: describe functions with leading comment blocks

On 4/27/19 2:53 AM, Laszlo Ersek wrote: > The GetExact(), GetSettings(), PrintSettings(), and ShellAppMain() > functions lack leading comment blocks. Supply those. > > While at it, make sure that every such comment block is preceded by two > blank lines. > > Cc: Anthony Perard > Cc: Ard

Re: [edk2-devel] [PATCH 11/16] OvmfPkg/EnrollDefaultKeys: extract MICROSOFT_VENDOR_GUID

On 4/27/19 2:53 AM, Laszlo Ersek wrote: > The GUID > > 77FA9ABD-0359-4D32-BD60-28F4E78F784B > > is specified in MSDN, at > , therefore it > deserves an entry in the package DEC file, and a header file under > "Include/Guid". > >

Re: [edk2-devel] [PATCH 07/16] OvmfPkg/EnrollDefaultKeys: clean up acronym capitalization in identifiers

On 4/27/19 2:53 AM, Laszlo Ersek wrote: > According to the edk2 coding standards, "[w]hen all letters in an acronym > are capitalized, it makes the prior and subsequent words visually > difficult to distinguish". > > Fix the spellings of three acronyms, accordingly: > - "KEK" (Key Exchange Key)

Re: [edk2-devel] [PATCH 3/3] CryptoPkg/BaseCryptLib: updata HMAC_ctx size

Hi Xiaoyu, Small typos: "update" in subject. Maybe better described as "Make HMAC_CTX_SIZE backward compatible"? On 4/29/19 10:15 AM, Xiaoyu lu wrote: > From: Xiaoyu Lu > > Openssl internally redefines the size of HMAC_CTX, "OpenSSL"? > but there is no external definition. > So add an

Re: [edk2-devel] [PATCH 10/16] OvmfPkg/EnrollDefaultKeys: split out certificate and signature constants

On 4/27/19 2:53 AM, Laszlo Ersek wrote: > A large portion of "EnrollDefaultKeys.c" is hex-encoded X509 certificates, > GUIDs, and signatures. These objects are constants, unlikely to see > changes anytime soon. Move them out of the way, to "AuthData.c", so we can > more easily work on functions in

Re: [edk2-devel] [PATCH 08/16] OvmfPkg/EnrollDefaultKeys: remove unneeded EFIAPI call. conv. specifiers

On 4/27/19 2:53 AM, Laszlo Ersek wrote: > The GetExact(), GetSettings(), PrintSettings() functions are only called > from within "EnrollDefaultKeys.c", and none of them take variable > arguments. Drop their EFIAPI calling convention specifiers. > > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc:

Re: [edk2-devel] [PATCH 13/16] OvmfPkg/EnrollDefaultKeys: document the steps of the entry point function

On 4/27/19 2:53 AM, Laszlo Ersek wrote: > The entry point function of EnrollDefaultKeys finishes with a sanity > check, verifying the values of the Secure Boot-related "control" > variables. Add a diagram to explain why we expect the values we do. > > While at it, write comments on the rest of

Re: [edk2-devel] [PATCH 04/16] ArmVirtPkg: build EnrollDefaultKeys.efi

On 4/27/19 2:53 AM, Laszlo Ersek wrote: > Having removed VALID_ARCHITECTURES from > "OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.inf", it now makes sense to > reflect the related platform DSC bits from OvmfPkg to ArmVirtPkg. > > Build "EnrollDefaultKeys.efi" as part of ArmVirtQemu and

Re: [edk2-devel] [PATCH 03/16] OvmfPkg/EnrollDefaultKeys: refresh INF file

On 4/27/19 2:53 AM, Laszlo Ersek wrote: > Bump INF_VERSION to the latest edk2 INF specification. > > Regenerate FILE_GUID to distinguish this application from downstream-only > versions. > > Remove the VALID_ARCHITECTURES comment as there is nothing ISA or platform > specific in the application.

Re: [edk2-devel] [PATCH] CryptoPkg: add issetugid declaration to fix openssl build on FreeBSD

On 4/22/19 3:46 PM, Wang, Jian J wrote: > crypto/uid.c is needed by VS201x toolchain on Windows. Let's still keep it in > inf. > That means we need this patch for build on FreeBSD. > > Reviewed-by: Jian J Wang Commit 1a734ed85fda71630c795832e6d24ea560caf739 has weird authorship again: rebecca

Re: [edk2-devel] [staging/about Patch] Remove reference to Tiano Contributor's Agreement

On 4/20/19 12:54 AM, Michael D Kinney wrote: > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Signed-off-by: Michael D Kinney > --- > README | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/README b/README > index b640a482f9..60f14a654a 100644 > --- a/README

Re: [edk2-devel] [PATCH v2 4/5] MdePkg/PiFirmwareFile: fix undefined behavior in FFS_FILE_SIZE

On 4/18/19 7:47 PM, Laszlo Ersek wrote: > Accessing "EFI_FFS_FILE_HEADER.Size", which is of type UINT8[3], through a > (UINT32*), is undefined behavior. Fix it by accessing the array elements > individually. > > Cc: Liming Gao > Cc: Michael D Kinney > Bugzilla:

Re: [edk2-devel] [PATCH v2 2/5] MdePkg/PiFirmwareFile: fix undefined behavior in SECTION_SIZE

On 4/18/19 7:47 PM, Laszlo Ersek wrote: > RH covscan justifiedly reports that accessing > "EFI_COMMON_SECTION_HEADER.Size", which is of type UINT8[3], through a > (UINT32*), is undefined behavior: > >> Error: OVERRUN (CWE-119): >> edk2-89910a39dcfd/OvmfPkg/Sec/SecMain.c:178: overrun-local:

Re: [edk2-devel] [PATCH v2 3/5] BaseTools/PiFirmwareFile: fix undefined behavior in SECTION_SIZE

On 4/18/19 7:47 PM, Laszlo Ersek wrote: > Sync SECTION_SIZE() from MdePkg to BaseTools, from an earlier patch in > this series. > > Cc: Bob Feng > Cc: Liming Gao > Cc: Yonghong Zhu > Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1710 > Signed-off-by: Laszlo Ersek > --- > > Notes:

Re: [edk2-devel] [PATCH 0/3] MdePkg/DebugLib: Change the global variable name

On 4/23/19 4:35 AM, Gao, Zhichao wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1740 > > The DebugLib instances of DebugPortProtocol, ConOut and StdErr > use a global variable "mExitBootServicesEvent" which is in > conflict with the same variable in StatusCodeHandlerRuntimeDxe.inf.

Re: [edk2-devel] [PATCH 04/10] MdePkg/PiFirmwareFile: fix undefined behavior in FFS_FILE_SIZE

Hi Michael, On 4/17/19 7:52 PM, Michael D Kinney wrote: > Laszlo, > > I have been following this thread. I think the style > used here to access the 3 array elements to build the > 24-bit size value is the best approach. I prefer this > over adding the union. > > I agree there is a read

Re: [edk2-devel] [edk2-CCodingStandardsSpecification Patch V2] Change preferred license of EDK II to BSD+Patent

On 4/17/19 7:27 PM, Michael D Kinney wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=1656 > > Change the EDK II C Coding Standards Specification to state that > the preferred license of the EDK II is the BSD+Patent License and > that file headers should use SPDX license identifiers. > >

Re: [edk2-devel] [PATCH 09/10] OvmfPkg/AcpiPlatformDxe: catch theoretical nullptr deref in Xen code

On 4/13/19 1:31 AM, Laszlo Ersek wrote: > RH covscan justifiedly reports a path through InstallXenTables() where > DsdtTable can technically remain NULL. > > If this occurs in practice, then the guest and the VMM are out of sync on > the interface contract. Catch the situation with a code snippet

Re: [edk2-devel] [PATCH 07/10] OvmfPkg/AcpiPlatformDxe: suppress invalid "deref of undef pointer" warning

On 4/13/19 1:31 AM, Laszlo Ersek wrote: > RH covscan emits the following false positive: > >> Error: CLANG_WARNING: >> edk2-89910a39dcfd/OvmfPkg/AcpiPlatformDxe/AcpiPlatform.c:182:14: >> warning: Dereference of undefined pointer value >> #Status = FwVol->ReadSection ( >> #

Re: [edk2-devel] [PATCH] BaseTools: support arm64 as a platform name in addition to aarch64

On 4/11/19 9:58 PM, Rebecca Cran wrote: > On 2019-04-11 13:55, Philippe Mathieu-Daudé wrote: >> >> With the work around link added: >> Reviewed-by: Philippe Mathieu-Daude > > > > But it's _not_ working around that bug. That was about "uname -p", b

Re: [edk2-devel] [PATCH] IntelFrameworkModulePkg: Fix comments and improve E820 debug output

On 4/11/19 9:53 PM, Rebecca Cran wrote: > On 2019-04-11 13:30, Rebecca Cran via Groups.Io wrote: >> >> I'm sending emails on Thunderbird via Postfix, so there's no Outlook >> involved. >> > > Let's try again: I've unset the groups.io fields, so I wonder if that'll > change things. Yes, I see

Re: [edk2-devel] [PATCH] BaseTools: support arm64 as a platform name in addition to aarch64

On 4/11/19 7:52 PM, Laszlo Ersek wrote: > On 04/11/19 16:23, Philippe Mathieu-Daudé wrote: >> On 4/11/19 5:16 AM, Rebecca Cran via Groups.Io wrote: >>> Some systems such as FreeBSD identify the platform as 'arm64' >>> and not 'aarch64' as Linux does. >> >>

Re: [edk2-devel] [PATCH] IntelFrameworkModulePkg: Fix comments and improve E820 debug output

2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >> Philippe Mathieu-Daudé >> Sent: Thursday, April 11, 2019 6:59 PM >> To: Gao, Liming ; Kinney, Michael D >> ; Laszlo Ersek >> Cc: devel@edk2.groups.io; rebe...@bluestop.org; Stephano Cetola >> >>

Re: [edk2-devel] [PATCH] BaseTools: support arm64 as a platform name in addition to aarch64

On 4/11/19 5:16 AM, Rebecca Cran via Groups.Io wrote: > Some systems such as FreeBSD identify the platform as 'arm64' > and not 'aarch64' as Linux does. Per https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220297 this seems to be a FreeBSD bug. > Signed-off-by: Rebecca Cran > --- >

Re: [edk2-devel] [PATCH] IntelFrameworkModulePkg: Fix comments and improve E820 debug output

day, April 08, 2019 9:16 PM >> To: Philippe Mathieu-Daudé ; rebe...@bluestop.org >> Cc: devel@edk2.groups.io >> Subject: Re: [edk2-devel] [PATCH] IntelFrameworkModulePkg: Fix comments >> and improve E820 debug output >> >> Reviewed-by: Liming Gao >> >&g

Re: [edk2-devel] [edk2] [PATCH] MdeModulePkg/CapsulePei: Update the debug code to print 64bit data

ct. And lots of PEIMs keep this combine. > > Thanks, > Zhichao > >> -Original Message- >> From: Wu, Hao A >> Sent: Thursday, April 11, 2019 4:12 PM >> To: Gao, Zhichao ; Philippe Mathieu-Daudé >> ; devel@edk2.groups.io >> Cc: Bret Barkelew ; Mi

<    5   6   7   8   9   10   11   >