Re: [edk2-devel] [PATCH v2 5/5] MdePkg/BaseLib: ensure ARM LongJump never returns 0

2023-10-03 Thread Philippe Mathieu-Daudé
Biesheuvel Cc: Sami Mujawar --- MdePkg/Library/BaseLib/Arm/SetJumpLongJump.S | 2 ++ MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm | 2 ++ Reviewed-by: Philippe Mathieu-Daudé -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109289

Re: [edk2-devel] [PATCH v2 4/5] MdePkg/BaseLib: correct register sizes in AArch64 SetJump/LongJump

2023-10-03 Thread Philippe Mathieu-Daudé
all of these to use the 64-bit x register views. Signed-off-by: Leif Lindholm Reanimated-by: Andrei Warkentin =) Reviewed-by: Philippe Mathieu-Daudé Cc: Ard Biesheuvel Cc: Sami Mujawar --- MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S | 8 MdePkg/Library/BaseLib/AArch64

Re: [edk2-devel] [PATCH v2 3/5] MdePkg/BaseLib: use normal register init in ARM SetJump implementations

2023-10-03 Thread Philippe Mathieu-Daudé
Hi Leif, On 26/9/23 19:15, Leif Lindholm wrote: There may be architectures on which there are benefits to eor r0, r0(, r0) but ARM was never one of them. Change to more readable mov r0, #0 instead. Signed-off-by: Leif Lindholm Cc: Ard Biesheuvel Cc: Sami Mujawar ---

Re: [edk2-devel] [PATCH 1/1] MdePkg/BaseLib: fix typo in Arm SetJump

2023-10-03 Thread Philippe Mathieu-Daudé
On 3/10/23 12:39, Leif Lindholm wrote: RO -> R0 Signed-off-by: Leif Lindholm Reported-by: Philippe Mathieu-Daudé Cc: Ard Biesheuvel Cc: Sami Mujawar --- MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdePkg/Libr

Re: [edk2-devel] [PATCH v4 6/7] OvmfPkg/PlatformCI: dummy grub.efi for AmdSev

2021-12-13 Thread Philippe Mathieu-Daudé
On 12/13/21 09:14, Gerd Hoffmann wrote: > Building grub.efi for AmdSev is difficult because it depends on patches > not yet merged to upstream grub. So shortcut the grub build by simply > creating an empty grub.efi file. That allows to at least build-test the > AmdSev variant. > >

Re: [edk2-devel] [PATCH v3 4/5] OvmfPkg/Microvm/virtio: add virtio-mmio support

2021-12-13 Thread Philippe Mathieu-Daudé
On 12/13/21 09:16, Gerd Hoffmann wrote: > Add virtio-mmio support (VirtioMmioDeviceLib and VirtioFdtDxe). > > With this patch added and a new enough qemu version (6.2+) edk2 > will detect virtio-mmio devices, so it is possible to boot from > storage (virtio-blk, virtio-scsi) or network

Re: [edk2-devel] [PATCH v3 3/5] OvmfPkg/Microvm/fdt: add empty fdt

2021-12-13 Thread Philippe Mathieu-Daudé
On 12/13/21 09:16, Gerd Hoffmann wrote: > FdtClient is unhappy without a device tree, so add an empty fdt > which we can use in case etc/fdt is not present in fw_cfg. > > On ARM machines a device tree is mandatory for hardware detection, > thats why FdtClient fails hard. "that's" > > On

Re: [edk2-devel] [PATCH v3 1/5] OvmfPkg/Microvm/fdt: add device tree support

2021-12-13 Thread Philippe Mathieu-Daudé
On 12/13/21 09:16, Gerd Hoffmann wrote: > Add fdt parser from EmbeddedPkg (FdtLib and FdtClientDxe) to MicrovmX64. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3689 > Signed-off-by: Gerd Hoffmann > --- > OvmfPkg/Microvm/MicrovmX64.dsc | 6 ++ > OvmfPkg/Microvm/MicrovmX64.fdf | 2

Re: [edk2-devel] [PATCH v3 2/5] OvmfPkg/Microvm/fdt: load fdt from fw_cfg

2021-12-13 Thread Philippe Mathieu-Daudé
On 12/13/21 09:16, Gerd Hoffmann wrote: > Needed for hardware detection: virtio-mmio devices for now, > later also pcie root bridge. > > Depends on patched qemu which actually provides an fdt: > https://gitlab.com/kraxel/qemu/-/commits/sirius/microvm-device-tree Link returns 404. > >

Re: [edk2-devel] [PATCH v3 5/5] OvmfPkg/Microvm: add README

2021-12-13 Thread Philippe Mathieu-Daudé
On 12/13/21 09:16, Gerd Hoffmann wrote: > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 > Signed-off-by: Gerd Hoffmann > Acked-by: Jiewen Yao > --- > OvmfPkg/Microvm/README | 50 ++ > 1 file changed, 50 insertions(+) > create mode 100644

Re: [edk2-devel] [PATCH v4 7/7] OvmfPkg/PlatformCI: add XenBuild.py

2021-12-13 Thread Philippe Mathieu-Daudé
On 12/13/21 09:14, Gerd Hoffmann wrote: > Add build test for OvmfXen. > > Signed-off-by: Gerd Hoffmann > --- > .../.azurepipelines/Ubuntu-GCC5.yml | 9 + > OvmfPkg/PlatformCI/XenBuild.py| 37 +++ > 2 files changed, 46 insertions(+) > create mode

Re: [edk2-devel] [PATCH v4 3/7] OvmfPkg/PlatformCI: add BhyveBuild.py

2021-12-13 Thread Philippe Mathieu-Daudé
On 12/13/21 09:14, Gerd Hoffmann wrote: > Add build test for OvmfPkg/Bhyve. > > Signed-off-by: Gerd Hoffmann > Acked-by: Jiewen Yao > Acked-by: Ard Biesheuvel > --- > .../.azurepipelines/Ubuntu-GCC5.yml | 9 + > OvmfPkg/PlatformCI/BhyveBuild.py | 37

[edk2-devel] [PATCH 3/3] .mailmap: Add an entry for Jiahui Cen

2021-12-08 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daude We use .mailmap to display contributors email addresses in an uniform format. Add an entry for Jiahui Cen to have his/her name and email address displayed properly in the git history (in particular, commit 7a6172f88bb0: "OvmfPkg: Introduce PciHostBridgeUtilityLib

[edk2-devel] [PATCH 2/3] .mailmap: Add an entry for Brijesh Singh

2021-12-08 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daude We use .mailmap to display contributors email addresses in an uniform format. Add an entry for Brijesh Singh to have his/her name and email address displayed properly in the git history (in particular, commit dc485c556d5f: "OvmfPkg/ResetVector: add the macro to

[edk2-devel] [PATCH 1/3] .mailmap: Add an entry for Wenyi Xie

2021-12-08 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daude We use .mailmap to display contributors email addresses in an uniform format. Add an entry for Wenyi Xie to have his/her name and email address displayed properly in the git history (in particular, commit dfafa8e453: "MdeModulePkg/DxeCorePerformanceLib:Variable

[edk2-devel] [PATCH 0/3] .mailmap: Add more entries to keep a clean git history

2021-12-08 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daude The .mailmap git feature helps fixing commit mistakes (in name/email). The easiest way to use it is with the --use-mailmap flag: $ git log --use-mailmap See documentation [1] and [2], and interesting blog [3]. In this series we fix 3 morecontributors emails,

Re: [edk2-devel] [PATCH v4] OvmfPkg: Remove unused print service driver (PrintDxe)

2021-12-08 Thread Philippe Mathieu-Daudé
On 12/8/21 17:47, Ard Biesheuvel wrote: > On Wed, 8 Dec 2021 at 17:43, Philippe Mathieu-Daudé wrote: >> >> Ping? >> > > I'll pick this up once the stable tag is released. Oh, I read "The hard freeze has ended and normal development activities can continue.&qu

Re: [edk2-devel] [PATCH v4] OvmfPkg: Remove unused print service driver (PrintDxe)

2021-12-08 Thread Philippe Mathieu-Daudé
Ping? On 11/18/21 21:46, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daude > > PrintDxe produces gEfiPrint2ProtocolGuid and gEfiPrint2SProtocolGuid, > and those are consumed by the following PrintLib instance: > > MdeModulePkg/Library/DxePrin

[edk2-devel] [PATCH v4] OvmfPkg: Remove unused print service driver (PrintDxe)

2021-11-18 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daude PrintDxe produces gEfiPrint2ProtocolGuid and gEfiPrint2SProtocolGuid, and those are consumed by the following PrintLib instance: MdeModulePkg/Library/DxePrintLibPrint2Protocol/DxePrintLibPrint2Protocol.inf However, none of the OVMF DSC files contain such a PrintLib

Re: [edk2-devel] [Patch 1/1] OvmfPkg/Xen: Fix VS2019 build issues

2021-11-11 Thread Philippe Mathieu-Daudé
Hi Michael, On 11/8/21 17:22, Michael D Kinney wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3722 > > Fix VS2019 NOOPT build issues related to converting > a larger integer value to a smaller integer value. > > Cc: Anthony Perard > Cc: Julien Grall > Cc: Ard Biesheuvel > Cc:

Re: [edk2-devel] [PATCH v2 5/5] OvmfPkg/Microvm: add README

2021-11-09 Thread Philippe Mathieu-Daudé
On 11/3/21 16:06, Gerd Hoffmann wrote: > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 > Signed-off-by: Gerd Hoffmann > Acked-by: Jiewen Yao > --- > OvmfPkg/Microvm/README | 50 ++ > 1 file changed, 50 insertions(+) > create mode 100644

Re: [edk2-devel] [PATCH v2 3/5] OvmfPkg/Microvm/fdt: add empty fdt

2021-11-09 Thread Philippe Mathieu-Daudé
On 11/3/21 16:06, Gerd Hoffmann wrote: > FdtClient is unhappy without a device tree, so add an empty fdt > which we can use in case etc/fdt is not present in fw_cfg. > > On ARM machines a device tree is mandatory for hardware detection, > thats why FdtClient fails hard. > > On microvm the device

Re: [edk2-devel] [PATCH v3 5/5] OvmfPkg: rework TPM configuration

2021-11-09 Thread Philippe Mathieu-Daudé
On 10/28/21 13:09, Gerd Hoffmann wrote: > Rename TPM_ENABLE to TPM2_ENABLE so naming is in line with the > ArmVirtPkg config option name. > > Add separate TPM1_ENABLE option for TPM 1.2 support. > > Signed-off-by: Gerd Hoffmann > Tested-by: Stefan Berger > --- >

Re: [edk2-devel] [PATCH v3 3/5] OvmfPkg: drop TPM_CONFIG_ENABLE

2021-11-09 Thread Philippe Mathieu-Daudé
On 10/28/21 13:09, Gerd Hoffmann wrote: > Drop TPM_CONFIG_ENABLE config option. Including TPM support in the > build without also including the TPM configuration menu is not useful. > > Suggested-by: Stefan Berger > Signed-off-by: Gerd Hoffmann > Tested-by: Stefan Berger > --- >

Re: [edk2-devel] [PATCH v3 1/5] OvmfPkg: remove unused TPM options from MicrovmX64.dsc

2021-11-09 Thread Philippe Mathieu-Daudé
On 10/28/21 13:09, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > OvmfPkg/Microvm/MicrovmX64.dsc | 2 -- > 1 file changed, 2 deletions(-) Reviewed-by: Philippe Mathieu-Daude -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online

Re: [edk2-devel] [PATCH v3 4/5] OvmfPkg: create Tcg12ConfigPei.inf

2021-11-09 Thread Philippe Mathieu-Daudé
On 10/28/21 13:09, Gerd Hoffmann wrote: > Split Tcg2ConfigPei.inf into two variants: Tcg12ConfigPei.inf with > TPM 1.2 support included and Tcg2ConfigPei.inf supporting TPM 2.0 only. > This allows x86 builds to choose whenever TPM 1.2 support should be > included or not by picking the one or the

Re: [edk2-devel] [PATCH v3 5/7] OvmfPkg/PlatformCI: add AmdSevBuild.py

2021-11-03 Thread Philippe Mathieu-Daudé
On 11/3/21 10:11, Gerd Hoffmann wrote: > Add build test for OvmfPkg/AmdSev. > > Acked-by: Jiewen Yao > Acked-by: Ard Biesheuvel > Signed-off-by: Gerd Hoffmann > --- > .../.azurepipelines/Ubuntu-GCC5.yml | 10 + > OvmfPkg/PlatformCI/AmdSevBuild.py | 37

Re: [edk2-devel] [PATCH v3 4/7] OvmfPkg/PlatformCI: add MicrovmBuild.py

2021-11-03 Thread Philippe Mathieu-Daudé
On 11/3/21 10:11, Gerd Hoffmann wrote: > Add build test for OvmfPkg/Microvm. > > Acked-by: Jiewen Yao > Acked-by: Ard Biesheuvel > Signed-off-by: Gerd Hoffmann > --- > .../.azurepipelines/Ubuntu-GCC5.yml | 10 + > OvmfPkg/PlatformCI/MicrovmBuild.py| 37

Re: [edk2-devel] [PATCH v3 2/7] OvmfPkg/PlatformCI: add QEMU_SKIP

2021-11-03 Thread Philippe Mathieu-Daudé
On 11/3/21 10:11, Gerd Hoffmann wrote: > Skip the qemu boot test in case QEMU_SKIP is set to true. > > Acked-by: Jiewen Yao > Acked-by: Ard Biesheuvel > Signed-off-by: Gerd Hoffmann > --- > OvmfPkg/PlatformCI/PlatformBuildLib.py | 5 + > 1 file changed, 5 insertions(+) Reviewed-by:

Re: [edk2-devel] [Patch 6/6] MdeModulePkg/Variable/RuntimeDxeUnitTest: Fix 32-bit GCC builds

2021-11-03 Thread Philippe Mathieu-Daudé
On 11/3/21 04:05, Michael D Kinney wrote: > When using will_return() on a pointer value, it must be > cast to UINTN to be compatible with 32-bit GCC builds. > This uses the same approach in samples provided in the > UnitTestFramworkPkg when passing pointer values to > UT_ASSERT_EQUAL(). > > Cc:

Re: [edk2-devel] [Patch 5/6] UefiCpuPkg/MtrrLib/UnitTest: Fix 32-bit GCC build issues

2021-11-03 Thread Philippe Mathieu-Daudé
On 11/3/21 04:05, Michael D Kinney wrote: > When using UT_ASSERT_EQUAL() on a pointer value, it must be > cast to UINTN. This follows the samples provided with the > UnitTestFrameworkPkg. > > Cc: Eric Dong > Cc: Ray Ni > Cc: Rahul Kumar > Signed-off-by: Michael D Kinney > --- >

Re: [edk2-devel] [PATCH v2 1/1] OvmfPkg: Introduce 16MiB flash size for (primarily) Linuxboot

2021-09-09 Thread Philippe Mathieu-Daudé
On 9/3/21 7:26 AM, Devon Bautista wrote: > The largest size flash image currently available for OVMF builds, 4MiB, > is too small to insert a Linux kernel and initramfs into the DXEFV, and > is thus insufficient for testing Linuxboot builds via OVMF. > > Introduce the FD_SIZE_16MB build macro

Re: [edk2-devel] [PATCH 10/17] OvmfPkg/Microvm: use XenTimerDxe (lapic timer)

2021-08-31 Thread Philippe Mathieu-Daudé
On 8/31/21 11:57 AM, Gerd Hoffmann wrote: > Microvm has no acpi timer, so go use XenTimerDxe > which uses the local apic instead. > > FIXME: timer frequency is wrong. Xen seems to expect a 10MHz timer. Maybe use as constant to make a generic LocalAPICTimer driver used by both Xen and microVM

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Fix typo of "memory" in RamDiskDxe debug message

2021-08-31 Thread Philippe Mathieu-Daudé
On 8/31/21 12:36 AM, Rebecca Cran wrote: > Fix a typo of "memory" in a debug message in RamDiskProtocol.c. > > Signed-off-by: Rebecca Cran > --- > MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskProtocol.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe

Re: [edk2-devel] [PATCH 1/2] OvmfPkg/PlatformPei: ScanOrAdd64BitE820Ram improvements

2021-08-24 Thread Philippe Mathieu-Daudé
On 8/19/21 10:11 AM, Gerd Hoffmann wrote: > Add a bool parameter to ScanOrAdd64BitE820Ram to explicitly specify > whenever ScanOrAdd64BitE820Ram should add HOBs for high memory (above > 4G) or scan only. > > Also add a lowmem parameter so ScanOrAdd64BitE820Ram > can report the memory size below

Re: [edk2-devel] [PATCH 1/1] BaseTools/tools_def: Fix CLANGPDB X64 RCPATH

2021-08-23 Thread Philippe Mathieu-Daudé
On 8/21/21 9:55 PM, Marvin Häuser wrote: > Use the correct X64 path for CLANGPDB RCPATH. > > Cc: Bob Feng > Cc: Liming Gao > Cc: Yuwei Chen > Cc: Vitaly Cheptsov > Signed-off-by: Marvin Häuser Fixes: 15330934dc86 ("BaseTools tools_def: Add CLANG9 tool chain to directly generate PE image")

Re: [edk2-devel] [PATCH v3] OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe

2021-08-23 Thread Philippe Mathieu-Daudé
On 8/23/21 9:08 AM, Lin, Gary (HPS OE-Linux) wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=3574 > > Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download > the kernel, initrd, and kernel command line from QEMU's fw_cfg. > > v3: > Add the bugzilla link > > Cc: Ard

Re: [edk2-devel] [PATCH v3 2/4] OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support

2021-08-23 Thread Philippe Mathieu-Daudé
On 8/23/21 9:09 AM, Lin, Gary (HPS OE-Linux) wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=3573 > > To avoid the potential inconsistency between PcdAcpiS3Enable and > QemuFwCfgS3Enabled(), this commit modifies LockBoxLib to detect > S3 support by PcdAcpiS3Enable as modules in

Re: [edk2-devel] [PATCH 1/1] Maintainers: Add kraxel as Reviewer to ArmVirtPkg and OvmfPkg

2021-08-19 Thread Philippe Mathieu-Daudé
On 8/16/21 9:18 AM, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > Maintainers.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Maintainers.txt b/Maintainers.txt > index 2e2d4d1b7f77..694994b4bfae 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -145,6

Re: [edk2-devel] [PATCH 2/2] OvmfPkg/PlatformPei: prefer etc/e820 for memory detection

2021-08-19 Thread Philippe Mathieu-Daudé
On 8/19/21 10:11 AM, Gerd Hoffmann wrote: > Prefer the e820 map provided via qemu firmware config interface > for memory detection. Use rtc cmos only as fallback, which should > be rarely needed these days as qemu supports etc/e820 since 2013. > > Signed-off-by: Gerd Hoffmann > --- >

Re: [edk2-devel] [PATCH v4 0/7] add support for virtio-mmio 1.0

2021-08-19 Thread Philippe Mathieu-Daudé
On 8/19/21 9:25 AM, Gerd Hoffmann wrote: > This little series adds virtio 1.0 support for the virtio-mmio > transport. For the mmio transport the difference between 0.9.5 and 1.0 > is rather small (when compared to the pci transport), it is just a bunch > of new registers for the changed virtio

Re: [edk2-devel] [PATCH v3 2/4] OvmfPkg/VirtioMmioDeviceLib: Add virtio 1.0 support.

2021-08-17 Thread Philippe Mathieu-Daudé
Hi Gerd, On 8/17/21 11:23 AM, Gerd Hoffmann wrote: > Add support for virtio 1.0 to the mmio transport. virtio 0.9.5 uses > page size, page frame number and a fixed layout for the ring. virtio > 1.0 uses the physical addresses for base address, used bits and > available bits instead. > > The

Re: [edk2-devel] [PATCH v3 3/4] OvmfPkg/VirtioMmioDeviceLib: Add default QueueNum for virtio 1.0

2021-08-17 Thread Philippe Mathieu-Daudé
On 8/17/21 11:23 AM, Gerd Hoffmann wrote: > Use QueueNumMax as QueueNum default for drivers which do not > explicitly call VIRTIO_DEVICE_PROTOCOL->SetQueueSize(). > > Signed-off-by: Gerd Hoffmann > --- > .../Library/VirtioMmioDeviceLib/VirtioMmioDevice.h | 1 + >

Re: [edk2-devel] [PATCH v2 2/4] OvmfPkg/VirtioMmioDeviceLib: Add virtio 1.0 support.

2021-08-16 Thread Philippe Mathieu-Daudé
On 8/16/21 3:35 PM, Yao, Jiewen wrote: > Hi Greg > Can we define MACRO to replace 1 or 2? That is very confusing. > > For example, > #define VIRT_IO_DEVICE_VERSION_0_95 1 > #define VIRT_IO_DEVICE_VERSION_1_00 2 Good idea. > > Thank you > Yao Jiewen -=-=-=-=-=-=-=-=-=-=-=- Groups.io

Re: [edk2-devel] [Patch] BaseTools: use shutil.copyfile instead shutil.copy2

2021-08-09 Thread Philippe Mathieu-Daudé
On 7/28/21 1:45 PM, Bob Feng wrote: > In Split tool, the copy file actions only need to > copy file content but not need to copy file metadata. > > copy2() copies the file metadata that causes split > unit test failed under edk2-basetools CI environment. > > So this patch changes the call of

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix the non-ascii character in UniversalPayloadEntry.c

2021-08-09 Thread Philippe Mathieu-Daudé
On 8/9/21 8:08 AM, duntan wrote: > Fix the non-ascii character in UniversalPayloadEntry.c > > Cc: Guo Dong > Cc: Ray Ni > Cc: Maurice Ma > Cc: Benjamin You > > Signed-off-by: DunTan > --- > UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [edk2-devel] [PATCH v3] OvmfPkg: Remove unused print service driver (PrintDxe)

2021-07-21 Thread Philippe Mathieu-Daudé
Ping? On 7/7/21 8:02 PM, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daude > > PrintDxe produces gEfiPrint2ProtocolGuid and gEfiPrint2SProtocolGuid, > and those are consumed by the following PrintLib instance: > > MdeModulePkg/Library/DxePrin

[edk2-devel] [PATCH v2 1/1] ArmVirtPkg: Remove meaningless comment

2021-07-21 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daude The "Shell Embedded Boot Loader" description (added in commit 6f5872b1f401) does not add any value, remove it. Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Cc: Julien Grall Suggested-by: Laszlo Ersek Signed-off-by: Philippe

Re: [edk2-devel] [PATCH] Maintainers.txt: remove Laszlo Ersek's entries

2021-07-08 Thread Philippe Mathieu-Daudé
(at their discretion). > > Cc: Andrew Fish > Cc: Ard Biesheuvel > Cc: Eric Dong > Cc: Jordan Justen > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Philippe Mathieu-Daudé > Cc: Rahul Kumar > Cc: Ray Ni > Cc: Sami Mujawar > Signed-off-by: Laszlo Erse

Re: [edk2-devel] [PATCH v2] OvmfPkg: Remove unused print service driver (PrintDxe)

2021-07-07 Thread Philippe Mathieu-Daudé
On 7/7/21 8:01 PM, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daude > > PrintDxe produces gEfiPrint2ProtocolGuid and gEfiPrint2SProtocolGuid, > and those are consumed by the following PrintLib instance: > > MdeModulePkg/Library/DxePrintLibPrint2Protocol/DxePrintLib

[edk2-devel] [PATCH v3] OvmfPkg: Remove unused print service driver (PrintDxe)

2021-07-07 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daude PrintDxe produces gEfiPrint2ProtocolGuid and gEfiPrint2SProtocolGuid, and those are consumed by the following PrintLib instance: MdeModulePkg/Library/DxePrintLibPrint2Protocol/DxePrintLibPrint2Protocol.inf However, none of the OVMF DSC files contain such a PrintLib

[edk2-devel] [PATCH v2] OvmfPkg: Remove unused print service driver (PrintDxe)

2021-07-07 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daude PrintDxe produces gEfiPrint2ProtocolGuid and gEfiPrint2SProtocolGuid, and those are consumed by the following PrintLib instance: MdeModulePkg/Library/DxePrintLibPrint2Protocol/DxePrintLibPrint2Protocol.inf However, none of the OVMF DSC files contain such a PrintLib

Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Remove unused print service driver (PrintDxe)

2021-07-07 Thread Philippe Mathieu-Daudé
On 7/6/21 6:02 PM, Laszlo Ersek wrote: > On 07/06/21 11:53, Philippe Mathieu-Daudé wrote: >> From: Philippe Mathieu-Daude >> >> The Print service driver is not used by OVMF, remove it. >> >> Cc: Laszlo Ersek >> Cc: Ard Biesheuvel >> Cc: Jordan Jus

Re: [edk2-devel] [PATCH 1/1] ArmVirtPkg: Remove meaningless comment

2021-07-07 Thread Philippe Mathieu-Daudé
On 7/6/21 5:57 PM, Laszlo Ersek wrote: > On 07/06/21 11:49, Philippe Mathieu-Daudé wrote: >> From: Philippe Mathieu-Daude >> >> The "Shell Embedded Boot Loader" description (added in >> commit 6f5872b1f401) does not add any value, remove it. >> >&g

[edk2-devel] [PATCH 1/1] OvmfPkg: Remove unused print service driver (PrintDxe)

2021-07-06 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daude The Print service driver is not used by OVMF, remove it. Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Brijesh Singh Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao Cc: Min Xu Cc: Tom Lendacky Suggested-by: Laszlo Ersek Signed-off-by:

[edk2-devel] [PATCH 1/1] ArmVirtPkg: Remove meaningless comment

2021-07-06 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daude The "Shell Embedded Boot Loader" description (added in commit 6f5872b1f401) does not add any value, remove it. Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Cc: Julien Grall Suggested-by: Laszlo Ersek Signed-off-by: Philippe

Re: [edk2-devel] [PATCH] BaseTools: Fix spelling of "overwrite" and "overwriting" in toolset.bat

2021-06-22 Thread Philippe Mathieu-Daudé
On 6/13/21 5:56 AM, Rebecca Cran wrote: > The words "overwrite" and "overwriting" are one word and shouldn't have > hyphens. > > Signed-off-by: Rebecca Cran > --- > BaseTools/toolsetup.bat | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Philippe Mathieu-Daude

Re: [edk2-devel] [PATCH 1/6] NetworkPkg/IScsiDxe: re-set session-level authentication state before login

2021-06-18 Thread Philippe Mathieu-Daudé
session-level authentication data needs to be rewound to a sane initial > state. > > Introduce the IScsiSessionResetAuthData() function. Call it from the > central -- session-level -- IScsiSessionLogin() function, just before the > latter calls the -- connection-level -- IScsiConnLogin() funct

Re: [edk2-devel] [PATCH 6/6] NetworkPkg: introduce the NETWORK_ISCSI_MD5_ENABLE feature test macro

2021-06-17 Thread Philippe Mathieu-Daudé
et requests it. With MD5 disabled, IScsiDxe will suggest > SHA256, and break off the connection (and session) if the target doesn't > support SHA256. > > Cc: Jiaxin Wu > Cc: Maciej Rabeda > Cc: Philippe Mathieu-Daudé > Cc: Siyuan Fu > Ref: https://bugzilla.tianoco

Re: [edk2-devel] [PATCH 3/6] NetworkPkg/IScsiDxe: distinguish "maximum" and "selected" CHAP digest sizes

2021-06-09 Thread Philippe Mathieu-Daudé
quot; field as well. > > This patch is functionally a no-op, just yet. > > Cc: Jiaxin Wu > Cc: Maciej Rabeda > Cc: Philippe Mathieu-Daudé > Cc: Siyuan Fu > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3355 > Signed-off-by: Laszlo Ersek >

Re: [edk2-devel] [PATCH 5/6] NetworkPkg/IScsiDxe: support SHA256 in CHAP

2021-06-09 Thread Philippe Mathieu-Daudé
D5. > > Cc: Jiaxin Wu > Cc: Maciej Rabeda > Cc: Philippe Mathieu-Daudé > Cc: Siyuan Fu > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3355 > Signed-off-by: Laszlo Ersek > --- > NetworkPkg/IScsiDxe/IScsiCHAP.h | 3 ++- > NetworkPkg/IScsiDxe/IScsiCHAP.c

Re: [edk2-devel] [PATCH 2/6] NetworkPkg/IScsiDxe: add horizontal whitespace to IScsiCHAP files

2021-06-09 Thread Philippe Mathieu-Daudé
; the patch introduces no functional changes. > > Cc: Jiaxin Wu > Cc: Maciej Rabeda > Cc: Philippe Mathieu-Daudé > Cc: Siyuan Fu > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3355 > Signed-off-by: Laszlo Ersek > --- > NetworkPkg/IScsiDxe/IScsiCHAP.h | 24 ++

Re: [edk2-devel] [PATCH 0/2] Quo vadis virtio-mmio?

2021-06-09 Thread Philippe Mathieu-Daudé
On 6/9/21 7:05 AM, Gerd Hoffmann wrote: > virtio-mmio support in ovmf seems to be the unloved child. The final > virto-1.0 specification was published five(!) years ago, nevertheless > the mmio transport doesn't support it yet ... > > Some people argue that it has been obsoleted by virtio-pci.

Re: [edk2-devel] [PATCH 00/43] OvmfPkg: remove Xen support from OvmfPkg*.dsc, in favor of OvmfXen.dsc

2021-05-31 Thread Philippe Mathieu-Daudé
On 5/27/21 10:55 AM, Laszlo Ersek wrote: > On 05/27/21 09:34, Ard Biesheuvel wrote: >> On Wed, 26 May 2021 at 22:15, Laszlo Ersek wrote: >>> >>> Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 >>> Repo: https://pagure.io/lersek/edk2.git >>> Branch: xen_split_bz_2122 >>> >>>

Re: [edk2-devel] [PATCH 42/43] OvmfPkg/SmbiosPlatformDxe: split Xen entry point from QEMU entry point

2021-05-31 Thread Philippe Mathieu-Daudé
ndependent file "Xen.c". (The existent Xen-specific C files are > arch-dependent.) :) Reviewed-by: Philippe Mathieu-Daude > Update both INF files; remove the dependencies that are now superfluous in > each. > > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Jordan Juste

Re: [edk2-devel] [PATCH 40/43] OvmfPkg/SmbiosPlatformDxe: declare InstallAllStructures() in header file

2021-05-31 Thread Philippe Mathieu-Daudé
esheuvel > Cc: Jordan Justen > Cc: Philippe Mathieu-Daudé > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.h | 11 +++ > 1 file changed, 11 insertions(+) Reviewed-by: Phil

Re: [edk2-devel] [PATCH 43/43] OvmfPkg: restrict XenPlatformLib to BdsDxe in the IA32, IA32X64, X64 DSCs

2021-05-31 Thread Philippe Mathieu-Daudé
all a XenPlatformLib API (that is, tries to re-introduce Xen > enlightenment) in a different module in these non-Xen DSC files. > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Philippe Mathieu-Daudé > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-o

Re: [edk2-devel] [PATCH 41/43] OvmfPkg/SmbiosPlatformDxe: create Xen-specific module INF file

2021-05-31 Thread Philippe Mathieu-Daudé
;. > > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Julien Grall > Cc: Philippe Mathieu-Daudé > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-off-by: Laszlo Ersek > --- > OvmfP

Re: [edk2-devel] [PATCH 39/43] OvmfPkg/SmbiosPlatformDxe: split GetXenSmbiosTables() decl. to new header

2021-05-31 Thread Philippe Mathieu-Daudé
w Fish > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Julien Grall > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Philippe Mathieu-Daudé > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-off-by: Laszlo

Re: [edk2-devel] [PATCH 29/43] OvmfPkg/PciHostBridgeLibScan: create from PciHostBridgeLib

2021-05-31 Thread Philippe Mathieu-Daudé
nd-copies-harder". Thanks for the tip :) Reviewed-by: Philippe Mathieu-Daude > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Julien Grall > Cc: Peter Grehan > Cc: Philippe Mathieu-Daudé > Cc: Rebecca Cran > Ref: https://bugzilla.t

Re: [edk2-devel] [PATCH 33/43] OvmfPkg/PciHostBridgeLibScan: remove QEMU (fw_cfg) support

2021-05-27 Thread Philippe Mathieu-Daudé
s from the library that do not depend on fw-cfg.) > > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Julien Grall > Cc: Peter Grehan > Cc: Philippe Mathieu-Daudé > Cc: Rebecca Cran > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signe

Re: [edk2-devel] [PATCH 26/43] OvmfPkg/Bhyve: remove IncompatiblePciDeviceSupport DXE driver

2021-05-27 Thread Philippe Mathieu-Daudé
on" is TRUE. > > The Bhyve platform statically assigns this PCD TRUE. Thus, remove the > driver from the Bhyve platform. > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Peter Grehan > Cc: Philippe Mathieu-Daudé > Cc: Rebecca Cran > Ref: https://bugzilla.ti

Re: [edk2-devel] [PATCH 23/43] OvmfPkg: drop PcdPciDisableBusEnumeration from the AmdSev platform

2021-05-27 Thread Philippe Mathieu-Daudé
gt; Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Min Xu > Cc: Philippe Mathieu-Daudé > Cc: Tom Lendacky > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/AmdSev/AmdSevX64.dsc | 1 - > 1 file changed, 1 deletion(-)

Re: [edk2-devel] [PATCH 21/43] OvmfPkg/PlatformPei: remove Xen support

2021-05-27 Thread Philippe Mathieu-Daudé
t;Maintainers.txt". > > This patch is best reviewed with "git show -b -W". Thanks for the tip ;) Reviewed-by: Philippe Mathieu-Daude > Cc: Andrew Fish > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Philippe

Re: [edk2-devel] [PATCH 12/43] OvmfPkg/AcpiPlatformDxe: remove the "AcpiPlatformDxe.inf" driver

2021-05-27 Thread Philippe Mathieu-Daudé
> from "AcpiPlatform.h". > > Remove "OvmfPkg/AcpiPlatformDxe/Xen.c" from the "OvmfPkg: Xen-related > modules" section of "Maintainers.txt", as well. > > Cc: Andrew Fish > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Lei

Re: [edk2-devel] [PATCH 11/43] OvmfPkg/XenAcpiPlatformDxe: create from AcpiPlatformDxe

2021-05-27 Thread Philippe Mathieu-Daudé
> > This patch should be reviewed with "git show --find-copies-harder". > > Cc: Andrew Fish > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Julien Grall > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Philippe Mathieu-Daudé

Re: [edk2-devel] [PATCH 04/43] OvmfPkg: switch the AmdSev platform to the fw_cfg-only ACPI platform driver

2021-05-27 Thread Philippe Mathieu-Daudé
mLib, so remove the > XenPlatformLib class resolution too, from the DSC file. > > Cc: Ard Biesheuvel > Cc: Brijesh Singh > Cc: Erdem Aktas > Cc: James Bottomley > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Min Xu > Cc: Philippe Mathieu-Daudé > Cc: Tom

Re: [edk2-devel] [PATCH 03/43] OvmfPkg: switch IA32, IA32X64, X64 to the fw_cfg-only ACPI platform driver

2021-05-27 Thread Philippe Mathieu-Daudé
ences: > > - https://wiki.qemu.org/Planning/1.7 > - https://wiki.qemu.org/Features/ACPITableGeneration > - edk2 commit 96bbdbc85693 ("OvmfPkg: AcpiPlatformDxe: download ACPI > tables from QEMU", 2014-03-31) > - edk2 commit 387536e472aa ("O

Re: [edk2-devel] [PATCH 15/43] OvmfPkg/XenAcpiPlatformDxe: remove the InstallAcpiTable() helper function

2021-05-27 Thread Philippe Mathieu-Daudé
n Justen > Cc: Julien Grall > Cc: Philippe Mathieu-Daudé > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/XenAcpiPlatformDxe/AcpiPlatform.h | 9 --- > OvmfPkg/XenAcpiPlatformDxe/AcpiPlatform.c | 30 ++---

Re: [edk2-devel] [edk2-devel202105 PATCH v2 1/1] ArmPkg/ArmGic: Fix maximum number of interrupts in GICv3

2021-05-27 Thread Philippe Mathieu-Daudé
On 5/24/21 3:01 PM, Sami Mujawar wrote: > From: Andreas Sandberg > > Bugzilla: 3415 (https://bugzilla.tianocore.org/show_bug.cgi?id=3415) > > The GICv3 architecture supports up to 1020 ordinary interrupt > lines. The actual number of interrupts supported is described by the > ITLinesNumber

Re: [edk2-devel] [PATCH 37/43] OvmfPkg/SmbiosPlatformDxe: return EFI_NOT_FOUND if there is no SMBIOS data

2021-05-27 Thread Philippe Mathieu-Daudé
in this case however (propagated from > gBS->LocateProtocol()). Make the return code match the documentation. > > (This issue is not too important, but it gets in the way of splitting the > entry point function next.) > > Cc: Ard Biesheuvel > Cc: Jordan Justen > C

Re: [edk2-devel] [PATCH 24/43] OvmfPkg/Bhyve: make "PcdPciDisableBusEnumeration" Fixed-at-Build

2021-05-27 Thread Philippe Mathieu-Daudé
se are out of scope for this patch > series.) > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Peter Grehan > Cc: Philippe Mathieu-Daudé > Cc: Rebecca Cran > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/

Re: [edk2-devel] [PATCH 19/43] OvmfPkg/OvmfXen: make "PcdPciDisableBusEnumeration" Fixed-at-Build

2021-05-27 Thread Philippe Mathieu-Daudé
ets the PCD to TRUE again. There > are no other writes to the PCD in the platform. > > Make the PCD Fixed-At-Build, and remove the access (in fact, the whole > InitializeXen() function) from XenPlatformPei. > > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Jordan Justen

Re: [edk2-devel] [PATCH 10/43] OvmfPkg/AcpiPlatformDxe: consolidate #includes and [LibraryClasses]

2021-05-27 Thread Philippe Mathieu-Daudé
de > directives. > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Philippe Mathieu-Daudé > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf | 1 - > OvmfPkg/A

Re: [edk2-devel] [PATCH 17/43] OvmfPkg/Bhyve/AcpiPlatformDxe: fix file path typo in comment

2021-05-27 Thread Philippe Mathieu-Daudé
en > Cc: Peter Grehan > Cc: Philippe Mathieu-Daudé > Cc: Rebecca Cran > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c | 2 +- > 1 file changed, 1 in

Re: [edk2-devel] [PATCH 16/43] OvmfPkg/XenAcpiPlatformDxe: remove OVMF's built-in ACPI tables

2021-05-27 Thread Philippe Mathieu-Daudé
pendencies from XenAcpiPlatformDxe that are no longer needed. > > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Julien Grall > Cc: Philippe Mathieu-Daudé > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-off-by: Las

Re: [edk2-devel] [PATCH 14/43] OvmfPkg/XenAcpiPlatformDxe: remove QEMU fw_cfg dependency

2021-05-27 Thread Philippe Mathieu-Daudé
eless -- the workhorse function of that source file is > QemuInstallAcpiTable(), which we no longer call. > > Remove any dependencies that are no longer needed by the > XenAcpiPlatformDxe driver. > > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Julien

Re: [edk2-devel] [PATCH 13/43] OvmfPkg/XenAcpiPlatformDxe: remove the QEMU ACPI linker/loader client

2021-05-27 Thread Philippe Mathieu-Daudé
ction call from XenAcpiPlatformDxe, > along with all dependencies that now become unused. > > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Julien Grall > Cc: Philippe Mathieu-Daudé > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Sig

Re: [edk2-devel] [PATCH 38/43] OvmfPkg/SmbiosPlatformDxe: locate SMBIOS protocol in InstallAllStructures()

2021-05-27 Thread Philippe Mathieu-Daudé
tter smaller. And that will be useful when we split the entry point > function to two versions. > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Philippe Mathieu-Daudé > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/Smb

Re: [edk2-devel] [PATCH 36/43] OvmfPkg/SmbiosPlatformDxe: clean up #includes and INF

2021-05-27 Thread Philippe Mathieu-Daudé
, drop unused #includes. > > - Keep #includes sorted. > > - Remove the leading underscore from the #include guard macro name in > "SmbiosPlatformDxe.h". > > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Julien Grall > Cc: Philip

Re: [edk2-devel] [PATCH 35/43] OvmfPkg/PciHostBridgeLibScan: clean up file names and file-top comments

2021-05-27 Thread Philippe Mathieu-Daudé
sten > Cc: Julien Grall > Cc: Peter Grehan > Cc: Philippe Mathieu-Daudé > Cc: Rebecca Cran > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/Library/PciHostBridgeLibScan/PciHostBridgeLibScan.inf

Re: [edk2-devel] [PATCH 34/43] OvmfPkg/PciHostBridgeLibScan: remove PcdOvmfHostBridgePciDevId

2021-05-27 Thread Philippe Mathieu-Daudé
this reports that the root bridge being registered does not > support extended PCI config space.) > > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Julien Grall > Cc: Peter Grehan > Cc: Philippe Mathieu-Daudé > Cc: Rebecca Cran > Ref: https://bugzil

Re: [edk2-devel] [PATCH 32/43] OvmfPkg/PciHostBridgeLib: remove Bhyve and Xen support

2021-05-27 Thread Philippe Mathieu-Daudé
t; Cc: Andrew Fish > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Philippe Mathieu-Daudé > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/Library/PciHo

Re: [edk2-devel] [PATCH 31/43] OvmfPkg/OvmfXen: consume PciHostBridgeLibScan

2021-05-27 Thread Philippe Mathieu-Daudé
ce later. > > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Julien Grall > Cc: Philippe Mathieu-Daudé > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/OvmfXen.dsc | 2 +- > 1 file cha

Re: [edk2-devel] [PATCH 30/43] OvmfPkg/Bhyve: consume PciHostBridgeLibScan

2021-05-27 Thread Philippe Mathieu-Daudé
ce later. > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Peter Grehan > Cc: Philippe Mathieu-Daudé > Cc: Rebecca Cran > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/Bhyve/BhyveX64.dsc | 2 +- > 1 fi

Re: [edk2-devel] [PATCH 28/43] OvmfPkg/PciHostBridgeLib: consolidate #includes and INF file sections

2021-05-27 Thread Philippe Mathieu-Daudé
sheuvel > Cc: Jordan Justen > Cc: Julien Grall > Cc: Philippe Mathieu-Daudé > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf | 7 +++--- > OvmfPkg/Library/PciHostB

Re: [edk2-devel] [PATCH 27/43] OvmfPkg/IncompatiblePciDeviceSupportDxe: remove PcdPciDisableBusEnumeration

2021-05-27 Thread Philippe Mathieu-Daudé
; > All those platforms inherit FALSE for "PcdPciDisableBusEnumeration" from > "MdeModulePkg.dec". > > This makes the PcdGetBool() call in the entry point of the driver > superfluous; remove it. Clean up now unused dependencies in the INF file > as well. >

Re: [edk2-devel] [PATCH 25/43] OvmfPkg/OvmfXen: remove IncompatiblePciDeviceSupport DXE driver

2021-05-27 Thread Philippe Mathieu-Daudé
ableBusEnumeration" is TRUE. > > The OvmfXen platform statically assigns this PCD TRUE. Thus, remove the > driver from the OvmfXen platform. > > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Julien Grall > Cc: Philippe Mathieu-Daudé > Ref: https://bugzi

Re: [edk2-devel] [PATCH 22/43] OvmfPkg: drop PcdPciDisableBusEnumeration from the IA32, IA32X64, X64 DSCs

2021-05-27 Thread Philippe Mathieu-Daudé
t; means we don't need a dynamic default for the PCD in the DSC files; it > could be declared Fixed-at-Build. > > However, because the PCD's default value in "MdeModulePkg.dec" is FALSE, > remove the (same-value) platform defaults altogether. > > Cc:

Re: [edk2-devel] [PATCH 20/43] OvmfPkg/XenAcpiPlatformDxe: remove delayed ACPI table installation

2021-05-27 Thread Philippe Mathieu-Daudé
t;virt" machine > configuration includes a PCIe host controller, respectively.) > > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Julien Grall > Cc: Philippe Mathieu-Daudé > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-o

  1   2   3   4   5   6   7   8   9   10   >