Sorry, I haven’t had time to look at EDK2 patches recently. I’ll spend some
time going through them tomorrow.
Rebecca
On Mon, Apr 22, 2024, at 8:29 PM, Guo, Gua wrote:
> Hi @Chiu, Chasel and @Kinney, Michael D
>
> As you know, Intel don't have owner own basetools now, may I get you
Reviewed-by: Rebecca Cran
On 3/5/2024 4:38 AM, Laszlo Ersek wrote:
The edk2-basetools commit that corresponds to edk2 commit bac9c74080cf
("BaseTools/AutoGen: declare ProcessLibraryConstructorList() for SEC
modules", 2024-02-29) is 5b7161de22ee ("BaseTools/A
Thanks.
Since Sean commented on
https://github.com/tianocore/edk2-basetools/issues/85, adding him for
more context around the original request.
--
Rebecca Cran
On 2/28/24 04:35, Gerd Hoffmann wrote:
On Wed, Feb 28, 2024 at 09:27:57AM +0100, Laszlo Ersek wrote:
On 2/28/24 02:15, Rebecca
.
Previously it fetched the list of releases from PyPI and incremented the
version number before publishing a new version, while it now depends on
the git repo being tagged.
Should I work on migrating the old code and figuring out how to make it
work with pyproject.toml?
--
Rebecca Cran
Merged as 3e91e421365027ee3e655feab33c67a4f544c777.
--
Rebecca Cran
On 2/6/24 00:02, Jayaprakash N wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4666
This commit fixes the issue reported through BZ4666.
The Syntax warning related to invalid escape sequence
for \C is seen
edk2-basetools v0.1.50 has just been published so we're back up and running.
I'll work my way through the backlog of BaseTools changes in the next
few days.
--
Rebecca Cran
On 2/24/24 13:59, Laszlo Ersek wrote:
v1 posting:
https://edk2.groups.io/g/devel/message/115193
msgid
Merged as
dae8c29dab546fad2801e70967855a9f6ae14ae0...6d571c0070161b1b96049410f8584c0955d73536
--
Rebecca Cran
On 2/18/2024 1:59 PM, Michael D Kinney via groups.io wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4679
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4680
REF
For the series:
Reviewed-by: Rebecca Cran
--
Rebecca Cran
On 2/18/2024 1:59 PM, Michael D Kinney wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4680
* Reject patches that match Author email "devel@edk2.groups.io"
* Update the current check for " via Groups
Merged as e59a40b92ce92f17e3d8d99917868c5678d408b7.
--
Rebecca Cran
On 2/12/2024 10:41 AM, Leif Lindholm via groups.io wrote:
On Sun, Feb 11, 2024 at 16:10:32 -0700, Rebecca Cran wrote:
I'm guessing there haven't been any reviews because so few people are
familiar with the PRACTICE scripting
Reviewed-by: Rebecca Cran
On 2/20/2024 9:22 PM, mikub...@linux.microsoft.com wrote:
From: Michael Kubacki
Currently, if an INF path is an absolute path on Linux (begins with
"/"), the "/" character will be removed. If the path is an absolute
system path, this cre
Invalid or non-existent authentication information. See
https://pypi.org/help/#invalid-auth for more information.
##[error]Cmd.exe exited with code '1'.
Finishing: Publish to PyPI
--
Rebecca Cran
On 2/13/24 12:42, Joey Vagedes wrote:
I agree - there are multiple blocking issues that will requ
Reviewed-by: Rebecca Cran
On 2/20/2024 8:21 AM, mikub...@linux.microsoft.com wrote:
From: Michael Kubacki
Checks that an offset used to access array elements is within the
expected range before accessing the array item.
Cc: Liming Gao
Cc: Ray Ni
Cc: Rebecca Cran
Cc: Richard Ho
Signed
Thanks. I've merged that PR, but there's another problem - the 'build'
package isn't available.
I've created another PR to fix it:
https://github.com/tianocore/edk2-basetools/pull/118
--
Rebecca Cran
On 2/23/24 07:48, Rebecca Cran wrote:
Could someone review Fix build-publish-whl
Could someone review Fix build-publish-whl-steps.yml: we no longer use
setup.py by bcran · Pull Request #117 · tianocore/edk2-basetools ·
GitHub <https://github.com/tianocore/edk2-basetools/pull/117> please?
It should be the last change needed to fix publishing releases.
--
Rebecca Cran
to require Python 3.10
Disable codecov to fix CI and due to very low coverage
--
Rebecca Cran
On 2/13/24 12:42, Joey Vagedes wrote:
I agree - there are multiple blocking issues that will require some fixes - One
additional thing I noted is that multiple areas still perform relative path
imports
I noticed the advisory at
https://github.com/advisories/GHSA-h9v6-q439-p7j2 is labeled "Unreviewed".
Should it be updated, and should the 'package', 'affected' and 'patched'
fields be updated?
--
Rebecca Cran
On 2/13/2024 11:46 AM, Doug Flick via groups.io wrote:
From:
discussion in the archive.
Similarly, I've been running an public-inbox instance at
https://openfw.io/edk2-devel/ for a while.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115522): https://edk2.groups.io/g/devel/message/1
the "Watchdog Interface
ID". Since the second "I" is for another word, should it still be
lower-case?
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114351): https://edk2.groups.io/g/devel/message/11
)
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114164): https://edk2.groups.io/g/devel/message/114164
Mute This Topic: https://groups.io/mt/103810212/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2
36F000, 1)
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114150): https://edk2.groups.io/g/devel/message/114150
Mute This Topic: https://groups.io/mt/103810212/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.
ady allocated pages.
Thanks. I'll update the script to require users to pass in the address
of the EFI_SYSTEM_TABLE instead of searching for it!
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114149): https://e
= AllocateRuntimeCopyPool (sizeof (EFI_SYSTEM_TABLE),
);
ASSERT (gDxeCoreST != NULL);
I'm wondering which is wrong: should AllocateRuntimeCopyPool be
returning a 4KB-aligned pointer, or is the script's assumption wrong?
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent
Originally posted at
https://twitter.com/UEFIForum/status/1745518769232077208
The Multi-ISA Driver Compatibility Survey is at
https://docs.google.com/forms/d/e/1FAIpQLScXjwaSBgLeqB1coEDxCPxho5JWF3AMqshOTJ2wd6Tf0He4LA/viewform
From that page:
Did you know Tiano today supports four 64-bit
table
ASSERT_EFI_ERROR (Status = Invalid Parameter)
ASSERT [SmbiosDxe]
/local-data/src/ampereone/edk2/MdePkg/Library/UefiMemoryAllocationLib/MemoryAllocationLib.c(145):
!(((INTN)(RETURN_STATUS)(Status)) < 0)
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messa
patch 2/3 to 3/3.
- Disable the watchdog in the case that EBS has been called and the timer
period is non-zero.
Rebecca Cran (3):
ArmPkg: Update GenericWatchdogDxe to allow setting full 48-bit offset
ArmPkg: Introduce global mTimerPeriod and remove calculation
ArmPkg: Disable watchdog
The calculation of the timer period was broken. Introduce a global
mTimerPeriod so the calculation can be removed. Since mTimerFrequencyHz
is only used in one place, remove the global and make it a local
variable. Do the same with mNumTimerTicks.
Signed-off-by: Rebecca Cran
---
ArmPkg/Drivers
The generic watchdog offset register is 48 bits wide, and can be set by
performing two 32-bit writes.
Add support for writing the high 16 bits of the offset register and
update the signature of the WatchdogWriteOffsetRegister function to take
a UINT64 value.
Signed-off-by: Rebecca Cran
Update GenericWatchdogDxe to disable watchdog interaction after exiting
boot services. Also, move the mEfiExitBootServicesEvent event to the top
of the file with the other static variables.
Signed-off-by: Rebecca Cran
---
ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.c | 17
obviously breaks bisect. I'll
fix it.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114019): https://edk2.groups.io/g/devel/message/114019
Mute This Topic: https://groups.io/mt/103538116/21656
Group Owner: devel+ow...@edk2
at we're now upstreaming to contribute
improvements and reduce our diffs against upstream.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114018): https://edk2.groups.io/g/devel/message/114018
Mute This Topic: https://grou
On 1/18/2024 12:04 PM, Oliver Smith-Denny wrote:
On 1/18/2024 10:45 AM, Rebecca Cran via groups.io wrote:
No, I mean SbsaQemu from edk2-platforms:
https://github.com/tianocore/edk2-platforms/tree/master/Platform/Qemu/SbsaQemu
Sure, if you can repro there that is helpful.
I've realized
for a historical issue that we are
working on reconciling with what edk2 has.
No, I mean SbsaQemu from edk2-platforms:
https://github.com/tianocore/edk2-platforms/tree/master/Platform/Qemu/SbsaQemu
To clarify, if you turn off pool guard, does the assert go away?
Yes.
--
Rebecca Cran
/Universal/SmbiosDxe/SmbiosDxe.c#L1342
And yes, that's the case I'm hitting.
I'm having trouble getting ArmVirtPkg to run. Would it be useful testing
using SbsaQemu instead?
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply
:
gEfiMdeModulePkgTokenSpaceGuid.PcdHeapGuardPropertyMask|0x0F
gEfiMdeModulePkgTokenSpaceGuid.PcdHeapGuardPageType|0xC000
gEfiMdeModulePkgTokenSpaceGuid.PcdHeapGuardPoolType|0xC000
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent
On 1/9/2024 11:52 PM, Huang, Yanbo wrote:
@Gao, Liming <mailto:gaolim...@byosoft.com.cn> @'Rebecca Cran'
<mailto:rebe...@bsdio.com>
Could you please help to merge this PR?
BaseTools: Fix raw strings containing valid escape characters by
YuweiChen1110 · Pull Request #5238 · ti
On 1/5/2024 1:26 AM, Ard Biesheuvel via groups.io wrote:
On Fri, 5 Jan 2024 at 06:15, Rebecca Cran
wrote:
Fixes and improvements to GenericWatchdogDxe.
What is the difference between v2 and v3?
Sorry, I should have said that. I forgot to build v2 and it had a bug in
the exit boot
The generic watchdog offset register is 48 bits wide, and can be set by
performing two 32-bit writes.
Add support for writing the high 16 bits of the offset register and
update the signature of the WatchdogWriteOffsetRegister function to take
a UINT64 value.
Signed-off-by: Rebecca Cran
The calculation of the timer period was broken. Introduce a global
mTimerPeriod so the calculation can be removed. Since mTimerFrequencyHz
is only used in one place, remove the global and make it a local
variable. Do the same with mNumTimerTicks.
Signed-off-by: Rebecca Cran
---
ArmPkg/Drivers
Fixes and improvements to GenericWatchdogDxe.
PR: https://github.com/tianocore/edk2/pull/5176
Rebecca Cran (3):
ArmPkg: Update GenericWatchdogDxe to allow setting full 48-bit offset
ArmPkg: Introduce global mTimerPeriod and remove calculation
ArmPkg: Disable watchdog interaction after
Update GenericWatchdogDxe to disable watchdog interaction after exiting
boot services. Also, move the mEfiExitBootServicesEvent event to the top
of the file with the other static variables.
Signed-off-by: Rebecca Cran
---
ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.c | 14
Thanks, I've incorporated the changes into the v2 patch series.
--
Rebecca
On 1/3/2024 3:56 PM, Ard Biesheuvel wrote:
Hi Rebecca,
On Wed, 3 Jan 2024 at 21:44, Rebecca Cran
wrote:
Fix the calculation of the timer period in GenericWatchdogDxe: we need
to multiply before dividing to keep
Thanks, I've incorporated the changes into the v2 patch series.
--
Rebecca
On 1/4/2024 3:01 AM, Sami Mujawar wrote:
Hi Rebecca,
Thank you for this patch.
I have some minor suggestions marked inline as [SAMI].
Regards,
Sami Mujawar
On 03/01/2024, 20:44, "Rebecca Cran" m
The calculation of the timer period was broken. Introduce a global
mTimerPeriod so the calculation can be removed. Since mTimerFrequencyHz
is only used in one place, remove the global and make it a local
variable. Do the same with mNumTimerTicks.
Signed-off-by: Rebecca Cran
---
ArmPkg/Drivers
Update GenericWatchdogDxe to disable watchdog interaction after exiting
boot services. Also, move the mEfiExitBootServicesEvent event to the top
of the file with the other static variables.
Signed-off-by: Rebecca Cran
---
ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.c | 14
Fixes and improvements to GenericWatchdogDxe.
PR: https://github.com/tianocore/edk2/pull/5176
Rebecca Cran (3):
ArmPkg: Update GenericWatchdogDxe to allow setting full 48-bit offset
ArmPkg: Introduce global mTimerPeriod and remove calculation
ArmPkg: Disable watchdog interaction after
The generic watchdog offset register is 48 bits wide, and can be set by
performing two 32-bit writes.
Add support for writing the high 16 bits of the offset register and
update the signature of the WatchdogWriteOffsetRegister function to take
a UINT64 value.
Signed-off-by: Rebecca Cran
Switches regex patterns to raw text to resolve python 3.12 syntax
warnings in regards to invalid escape sequences, as is suggested by the
re (regex) module in python.
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Cc: Yuwei Chen
Signed-off-by: Joey Vagedes
Wouldn't it be better to add the Stack Protector library
(MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf) instead of
disabling it?
--
Rebecca Cran
On 1/4/2024 11:49 AM, Prabin CA via groups.io wrote:
Add the no-stack-protector compiler flag to allow StandaloneMM builds
on both
Fix the calculation of the timer period in GenericWatchdogDxe: we need
to multiply before dividing to keep the values as integers.
Signed-off-by: Rebecca Cran
---
ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Update GenericWatchdogDxe to disable watchdog interaction after exiting
boot services. Also, move the mEfiExitBootServicesEvent event to the top
of the file with the other static variables.
Signed-off-by: Rebecca Cran
---
ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.c | 14
The generic watchdog offset register is 48 bits wide, and can be set by
performing two 32-bit writes.
Add support for writing the high 16 bits of the offset register and
update the signature of the WatchdogWriteOffsetRegister function to take
a UINT64 value.
Signed-off-by: Rebecca Cran
Fixes and improvements to GenericWatchdogDxe.
PR: https://github.com/tianocore/edk2/pull/5176
Rebecca Cran (3):
ArmPkg: Update GenericWatchdogDxe to allow setting full 48-bit offset
ArmPkg: Fix the calculation of the timer period in GenericWatchdogDxe
ArmPkg: Disable watchdog interaction
. the re module
in python suggests that when creating regex patterns, to use raw text.
This patch series adds the r prefix to any regex pattern that uses an
invalid escape sequence.
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Cc: Yuwei Chen
Signed-off-by: Joey Vagedes
Joey Vagedes (1
I see two patches with the same subject line sent within about 15
minutes of each other.
Could you confirm whether I should review this one (1:43am) or the other
(1:27am) please?
Thanks.
Rebecca Cran
On 12/12/2023 1:43 AM, Yuting Yang wrote:
Add --catch_default option
Raise
Thanks.
Reviewed-by: Rebecca Cran
--
Rebecca Cran
On 12/6/2023 1:27 PM, Joey Vagedes wrote:
Switches regex patterns to raw text to resolve python 3.12 syntax
warnings in regards to invalid escape sequences, as is suggested by the
re (regex) module in python.
Cc: Rebecca Cran
Cc: Liming Gao
Reviewed-by: Rebecca Cran
--
Rebecca Cran
On 12/12/2023 2:38 AM, Pierre Gondois wrote:
Hello BaseTools maintainers,
Just a ping in case you have any comment for this patch,
Regards,
Pierre
On 11/29/23 10:37, Sami Mujawar wrote:
Hi Ray,
On 29/11/2023, 00:56, "Ni, Ray" <mailto:r
Queued as https://github.com/tianocore/edk2/pull/5177 .
On 12/19/2023 6:02 AM, gaoliming wrote:
The change is good.
Reviewed-by: Liming Gao
-邮件原件-
发件人: devel@edk2.groups.io 代表 Guo, Gua
发送时间: 2023年12月19日 15:32
收件人: devel@edk2.groups.io; Chen, Christine ;
Rebecca Cran ; Gao, Liming
Reviewed-by: Rebecca Cran
On 12/15/2023 2:11 AM, Yuwei Chen wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4624
Currently, Python FMMT tool does not support automatically
select FMMTConf.ini file which saves GuidTool settings.
This patch supports this features.
Cc: Rebecca Cran
Reviewed-by: Rebecca Cran
On 12/20/2023 12:31 PM, Jake Garver wrote:
In the R_AARCH64_ADR_GOT_PAGE case on AARCH64, we may encounter an ADR
instead of an ADRP when the toolchain is working around Cortex-A53
erratum #843419. If that's the case, be sure to calculate the offset
appropriately
think to follow the style guide, it should have a "" at the end,
though most files with copyrights from individuals don't have that.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112635): https://edk2.g
Could someone push these changes to the edk2-test repo please?
On 11/10/2023 12:08 PM, Rebecca Cran wrote:
Some improvements to the edk2-test repository.
Since buildzip.sh creates output that appears more useful for running on
the target machine, I wonder if we might want to mention
On 4/7/2023 10:58 AM, Rebecca Cran wrote:
Could I get some reviews on this please? It was sent out back in
February.
I'm not sure how we should solve the CI breakage, since as I noted in
the v1 revision it contains fields that begin with a lower-case letter
following the style of the DDR4
On 12/11/2023 6:17 PM, Laszlo Ersek wrote:
On 12/9/23 01:33, Rebecca Cran via groups.io wrote:
On 12/8/2023 5:19 PM, Rebecca Cran wrote:
Add the new DEBUG_MANAGEABILITY debug level to MdePkg.dec and MdePkg.uni.
Improve the wording of the description of the DEBUG_MANAGEABILITY
level
I don't appear to have permission to push to the edk2-test repo.
Could somebody merge my change please?
Thanks.
Rebecca
On 11/10/2023 12:08 PM, Rebecca Cran wrote:
Some improvements to the edk2-test repository.
Since buildzip.sh creates output that appears more useful for running
On 11/29/2023 1:06 AM, G Edhaya Chandran wrote:
Hi Rebecca,
Thank you for these updates.
Just a matter of style, but can we do HowToBuild*SCT*.txt instead of
HowToBuild*Sct*.txt?
Sure! I can make that change just before I push the series.
--
Rebecca Cran
On 12/8/2023 5:19 PM, Rebecca Cran wrote:
Add the new DEBUG_MANAGEABILITY debug level to MdePkg.dec and MdePkg.uni.
Improve the wording of the description of the DEBUG_MANAGEABILITY level in
DebugLib.h.
Update the comment block in ArmVirtPkg.dsc.inc with the new list and updated
formatting
Update the debug level comments in ArmVirt.dsc.inc to sync with
MdePkg/Include/Library/DebugLib.h.
Signed-off-by: Rebecca Cran
---
ArmVirtPkg/ArmVirt.dsc.inc | 42 ++--
1 file changed, 22 insertions(+), 20 deletions(-)
diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg
Update MdePkg.dec to add the manageability debug level to
PcdFixedDebugPrintErrorLevel.
Signed-off-by: Rebecca Cran
---
MdePkg/MdePkg.dec | 1 +
1 file changed, 1 insertion(+)
diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec
index ac54338089e8..bec63f5416e2 100644
--- a/MdePkg/MdePkg.dec
Add the new DEBUG_MANAGEABILITY debug level to MdePkg.dec and MdePkg.uni.
Improve the wording of the description of the DEBUG_MANAGEABILITY level in
DebugLib.h.
Update the comment block in ArmVirtPkg.dsc.inc with the new list and updated
formatting.
Rebecca Cran (4):
MdePkg: Improve wording
Update MdePkg.uni with the manageability debug level.
Signed-off-by: Rebecca Cran
---
MdePkg/MdePkg.uni | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MdePkg/MdePkg.uni b/MdePkg/MdePkg.uni
index 5c1fa24065c7..75dbc6ffe3c0 100644
--- a/MdePkg/MdePkg.uni
+++ b/MdePkg/MdePkg.uni
@@ -214,6
Improve the wording of the comment explaining the DEBUG_MANAGEABILITY
debug level.
Signed-off-by: Rebecca Cran
---
MdePkg/Include/Library/DebugLib.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MdePkg/Include/Library/DebugLib.h
b/MdePkg/Include/Library/DebugLib.h
know why it's causing
issues yet. However, using the same IO port range in EDKII fixes the
issue and is a good idea anyway.
Reviewed-by: Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111408): https://edk2.groups.io/g/devel
On 11/14/2023 7:51 AM, Laszlo Ersek via groups.io wrote:
Funnily enough, my stance is quite the opposite. I happen to disagree
with some patterns that uncrustify enforces, but I'm thankful that at
any given state of CI (= using any given version of uncrustify), we
can't have any more debates
/introducing_black_to_your_project.html#avoiding-ruining-git-blame
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79): https://edk2.groups.io/g/devel/message/79
Mute This Topic: https://groups.io/mt/102559740/21656
Group Owner: devel+ow
BaseTools (including porting existing code to Python), and adding
edk2-uncrustify would work against that.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#76): https://edk2.groups.io/g/devel/message/76
Mute
For the series:
Acked-by: Rebecca Cran
On 11/10/23 12:30, Leif Lindholm wrote:
OK, so this a bit of a backwards review, but I figured I might as
well show how I would prefer the split. I'm adding a patch that
changes internal returns to dictionaries instead of multiple return
values
Fix the URL for the edk2-test repo: the uefi-sct is a directory inside
the repo.
Signed-off-by: Rebecca Cran
Contributed-under: TianoCore Contribution Agreement 1.1
---
Maintainers.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index
If edk2-test-parser doesn't exist, tell the user where they can clone it
from.
Signed-off-by: Rebecca Cran
Contributed-under: TianoCore Contribution Agreement 1.1
---
uefi-sct/SctPkg/buildzip.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/uefi-sct/SctPkg/buildzip.sh b/uefi-sct/SctPkg
Rename the text files in the HowToBuild directory to remove the spaces
and use CamelCase instead.
Signed-off-by: Rebecca Cran
Contributed-under: TianoCore Contribution Agreement 1.1
---
uefi-sct/HowToBuild/{How to accelerate SCT execution.txt =>
HowToAccelerateSctExecution.txt} | 0
uefi-
Unbreak buildzip.sh by removing the line sourcing edksetup.sh: unless
WORKSPACE and PACKAGES_PATH are already configured, edksetup.sh will
error out.
Signed-off-by: Rebecca Cran
Contributed-under: TianoCore Contribution Agreement 1.1
---
uefi-sct/SctPkg/buildzip.sh | 3 ---
1 file changed, 3
to buildzip.sh
Rebecca Cran (4):
Unbreak buildzip.sh
Rename files in HowToBuild to avoid spaces in filenames
Point users to the URL for edk2-test-parser if it doesn't exist
Fix the URL for the edk2-test repo
Maintainers.txt
It looks like Maintainers.txt also needs to be updated since I got
bounces from Eric Jin and Arvin Chen's email addresses.
On 11/10/23 12:01, Rebecca Cran wrote:
Some improvements to the edk2-test repository.
Since buildzip.sh creates output that appears more useful for running on
the target
Fix the URL for the edk2-test repo: the uefi-sct is a directory inside
the repo.
Signed-off-by: Rebecca Cran
Contributed-under: TianoCore Contribution Agreement 1.1
---
Maintainers.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index
If edk2-test-parser doesn't exist, tell the user where they can clone it
from.
Signed-off-by: Rebecca Cran
Contributed-under: TianoCore Contribution Agreement 1.1
---
uefi-sct/SctPkg/buildzip.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/uefi-sct/SctPkg/buildzip.sh b/uefi-sct/SctPkg
Unbreak buildzip.sh by removing the line sourcing edksetup.sh: unless
WORKSPACE and PACKAGES_PATH are already configured, edksetup.sh will
error out.
Signed-off-by: Rebecca Cran
Contributed-under: TianoCore Contribution Agreement 1.1
---
uefi-sct/SctPkg/buildzip.sh | 3 ---
1 file changed, 3
Rename the text files in the HowToBuild directory to remove the spaces
and use CamelCase instead.
Signed-off-by: Rebecca Cran
Contributed-under: TianoCore Contribution Agreement 1.1
---
uefi-sct/HowToBuild/{How to accelerate SCT execution.txt =>
HowToAccelerateSctExecution.txt} | 0
uefi-
we delete it?
Finally, is the TianoCore Contribution Agreement still relevant? I know
it is for the edk2 docs repositories, but not sure if edk2-test should
be updated to match the other code repos like edk2 and edk2-platforms?
Rebecca Cran (4):
Unbreak buildzip.sh
Rename files in HowToBuild
Reviewed-by: Rebecca Cran
On 10/31/2023 12:23 AM, Joey Vagedes wrote:
Resolves an invalid escape sequence in a regex string that occurs
because the string was not marked as a raw string, so backslash
characters create unexpected escape sequences.
This was brought to light due to Python 3.12
EFI_IMAGE_SCN_MEM_EXECUTE and EFI_IMAGE_SCN_MEM_WRITE
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Cc: Yuwei Chen
Joey Vagedes (2):
MdePkg: IndustryStandard: Add DLL Characteristics
BaseTools: GenFw: auto-set nxcompat flag
MdePkg/Include/IndustryStandard/PeImage.h| 17 +-
BaseTools
Reviewed-by: Rebecca Cran
--
Rebecca Cran
On 11/6/2023 1:12 PM, Joey Vagedes wrote:
Clarify to users that they should review the build log when make
(POSIX-like system) or nmake (Windows) fails to compile basetools.
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Cc: Yuwei Chen
Signed-off
just has one watcher, Jordan,
so I'd guess he did set it up.
It has two forks, neither of which have been updated recently:
https://bitbucket.org/kevintruong/edk2/src/master/ (last updated:
2015-04-18)
https://bitbucket.org/cn_taoye/edk2/src/master/ (last updated: 2015-11-11
I just noticed the Bitbucket mirror that's listed in Maintainers.txt
hasn't had any new commits since March 2022.
EDK II
--
W: http://www.tianocore.org/edk2/
L: https://edk2.groups.io/g/devel/
T: git - https://github.com/tianocore/edk2.git
T: git (mirror) -
Liming, could you review this please? It's blocking another patch from
being committed.
--
Rebecca
On 11/1/2023 6:20 PM, Rebecca Cran wrote:
Allow .rtf files created by applications such as Notepad to be committed
as-is without further manual editing by skipping the requirements for
CRLF
I'm still working on this! The last hurdle is fixing PatchCheck.py to
allow .rtf files written by Notepad etc. to be committed as-is, without
requiring line endings to be fixed, trailing whitespace to be removed etc.
Once that's in, I'll merge these two patches.
--
Rebecca Cran
On 10/17
Allow .rtf files created by applications such as Notepad to be committed
as-is without further manual editing by skipping the requirements for
CRLF, no tabs and no trailing whitespace.
Signed-off-by: Rebecca Cran
---
BaseTools/Scripts/PatchCheck.py | 5 -
1 file changed, 4 insertions(+), 1
++--
BaseTools/Plugin/DebugMacroCheck/BuildPlugin/DebugMacroCheckBuildPlugin.py |
10 +-
pip-requirements.txt|
4 ++--
4 files changed, 17 insertions(+), 16 deletions(-)
For the series:
Reviewed-by: Rebecca Cran
--
Rebecca Cran
Reviewed-by: Rebecca Cran
--
Rebecca Cran
On 10/12/23 11:11, levi.yun wrote:
The patch "[PATCH v3 1/2] StandaloneMmPkg: Make StandaloneMmCpu driver
architecture independent" (https://edk2.groups.io/g/devel/message/109178)
removed ArmPkg/ArmPkg.dec from the Packages section in th
Reviewed-by: Rebecca Cran
On 9/22/23 00:47, Yuwei Chen wrote:
As the error is changed to warning, Trim.py will skip the build
error when the source code have exactly issue.
This patch change warning to error to opens the checking.
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Signed-off
Thanks! Since you're okay with it, as a BaseTools maintainer I'll go
ahead with that plan.
--
Rebecca
On 10/17/23 13:56, Joey Vagedes wrote:
While I’m not a maintainer, so I don’t have much say - I don’t see an
issue with your solution that rewrites the entire file as the small
change I
MdePkg maintainers: could you review this, and I'll be happy to
merge/commit it.
--
Rebecca Cran
On 7/13/23 09:24, Joey Vagedes via groups.io wrote:
Add the bit masks for DLL Characteristics, used within the optional
header of a PE, to the PeImage.h header file.
Update the Visual Studio
1 - 100 of 1512 matches
Mail list logo
