On 10/25/23 10:35, Laszlo Ersek wrote:
> Email to Isaac's address bounces ("5.1.0 Address
> rejected"); remove that address.
>
> Cc: Abdul Lateef Attar
> Cc: Abner Chang
> Cc: Ashraf Ali S
> Cc: Chasel Chiu
> Cc: Eric Dong
> Cc: Liming Gao
> Cc: Nate DeSimone
> Cc: Nickle Wang
> Cc:
On 10/27/23 18:27, Jayaprakash, N wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4580
>
> This BZ has been created to provide the sample python scripts
> to demonstrate the socket client capabilities using http library
> on UEFI shell with the help of Python UEFI interpreter.
> The
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4580
This BZ has been created to provide the sample python scripts
to demonstrate the socket client capabilities using http library
on UEFI shell with the help of Python UEFI interpreter.
The http_echo_client.py and http_echo_server.py scripts
This commit provides 2 sample scripts namely
http_echo_client.py and http_echo_server.py to exercise the
socket capabilities on UEFI shell using the http library from Python UEFI
interpreter.
Jayaprakash N (1):
ek2-libc: Sample python scripts for socket client capabilities on UEFI
shell
ickle Wang
> Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/2] ManageabilityPkg/Ipmi:
> Remove IpmiCommandLib.h from ManageabilityPkg
>
> [AMD Official Use Only - General]
>
> Caution: This message originated from an External Source. Use proper caution
> when opening
Reviewed-by : Jayaprakash Nevara
Regards,
JP
-Original Message-
From: devel@edk2.groups.io On Behalf Of Jayaprakash, N
Sent: Thursday, October 26, 2023 9:00 PM
To: devel@edk2.groups.io
Cc: Jayaprakash, N
Subject: [edk2-devel] [edk2-libc Patch 0/1] fix missing nanf definition
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Mike Maslenkin
> Sent: Friday, October 27, 2023 7:54 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; nick...@nvidia.com;
> ig...@ami.com; Mike Maslenkin
> Subject: [edk2-redfish-client][PATCH v2
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Mike Maslenkin
> Sent: Friday, October 27, 2023 7:54 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; nick...@nvidia.com;
> ig...@ami.com; Mike Maslenkin
> Subject: [edk2-redfish-client][PATCH v2
l@edk2.groups.io On Behalf Of Chang,
> Abner via groups.io
> Sent: Wednesday, October 18, 2023 12:53 PM
> To: devel@edk2.groups.io; Chang, Abner
> Cc: Attar, AbdulLateef (Abdul Lateef) ; Isaac
> Oram ; Nickle Wang ; Nate
> DeSimone ; Liming Gao
>
> Subject: Re: [edk2-dev
Signed-off-by: Mike Maslenkin
---
.../RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c
b/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c
Signed-off-by: Mike Maslenkin
---
.../RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c
b/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c
index
Signed-off-by: Mike Maslenkin
---
RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosData.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosData.h
b/RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosData.h
index
StrnCpyS accepts string length in characters, not in bytes.
Signed-off-by: Mike Maslenkin
---
RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c
This patch fixes leak in RedfishExternalResourceResourceFeatureCallback
function.
Signed-off-by: Mike Maslenkin
---
RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c
This functions contain memory leaks.
Less identation helps to solve this issues.
Signed-off-by: Mike Maslenkin
---
.../RedfishFeatureUtilityLib.c| 289 +-
1 file changed, 146 insertions(+), 143 deletions(-)
diff --git
Signed-off-by: Mike Maslenkin
---
.../RedfishFeatureUtilityLib.c| 11 +++
1 file changed, 11 insertions(+)
diff --git
a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c
Signed-off-by: Mike Maslenkin
---
.../RedfishFeatureUtilityLib.c| 30 +++
1 file changed, 30 insertions(+)
diff --git
a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c
Signed-off-by: Mike Maslenkin
---
.../RedfishFeatureUtilityLib.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git
a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c
Memory allocated by calloc() is filled with bytes of value zero.
Signed-off-by: Mike Maslenkin
---
.../PrivateLibrary/RedfishLib/edk2libredfish/src/service.c | 1 -
1 file changed, 1 deletion(-)
diff --git
a/RedfishClientPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/service.c
This patchset contains fixes of wrong format and number of arguments
passed to DEBUG macro.
Also a number of memory leaks were fixed.
Here is a link to PR:
https://github.com/tianocore/edk2-redfish-client/pull/52
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike
Signed-off-by: Mike Maslenkin
---
RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c
b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c
index
On Thu, Oct 26, 2023 at 16:35:52 +0100, Leif Lindholm wrote:
> On Wed, Oct 11, 2023 at 10:53:20 -0700, ndhil...@marvell.com wrote:
> > From: Narinder Dhillon
> >
> > Current Marvell package structure makes it difficult to add new silicon
> > packages that reuse common elements without creating
On 10/26/23 16:17, Jayaprakash, N wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4574
>
> This commit is for processing the below PR on edk2-libc repo
> https://github.com/tianocore/edk2-libc/pull/10
> The realpath function signature in stdlib of edk2-libc doesn't match
> signature
On Wed, Oct 11, 2023 at 10:53:20 -0700, ndhil...@marvell.com wrote:
> From: Narinder Dhillon
>
> Current Marvell package structure makes it difficult to add new silicon
> packages that reuse common elements without creating nested DEC files.
>
> This patch creates a new MarvellSiliconPkg folder
Reviewed-by: Jayaprakash Nevara
It's simple fix to align the function signature as per the standards.
Regards,
JP
-Original Message-
From: Jayaprakash, N
Sent: Thursday, October 26, 2023 7:47 PM
To: devel@edk2.groups.io
Cc: Jayaprakash, N ; Rebecca Cran ;
Kinney, Michael D ; Kloper,
This patch fixes the issue of missing definition of nanf in StdLib.
This has been extracted from the below PR submitted on edk2-libc.
https://github.com/tianocore/edk2-libc/pull/9
Jayaprakash N (1):
ek2-libc: fix missing nanf definition in StdLib
StdLib/LibC/LibC.inf| 1 +
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4576
File StdLib/Include/math.h:406 defines NAN constant as __nanf.__val.
The problem is that __nanf is never defined.
Fix is simple: define __nanf in similar way as __infinityf
This fix has been provided through the below PR on edk2-libc repo
Hi Nharinder,
Apologies for delay in responding - this was sent out during UEFI
plugfest, and then I brought home a cold from there.
On Wed, Oct 11, 2023 at 10:53:20 -0700, ndhil...@marvell.com wrote:
> From: Narinder Dhillon
>
> Current Marvell package structure makes it difficult to add new
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4574
This commit is for processing the below PR on edk2-libc repo
https://github.com/tianocore/edk2-libc/pull/10
The realpath function signature in stdlib of edk2-libc doesn't match
signature as per the standard definition of this function given
This patch fixes the function signature of realpath to match with the standard
defined signature. This patch bas been extracted from the below pull request
raised on edk2-libc.
https://github.com/tianocore/edk2-libc/pull/10
Jayaprakash N (1):
ek2-libc: realpath function signature doesn't
2.groups.io; ler...@redhat.com
>> Cc: Attar, AbdulLateef (Abdul Lateef) ; Chang,
>> Abner ; Ashraf Ali S ;
>> Chasel Chiu ; Eric Dong ;
>> Liming Gao ; Nate DeSimone
>> ; Nickle Wang ;
>> Rangasai V Chaganty ; Ray Ni
>> ; Theo Jehl
>> Subject: R
On 10/26/23 10:06, Chang, Abner via groups.io wrote:
> From: Abner Chang
>
> Run Uncrustify on the C source files those were
> modified in commit ID from 3f4c4384 to 28ff8f29.
>
> Signed-off-by: Abner Chang
> Cc: Abdul Lateef Attar
> Cc: Nickle Wang
> Cc: Konstantin Aladyshev
> ---
>
Update RedfishLib to align with RedfishLib in edk2 repository.
RedfishLib commits on edk2:
cf68ff61 RedfishPkg/RedfishLib: introduce new interfaces.
1cbdd6e9 RedfishPkg/libredfish: introduce new interfaces.
8765f3eb RedfishPkg/RedfishLib: return HTTP headers to caller.
Signed-off-by: Nickle Wang
Update RedfishLib to align with RedfishLib in edk2 repository.
RedfishLib commits on edk2:
cf68ff61 RedfishPkg/RedfishLib: introduce new interfaces.
1cbdd6e9 RedfishPkg/libredfish: introduce new interfaces.
8765f3eb RedfishPkg/RedfishLib: return HTTP headers to caller.
Signed-off-by: Nickle Wang
From: Abner Chang
Run Uncrustify on the C source files those were
modified in commit ID from 3f4c4384 to 28ff8f29.
Signed-off-by: Abner Chang
Cc: Abdul Lateef Attar
Cc: Nickle Wang
Cc: Konstantin Aladyshev
---
.../Include/Library/BasePldmProtocolLib.h | 6 ++---
Chang,
> Abner ; Ashraf Ali S ;
> Chasel Chiu ; Eric Dong ;
> Liming Gao ; Nate DeSimone
> ; Nickle Wang ;
> Rangasai V Chaganty ; Ray Ni
> ; Theo Jehl
> Subject: Re: [edk2-devel] [edk2-platforms PATCH] Maintainers.txt: remove
> Isaac Oram's email address
>
> Caut
On Wed, Oct 25, 2023 at 9:35 AM Laszlo Ersek wrote:
>
> Email to Isaac's address bounces ("5.1.0 Address
> rejected"); remove that address.
FWIW, there's a patch in the ML list (by Nate IIRC?) that never got
merged that addresses this very issue, with proposed replacements.
--
Pedro
Reviewed-by: Sai Chaganty
-Original Message-
From: Laszlo Ersek
Sent: Wednesday, October 25, 2023 1:36 AM
To: edk2-devel-groups-io
Cc: Abdul Lateef Attar ; Abner Chang
; S, Ashraf Ali ; Chiu, Chasel
; Dong, Eric ; Gao, Liming
; Desimone, Nathaniel L
; Nickle Wang ; Pedro
Falcato
ng, Eric ; Gao,
> Liming ; Desimone, Nathaniel L
> ; Nickle Wang ;
> Pedro Falcato ; Chaganty, Rangasai V
> ; Ni, Ray ; Theo Jehl
>
> Subject: [edk2-devel] [edk2-platforms PATCH] Maintainers.txt: remove
> Isaac Oram's email address
>
> Email to Isaac's address bounces
With the fact that CSM is not supported,
the request is to remove the cache setting for memory under 1MB.
This can be treated as the missing part of legacy CSM deprecation.
This patch only set the 0 to 9 and C to F as Write Back.
A-B range is still uncacheable for VGA.
Reviewed-by: Ashraf Ali S
Thanks.,
S, Ashraf Ali
-Original Message-
From: Laszlo Ersek
Sent: Wednesday, October 25, 2023 2:06 PM
To: edk2-devel-groups-io
Cc: Abdul Lateef Attar ; Abner Chang
; S, Ashraf Ali ; Chiu, Chasel
; Dong, Eric ; Gao, Liming
; Desimone, Nathaniel L
;
Email to Isaac's address bounces ("5.1.0 Address
rejected"); remove that address.
Cc: Abdul Lateef Attar
Cc: Abner Chang
Cc: Ashraf Ali S
Cc: Chasel Chiu
Cc: Eric Dong
Cc: Liming Gao
Cc: Nate DeSimone
Cc: Nickle Wang
Cc: Pedro Falcato
Cc: Rangasai V Chaganty
Cc: Ray Ni
Cc: Sai
On 10/20/23 14:18, Laszlo Ersek wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=4565
>
> RealTimeClockLib instances should neither set gRT fields nor install
> EFI_REAL_TIME_CLOCK_ARCH_PROTOCOL in LibRtcInitialize();
> EmbeddedPkg/RealTimeClockRuntimeDxe already performs those actions.
>
On the whole, I find edk2-libc creates more problems than it solves. So
I will not be reviewing patches for it.
/
Leif
On 2023-10-20 20:54, Michael D Kinney wrote:
+Ard
+Leif
-Original Message-
From: Jayaprakash, N
Sent: Friday, October 20, 2023 7:04 AM
To:
Hi Laszlo,
This change is look good to me and I will take this change into
edk2/OvmfPkg/LoongArchVirt/ which I'm porting. Thanks.
Reviewed-by: Chao Li
Thanks,
Chao
在 2023/10/20 20:18, Laszlo Ersek 写道:
RealTimeClockLib instances are consumed by edk2's
EmbeddedPkg/RealTimeClockRuntimeDxe
You can build edk2-libc Python 3.6.8 using GCC tool chain by following the BKMs
documented in this file
https://github.com/tianocore/edk2-libc/blob/master/AppPkg/Applications/Python/Python-3.6.8/GCCCompilationBKMs.rst
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to
; Jayaprakash, N
Cc: Rebecca Cran ; Kinney, Michael D
; Tyler Erickson ; Ard
Biesheuvel ; Leif Lindholm
Subject: Re: [edk2-devel] [edk2-libc Patch 1/1] ek2-libc: Enhance StdLib for
supporting Aarch64 and ARM
On Fri, Oct 20, 2023 at 3:04 PM Jayaprakash, N wrote:
>
> REF:
On Fri, Oct 20, 2023 at 3:04 PM Jayaprakash, N wrote:
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4570
>
> This commit is for processing the below PR on edk2-libc repo
> https://github.com/tianocore/edk2-libc/pull/3
> These are the changes introduced to StdLib to build
> an
+Ard
+Leif
> -Original Message-
> From: Jayaprakash, N
> Sent: Friday, October 20, 2023 7:04 AM
> To: devel@edk2.groups.io
> Cc: Jayaprakash, N ; Rebecca Cran
> ; Kinney, Michael D ;
> Tyler Erickson
> Subject: [edk2-libc Patch 1/1] ek2-libc: Enhance StdLib for supporting
> Aarch64 and
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4570
This commit is for processing the below PR on edk2-libc repo
https://github.com/tianocore/edk2-libc/pull/3
These are the changes introduced to StdLib to build
an application for the UEFI shell.
Added format macros for int types to Aarch64,
This patch request contains enhancements made to StdLibc
through BZ https://bugzilla.tianocore.org/show_bug.cgi?id=4570
Jayaprakash N (1):
ek2-libc: Enhance StdLib for supporting Aarch64 and ARM
StdLib/Include/Aarch64/machine/int_fmtio.h | 211 +
On Fri, 20 Oct 2023 at 14:19, Laszlo Ersek wrote:
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=4565
>
> RealTimeClockLib instances should neither set gRT fields nor install
> EFI_REAL_TIME_CLOCK_ARCH_PROTOCOL in LibRtcInitialize();
> EmbeddedPkg/RealTimeClockRuntimeDxe already performs
RealTimeClockLib instances are consumed by edk2's
EmbeddedPkg/RealTimeClockRuntimeDxe driver. In its entry point function
InitializeRealTimeClock(), the driver:
(1) calls LibRtcInitialize(),
(2) sets the GetTime(), SetTime(), GetWakeupTime() and SetWakeupTime()
runtime services to its own
RealTimeClockLib instances are consumed by edk2's
EmbeddedPkg/RealTimeClockRuntimeDxe driver. In its entry point function
InitializeRealTimeClock(), the driver:
(1) calls LibRtcInitialize(),
(2) sets the GetTime(), SetTime(), GetWakeupTime() and SetWakeupTime()
runtime services to its own
RealTimeClockLib instances are consumed by edk2's
EmbeddedPkg/RealTimeClockRuntimeDxe driver. In its entry point function
InitializeRealTimeClock(), the driver:
(1) calls LibRtcInitialize(),
(2) sets the GetTime(), SetTime(), GetWakeupTime() and SetWakeupTime()
runtime services to its own
RealTimeClockLib instances are consumed by edk2's
EmbeddedPkg/RealTimeClockRuntimeDxe driver. In its entry point function
InitializeRealTimeClock(), the driver:
(1) calls LibRtcInitialize(),
(2) sets the GetTime(), SetTime(), GetWakeupTime() and SetWakeupTime()
runtime services to its own
RealTimeClockLib instances are consumed by edk2's
EmbeddedPkg/RealTimeClockRuntimeDxe driver. In its entry point function
InitializeRealTimeClock(), the driver:
(1) calls LibRtcInitialize(),
(2) sets the GetTime(), SetTime(), GetWakeupTime() and SetWakeupTime()
runtime services to its own
RealTimeClockLib instances are consumed by edk2's
EmbeddedPkg/RealTimeClockRuntimeDxe driver. In its entry point function
InitializeRealTimeClock(), the driver:
(1) calls LibRtcInitialize(),
(2) sets the GetTime(), SetTime(), GetWakeupTime() and SetWakeupTime()
runtime services to its own
https://bugzilla.tianocore.org/show_bug.cgi?id=4565
RealTimeClockLib instances should neither set gRT fields nor install
EFI_REAL_TIME_CLOCK_ARCH_PROTOCOL in LibRtcInitialize();
EmbeddedPkg/RealTimeClockRuntimeDxe already performs those actions.
Cc: Ard Biesheuvel
Cc: Bibo Mao
Cc: Chao Li
Cc:
RealTimeClockLib instances are consumed by edk2's
EmbeddedPkg/RealTimeClockRuntimeDxe driver. In its entry point function
InitializeRealTimeClock(), the driver:
(1) calls LibRtcInitialize(),
(2) sets the GetTime(), SetTime(), GetWakeupTime() and SetWakeupTime()
runtime services to its own
-
> > From: Chang, Abner
> > Sent: Wednesday, October 18, 2023 10:49 AM
> > To: Konstantin Aladyshev
> > Subject: RE: [edk2-devel] [edk2-discuss] PLDM messages via MCTP over KCS
> >
> > Sure, this works for me. I will update the code.
> >
> > Thank
Attar, AbdulLateef (Abdul Lateef) ; Isaac
> Oram ; Nickle Wang ; Nate
> DeSimone
> Subject: [edk2-devel] [edk2-platforms][PATCH 2/2]
> OutOfBandManagement/IpmiFeaturePKg: Remove IpmiCommandLib.h from
> IpmiFeaturePkg
>
> Caution: This message originated from an External So
Attar, AbdulLateef (Abdul Lateef) ; Isaac
> Oram ; Nickle Wang
> Subject: [edk2-devel] [edk2-platforms][PATCH 1/2] ManageabilityPkg/Ipmi:
> Remove IpmiCommandLib.h from ManageabilityPkg
>
> Caution: This message originated from an External Source. Use proper caution
> when
On 10/17/23 13:38, Nhi Pham via groups.io wrote:
> Thanks, Laszlo for this patch.
>
> Reviewed-by: Nhi Pham
>
> Regards,
> Nhi
Thank you both for reviewing; commit 7f3e7fc0b4ed.
Laszlo
>
> On 10/17/2023 5:05 PM, Laszlo Ersek via groups.io wrote:
>> Nhi says that reading
Thanks, Laszlo for this patch.
Reviewed-by: Nhi Pham
Regards,
Nhi
On 10/17/2023 5:05 PM, Laszlo Ersek via groups.io wrote:
Nhi says that reading LINK_CONTROL_LINK_STATUS_REG is redundant; its only
use was debugging (before commit 380b4b40c60d). Thus, we can go farther
than commit
[AMD Official Use Only - General]
> -Original Message-
> From: Konstantin Aladyshev
> Sent: Tuesday, October 17, 2023 4:54 PM
> To: Chang, Abner
> Cc: disc...@edk2.groups.io; devel@edk2.groups.io
> Subject: Re: [edk2-devel] [edk2-discuss] PLDM messages via MCTP ov
On 10/17/2023 4:05 AM, Laszlo Ersek wrote:
Nhi says that reading LINK_CONTROL_LINK_STATUS_REG is redundant; its only
use was debugging (before commit 380b4b40c60d). Thus, we can go farther
than commit 2e27c62ef000, and remove the MmioRead32() call altogether.
Build-tested with "Jade.dsc".
Cc:
Nhi says that reading LINK_CONTROL_LINK_STATUS_REG is redundant; its only
use was debugging (before commit 380b4b40c60d). Thus, we can go farther
than commit 2e27c62ef000, and remove the MmioRead32() call altogether.
Build-tested with "Jade.dsc".
Cc: Chuong Tran
Cc: Leif Lindholm
Cc: Nhi Pham
al Message-
> > From: disc...@edk2.groups.io On Behalf Of
> > Chang, Abner via groups.io
> > Sent: Saturday, October 14, 2023 5:11 PM
> > To: Konstantin Aladyshev
> > Cc: disc...@edk2.groups.io; devel@edk2.groups.io
> > Subject: Re: [edk2-devel] [edk2-discuss] PLDM
at
this version.
Thanks
Abner
> -Original Message-
> From: disc...@edk2.groups.io On Behalf Of
> Chang, Abner via groups.io
> Sent: Saturday, October 14, 2023 5:11 PM
> To: Konstantin Aladyshev
> Cc: disc...@edk2.groups.io; devel@edk2.groups.io
> Subject: Re: [edk2-devel] [edk2-d
[AMD Official Use Only - General]
> -Original Message-
> From: Konstantin Aladyshev
> Sent: Saturday, October 14, 2023 4:26 PM
> To: Chang, Abner
> Cc: disc...@edk2.groups.io; devel@edk2.groups.io
> Subject: Re: [edk2-devel] [edk2-discuss] PLDM messages via MCTP ov
icial Use Only - General]
>
> > -Original Message-
> > From: Konstantin Aladyshev
> > Sent: Friday, October 13, 2023 8:16 PM
> > To: Chang, Abner
> > Cc: disc...@edk2.groups.io; devel@edk2.groups.io
> > Subject: Re: [edk2-devel] [edk2-discuss] PLDM messages
[AMD Official Use Only - General]
> -Original Message-
> From: Konstantin Aladyshev
> Sent: Friday, October 13, 2023 8:16 PM
> To: Chang, Abner
> Cc: disc...@edk2.groups.io; devel@edk2.groups.io
> Subject: Re: [edk2-devel] [edk2-discuss] PLDM messages via MCTP ov
On 10/13/23 12:12, Ard Biesheuvel wrote:
> On Thu, 12 Oct 2023 at 11:10, Laszlo Ersek wrote:
>>
>> https://bugzilla.tianocore.org/show_bug.cgi?id=4564
>>
>> The RealTimeClockLib class header in edk2's EmbeddedPkg mistakenly
>> declares a function called LibRtcVirtualNotifyEvent(). No component
On 10/13/23 05:24, Nhi Pham wrote:
> HI Lazslo,
>
> I was not reviewing carefully. The MmioRead32 is redundant code. Can you
> help me get rid of that code?
Sure, if you don't need the read access to the
LINK_CONTROL_LINK_STATUS_REG register, I can drop that too; I just
didn't want to do it
t; Abner
>
>
> > -Original Message-
> > From: Konstantin Aladyshev
> > Sent: Thursday, October 5, 2023 11:18 PM
> > To: Chang, Abner
> > Cc: disc...@edk2.groups.io; devel@edk2.groups.io
> > Subject: Re: [edk2-devel] [edk2-discuss] PLDM mes
On Thu, 12 Oct 2023 at 11:10, Laszlo Ersek wrote:
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=4564
>
> The RealTimeClockLib class header in edk2's EmbeddedPkg mistakenly
> declares a function called LibRtcVirtualNotifyEvent(). No component ever
> calls this function across module
HI Lazslo,
I was not reviewing carefully. The MmioRead32 is redundant code. Can you
help me get rid of that code?
Thanks,
Nhi
On 10/13/2023 9:20 AM, Nhi Pham wrote:
Thanks for fixing it.
Reviewed-by: Nhi Pham
Regards,
Nhi
On 10/12/2023 4:09 PM, Laszlo Ersek wrote:
Commit 380b4b40c60d
It looks good to me.
Reviewed-by: Nhi Pham
Thanks,
Nhi
On 10/12/2023 4:09 PM, Laszlo Ersek wrote:
The RealTimeClockLib class header in edk2 mistakenly declares a function
called LibRtcVirtualNotifyEvent(). No component ever calls this function
crossing module boundaries; all RealTimeClockLib
Thanks for fixing it.
Reviewed-by: Nhi Pham
Regards,
Nhi
On 10/12/2023 4:09 PM, Laszlo Ersek wrote:
Commit 380b4b40c60d ("AmpereAltraPkg: Update Ampere specific platform PCIe
core", 2023-03-29) removed the DEBUG macro call from
Ac01PcieCoreUpdateLink() that was the only reader of "Val".
Hi,
czw., 12 paź 2023 o 11:10 Laszlo Ersek napisał(a):
>
> The RealTimeClockLib class header in edk2 mistakenly declares a function
> called LibRtcVirtualNotifyEvent(). No component ever calls this function
> crossing module boundaries; all RealTimeClockLib instances in edk2 and
> edk2-platforms
Hi Laszlo,
This patch is look good to me. Thanks.
Acked-by: Chao Li
Thanks,
Chao
在 2023/10/12 20:14, xianglai 写道:
Hi Laszlo Ersek:
The RealTimeClockLib class header in edk2 mistakenly declares a function
called LibRtcVirtualNotifyEvent(). No component ever calls this function
crossing
Hi Laszlo Ersek:
The RealTimeClockLib class header in edk2 mistakenly declares a function
called LibRtcVirtualNotifyEvent(). No component ever calls this function
crossing module boundaries; all RealTimeClockLib instances in edk2 and
edk2-platforms are supposed to register (and do register)
Edk2 commit [1] introduced the library class header to
ArmPkg; commit [2] introduced the first OemMiscLib instance to ArmPkg; and
commit [3] introduced (retroactively) the library class itself to ArmPkg.
Alas, when all these edk2 commits were made, edk2-platforms already had a
https://bugzilla.tianocore.org/show_bug.cgi?id=4564
This patch accompanies "[edk2-platforms PATCH 04/19] Hisilicon: rename
OemMiscLib class to HisiOemMiscLib".
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Wenyi Xie
Thanks
Laszlo
Laszlo Ersek (1):
Hisilicon: rename OemMiscLib class
Edk2-platforms contains two DS3231RealTimeClockLib instances:
- Silicon/Hisilicon/Library/DS3231RealTimeClockLib
- Platform/Hisilicon/D03/Library/DS3231RealTimeClockLib
The latter is still used (by the D03 and D05 platforms), but the former
has not been referenced since commit 478282ea28c7
The RealTimeClockLib class header in edk2 mistakenly declares a function
called LibRtcVirtualNotifyEvent(). No component ever calls this function
crossing module boundaries; all RealTimeClockLib instances in edk2 and
edk2-platforms are supposed to register (and do register) their
The RealTimeClockLib class header in edk2 mistakenly declares a function
called LibRtcVirtualNotifyEvent(). No component ever calls this function
crossing module boundaries; all RealTimeClockLib instances in edk2 and
edk2-platforms are supposed to register (and do register) their
The RealTimeClockLib class header in edk2 mistakenly declares a function
called LibRtcVirtualNotifyEvent(). No component ever calls this function
crossing module boundaries; all RealTimeClockLib instances in edk2 and
edk2-platforms are supposed to register (and do register) their
The RealTimeClockLib class header in edk2 mistakenly declares a function
called LibRtcVirtualNotifyEvent(). No component ever calls this function
crossing module boundaries; all RealTimeClockLib instances in edk2 and
edk2-platforms are supposed to register (and do register) their
The RealTimeClockLib class header in edk2 mistakenly declares a function
called LibRtcVirtualNotifyEvent(). No component ever calls this function
crossing module boundaries; all RealTimeClockLib instances in edk2 and
edk2-platforms are supposed to register (and do register) their
The RealTimeClockLib class header in edk2 mistakenly declares a function
called LibRtcVirtualNotifyEvent(). No component ever calls this function
crossing module boundaries; all RealTimeClockLib instances in edk2 and
edk2-platforms are supposed to register (and do register) their
The RealTimeClockLib class header in edk2 mistakenly declares a function
called LibRtcVirtualNotifyEvent(). No component ever calls this function
crossing module boundaries; all RealTimeClockLib instances in edk2 and
edk2-platforms are supposed to register (and do register) their
Commit 380b4b40c60d ("AmpereAltraPkg: Update Ampere specific platform PCIe
core", 2023-03-29) removed the DEBUG macro call from
Ac01PcieCoreUpdateLink() that was the only reader of "Val". Since then,
Val has only been set, but never read. This triggers
"-Werror=unused-but-set-variable".
Found
The RealTimeClockLib class header in edk2 mistakenly declares a function
called LibRtcVirtualNotifyEvent(). No component ever calls this function
crossing module boundaries; all RealTimeClockLib instances in edk2 and
edk2-platforms are supposed to register (and do register) their
The RealTimeClockLib class header in edk2 mistakenly declares a function
called LibRtcVirtualNotifyEvent(). No component ever calls this function
crossing module boundaries; all RealTimeClockLib instances in edk2 and
edk2-platforms are supposed to register (and do register) their
Since edk2 commit 8db39c60cdf3 ("MdeModulePkg/FaultTolerantWrite: Consume
Variable Flash Info", 2022-05-19), the Hisilicon platforms (D03, D05, D06,
HiKey, HiKey960) must have been broken; they don't resolve the new
VariableFlashInfoLib class to the (only) BaseVariableFlashInfoLib
instance. Do
VirtualRealTimeClockLib is not used in either edk2-platforms or
edk2-non-osi, and there never has been a reference to it -- even the
initial code drop that added it to edk2-platforms [*] contained zero
references to it. Remove it.
[*] commit 600081b52deb ("Platform,Silicon: Import Hisilicon
Edk2 commit [1] introduced the library class header to
ArmPkg; commit [2] introduced the first OemMiscLib instance to ArmPkg; and
commit [3] introduced (retroactively) the library class itself to ArmPkg.
Alas, when all these edk2 commits were made, edk2-platforms already had a
Edk2 commit cc650a0378f8 ("ArmPlatformPkg: Retire NorFlashDxe driver",
2022-11-06) removed PcdNorFlashCheckBlockLocked from
"gArmPlatformTokenSpaceGuid"; edk2-platforms commit d7b286ae5f53
("Platform/ARM: clone NorFlashDxe from ArmPlatformPkg", 2022-10-19)
provided it in the *different* namespace
801 - 900 of 11988 matches
Mail list logo
