On 07/23/19 00:52, rebe...@bsdio.com wrote:
> On 2019-07-22 16:16, Laszlo Ersek wrote:
>>
>> should we push patches #1 through #4 from this series?
>>
>> They are independent of python detection (which is still being discussed).
>
>
> I think that's a good idea.
Pushed patches #1 through #4 as
On 2019-07-22 16:16, Laszlo Ersek wrote:
>
> should we push patches #1 through #4 from this series?
>
> They are independent of python detection (which is still being discussed).
I think that's a good idea.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages
Hi All,
On 07/16/19 18:55, rebe...@bsdio.com wrote:
> This is a (very minor) optimization: `pwd` runs the command (even as a
> built-in), whereas $PWD simply evaluates the value of the variable.
>
> ALso, modern scripts should generally use $(...) to run commands,
> instead of `...`.
>
>
Rebecca:
The change is good. Reviewed-by: Liming Gao for 1-4,
and 6.
For patch 5, I see Leif sends another version update. I will give the
comments on his change.
Thanks
Liming
> -Original Message-
> From: Rebecca Cran [mailto:rebe...@bsdio.com]
> Sent: Wednesday, July 17, 2019
This is a (very minor) optimization: `pwd` runs the command (even as a
built-in), whereas $PWD simply evaluates the value of the variable.
ALso, modern scripts should generally use $(...) to run commands,
instead of `...`.
Signed-off-by: Rebecca Cran
Reviewed-by: Laszlo Ersek
Reviewed-by: Leif
