Re: [edk2-devel] [Patch 00/10 V8] Enable multiple process AutoGen

2019-08-09 Thread Leif Lindholm
On Fri, Aug 09, 2019 at 02:54:28PM +, Gao, Liming wrote: > > Thank you for the clarification, Laszlo. > > > > I would say this makes a fix for the --hash issue a hard requirement > > for the stable tag. > > If --hash issue is the regression issue caused by this patch set, I agree it > must b

Re: [edk2-devel] [Patch 00/10 V8] Enable multiple process AutoGen

2019-08-09 Thread Bob Feng
aszlo Ersek Cc: Feng, Bob C ; Gao, Liming ; devel@edk2.groups.io; Andrew Fish ; Kinney, Michael D Subject: Re: [edk2-devel] [Patch 00/10 V8] Enable multiple process AutoGen On Fri, Aug 09, 2019 at 02:54:31PM +0200, Laszlo Ersek wrote: > On 08/09/19 03:37, Feng, Bob C wrote: > > T

Re: [edk2-devel] [Patch 00/10 V8] Enable multiple process AutoGen

2019-08-09 Thread Liming Gao
D > Subject: Re: [edk2-devel] [Patch 00/10 V8] Enable multiple process AutoGen > > On Fri, Aug 09, 2019 at 02:54:31PM +0200, Laszlo Ersek wrote: > > On 08/09/19 03:37, Feng, Bob C wrote: > > > Thanks for your response. > > > > > > I'm going to push

Re: [edk2-devel] [Patch 00/10 V8] Enable multiple process AutoGen

2019-08-09 Thread Bob Feng
: [edk2-devel] [Patch 00/10 V8] Enable multiple process AutoGen On 08/09/19 03:37, Feng, Bob C wrote: > Thanks for your response. > > I'm going to push this patch set late today, if there is no more comments. Sorry, I have to disagree about that. There is a NACK standing from Leif -- h

Re: [edk2-devel] [Patch 00/10 V8] Enable multiple process AutoGen

2019-08-09 Thread Leif Lindholm
On Fri, Aug 09, 2019 at 02:54:31PM +0200, Laszlo Ersek wrote: > On 08/09/19 03:37, Feng, Bob C wrote: > > Thanks for your response. > > > > I'm going to push this patch set late today, if there is no more comments. > > Sorry, I have to disagree about that. There is a NACK standing from Leif > --

Re: [edk2-devel] [Patch 00/10 V8] Enable multiple process AutoGen

2019-08-09 Thread Laszlo Ersek
r...@redhat.com; Feng, Bob C > ; leif.lindh...@linaro.org > Cc: Andrew Fish ; Kinney, Michael D > > Subject: RE: [edk2-devel] [Patch 00/10 V8] Enable multiple process AutoGen > > Bob: > I have no comments for this patch set. I am OK to add it for 201908 stable > tag.

Re: [edk2-devel] [Patch 00/10 V8] Enable multiple process AutoGen

2019-08-08 Thread Bob Feng
ndrew Fish ; Kinney, Michael D Subject: RE: [edk2-devel] [Patch 00/10 V8] Enable multiple process AutoGen Bob: I have no comments for this patch set. I am OK to add it for 201908 stable tag. Ack-by: Liming Gao Thanks Liming > -Original Message- > From: devel@edk2.groups.io [m

Re: [edk2-devel] [Patch 00/10 V8] Enable multiple process AutoGen

2019-08-08 Thread Liming Gao
M > To: Feng, Bob C ; devel@edk2.groups.io; > leif.lindh...@linaro.org > Cc: Andrew Fish ; Kinney, Michael D > ; Gao, Liming > Subject: Re: [edk2-devel] [Patch 00/10 V8] Enable multiple process AutoGen > > On 08/09/19 00:18, Laszlo Ersek wrote: > > On 08/08/19 17:38, Fen

Re: [edk2-devel] [Patch 00/10 V8] Enable multiple process AutoGen

2019-08-08 Thread Laszlo Ersek
On 08/09/19 00:18, Laszlo Ersek wrote: > On 08/08/19 17:38, Feng, Bob C wrote: >> Hi Laszlo and Leif, >> >> Thanks for you detailed testing and comments. >> >> I'd like to explain the failure of the test 3#. I can reproduce the failure >> with your steps and I found this failure can also be reprod

Re: [edk2-devel] [Patch 00/10 V8] Enable multiple process AutoGen

2019-08-08 Thread Laszlo Ersek
.io [mailto:devel@edk2.groups.io] On Behalf Of Leif > Lindholm > Sent: Thursday, August 8, 2019 9:45 PM > To: Laszlo Ersek > Cc: Feng, Bob C ; devel@edk2.groups.io; Andrew Fish > ; Kinney, Michael D ; Gao, > Liming > Subject: Re: [edk2-devel] [Patch 00/10 V8] Enable multip

Re: [edk2-devel] [Patch 00/10 V8] Enable multiple process AutoGen

2019-08-08 Thread Bob Feng
@edk2.groups.io] On Behalf Of Leif Lindholm Sent: Thursday, August 8, 2019 9:45 PM To: Laszlo Ersek Cc: Feng, Bob C ; devel@edk2.groups.io; Andrew Fish ; Kinney, Michael D ; Gao, Liming Subject: Re: [edk2-devel] [Patch 00/10 V8] Enable multiple process AutoGen Hi Laszlo, Thanks for looping me in. O

Re: [edk2-devel] [Patch 00/10 V8] Enable multiple process AutoGen

2019-08-08 Thread Leif Lindholm
Hi Laszlo, Thanks for looping me in. On Thu, Aug 08, 2019 at 03:08:22PM +0200, Laszlo Ersek wrote: > (+ Andrew, Leif, Mike; Liming) > > On 08/07/19 06:25, Bob Feng wrote: > (3) In my normal edk2 clone, I cleaned the tree, applied your patches > (again on top of commit 96603b4f02b9), and started

Re: [edk2-devel] [Patch 00/10 V8] Enable multiple process AutoGen

2019-08-08 Thread Laszlo Ersek
(+ Andrew, Leif, Mike; Liming) On 08/07/19 06:25, Bob Feng wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 > > In order to improve the build performance, we implemented > multiple-processes AutoGen. This change will reduce 20% time > for AutoGen phase. > > The design document can

[edk2-devel] [Patch 00/10 V8] Enable multiple process AutoGen

2019-08-06 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 In order to improve the build performance, we implemented multiple-processes AutoGen. This change will reduce 20% time for AutoGen phase. The design document can be got from: https://edk2.groups.io/g/devel/files/Designs/2019/0627/Multiple-th