Re: Segfault in Kannel meta-data (TLV) branch with certain DLR

2008-01-30 Thread Kyriacos Sakkas
Stipe Tolj wrote: Kyriacos Sakkas schrieb: This will happen, but I am holding off for a bit more, as meta-data was used to implement some new requirements, so I am waiting for a bit to make sure I am meeting those before making any further change. I will update when that happens. Hi, any

Re: Segfault in Kannel meta-data (TLV) branch with certain DLR

2008-01-30 Thread Stipe Tolj
Kyriacos Sakkas schrieb: I am currently running my full live load via GET request on the version before the patch fixing the POST method. The wait is until me (or someone else that can put some stress on it) confirms operation of the current meta-data cvs under some sort of heavy load via POST

Re: Segfault in Kannel meta-data (TLV) branch with certain DLR

2008-01-29 Thread Giulio Harding
FYI, with the simple tests I had, this patch fixes the problem - I guess the true test is for Kyriacos to put it into production, and resume using POSTs, if he feels brave enough :) Thanks again Alex! On 25/01/2008, at 12:51 AM, Alexander Malysh wrote: Hi again, seems the fix is also

Re: Segfault in Kannel meta-data (TLV) branch with certain DLR

2008-01-29 Thread Kyriacos Sakkas
This will happen, but I am holding off for a bit more, as meta-data was used to implement some new requirements, so I am waiting for a bit to make sure I am meeting those before making any further change. I will update when that happens. Kyriacos Giulio Harding wrote: FYI, with the simple tests

Re: Segfault in Kannel meta-data (TLV) branch with certain DLR

2008-01-29 Thread Stipe Tolj
Kyriacos Sakkas schrieb: This will happen, but I am holding off for a bit more, as meta-data was used to implement some new requirements, so I am waiting for a bit to make sure I am meeting those before making any further change. I will update when that happens. Hi, any change from our side?

Re: Segfault in Kannel meta-data (TLV) branch with certain DLR

2008-01-24 Thread Giulio Harding
Ok, I've just reproduced Kyriacos' problem - it seems to be an issue with MT HTTP POST with the TLV HTTP header set. This is Kannel from the meta_data branch, with a couple of site- specific patches (though they shouldn't have any effect - I get the same results as Kyriacos does, and he's

Re: Segfault in Kannel meta-data (TLV) branch with certain DLR

2008-01-24 Thread Alexander Malysh
Hi again, seems the fix is also really simple :) Please try attached patch. Giulio Harding wrote: Ok, I've just reproduced Kyriacos' problem - it seems to be an issue with MT HTTP POST with the TLV HTTP header set. This is Kannel from the meta_data branch, with a couple of site- specific

Re: Segfault in Kannel meta-data (TLV) branch with certain DLR

2008-01-24 Thread Alexander Malysh
Hi, patch commited to meta-data branch. Alexander Malysh wrote: Hi again, seems the fix is also really simple :) Please try attached patch. Giulio Harding wrote: Ok, I've just reproduced Kyriacos' problem - it seems to be an issue with MT HTTP POST with the TLV HTTP header set.

Re: Segfault in Kannel meta-data (TLV) branch with certain DLR

2008-01-23 Thread Kyriacos Sakkas
My stability issues are in HTTP in both directions it would seem. I get no detailed error messages but it appears that smsbox dies after either forwarding more than 2-3 MOs to my app, or after it receives more than 2-3 MTs from my app. It then gets regenerated, but seems unable to talk properly to

Re: Segfault in Kannel meta-data (TLV) branch with certain DLR

2008-01-22 Thread Kyriacos Sakkas
I re-compiled only difference was that is set with=debug, and now that problem seems to have gone away. still I am at very low volumes. Kyriacos Also on submitting a message (MT) kannel no longer returns 0: Accepted for delivery or anything else. I understand this may be unrelated changes, but

Re: Segfault in Kannel meta-data (TLV) branch with certain DLR

2008-01-22 Thread Kyriacos Sakkas
Hi Guys, I got the meta-data branch and I am still getting a lot of stability issues, although they all seem to have to do with the HTTP interface rather than the patch. I am running on debian with stock amd64 kernels but I understand that your production machine is 64bit anyway. Gioulio are

Re: Segfault in Kannel meta-data (TLV) branch with certain DLR

2008-01-22 Thread Stipe Tolj
Kyriacos Sakkas schrieb: 2008-01-22 14:05:08 [10986] [7] DEBUG: validity_period: NULL 2008-01-22 14:05:08 [10986] [7] DEBUG: registered_delivery: 0 = 0x 2008-01-22 14:05:08 [10986] [7] DEBUG: replace_if_present_flag: 0 = 0x 2008-01-22 14:05:08 [10986] [7] DEBUG:

Re: Segfault in Kannel meta-data (TLV) branch with certain DLR

2008-01-22 Thread Giulio Harding
I've actually had to back out of using the meta-data Kannel, as we spotted what looks to be a problem in the way Kannel handles carriage return characters (ctrl-M) in synchronous responses to MO HTTP requests - the carriage returns arrive at smsbox fine, but by the time they leave the

Segfault in Kannel meta-data (TLV) branch with certain DLR

2008-01-21 Thread Giulio Harding
I've been testing Alex's TLV patch with the meta-data branch, with initial success (able to read and set mblox TLVs for US-specific bind, as per Kyriacos's mblox TLV config - thanks for that!). It's been performing perfectly on our test server, with a small number of test binds, carrying

Re: Segfault in Kannel meta-data (TLV) branch with certain DLR

2008-01-21 Thread Giulio Harding
Ok, after a bit more perusing of the code, I think I found the problem (line 1460 of gw/smsc/smsc_smpp.c): ... /* got a deliver ack (DLR)? * NOTE: following SMPP v3.4. spec. we are interested * only on bits 2-5 (some SMSC's send 0x44, and

Re: Segfault in Kannel meta-data (TLV) branch with certain DLR

2008-01-21 Thread Alexander Malysh
Hi, thanks for very good bug report. Please try attached patch that should fix: 1) typo ; 2) the case if dlr is not found in the storage. Just apply it to smpp-tlv branch. Giulio Harding wrote: Ok, after a bit more perusing of the code, I think I found the problem (line 1460 of

Re: Segfault in Kannel meta-data (TLV) branch with certain DLR

2008-01-21 Thread Kyriacos Sakkas
Hi, And a great thanks to both Giulio Alexander, I have had this problem too, and had being trying to solve it, but my C skill are fairly crappy :), I will roll this out tomorrow on a production environment with a couple of thousand msgs per day, and that should show if its properly stable.

Re: Segfault in Kannel meta-data (TLV) branch with certain DLR

2008-01-21 Thread Kyriacos Sakkas
Hi, There is some umbiquity in the patch. The new lines are inserted lower from where the old lines are removed, and specificaly after an IF statement that would negate this code block: if (dlrmsg != NULL) { +if (dlrmsg-sms.meta_data == NULL) This looks

Re: Segfault in Kannel meta-data (TLV) branch with certain DLR

2008-01-21 Thread Giulio Harding
Also, it looks like there's 2 instances of the same typo, one at 1396, the other at 1460 the 2nd instance at line 1460, should it be something like this? ... if (dlrmsg != NULL) { if (dlrmsg-sms.meta_data == NULL)

Re: Segfault in Kannel meta-data (TLV) branch with certain DLR

2008-01-21 Thread Alexander Malysh
Hi, you are right. Thanks! Please try attached patch that combine fixes for both cases. It's on top of clean smpp-tlv branch. Giulio Harding wrote: Also, it looks like there's 2 instances of the same typo, one at 1396, the other at 1460 the 2nd instance at line 1460, should it be

Re: Segfault in Kannel meta-data (TLV) branch with certain DLR

2008-01-21 Thread Giulio Harding
Thanks, looks good so far! I'll report back in a few hours after traffic has picked up again, and let you know how the patched-patched- Kannel is faring :) Cheers, On 22/01/2008, at 2:03 AM, Alexander Malysh wrote: Hi, you are right. Thanks! Please try attached patch that combine fixes

Re: Segfault in Kannel meta-data (TLV) branch with certain DLR

2008-01-21 Thread Stipe Tolj
Alexander Malysh schrieb: Hi, you are right. Thanks! Please try attached patch that combine fixes for both cases. It's on top of clean smpp-tlv branch. @Alex: Thanks! Instant resolving appritiated :) +1, commited to CVS meta-data branch. @Giulio, Kyriacos: please update your local CVS

Re: Segfault in Kannel meta-data (TLV) branch with certain DLR

2008-01-21 Thread Giulio Harding
Just a followup on this, we've processed ~12000 MOs over SMPP this morning, and there's been no further issues - thanks again Alex for the prompt fix! :) On 22/01/2008, at 2:21 AM, Giulio Harding wrote: Thanks, looks good so far! I'll report back in a few hours after traffic has picked up