On 1/19/23 04:52, Michal Schorm wrote:
Hello,
While playing around with Sourcegraph, which indexed all Fedora
package repositories, I was able to craft a query listing all '%if'
conditionals referencing Fedora releases that reached EOL.
On Thu, Jan 19, 2023 at 10:52 AM Michal Schorm wrote:
> Would you see a value in e.g. some kind of a robot reminding
> maintainers of such obsolete code? (e.g. new RPMinspect or ZUUL CI
> check)
"Reminding" is another term for nagging. Fedora should
not be a nag when there may be reasons for
Dne 19. 01. 23 v 16:13 Michal Schorm napsal(a):
I'd just add that the same may apply to the %{rhel} macros too - Is
there any need to check for*EOLed* RHEL releases?
Sometimes yes. I have seen people still using RHEL 5 and building packages for
RHEL 5.
It is not needed to be present in
I personally very much prefer to keep stale conditionals out of the spec files
I work on, but I also concur that it is reasonable to want to leave this to
maintainer discretion.
On Thu, Jan 19, 2023, at 11:14 AM, Robbie Harwood wrote:
> Michal Schorm writes:
>
>> On Thu, Jan 19, 2023 at 3:36
Michal Schorm wrote:
> I'd like to learn why people would (not) like such a check or reminder.
The maintainer sees the conditional every time they update the spec.
They can remove it whenever it's convenient to them. There's no need to
pester people about such non-urgent maintenance. It's not
Michal Schorm writes:
> On Thu, Jan 19, 2023 at 3:36 PM Robbie Harwood wrote:
>>> Would you see a value in e.g. some kind of a robot reminding
>>> maintainers of such obsolete code? (e.g. new RPMinspect or ZUUL CI
>>> check)
>>
>> Please don't.
>
> Would you mind expanding your answer a bit,
On Thu, Jan 19, 2023 at 04:13:02PM +0100, Michal Schorm wrote:
On Thu, Jan 19, 2023 at 4:04 PM Ewoud Kohl van Wijngaarden
wrote:
>Do you agree it would be safe to remove such conditionals and the code
>they hold ?
Only if they're purely for Fedora. In many examples you also see a rhel
On Thu, Jan 19, 2023 at 4:04 PM Ewoud Kohl van Wijngaarden
wrote:
> >Do you agree it would be safe to remove such conditionals and the code
> >they hold ?
>
> Only if they're purely for Fedora. In many examples you also see a rhel
> conditional and that could be used for EPEL. A good number of
On Thu, Jan 19, 2023 at 11:52:04AM +0100, Michal Schorm wrote:
While playing around with Sourcegraph, which indexed all Fedora
package repositories, I was able to craft a query listing all '%if'
conditionals referencing Fedora releases that reached EOL.
On Thu, Jan 19, 2023 at 8:55 AM Michal Schorm wrote:
> On Thu, Jan 19, 2023 at 3:36 PM Robbie Harwood
> wrote:
> > > Would you see a value in e.g. some kind of a robot reminding
> > > maintainers of such obsolete code? (e.g. new RPMinspect or ZUUL CI
> > > check)
> >
> > Please don't.
>
> Would
On Thu, Jan 19, 2023 at 3:36 PM Robbie Harwood wrote:
> > Would you see a value in e.g. some kind of a robot reminding
> > maintainers of such obsolete code? (e.g. new RPMinspect or ZUUL CI
> > check)
>
> Please don't.
Would you mind expanding your answer a bit, please?
I'd like to learn why
Michal Schorm writes:
> While playing around with Sourcegraph, which indexed all Fedora
> package repositories, I was able to craft a query listing all '%if'
> conditionals referencing Fedora releases that reached EOL.
>
> Do you agree it would be safe to remove such conditionals and the code
>
On Thu, 19 Jan 2023 at 10:52, Michal Schorm wrote:
>
> Hello,
> While playing around with Sourcegraph, which indexed all Fedora
> package repositories, I was able to craft a query listing all '%if'
> conditionals referencing Fedora releases that reached EOL.
>
>
13 matches
Mail list logo
