Re: Critpath karma

2018-03-07 Thread Adam Williamson
. > If we do think there's a good reason to keep two kinds of karma for the > glorious feature, perhaps we could just hide the critpath karma feedback > buttons in the UI for now just so they don't get confused with the > normal karma, which can lead to some issues since it doesn't really

Re: Critpath karma

2018-03-07 Thread Randy Barlow
ma button that we use for normal updates, but on critpath updates the alarm bells are bigger? If we do think there's a good reason to keep two kinds of karma for the glorious feature, perhaps we could just hide the critpath karma feedback buttons in the UI for now just so they don't get confused with t

Re: Critpath karma

2018-03-07 Thread Adam Williamson
On Wed, 2018-03-07 at 08:50 +, Zbigniew Jędrzejewski-Szmek wrote: > On Tue, Mar 06, 2018 at 04:20:26PM -0800, Adam Williamson wrote: > > 1. Any update that is marked as 'critpath breaking' by a FAS-registered > > tester would be blocked from going any further in the update process > > without

Re: Critpath karma

2018-03-07 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Mar 06, 2018 at 04:20:26PM -0800, Adam Williamson wrote: > 1. Any update that is marked as 'critpath breaking' by a FAS-registered > tester would be blocked from going any further in the update process > without manual intervention (no autopushes at all) IIRC, that happens with all

Re: Critpath karma

2018-03-06 Thread Adam Williamson
On Tue, 2018-03-06 at 08:48 -0500, Randy Barlow wrote: > Greetings! > > Does anybody here know the history and/or purpose behind Bodhi's > critical path karma? A brief grepping of Bodhi's codebase makes me think > it isn't really used by Bodhi for any purpose other than recording and > displaying

Re: Critpath karma

2018-03-06 Thread Randy Barlow
I've filed https://github.com/fedora-infra/bodhi/issues/2194 about considering removing this feature from Bodhi. I listed an example there where I thought the feature was actively harmful in a particular case, due to users not knowing that the field doesn't actually count for anything.

Re: Critpath karma

2018-03-06 Thread Randy Barlow
irements for critical path packages to reach a certain level of normal karma, and we do have Greenwave to enforce automated tests. The critpath karma field does seem like it wouldn't serve a purpose anymore, even given automated testing. signature.asc Description: Open

Re: Critpath karma

2018-03-06 Thread Randy Barlow
On 03/06/2018 08:53 AM, Peter Robinson wrote: > Critical path were (are) packages that were in blocking deliverables, > it pre-dates the Editions, basically if it was a core blocking package > eg part of Workstaiton, it needed to get more testing/karma before it > could go stable, adamw probably

Re: Critpath karma

2018-03-06 Thread Dennis Gilmore
El mar, 06-03-2018 a las 08:48 -0500, Randy Barlow escribió: > Greetings! > > Does anybody here know the history and/or purpose behind Bodhi's > critical path karma? A brief grepping of Bodhi's codebase makes me > think > it isn't really used by Bodhi for any purpose other than recording > and >

Re: Critpath karma

2018-03-06 Thread Peter Robinson
On Tue, Mar 6, 2018 at 1:48 PM, Randy Barlow wrote: > Greetings! > > Does anybody here know the history and/or purpose behind Bodhi's > critical path karma? A brief grepping of Bodhi's codebase makes me think > it isn't really used by Bodhi for any purpose other than

Critpath karma

2018-03-06 Thread Randy Barlow
Greetings! Does anybody here know the history and/or purpose behind Bodhi's critical path karma? A brief grepping of Bodhi's codebase makes me think it isn't really used by Bodhi for any purpose other than recording and displaying people's entries. I.e., it doesn't seem to be used in Bodhi's