Re: New ssh key fingerprint for dev.laptop.org.
I have renamed the authorized_keys or authorized_keys2 files for eight accounts on teach.laptop.org which contained weak keys or which caused the checking script to report a warning when processed. Please contact me to resolve your account status if you have an account but are unable to authenticate. Thanks, Michael ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Strange 755 mode on .sugar/default/owner.key
I just spent a bit of time trying to understand why .sugar/default/owner.key was 755 on the xo am working on. I can't find any plausible reason, the key creation does the right thing, nothing seems to chmod it, and I haven't chmoded anything - but so it was. But I thought I'd mention it, in case someone else has seen it, or bumps into a similar case. This was a 642 machine, upgraded to 703, and - mysteriously - .sugar/default/owner.key was 755. the truth is out there... somewhere. m -- [EMAIL PROTECTED] [EMAIL PROTECTED] -- School Server Architect - ask interesting questions - don't get distracted with shiny stuff - working code first - http://wiki.laptop.org/go/User:Martinlanghoff ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
New ssh key fingerprint for dev.laptop.org.
Hi, Two annoucements: * The SSH RSA fingerprint for dev.laptop.org has changed to: 65:2c:41:29:54:03:70:d9:c5:b9:5e:5a:62:33:d6:d1. * Debian and Ubuntu have announced a bug in their OpenSSL cryptographic key generator, with the result that keys created by the affected versions are "weak" keys and can be brute-forced. The ssh server on dev now detects for attempted logins using a predictable key and blocks such logins. If you are unable to login to dev today, you should contact [EMAIL PROTECTED] to have your key replaced. More details at: http://lists.debian.org/debian-security-announce/2008/msg00152.html Thanks, - Chris. -- Chris Ball <[EMAIL PROTECTED]> ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Re: [sugar] OLPC priorities for Sugar in the August release
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jameson "Chema" Quinn wrote: | One low-hanging fruit for faster activity start is having activity install | compile .pyc files, with (tiny) extra points if the .pyc gets hints to not | use jffs2 compression. This is on my gameplan with the bundle format update | stuff, but I have gotten stuck on the signatures (openssl cannot read ssh | public keys) so I am behind on that. I had hoped to finish it in my free | time this week but starting next week I cannot be so sure I'll have time. Pretty small fruit. Based on my measurements (http://lists.laptop.org/pipermail/sugar/2008-March/004669.html), we are talking about less than 200 ms for typical Activities. The only Activities I know of with enough code for this to matter are the TamTam activities. Even the Journal spends much less than one second compiling. ~ Additionally, my measurements include the time to write the pyc file back into jffs2, so the real launch delay could be even less. - --Ben -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.7 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIK5JwUJT6e6HFtqQRAhbqAJ9jrt0gENi+ar1CCq0QU2O891SH7wCdFlsD JW1/uQlAarBii8WB7V4WVkA= =z9mP -END PGP SIGNATURE- ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
New faster build 1949
http://xs-dev.laptop.org/~cscott/olpc/streams/faster/build1949 Changes in build 1949 from build: 1947 Size delta: -2.50M -etoys 2.3.1896-1 +etoys 3.0.1998-1 -squeak-vm 3.9-12olpc5 +squeak-vm 3.10-3olpc1 --- Changes for etoys 3.0.1998-1 from 2.3.1896-1 --- + VM support for GStreamer, XIM, async IO + suspend UI process while inactive (do not hog CPU when in background) + fixed international keyboard input + many more strings translatable + errors get logged in regular log file via stdout + faster project loading + Pango text rendering support (experimental) + and many more minor fixes and improvements --- Changes for squeak-vm 3.10-3olpc1 from 3.9-12olpc5 --- + fix KedamaPlugin2 (exports where not listed) + fix show-source key + fix SEGFAULT in OggPlugin + add RomePlugin w/ Pango support + fix drag-n-drop + remove Mpeg3Plugin + fix dbus plugin not zero-terminating some strings + fix freeze in drag and drop + add analog input support + fix cursor keys + re-enable -O2 to get back speed (duh!) + handle view-source key + big merge with trunk + unicode key events + fixed dbus plugin -- This mail was automatically generated See http://dev.laptop.org/~rwh/announcer/faster-pkgs.html for aggregate logs See http://dev.laptop.org/~rwh/announcer/joyride_vs_update1.html for a comparison ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Re: [sugar] OLPC priorities for Sugar in the August release
On Wed, May 14, 2008 at 10:43 AM, Mikus Grinbergs <[EMAIL PROTECTED]> wrote: >> One low-hanging fruit for faster activity start is having activity install >> compile .pyc files > > There are .pyc files here and there in the XO core software. I do > not expect to myself be changing Activity code -- but if the OLPC is > supposed to be "easy enough for a kid to program" - *someone* will. > > For myself, I don't have wireless at home; to make my communications > setup work properly I need to "patch" some "telepathy/presence" .py > files. [Having changed a .py file, I delete the same-name .pyc > file, and reboot.] I'm not sure what created those corresponding > .pyc files. I __wish__ there was an easy-to-find GUIDE explaining > how and when the various .pyc files were installed. Your wish is noted on the Wiki page for the Architecture Manual. > mikus > > ___ > Sugar mailing list > [EMAIL PROTECTED] > http://lists.laptop.org/listinfo/sugar > -- Edward Cherlin End Poverty at a Profit by teaching children business http://www.EarthTreasury.org/ "The best way to predict the future is to invent it."--Alan Kay ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Re: [sugar] OLPC priorities for Sugar in the August release
Marco Pesenti Gritti wrote: > On Wed, May 14, 2008 at 6:26 PM, Greg Smith (gregmsmi) > <[EMAIL PROTECTED]> wrote: >> Thinking about the "hot corners" pop-up frame thingy, Nepal asked that >> be deprecated and I agree based on my personal experience and that of my >> kids. The only thing I have heard people use it for is the copy and >> paste functionality. Waveplace lead mentioned that and its used in the >> Uruguay training presentation linked above. > > Simon is working on making this an option. We would still need to > decide about the default obviously... > > Marco These sugar rpms include a control panel option to set a delay for the frame activation and an option to toggle the top of the screen to activate the frame. http://dev.laptop.org/~erikos/cp/ You need to install sugar and sugar-toolkit (rpm -U [package] should work fine). I tested on joyride 1918. The control panel can be accessed with the palette on the XO in the home screen. Best, Simon ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
New joyride build 1949
http://xs-dev.laptop.org/~cscott/olpc/streams/joyride/build1949 Changes in build 1949 from build: 1947 Size delta: -2.63M -etoys 2.3.1896-1 +etoys 3.0.1998-1 -squeak-vm 3.9-12olpc5 +squeak-vm 3.10-3olpc1 --- Changes for etoys 3.0.1998-1 from 2.3.1896-1 --- + VM support for GStreamer, XIM, async IO + suspend UI process while inactive (do not hog CPU when in background) + fixed international keyboard input + many more strings translatable + errors get logged in regular log file via stdout + faster project loading + Pango text rendering support (experimental) + and many more minor fixes and improvements --- Changes for squeak-vm 3.10-3olpc1 from 3.9-12olpc5 --- + fix KedamaPlugin2 (exports where not listed) + fix show-source key + fix SEGFAULT in OggPlugin + add RomePlugin w/ Pango support + fix drag-n-drop + remove Mpeg3Plugin + fix dbus plugin not zero-terminating some strings + fix freeze in drag and drop + add analog input support + fix cursor keys + re-enable -O2 to get back speed (duh!) + handle view-source key + big merge with trunk + unicode key events + fixed dbus plugin -- This mail was automatically generated See http://dev.laptop.org/~rwh/announcer/joyride-pkgs.html for aggregate logs See http://dev.laptop.org/~rwh/announcer/joyride_vs_update1.html for a comparison ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Keyboard Support for Haiti & Ethiopia - OLPC 8.1.1 bugfix release
--- officially --- According to tickets #6973 and #6945, 703 loads the wrong keyboard map for Haiti and inappropriately invokes GTK-IM for Ethiopia. It is proposed that we make a small bug-fix release to allow Haiti and Mongolia to make effective use of their laptops with a 703-like build. The USR process checklist for this release is here: http://wiki.laptop.org/go/OLPC_SW-ECO_5_Checklist and the Wiki documentation is at http://wiki.laptop.org/go/OLPC_SW-ECO_5 At present, we believe that #6973 and #6945 can be fixed without security-sensitive changes. --- less officially --- We've got a fair amount of divergence between current joyrides and 703: http://dev.laptop.org/~rwh/announcer/joyride_vs_update1.html and I'm mildly interested in reducing this divergence. Also, there are some tickets at http://dev.laptop.org/query?status=assigned&status=new&status=reopened&group=status&milestone=Update1.1 (and some not recorded there) which we ought to consider. If you can provide a package by Sunday night which is useful and which comes with some evidence that the change introduces no regressions, please speak up and I'll see whether we can dig up the resources required to QA your change. Thanks very much, Michael ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Discussion about Flash
To sum up, which version of Flash is it better to be used by someone who wants to create a dvd for OLPC? Also, is Anvil Studio appropriate for music effects? And finally, may we attach some video-recorded schenes in the dvd? ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Browse startuptime
> cat /boot/olpc_build > faster 1815 browse starts in just over 10 seconds (12-13 until \"OLPC Library\" loads compleatly) just another data-point This anonymous email was sent using Send Anonymous Email - http://www.sendanonymousemail.net. ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Re: Keyboard layout issues
On Wed, May 14, 2008 at 05:12:08PM -0400, Kim Quirk wrote: > Once the next step is figured out -- packaging, do we start a 704 build > (based on 703) with just these fixes? Or do I test them out in a joyride > first? When they are created, I recommend that we ask Dennis to apply these packages to 703. It's going to take some time to choose which parts of joyride (if any) are ready for release. > Please tell me when there is a build I can test these fixes on. Will do. Michael ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Re: School server stuff
On Mon, 2008-05-12 at 23:49 -0400, John Watlington wrote: > On May 12, 2008, at 8:46 PM, Marcus Leech wrote: > > A few questions: > > > > What driver is required on an ordinary Linux system for the active > > antennae? > > [I ask because plugging one in to a hot-off-the-presses F9 system > > causes said system to freeze instantly :-( ] > > The stock upstream libertas kernel might work, given proper firmware > in /lib/firmware. It most certainly should -- and was tested fairly recently. If you have problems, file a bug in Fedora bugzilla. -- dwmw2 ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Re: Keyboard layout issues
This looks great, Sayamindu! Thanks for getting to this so quickly. Michael, Once the next step is figured out -- packaging, do we start a 704 build (based on 703) with just these fixes? Or do I test them out in a joyride first? Please tell me when there is a build I can test these fixes on. Regards, Kim On Wed, May 14, 2008 at 5:03 PM, Michael Stone <[EMAIL PROTECTED]> wrote: > Sayamindu, > > Thanks for the awesome writeup. Do you feel comfortable enough with > Fedora packaging to take responsibility for providing 703-compatible > packages containing these changes? > > Thanks, > > Michael > > Status fragment: > > #6973 PKG ??? (Production problem: Haiti keyboard doesn't match > keyboard mappings) > #6945 PKG ??? (MFG Problem: Ethiopian keyboards don't provide > English characters) > #5996 ESC sayamindu (Mongolian, Devanagari keyboard/language testing) > > ___ > Devel mailing list > Devel@lists.laptop.org > http://lists.laptop.org/listinfo/devel > ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Re: [sugar] OLPC priorities for Sugar in the August release
On Wed, May 14, 2008 at 01:00:32PM -0700, John Gilmore wrote: > I've often wanted the close-box to be in the Frame itself, so that there's > a short and totally deterministic way to tell someone how to exit the > current application. Providing an obvious close-button outside of the activity is a good idea for other reasons such as the ability to close misbehaving activities. (Some would argue that the activity-button's 'close' palette entry is adequate, but I think we can do better without much trouble.) Michael ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Re: Keyboard layout issues
Sayamindu, Thanks for the awesome writeup. Do you feel comfortable enough with Fedora packaging to take responsibility for providing 703-compatible packages containing these changes? Thanks, Michael Status fragment: #6973 PKG ??? (Production problem: Haiti keyboard doesn't match keyboard mappings) #6945 PKG ??? (MFG Problem: Ethiopian keyboards don't provide English characters) #5996 ESC sayamindu (Mongolian, Devanagari keyboard/language testing) ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Re: What's the latest "safe" Joyride build to use?
On 14.05.2008, at 21:47, Marcus Leech wrote: > I updgraded from 1918 to 1946 today, and found that most of the > activities had disappeared, they weren't even > in the "list" view. You have to install activities manually. Here is a script that may help: http://dev.laptop.org/~bert/joyride-activities.py To use it, press ctrl-alt-f1 (mesh key) to get a login, press enter, then type these commands: su - olpc wget http://dev.laptop.org/~bert/joyride-activities.py python joyride-activities.py Please report back if that worked. - Bert - ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Re: [sugar] OLPC priorities for Sugar in the August release
> Specifically, check out Feel free to look at the latest at > wiki.laptop.org/go/Designs/Frame for details on the changes which will > imbue the Frame with much more utility. We still need to address the > usability concerns, naturally, ... See dev.laptop.org/ticket/4910 for a critique of the usability of how available controls were placed in the old Frame, Activity bar, and "my program name" bar. I hope that as you move things in and out of the Frame, you'll also adjust the designs of the other control bars (that the Frame often obscures). I've often wanted the close-box to be in the Frame itself, so that there's a short and totally deterministic way to tell someone how to exit the current application. Finally, eBook mode should be seriously considered in the redesign, so that most of the controls are readily available from the ten available buttons. (Rather than having the controls in eBook mode be non-WSYWIG). http://dev.laptop.org/ticket/1310 talks about that. Don Hopkins had some great ideas and prototypes, too. John ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
What's the latest "safe" Joyride build to use?
I updgraded from 1918 to 1946 today, and found that most of the activities had disappeared, they weren't even in the "list" view. -- Marcus LeechMail: Dept 1A12, M/S: 04352P16 Security Standards AdvisorPhone: (ESN) 393-9145 +1 613 763 9145 Strategic Standards Nortel Networks [EMAIL PROTECTED] ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Keyboard layout issues
Hi all, For the past few days have been looking at the various keyboard related issues, especially the following http://dev.laptop.org/ticket/6973: (Production problem: Haiti keyboard doesn't match keyboard mappings) http://dev.laptop.org/ticket/6945: (MFG Problem: Ethiopian keyboards don't provide English characters) http://dev.laptop.org/ticket/5996 (Mongolian, Devanagari keyboard/language testing) and I think I have managed to find solutions for all of the above. For issue #6973 (Haiti keyboard), Arjun had already found the source of the problem - a typo in the ca symbols file in the xkeyboard-config package. I have attached a patch to the ticket (http://dev.laptop.org/attachment/ticket/6973/6973.patch). Issue #6945 (Ethiopean keyboard) confused me significantly, and in the end, the cause of the issue was found to be a GTK Input Module (Amharic ET+) which was getting loaded due to the locale being set to am_ET.UTF-8. This essentially overrode the XKB settings that we have. This can happen for a few other locales as well (eg: Thai), and I have added a small one liner patch to the olpc-session file (a part of olpc-utils) which should take care of the issue (http://dev.laptop.org/attachment/ticket/6945/6945.patch). Issue 5996 (Mongolian/Devanagari keyboard) is pretty straight forward. The testing was apparently done on build 656, which does not have the updated symbol files. Build 703 works fine for me. Are we planning to deploy build 656 in Mongolia in the near future ? If we are not, I think that the ticket can be safely closed as "Obsolete" or "Invalid". Testing the keyboard layouts = I ran into some problems initially, since I was not familiar with how to set the manufacturing data. I have a B4 with me currently, which had only the LA tag, and none of the K* tags. I added the K* tags with the add-tag command from the OFW prompt, and when I needed to change the tags, I used to change-tag command (in some cases, where the values associated with the tags had different lengths, I had to use $delete-tag and then add-tag again). After the tags had been changed, I did a clean install of the os image via copy-nand. Example set up for testing Mongolian keyboard layout (relevant data is available at http://wiki.laptop.org/go/Mfg-data) At the OFW prompt add-tag KM olpc add-tag KL us,mn add-tag KV olpc2,olpc add-tag LO mn_MN.UTF-8 copy-nand u:\os703.img boot Once the Sugar setup screen comes up, verify if the initial inputs are in basic Latin (following the QWERTY layout). If the basic Latin is OK, press the layout toggle key (the key to the right of the "up" arrow key), and verify that the keypresses now generate Mongolian (Cyrillic??) characters (as per http://wiki.laptop.org/go/OLPC_Mongolian_Keyboard). Comments on the patches are welcome :-). Thanks, Sayamindu -- Sayamindu Dasgupta [http://sayamindu.randomink.org/ramblings] ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Re: [sugar] OLPC priorities for Sugar in the August release
On Wed, May 14, 2008 at 5:56 AM, Marco Pesenti Gritti <[EMAIL PROTECTED]> wrote: > On Wed, May 14, 2008 at 11:48 AM, Tomeu Vizoso <[EMAIL PROTECTED]> wrote: > > * More notifications? > > > > How can we know which areas in the UI are in most need of more feedback? > > > Eben posted about this on the internal mailing list. I think we should > turn his suggestions into tickets. Yup. I've got a list I'd like to see fixed up. I suspect that list mostly coincides with areas that people in the field would want feedback, but they may have additional areas I missed. > No idea in regards to the manual. What we certainly can/should do is > to finish up the redesign. Eben had a list of regressions, but he is > lazy and didn't post tickets for them yet... Designers :P > Sorry! I have a short list of tickets to file, and a number of others to update with design sketches as soon as the mockups are finished. I'll likely spend tomorrow writing tickets for the critical regressions and feedback bugs I think we need to fix. - Eben ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Re: [sugar] OLPC priorities for Sugar in the August release
> > > Is the solution currently in joyride satisfactory for the August > > release? > > > > Personally I think it's OK. It won't hurt to try to do better if we > > have time obviously... > > Let me clarify. I think activities launch is OK. Stuff like frame > responsiveness and activity switch should be improved. There are a handful of rainbow bugs that need to be fixed before we should actually ship the thing (specifically #6989), but I'm not aware of other major risks there. I still don't really have enough information about whether the incompatibilities in spool format that I mentioned before warrant bumping the spool-format version identifier from 1->2 (which would require a minor change to the DS). Michael ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Re: [sugar] OLPC priorities for Sugar in the August release
On Wed, May 14, 2008 at 12:26 PM, Greg Smith (gregmsmi) <[EMAIL PROTECTED]> wrote: > Hi Tomeu, Walter, et al, > > FYI Uruguay already posted some presentations and training based on the > existing UI. > > See: http://www.ceibalflorida.blogspot.com/ posts from April. I'm not up > to speed on proposed Sugar changes so it may have minimal impact. Feel free to look at the latest at wiki.laptop.org/go/Designs. > Thinking about the "hot corners" pop-up frame thingy, Nepal asked that > be deprecated and I agree based on my personal experience and that of my > kids. The only thing I have heard people use it for is the copy and > paste functionality. Waveplace lead mentioned that and its used in the > Uruguay training presentation linked above. Specifically, check out Feel free to look at the latest at wiki.laptop.org/go/Designs/Frame for details on the changes which will imbue the Frame with much more utility. We still need to address the usability concerns, naturally, and as Marco mentioned we have a few things to try in that regard, but it's just as important to me that the Frame actually serve vital roles on the system in the first place! - Eben ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Re: [sugar] OLPC priorities for Sugar in the August release
Pentagram and myself have been putting effort into solidifying designs for Sugar Groups. In a first rendition, it shouldn't require much more than an extension of the invitation framework to support group invites, and a simple UI for creating a group. I think even without advanced features such as bulletin boards, implicit group chats, and other details we've talked about surrounding the idea in the past, this will be a big way to improve the collaboration space even by making it extremely simple to say "share with ". I aim to have some screenshots which present this in a manner which might be feasible for August (if not, definitely Dec.) posted to the Designs page on the wiki by the weekend. - Eben On Wed, May 14, 2008 at 5:53 AM, Guillaume Desmottes <[EMAIL PROTECTED]> wrote: > Le mercredi 14 mai 2008 à 11:48 +0200, Tomeu Vizoso a écrit : > > > * Groups, models for groups (Peru, Hernan) > > > > Is this groups in Sugar? Do we have some kind of requirements? > > There are some discussions about groups here: > https://dev.laptop.org/ticket/4043 > > > G. > > > > ___ > Devel mailing list > Devel@lists.laptop.org > http://lists.laptop.org/listinfo/devel > ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Re: [sugar] OLPC priorities for Sugar in the August release
Has Firefox 3- B5 landed in Joyride? it is much faster starting up than the FF3B2 we had in the older systems (not to mention immensely better on memory usage). - Jim On Wed, 2008-05-14 at 14:57 +0200, Marco Pesenti Gritti wrote: > On Wed, May 14, 2008 at 1:46 PM, Mikus Grinbergs <[EMAIL PROTECTED]> wrote: > > > * More responsive UI - faster launch of activities > > > > > > Is the solution currently in joyride satisfactory for the August release? > > > > I use a recent Joyride on my G1G1. My average time to launch Browse > > (from the time I click in the F3 Activity Ring on the Browse icon, > > to the time when I can click on the entry field in Browse itself (so > > that I can start typing in an URL) is 25 seconds. > > If you could download the latest joyride, time startup and open a > ticket that would be useful. 25 seconds are too much obviously. > > Please take both time on the very first start and after a reboot, > xulrunner does component registration on the very first start which > could be expensive > > Thanks. > Marco > ___ > Devel mailing list > Devel@lists.laptop.org > http://lists.laptop.org/listinfo/devel -- Jim Gettys <[EMAIL PROTECTED]> One Laptop Per Child ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
New faster build 1947
http://xs-dev.laptop.org/~cscott/olpc/streams/faster/build1947 Changes in build 1947 from build: 1946 Size delta: 0.00M -rdesktop 1.5.0-2.fc7 +rdesktop 1.6.0-1.fc7 -libvorbis 1:1.1.2-3.fc7 +libvorbis 1:1.1.2-4.fc7 --- Changes for rdesktop 1.6.0-1.fc7 from 1.5.0-2.fc7 --- + Update to 1.6.0 -- This mail was automatically generated See http://dev.laptop.org/~rwh/announcer/faster-pkgs.html for aggregate logs See http://dev.laptop.org/~rwh/announcer/joyride_vs_update1.html for a comparison ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Re: [sugar] OLPC priorities for Sugar in the August release
> One low-hanging fruit for faster activity start is having activity install > compile .pyc files There are .pyc files here and there in the XO core software. I do not expect to myself be changing Activity code -- but if the OLPC is supposed to be "easy enough for a kid to program" - *someone* will. For myself, I don't have wireless at home; to make my communications setup work properly I need to "patch" some "telepathy/presence" .py files. [Having changed a .py file, I delete the same-name .pyc file, and reboot.] I'm not sure what created those corresponding .pyc files. I __wish__ there was an easy-to-find GUIDE explaining how and when the various .pyc files were installed. mikus ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
New joyride build 1947
http://xs-dev.laptop.org/~cscott/olpc/streams/joyride/build1947 Changes in build 1947 from build: 1946 Size delta: 0.00M -rdesktop 1.5.0-2.fc7 +rdesktop 1.6.0-1.fc7 -libvorbis 1:1.1.2-3.fc7 +libvorbis 1:1.1.2-4.fc7 --- Changes for rdesktop 1.6.0-1.fc7 from 1.5.0-2.fc7 --- + Update to 1.6.0 -- This mail was automatically generated See http://dev.laptop.org/~rwh/announcer/joyride-pkgs.html for aggregate logs See http://dev.laptop.org/~rwh/announcer/joyride_vs_update1.html for a comparison ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Re: [sugar] OLPC priorities for Sugar in the August release
On Wed, May 14, 2008 at 6:26 PM, Greg Smith (gregmsmi) <[EMAIL PROTECTED]> wrote: > Thinking about the "hot corners" pop-up frame thingy, Nepal asked that > be deprecated and I agree based on my personal experience and that of my > kids. The only thing I have heard people use it for is the copy and > paste functionality. Waveplace lead mentioned that and its used in the > Uruguay training presentation linked above. Simon is working on making this an option. We would still need to decide about the default obviously... Marco ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Re: [sugar] OLPC priorities for Sugar in the August release
Hi Tomeu, Walter, et al, FYI Uruguay already posted some presentations and training based on the existing UI. See: http://www.ceibalflorida.blogspot.com/ posts from April. I'm not up to speed on proposed Sugar changes so it may have minimal impact. Thinking about the "hot corners" pop-up frame thingy, Nepal asked that be deprecated and I agree based on my personal experience and that of my kids. The only thing I have heard people use it for is the copy and paste functionality. Waveplace lead mentioned that and its used in the Uruguay training presentation linked above. If you do take out the popup frame make sure to come up with a new copy and paste mechanism. Uruguay also has a multi-day training planned for June: http://www.inscripcioncursotics.8m.com/programa.htm They're probably OK with updating their docs but you should bring them in the loop ahead of time, if possible. BTW can you ask Peru to post their manual somewhere? Colombia just asked for Spanish documentation and I'm sure it will be useful for many other countries too. Thanks, Greg S * Message: 2 Date: Wed, 14 May 2008 08:29:39 -0400 From: "Walter Bender" <[EMAIL PROTECTED]> Subject: Re: [sugar] OLPC priorities for Sugar in the August release To: "Tomeu Vizoso" <[EMAIL PROTECTED]> Cc: OLPC Developer's List , Sugar Mailing List <[EMAIL PROTECTED]> Message-ID: <[EMAIL PROTECTED]> Content-Type: text/plain; charset=ISO-8859-1 > * New Sugar UI? Should continue with some specific goals on how to > roll out the new features so it won't be difficult for people. Wad > brought up the issue that Peru has already started printing a manual > based on the old UI. I've been talking with the Peru folks about this too. The percentage of the user manual that is dependent on the old UI is only in a very few places. If the new UI really simplifies sharing, activity management, and notifications, then I think they'd be more than willing to accept the change. I'll talk to them again when I see them next week. -walter ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Volunteers/help for sugar/cerebro integration
Hi, I'm looking for help/volunteers to assist with the integration process of cerebro [1] into sugar. Cerebro offers a fast and efficient data transport and collaboration mechanism between tens of XOs in simple mesh. Using cerebro we can make the simple mesh scale as well as the current limit using school server WiFi and improve the collaboration experience in many application scenarios. The integration can be done in either of these two ways: 1) Create a new telepathy connection manager that will act as interface between telepathy and cerebro. Some preliminary work already done by Michael Stone [2]. 2) Add the necessary callbacks in cerebro that will allow it to act as presence service to sugar directly [3]. Cerebro provides the necessary functionality, but lacks several dbus callbacks. Questions/comments? [1] http://wiki.laptop.org/go/Cerebro [2] http://dev.laptop.org/git?p=users/mstone/telepathy-cerebro;a=tree;hb=HEAD [3] /usr/lib/python2.5/site-packages/sugar/presence/presenceservice.py Thanks, Pol -- Polychronis Ypodimatopoulos Graduate student Viral Communications MIT Media Lab Tel: +1 (617) 459-6058 http://www.mit.edu/~ypod/ ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
New faster build 1946
http://xs-dev.laptop.org/~cscott/olpc/streams/faster/build1946 Changes in build 1946 from build: 1940 Size delta: 0.00M -telepathy-gabble 0.7.5-1.olpc2 +telepathy-gabble 0.7.6-1.olpc2 --- Changes for telepathy-gabble 0.7.6-1.olpc2 from 0.7.5-1.olpc2 --- + Update to 0.7.6 + Move html docs to correct dir. -- This mail was automatically generated See http://dev.laptop.org/~rwh/announcer/faster-pkgs.html for aggregate logs See http://dev.laptop.org/~rwh/announcer/joyride_vs_update1.html for a comparison ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
New joyride build 1946
http://xs-dev.laptop.org/~cscott/olpc/streams/joyride/build1946 Changes in build 1946 from build: 1938 Size delta: 0.00M -telepathy-gabble 0.7.5-1.olpc2 +telepathy-gabble 0.7.6-1.olpc2 --- Changes for telepathy-gabble 0.7.6-1.olpc2 from 0.7.5-1.olpc2 --- + Update to 0.7.6 + Move html docs to correct dir. -- This mail was automatically generated See http://dev.laptop.org/~rwh/announcer/joyride-pkgs.html for aggregate logs See http://dev.laptop.org/~rwh/announcer/joyride_vs_update1.html for a comparison ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Re: [sugar] OLPC priorities for Sugar in the August release
> If you could download the latest joyride, time startup and open a > ticket that would be useful. 25 seconds are too much obviously. I took the time on Joyride 1932, which had been manually updated (via yum install) with cups-libs 1:1.2.12-11.fc7 and telepathy-glib 0.7.8-1.olpc2, to bring it up to equivalence with Joyride 1938 (and following). I __doubt__ that downloading the latest joyride would make any difference. Why should I open up a ticket? I don't have my G1G1 instrumented, to *prove* how many seconds it took. I was not the one who said "too much". > Please take both time on the very first start and after a reboot, I don't understand how a "very first start" differs from a "reboot". I get 25 seconds when clicking on the Browse icon is the first thing I do after a reboot. It currently is difficult for me to restart Browse after having closed it - Rainbow won't let me (ticket #6989). Just to check that 'faster' is no better, I installed faster 1944. On my G1G1, it too takes the same 25 seconds to bring up Browse. mikus ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Re: [sugar] OLPC priorities for Sugar in the August release
One low-hanging fruit for faster activity start is having activity install compile .pyc files, with (tiny) extra points if the .pyc gets hints to not use jffs2 compression. This is on my gameplan with the bundle format update stuff, but I have gotten stuck on the signatures (openssl cannot read ssh public keys) so I am behind on that. I had hoped to finish it in my free time this week but starting next week I cannot be so sure I'll have time. On Wed, May 14, 2008 at 6:57 AM, Marco Pesenti Gritti <[EMAIL PROTECTED]> wrote: > On Wed, May 14, 2008 at 1:46 PM, Mikus Grinbergs <[EMAIL PROTECTED]> wrote: > > > * More responsive UI - faster launch of activities > > > > > > Is the solution currently in joyride satisfactory for the August > release? > > > > I use a recent Joyride on my G1G1. My average time to launch Browse > > (from the time I click in the F3 Activity Ring on the Browse icon, > > to the time when I can click on the entry field in Browse itself (so > > that I can start typing in an URL) is 25 seconds. > > If you could download the latest joyride, time startup and open a > ticket that would be useful. 25 seconds are too much obviously. > > Please take both time on the very first start and after a reboot, > xulrunner does component registration on the very first start which > could be expensive > > Thanks. > Marco > ___ > Sugar mailing list > [EMAIL PROTECTED] > http://lists.laptop.org/listinfo/sugar > ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Re: [sugar] OLPC priorities for Sugar in the August release
On Wed, May 14, 2008 at 1:46 PM, Mikus Grinbergs <[EMAIL PROTECTED]> wrote: > > * More responsive UI - faster launch of activities > > > > Is the solution currently in joyride satisfactory for the August release? > > I use a recent Joyride on my G1G1. My average time to launch Browse > (from the time I click in the F3 Activity Ring on the Browse icon, > to the time when I can click on the entry field in Browse itself (so > that I can start typing in an URL) is 25 seconds. If you could download the latest joyride, time startup and open a ticket that would be useful. 25 seconds are too much obviously. Please take both time on the very first start and after a reboot, xulrunner does component registration on the very first start which could be expensive Thanks. Marco ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Re: [sugar] OLPC priorities for Sugar in the August release
was that joyride or the faster build? -walter On Wed, May 14, 2008 at 7:46 AM, Mikus Grinbergs <[EMAIL PROTECTED]> wrote: >> * More responsive UI - faster launch of activities >> >> Is the solution currently in joyride satisfactory for the August release? > > I use a recent Joyride on my G1G1. My average time to launch Browse > (from the time I click in the F3 Activity Ring on the Browse icon, > to the time when I can click on the entry field in Browse itself (so > that I can start typing in an URL) is 25 seconds. > > Is that satisfactory ? > > mikus > > > ___ > Devel mailing list > Devel@lists.laptop.org > http://lists.laptop.org/listinfo/devel > ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Re: [sugar] OLPC priorities for Sugar in the August release
> * More responsive UI - faster launch of activities > > Is the solution currently in joyride satisfactory for the August release? I use a recent Joyride on my G1G1. My average time to launch Browse (from the time I click in the F3 Activity Ring on the Browse icon, to the time when I can click on the entry field in Browse itself (so that I can start typing in an URL) is 25 seconds. Is that satisfactory ? mikus ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Re: Help Running Non-python program on OLPC
2008/5/14 shivaprasad javali <[EMAIL PROTECTED]>: > Hi All, > > I am trying to install a new activity written in c++ on the OLPC. > I tried writing a python script which just launches my application and > setting the approproate properties in the activity.info file. It launched > allright but i am getting two windows one blank window for the oython script > and another one containing my application . I want to know how to make my > application sit on top of the window for the py script itself. Any help > would be greatly appreciated. have you checked out the sugarizing page on the wiki? http://wiki.laptop.org/go/Sugarizing they have some tips there bobby ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Re: [sugar] OLPC priorities for Sugar in the August release
> * New Sugar UI? Should continue with some specific goals on how to > roll out the new features so it won't be difficult for people. Wad > brought up the issue that Peru has already started printing a manual > based on the old UI. I've been talking with the Peru folks about this too. The percentage of the user manual that is dependent on the old UI is only in a very few places. If the new UI really simplifies sharing, activity management, and notifications, then I think they'd be more than willing to accept the change. I'll talk to them again when I see them next week. -walter ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Help Running Non-python program on OLPC
Hi All, I am trying to install a new activity written in c++ on the OLPC. I tried writing a python script which just launches my application and setting the approproate properties in the activity.info file. It launched allright but i am getting two windows one blank window for the oython script and another one containing my application . I want to know how to make my application sit on top of the window for the py script itself. Any help would be greatly appreciated. Thanks Shivaprasad ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Re: [PATCH stable] Separate multicast configuration for mesh and wlan interfaces.
> -- http://lkml.org/lkml/2008/2/21/334 +1 > -- http://lkml.org/lkml/2007/6/23/189 +1 I always mostly create patches which are checkpatch.pl clean, even following the 80 columns rule mostly, but sometimes I delibertaly ignored this rule. For me, it should be a 132 columns rule :-) ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Re: [sugar] OLPC priorities for Sugar in the August release
On Wed, May 14, 2008 at 11:48 AM, Tomeu Vizoso <[EMAIL PROTECTED]> wrote: > * Datastore upgrade > > Which are the requirements for the DataStore in the August release? I think it was proposed to focus on backups for August and "address" stability concerns that way. At this date and with all the disagreements exposed by the thread about your rewrite, I think it's sadly the safest option. Marco ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Re: [sugar] OLPC priorities for Sugar in the August release
Le mercredi 14 mai 2008 à 11:48 +0200, Tomeu Vizoso a écrit : > * Groups, models for groups (Peru, Hernan) > > Is this groups in Sugar? Do we have some kind of requirements? There are some discussions about groups here: https://dev.laptop.org/ticket/4043 G. ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Re: [sugar] OLPC priorities for Sugar in the August release
On Wed, May 14, 2008 at 11:56 AM, Marco Pesenti Gritti <[EMAIL PROTECTED]> wrote: > On Wed, May 14, 2008 at 11:48 AM, Tomeu Vizoso <[EMAIL PROTECTED]> wrote: > > Hi all, > > > > have some doubts about http://wiki.laptop.org/go/Priorities-2008 > > > > * More responsive UI - faster launch of activities > > > > Is the solution currently in joyride satisfactory for the August release? > > > Personally I think it's OK. It won't hurt to try to do better if we > have time obviously... Let me clarify. I think activities launch is OK. Stuff like frame responsiveness and activity switch should be improved. Marco ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Re: [sugar] OLPC priorities for Sugar in the August release
On Wed, May 14, 2008 at 11:48 AM, Tomeu Vizoso <[EMAIL PROTECTED]> wrote: > Hi all, > > have some doubts about http://wiki.laptop.org/go/Priorities-2008 > > * More responsive UI - faster launch of activities > > Is the solution currently in joyride satisfactory for the August release? Personally I think it's OK. It won't hurt to try to do better if we have time obviously... > * More notifications? > > How can we know which areas in the UI are in most need of more feedback? Eben posted about this on the internal mailing list. I think we should turn his suggestions into tickets. Trying to get some user feedback would also be useful, even just by the developers community. > * New Sugar UI? Should continue with some specific goals on how to > roll out the new features so it won't be difficult for people. Wad > brought up the issue that Peru has already started printing a manual > based on the old UI. > > How can I help regarding this? No idea in regards to the manual. What we certainly can/should do is to finish up the redesign. Eben had a list of regressions, but he is lazy and didn't post tickets for them yet... Designers :P > * Groups, models for groups (Peru, Hernan) > > Is this groups in Sugar? Do we have some kind of requirements? I think this refers to collaboration group. With collaboration still so unstable (and lack of clarity about future architecture) I don't personally think it's wise to push down on this. > * Sugar on other distro (mgmt) > > On which other distro? Which are the requirements? What means "(mgmt)"? Management I think. Marco ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Re: [PATCH stable] Separate multicast configuration for mesh and wlan interfaces.
On Wed, 2008-05-14 at 02:46 -0700, Andrew Morton wrote: > On Wed, 14 May 2008 10:39:19 +0100 David Woodhouse <[EMAIL PROTECTED]> wrote: > > > On Wed, 2008-05-14 at 02:17 -0700, Andrew Morton wrote: > > > On Wed, 14 May 2008 09:44:12 +0100 David Woodhouse <[EMAIL PROTECTED]> > > > wrote: > > > > > > > I'm sorry if that offends you, but making code more readable helps me > > > > find real bugs, and that is more important to me than the 80-column > > > > rule. > > > > > > Code which wraps due to excess line sizes is less readable that code > > > which avoids this. Your rhetorical trick of saying it is "more > > > readable" is of course unsubstantiated and incorrect, which makes > > > everything else you say baseless. > > > > Andrew, I'm disappointed in you. You actually _removed_ a concrete > > example which substantiated my observation (an observation which Linus > > has also made), and then called it 'unsubstantiated and incorrect'. > > > > Some random individual anecdote is neither here nor there. I'm sure > there are counter-anecdotes, but so what? > Code which wraps in an 80-col display is hard to read in an 80-col > display. Often very hard. Your right. -- dwmw2 ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
OLPC priorities for Sugar in the August release
Hi all, have some doubts about http://wiki.laptop.org/go/Priorities-2008 * More responsive UI - faster launch of activities Is the solution currently in joyride satisfactory for the August release? * More notifications? How can we know which areas in the UI are in most need of more feedback? * New Sugar UI? Should continue with some specific goals on how to roll out the new features so it won't be difficult for people. Wad brought up the issue that Peru has already started printing a manual based on the old UI. How can I help regarding this? * May help push the bug patch release in order to get some of these other features out without requiring a new UI. Can you please expand on this? Which new features can be offered without the new UI? * Datastore upgrade Which are the requirements for the DataStore in the August release? * Groups, models for groups (Peru, Hernan) Is this groups in Sugar? Do we have some kind of requirements? * Sugar on other distro (mgmt) On which other distro? Which are the requirements? What means "(mgmt)"? Thanks, Tomeu ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Re: [PATCH stable] Separate multicast configuration for mesh and wlan interfaces.
On Wed, 14 May 2008 10:39:19 +0100 David Woodhouse <[EMAIL PROTECTED]> wrote: > On Wed, 2008-05-14 at 02:17 -0700, Andrew Morton wrote: > > On Wed, 14 May 2008 09:44:12 +0100 David Woodhouse <[EMAIL PROTECTED]> > > wrote: > > > > > I'm sorry if that offends you, but making code more readable helps me > > > find real bugs, and that is more important to me than the 80-column > > > rule. > > > > Code which wraps due to excess line sizes is less readable that code > > which avoids this. Your rhetorical trick of saying it is "more > > readable" is of course unsubstantiated and incorrect, which makes > > everything else you say baseless. > > Andrew, I'm disappointed in you. You actually _removed_ a concrete > example which substantiated my observation (an observation which Linus > has also made), and then called it 'unsubstantiated and incorrect'. > Some random individual anecdote is neither here nor there. I'm sure there are counter-anecdotes, but so what? Code which wraps in an 80-col display is hard to read in an 80-col display. Often very hard. ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Re: [PATCH stable] Separate multicast configuration for mesh and wlan interfaces.
On Wed, 2008-05-14 at 02:17 -0700, Andrew Morton wrote: > On Wed, 14 May 2008 09:44:12 +0100 David Woodhouse <[EMAIL PROTECTED]> wrote: > > > I'm sorry if that offends you, but making code more readable helps me > > find real bugs, and that is more important to me than the 80-column > > rule. > > Code which wraps due to excess line sizes is less readable that code > which avoids this. Your rhetorical trick of saying it is "more > readable" is of course unsubstantiated and incorrect, which makes > everything else you say baseless. Andrew, I'm disappointed in you. You actually _removed_ a concrete example which substantiated my observation (an observation which Linus has also made), and then called it 'unsubstantiated and incorrect'. That's somewhat disingenuous of you. -- dwmw2 ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Re: [PATCH stable] Separate multicast configuration for mesh and wlan interfaces.
On Wed, 14 May 2008 09:44:12 +0100 David Woodhouse <[EMAIL PROTECTED]> wrote: > I'm sorry if that offends you, but making code more readable helps me > find real bugs, and that is more important to me than the 80-column > rule. Code which wraps due to excess line sizes is less readable that code which avoids this. Your rhetorical trick of saying it is "more readable" is of course unsubstantiated and incorrect, which makes everything else you say baseless. ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Re: [PATCH stable] Separate multicast configuration for mesh and wlan interfaces.
On Tue, 2008-05-13 at 19:12 -0400, Andres Salomon wrote: > Can we come to a consensus for the sake of outside contributors? > Rather than telling the cozybit folks one thing, and having checkpatch.pl > and CodingStyle claim another (Dave, surely you wouldn't argue against > using checkpatch?), can we get our stories straight? Please? Checkpatch is a useful tool but I use it with the line length check patched out, and I take the rest of its output with a pinch of salt. As for getting our stories straight... let's defer to Linus, who at various times has said the following: >> Quite frankly, I've several times been *this* close (holds up fingers so >> you can't even see between them) to just remove checkpatch entirely. >> >> I'm personally of the opinion that a lot of checkpatch "fixes" are >> anything but. That mainly concerns fixing overlong lines (where the >> "fixed" version is usually worse than the original), but it's been true >> for some other warnings too." -- http://lkml.org/lkml/2008/2/21/334 >> Quite frankly, I personally am considering removing "checkpatch.pl". >> That thing is just a nazi dream. That hard-coded 80-character limit >> etc is just bad taste. >> >> Dammit, code cleanliness is not about "automated and mindless slavish >> following of rules". A process that is too inflexible is a *bad* process. >> I'd much rather have a few 80+ character lines than stupid and unreadable >> line wrapping just because the line hit 87 characters in length. >> >> I don't have 25 lines on a screen either. -- http://lkml.org/lkml/2007/6/23/189 -- dwmw2 ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Re: [PATCH stable] Separate multicast configuration for mesh and wlan interfaces.
On Tue, 2008-05-13 at 15:06 -0700, Andrew Morton wrote: > On Tue, 13 May 2008 22:59:26 +0100 > David Woodhouse <[EMAIL PROTECTED]> wrote: > > > On Tue, 2008-05-13 at 12:30 -0700, Andrew Morton wrote: > > > On Tue, 13 May 2008 13:20:19 -0400 > > > Andres Salomon <[EMAIL PROTECTED]> wrote: > > > > > > > On Tue, 13 May 2008 15:45:39 +0100 > > > > David Woodhouse <[EMAIL PROTECTED]> wrote: > > > > > > > > > On Tue, 2008-05-13 at 15:38 +0100, David Woodhouse wrote: > > > > > > > > > > > > And even without that, it doesn't seem to do the right thing. Set > > > > > > IFF_PROMISC mode on one interface, then on the other, then clear it > > > > > > on the first it should remain set in hardware. And AFAICT it > > > > > > doesn't. > > > > > > > > > > > > I'll see if I can make it work > > > > > > > > > > Hm, a single cup of tea mostly achieves that; sorry :) > > > > > > > > > > I was missing the fact that priv->packetfilter[] is now an array. > > > > > It got a bit clearer after I reformatted it to stop trying to fit in > > > > > 80 columns. Sometimes the code just doesn't fit; it's painful to try > > > > > to make it. > > > > > > > > > > > > > Gosh, I sure wish you, Andrew, checkpatch.pl, and Ingo[0] were all on > > > > the same page > > > > regarding that.. it would sure make my life easier. > > > > > > > > > > David is off in his own little world on this and can be safely ignored. > > > > > > Meanwhile the rest of us are forced to stare at crocks of shit like > > > http://userweb.kernel.org/~akpm/x.jpg, wondering who hates us and why. > > > > I think the large amount of whitespace in the screenshot at > > http://david.woodhou.se/narrow.png shows quite effectively why I think > > you're talking nonsense on this particular topic. > > That's an 80-column display. Seems to be something like an 80-row display too. Even if you have one of those weird rotatable monitors and you've put it into portrait mode, it's not particularly realistic. Mine, on the other hand, is less contrived -- it's a web browser which is no wider than it _has_ to be these days, to view news.bbc.co.uk. And the code in question is not the example you chose, which I would accept patches for, but lbs_set_if_multicast_list() -- shown at http://david.woodhou.se/then-and-now.html in both the original 80-column and the more readable slightly wider versions. > If that's the best your can do, you have nothing. In the past, after fixing the 80-column nonsense to make code more readable, I've immediately spotted bugs which weren't apparent before (commit f6f0f818, for example). I do try to keep code within 80 columns where I can; it's a reasonable guideline -- but I also accept that sometimes it just doesn't fit, and it would be foolish and counter-productive to try to force it. I'm sorry if that offends you, but making code more readable helps me find real bugs, and that is more important to me than the 80-column rule. -- dwmw2 ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
Re: [PATCH stable] Separate multicast configuration for mesh and wlan interfaces.
On Tue, 2008-05-13 at 16:15 -0700, Andrew Morton wrote: > On Tue, 13 May 2008 19:12:27 -0400 Andres Salomon <[EMAIL PROTECTED]> wrote: > > > And FWIW, I like the 80 char limit _except_ when it comes to strings. > > I don't normally bother about the strings, unless it is obvious that > the surrounding code has worked to prevent them from wrapping (and if I > notice that). > > Or if they make code particularly hard to read and alter. I've seen > some which wander out to column 130, which is getting daft. > > The code at http://userweb.kernel.org/~akpm/x.jpg has short strings, > but it has gone and stuffed the _arguments_ onto the same line too, which > is just obnoxious. I would probably accept patches to move the arguments onto the next line; I don't think that would make the overall code less readable. In fact, I would normally put the arguments on the next line these days anyway -- but that particular piece of debugging code dates from before all this pointless fuss about 80 columns got started, so it was never an issue. It could probably do with printk priorities too, while we're at it. -- dwmw2 ___ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel