On 29/04/2025 21.48, Pierrick Bouvier wrote:
...
I'm not keen to have a default target set, but it's a personal opinion based
on fear of "implicit smart choice hurts", so I'll be happy to change my mind
with a good argument for it.
No default target, please! We've seen this with the default ma
On Tue, Apr 29, 2025 at 13:03:12 +0100, Daniel P. Berrangé wrote:
> On Tue, Apr 29, 2025 at 01:42:22PM +0200, Peter Krempa wrote:
> > On Tue, Apr 29, 2025 at 12:36:40 +0100, Daniel P. Berrangé wrote:
> > > On Tue, Apr 15, 2025 at 04:13:08AM -0400, Narayana Murty N wrote:
> > > > Add POWER11 as a su
On 29/04/2025 15.15, Daniel P. Berrangé wrote:
We deprecate versioned machine types on a fixed schedule. This allows us
to auto-generate a paragraph in the deprecated.rst document that always
has accurate version info.
Signed-off-by: Daniel P. Berrangé
---
docs/about/deprecated.rst | 7 +
On 29/04/2025 15.15, Daniel P. Berrangé wrote:
When VERSION is set to a development snapshot (micro >= 50), or a release
candidate (micro >= 90) we have an off-by-1 in determining deprecation
and deletion thresholds for versioned machine types. In such cases we need
to use the next major/minor ve
On Tue, Apr 29, 2025 at 04:30:56PM +0200, Thomas Huth wrote:
> On 29/04/2025 15.15, Daniel P. Berrangé wrote:
> > This reverts commit c9fd2d9a48ee3c195cf83cc611b87b09f02f0013.
> >
> > When we introduced the specialized machine type deprecation policy, we
> > allow automatic deprecation to take eff
On 29/04/2025 15.15, Daniel P. Berrangé wrote:
This reverts commit c9fd2d9a48ee3c195cf83cc611b87b09f02f0013.
When we introduced the specialized machine type deprecation policy, we
allow automatic deprecation to take effect immediately, but blocked the
automatic deletion of machine types for 2 re
On Tue, Apr 29, 2025 at 12:19:50 +0200, Jiri Denemark via Devel wrote:
> From: Jiri Denemark
>
> This patch is effectively a NOP, but it fixes a logic bug and makes the
> heuristics more visible and easier to change should there be a need to
> do so in the future.
>
> We decide which CPU model i
On Tue, Apr 29, 2025 at 02:57:13PM +0200, Ján Tomko wrote:
> On a Tuesday in 2025, Daniel P. Berrangé via Devel wrote:
> > Over the years we've made various changes to stop hardcoding paths at
> > build time, but the work is incomplete.
> >
> > This bit us significantly in Fedora 42 where they hav
On Tue, Apr 29, 2025 at 15:27:44 +0200, Peter Krempa via Devel wrote:
> On Tue, Apr 29, 2025 at 12:19:49 +0200, Jiri Denemark via Devel wrote:
> > From: Jiri Denemark
> >
> > Refactor weight calculation to a separate virCPUx86WeightFeatures
> > function to avoid code duplication.
> >
> > Signed-
On Tue, Apr 29, 2025 at 12:19:49 +0200, Jiri Denemark via Devel wrote:
> From: Jiri Denemark
>
> Refactor weight calculation to a separate virCPUx86WeightFeatures
> function to avoid code duplication.
>
> Signed-off-by: Jiri Denemark
> ---
> src/cpu/cpu_x86.c | 83 ++---
We deprecate versioned machine types on a fixed schedule. This allows us
to auto-generate a paragraph in the deprecated.rst document that always
has accurate version info.
Signed-off-by: Daniel P. Berrangé
---
docs/about/deprecated.rst | 7 +++
docs/conf.py | 33 +++
If we change the deprecation logic in include/hw/boards.h, we must make
a corresponding change to docs/conf.py and docs/about/deprecated.rst.
Add comments to these files as a warning to future maintainers to keep
these files in sync.
Reviewed-by: Thomas Huth
Signed-off-by: Daniel P. Berrangé
---
We remove versioned machine types on a fixed schedule. This allows us
to auto-generate a paragraph in the removed-features.rst document that
always has accurate version info.
Signed-off-by: Daniel P. Berrangé
---
docs/about/removed-features.rst | 10 ++
docs/conf.py|
When VERSION is set to a development snapshot (micro >= 50), or a release
candidate (micro >= 90) we have an off-by-1 in determining deprecation
and deletion thresholds for versioned machine types. In such cases we need
to use the next major/minor version in threshold checks.
This adapts the depre
This reverts commit c9fd2d9a48ee3c195cf83cc611b87b09f02f0013.
When we introduced the specialized machine type deprecation policy, we
allow automatic deprecation to take effect immediately, but blocked the
automatic deletion of machine types for 2 releases. This ensured we
complied with the histori
Since we deprecate and remove versioned machine types on a fixed
schedule, we can automatically ensure that the docs reflect the
latest version info, rather than requiring manual updates on each
dev cycle.
The first patch in this series removes the hack which postponed
automatic removal of version
On a Tuesday in 2025, Daniel P. Berrangé via Devel wrote:
Over the years we've made various changes to stop hardcoding paths at
build time, but the work is incomplete.
This bit us significantly in Fedora 42 where they have merged the 'sbin'
and 'bin' dirs together. In the build environment we ha
On Tue, Apr 29, 2025 at 12:19:48 +0200, Jiri Denemark via Devel wrote:
> From: Jiri Denemark
>
> Signed-off-by: Jiri Denemark
> ---
> tests/cputest.c |1 +
> .../x86_64-cpuid-Atom-P5362-2-disabled.xml|9 +
> .../x86_64-cpuid-Atom-P5362-2-enabled.xml
On Tue, Apr 29, 2025 at 13:40:31 +0100, Daniel P. Berrangé wrote:
> On Tue, Apr 29, 2025 at 02:38:45PM +0200, Peter Krempa wrote:
> > On Tue, Apr 29, 2025 at 12:14:16 +0100, Daniel P. Berrangé via Devel wrote:
> > > From: Daniel P. Berrangé
> > >
> > > Allow virCommand to find 'tc' in $PATH. This
On Tue, Apr 29, 2025 at 12:14:20 +0100, Daniel P. Berrangé via Devel wrote:
> From: Daniel P. Berrangé
>
> Allow virCommand to find them in $PATH, which will always include 'sbin'
> since the openvz driver only operates in system mode.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> src/openvz/o
On Tue, Apr 29, 2025 at 12:14:19 +0100, Daniel P. Berrangé via Devel wrote:
> From: Daniel P. Berrangé
>
> Allow virCommand to find it in $PATH
>
> Signed-off-by: Daniel P. Berrangé
> ---
Now we can suggest a workaround in
https://gitlab.com/libvirt/libvirt/-/issues/757
defining a fake agent
On Tue, Apr 29, 2025 at 12:14:18 +0100, Daniel P. Berrangé via Devel wrote:
> From: Daniel P. Berrangé
>
> Change the mesonm rules to always enable the LVM driver if on a
s/mesonm/meson/
> Linux host, unless the meson options say not to.
>
> The virCommand APIs will return suitable runtime err
On Tue, Apr 29, 2025 at 02:38:45PM +0200, Peter Krempa wrote:
> On Tue, Apr 29, 2025 at 12:14:16 +0100, Daniel P. Berrangé via Devel wrote:
> > From: Daniel P. Berrangé
> >
> > Allow virCommand to find 'tc' in $PATH. This command is only used
> > when running privileged in which case both 'bin' a
On Tue, Apr 29, 2025 at 12:14:17 +0100, Daniel P. Berrangé via Devel wrote:
> From: Daniel P. Berrangé
>
> There is no reference to AUGPARSE, BLACK, FLAKE8, PDWTAGS or PYTEST conf
> variables anywhere, only the ${name}_prog meson variables are used.
>
> Signed-off-by: Daniel P. Berrangé
> ---
>
On Tue, Apr 29, 2025 at 12:14:16 +0100, Daniel P. Berrangé via Devel wrote:
> From: Daniel P. Berrangé
>
> Allow virCommand to find 'tc' in $PATH. This command is only used
> when running privileged in which case both 'bin' and 'sbin' dirs will
> be in $PATH, so virFindFileInPath will do the righ
On Tue, Apr 29, 2025 at 12:14:15 +0100, Daniel P. Berrangé via Devel wrote:
> From: Daniel P. Berrangé
>
> Allow virCommand to find 'ovs-vsctl' in $PATH. This command is only used
> when running privileged in which case both 'bin' and 'sbin' dirs will
> be in $PATH, so virFindFileInPath will do t
On Tue, Apr 29, 2025 at 12:14:14 +0100, Daniel P. Berrangé via Devel wrote:
> From: Daniel P. Berrangé
>
> Allow virCommand to find 'modprobe' & 'rmmod' in $PATH. These commands
> are only used when running privileged in which case both 'bin' and
> 'sbin' dirs will be in $PATH, so virFindFileInPa
On Tue, Apr 29, 2025 at 12:14:13 +0100, Daniel P. Berrangé via Devel wrote:
> From: Daniel P. Berrangé
>
> Allow virCommand to find 'mm-ctl' in $PATH. This command is only used
> when running privileged in which case both 'bin' and 'sbin' dirs will
> be in $PATH, so virFindFileInPath will do the
On Tue, Apr 29, 2025 at 12:14:12 +0100, Daniel P. Berrangé via Devel wrote:
> From: Daniel P. Berrangé
>
> Allow virCommand to find 'mdevctl' in $PATH. This command is only used
> when running privileged in which case both 'bin' and 'sbin' dirs will
> be in $PATH, so virFindFileInPath will do the
On Tue, Apr 29, 2025 at 12:14:11 +0100, Daniel P. Berrangé via Devel wrote:
> From: Daniel P. Berrangé
>
> Allow virCommand to find 'dmidecode' in $PATH. This command is only
> usable when running privileged since it relies on reading from a
> privileged kernel file. Thus we can assume both 'bin'
On Tue, Apr 29, 2025 at 12:14:10 +0100, Daniel P. Berrangé via Devel wrote:
> From: Daniel P. Berrangé
>
> There are no references to an "IP" conf variable nor a meson
> 'ip_prog' variable so the check serves no purpose.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> meson.build| 1
On Tue, Apr 29, 2025 at 12:14:09 +0100, Daniel P. Berrangé via Devel wrote:
> From: Daniel P. Berrangé
>
> Allow virCommand to find 'dmidecode' in $PATH. This command is only
> usable when running privileged since it relies on reading from a
> privileged kernel file. Thus we can assume both 'bin'
On Tue, Apr 29, 2025 at 13:03:12 +0100, Daniel P. Berrangé wrote:
> On Tue, Apr 29, 2025 at 01:42:22PM +0200, Peter Krempa wrote:
> > On Tue, Apr 29, 2025 at 12:36:40 +0100, Daniel P. Berrangé wrote:
> > > On Tue, Apr 15, 2025 at 04:13:08AM -0400, Narayana Murty N wrote:
> > > > Add POWER11 as a su
On Tue, 29 Apr 2025, Markus Armbruster wrote:
Pierrick Bouvier writes:
On 4/28/25 4:07 AM, Markus Armbruster wrote:
Peter Krempa writes:
So what should libvirt do once multiple targets are supported?
How do we query CPUs for each of the supported targets?
It's kind of a similar question
On Tue, Apr 29, 2025 at 01:42:22PM +0200, Peter Krempa wrote:
> On Tue, Apr 29, 2025 at 12:36:40 +0100, Daniel P. Berrangé wrote:
> > On Tue, Apr 15, 2025 at 04:13:08AM -0400, Narayana Murty N wrote:
> > > Add POWER11 as a supported cpu model for ppc64.
> > >
> > > Signed-off-by: Narayana Murty N
On Tue, Apr 29, 2025 at 12:14:08 +0100, Daniel P. Berrangé via Devel wrote:
> From: Daniel P. Berrangé
>
> There is no reference to PERL, PYTHON3, XMLLINT or XSLTPROC conf
> variables anywhere, only the ${name}_prog meson variables are
> used.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> meso
On Tue, Apr 29, 2025 at 12:14:07 +0100, Daniel P. Berrangé via Devel wrote:
> From: Daniel P. Berrangé
>
> Currently $(PERL) is expanding to nothing, but the spacing-check.pl test
> luckily still works via the shebang.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> build-aux/Makefile.in | 1 +
>
On Tue, Apr 29, 2025 at 12:14:06 +0100, Daniel P. Berrangé via Devel wrote:
> From: Daniel P. Berrangé
>
> Nothing in the tree references RST2MAN or RST2HTML5 variables, only
> rst2man_prog & rst2html5_prog, so the former can be removed.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> docs/meson
On Tue, Apr 29, 2025 at 12:14:05 +0100, Daniel P. Berrangé via Devel wrote:
> From: Daniel P. Berrangé
>
> Change the source to assume use of 'ifconfig' on FreeBSD builds,
> allowing virCommand to report missing commands at runtime.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> meson.build
On Tue, Apr 29, 2025 at 12:14:04 +0100, Daniel P. Berrangé via Devel wrote:
> From: Daniel P. Berrangé
>
> Change the meson rules to always enable numad if on a FreeBSD host,
> unless the meson options say not to.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> meson.build | 11 +--
On Tue, Apr 29, 2025 at 12:14:03 +0100, Daniel P. Berrangé via Devel wrote:
> From: Daniel P. Berrangé
>
> Change the meson rules to always enable numad if on a Linux host, unless
> the meson options say not to.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> meson.build| 10 +++---
>
On Tue, Apr 29, 2025 at 12:36:40 +0100, Daniel P. Berrangé wrote:
> On Tue, Apr 15, 2025 at 04:13:08AM -0400, Narayana Murty N wrote:
> > Add POWER11 as a supported cpu model for ppc64.
> >
> > Signed-off-by: Narayana Murty N
> > ---
> > src/cpu_map/index.xml | 1 +
> > src/
On Tue, Apr 15, 2025 at 04:13:09AM -0400, Narayana Murty N wrote:
> QEMU has historically used uppercase CPU model names like "POWER8",
> "POWER9", etc. However, starting with commit c5354f54aa60 ("ppc: make
> cpu_model translation to type consistent"), QEMU began using lowercase
> CPU model names
On Tue, Apr 15, 2025 at 04:13:08AM -0400, Narayana Murty N wrote:
> Add POWER11 as a supported cpu model for ppc64.
>
> Signed-off-by: Narayana Murty N
> ---
> src/cpu_map/index.xml | 1 +
> src/cpu_map/meson.build| 1 +
> src/cpu_map/ppc64_POWER11.xml
On Tue, Apr 29, 2025 at 12:14:02 +0100, Daniel P. Berrangé via Devel wrote:
> From: Daniel P. Berrangé
>
> This is redundant since the tests will strip any path component from the
> binary name before comparison.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> tests/storagepoolxml2argvtest.c | 1
On Tue, Apr 29, 2025 at 12:14:01 +0100, Daniel P. Berrangé via Devel wrote:
> From: Daniel P. Berrangé
>
> This was always undesirable but now causes problems on Fedora 42
> where at build time we detect a /sbin path but at runtime this
> will only exist on upgraded machines, not fresh installs.
On Tue, Apr 15, 2025 at 04:13:09 -0400, Narayana Murty N wrote:
> QEMU has historically used uppercase CPU model names like "POWER8",
> "POWER9", etc. However, starting with commit c5354f54aa60 ("ppc: make
> cpu_model translation to type consistent"), QEMU began using lowercase
> CPU model names (e
On Tue, Apr 15, 2025 at 04:13:08 -0400, Narayana Murty N wrote:
> Add POWER11 as a supported cpu model for ppc64.
uppercase
>
> Signed-off-by: Narayana Murty N
> ---
> src/cpu_map/index.xml | 1 +
> src/cpu_map/meson.build| 1 +
> src/cpu_map/ppc64_POWE
On Tue, Apr 15, 2025 at 04:13:06 -0400, Narayana Murty N wrote:
> The commit 140ff3c5141 ("tests: qemuhotplugtest: Fix arch-specific
> parts of 'ppc64' test XMLs") fixated on the POWER9 in results xml which
> actually would be the host-cpu at the moment on the source tree. With updates
> to higher
On Tue, Apr 15, 2025 at 04:13:07 -0400, Narayana Murty N wrote:
> Add the qemu test capabilities xml and reply files for
> QEMU v10.0.0-rc2 on ppc64. A QEMU v10.0.0-rc2 was used for generating
> this data.The tests with the 'latest' suffix, which expect
> the latest available CPU version from the c
From: Daniel P. Berrangé
Allow virCommand to find them in $PATH, which will always include 'sbin'
since the openvz driver only operates in system mode.
Signed-off-by: Daniel P. Berrangé
---
src/openvz/openvz_conf.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/o
From: Daniel P. Berrangé
Allow virCommand to find it in $PATH
Signed-off-by: Daniel P. Berrangé
---
src/util/virpolkit.c | 8 +---
src/util/virpolkit.h | 2 --
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/util/virpolkit.c b/src/util/virpolkit.c
index 0a637db9ba..81fa5
From: Daniel P. Berrangé
Change the mesonm rules to always enable the LVM driver if on a
Linux host, unless the meson options say not to.
The virCommand APIs will return suitable runtime errors if the
tools are not installed.
Signed-off-by: Daniel P. Berrangé
---
meson.build
From: Daniel P. Berrangé
Allow virCommand to find 'tc' in $PATH. This command is only used
when running privileged in which case both 'bin' and 'sbin' dirs will
be in $PATH, so virFindFileInPath will do the right thing to find it.
Signed-off-by: Daniel P. Berrangé
---
meson.build
From: Daniel P. Berrangé
There is no reference to AUGPARSE, BLACK, FLAKE8, PDWTAGS or PYTEST conf
variables anywhere, only the ${name}_prog meson variables are used.
Signed-off-by: Daniel P. Berrangé
---
meson.build | 1 -
1 file changed, 1 deletion(-)
diff --git a/meson.build b/meson.build
i
From: Daniel P. Berrangé
Allow virCommand to find 'ovs-vsctl' in $PATH. This command is only used
when running privileged in which case both 'bin' and 'sbin' dirs will
be in $PATH, so virFindFileInPath will do the right thing to find it.
Signed-off-by: Daniel P. Berrangé
---
meson.build
From: Daniel P. Berrangé
Allow virCommand to find 'modprobe' & 'rmmod' in $PATH. These commands
are only used when running privileged in which case both 'bin' and
'sbin' dirs will be in $PATH, so virFindFileInPath will do the right
thing to find them.
Signed-off-by: Daniel P. Berrangé
---
meso
From: Daniel P. Berrangé
Allow virCommand to find 'mm-ctl' in $PATH. This command is only used
when running privileged in which case both 'bin' and 'sbin' dirs will
be in $PATH, so virFindFileInPath will do the right thing to find it.
Signed-off-by: Daniel P. Berrangé
---
meson.build
From: Daniel P. Berrangé
Allow virCommand to find 'mdevctl' in $PATH. This command is only used
when running privileged in which case both 'bin' and 'sbin' dirs will
be in $PATH, so virFindFileInPath will do the right thing to find it.
Signed-off-by: Daniel P. Berrangé
---
src/node_device/node
From: Daniel P. Berrangé
There are no references to an "IP" conf variable nor a meson
'ip_prog' variable so the check serves no purpose.
Signed-off-by: Daniel P. Berrangé
---
meson.build| 1 -
src/util/virnetdevip.c | 6 +++---
2 files changed, 3 insertions(+), 4 deletions(-)
diff
From: Daniel P. Berrangé
Allow virCommand to find 'dmidecode' in $PATH. This command is only
usable when running privileged since it relies on reading from a
privileged kernel file. Thus we can assume both 'bin' and 'sbin' dirs
will be in $PATH and virFindFileInPath will do the right thing to
fin
From: Daniel P. Berrangé
Allow virCommand to find 'dmidecode' in $PATH. This command is only
usable when running privileged since it relies on reading from a
privileged kernel file. Thus we can assume both 'bin' and 'sbin' dirs
will be in $PATH and virFindFileInPath will do the right thing to
fin
From: Daniel P. Berrangé
There is no reference to PERL, PYTHON3, XMLLINT or XSLTPROC conf
variables anywhere, only the ${name}_prog meson variables are
used.
Signed-off-by: Daniel P. Berrangé
---
meson.build | 1 -
1 file changed, 1 deletion(-)
diff --git a/meson.build b/meson.build
index ea3
From: Daniel P. Berrangé
Currently $(PERL) is expanding to nothing, but the spacing-check.pl test
luckily still works via the shebang.
Signed-off-by: Daniel P. Berrangé
---
build-aux/Makefile.in | 1 +
build-aux/meson.build | 1 +
2 files changed, 2 insertions(+)
diff --git a/build-aux/Makefi
From: Daniel P. Berrangé
Nothing in the tree references RST2MAN or RST2HTML5 variables, only
rst2man_prog & rst2html5_prog, so the former can be removed.
Signed-off-by: Daniel P. Berrangé
---
docs/meson.build | 1 -
1 file changed, 1 deletion(-)
diff --git a/docs/meson.build b/docs/meson.buil
From: Daniel P. Berrangé
Change the source to assume use of 'ifconfig' on FreeBSD builds,
allowing virCommand to report missing commands at runtime.
Signed-off-by: Daniel P. Berrangé
---
meson.build| 4
src/util/virnetdevip.c | 8
2 files changed, 4 insertions(+), 8 d
From: Daniel P. Berrangé
Change the meson rules to always enable numad if on a FreeBSD host,
unless the meson options say not to.
Signed-off-by: Daniel P. Berrangé
---
meson.build | 11 +--
src/bhyve/bhyve_command.c | 6 +++---
2 files changed, 4 insertions(+), 13 deleti
From: Daniel P. Berrangé
Change the meson rules to always enable numad if on a Linux host, unless
the meson options say not to.
Signed-off-by: Daniel P. Berrangé
---
meson.build| 10 +++---
src/util/virnuma.c | 2 +-
2 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/m
From: Daniel P. Berrangé
This is redundant since the tests will strip any path component from the
binary name before comparison.
Signed-off-by: Daniel P. Berrangé
---
tests/storagepoolxml2argvtest.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/tests/storage
From: Daniel P. Berrangé
This was always undesirable but now causes problems on Fedora 42
where at build time we detect a /sbin path but at runtime this
will only exist on upgraded machines, not fresh installs.
Signed-off-by: Daniel P. Berrangé
---
meson.build | 13 ---
Over the years we've made various changes to stop hardcoding paths at
build time, but the work is incomplete.
This bit us significantly in Fedora 42 where they have merged the 'sbin'
and 'bin' dirs together. In the build environment we have a clean
install where '/sbin' and '/usr/sbin' are simply
On Tue, Apr 15, 2025 at 04:13:05 -0400, Narayana Murty N wrote:
> Support for the pseries-2.7 machine type in QEMU was officially removed in
> version 9.2 with qemu commit 445d3facffe8 ("ppc/spapr: remove deprecated
> machine pseries-2.7"). Instead of removing related tests, they are now pinned
> t
From: Jiri Denemark
This patch is effectively a NOP, but it fixes a logic bug and makes the
heuristics more visible and easier to change should there be a need to
do so in the future.
We decide which CPU model is the best match for given CPU data by
comparing lists of features that need to be en
From: Jiri Denemark
Signed-off-by: Jiri Denemark
---
tests/cputest.c |1 +
.../x86_64-cpuid-Atom-P5362-2-disabled.xml|9 +
.../x86_64-cpuid-Atom-P5362-2-enabled.xml | 19 +
.../x86_64-cpuid-Atom-P5362-2-guest.xml | 43 +
.../x86_64-cpuid-A
From: Jiri Denemark
Refactor weight calculation to a separate virCPUx86WeightFeatures
function to avoid code duplication.
Signed-off-by: Jiri Denemark
---
src/cpu/cpu_x86.c | 83 ++-
1 file changed, 46 insertions(+), 37 deletions(-)
diff --git a/src
From: Jiri Denemark
Signed-off-by: Jiri Denemark
---
tests/cputest.c |1 +
.../x86_64-cpuid-Xeon-w7-3465X-disabled.xml | 10 +
.../x86_64-cpuid-Xeon-w7-3465X-enabled.xml| 20 +
.../x86_64-cpuid-Xeon-w7-3465X-guest.xml | 55 +
.../x86_64-cpuid-X
From: Jiri Denemark
Signed-off-by: Jiri Denemark
---
tests/cputest.c |1 +
.../x86_64-cpuid-Xeon-Gold-6530-disabled.xml | 10 +
.../x86_64-cpuid-Xeon-Gold-6530-enabled.xml | 20 +
.../x86_64-cpuid-Xeon-Gold-6530-guest.xml | 58 +
.../x86_64-cpuid-X
From: Jiri Denemark
Signed-off-by: Jiri Denemark
---
tests/cputest.c |1 +
...86_64-cpuid-Xeon-Bronze-3408U-disabled.xml |9 +
...x86_64-cpuid-Xeon-Bronze-3408U-enabled.xml | 21 +
.../x86_64-cpuid-Xeon-Bronze-3408U-guest.xml | 59 +
.../x86_64-cpuid-X
From: Jiri Denemark
Signed-off-by: Jiri Denemark
---
tests/cputest.c |1 +
...86_64-cpuid-EPYC-9334-32-Core-disabled.xml |9 +
...x86_64-cpuid-EPYC-9334-32-Core-enabled.xml | 15 +
.../x86_64-cpuid-EPYC-9334-32-Core-guest.xml | 42 +
.../x86_64-cpuid-E
From: Jiri Denemark
Signed-off-by: Jiri Denemark
---
tests/cputest.c |1 +
.../x86_64-cpuid-Xeon-6731E-disabled.xml | 11 +
.../x86_64-cpuid-Xeon-6731E-enabled.xml | 21 +
.../x86_64-cpuid-Xeon-6731E-guest.xml | 128 +
.../x86_64-cpuid-X
From: Jiri Denemark
Signed-off-by: Jiri Denemark
---
tests/cputest.c |1 +
.../x86_64-cpuid-Xeon-Gold-6152-disabled.xml |7 +
.../x86_64-cpuid-Xeon-Gold-6152-enabled.xml | 19 +
.../x86_64-cpuid-Xeon-Gold-6152-guest.xml | 40 +
.../x86_64-cpuid-X
From: Jiri Denemark
Signed-off-by: Jiri Denemark
---
tests/cputest.c |1 +
...-5-5500U-with-Radeon-Graphics-disabled.xml |9 +
...n-5-5500U-with-Radeon-Graphics-enabled.xml | 11 +
...zen-5-5500U-with-Radeon-Graphics-guest.xml | 39 +
...yzen-5-5500U-wi
From: Jiri Denemark
Signed-off-by: Jiri Denemark
---
tests/cputest.c |1 +
...86_64-cpuid-EPYC-7713-64-Core-disabled.xml | 11 +
...x86_64-cpuid-EPYC-7713-64-Core-enabled.xml | 11 +
.../x86_64-cpuid-EPYC-7713-64-Core-guest.xml | 44 +
.../x86_64-cpuid-E
From: Jiri Denemark
Signed-off-by: Jiri Denemark
---
tests/cputest.c |1 +
...86_64-cpuid-Xeon-Silver-4214R-disabled.xml |7 +
...x86_64-cpuid-Xeon-Silver-4214R-enabled.xml | 19 +
.../x86_64-cpuid-Xeon-Silver-4214R-guest.xml | 46 +
.../x86_64-cpuid-X
From: Jiri Denemark
Signed-off-by: Jiri Denemark
---
tests/cputest.c |1 +
.../x86_64-cpuid-Xeon-E3-1270-v5-disabled.xml |6 +
.../x86_64-cpuid-Xeon-E3-1270-v5-enabled.xml | 18 +
.../x86_64-cpuid-Xeon-E3-1270-v5-guest.xml| 32 +
.../x86_64-cpuid-X
From: Jiri Denemark
Signed-off-by: Jiri Denemark
---
tests/cputest.c |1 +
.../x86_64-cpuid-Core-i7-1365U-disabled.xml |6 +
.../x86_64-cpuid-Core-i7-1365U-enabled.xml| 21 +
.../x86_64-cpuid-Core-i7-1365U-guest.xml | 71 +
.../x86_64-cpuid-C
From: Jiri Denemark
Signed-off-by: Jiri Denemark
---
tests/cputest.c |1 +
.../x86_64-cpuid-Core-i7-1270P-disabled.xml |8 +
.../x86_64-cpuid-Core-i7-1270P-enabled.xml| 21 +
.../x86_64-cpuid-Core-i7-1270P-guest.xml | 71 +
.../x86_64-cpuid-C
Several CPU tests covering recent-ish CPUs are added to cputest to make
sure the fix doesn't break anything.
Jiri Denemark (15):
cputest: Add data for Intel(R) Core(TM) i7-1270P CPU
cputest: Add data for Intel(R) Core(TM) i7-1365U CPU
cputest: Add data for Intel(R) Xeon(R) CPU E3-1270 v5 CPU
On Tue, Apr 29, 2025 at 11:35:52AM +0200, Philippe Mathieu-Daudé wrote:
> On 29/4/25 10:23, Markus Armbruster wrote:
> > Pierrick Bouvier writes:
> >
> > > On 4/28/25 4:07 AM, Markus Armbruster wrote:
> > > > Peter Krempa writes:
> > > >
> > > > > So what should libvirt do once multiple targets
On 29/4/25 11:32, Daniel P. Berrangé wrote:
On Tue, Apr 29, 2025 at 11:20:59AM +0200, Thomas Huth via Devel wrote:
On 29/04/2025 10.23, Markus Armbruster wrote:
...
I don't wish to derail this thread, but we've been dancing around the
question of how to best fix the target for some time. I thi
On 29/4/25 10:23, Markus Armbruster wrote:
Pierrick Bouvier writes:
On 4/28/25 4:07 AM, Markus Armbruster wrote:
Peter Krempa writes:
So what should libvirt do once multiple targets are supported?
How do we query CPUs for each of the supported targets?
It's kind of a similar question w
On Tue, Apr 29, 2025 at 11:20:59AM +0200, Thomas Huth via Devel wrote:
> On 29/04/2025 10.23, Markus Armbruster wrote:
> ...
> > I don't wish to derail this thread, but we've been dancing around the
> > question of how to best fix the target for some time. I think we should
> > talk about it for r
On 29/04/2025 10.23, Markus Armbruster wrote:
...
I don't wish to derail this thread, but we've been dancing around the
question of how to best fix the target for some time. I think we should
talk about it for real.
Mind, this is not an objection to your larger "single binary" idea. It
could b
On Tue, Apr 29, 2025 at 10:31:43AM +0200, Michal Privoznik via Devel wrote:
> From: Michal Privoznik
>
> The script is renamed to mockable-attribute.py and adjusted to
> check for the new attribute.
>
> Signed-off-by: Michal Privoznik
> ---
> build-aux/syntax-check.mk
On Tue, Apr 29, 2025 at 10:31:42AM +0200, Michal Privoznik via Devel wrote:
> From: Michal Privoznik
>
> Per change in coding style done in previous commit,
> ATTRIBUTE_MOCKABLE should be used instead of G_NO_INLINE for
> functions that are mocked in our test suite. Do the change.
>
> Signed-off
On Tue, Apr 29, 2025 at 10:31:41AM +0200, Michal Privoznik via Devel wrote:
> From: Michal Privoznik
>
> Currently, if we want to mock a function the noinline attribute
> is appended after the function (via G_NO_INLINE macro). This used
> to work for non pure functions. But there are some trivial
On Tue, Apr 29, 2025 at 09:43:24AM +0200, Markus Armbruster wrote:
> Pierrick Bouvier writes:
>
> > After looking at the introspection code, I don't see any major blocker.
> > We need to keep some of existing "if", as they are based on config-host,
> > and should apply.
> > We can introduce a ne
From: Michal Privoznik
The script is renamed to mockable-attribute.py and adjusted to
check for the new attribute.
Signed-off-by: Michal Privoznik
---
build-aux/syntax-check.mk | 4 ++--
scripts/meson.build | 2 +-
scripts/{mock-noinlin
From: Michal Privoznik
Per change in coding style done in previous commit,
ATTRIBUTE_MOCKABLE should be used instead of G_NO_INLINE for
functions that are mocked in our test suite. Do the change.
Signed-off-by: Michal Privoznik
---
src/cpu/cpu.h | 2 +-
src/hypervisor/doma
From: Michal Privoznik
Currently, if we want to mock a function the noinline attribute
is appended after the function (via G_NO_INLINE macro). This used
to work for non pure functions. But there are some trivial
functions (for instance virQEMUCapsProbeHVF()) that are pure,
i.e. have no side effec
1 - 100 of 105 matches
Mail list logo
