That looks great. Thanks!
On Wed, Mar 5, 2014 at 12:24 PM, Ralph Castain wrote:
> Nicely done - thanks!
>
>
>
> On Wed, Mar 5, 2014 at 10:14 AM, Adrian Reber wrote:
>
>> Josh, please have a look at:
>>
>>
>> https://lisas.de/git/?p=open-mpi.git;a=commitdiff;h=5d5edafa36605ca7650eafa7f99fa19856
Nicely done - thanks!
On Wed, Mar 5, 2014 at 10:14 AM, Adrian Reber wrote:
> Josh, please have a look at:
>
>
> https://lisas.de/git/?p=open-mpi.git;a=commitdiff;h=5d5edafa36605ca7650eafa7f99fa1985641e488
>
> I moved the parameter initialization to sstore_stage_register() and can
> now see tha
Josh, please have a look at:
https://lisas.de/git/?p=open-mpi.git;a=commitdiff;h=5d5edafa36605ca7650eafa7f99fa1985641e488
I moved the parameter initialization to sstore_stage_register() and can
now see that the variables are correctly used:
$ orterun --mca sstore_stage_verbose 30
[...]
[dcbz:028
Yea. Those look fine. Thanks!
On Mon, Mar 3, 2014 at 10:42 AM, Adrian Reber wrote:
> I will prepare a patch that moves the parameter initialization somewhere
> else
> and will not remove it. Do you think the other parts of the patch can be
> applied (without sstore_stage_select() removal)?
>
>
I will prepare a patch that moves the parameter initialization somewhere else
and will not remove it. Do you think the other parts of the patch can be
applied (without sstore_stage_select() removal)?
On Mon, Mar 03, 2014 at 10:07:36AM -0600, Josh Hursey wrote:
> It should probably be moved to the
It should probably be moved to the component initialization of the sstore
stage component since those parameters are how the user controls where to
store those files. I think there is an MCA registration function that is
called after component initialization - that would be the best spot, but I
do
I removed a complete function because it was not used:
../../../../../orte/mca/sstore/stage/sstore_stage_component.c: At top level:
../../../../../orte/mca/sstore/stage/sstore_stage_component.c:77:12: warning:
'sstore_stage_select' defined but not used [-Wunused-function]
static int sstore_stage
It looks like you removed a number of sstore stage MCA parameters. Did they
move somewhere else? or do you have a different way to set those parameters?
Other than that it looks good to me.
On Mon, Mar 3, 2014 at 5:29 AM, Adrian Reber wrote:
> I have a simple patch which fixes the remaining co
I have a simple patch which fixes the remaining compiler warnings when
running with '--with-ft':
https://lisas.de/git/?p=open-mpi.git;a=commitdiff;h=4dee703a0a2e64972b0c35b7693c11a09f1fbe5f
Does anybody see any problems with this patch?
Adrian
