Re: [OMPI devel] RFC: hide btl segment keys within btl

2012-06-18 Thread Nathan Hjelm
think it is good. > > Rolf > > >-Original Message- > >From: devel-boun...@open-mpi.org [mailto:devel-boun...@open-mpi.org] > >On Behalf Of George Bosilca > >Sent: Saturday, June 16, 2012 12:49 PM > >To: Open MPI Developers > >Subject: Re: [OMPI devel] RF

Re: [OMPI devel] RFC: hide btl segment keys within btl

2012-06-18 Thread Rolf vandeVaart
Subject: Re: [OMPI devel] RFC: hide btl segment keys within btl > >Looks good to me. I would add some checks regarding the number and size of >the segments and the allocated space (MCA_BTL_SEG_MAX_SIZE) to make >sure we never hit the corner case where there are too many segments >

Re: [OMPI devel] RFC: hide btl segment keys within btl

2012-06-16 Thread George Bosilca
Looks good to me. I would add some checks regarding the number and size of the segments and the allocated space (MCA_BTL_SEG_MAX_SIZE) to make sure we never hit the corner case where there are too many segments compared with the available space. And add a huge comment in the btl.h about the

Re: [OMPI devel] RFC: hide btl segment keys within btl

2012-06-14 Thread Jeff Squyres
This sounds like a good thing to me. +1 On Jun 13, 2012, at 12:58 PM, Nathan Hjelm wrote: > What: hide btl segment keys from PML/OSC code. > > Why: As it stands new BTLs with larger segment keys (smcuda for example) > require changes in both OSC/rdma as well as the PMLs. This RFC makes will

[OMPI devel] RFC: hide btl segment keys within btl

2012-06-13 Thread Nathan Hjelm
What: hide btl segment keys from PML/OSC code. Why: As it stands new BTLs with larger segment keys (smcuda for example) require changes in both OSC/rdma as well as the PMLs. This RFC makes will make changes in segment keys transparent to all btl users. When: The changes are very