Re: [OMPI devel] [OMPI svn-full] svn:open-mpi r20568

2009-02-17 Thread Ralf Wildenhues
Hello, * Jeff Squyres wrote on Tue, Feb 17, 2009 at 07:01:01PM CET: > On Feb 17, 2009, at 11:18 AM, George Bosilca wrote: > >> I guess that if the free function supports the NULL pointer we should >> do the same... > > I'll agree with that if we know for sure that free(NULL) is universally > sup

Re: [OMPI devel] [OMPI svn-full] svn:open-mpi r20568

2009-02-17 Thread Jeff Squyres
On Feb 17, 2009, at 2:05 PM, George Bosilca wrote: I can confirm it at least on MAC OS X and Linux. Based on IEEE Std 1003.1-2008, if the argument of the free function is null, no action should occur. So I guess most POSIX compliant environments support the NULL argument. Sounds good. Te

Re: [OMPI devel] [OMPI svn-full] svn:open-mpi r20568

2009-02-17 Thread George Bosilca
I can confirm it at least on MAC OS X and Linux. Based on IEEE Std 1003.1-2008, if the argument of the free function is null, no action should occur. So I guess most POSIX compliant environments support the NULL argument. george. On Feb 17, 2009, at 13:01 , Jeff Squyres wrote: On Feb 1

Re: [OMPI devel] [OMPI svn-full] svn:open-mpi r20568

2009-02-17 Thread Jeff Squyres
On Feb 17, 2009, at 11:18 AM, George Bosilca wrote: I guess that if the free function supports the NULL pointer we should do the same... I'll agree with that if we know for sure that free(NULL) is universally supported. You mentioned "a few man pages" -- how universal is this support?

Re: [OMPI devel] [OMPI svn-full] svn:open-mpi r20568

2009-02-17 Thread George Bosilca
I guess that if the free function supports the NULL pointer we should do the same... george. On Feb 17, 2009, at 07:35 , Jeff Squyres wrote: On Feb 16, 2009, at 9:16 PM, George Bosilca wrote: Based on several man pages, free is capable of handling a NULL argument. What is really puzzlin

Re: [OMPI devel] [OMPI svn-full] svn:open-mpi r20568

2009-02-17 Thread Jeff Squyres
On Feb 16, 2009, at 9:16 PM, George Bosilca wrote: Based on several man pages, free is capable of handling a NULL argument. What is really puzzling is that on your system it doesn't ... I tried on two system a 64 bits Debian and on my MAC OS X with all memory allocator options on, and I'm

Re: [OMPI devel] [OMPI svn-full] svn:open-mpi r20568

2009-02-16 Thread George Bosilca
Based on several man pages, free is capable of handling a NULL argument. What is really puzzling is that on your system it doesn't ... I tried on two system a 64 bits Debian and on my MAC OS X with all memory allocator options on, and I'm unable to get such a warning :( george. On Feb 16

Re: [OMPI devel] [OMPI svn-full] svn:open-mpi r20568

2009-02-16 Thread Jeff Squyres
r20569 fixes the problem, but I'm not 100% sure it's the Right Way. Short version: now that we're guaranteeing to free the event base, we're exercising a code path that was never used before. Apparently the orted initializes the ev->timebase min_heap_t structure, but then never uses it. S

Re: [OMPI devel] [OMPI svn-full] svn:open-mpi r20568

2009-02-16 Thread Jeff Squyres
Unfortunately, this doesn't fully fix the problem -- I'm still getting bad frees: [16:47] svbu-mpi:~/mpi % ./hello stdout: Hello, world! I am 0 of 1 (svbu-mpi.cisco.com) stderr: Hello, world! I am 0 of 1 (svbu-mpi.cisco.com) malloc debug: Invalid free (min_heap.h, 58) [16:48] svbu-mpi:~/mpi