Re: [PATCH 2/5] bsps/imxrt: Reduce devicetree size

is it already clear in the related doco that overlays and adding stuff during run-time are not supported? On Wed, May 12, 2021 at 3:49 AM Christian Mauderer wrote: > > Remove symbols that would be necessary for overlays and decrease padding > that would be necessary for adding stuff during run-ti

Re: [PATCH 1/5] bsps/imxrt: Fix documentation error

On Wed, May 12, 2021 at 3:49 AM Christian Mauderer wrote: > > Update #4180 > --- > bsps/arm/imxrt/include/fsl_qtmr.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/bsps/arm/imxrt/include/fsl_qtmr.h > b/bsps/arm/imxrt/include/fsl_qtmr.h > index a675413f8d..eb1d612ac3 100

Re: [PATCH 1/3] _TOD_Validate(): Fix incorrect return code

> > These three files in bsps/ should not be calling score functions > > directly, unless they implement part of the score CPU port. These > > don't seem to be doing that. This issue exists before this patch, but > > a ticket should be opened to fix this. A new API should be added for > > applicati

Re: [PATCH v2] rtems: Constify rtems_task_wake_when()

I understand the efficiency, but the interface is awkward. At least maybe put UINT32_MAX behind a macro to make the intent more clear #define RTEMS_TICKS_MASK 0xU or UINT32_MAX is fine there too, equivalent. Otherwise, go ahead. On Tue, May 11, 2021 at 10:46 PM Sebastian Huber wrote: > >

Re: [PATCH 3/3] rtems: Constify rtems_task_wake_when()

I'm not a big fan of the way this has been implemented. It exposes an internal implementation detail (how you mask the ticks). I don't quite see why it is being done. On Tue, May 11, 2021 at 9:38 AM Sebastian Huber wrote: > > Add a parameter to _TOD_Validate() to disable the validation of the > t

Re: [PATCH 1/3] _TOD_Validate(): Fix incorrect return code

On Tue, May 11, 2021 at 9:38 AM Sebastian Huber wrote: > > From: Frank Kühndel > > This patch fixes bug #4403. Directives > > * rtems_timer_fire_when() > * rtems_timer_server_fire_when() > * rtems_task_wake_when() > > are documented to return RTEMS_INVALID_ADDRESS when their time-of-day > argumen

Re: [PATCH] user/bld/index.rst: removed references to legacy network config options

ignore this patch, I spoke with Harrison on Discord and he will send another in the next few days On Sat, May 8, 2021 at 8:13 PM Harrison Edward Gerber wrote: > > From: Harrison > > --- > user/bld/index.rst | 7 --- > 1 file changed, 7 deletions(-) > > diff --git a/user/bld/index.rst b/user

Re: code review: help implementing clock_montonic

On Fri, May 7, 2021 at 12:53 PM zack_on_the_speed_chanel wrote: > > hello, > > Currenttly i'm trying to implement the clock_monotonic which was part of > ticket #3889. So far these are the changes are as follows > This ticket mostly references the need for a test. Have you tried to write a test

Re: Error when using RTEMS_MICROSECONDS_TO_TICKS

On Sun, May 9, 2021 at 9:33 AM Richi Dubey wrote: > > Hi, > > I am using the line: > rtems_task_wake_after(RTEMS_MICROSECONDS_TO_TICKS(6000)); in my test program > to emulate a 6 seconds sleep. But when I deubg the program using qemu, I do > not see it waiting for 6 seconds; on debugging, there

Re: timing on qemu

On Sat, May 8, 2021 at 12:09 PM Richi Dubey wrote: > > Hi, > > When I use benchmark_timer_initialize() and later read the value with > benchmark_timer_read(), it always shows 0 for me in qemu. Is this expected? > > I am using the arm/realview_pbx_a9_qemu bsp, qemu 4.1.0, and I built the > testsu

Re: [PATCH v2 1/5] libcsupport: Added futimens() and utimensat()

On Mon, May 10, 2021 at 3:16 PM Ryan Long wrote: > > Reply is below. > > -Original Message----- > From: Gedare Bloom > Sent: Monday, May 10, 2021 12:36 PM > To: Ryan Long > Cc: devel@rtems.org > Subject: Re: [PATCH v2 1/5] libcsupport: Added futimens() and ut

Re: [PATCH v1 0/2] [libbsd] Install correct machine include headers

I can't review these currently, just want to put a note out there. Hopefully someone else gets to it. Otherwise ping it in a week or two and I might have more time to look myself.. On Mon, May 10, 2021 at 11:26 AM Jan Sommer wrote: > > Hello, > > This is a follow-up on this discussion regarding t

Re: [PATCH 2/2] Fix the bibtex extension configure test

ok to both of these. To honor Joel, I'll suggest you should include in the commit msg a more descriptive notion of what you fixed (i.e., "fixed OS neutrality") ;) On Mon, May 10, 2021 at 11:26 AM wrote: > > From: Chris Johns > > --- > common/waf.py | 6 -- > 1 file changed, 4 insertions(+),

Re: [PATCH rtems-libbsd v2] ipsec-tools/pfkey: Fix socket leak

looks good, thanks. for the backport please open a separate ticket to 5. On Mon, May 10, 2021 at 11:26 AM Christian MAUDERER wrote: > > Only change is a better description. > > Am 10.05.21 um 08:50 schrieb Christian Mauderer: > > setkey uses pfkey_open to open a socket. But setkey doesn't close t

Re: [PATCH 2/2] rtems: Use _Objects_Free_nothing() for msg queues

ok On Mon, May 10, 2021 at 11:41 AM Sebastian Huber wrote: > > Use _Objects_Free_nothing() for rtems_message_queue_construct() to avoid > unreachable code in _CORE_message_queue_Close() in case only > user-provided message buffers are used. > > Update #4007. > --- > cpukit/rtems/src/msgqconstruc

Re: [PATCH 2/2] bsp: Use RTEMS_NOINIT for bsp_fdt_blob

ok On Mon, May 10, 2021 at 11:42 AM Sebastian Huber wrote: > > Sorry, I sent the wrong patch set. Please ignore this one. > > -- > embedded brains GmbH > Herr Sebastian HUBER > Dornierstr. 4 > 82178 Puchheim > Germany > email: sebastian.hu...@embedded-brains.de > phone: +49-89-18 94 741 - 16 > fa

Re: [PATCH v2 5/5] Change filesystem utime_h handler to utimens_h

On Thu, May 6, 2021 at 1:51 PM Ryan Long wrote: > > Also updated licenses. > > Closes #4400 > --- > bsps/arm/csb337/umon/tfsDriver.c| 2 +- > cpukit/Makefile.am | 4 +-- > cpukit/include/rtems/confdefs/libio.h | 4 +-- > cpukit/include/rtems/imfs.h

Re: [PATCH v2 1/5] libcsupport: Added futimens() and utimensat()

On Thu, May 6, 2021 at 1:51 PM Ryan Long wrote: > > Created futimens.c and utimensat.c to add support for the POSIX > methods futimens() and utimensat(). > > utime() and utimes() are considered obsolote by POSIX, but RTEMS > will continue to support them. > > Closes #4396 > --- > cpukit/Makefile.

Re: [PATCH] bsps/raspberrypi/console: Fix default console device

On Thu, May 6, 2021 at 8:49 AM Niteesh G. S. wrote: > > Hi Alan, > > On Thu, May 6, 2021 at 6:12 PM Alan Cudmore wrote: >> >> Hi Niteesh, >> >> I was hoping to try this out as soon as I get some time. No later than >> weekend. So if nobody else is able to check it out, I will be able to >> prov

Re: [PATCH v4] rtems-debugger: Fixed 32bit pointers

On Thu, May 6, 2021 at 10:13 AM Joel Sherrill wrote: > > > > On Wed, May 5, 2021 at 12:35 AM Gedare Bloom wrote: >> >> On Tue, May 4, 2021 at 1:34 PM Stephen Clark >> wrote: >> > >> > Using 32bit types like uint32_t for pointers creates

Re: [PATCH v3] bsps/shared/ofw: Fix coverity defects

ok, Vijay please push On Thu, May 6, 2021 at 2:06 AM G S Niteesh Babu wrote: > > This patch adds asserts to fix coverity defects > 1) CID 1474437 (Out-of-bounds access) > 2) CID 1474436 (Out-of-bounds access) > > From manual inspection, out of bounds access cannot occur due to > bounds checking b

Re: Large compressed patch: posix-compliance: Update to include POSIX 1003.1-2017 (Issue 7).

Thanks Joel. Is this patch 2/2? Go ahead. On Wed, May 5, 2021 at 3:36 PM Joel Sherrill wrote: > > Hi > > This was too large to send through uncompressed so I am attaching it. > Gedare's idea of not renaming the CSV to bump the version was good. But this > change adds a new column for POSIX 100

Re: [PATCH] Removed references to legacy network config options in user/bld/index.rst as those options are no longer valid

On Wed, May 5, 2021 at 7:12 PM Vijay Kumar Banerjee wrote: > > Hi Harrison, > > The patch looks good, just a little change is required. You'll notice > that we follow a pattern in our commit messages. First, write the name > of the file changed, then a short description of the change and then, > i

Re: GSoC - Code Formatting and Style Checking for RTEMS score

hi Ida, On Wed, May 5, 2021 at 3:21 PM Ida Delphine wrote: > > Hello everyone, > > Regarding this project (https://devel.rtems.org/ticket/3860) I went with > clang-format as we all agreed. I have tested it on some "score" files and it > made some changes which I don't think are very much in lin

Re: [PATCH v1 1/5] libcsupport: Added futimens() and utimensat()

On Wed, May 5, 2021 at 11:03 AM Ryan Long wrote: > > Reply is below. > > -Original Message----- > From: Gedare Bloom > Sent: Tuesday, May 4, 2021 11:27 AM > To: Ryan Long > Cc: Sebastian Huber ; devel@rtems.org > Subject: Re: [PATCH v1 1/5] libcsupport: Add

Re: [PATCH] rtemstoolkit/mailer.py: Fix option ordering for add_arguments

On Wed, May 5, 2021 at 9:16 AM Alex White wrote: > > On Wed, May 5, 2021 at 9:47 AM Gedare Bloom wrote: > > > > Why? > > To prevent the '--mail' and '--use-gitconfig' options from being added more > than once to the ArgumentParser in add_arguments

Re: [PATCH] rtems: rtems_scheduler_ident_by_processor_set()

ok On Wed, May 5, 2021 at 5:28 AM Sebastian Huber wrote: > > Check for a NULL processor set pointer. > --- > cpukit/rtems/src/scheduleridentbyprocessorset.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/cpukit/rtems/src/scheduleridentbyprocessorset.c > b/cpukit/rtems/src/schedule

Re: [PATCH] rtems: rtems_scheduler_get_processor_set() status

ok, this is also consistent with rtems_scheduler_ident_by_processor_set() On Wed, May 5, 2021 at 6:27 AM Sebastian Huber wrote: > > In case the processor set is not large enough to contain the processor > set owned by the scheduler return RTEMS_INVALID_SIZE instead of > RTEMS_INVALID_NUMBER. This

Re: [PATCH] Return NULL for zero size allocations

On Wed, May 5, 2021 at 1:19 AM Sebastian Huber wrote: > > On 05/05/2021 09:00, Chris Johns wrote: > > On 5/5/21 4:58 pm, Chris Johns wrote: > >> On 5/5/21 4:52 pm, Sebastian Huber wrote: > >>> In POSIX, zero size memory allocations are implementation-defined > >>> behaviour. The implementation ha

Re: [PATCH] rtemstoolkit/mailer.py: Fix option ordering for add_arguments

Why? On Wed, May 5, 2021 at 8:08 AM Alex White wrote: > > The ordering of keys cannot be guaranteed in a dictionary. This changes > the options dictionary to an OrderedDict to preserve key order. This > also fixes the iteration start point in add_arguments. > > Closes #4402 > --- > rtemstoolkit/

Re: [PATCH v2] bsps/shared/ofw: Fix coverity defects

alright looks good. Vijay or Christian please confirm and push if you're good with it too. On Wed, May 5, 2021 at 12:52 AM Niteesh G. S. wrote: > > > > On Mon, May 3, 2021 at 11:23 PM Gedare Bloom wrote: >> >> Hi Niteesh, >> >> This looks good to me.

Re: [PATCH v4] rtems-debugger: Fixed 32bit pointers

On Tue, May 4, 2021 at 1:34 PM Stephen Clark wrote: > > Using 32bit types like uint32_t for pointers creates issues on 64 bit > architectures like AArch64. Replaced occurrences of these with uintptr_t, > which will work for both 32 and 64 bit architectures. Added hex_decode_addr > function to rtem

Re: [PATCH v1 1/5] libcsupport: Added futimens() and utimensat()

On Tue, May 4, 2021 at 10:04 AM Ryan Long wrote: > > > > -Original Message- > From: Sebastian Huber > Sent: Tuesday, May 4, 2021 12:04 AM > To: Ryan Long ; devel@rtems.org > Subject: Re: [PATCH v1 1/5] libcsupport: Added futimens() and utimensat() > > On 03/05/2021 15:40, Ryan Long wrote:

Re: [PATCH] Make zero size allocation result consistent

On Tue, May 4, 2021 at 6:55 AM Sebastian Huber wrote: > > On 04/05/2021 14:52, Joel Sherrill wrote: > > > > > > On Tue, May 4, 2021, 7:12 AM Sebastian Huber > > > > wrote: > > > > On 04/05/2021 14:07, Joel Sherrill wrote: > > > This is undefined

Re: [PATCH 2/2] covoar: Store address-to-line info outside of DWARF

On Fri, Apr 30, 2021 at 2:01 PM Alex White wrote: > > This adds the AddressToLineMapper class and supporting classes to > assume responsibility of tracking address-to-line information. > > This allows the DWARF library to properly cleanup all of its resources > and leads to significant memory savi

Re: [PATCH 1/2] covoar: Store only the file name in ExecutableInfo

On Fri, Apr 30, 2021 at 2:02 PM Alex White wrote: > > This changes the ExecutableInfo class to only store the executable > file's name rather than an entire instance of rld::files::object. This > allows the rld::files::object to be cleaned up in the ExecutableInfo > constructor. > > Updates #4383

Re: [PATCH rtems-net-legacy] Re-license copyright texts

ok On Mon, May 3, 2021 at 4:37 PM Vijay Kumar Banerjee wrote: > > --- > bsp_drivers.py | 3 ++- > netlegacy.py| 3 ++- > testsuites/ftp01/wscript| 3 ++- > testsuites/loopback/wscript | 3 ++- > testsuites/networking01/wscript | 3 ++- > testsuite

Re: [PATCH rtems-net-legacy v2] bsp_drivers: Use os.path for compatibility with non Unix host

looks good to me On Mon, May 3, 2021 at 4:37 PM Vijay Kumar Banerjee wrote: > > Is this Ok to push? > > On Mon, Apr 19, 2021 at 11:32 AM Vijay Kumar Banerjee wrote: > > > > On Mon, Apr 19, 2021 at 11:30 AM Vijay Kumar Banerjee > > wrote: > > > > > > --- > > > bsp_drivers.py | 22 +++--

Re: [PATCH] nfs.c: Change filesystem utime_h handler to utimens_h

On Mon, May 3, 2021 at 12:34 PM Joel Sherrill wrote: > > Ryan.. these have the same subject/short message and are threading together > as the same patch. > > Resubmit both as v2 with libbsd and net-legacy added to the commit message. > Something like: > > legacy nfs.c: Change filesystem utime_h

Re: [PATCH] Make zero size allocation result consistent

ok. This could break applications in strange ways if they depended on the old behavior. A clear note will be needed in release. On Mon, May 3, 2021 at 1:21 AM Sebastian Huber wrote: > > The zero size allocations had no consistent behaviour in RTEMS. For > example, malloc( 0 ) returned NULL and p

Re: [PATCH] rtems: Use allocator mutex for timer server

ok. It seems like it was a bit of a misuse of the _Once interface to directly access its lock mechanism. Does this now make the only use of _Once_Lock inside of _Once? Maybe, _Once_Lock/Unlock should not be exposed (change to static in once.c)? On Sun, May 2, 2021 at 11:00 PM Sebastian Huber wrot

Re: [PATCH v2] bsps/shared/ofw: Fix coverity defects

Hi Niteesh, This looks good to me. What/how did you test it? Gedare On Sat, May 1, 2021 at 6:31 AM G S Niteesh Babu wrote: > > This patch adds asserts to fix coverity defects > 1) CID 1474437 (Out-of-bounds access) > 2) CID 1474436 (Out-of-bounds access) > > From manual inspection, out of bound

Re: [PATCH] score: Add _Thread_Dispatch_direct_no_return()

ok, that's annoying. On Fri, Apr 30, 2021 at 9:02 AM Sebastian Huber wrote: > > The __builtin_unreachable() cannot be used with current GCC versions to > tell the compiler that a function does not return to the caller, see: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99151 > > Add a no retur

Re: [PATCH] spmisc01: Test RTEMS_NOINIT

ok On Fri, Apr 30, 2021 at 9:04 AM Sebastian Huber wrote: > > Close #3866. > --- > testsuites/sptests/spmisc01/init.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/testsuites/sptests/spmisc01/init.c > b/testsuites/sptests/spmisc01/init.c > index e64fa4e480..6fbc0eeff8 100644 > -

Re: [PATCH 2/2] bsps: Support RTEMS_NOINIT in linkcmds

these 2 look good On Fri, Apr 30, 2021 at 7:55 AM Sebastian Huber wrote: > > Close #3866. > --- > bsps/arm/include/bsp/arm-cp15-start.h| 6 +- > bsps/arm/include/bsp/linker-symbols.h| 4 > bsps/arm/shared/start/linkcmds.base | 7 +++ > bsps/bfin/

Re: [PATCH] riscv/start: Startup sequence update.

On Thu, Apr 29, 2021 at 11:53 AM Sebastian Huber wrote: > > > On 28/04/2021 15:55, Somesh Deshmukh wrote: > > +/* Clear .bss */ > > +LADDRa0, bsp_section_bss_begin > > +li a1, 0 > > +LADDRa2, bsp_section_bss_size > > +call memset > > + > > #ifdef BSP_START_COPY_FDT_FROM_U_BOOT

Re: [PATCH rtems] cpukit/Makefile.am: Remove remaining LIBNETWORKING files

ok On Thu, Apr 29, 2021 at 10:07 AM Vijay Kumar Banerjee wrote: > > --- > cpukit/Makefile.am | 43 --- > cpukit/configure.ac | 1 - > 2 files changed, 44 deletions(-) > > diff --git a/cpukit/Makefile.am b/cpukit/Makefile.am > index b0df610bed..44ab945778

Re: [PATCH] riscv/console: Updated the console-config.c file

Hesham, please review. I'm not certain. On Wed, Apr 28, 2021 at 7:23 AM Somesh Deshmukh wrote: > > - Parsing the sub-node should be available generic not specific to Freedom > Arty310 board. If we remove the Freedom Arty macro now, it will lose > backward compatibility.The proposed change wil

Re: [PATCH] riscv/start: Startup sequence update.

looks good. someone using riscv can build/test and push, any takers? On Wed, Apr 28, 2021 at 7:55 AM Somesh Deshmukh wrote: > > - The current startup sequence performs the call to the bsp_fdt_copy() and > then > performs memset to the BSS region. In bsp_fdt_copy(), RTEMS allocates > memory f

Re: [PATCH v2] Use alias for rtems_task_self() and pthread_self()

ok On Thu, Apr 29, 2021 at 7:18 AM Sebastian Huber wrote: > > This may reduce the code size a bit. > --- > cpukit/Makefile.am | 3 +- > cpukit/include/rtems/score/threadimpl.h | 7 > cpukit/posix/src/pthreadself.c | 32 --- > cpukit/rtems/src/task

Re: [PATCH] c-user: CONFIGURE_BSP_PREREQUISITE_DRIVERS

ok On Thu, Apr 29, 2021 at 7:02 AM Sebastian Huber wrote: > > Replace copy and paste with a provide a proper description. > --- > c-user/config/bsp-related.rst | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/c-user/config/bsp-related.rst b/c-user/config/bsp-related.r

Re: Issues with rtems_waf on Windows 10 with gccdeps module

On Thu, Apr 29, 2021 at 9:59 AM Gedare Bloom wrote: > > On Thu, Apr 29, 2021 at 3:14 AM Robin Müller > wrote: > > > > I replaced the file in rtems_waf manually but it still throws the same > > error: > > > > [1/2] Compiling build/conf_check_995d7bdd1834

Re: Issues with rtems_waf on Windows 10 with gccdeps module

On Thu, Apr 29, 2021 at 3:14 AM Robin Müller wrote: > > I replaced the file in rtems_waf manually but it still throws the same error: > > [1/2] Compiling build/conf_check_995d7bdd1834199278843e9a51c37759/test.c > > ['C:/Users/Robin/Documents/RTEMS/rtems-tools/rtems/6/bin/sparc-rtems6-gcc.exe', >

Re: [PATCH] c-user: Reformat configuration option constraints

ok On Wed, Apr 28, 2021 at 11:30 PM Sebastian Huber wrote: > > If only one constraint is present, then use a single sentence, otherwise > use a list for the constraints. Format the constraints so that the line > length limit is maintained. > --- > c-user/config/bdbuf.rst | 94 +

Re: [PATCH] bsps/shared/ofw: Fix coverity defects

On Wed, Apr 28, 2021 at 9:04 PM Niteesh G. S. wrote: > > > > On Thu, Apr 29, 2021 at 12:50 AM Gedare Bloom wrote: >> >> On Wed, Apr 28, 2021 at 11:30 AM G S Niteesh Babu >> wrote: >> > >> > This patch adds asserts to fix coverity defects >&g

Re: [PATCH] pwdgrp.c: Removed unused variable

ok On Wed, Apr 28, 2021 at 2:25 PM Ryan Long wrote: > > The 'sc' variable was originally storing the return value of mkdir(). > This was causing an issue, so it was changed to make it to where we > ignored the return value with (void). The 'sc' variable was left in > by mistake. > --- > cpukit/l

Re: [PATCH] bsps/shared/ofw: Fix coverity defects

On Wed, Apr 28, 2021 at 11:30 AM G S Niteesh Babu wrote: > > This patch adds asserts to fix coverity defects > 1) CID 1474437 (Out-of-bounds access) > 2) CID 1474436 (Out-of-bounds access) > > From manual inspection, out of bounds access cannot occur due to > bounds checking but coverity fails to

Re: [PATCH] STM32 lwIP addition

;> examples and these examples are always targeted towards a specific API. >>> I changed the version to be usable by both APIs. I now applied the >>> __rtems__ preprocessor defines where applicable and moved the preprocessor >>> defines into a separate file. >>> &g

Re: [PATCH] c-user: Generate region manager documentation

On Tue, Apr 27, 2021 at 12:03 PM Sebastian Huber wrote: > > The documentation is a consolidation of the comments in Doxygen markup > and the documentation sources in Sphinx markup. The documentation was > transfered to interface specification items. The documentation source > files were generate

Re: [PATCH v3 0/2] powerpc/shared/console: Console baud rate fixes

ok, vijay, please check the build and push if all good On Tue, Apr 27, 2021 at 11:48 AM wrote: > > From: Peter Dufault > > With these two changes the "powerpc/shared/console" code supports a > configurable baud rate. > > Peter Dufault (2): > powerpc/shared/console: Make console baud rate confi

Re: [PATCH] STM32 lwIP addition

On Tue, Apr 27, 2021 at 2:09 PM Gedare Bloom wrote: > > On Tue, Apr 27, 2021 at 11:41 AM Robin Mueller > wrote: > > I'm not sure what happened, it looks like my email client garbled the inline threaded reply. Hopefully my comments com

Re: [PATCH] STM32 lwIP addition

On Tue, Apr 27, 2021 at 11:41 AM Robin Mueller wrote: > > This patch adds the STM32H7 / NUCLEO-H743ZI lwIP port. > It also improves the architecture to make integration > of new BSPs easier. > > https://github.com/rmspacefish/rtems-stm32-lwip is a self-contained > repository to test the lwIP integ

Re: [PATCH v2] STM32 lwIP addition and CMake support

ts.rtems.org/pipermail/devel/2016-July/043530.html Gedare > Kind Regards > Robin > > On Tue, 27 Apr 2021 at 18:27, Sebastian Huber > wrote: >> >> On 27/04/2021 17:23, Gedare Bloom wrote: >> >> >> I can try to get a better license for the files taken fro

Re: [PATCH] c-user: Generate task manager documentation

your suggestions look good On Tue, Apr 27, 2021 at 11:52 AM Sebastian Huber wrote: > > Hello Gedare, > > thanks a lot for the review. > > On 27/04/2021 18:01, Gedare Bloom wrote: > > > On Tue, Apr 27, 2021 at 3:31 AM Sebastian Huber > > wrote: > >> T

Re: [PATCH v2 2/2] powerpc/shared/console: "termios" first open sets console baud to 9600

On Sat, Apr 10, 2021 at 6:41 AM wrote: > > From: Peter Dufault > > When the PowerPC shared console baud rate starts at anything other than > 9600 the termios code will set it to 9600 at the first open. > --- > bsps/powerpc/shared/console/uart.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff

Re: [PATCH] posix: Use alias for pthread_self()

PS: the git-rm is missing? On Tue, Apr 27, 2021, 10:09 AM Gedare Bloom wrote: > @Joel: you ok with this cross-link between classic and posix layers? > > On Tue, Apr 27, 2021 at 3:12 AM Sebastian Huber > wrote: > > > > This may reduce the code size a bit. > &g

Re: [PATCH] posix: Use alias for pthread_self()

@Joel: you ok with this cross-link between classic and posix layers? On Tue, Apr 27, 2021 at 3:12 AM Sebastian Huber wrote: > > This may reduce the code size a bit. > --- > cpukit/Makefile.am| 1 - > cpukit/rtems/src/taskself.c | 4 > spec/build/cpukit/librtemscpu.yml

Re: [PATCH] rtems: Constify timer fire when directives

add ticket On Tue, Apr 27, 2021 at 2:54 AM Sebastian Huber wrote: > > --- > cpukit/include/rtems/rtems/timer.h | 4 ++-- > cpukit/rtems/src/timerfirewhen.c | 2 +- > cpukit/rtems/src/timerserverfirewhen.c | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/cpuki

Re: [PATCH] Return status code for _Scheduler_Set_affinity()

ok On Mon, Apr 26, 2021 at 5:55 AM Sebastian Huber wrote: > > This avoids having conditional statements to get the API-specific status > code. > --- > cpukit/include/rtems/score/scheduler.h| 12 ++--- > cpukit/include/rtems/score/scheduleredfsmp.h | 9 --- > cpukit/include/rtem

Re: [PATCH] Return status code for _Thread_Start()

ok On Mon, Apr 26, 2021 at 5:54 AM Sebastian Huber wrote: > > This avoids having conditional statements to get the API-specific status > code. > --- > cpukit/include/rtems/score/threadimpl.h | 7 +++ > cpukit/posix/src/pthreadcreate.c| 5 ++--- > cpukit/rtems/src/taskstart.c

Re: [PATCH] rtems: Change rtems_task_get_affinity() status

This is an API visible change. Please add a ticket. On Mon, Apr 26, 2021 at 5:54 AM Sebastian Huber wrote: > > Return RTEMS_INVALID_SIZE if the processor set is too small to contain > the processor affinity set of the task. > --- > cpukit/include/rtems/score/schedulerimpl.h | 2 +- > cpukit/incl

Re: [PATCH 2/2] Simplify get affinitiy directives

ok On Mon, Apr 26, 2021 at 2:41 AM Sebastian Huber wrote: > > There is no need to disable thread dispatching to get the affinity of a > task. > --- > cpukit/posix/src/pthreadgetaffinitynp.c | 3 --- > cpukit/rtems/src/taskgetaffinity.c | 3 --- > 2 files changed, 6 deletions(-) > > diff --g

Re: [PATCH 1/2] Return status code for _Scheduler_Get_affinity()

ok On Mon, Apr 26, 2021 at 2:41 AM Sebastian Huber wrote: > > This avoids having conditional expressions to the API-specific status > code. > --- > cpukit/include/rtems/score/schedulerimpl.h | 7 --- > cpukit/posix/src/pthreadgetaffinitynp.c| 7 --- > cpukit/posix/src/pthreadgetattrn

Re: [PATCH v2] c-user: Generate interrupt manager documentation

OK, thanks for the clarification. On Mon, Apr 26, 2021 at 11:39 PM Sebastian Huber wrote: > > The documentation is a consolidation of the comments in Doxygen markup > and the documentation sources in Sphinx markup. The documentation was > transfered to interface specification items. The documen

Re: [PATCH] c-user: Generate task manager documentation

On Tue, Apr 27, 2021 at 3:31 AM Sebastian Huber wrote: > > The documentation is a consolidation of the comments in Doxygen markup > and the documentation sources in Sphinx markup. The documentation was > transfered to interface specification items. The documentation source > files were generated

Re: [PATCH v2] STM32 lwIP addition and CMake support

Hi Robin, I'm wading in here a little bit late, but I want to address a couple things. First, if we will move forward with this, it would be best to separate the functional patch from the build patch. I.e., split the cmake stuff from the driver/code improvements. That said, see the following 2 po

Re: [PATCH v4] psx13: Reworked and relicensed

Looks ok, confirm you tested with/without debug, and go ahead and push. On Mon, Apr 26, 2021 at 10:10 AM Ryan Long wrote: > > Changed the way the tests were structured, added rtems_test_assert()'s, > updated psx13.scn and the license. > > Update #3899 > --- > testsuites/psxtests/psx13/main.c

Re: [PATCH] c-user: Generate scheduling concepts documentation

looks good. On Fri, Apr 23, 2021 at 1:15 PM Sebastian Huber wrote: > > The documentation is a consolidation of the comments in Doxygen markup > and the documentation sources in Sphinx markup. The documentation was > transfered to interface specification items. The documentation source > files w

Re: [PATCH v1 1/3] cpukit: Add signal mapping support

On Fri, Apr 23, 2021 at 8:28 AM Kinsey Moore wrote: > > On 4/20/2021 01:44, Chris Johns wrote: > > On 20/4/21 4:38 pm, Sebastian Huber wrote: > >> On 20/04/2021 08:30, Chris Johns wrote: > >>> On 20/4/21 3:54 pm, Sebastian Huber wrote: > On 20/04/2021 07:30, Chris Johns wrote: > > >

Re: [PATCH] c-user: Generate interrupt manager documentation

I need clarification on a subtle point, which exists prior to your change. It may be that I just don't understand what we mean by "The directive will not cause the calling task to be preempted.", but does rtems_interrupt_enable() and rtems_interrupt_flash() introduce a preemption point? The documen

Re: Implimenting timer_monotonic

On Thu, Apr 22, 2021 at 1:39 PM zack_on_the_speed_chanel wrote: > > Hello, > > So in looking at the ticket i realized it was more the making the test and > only testing the creation of a timer object. I also have to implement the > monotonic timer. Right now it seems like a monumental task for

Re: [PATCH rtems 1/2] telnetd.c: Remove RTEMS_NETWORKING check

I guess there's not much else to do here without a network stack API to manipulate the network task(s). Is there a ticket to fix the lack of ability to configure and access network task priorities? I'm guessing libbsd and lwip will both need to figure out how to do this somehow. The design isn't o

Re: [PATCH rtems-docs] legacy-networking: Add note with build instructions for rtems-net-legacy

On Thu, Apr 22, 2021 at 12:08 PM Vijay Kumar Banerjee wrote: > > ping. :) > > On Mon, Apr 19, 2021 at 12:12 PM Vijay Kumar Banerjee wrote: > > > > --- > > legacy-networking/index.rst | 1 + > > legacy-networking/quick_start.rst | 29 + > > 2 files changed, 30 i

Re: [PATCH rtems 2/2] testsuites: Remove telnetd01

Should the commit message indicate where these files have been moved? Otherwise, it's ok to me. Can't run this test without building a stack. On Tue, Apr 13, 2021 at 11:45 PM Vijay Kumar Banerjee wrote: > > --- > spec/build/testsuites/libtests/grp.yml | 2 - > spec/build/testsuites/libt

Re: [PATCH 2/2] c-user: Generate message manager documentation

On Thu, Apr 22, 2021 at 11:33 AM Sebastian Huber wrote: > > On 22/04/2021 17:44, Gedare Bloom wrote: > > > Also not related to the documentation, but it seems that > > rtems_message_queue_construct() will not handle a NULL configuration. > > Is this intentional, or a bu

Re: [PATCH 2/2] c-user: Generate message manager documentation

On Thu, Apr 22, 2021 at 11:52 AM Sebastian Huber wrote: > > On 22/04/2021 17:44, Gedare Bloom wrote: > > >> +:c:macro:`RTEMS_ILLEGAL_ON_REMOTE_OBJECT` > >> +The semaphore resided on a remote node. > > s/semaphore/message queue > > > Thanks for the

Re: [PATCH] psx13: Reworked and relicensed

he banners since only rtems_test_assert() will print anything there. > > > -Original Message- > From: Gedare Bloom > Sent: Thursday, April 22, 2021 8:45 AM > To: Ryan Long > Cc: devel@rtems.org > Subject: Re: [PATCH] psx13: Reworked and relicensed > > S

Re: [PATCH] psx13: Reworked and relicensed

On Thu, Apr 22, 2021 at 9:44 AM Ryan Long wrote: > > What other file? > ls rtems/testsuites/psxtests/psx13 > > > From: Joel Sherrill > Sent: Thursday, April 22, 2021 9:21 AM > To: Sebastian Huber > Cc: Gedare Bloom ; Ryan Long ; > rtems-de...@rtems.org > Sub

Re: [PATCH 1/2] c-user: Generate rate-monotonic manager docs

this one is fine, if you want to resend separately I can ACK it right away, or resend with the v2 of the message queue is fine with me. On Thu, Apr 22, 2021 at 8:07 AM Sebastian Huber wrote: > > The documentation is a consolidation of the comments in Doxygen markup > and the documentation sources

Re: [PATCH 2/2] c-user: Generate message manager documentation

On Thu, Apr 22, 2021 at 8:07 AM Sebastian Huber wrote: > > The documentation is a consolidation of the comments in Doxygen markup > and the documentation sources in Sphinx markup. The documentation was > transfered to interface specification items. The documentation source > files were generated

Re: [PATCH] c-user: fix broken definition in rate-monotonic background.

> > If it's more, poke me. > > On Thu, Apr 22, 2021, 10:10 AM Gedare Bloom wrote: >> >> --- >> c-user/rate-monotonic/background.rst | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/c-user/rate-monotonic/background

[PATCH] c-user: fix broken definition in rate-monotonic background.

--- c-user/rate-monotonic/background.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/c-user/rate-monotonic/background.rst b/c-user/rate-monotonic/background.rst index 9ca7dff..c81af4e 100644 --- a/c-user/rate-monotonic/background.rst +++ b/c-user/rate-monotonic/backgrou

Re: [PATCH] Updated tick implementation for HAL_GetTick

On Thu, Apr 22, 2021 at 8:02 AM Sebastian Huber wrote: > > On 22/04/2021 14:17, Robin Müller wrote: > > > It worked for me. Can you specify that? The overflow check would have > > to be implemented by an upper layer, right? > > I can adapt my former patch using the tick solution to do the > > mult

Re: [PATCH] c-user: Mention timer server fire directives

ok, nice catch. On Thu, Apr 22, 2021 at 5:52 AM Sebastian Huber wrote: > > A timer may be also reinitiated by the timer server fire directives. > --- > c-user/timer/directives.rst | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/c-user/timer/directives.rst b/c-user/t

Re: [PATCH v2] sb: Merge mailer changes from rtems-tools

On Thu, Apr 22, 2021 at 7:18 AM Alex White wrote: > > This adds the improved mailer.py script from rtems-tools. > > Closes #4388 > --- > source-builder/sb/mailer.py | 192 ++-- > source-builder/sb/options.py| 26 - > source-builder/sb/setbuilder.py | 2 +

Re: [PATCH] psx13: Reworked and relicensed

See below for comments. This test suite might be a good candidate for conversion to T_TEST_CASE framework. At any rate, this refactor is a marked improvement. On Wed, Apr 21, 2021 at 2:57 PM Ryan Long wrote: > > Changed the way the tests were structured, added rtems_test_assert()'s, > updated psx

Re: [PATCH 8/8] c-user: Generate dual-ported memory manager docs

On Wed, Apr 21, 2021 at 7:50 AM Sebastian Huber wrote: > > The documentation is a consolidation of the comments in Doxygen markup > and the documentation sources in Sphinx markup. The documentation was > transfered to interface specification items. The documentation source > files were generated

Re: [PATCH 4/8] c-user: Add user extensions glossary terms

On Wed, Apr 21, 2021 at 7:50 AM Sebastian Huber wrote: > > --- > c-user/glossary.rst | 40 +-- > c-user/user-extensions/background.rst | 13 +++-- > 2 files changed, 42 insertions(+), 11 deletions(-) > > diff --git a/c-user/glossary.rst b/c-user/gloss

Re: [PATCH] rtems: Generate

On Wed, Apr 21, 2021 at 7:46 AM Sebastian Huber wrote: > > Change license to BSD-2-Clause according to file histories and > documentation re-licensing agreement. > > Update #3899. > Update #3993. > --- > cpukit/include/rtems/rtems/support.h | 404 +-- > 1 file changed, 320

Re: [PATCH] Fix calloc() behaviour in case of overflow

Looks good. On Tue, Apr 20, 2021, 12:33 PM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > The multiplication to calculate the length of the memory area to > allocate may overflow. Return NULL in case of an overflow. > > Close #4389. > --- > cpukit/libcsupport/src/calloc.c

<    3   4   5   6   7   8   9   10   11   12   >