Re: About HEAP error

> > breaking at _Terminate and doing a back trace will give > you the exact line the error is raised from. I don't know why I did not focus on this earlier! So I put a breakpoint at the line which detects a fault and now we know

Re: About HEAP error

> > This is just the detection point. The allocate is doing a validity check > and something is wrong from an overwrite. > FWIW this is pretty early in the test I think. Good point, the corruption has already happened earlier, and yes its quite early : ... #13 0x0010860e in rtems_task_create

RSB build issue with rtems-libbsd

Hello, I'm getting the following error when trying to build rtems-libbsd from RSB. Is there anything that I'm missing? ``` ../source-builder/sb-set-builder --prefix=$RTEMS6_PREFIX 6/rtems-libbsd --host=powerpc-rtems6 --with-rtems-bsp=beatnik RTEMS Source Builder - Set Builder, 6 (102cb1e6450f)

Re: [PATCH] main_edit.c: Fix Unchecked return value (CID #1255318)

ok On Fri, Mar 5, 2021 at 1:55 PM Ryan Long wrote: > > CID 1255318: Unchecked return value in display_line(). > > Updates #4257 > --- > cpukit/libmisc/shell/main_edit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/cpukit/libmisc/shell/main_edit.c >

Re: [PATCH v3 0/4] Fix Unchecked return value from libarary

This set is ok On Fri, Mar 5, 2021 at 1:42 PM Ryan Long wrote: > > Hi, > > Here are the patches with the fix to main_chmod.c. > > Thanks, > Ryan > > Ryan Long (4): > gen_uuid.c: Fix two Unchecked return value from library errors > main_chmod.c: Fix Unchecked return value from library (CID

[PATCH] Fix Unchecked return value issue

Hi, Here's the fix for main_edit.c. I just just needed to add a space between (void) and the function call. Thanks, Ryan Ryan Long (1): main_edit.c: Fix Unchecked return value (CID #1255318) cpukit/libmisc/shell/main_edit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.8.3.1

[PATCH] main_edit.c: Fix Unchecked return value (CID #1255318)

CID 1255318: Unchecked return value in display_line(). Updates #4257 --- cpukit/libmisc/shell/main_edit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpukit/libmisc/shell/main_edit.c b/cpukit/libmisc/shell/main_edit.c index a011049..8ac7eee 100644 ---

[PATCH v3 0/4] Fix Unchecked return value from libarary

Hi, Here are the patches with the fix to main_chmod.c. Thanks, Ryan Ryan Long (4): gen_uuid.c: Fix two Unchecked return value from library errors main_chmod.c: Fix Unchecked return value from library (CID #1063856) pwdgrp.c: Fix Unchecked return value from library (CID #1255518)

[PATCH v3 4/4] main_help.c: Unchecked return value from library (CID #1437650)

CID 1437650: Unchecked return value from library in rtems_shell_help(). Closes #4291 --- cpukit/libmisc/shell/main_help.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cpukit/libmisc/shell/main_help.c b/cpukit/libmisc/shell/main_help.c index 611f2e0..9f59e9d 100644 ---

[PATCH v3 1/4] gen_uuid.c: Fix two Unchecked return value from library errors

CID 1049146: Unchecked return value from library in get_clock(). CID 1049147: Unchecked return value from library in get_random_fd(). Closes #4280 --- cpukit/libmisc/uuid/gen_uuid.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/cpukit/libmisc/uuid/gen_uuid.c

[PATCH v3 3/4] pwdgrp.c: Fix Unchecked return value from library (CID #1255518)

CID 1255518: Unchecked return value from library in pwdgrp_init(). Closes #4282 --- cpukit/libcsupport/src/pwdgrp.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/cpukit/libcsupport/src/pwdgrp.c b/cpukit/libcsupport/src/pwdgrp.c index a97d397..f4a10f7 100644 ---

[PATCH v3 2/4] main_chmod.c: Fix Unchecked return value from library (CID #1063856)

CID 1063856: Unchecked return value from library in rtems_shell_main_chmod(). Closes #4281 --- cpukit/libmisc/shell/main_chmod.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/cpukit/libmisc/shell/main_chmod.c b/cpukit/libmisc/shell/main_chmod.c index

Fwd: Makefile.in not regenerated for libc/posix

Unfortunately newlib needs to bump again to catch the minor fix -- Forwarded message - From: Eshan Dhawan via Newlib Date: Fri, Mar 5, 2021, 1:27 PM Subject: Makefile.in not regenerated for libc/posix To: Newlib Hello, Makefile.in wasn’t regenerated for libc/posix For the

Re: [PATCH v2 0/4] Fix Unchecked return value from library issues

1, 3, 4 are fine. 2 needs to be fixed. On Fri, Mar 5, 2021 at 12:47 PM Ryan Long wrote: > > Hi, > > Here are the patches with the recommended fixes. > > Thanks, > Ryan > > Ryan Long (4): > gen_uuid.c: Fix two Unchecked return value from library errors > main_chmod.c: Fix Unchecked return

Re: [PATCH v2 2/4] main_chmod.c: Fix Unchecked return value from library (CID #1063856)

On Fri, Mar 5, 2021 at 12:47 PM Ryan Long wrote: > > CID 1063856: Unchecked return value from library in > rtems_shell_main_chmod(). > > Closes #4281 > --- > cpukit/libmisc/shell/main_chmod.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git

[PATCH v2 4/4] main_help.c: Unchecked return value from library (CID #1437650)

CID 1437650: Unchecked return value from library in rtems_shell_help(). Closes #4291 --- cpukit/libmisc/shell/main_help.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cpukit/libmisc/shell/main_help.c b/cpukit/libmisc/shell/main_help.c index 611f2e0..9f59e9d 100644 ---

[PATCH v2 3/4] pwdgrp.c: Fix Unchecked return value from library (CID #1255518)

CID 1255518: Unchecked return value from library in pwdgrp_init(). Closes #4282 --- cpukit/libcsupport/src/pwdgrp.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/cpukit/libcsupport/src/pwdgrp.c b/cpukit/libcsupport/src/pwdgrp.c index a97d397..f4a10f7 100644 ---

[PATCH v2 2/4] main_chmod.c: Fix Unchecked return value from library (CID #1063856)

CID 1063856: Unchecked return value from library in rtems_shell_main_chmod(). Closes #4281 --- cpukit/libmisc/shell/main_chmod.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/cpukit/libmisc/shell/main_chmod.c b/cpukit/libmisc/shell/main_chmod.c index 0c39072..df18ef1

[PATCH v2 0/4] Fix Unchecked return value from library issues

Hi, Here are the patches with the recommended fixes. Thanks, Ryan Ryan Long (4): gen_uuid.c: Fix two Unchecked return value from library errors main_chmod.c: Fix Unchecked return value from library (CID #1063856) pwdgrp.c: Fix Unchecked return value from library (CID #1255518)

[PATCH v2 1/4] gen_uuid.c: Fix two Unchecked return value from library errors

CID 1049146: Unchecked return value from library in get_clock(). CID 1049147: Unchecked return value from library in get_random_fd(). Closes #4280 --- cpukit/libmisc/uuid/gen_uuid.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/cpukit/libmisc/uuid/gen_uuid.c

Re: [PATCH rtems-net-legacy] netlegacy: Build libtelnetd.a and install header file in correct location

On Fri, Mar 5, 2021 at 12:08 PM Vijay Kumar Banerjee wrote: > > On Fri, Mar 5, 2021 at 12:07 PM Gedare Bloom wrote: > > > > On Fri, Mar 5, 2021 at 11:42 AM Vijay Kumar Banerjee > > wrote: > > > > > > --- > > > netlegacy.py | 27 +-- > > >

Re: [PATCH rtems-net-legacy] netlegacy: Build libtelnetd.a and install header file in correct location

On Fri, Mar 5, 2021 at 12:07 PM Gedare Bloom wrote: > > On Fri, Mar 5, 2021 at 11:42 AM Vijay Kumar Banerjee wrote: > > > > --- > > netlegacy.py | 27 +-- > > testsuites/telnetd01/wscript | 2 +- > > 2 files changed, 22 insertions(+), 7 deletions(-) > >

Re: [PATCH rtems-net-legacy] netlegacy: Build libtelnetd.a and install header file in correct location

On Fri, Mar 5, 2021 at 11:42 AM Vijay Kumar Banerjee wrote: > > --- > netlegacy.py | 27 +-- > testsuites/telnetd01/wscript | 2 +- > 2 files changed, 22 insertions(+), 7 deletions(-) > > diff --git a/netlegacy.py b/netlegacy.py > index 037e2ee..0889548

Re: [PATCH 0/3] Fix Missing break in switch Coverity issues

On Fri, Mar 5, 2021 at 11:48 AM Sebastian Huber wrote: > > On 05/03/2021 19:40, Joel Sherrill wrote: > > > On Fri, Mar 5, 2021, 12:25 PM Sebastian Huber > > > > wrote: > > > > On 05/03/2021 16:27, Gedare Bloom wrote: > > > > > Should we add a

Re: Checking Status of My Outstanding Patches

Yes, that looks right. Joel, you can push his grlib patches and the case fall-throughs. On Fri, Mar 5, 2021 at 11:19 AM Ryan Long wrote: > > Hi, > > > > Since I’ve sent a lot of patches this week, I just want to verify which are > ready to be merged and what needs to be resubmitted. > > > >

[PATCH 2/2] bsps/shared: Allow setting baud rate for zynq uart

Closes #4236 --- bsps/arm/shared/serial/zynq-uart.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/bsps/arm/shared/serial/zynq-uart.c b/bsps/arm/shared/serial/zynq-uart.c index a0dfc0c929..f298719fde 100644 --- a/bsps/arm/shared/serial/zynq-uart.c +++

[5 PATCH 0/2] Backport fixes to zynq uart to RTEMS5

This patchset backports the commits of Kinsey Moore and myself, which fix the stdin behavior for the zynq-uart based console driver. I checked the behavior on hardware with the termios.exe application. Before, the scanf and similar functions do not wait for user input and return immediately. With

[PATCH 1/2] zynq-uart: Fix set_attributes implementation

From: Kinsey Moore The zynq-uart set_attributes implementation was configured to always return false which causes spconsole01 to fail. This restores the disabled implementation which sets the baud rate registers appropriately and allows spconsole01 to pass. This also expands the set_attributes

Re: [PATCH 0/3] Fix Missing break in switch Coverity issues

On 05/03/2021 19:40, Joel Sherrill wrote: On Fri, Mar 5, 2021, 12:25 PM Sebastian Huber > wrote: On 05/03/2021 16:27, Gedare Bloom wrote: > Should we add a macro for this, e.g., "RTEMS_CASE_NO_BREAK" so that we > can update them in

[PATCH rtems-net-legacy] netlegacy: Build libtelnetd.a and install header file in correct location

--- netlegacy.py | 27 +-- testsuites/telnetd01/wscript | 2 +- 2 files changed, 22 insertions(+), 7 deletions(-) diff --git a/netlegacy.py b/netlegacy.py index 037e2ee..0889548 100644 --- a/netlegacy.py +++ b/netlegacy.py @@ -31,7 +31,8 @@ import os

Re: [PATCH 0/3] Fix Missing break in switch Coverity issues

On Fri, Mar 5, 2021, 12:25 PM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 05/03/2021 16:27, Gedare Bloom wrote: > > > Should we add a macro for this, e.g., "RTEMS_CASE_NO_BREAK" so that we > > can update them in future if needed for other tools? > I would just pick a name

Re: [PATCH 0/3] Fix Missing break in switch Coverity issues

On 05/03/2021 16:27, Gedare Bloom wrote: Should we add a macro for this, e.g., "RTEMS_CASE_NO_BREAK" so that we can update them in future if needed for other tools? I would just pick a name which is understood by GCC, clang, and Coverity. I guess other tools will understand this or why did you

Checking Status of My Outstanding Patches

Hi, Since I've sent a lot of patches this week, I just want to verify which are ready to be merged and what needs to be resubmitted. Ready to be merged: Grlib patches: * grspw.c * gr_rasta_spw_router.c * gr_rasta_tmtc.c * gr_leon4_n2x.c * gr_701.c *

RE: [PATCH v3 1/1] bsps/shared: Allow setting baud rate for zynq uart

Thanks. Pushed to master. > -Original Message- > From: Gedare Bloom > Sent: Friday, March 5, 2021 6:48 PM > To: Sommer, Jan > Cc: devel@rtems.org > Subject: Re: [PATCH v3 1/1] bsps/shared: Allow setting baud rate for zynq > uart > > Looks good to me. > > On Fri, Mar 5, 2021 at 10:42

[PATCH v2] user/bsps: Mention fixed console baud rate for zynq

--- user/bsps/arm/xilinx-zynq.rst | 12 1 file changed, 12 insertions(+) diff --git a/user/bsps/arm/xilinx-zynq.rst b/user/bsps/arm/xilinx-zynq.rst index 365c336..29f9cb0 100644 --- a/user/bsps/arm/xilinx-zynq.rst +++ b/user/bsps/arm/xilinx-zynq.rst @@ -37,6 +37,18 @@ to return the

RE: [PATCH v3 0/1] Enable baud rate selection for zynq uart

Thanks. To be honest, I wasn’t really sure what to do with B0 since there aren’t any modem control lines. I just grepped for B0 and looked what other BSPs are doing and they do nothing, so I copied that to have at least common behavior among RTEMS. From: Joel Sherrill Sent: Friday, March 5,

Re: [PATCH v3 0/1] Enable baud rate selection for zynq uart

On Fri, Mar 5, 2021 at 11:42 AM Jan Sommer wrote: > v3: > - Make sure the baud registers are not modified for baud rate B0 > B0 is an odd bird. It indicates hang up. From https://pubs.opengroup.org/onlinepubs/9699919799.2008edition/functions/tcsetattr.html : If the output baud rate stored in

Re: [PATCH v3 1/1] bsps/shared: Allow setting baud rate for zynq uart

Looks good to me. On Fri, Mar 5, 2021 at 10:42 AM Jan Sommer wrote: > > --- > bsps/shared/dev/serial/zynq-uart.c | 21 - > 1 file changed, 16 insertions(+), 5 deletions(-) > > diff --git a/bsps/shared/dev/serial/zynq-uart.c > b/bsps/shared/dev/serial/zynq-uart.c > index

[PATCH v3 0/1] Enable baud rate selection for zynq uart

v3: - Make sure the baud registers are not modified for baud rate B0 v2: - Use rtems_baud_to_number instead of duplicating baud table This patch allows to set the baud rate of the zynq-uart using the termios API. I could change the baud rate successfully on hardware using the termios

[PATCH v3 1/1] bsps/shared: Allow setting baud rate for zynq uart

--- bsps/shared/dev/serial/zynq-uart.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/bsps/shared/dev/serial/zynq-uart.c b/bsps/shared/dev/serial/zynq-uart.c index 8f17d3ca65..cd0d0e7584 100644 --- a/bsps/shared/dev/serial/zynq-uart.c +++

RE: [PATCH v4 0/3] Add cadence-SPI driver

Thanks, I got some test feedback from Rick van der Wal. I will prepare a new patch set with some modifications. The zynq-uart issue is currently more pressing for me. Best regards, Jan > -Original Message- > From: Gedare Bloom > Sent: Friday, March 5, 2021 4:41 PM > To: Sommer, Jan

RE: [PATCH v2 1/1] bsps/shared: Allow setting baud rate for zynq uart

> -Original Message- > From: Gedare Bloom > Sent: Friday, March 5, 2021 4:36 PM > To: Sommer, Jan > Cc: devel@rtems.org > Subject: Re: [PATCH v2 1/1] bsps/shared: Allow setting baud rate for zynq > uart > > On Mon, Feb 22, 2021 at 9:23 AM Jan Sommer wrote: > > > > --- > >

Re: Standalone repository for libnetworking stack

On Fri, Mar 5, 2021 at 9:37 AM Joel Sherrill wrote: > > > > On Fri, Mar 5, 2021 at 9:48 AM Vijay Kumar Banerjee wrote: >> >> Hi all, >> >> If no one has any objections, I would like to push the RTEMS patches to >> remove libnetworking. >> >> The patches are in this repo: >>

Re: Standalone repository for libnetworking stack

On Fri, Mar 5, 2021 at 9:48 AM Vijay Kumar Banerjee wrote: > Hi all, > > If no one has any objections, I would like to push the RTEMS patches to > remove libnetworking. > > The patches are in this repo: > https://git.rtems.org/vijay/rtems.git/log/?h=devel-no-libnet > I do not object but this is

Re: Standalone repository for libnetworking stack

Hi all, If no one has any objections, I would like to push the RTEMS patches to remove libnetworking. The patches are in this repo: https://git.rtems.org/vijay/rtems.git/log/?h=devel-no-libnet Best regards, Vijay On Mon, Mar 1, 2021, 14:48 Vijay Kumar Banerjee wrote: > On Mon, Mar 1, 2021

Re: [PATCH v4 0/3] Add cadence-SPI driver

Jan, I think this driver is fine to go in if you're happy with it. On Fri, Feb 19, 2021 at 6:06 AM Jan Sommer wrote: > > v4: > - Use copyright information without UTF-8 characters > > v3: > - Fix wrong changes to spec/build/bsps/arm/xilinx-zynq/obj.yml > > v2: > - Moved source file to

Re: [PATCH v2 1/1] bsps/shared: Allow setting baud rate for zynq uart

On Thu, Mar 4, 2021 at 1:11 AM wrote: > > Could someone please have a look a this patch and approve it? > Should I then still add a new section to the docs regarding the console > behavior for the zynq? Please do prepare an addition for the docs, that would be great. > With this patch applied

Re: [PATCH v2 1/1] bsps/shared: Allow setting baud rate for zynq uart

On Mon, Feb 22, 2021 at 9:23 AM Jan Sommer wrote: > > --- > bsps/shared/dev/serial/zynq-uart.c | 14 +++--- > 1 file changed, 11 insertions(+), 3 deletions(-) > > diff --git a/bsps/shared/dev/serial/zynq-uart.c > b/bsps/shared/dev/serial/zynq-uart.c > index 8f17d3ca65..dd5a6e1cb8 100644

Re: [PATCH 0/3] Fix Missing break in switch Coverity issues

Should we add a macro for this, e.g., "RTEMS_CASE_NO_BREAK" so that we can update them in future if needed for other tools? Regardless of the addition of a macro these are fine, the grlib one came through separately I think. But I'd like to see a macro proposed. On Wed, Mar 3, 2021 at 2:26 PM

Re: [PATCH] user: Update ZynqMP QEMU BSP name

ok On Thu, Mar 4, 2021 at 10:03 AM Kinsey Moore wrote: > > The ZynqMP QEMU BSPs have had _qemu added to their names to better > identify them as QEMU BSPs similar to other BSPs which are meant to run > exclusively on QEMU and not hardware. > --- > user/bsps/aarch64/xilinx-zynqmp.rst | 11

Re: [PATCH] spec/aarch64: Rename ZynqMP QEMU BSPs

ok On Thu, Mar 4, 2021 at 10:03 AM Kinsey Moore wrote: > > The current ZynqMP BSPs don't have _qemu in their name as do all other > RTEMS BSPs that are specifically made to run on QEMU. This fixes the > naming for those ZynqMP BSP variants for easier identification. > --- >

Re: [PATCH v3 2/2] bsps/aarch64: Resolve usage of SUBALIGN()

This one seems fine to me based on my understanding of the rtemsr*set explicit alignment change. On Wed, Mar 3, 2021 at 6:37 AM Kinsey Moore wrote: > > Remove usage of SUBALIGN() in aarch64 linkcmds which works around a > difference in behavior on AArch64 platforms. This is no longer necessary >

Re: [PATCH 10/12] satcan.c: Fix Unsigned compared against 0 (CID #1399768)

On Fri, Mar 5, 2021 at 8:13 AM Joel Sherrill wrote: > > > > On Fri, Mar 5, 2021, 9:08 AM Gedare Bloom wrote: >> >> On Thu, Mar 4, 2021 at 12:50 PM Ryan Long wrote: >> > >> > CID 1399768: Unsigned compared against 0 in satcan_ioctl(). >> > >> > Closes #4294 >> > --- >> >

Re: [PATCH 10/12] satcan.c: Fix Unsigned compared against 0 (CID #1399768)

On Fri, Mar 5, 2021, 9:08 AM Gedare Bloom wrote: > On Thu, Mar 4, 2021 at 12:50 PM Ryan Long > wrote: > > > > CID 1399768: Unsigned compared against 0 in satcan_ioctl(). > > > > Closes #4294 > > --- > > bsps/shared/grlib/can/satcan.c | 16 > > 1 file changed, 4 insertions(+),

Re: [PATCH 11/12] b1553brm.c: Fix Unsigned compared against 0 (CID #1399773)

On Thu, Mar 4, 2021 at 12:50 PM Ryan Long wrote: > > CID 1399773: Unsigned compared against 0 in brm_write(). > > Closes #4295 > --- > bsps/shared/grlib/1553/b1553brm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/bsps/shared/grlib/1553/b1553brm.c >

Re: [PATCH 10/12] satcan.c: Fix Unsigned compared against 0 (CID #1399768)

On Thu, Mar 4, 2021 at 12:50 PM Ryan Long wrote: > > CID 1399768: Unsigned compared against 0 in satcan_ioctl(). > > Closes #4294 > --- > bsps/shared/grlib/can/satcan.c | 16 > 1 file changed, 4 insertions(+), 12 deletions(-) > > diff --git a/bsps/shared/grlib/can/satcan.c

Re: About HEAP error

On Thu, Mar 4, 2021, 11:31 PM Richi Dubey wrote: > Hi, > > Thanks to both of you for helping me out with this! > > When I backtrace on _Terminate: I get this: > > Init -> rtems_task_create -> ... -> _Heap_Allocate -> ... > ->_Heap_Protection_check_free_block -> _Heap_Protection_block_error >

FTW tests Re: [rtems-source-builder commit] 6: Update tool chain

Thanks Sebastian. I built this newlib hash yesterday for all targets on Centos and was about to test Eshan's ftw test patches. I'm hoping an our of date toolset causes test failures and not build failures. Are we at a point where a forced tool upgrade might be acceptable? --joel On Fri, Mar 5,

RE: [PATCH] aarch64: Fix context switch

Sorry, I though this had already been committed. I had a patch in my private branch that lines up exactly with this one which I skipped when pushing my other patch set to the list. This looks good. Kinsey -Original Message- From: Sebastian Huber Sent: Thursday, March 4, 2021 23:56 To:

RE: [PATCH v1 7/7] spec/aarch64: Force strict alignment for ZynqMP

Hi Sebastian, For AArch64, that would be SCTLR_EL1.A (bit 1). Even with that alignment checking disabled, I still see data aborts on misaligned accesses. The MMU is disabled during operation, so that wouldn't be the issue, either. From reading the spec on that bit, it would seem that AArch64 is