Re: [PATCH 1/3] waf_generator: Copy headers if necessary.

2017-08-10 Thread Chris Johns
OK with the minor change. On 11/08/2017 04:14, Christian Mauderer wrote: > From: Christian Mauderer > > There are some cases, where a header is installed into a directory with > a different name then it's source directory. In that case, the build > might

Re [PATCH 1/3] waf_generator: Copy headers if necessary.

2017-08-10 Thread Christian Mauderer
Hello Chris and Sichen, I updated the patch "waf_generator: Copy headers if necessary." according to Chris suggestions. @Chris: Could you have a look if it now looks OK for you? @Sichen: Could you replace the first patch in your patch set with this one? I also created a patch that moves the **

[PATCH 1/3] waf_generator: Copy headers if necessary.

2017-08-10 Thread Christian Mauderer
From: Christian Mauderer There are some cases, where a header is installed into a directory with a different name then it's source directory. In that case, the build might fail because the header is not found. One example would be the . The source for this

Re: [PATCH 1/3] waf_generator: Copy headers if necessary.

2017-08-10 Thread Chris Johns
On 10/08/2017 16:41, Christian Mauderer wrote: > > I was more concerned that the include list in builder.py has grown > significantly. If you don't have a problem with that, it's OK. > I will fix this after the merge. >> I could look at making libbsd.py into libbsd/__init__.py with a file per

Re: [PATCH 1/3] waf_generator: Copy headers if necessary.

2017-08-10 Thread Christian Mauderer
Am 10.08.2017 um 08:31 schrieb Chris Johns: > On 10/08/2017 16:06, Christian Mauderer wrote: >> Am 10.08.2017 um 07:55 schrieb Chris Johns: >>> On 10/08/2017 15:34, Christian Mauderer wrote: Am 10.08.2017 um 01:08 schrieb Chris Johns: > On 10/08/2017 02:29, Sichen Zhao wrote: >>

Re: [PATCH 1/3] waf_generator: Copy headers if necessary.

2017-08-10 Thread Christian Mauderer
Am 10.08.2017 um 07:55 schrieb Chris Johns: > On 10/08/2017 15:34, Christian Mauderer wrote: >> Am 10.08.2017 um 01:08 schrieb Chris Johns: >>> On 10/08/2017 02:29, Sichen Zhao wrote: From: Christian Mauderer >> There was no real reason. I just chose

Re: [PATCH 1/3] waf_generator: Copy headers if necessary.

2017-08-09 Thread Chris Johns
On 10/08/2017 15:34, Christian Mauderer wrote: > Am 10.08.2017 um 01:08 schrieb Chris Johns: >> On 10/08/2017 02:29, Sichen Zhao wrote: >>> From: Christian Mauderer > There was no real reason. I just chose an arbitrary name. > 'build-include' is fine for me

Re: [PATCH 1/3] waf_generator: Copy headers if necessary.

2017-08-09 Thread Christian Mauderer
Am 10.08.2017 um 01:08 schrieb Chris Johns: > On 10/08/2017 02:29, Sichen Zhao wrote: >> From: Christian Mauderer >> >> There are some cases, where a header is installed into a directory with >> a different name then it's source directory. In that case, the

Re: [PATCH 1/3] waf_generator: Copy headers if necessary.

2017-08-09 Thread Chris Johns
On 10/08/2017 02:29, Sichen Zhao wrote: > From: Christian Mauderer > > There are some cases, where a header is installed into a directory with > a different name then it's source directory. In that case, the build > might fail because the header is not

[PATCH 1/3] waf_generator: Copy headers if necessary.

2017-08-09 Thread Sichen Zhao
From: Christian Mauderer There are some cases, where a header is installed into a directory with a different name then it's source directory. In that case, the build might fail because the header is not found. One example would be the . The source for this