Re: [uclibc-ng-devel] [RFC PATCH v4 1/1] libpthread: Fix inclusion of unwind code.
On Wed, Nov 30, 2016 at 06:40:01AM +0100, thus spake Waldemar Brodkorb: > Hi Ignacy, Hi Waldemar, > Ignacy Gawędzki wrote, > > > Since librt and libpthread are now integrated into libc, including > > unwind-resume and unwind-forcedunwind implementations of unwind code > > makes no sense. Only unwind-forcedunwind is now included with > > functions hidden to avoid them overriding the ones from libgcc_s. > > I tested the patch and I think I will push it in the next days. Nice. > Sorry that it took a while, but the removal of the test suite > took a while. Now the test suite is compiled as a normal software > package and not with the initial gcc. That's definitely the right way to go. > Therefore no regressions seen with your patch. I'm happy to hear that. =) > Any other news to the patch? No. We've been using it on uClibc-ng 1.0.18 in-house for weeks without any noticeable problem. Regards, Ignacy -- Ignacy Gawędzki R Engineer Green Communications ___ devel mailing list devel@uclibc-ng.org http://mailman.uclibc-ng.org/cgi-bin/mailman/listinfo/devel
Re: [uclibc-ng-devel] [RFC PATCH v4 1/1] libpthread: Fix inclusion of unwind code.
Hi Ignacy, Ignacy Gawędzki wrote, > Since librt and libpthread are now integrated into libc, including > unwind-resume and unwind-forcedunwind implementations of unwind code > makes no sense. Only unwind-forcedunwind is now included with > functions hidden to avoid them overriding the ones from libgcc_s. I tested the patch and I think I will push it in the next days. Sorry that it took a while, but the removal of the test suite took a while. Now the test suite is compiled as a normal software package and not with the initial gcc. Therefore no regressions seen with your patch. Any other news to the patch? best regards Waldemar ___ devel mailing list devel@uclibc-ng.org http://mailman.uclibc-ng.org/cgi-bin/mailman/listinfo/devel
Re: [uclibc-ng-devel] [RFC PATCH v4 1/1] libpthread: Fix inclusion of unwind code.
On Mon, Oct 17, 2016 at 03:40:04PM +0200, thus spake Ignacy Gawedzki: > On Sun, Oct 16, 2016 at 10:01:30PM +0200, thus spake Waldemar Brodkorb: > > > As I said, I used d4d4f37 and not strictly origin/master. But I > > > otherwise used the command line you gave me, including --libc-source. > > > > But 17ad14e5780533db90171e16b95dbeda4e81ffb0 contains a workaround > > for exactly the seen problem. > > > > > I will re-run the tests with origin/master and my patch on top of it. > > I found a few interesting things. The test binaries are compiled by > openadk with the "initial" GCC and not the "final" one. The > difference is that the implementation of the unwinder code is then > taken from libgcc.a. I get the same behavior if I explicitly add this > library to the list of objects to link into the test binary. With a > final version of GCC, the implementation is taken from libgcc_s.so as > it should and the behavior is maybe not ideal but to me it looks far > better (is that because the initial GCC doesn't really implement any > unwinder code?). BTW, the initial GCC is built with --disable-threads. Could that possibly be the reason some of the tests in nptl fail? -- Ignacy Gawędzki R Engineer Green Communications ___ devel mailing list devel@uclibc-ng.org http://mailman.uclibc-ng.org/cgi-bin/mailman/listinfo/devel
Re: [uclibc-ng-devel] [RFC PATCH v4 1/1] libpthread: Fix inclusion of unwind code.
On Sun, Oct 16, 2016 at 10:01:30PM +0200, thus spake Waldemar Brodkorb: > > As I said, I used d4d4f37 and not strictly origin/master. But I > > otherwise used the command line you gave me, including --libc-source. > > But 17ad14e5780533db90171e16b95dbeda4e81ffb0 contains a workaround > for exactly the seen problem. > > > I will re-run the tests with origin/master and my patch on top of it. I found a few interesting things. The test binaries are compiled by openadk with the "initial" GCC and not the "final" one. The difference is that the implementation of the unwinder code is then taken from libgcc.a. I get the same behavior if I explicitly add this library to the list of objects to link into the test binary. With a final version of GCC, the implementation is taken from libgcc_s.so as it should and the behavior is maybe not ideal but to me it looks far better (is that because the initial GCC doesn't really implement any unwinder code?). The reason why this works without my patch is that the implementation of the unwinder code is then linked dynamically from libc.so, which, as I've said previously, is not supposed to be used by code from outside the lib itself. I haven't had time yet to look into openadk in order to understand why it's not using the final GCC to build the tests. Do you have any idea? -- Ignacy Gawędzki R Engineer Green Communications ___ devel mailing list devel@uclibc-ng.org http://mailman.uclibc-ng.org/cgi-bin/mailman/listinfo/devel
Re: [uclibc-ng-devel] [RFC PATCH v4 1/1] libpthread: Fix inclusion of unwind code.
Hi, Ignacy Gawędzki wrote, > On Sun, Oct 16, 2016 at 05:45:40PM +0200, thus spake Waldemar Brodkorb: > > I tested again. With uClibc-ng master i get exactly 3 errors. > > Tried three times. > > I was using d4d4f37 and my patch applied on top of it. > > > > > With your patch I get sometime 11 or 12 errors. Seems a timeout > > issue. > > > > What version of Qemu are you using? > > > > qemu-system-mips -version > > > > QEMU emulator version 2.6.1, Copyright (c) 2003-2008 Fabrice Bellard > > I'm using 2.5.0. > > > > > We recently had issues with the testsuite build without the full gcc > > and I thinking of separating the testsuite to its own project. > > > > OpenADK does not change between runs of embedded-test as long as > > you don't use --update. > > Yes, but I ran my tests in two copies of embedded-test.git, and most > probably the second one cloned a more recent version of openadk. > > > Are you sure you use uClibc-ng fresh checkout and referencing the > > directory with --libc-source? 1.0.18 release would have 11/12 > > errors, which is the fallback when no special directory is used. > > As I said, I used d4d4f37 and not strictly origin/master. But I > otherwise used the command line you gave me, including --libc-source. But 17ad14e5780533db90171e16b95dbeda4e81ffb0 contains a workaround for exactly the seen problem. > I will re-run the tests with origin/master and my patch on top of it. Okay, thanks. Waldemar ___ devel mailing list devel@uclibc-ng.org http://mailman.uclibc-ng.org/cgi-bin/mailman/listinfo/devel
Re: [uclibc-ng-devel] [RFC PATCH v4 1/1] libpthread: Fix inclusion of unwind code.
On Sun, Oct 16, 2016 at 05:45:40PM +0200, thus spake Waldemar Brodkorb: > I tested again. With uClibc-ng master i get exactly 3 errors. > Tried three times. I was using d4d4f37 and my patch applied on top of it. > > With your patch I get sometime 11 or 12 errors. Seems a timeout > issue. > > What version of Qemu are you using? > > qemu-system-mips -version > > QEMU emulator version 2.6.1, Copyright (c) 2003-2008 Fabrice Bellard I'm using 2.5.0. > > We recently had issues with the testsuite build without the full gcc > and I thinking of separating the testsuite to its own project. > > OpenADK does not change between runs of embedded-test as long as > you don't use --update. Yes, but I ran my tests in two copies of embedded-test.git, and most probably the second one cloned a more recent version of openadk. > Are you sure you use uClibc-ng fresh checkout and referencing the > directory with --libc-source? 1.0.18 release would have 11/12 > errors, which is the fallback when no special directory is used. As I said, I used d4d4f37 and not strictly origin/master. But I otherwise used the command line you gave me, including --libc-source. I will re-run the tests with origin/master and my patch on top of it. Cheers, Ignacy -- Ignacy Gawędzki R Engineer Green Communications ___ devel mailing list devel@uclibc-ng.org http://mailman.uclibc-ng.org/cgi-bin/mailman/listinfo/devel
Re: [uclibc-ng-devel] [RFC PATCH v4 1/1] libpthread: Fix inclusion of unwind code.
Hi, Ignacy Gawędzki wrote, > On Thu, Oct 13, 2016 at 09:19:19PM +0200, thus spake Waldemar Brodkorb: > > If you want you can try it with my embedded-test script (you need > > mksh and qemu installed): > > git clone git://git.embedded-test.org/git/embedded-test > > cd embedded-test > > git clone git://git.uclibc-ng.org/git/uclibc-ng > > mksh embedded-test.sh --arch=mipsel --libc=uclibc-ng \ > > --libc-source=uclibc-ng --test=libc > > > > Only 3 tests should fail. > > Then apply your patch and run it again, it will automatically > > do a complete clean build. > > Okay I did this several times yesterday. On the first attempts, 11 > tests failed without my patch vs. 12 with it. The additional test > that failed with my patch was nptl/tst-cancelx10. I started > investigating what could possibly go wrong and tried several things, > from running the binary with qemu-mipsel to logging into the vm used > for tests and running the test from there. It seemed at first that > with my patch the binary got killed with SIGABRT. I re-ran > embedded-test.sh several times in the process and at some point > noticed that the SHA-1 for openadk is not the same. Since that > moment, I re-ran embedded-test.sh with a pristine setup in both cases > (with and without my patch). Now in both cases I have 11 failed tests > and nptl/tst-cancelx10 doesn't fail. > > So I'm wondering whether anything in openadk could have changed in the > meantime that makes the tests work well in both cases. > > Could you please run the tests again yourself to check this? I tested again. With uClibc-ng master i get exactly 3 errors. Tried three times. With your patch I get sometime 11 or 12 errors. Seems a timeout issue. What version of Qemu are you using? qemu-system-mips -version QEMU emulator version 2.6.1, Copyright (c) 2003-2008 Fabrice Bellard We recently had issues with the testsuite build without the full gcc and I thinking of separating the testsuite to its own project. OpenADK does not change between runs of embedded-test as long as you don't use --update. Are you sure you use uClibc-ng fresh checkout and referencing the directory with --libc-source? 1.0.18 release would have 11/12 errors, which is the fallback when no special directory is used. best regards Waldemar ___ devel mailing list devel@uclibc-ng.org http://mailman.uclibc-ng.org/cgi-bin/mailman/listinfo/devel
Re: [uclibc-ng-devel] [RFC PATCH v4 1/1] libpthread: Fix inclusion of unwind code.
On Thu, Oct 13, 2016 at 09:19:19PM +0200, thus spake Waldemar Brodkorb: > If you want you can try it with my embedded-test script (you need > mksh and qemu installed): > git clone git://git.embedded-test.org/git/embedded-test > cd embedded-test > git clone git://git.uclibc-ng.org/git/uclibc-ng > mksh embedded-test.sh --arch=mipsel --libc=uclibc-ng \ > --libc-source=uclibc-ng --test=libc > > Only 3 tests should fail. > Then apply your patch and run it again, it will automatically > do a complete clean build. Okay I did this several times yesterday. On the first attempts, 11 tests failed without my patch vs. 12 with it. The additional test that failed with my patch was nptl/tst-cancelx10. I started investigating what could possibly go wrong and tried several things, from running the binary with qemu-mipsel to logging into the vm used for tests and running the test from there. It seemed at first that with my patch the binary got killed with SIGABRT. I re-ran embedded-test.sh several times in the process and at some point noticed that the SHA-1 for openadk is not the same. Since that moment, I re-ran embedded-test.sh with a pristine setup in both cases (with and without my patch). Now in both cases I have 11 failed tests and nptl/tst-cancelx10 doesn't fail. So I'm wondering whether anything in openadk could have changed in the meantime that makes the tests work well in both cases. Could you please run the tests again yourself to check this? Cheers, Ignacy -- Ignacy Gawędzki R Engineer Green Communications ___ devel mailing list devel@uclibc-ng.org http://mailman.uclibc-ng.org/cgi-bin/mailman/listinfo/devel
