Pushed as 0b4acb8.
-Original Message-
From: devel@edk2.groups.io On Behalf Of Ni, Ray
Sent: Tuesday, October 31, 2023 1:22 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel
Subject: [edk2-devel] [PATCH] IntelFsp2Pkg/SwitchStack: Reserve 32B when
calling C function in 64bit
When FSP runs in
Reviewed-by: Nate DeSimone
-Original Message-
From: Ni, Ray
Sent: Wednesday, November 1, 2023 2:30 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Duggapu, Chinni B
; Ng, Ray Han Lim ; Zeng,
Star ; Kuo, Ted ; S, Ashraf Ali
; Mohapatra, Susovan
Subject:
Hi Wei,
- Please update the copyright year on SmmIpmiBaseLib.c + SmmIpmiBaseLib.inf
- Please remove the duplicate old-style function comment on IpmiSubmitCommand()
- Additional feedback inline.
> -Original Message-
> From: Xu, Wei6
> Sent: Monday, October 30, 2023 8:08 PM
> To:
Reviewed-by: Nate DeSimone
> -Original Message-
> From: Huang, Li-Xia
> Sent: Monday, October 30, 2023 11:24 PM
> To: devel@edk2.groups.io
> Cc: Abner Chang ; Desimone, Nathaniel L
>
> Subject: [PATCH v4 1/1] IpmiFeaturePkg/GenericIpmi: Support Standalone
> MM
>
> Add Standalone Mm
Pushed as 3c2f11d
> -Original Message-
> From: Huang, Li-Xia
> Sent: Monday, October 30, 2023 11:24 PM
> To: devel@edk2.groups.io
> Cc: Abner Chang ; Desimone, Nathaniel L
>
> Subject: [PATCH v4 1/1] IpmiFeaturePkg/GenericIpmi: Support Standalone
> MM
>
> Add Standalone Mm Generic Impi
On 11/2/23 16:59, mikub...@linux.microsoft.com wrote:
> From: Michael Kubacki
>
> - Adds Apache License 2.0 as an acceptable source license per
> discussion in https://edk2.groups.io/g/devel/message/110226
> - Updates the URL for existing licenses to match the current path
> used by
If the user specified a size for the PCI MMIO window via the option:
-fw_cfg name=opt/ovmf/X-PciMmio64Mb,string=32768
then this patch ensures that the mmio window is not resized again.
Essentially, this prevents the change introduced in the following
patch from taking effect:
commit
On 11/2/23 14:06, Pedro Falcato wrote:
> On Thu, Nov 2, 2023 at 11:28 AM Laszlo Ersek
> wrote:
>>
>> On 11/1/23 02:12, Mike Maslenkin wrote:
[...]
>>> Just curious why this patch was broken by google groups.
>>>
>>> Some patches to edk2 and edk2-redfish-client have unintended line
>>> breaks
On 11/3/23 01:03, Joe L wrote:
> From: joelopez333
>
> REF:https://edk2.groups.io/g/devel/topic/102310377#110456
>
> - Add a read after the final PCI Configuration space write
> in RootBridgeIoPciAccess.
>
> - When configuration space is strongly ordered, this ensures
> that program
On 11/3/23 08:32, Chao Li wrote:
> Hi Laszlo,
>
> Sorry, the reason of some mail is not under cover letter is found, I
> will fix it at the V2.
>
> I don't think the code is **duplicated** since most code is architecture
> related, and maybe some code is referenced from others ARCH. As the
>
Hi Bibo,
Yes, you are right, MpInitLib is most used on the physical machines, but
in LoongArch, this library is a public library, so it is the minimum
requirement that it can worke on physical machines and virtual machines.
This library has been tested on the actual and virtual machines to
On 2023/11/3 下午4:09, Chao Li wrote:
Hi Bibo,
Yes, you are right, MpInitLib is most used on the physical machines, but
in LoongArch, this library is a public library, so it is the minimum
requirement that it can worke on physical machines and virtual machines.
This library has been tested
Hi Wei,
Could you please split the patch to into separate patches?
Different patch for different issue may looks clearer.
Thanks,
Dun
-Original Message-
From: Sheng, W
Sent: Friday, November 3, 2023 1:35 PM
To: devel@edk2.groups.io
Cc: Dong, Eric ; Ni, Ray ; Laszlo Ersek
; Wu, Jiaxin
Hi Ray,
Thanks for review.
I think the MpInitLib is necessary, because this library will serve PEI
and DEX phases. In LoongArch, the MP initialization function will be
called first in the PEI phase. It will wake up all of AP, collect
accurate online cores, and all APs will fill in their
On 11/3/23 02:03, Chao Li wrote:
> This patch set will enable LoongArch virtual machine in edk2, the new
> LoongArch virtual machine is located in OvmfPkg/LoongArchVirt/, it is a
> generic platform that dose not require any actual hardware.
>
> Patch1-Patch14: Submit the common library and driver
Hi Laszlo,
Sorry, the reason of some mail is not under cover letter is found, I
will fix it at the V2.
I don't think the code is **duplicated** since most code is architecture
related, and maybe some code is referenced from others ARCH. As the
cover letter saied, most code is distributed
On 2023/11/3 下午3:08, Chao Li wrote:
Hi Ray,
Thanks for review.
I think the MpInitLib is necessary, because this library will serve PEI
and DEX phases. In LoongArch, the MP initialization function will be
called first in the PEI phase. It will wake up all of AP, collect
accurate online
On 11/2/23 21:03, Michael Kubacki wrote:
> From: Michael Kubacki
>
> The code in this directory is licensed under Apache License, Version
> 2.0. Therefore, the directory is listed under paths with licenses
> other than BSD-2-Clause Plus Patent. The directory link points to the
> complete Apache
On 11/3/23 06:15, Vivek Kasireddy wrote:
> If the user specified a size for the PCI MMIO window via the option:
> -fw_cfg name=opt/ovmf/X-PciMmio64Mb,string=32768
> then this patch ensures that the mmio window is not resized again.
>
> Essentially, this prevents the change introduced in the
On 11/3/23 13:14, Wu, Jiaxin wrote:
> Shadow stack will stop update after CET disable (DisableCet in
> DisableReadOnlyPageWriteProtect), but normal smi stack will be
> continue updated with the function return and enter
> (DisableReadOnlyPageWriteProtect & EnableReadOnlyPageWriteProtect),
> thus
On 11/3/23 13:14, Wu, Jiaxin wrote:
> Shadow stack will stop update after CET disable (DisableCet in
> DisableReadOnlyPageWriteProtect), but normal smi stack will be
> continue updated with the function return and enter
> (DisableReadOnlyPageWriteProtect & EnableReadOnlyPageWriteProtect),
> thus
On 11/3/23 15:16, Michael Kubacki wrote:
> On 11/3/2023 9:06 AM, Laszlo Ersek wrote:
>> On 11/2/23 21:03, Michael Kubacki wrote:
>>> From: Michael Kubacki
>>>
>>> The code in this directory is licensed under Apache License, Version
>>> 2.0. Therefore, the directory is listed under paths with
On 11/3/23 06:35, Sheng Wei wrote:
> Clear CR4.CET bit before restoring MSR IA32_S_CET.
> Backup/restore MSR IA32_U_CET in SMI.
> Use current CR4 value when changing CR4.CET.
(1) Why?
(It's fine if you can provide a reference from the Intel SDM, but then
please do provide it.)
No problem has
On 11/3/23 15:10, Wu, Jiaxin wrote:
> Hi Laszlo,
>
> Thanks the feedback.
>
>>
>> Is this somehow related to
>>
>> [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Clear CR4.CET before
>> restoring MSR IA32_S_CET
>>
>> at
>>
>> https://edk2.groups.io/g/devel/message/110605
>>
>> ?
>>
>> I'm
On 11/3/2023 9:06 AM, Laszlo Ersek wrote:
On 11/2/23 21:03, Michael Kubacki wrote:
From: Michael Kubacki
The code in this directory is licensed under Apache License, Version
2.0. Therefore, the directory is listed under paths with licenses
other than BSD-2-Clause Plus Patent. The directory
I just noticed the Bitbucket mirror that's listed in Maintainers.txt
hasn't had any new commits since March 2022.
EDK II
--
W: http://www.tianocore.org/edk2/
L: https://edk2.groups.io/g/devel/
T: git - https://github.com/tianocore/edk2.git
T: git (mirror) -
There is the SmmCpuSyncLib Library class define the SMM CPU sync
flow, which is aligned with existing SMM CPU driver sync behavior.
This patch is to consume SmmCpuSyncLib instance directly.
With this change, SMM CPU Sync flow/logic can be customized
with different implementation no matter for any
After review, there are unnecessary steps for BSP and AP sync for SMM
exit. This patch is to reduce one round BSP and AP sync so as to improve
SMI performance:
BSP: WaitForAllAPs <-- AP: ReleaseBsp
BSP: ReleaseAllAPs --> AP: WaitForBsp
Change-Id: Ic33f42f3daa7ff1847e524d0c3d9cd4fcdefa61b
Cc: Eric
Intel is planning to provide different SMM CPU Sync implementation
along with some specific registers to improve the SMI performance,
hence need SmmCpuSyncLib Library for Intel.
This patch is to:
1.Adds SmmCpuSyncLib Library class in UefiCpuPkg.dec.
2.Adds SmmCpuSyncLib.h function declaration
The series patches are to refine SMM CPU Sync flow. After the refinement,
it's easy to abstract SmmCpuSyncLib for any user to provide different SMM
CPU Sync implementation.
Cc: Eric Dong
Cc: Ray Ni
Cc: Zeng Star
Cc: Gerd Hoffmann
Cc: Rahul Kumar
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan
This patch is to define 3 new functions (WaitForBsp & ReleaseBsp &
ReleaseOneAp) used for the semaphore sync between BSP & AP. With the
change, BSP and AP Sync flow will be easy understand as below:
BSP: ReleaseAllAPs or ReleaseOneAp --> AP: WaitForBsp
BSP: WaitForAllAPs <-- AP:
Implements SmmCpuSyncLib Library class. The instance follows the
existing SMM CPU driver (PiSmmCpuDxeSmm) sync implementation:
1.Abstract Counter and Run semaphores into SmmCpuSyncCtx.
2.Abstract CPU arrival count operation to
SmmCpuSyncGetArrivedCpuCount(), SmmCpuSyncCheckInCpu(),
The SmmCpuSyncLib instance is included in UefiCpuLibs.dsc.inc.
This patch is to specify SmmCpuSyncLib instance in OvmfPkg by
using "!include UefiCpuPkg/UefiCpuLibs.dsc.inc".
Change-Id: I2ab1737425e26a7bfc4f564b3b7f15ca5c2268fb
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Eric Dong
The SmmCpuSyncLib instance is included in UefiCpuLibs.dsc.inc.
This patch is to specify SmmCpuSyncLib instance in UefiPayloadPkg
by using "!include UefiCpuPkg/UefiCpuLibs.dsc.inc".
Change-Id: Ib303a9cdf260ac1ffc146e5f2e68834dec00ff25
Cc: Guo Dong
Cc: Sean Rhodes
Cc: James Lu
Cc: Gua Guo
Cc:
Shadow stack will stop update after CET disable (DisableCet in
DisableReadOnlyPageWriteProtect), but normal smi stack will be
continue updated with the function return and enter
(DisableReadOnlyPageWriteProtect & EnableReadOnlyPageWriteProtect),
thus leading stack mismatch after CET re-enabled
Hi Laszlo,
Thanks the feedback.
>
> Is this somehow related to
>
> [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Clear CR4.CET before
> restoring MSR IA32_S_CET
>
> at
>
> https://edk2.groups.io/g/devel/message/110605
>
> ?
>
> I'm not familiar with control flow integrity, but both
Liming, could you review this please? It's blocking another patch from
being committed.
--
Rebecca
On 11/1/2023 6:20 PM, Rebecca Cran wrote:
Allow .rtf files created by applications such as Notepad to be committed
as-is without further manual editing by skipping the requirements for
CRLF, no
On 11/3/2023 9:00 AM, Laszlo Ersek wrote:
This repo link originally goes back to commit 4202afa45dea ("EDK II: Add
Maintainers.txt file", 2014-10-14). Therefore I *guess* the mirror was
set up by Jordan.
Can we ask (or query) bitbucket.org how many "clone" commands it has
serviced?
My gut
On 11/3/2023 10:46 AM, Laszlo Ersek wrote:
On 11/3/23 15:16, Michael Kubacki wrote:
On 11/3/2023 9:06 AM, Laszlo Ersek wrote:
On 11/2/23 21:03, Michael Kubacki wrote:
From: Michael Kubacki
The code in this directory is licensed under Apache License, Version
2.0. Therefore, the directory is
On 11/3/23 14:15, Laszlo Ersek wrote:
> On 11/3/23 06:15, Vivek Kasireddy wrote:
>> If the user specified a size for the PCI MMIO window via the option:
>> -fw_cfg name=opt/ovmf/X-PciMmio64Mb,string=32768
>> then this patch ensures that the mmio window is not resized again.
>>
>> Essentially, this
On 11/3/23 15:46, Laszlo Ersek wrote:
> Given that that is not the case, just apply my R-b. :)
> I don't object to any of the v4 patches getting merged as posted.
To clarify:
- for patches 1 through 7:
Acked-by: Laszlo Ersek
- for patch 8:
Reviewed-by: Laszlo Ersek
Thanks for your
On 11/3/23 15:49, Rebecca Cran wrote:
> I just noticed the Bitbucket mirror that's listed in Maintainers.txt
> hasn't had any new commits since March 2022.
>
>
> EDK II
> --
> W: http://www.tianocore.org/edk2/
> L: https://edk2.groups.io/g/devel/
> T: git -
On Wed, Nov 1, 2023 at 11:17 PM Igor Kulchytskyy wrote:
>
> Supported function of the driver changed to wait for all newtwork
> interface to be installed.
> Filer out the network interfaces which are not supported by
> Redfish Host Interface.
>
> Cc: Abner Chang
> Cc: Nickle Wang
> Cc: Mike
Add an instance of ImagePropertiesRecordLib which will be used by the
DXE Core.
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Signed-off-by: Taylor Beebe
Reviewed-by: Michael D Kinney
Acked-by: Jiewen Yao
---
OvmfPkg/AmdSev/AmdSevX64.dsc| 1 +
This patch updates MemoryAttributesTable.c to reduce reliance on global
variables and allow some logic to move to a library.
Cc: Jian J Wang
Cc: Liming Gao
Cc: Dandan Bi
Signed-off-by: Taylor Beebe
Reviewed-by: Liming Gao
---
MdeModulePkg/Core/Dxe/Misc/MemoryAttributesTable.c | 102
v4:
- Expose additional functions in the Library API
- Add NULL checks to library functions and return a
status where applicable.
v3:
- Refactor patch series so the transition of logic from the DXE
MAT logic to the new library is more clear.
- Update function headers to improve clarity and
Create a host-based unit test for the ImagePropertiesRecordLib
SplitTable() logic. This test has 4 cases which tests different
potential image and memory map layouts. 3/4 of these tests fail
with the logic in its current state to provide proof of the bugs
in the current MAT logic.
Cc: Jian J Wang
Fix the bugs in the MAT logic before switching the
UEFI and SMM MAT logic to use the new library.
Cc: Jian J Wang
Cc: Liming Gao
Cc: Dandan Bi
Signed-off-by: Taylor Beebe
Reviewed-by: Liming Gao
---
MdeModulePkg/Core/Dxe/Misc/MemoryAttributesTable.c | 2
+-
Move some DXE MAT logic to ImagePropertiesRecordLib to consolidate
code and enable unit testability.
Cc: Jian J Wang
Cc: Liming Gao
Cc: Dandan Bi
Signed-off-by: Taylor Beebe
Reviewed-by: Liming Gao
---
MdeModulePkg/Core/Dxe/Misc/MemoryAttributesTable.c |
774
Update function headers to clarify the contract of each function and
improve readability. Add NULL checks to all functions that take a
pointer as an argument. Add return status to functions that
may need to return early due to invalid input.
Cc: Jian J Wang
Cc: Liming Gao
Cc: Dandan Bi
The function EnforceMemoryMapAttribute() in the SMM MAT logic will
ensure that the CODE and DATA memory types have the desired attributes.
The consumer of the SMM MAT should only override the Attributes field
in the MAT if it is nonzero. This also allows the UEFI and SMM MAT
logic to use
Now that the bugs are fixed in the MAT logic, we can remove the
duplicate logic from PiSmmCore/MemoryAttributesTable.c and use
ImagePropertiesRecordLib instead.
Cc: Jian J Wang
Cc: Liming Gao
Cc: Dandan Bi
Cc: Jiaxin Wu
Cc: Ray Ni
Signed-off-by: Taylor Beebe
Reviewed-by: Liming Gao
---
Add an instance of ImagePropertiesRecordLib which will be used by the
DXE Core.
Cc: Guo Dong
Cc: Sean Rhodes
Cc: James Lu
Cc: Gua Guo
Signed-off-by: Taylor Beebe
Reviewed-by: Michael D Kinney
Reviewed-by: Gua Guo
---
UefiPayloadPkg/UefiPayloadPkg.dsc | 1 +
1 file changed, 1 insertion(+)
Add logic to create and delete image properties records. Where
applicable, redirect existing code to use the new library.
Cc: Jian J Wang
Cc: Liming Gao
Cc: Dandan Bi
Cc: Jiaxin Wu
Cc: Ray Ni
Signed-off-by: Taylor Beebe
Reviewed-by: Liming Gao
---
Update DumpImageRecord() to be DumpImageRecords(), and improve
the debug output. The function will output at DEBUG_INFO instead,
and the function will be run in DXE and SMM
MAT logic when the MAT is installed at EndOfDxe on DEBUG builds.
Cc: Jian J Wang
Cc: Liming Gao
Cc: Dandan Bi
Cc: Jiaxin
Create a library for manipulating image properties records. The
library is currently blank and will be filled in a future patch
to help with reviewer readability.
Cc: Jian J Wang
Cc: Liming Gao
Cc: Dandan Bi
Signed-off-by: Taylor Beebe
Reviewed-by: Liming Gao
---
Add an instance of ImagePropertiesRecordLib which will be used by the
DXE Core.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Gerd Hoffmann
Signed-off-by: Taylor Beebe
Reviewed-by: Michael D Kinney
---
ArmVirtPkg/ArmVirt.dsc.inc | 1 +
1 file changed, 1 insertion(+)
diff --git
Add an instance of ImagePropertiesRecordLib which will be used by the
DXE Core.
Cc: Andrew Fish
Cc: Ray Ni
Signed-off-by: Taylor Beebe
Reviewed-by: Michael D Kinney
---
EmulatorPkg/EmulatorPkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/EmulatorPkg/EmulatorPkg.dsc
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Laszlo
> Ersek
> Sent: Friday, November 3, 2023 12:19 AM
> To: devel@edk2.groups.io; jlo...@gmail.com
> Cc: Leif Lindholm ; Ard Biesheuvel
> ; Sami Mujawar ;
> Wang, Jian J ; Gao, Liming
> ; Wu, Hao A ; Ni, Ray
> ; Pedro
Hi Mike,
You are absolutely right.
I moved that NetworkInterfaceGetSubnetInfo function up, not copied it. But
somehow it was copied.
My mistake.
I will fix it and resubmit.
Thank you,
Igor
-Original Message-
From: Mike Maslenkin
Sent: Friday, November 3, 2023 11:54 AM
To: Igor
On 03/11/2023 16:03, Kinney, Michael D wrote:
PCI Configuration read/write operations are non-posted, so the PCI
Configuration write operation should complete without the need for
an additional transaction. If you are seeing an issue, then it may
be in the implementation of the
Commit 0df6c8c157af9 ("BaseTools/tools_def AARCH64:
avoid SIMD registers in XIP code")
adds -mgeneral-regs-only to GCC_AARCH64_CC_XIPFLAGS,
in order to avoid a bug present in certain versions of GCC.
This was never a problem for clang.
That's given the history of what the problem is.
Then we can
Good catch!
Reviewed-by: Nate DeSimone
-Original Message-
From: devel@edk2.groups.io On Behalf Of Ni, Ray
Sent: Tuesday, October 31, 2023 1:22 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel
Subject: [edk2-devel] [PATCH] IntelFsp2Pkg/SwitchStack: Reserve 32B when
calling C function in
Hi Laszlo,
Thanks comments.
>
> I have two comments:
>
>
> (1) both the pre-patch code and the post-patch code have several
> instances of the following pattern:
>
> Boolean = (Expression != 0) ? TRUE : FALSE;
>
> This is an anti-pattern. It should only be:
>
> Boolean = Expression !=
Shadow stack will stop update after CET disable (DisableCet in
DisableReadOnlyPageWriteProtect), but normal smi stack will be
continue updated with the function return and enter
(DisableReadOnlyPageWriteProtect & EnableReadOnlyPageWriteProtect),
thus leading stack mismatch after CET re-enabled
The series has been pushed as 0cedeab~..6d60278
-Original Message-
From: devel@edk2.groups.io On Behalf Of Zhen Gong
Sent: Sunday, October 29, 2023 1:28 PM
To: devel@edk2.groups.io
Cc: Gong, Zhen
Subject: [edk2-devel] [PATCH edk2-platforms v2 0/4] IpmiFeaturePkg: Add server
management
66 matches
Mail list logo
