On 04/03/2020 21:22, Nikita Leshenko wrote:
Support dynamic insertion and removal of the protocol
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2390
Signed-off-by: Nikita Leshenko
Reviewed-by: Laszlo Ersek
---
OvmfPkg/MptScsiDxe/MptScsi.c | 179 +-
O
: Liran Alon
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#55507): https://edk2.groups.io/g/devel/message/55507
Mute This Topic: https://groups.io/mt/71733505/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2
On 04/03/2020 21:22, Nikita Leshenko wrote:
In order to probe and connect to the MptScsi device we need this
protocol. Currently it does nothing.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2390
Signed-off-by: Nikita Leshenko
Reviewed-by: Laszlo Ersek
---
Reviewed-by: Liran Alon
On 04/03/2020 21:22, Nikita Leshenko wrote:
Reset and send the IO controller initialization request. The reply is
read back to complete the doorbell function but it isn't useful to us
because it doesn't contain relevant data or status codes.
See "LSI53C1030 PCI-X to Dual Channel Ultra320 SCSI
o ZeroMem() if you only use the first byte of Target?
Seems redundant.
In addition, I suggest squashing this patch with the previous one as
GetTargetLun() and BuildDevicePath() kinda complement each other.
Reviewed-by: Liran Alon
+ //
+ // This device support 256 targets only, so it'
On 04/03/2020 21:22, Nikita Leshenko wrote:
In preparation for implementing LSI Fusion MPT SCSI devices, create a
basic scaffolding for a driver.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2390
Signed-off-by: Nikita Leshenko
---
Reviewed-by: Liran Alon
---
Reviewed-by: Liran Alon
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#55511): https://edk2.groups.io/g/devel/message/55511
Mute This Topic: https://groups.io/mt/71733494/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe
device.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2390
Signed-off-by: Nikita Leshenko
Reviewed-by: Laszlo Ersek
---
Reviewed-by: Liran Alon
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#55513): https://edk2.groups.io/g
device for each
one that responds.
Support for multiple LUNs will be implemented in another series.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2390
Signed-off-by: Nikita Leshenko
---
Reviewed-by: Liran Alon
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to
0 || Lun > 0) {
+return EFI_NOT_FOUND;
+ }
+
+ ScsiDevicePath = AllocateZeroPool (sizeof (*ScsiDevicePath));
Nit: It should also be sufficient to use AllocatePool() as below
overrides all fields of SCSI_DEVICE_PATH.
Reviewed-by: Liran Alon
+ if (ScsiDevicePath == NULL) {
On 04/03/2020 21:22, Nikita Leshenko wrote:
This will give us an exclusive access to the PciIo of this device
after it was started and until is will be stopped.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2390
Signed-off-by: Nikita Leshenko
---
Reviewed-by: Liran Alon
On 04/03/2020 21:22, Nikita Leshenko wrote:
Machines should be able to boot after this commit. Tested with different
Linux distributions (Ubuntu, CentOS) and different Windows
versions (Windows 7, Windows 10, Server 2016).
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2390
Signed-off-by:
On 04/03/2020 21:22, Nikita Leshenko wrote:
Support for multiple targets will be implemented in a later commit in
this series.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2390
Signed-off-by: Nikita Leshenko
Reviewed-by: Laszlo Ersek
---
OvmfPkg/MptScsiDxe/MptScsi.c | 38 ++
Hi Lazlo,
On 06/03/2020 22:14, Laszlo Ersek wrote:
Hi Nikita,
On 03/04/20 20:22, Nikita Leshenko wrote:
This series adds driver support for:
- LSI53C1030
- SAS1068
- SAS1068E
These controllers are widely supported by QEMU, VirtualBox and VMWare.
This work is part of the more general agenda
In preparation for support booting from PvScsi devices, create a
basic scaffolding for a driver.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
Reviewed-by: Nikita Leshenko
Signed-off-by: Liran Alon
---
OvmfPkg/OvmfPkgIa32.dsc | 8
OvmfPkg/OvmfPkgIa32.fdf | 3
Enable IOSpace & Bus-Mastering PCI attributes when device is started.
Note that original PCI attributes is restored when device is stopped.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
Reviewed-by: Nikita Leshenko
Signed-off-by: Liran Alon
---
OvmfPkg/PvScsiDxe/PvScsi.c
Implement EXT_SCSI_PASS_THRU.PassThru().
Machines should be able to boot after this commit.
Tested with Ubuntu 16.04 guest.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
Reviewed-by: Nikita Leshenko
Signed-off-by: Liran Alon
---
OvmfPkg/OvmfPkg.dec | 6 +
OvmfPkg
e future when PVSCSI will have bigger values
for MaxTarget and MaxLun.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
Reviewed-by: Nikita Leshenko
Signed-off-by: Liran Alon
---
OvmfPkg/OvmfPkg.dec | 9 +++
OvmfPkg/PvScsiDxe/PvScsi.c
Reviewed-by: Nikita Leshenko
Signed-off-by: Liran Alon
---
OvmfPkg/Include/IndustryStandard/PvScsi.h | 21 ++
OvmfPkg/PvScsiDxe/PvScsi.c| 49 ++-
OvmfPkg/PvScsiDxe/PvScsi.inf | 5 +++
3 files changed, 74 insertions(+), 1 deletion(-)
create
Support dynamic insertion and removal of the protocol.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
Reviewed-by: Nikita Leshenko
Signed-off-by: Liran Alon
---
OvmfPkg/PvScsiDxe/PvScsi.c | 209 ++-
OvmfPkg/PvScsiDxe/PvScsi.h | 29 +
OvmfPkg
-off-by: Liran Alon
---
OvmfPkg/PvScsiDxe/PvScsi.c | 42 +-
OvmfPkg/PvScsiDxe/PvScsi.h | 1 +
2 files changed, 42 insertions(+), 1 deletion(-)
diff --git a/OvmfPkg/PvScsiDxe/PvScsi.c b/OvmfPkg/PvScsiDxe/PvScsi.c
index e7d0a23db6ab..33167c177b42 100644
--- a
Hi,
This series adds driver support for VMware PVSCSI controller.
This controller is supported by VMware and QEMU. This work is part of
the more general agenda of enhancing OVMF boot device support to have
feature parity with SeaBIOS (Which supports booting from VMware PVSCSI).
The BugZilla tick
In order to probe and connect to the PvScsi device we need this
protocol. Currently it does nothing.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
Reviewed-by: Nikita Leshenko
Signed-off-by: Liran Alon
---
OvmfPkg/PvScsiDxe/PvScsi.c | 68
This will give us an exclusive access to the PciIo of this device
after it was started and until is will be stopped.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
Reviewed-by: Nikita Leshenko
Signed-off-by: Liran Alon
---
OvmfPkg/PvScsiDxe/PvScsi.c | 29
the following commits.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
Reviewed-by: Nikita Leshenko
Signed-off-by: Liran Alon
---
OvmfPkg/PvScsiDxe/PvScsi.c | 24
OvmfPkg/PvScsiDxe/PvScsi.h | 10 ++
2 files changed, 34 insertions(+)
diff --git a/OvmfPkg/PvScsi
Implement EXT_SCSI_PASS_THRU.BuildDevicePath() and
EXT_SCSI_PASS_THRU.GetTargetLun().
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
Reviewed-by: Nikita Leshenko
Signed-off-by: Liran Alon
---
OvmfPkg/PvScsiDxe/PvScsi.c | 60 --
1 file changed, 58
The following commits will complete the implementation of
device initialization.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
Reviewed-by: Nikita Leshenko
Signed-off-by: Liran Alon
---
OvmfPkg/PvScsiDxe/PvScsi.c | 77 ++
1 file changed, 77
sure to map these rings to device by using
PciIo->Map().
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
Reviewed-by: Nikita Leshenko
Signed-off-by: Liran Alon
---
OvmfPkg/PvScsiDxe/PvScsi.c | 235 +
OvmfPkg/PvScsiDxe/PvScsi.h | 17 +++
2 fi
Enable PCI dual-address cycle attribute to signal device supports
64-bit DMA addresses.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
Reviewed-by: Nikita Leshenko
Signed-off-by: Liran Alon
---
OvmfPkg/PvScsiDxe/PvScsi.c | 21 +
1 file changed, 21 insertions
These definitions will be used by the following commits to complete the
implementation of PVSCSI device driver.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
Reviewed-by: Nikita Leshenko
Signed-off-by: Liran Alon
---
OvmfPkg/Include/IndustryStandard/PvScsi.h | 162
Install Component Name protocols to have a nice display name for the
driver in places such as UEFI shell.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
Reviewed-by: Nikita Leshenko
Signed-off-by: Liran Alon
---
OvmfPkg/PvScsiDxe/PvScsi.c | 63
This commit doesn't change semantics.
It is done as a preparation for future commits which will modify
PCI attributes.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
Reviewed-by: Nikita Leshenko
Signed-off-by: Liran Alon
---
OvmfPkg/PvScsiDxe/PvScsi.c
On 24/03/2020 17:14, Laszlo Ersek wrote:
On 03/16/20 16:01, Liran Alon wrote:
I'm going to stop reviewing this iteration now; please rework the rest
of the series for v2 with this resource management pattern.
Thanks!
Laszlo
Thanks for the very detailed review!
I have read all your com
On 24/03/2020 18:00, Laszlo Ersek wrote:
On 03/16/20 16:01, Liran Alon wrote:
+STATIC
+EFI_STATUS
+PvScsiWriteCmdDesc (
+ IN CONST PVSCSI_DEV *Dev,
+ IN UINT32 Cmd,
+ IN VOID *Desc,
+ IN UINTN Length
+ )
+{
+ EFI_STATUS Status;
+ UINTN
On 24/03/2020 18:43, Laszlo Ersek wrote:
On 03/16/20 16:01, Liran Alon wrote:
+STATIC
+BOOLEAN
+PvScsiIsReqRingFull (
+ IN CONST PVSCSI_DEV *Dev
+ )
+{
+ PVSCSI_RINGS_STATE *RingsState;
+ UINT64 ReqNumEntries;
+
+ RingsState = Dev->RingDesc.RingState;
+ ReqNumEntries
On 25/03/2020 3:48, Laszlo Ersek wrote:
On 03/24/20 16:35, Liran Alon wrote:
On 24/03/2020 17:14, Laszlo Ersek wrote:
On 03/16/20 16:01, Liran Alon wrote:
I'm going to stop reviewing this iteration now; please rework the rest
of the series for v2 with this resource management pa
In preparation for support booting from PvScsi devices, create a
basic scaffolding for a driver.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
Signed-off-by: Liran Alon
---
OvmfPkg/OvmfPkgIa32.dsc | 8
OvmfPkg/OvmfPkgIa32.fdf | 3 +++
OvmfPkg/OvmfPkgIa32X64
sure to map these rings to device by using
PciIo->Map().
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
Signed-off-by: Liran Alon
---
OvmfPkg/PvScsiDxe/PvScsi.c | 269 +
OvmfPkg/PvScsiDxe/PvScsi.h | 17 +++
2 files changed, 286 insertions(+)
d
This commit doesn't change semantics.
It is done as a preparation for future commits which will modify
PCI attributes.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
Signed-off-by: Liran Alon
---
OvmfPkg/PvScsiDxe/PvScsi.c | 54 +-
OvmfPkg/PvSc
This will give us an exclusive access to the PciIo of this device
after it was started and until it will be stopped.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
Reviewed-by: Laszlo Ersek
Signed-off-by: Liran Alon
---
OvmfPkg/PvScsiDxe/PvScsi.c | 29
The following commits will complete the implementation of
device initialization.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
Signed-off-by: Liran Alon
---
OvmfPkg/PvScsiDxe/PvScsi.c | 91 ++
1 file changed, 91 insertions(+)
diff --git a/OvmfPkg
Reviewed-by: Laszlo Ersek
Signed-off-by: Liran Alon
---
OvmfPkg/Include/IndustryStandard/PvScsi.h | 21 ++
OvmfPkg/PvScsiDxe/PvScsi.c| 49 ++-
OvmfPkg/PvScsiDxe/PvScsiDxe.inf | 5 +++
3 files changed, 74 insertions(+), 1 deletion(-)
create
In order to probe and connect to the PvScsi device we need this
protocol. Currently it does nothing.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
Reviewed-by: Laszlo Ersek
Signed-off-by: Liran Alon
---
OvmfPkg/PvScsiDxe/PvScsi.c | 66 -
OvmfPkg
Enable MMIO-Space & Bus-Mastering PCI attributes when device is started.
Note that original PCI attributes are restored when device is stopped.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
Signed-off-by: Liran Alon
---
OvmfPkg/PvScsiDxe/PvScsi.c | 12 +++-
1 file changed
Implement EXT_SCSI_PASS_THRU.BuildDevicePath() and
EXT_SCSI_PASS_THRU.GetTargetLun().
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
Reviewed-by: Laszlo Ersek
Signed-off-by: Liran Alon
---
OvmfPkg/PvScsiDxe/PvScsi.c | 61 --
1 file changed, 59
Support dynamic insertion and removal of the protocol.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
Reviewed-by: Laszlo Ersek
Signed-off-by: Liran Alon
---
OvmfPkg/PvScsiDxe/PvScsi.c | 209 +++-
OvmfPkg/PvScsiDxe/PvScsi.h | 29 +
OvmfPkg
These definitions will be used by the following commits to complete the
implementation of PVSCSI device driver.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
Signed-off-by: Liran Alon
---
OvmfPkg/Include/IndustryStandard/PvScsi.h | 165 ++
1 file changed, 165
Install Component Name protocols to have a nice display name for the
driver in places such as UEFI shell.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
Reviewed-by: Laszlo Ersek
Signed-off-by: Liran Alon
---
OvmfPkg/PvScsiDxe/PvScsi.c | 59 --
1
Implement EXT_SCSI_PASS_THRU.PassThru().
Machines should be able to boot after this commit.
Tested with Ubuntu 16.04 guest.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
Signed-off-by: Liran Alon
---
OvmfPkg/OvmfPkg.dec | 6 +
OvmfPkg/PvScsiDxe/PvScsi.c | 442
e future when PVSCSI will have bigger values
for MaxTarget and MaxLun.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
Reviewed-by: Laszlo Ersek
Signed-off-by: Liran Alon
---
OvmfPkg/OvmfPkg.dec | 9 +++
OvmfPkg/PvScsiDxe/PvScsi.c
the following commits.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
Signed-off-by: Liran Alon
---
OvmfPkg/PvScsiDxe/PvScsi.c | 27 +++
OvmfPkg/PvScsiDxe/PvScsi.h | 10 ++
2 files changed, 37 insertions(+)
diff --git a/OvmfPkg/PvScsiDxe/PvScsi.c b/Ovmf
-by: Liran Alon
---
OvmfPkg/PvScsiDxe/PvScsi.c | 43 +-
OvmfPkg/PvScsiDxe/PvScsi.h | 1 +
2 files changed, 43 insertions(+), 1 deletion(-)
diff --git a/OvmfPkg/PvScsiDxe/PvScsi.c b/OvmfPkg/PvScsiDxe/PvScsi.c
index de4122e39a81..42a18494efb7 100644
--- a
Hi,
This series adds driver support for VMware PVSCSI controller.
This controller is supported by VMware and QEMU. This work is part of
the more general agenda of enhancing OVMF boot device support to have
feature parity with SeaBIOS (Which supports booting from VMware PVSCSI).
I pushed a copy o
Enable PCI dual-address cycle attribute to signal device
supports 64-bit DMA addresses.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
Signed-off-by: Liran Alon
---
OvmfPkg/PvScsiDxe/PvScsi.c | 23 +++
1 file changed, 23 insertions(+)
diff --git a/OvmfPkg
On 25/03/2020 18:31, Laszlo Ersek wrote:
On 03/25/20 02:11, Liran Alon wrote:
On 24/03/2020 18:00, Laszlo Ersek wrote:
On 03/16/20 16:01, Liran Alon wrote:
+STATIC
+EFI_STATUS
+PvScsiWriteCmdDesc (
+ IN CONST PVSCSI_DEV *Dev,
+ IN UINT32 Cmd,
+ IN VOID *Desc
On 25/03/2020 18:40, Liran Alon wrote:
On 25/03/2020 18:31, Laszlo Ersek wrote:
On 03/25/20 02:11, Liran Alon wrote:
To avoid further style comments, what is the coding convention in EDK2
to align the "PVSCSI_CMD_DESC_SETUP_RINGS Cmd;" var properly?
The best I can recommend o
On 27/03/2020 0:17, Laszlo Ersek wrote:
On 03/25/20 17:10, Liran Alon wrote:
PvScsiRestorePciAttributes (Dev);
diff --git a/OvmfPkg/PvScsiDxe/PvScsi.h b/OvmfPkg/PvScsiDxe/PvScsi.h
index 6d23b6e1eccf..7f91d70fec79 100644
--- a/OvmfPkg/PvScsiDxe/PvScsi.h
+++ b/OvmfPkg/PvScsiDxe/PvScsi.h
On 27/03/2020 14:26, Laszlo Ersek wrote:
On 03/25/20 17:10, Liran Alon wrote:
+/**
+ Returns if PVSCSI request ring is full
+**/
+STATIC
+BOOLEAN
+PvScsiIsReqRingFull (
+ IN CONST PVSCSI_DEV *Dev
+ )
+{
+ PVSCSI_RINGS_STATE *RingsState;
+ UINT32 ReqNumEntries
On 27/03/2020 16:04, Liran Alon wrote:
On 27/03/2020 14:26, Laszlo Ersek wrote:
On 03/25/20 17:10, Liran Alon wrote:
+
+ //
+ // Report target status
+ //
+ Packet->TargetStatus = Response->ScsiStatus;
+
+ //
+ // Host adapter status and function return value depend on
+ //
On 27/03/2020 16:35, Laszlo Ersek wrote:
On 03/27/20 01:05, Liran Alon wrote:
On 27/03/2020 0:17, Laszlo Ersek wrote:
On 03/25/20 17:10, Liran Alon wrote:
PvScsiRestorePciAttributes (Dev);
diff --git a/OvmfPkg/PvScsiDxe/PvScsi.h b/OvmfPkg/PvScsiDxe/PvScsi.h
index 6d23b6e1eccf
On 28/03/2020 0:05, Laszlo Ersek wrote:
On 03/27/20 14:04, Liran Alon wrote:
On 27/03/2020 14:26, Laszlo Ersek wrote:
On 03/25/20 17:10, Liran Alon wrote:
+ Packet->HostAdapterStatus =
+ EFI_EXT_SCSI_STATUS_HOST_ADAPTER_DATA_OVERRUN_UNDERRUN;
+ ret
On 28/03/2020 1:04, Liran Alon wrote:
On 28/03/2020 0:05, Laszlo Ersek wrote:
On 03/27/20 14:04, Liran Alon wrote:
On 27/03/2020 14:26, Laszlo Ersek wrote:
On 03/25/20 17:10, Liran Alon wrote:
+ Packet->HostAdapterStatus =
+ EFI_EXT_SCSI_STATUS_HOST_ADAPTER_DATA_OVERRUN_UNDER
On 28/03/2020 1:17, Liran Alon wrote:
On 28/03/2020 1:04, Liran Alon wrote:
On 28/03/2020 0:05, Laszlo Ersek wrote:
On 03/27/20 14:04, Liran Alon wrote:
On 27/03/2020 14:26, Laszlo Ersek wrote:
On 03/25/20 17:10, Liran Alon wrote:
+ Packet->HostAdapterSta
In preparation for support booting from PvScsi devices, create a
basic scaffolding for a driver.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
Reviewed-by: Laszlo Ersek
Signed-off-by: Liran Alon
---
OvmfPkg/OvmfPkgIa32.dsc | 8
OvmfPkg/OvmfPkgIa32.fdf | 3
Support dynamic insertion and removal of the protocol.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
Reviewed-by: Laszlo Ersek
Signed-off-by: Liran Alon
---
OvmfPkg/PvScsiDxe/PvScsi.c | 209 +++-
OvmfPkg/PvScsiDxe/PvScsi.h | 29 +
OvmfPkg
This will give us an exclusive access to the PciIo of this device
after it was started and until it will be stopped.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
Reviewed-by: Laszlo Ersek
Signed-off-by: Liran Alon
---
OvmfPkg/PvScsiDxe/PvScsi.c | 29
Hi,
This series adds driver support for VMware PVSCSI controller.
This controller is supported by VMware and QEMU. This work is part of
the more general agenda of enhancing OVMF boot device support to have
feature parity with SeaBIOS (Which supports booting from VMware PVSCSI).
I pushed a copy o
In order to probe and connect to the PvScsi device we need this
protocol. Currently it does nothing.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
Reviewed-by: Laszlo Ersek
Signed-off-by: Liran Alon
---
OvmfPkg/PvScsiDxe/PvScsi.c | 66 -
OvmfPkg
Install Component Name protocols to have a nice display name for the
driver in places such as UEFI shell.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
Reviewed-by: Laszlo Ersek
Signed-off-by: Liran Alon
---
OvmfPkg/PvScsiDxe/PvScsi.c | 59 --
1
Reviewed-by: Laszlo Ersek
Signed-off-by: Liran Alon
---
OvmfPkg/Include/IndustryStandard/PvScsi.h | 21 ++
OvmfPkg/PvScsiDxe/PvScsi.c| 49 ++-
OvmfPkg/PvScsiDxe/PvScsiDxe.inf | 5 +++
3 files changed, 74 insertions(+), 1 deletion(-)
create
Enable MMIO-Space & Bus-Mastering PCI attributes when device is started.
Note that original PCI attributes are restored when device is stopped.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
Reviewed-by: Laszlo Ersek
Signed-off-by: Liran Alon
---
OvmfPkg/PvScsiDxe/PvScsi.c
e future when PVSCSI will have bigger values
for MaxTarget and MaxLun.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
Reviewed-by: Laszlo Ersek
Signed-off-by: Liran Alon
---
OvmfPkg/OvmfPkg.dec | 9 +++
OvmfPkg/PvScsiDxe/PvScsi.c
This commit doesn't change semantics.
It is done as a preparation for future commits which will modify
PCI attributes.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
Reviewed-by: Laszlo Ersek
Signed-off-by: Liran Alon
---
OvmfPkg/PvScsiDxe/PvScsi.c
Implement EXT_SCSI_PASS_THRU.BuildDevicePath() and
EXT_SCSI_PASS_THRU.GetTargetLun().
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
Reviewed-by: Laszlo Ersek
Signed-off-by: Liran Alon
---
OvmfPkg/PvScsiDxe/PvScsi.c | 61 --
1 file changed, 59
-by: Liran Alon
---
OvmfPkg/PvScsiDxe/PvScsi.c | 43 +-
OvmfPkg/PvScsiDxe/PvScsi.h | 1 +
2 files changed, 43 insertions(+), 1 deletion(-)
diff --git a/OvmfPkg/PvScsiDxe/PvScsi.c b/OvmfPkg/PvScsiDxe/PvScsi.c
index da3535c75220..d7f0d3c8790c 100644
--- a
Implement EXT_SCSI_PASS_THRU.PassThru().
Machines should be able to boot after this commit.
Tested with Ubuntu 16.04 guest.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
Signed-off-by: Liran Alon
---
OvmfPkg/OvmfPkg.dec | 6 +
OvmfPkg/PvScsiDxe/PvScsi.c | 456
These definitions will be used by the following commits to complete the
implementation of PVSCSI device driver.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
Acked-by: Laszlo Ersek
Signed-off-by: Liran Alon
---
OvmfPkg/Include/IndustryStandard/PvScsi.h | 165
sure to map these rings to device by using
PciIo->Map().
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
Signed-off-by: Liran Alon
---
OvmfPkg/PvScsiDxe/PvScsi.c | 219
OvmfPkg/PvScsiDxe/PvScsi.h | 17 +++
OvmfPkg/PvScsiDxe/PvScsiDxe.inf |
The following commits will complete the implementation of
device initialization.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
Reviewed-by: Laszlo Ersek
Signed-off-by: Liran Alon
---
OvmfPkg/PvScsiDxe/PvScsi.c | 114 +
1 file changed, 114
the following commits.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
Signed-off-by: Liran Alon
---
OvmfPkg/PvScsiDxe/PvScsi.c | 60 ++
OvmfPkg/PvScsiDxe/PvScsi.h | 20 +
2 files changed, 68 insertions(+), 12 deletions(-)
diff --git a/Ovmf
Enable PCI dual-address cycle attribute to signal device
supports 64-bit DMA addresses.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
Reviewed-by: Laszlo Ersek
Signed-off-by: Liran Alon
---
OvmfPkg/PvScsiDxe/PvScsi.c | 23 +++
1 file changed, 23 insertions
On 30/03/2020 18:54, Laszlo Ersek wrote:
On 03/28/20 21:00, Liran Alon wrote:
STATIC
EFI_STATUS
PvScsiInit (
@@ -466,6 +669,14 @@ PvScsiInit (
goto RestorePciAttributes;
}
+ //
+ // Init PVSCSI rings
+ //
+ Status = PvScsiInitRings (Dev);
+ if (EFI_ERROR (Status
driver as-well.
Cc: Nikita Leshenko
Suggested-by: Laszlo Ersek
Signed-off-by: Liran Alon
---
Maintainers.txt | 5 +
1 file changed, 5 insertions(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index 342bb8d0850c..de443ba7ba1f 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -435,6
hat this truncation do not result in loss of data.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2651
Reported-by: Sean Brogan
Signed-off-by: Liran Alon
---
OvmfPkg/PvScsiDxe/PvScsi.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/OvmfPkg/PvScsiDxe/PvScsi.
PvScsiInitRings().
Signed-off-by: Liran Alon
---
OvmfPkg/PvScsiDxe/PvScsi.c | 150 +++--
1 file changed, 76 insertions(+), 74 deletions(-)
diff --git a/OvmfPkg/PvScsiDxe/PvScsi.c b/OvmfPkg/PvScsiDxe/PvScsi.c
index 1ca50390c0e5..5b7fdcbda10b 100644
--- a/OvmfPkg
On 01/04/2020 0:56, Laszlo Ersek wrote:
On 03/31/20 17:53, Sean via Groups.Io wrote:
A couple of thoughts.
1. I would suggest that ASSERT should not be the only protection for an invalid
operation as ASSERT is usually disabled on release builds.
2. We do have a library to make this more expli
On 01/04/2020 1:13, Liran Alon wrote:
On 01/04/2020 0:56, Laszlo Ersek wrote:
On 03/31/20 17:53, Sean via Groups.Io wrote:
A couple of thoughts.
1. I would suggest that ASSERT should not be the only protection for
an invalid operation as ASSERT is usually disabled on release builds.
2. We
On 01/04/2020 1:19, Laszlo Ersek wrote:
Hi Liran,
On 03/31/20 13:47, Liran Alon wrote:
Previous to this change, PvScsiFreeRings() was not undoing all
operations that was done by PvScsiInitRings().
This is because PvScsiInitRings() was both preparing rings (Allocate
memory and map it for
PvScsiInitRings().
Signed-off-by: Liran Alon
---
OvmfPkg/PvScsiDxe/PvScsi.c | 163 +++--
1 file changed, 85 insertions(+), 78 deletions(-)
diff --git a/OvmfPkg/PvScsiDxe/PvScsi.c b/OvmfPkg/PvScsiDxe/PvScsi.c
index 1ca50390c0e5..8c458ecceeb0 100644
--- a/OvmfPkg
On 01/04/2020 13:41, Laszlo Ersek wrote:
On 04/01/20 00:56, Liran Alon wrote:
+ //
+ // Setup rings against device
+ //
+ Status = PvScsiSetupRings (Dev);
+ if (EFI_ERROR (Status)) {
+goto FreeDMACommBuffer;
I'm going to rename this label to "FreeDmaCommBuffer" up
On 15/07/2020 11:20, Gary Lin wrote:
The toke value of PcdMptScsiStallPerPollUsec should be 0x3a since the
previous toke value is 0x39.
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Cc: Liran Alon
Cc: Nikita Leshenko
Signed-off-by: Gary Lin
---
Reviewed-by: Liran Alon
On 29/04/2020 16:39, Laszlo Ersek wrote:
On 04/29/20 15:38, Laszlo Ersek wrote:
On 04/24/20 19:59, Nikita Leshenko wrote:
diff --git a/OvmfPkg/MptScsiDxe/MptScsiDxe.inf
b/OvmfPkg/MptScsiDxe/MptScsiDxe.inf
index 9f7c98829ee1..4862ff9dd497 100644
--- a/OvmfPkg/MptScsiDxe/MptScsiDxe.inf
+++ b/O
92 matches
Mail list logo
