Re: [edk2-devel] [[edk2-platforms]PATCH v4 1/1] Platform: Intel: Add Stratix 10 platform support

2019-05-29 Thread Loh, Tien Hock
Leif, thanks for reviewing, a question inlined. > -Original Message- > From: Leif Lindholm > Sent: Wednesday, May 29, 2019 10:43 PM > To: Loh, Tien Hock > Cc: devel@edk2.groups.io; thlo...@gmail.com; Ard Biesheuvel > ; Kinney, Michael D > > Subject: Re: [[edk

Re: [edk2-devel] [PATCH v2 6/7] EmbeddedPkg: Fix DwEmmc SendCommand polling

2019-05-30 Thread Loh, Tien Hock
> -Original Message- > From: Haojian Zhuang > Sent: Thursday, May 30, 2019 3:06 PM > To: Leif Lindholm > Cc: Loh, Tien Hock ; devel@edk2.groups.io; > thlo...@gmail.com; Ard Biesheuvel > Subject: Re: [PATCH v2 6/7] EmbeddedPkg: Fix DwEmmc SendCommand > polling &

Re: [edk2-devel] [[edk2-platforms]PATCH v4 1/1] Platform: Intel: Add Stratix 10 platform support

2019-05-29 Thread Loh, Tien Hock
> -Original Message- > From: Wu, Hao A > Sent: Thursday, May 30, 2019 9:03 AM > To: devel@edk2.groups.io; Loh, Tien Hock ; > thlo...@gmail.com > Cc: Ard Biesheuvel ; Leif Lindholm > ; Kinney, Michael D > > Subject: RE: [edk2-devel] [[edk2-platforms]PATCH v

[edk2-devel] [PATCH v2 7/7] EmbeddedPkg: Fix DwEmmc read/write size in preparing DMA size

2019-05-27 Thread Loh, Tien Hock
From: "Tien Hock, Loh" Add support for reading data that is less than DWEMMC_BLOCK_SIZE, otherwise it would read bigger data than requested and cause errors Signed-off-by: "Tien Hock, Loh" Cc: Leif Lindholm Cc: Ard Biesheuvel -- v2: - Fix white space issue ---

[edk2-devel] [PATCH v2 5/7] EmbeddedPkg: Clear CTYPE on initialization

2019-05-27 Thread Loh, Tien Hock
From: "Tien Hock, Loh" Clear CTYPE on initialization. This is important if previous bootloader changes the CTYPE can cause the controller to not initialize correctly if CTYPE is not reset to 0 Signed-off-by: "Tien Hock, Loh" Cc: Leif Lindholm Cc: Ard Biesheuvel ---

[edk2-devel] [PATCH v2 1/7] EmbeddedPkg: Add SD command support for DwEmmc

2019-05-27 Thread Loh, Tien Hock
From: "TIen Hock, Loh" Added ACMD6 for SD support. For SD, after CMD55 is sent, the next command should be an application command, which should not expect data Signed-off-by: "Tien Hock, Loh" Cc: Leif Lindholm Cc: Ard Biesheuvel -- v2: - Move IsACmd as a local static variable in function -

[edk2-devel] [PATCH v2 3/7] EmbeddedPkg: Send command when MMC ask for response

2019-05-27 Thread Loh, Tien Hock
From: "Tien Hock, Loh" Send command when MMC ask for response in DwEmmcReceiveResponse, and command is a pending command (eg. DMA needs to be set up first) Signed-off-by: "Tien Hock, Loh" Cc: Leif Lindholm Cc: Ard Biesheuvel --- EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c | 9 - 1

[edk2-devel] [PATCH v2 6/7] EmbeddedPkg: Fix DwEmmc SendCommand polling

2019-05-27 Thread Loh, Tien Hock
From: "Tien Hock, Loh" Change SendCommand polling mode to remove unnecessary delay, and check for transfer done only when block data is to be read/write. This would also increase performance slightly. Signed-off-by: "Tien Hock, Loh" Cc: Leif Lindholm Cc: Ard Biesheuvel ---

[edk2-devel] [PATCH v2 4/7] EmbeddedPkg: Fix response check flag

2019-05-27 Thread Loh, Tien Hock
From: "Tien Hock, Loh" Do not send CRC response check if the MMC command does not support CRC response Signed-off-by: Tien Hock, Loh Cc: Leif Lindholm Cc: Ard Biesheuvel --- EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[edk2-devel] [PATCH v2 2/7] EmbeddedPkg: Fix DwEmmc CMD8 support for SD

2019-05-27 Thread Loh, Tien Hock
From: "Tien Hock, Loh" On CMD8, for SD, the controller should not expect data as this is a SEND_IF_COND command to verify SD operating condition, and does not have data. Signed-off-by: Tien Hock, Loh Cc: Leif Lindholm Cc: Ard Biesheuvel -- v2 - Change IsEmmc to EFI_MMC_HOST_CARD_TYPE ---

[edk2-devel] [PATCH v2 0/7] Fix some bugs with DwEmmc

2019-05-27 Thread Loh, Tien Hock
From: "Tien Hock, Loh" There are some issues with DwEmmc when being used with SD protocol. These series of patches fixes the issues. TIen Hock, Loh (1): EmbeddedPkg: Add SD command support for DwEmmc Tien Hock, Loh (6): EmbeddedPkg: Fix DwEmmc CMD8 support for SD EmbeddedPkg: Send

Re: [edk2-devel] [PATCH v2 6/7] EmbeddedPkg: Fix DwEmmc SendCommand polling

2019-06-10 Thread Loh, Tien Hock
- > > From: Haojian Zhuang > > Sent: Thursday, May 30, 2019 3:06 PM > > To: Leif Lindholm > > Cc: Loh, Tien Hock ; devel@edk2.groups.io; > > thlo...@gmail.com; Ard Biesheuvel > > Subject: Re: [PATCH v2 6/7] EmbeddedPkg: Fix DwEmmc SendCommand > >

Re: [edk2-devel] [PATCH v2 6/7] EmbeddedPkg: Fix DwEmmc SendCommand polling

2019-06-11 Thread Loh, Tien Hock
> -Original Message- > From: Leif Lindholm > Sent: Tuesday, June 11, 2019 5:09 PM > To: Loh, Tien Hock > Cc: 'Haojian Zhuang' ; 'devel@edk2.groups.io' > ; 'thlo...@gmail.com' ; 'Ard > Biesheuvel' > Subject: Re: [PATCH v2 6/7] EmbeddedPkg: Fix DwEmmc SendComma

[edk2-devel] [PATCH 2/4] EmbeddedPkg: Fix response check flag

2019-05-09 Thread Loh, Tien Hock
From: "Tien Hock, Loh" Do not send CRC response check if the MMC command does not support CRC response Signed-off-by: Tien Hock, Loh Cc: Leif Lindholm Cc: Ard Biesheuvel --- EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[edk2-devel] [PATCH v2] EmbeddedPkg: Fix DwEmmc SendCommand polling

2019-05-09 Thread Loh, Tien Hock
From: "Tien Hock, Loh" Change SendCommand polling mode to remove unnecessary delay, and check for transfer done only when block data is to be read/write. This would also increase performance slightly. Signed-off-by: "Tien Hock, Loh" Cc: Leif Lindholm Cc: Ard Biesheuvel ---

[edk2-devel] [PATCH v2] EmbeddedPkg: Clear CTYPE on initialization

2019-05-09 Thread Loh, Tien Hock
From: "Tien Hock, Loh" Clear CTYPE on initialization. This is important if previous bootloader changes the CTYPE can cause the controller to not initialize correctly if CTYPE is not reset to 0 Signed-off-by: "Tien Hock, Loh" Cc: Leif Lindholm Cc: Ard Biesheuvel ---

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: BaseSerialPortLib16550: Update Mmio32 to UNI

2019-05-09 Thread Loh, Tien Hock
> -Original Message- > From: Wu, Hao A > Sent: Thursday, May 9, 2019 2:37 PM > To: devel@edk2.groups.io; Loh, Tien Hock ; > thlo...@gmail.com > Cc: tien.hock.loh ; Wang, Jian J > ; Zhu, Yonghong > Subject: RE: [edk2-devel] [PATCH 1/1] MdeModulePkg: > BaseSerial

[edk2-devel] [PATCH v2 1/1] MdeModulePkg: BaseSerialPortLib16550: Add missing Pcd to UNI

2019-05-09 Thread Loh, Tien Hock
From: "Tien Hock, Loh" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1771 Some busses doesn't allow 8 bit MMIO read/write, this adds support for 32 bits read/write. This patch adds the UNI information on the new Pcd introduced - PcdSerialRegisterAccessWidth Signed-off-by: "Tien Hock, Loh"

[edk2-devel] [[edk2-platforms]PATCH v4 1/1] Platform: Intel: Add Stratix 10 platform support

2019-05-09 Thread Loh, Tien Hock
From: "Tien Hock, Loh" Adds support for Intel Stratix 10 Platform. Signed-off-by: "Tien Hock, Loh" Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney -- v4 - Removed LibC - Added NOOPT to BUILD_TARGETS - Removed ARM from

Re: [edk2-devel] [PATCH v2] EmbeddedPkg: Clear CTYPE on initialization

2019-05-22 Thread Loh, Tien Hock
Hi Ard, Leif, Can you help review this? Thanks! -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#41205): https://edk2.groups.io/g/devel/message/41205 Mute This Topic: https://groups.io/mt/31552976/21656 Group Owner:

Re: [edk2-devel] [PATCH 2/4] EmbeddedPkg: Fix response check flag

2019-05-22 Thread Loh, Tien Hock
Hi Ard, Leif, Can you help review this? Thanks! -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#41204): https://edk2.groups.io/g/devel/message/41204 Mute This Topic: https://groups.io/mt/31552954/21656 Group Owner:

[edk2-devel] [PATCH v2 1/1] EmbeddedPkg: Fix DwEmmc read/write size in preparing DMA size

2019-05-09 Thread Loh, Tien Hock
From: "Tien Hock, Loh" Add support for reading data that is less than DWEMMC_BLOCK_SIZE, otherwise it would read bigger data than requested and cause errors Signed-off-by: "Tien Hock, Loh" Cc: Leif Lindholm Cc: Ard Biesheuvel -- v2: - Fix white space issue ---

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: BaseSerialPortLib16550: Add Mmio32 support

2019-04-24 Thread Loh, Tien Hock
tform that uses I/O space, thus I'm unable to test the changes. > Mike > > > -Original Message- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] > > On Behalf Of Wu, Hao A > > Sent: Tuesday, April 23, 2019 8:20 PM > > To: Loh, Tien Hock ;

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: BaseSerialPortLib16550: Add Mmio32 support

2019-04-26 Thread Loh, Tien Hock
> -Original Message- > From: Wu, Hao A > Sent: Friday, April 26, 2019 1:36 PM > To: thlo...@gmail.com; devel@edk2.groups.io; Loh, Tien Hock > ; Kinney, Michael D > > Cc: Wang, Jian J > Subject: RE: [PATCH 1/1] MdeModulePkg: BaseSerialPortLib165

[edk2-devel] [PATCH v5 1/1] MdeModulePkg: BaseSerialPortLib16550: Add Mmio32 support

2019-04-26 Thread Loh, Tien Hock
From: "Tien Hock, Loh" Some busses doesn't allow 8 bit MMIO read/write, this adds support for 32 bits read/write Signed-off-by: "Tien Hock, Loh" Cc: Jian J Wang Cc: Hao Wu --- v5 - Updates function header comments - Change the implementation to eliminate unnecessary else clause v4 - Updates

[edk2-devel] [[edk2-platforms] PATCH v3 1/1] Platform/Intel/Stratix10: Add Stratix 10 platform support

2019-05-01 Thread Loh, Tien Hock
From: "Tien Hock, Loh" Adds support for Intel Stratix 10 Platform. Signed-off-by: "Tien Hock, Loh" #Cc: Ard Biesheuvel #Cc: Leif Lindholm #Cc: Michael D Kinney -- v3 - Updated Pcd with updated name v2 - Updates ShellBinPkg with ShellPkg --- .../Drivers/IntelPlatformDxe/IntelPlatformDxe.c

Re: [edk2-devel] [[edk2-platforms] PATCH v3 1/1] Platform/Intel/Stratix10: Add Stratix 10 platform support

2019-05-01 Thread Loh, Tien Hock
Please ignore this patch, something went wrong with the my mail server config. See https://edk2.groups.io/g/devel/message/39897 for the actual patch -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#39898):

[edk2-devel] [PATCH 1/1] EmbeddedPkg: Fix DwEmmc driver bugs

2019-05-01 Thread Loh, Tien Hock
From: "Tien Hock, Loh" This fixes some issues with DwEmmc when using with SDMMC card: - clear CTYPE when controller initializes - change SendCommand polling mode to remove unnecessary delay - Add CMD6 support for SD support - For pending read/write command, send when DwEmmcReceiveResponse is

[edk2-devel] [[PATCH v2] 0/7] Fix DwEmmc driver bugs

2019-05-02 Thread Loh, Tien Hock
From: "Tien Hock, Loh" This fixes a few issues with DwEmmc driver: - - Change SendCommand polling mode and check for DTO when read/write - Add CMD6 for SD support - Clear CTYPE on initialization - Add CMD8 support for SD - Add ACMD51 for SD - Call send command when receive response is

[edk2-devel] [[PATCH v2] 2/7] EmbeddedPkg: Fix DwEmmc driver bugs

2019-05-02 Thread Loh, Tien Hock
From: "Tien Hock, Loh" Clear CTYPE on initialization. This is important if previous bootloader changes the CTYPE can cause the controller to not initialize correctly if CTYPE is not reset to 0 Signed-off-by: "Tien Hock, Loh" Cc: Leif Lindholm Cc: Ard Biesheuvel ---

[edk2-devel] [[PATCH v2] 4/7] EmbeddedPkg: Fix DwEmmc driver bugs

2019-05-02 Thread Loh, Tien Hock
From: "Tien Hock, Loh" Add ACMD51 support for SD, this is needed to do SEND_SCR command correctly Signed-off-by: "Tien Hock, Loh" Cc: Leif Lindholm Cc: Ard Biesheuvel --- EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c | 4 1 file changed, 4 insertions(+) diff --git

[edk2-devel] [[PATCH v2] 6/7] EmbeddedPkg: Fix DwEmmc driver bugs

2019-05-02 Thread Loh, Tien Hock
From: "Tien Hock, Loh" Do not send CRC response check if the MMC command does not support CRC response Signed-off-by: "Tien Hock, Loh" Cc: Leif Lindholm Cc: Ard Biesheuvel --- EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

[edk2-devel] [[PATCH v2] 7/7] EmbeddedPkg: Fix DwEmmc driver bugs

2019-05-02 Thread Loh, Tien Hock
From: "Tien Hock, Loh" Add support for reading data that is less than DWEMMC_BLOCK_SIZE, otherwise it would read bigger data than requested and cause errors Signed-off-by: "Tien Hock, Loh" Cc: Leif Lindholm Cc: Ard Biesheuvel --- EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c | 16

[edk2-devel] [[PATCH v2] 3/7] EmbeddedPkg: Fix DwEmmc driver bugs

2019-05-02 Thread Loh, Tien Hock
From: "Tien Hock, Loh" On CMD8, for SD, the controller should not expect data as this is a SEND_IF_COND command to verify SD operating condition, and does not have data Signed-off-by: "Tien Hock, Loh" Cc: Leif Lindholm Cc: Ard Biesheuvel --- EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c

[edk2-devel] [PATCH 1/1] MdeModulePkg: BaseSerialPortLib16550: Update Mmio32 to UNI

2019-05-07 Thread Loh, Tien Hock
From: "tien.hock.loh" Some busses doesn't allow 8 bit MMIO read/write, this adds support for 32 bits read/write. This patch adds the UNI information on the new Pcd introduced - PcdSerialRegisterAccessWidth Signed-off-by: "Tien Hock, Loh" Cc: Jian J Wang Cc: Hao Wu Cc: "Zhu, YongHong"

[edk2-devel] [PATCH 1/1] EmbeddedPkg: Add SD command support for DwEmmc

2019-05-08 Thread Loh, Tien Hock
From: "TIen Hock, Loh" Added ACMD6 for SD support. For SD, after CMD55 is sent, the next command should be an application command, which should not expect data Signed-off-by: "Tien Hock, Loh" Cc: Leif Lindholm Cc: Ard Biesheuvel -- v2: - Move IsACmd as a local static variable in function -

Re: [edk2-devel] [[PATCH v2] 7/7] EmbeddedPkg: Fix DwEmmc driver bugs

2019-05-09 Thread Loh, Tien Hock
> -Original Message- > From: Leif Lindholm > Sent: Friday, May 3, 2019 8:19 PM > To: Loh, Tien Hock > Cc: devel@edk2.groups.io; thlo...@gmail.com; Ard Biesheuvel > > Subject: Re: [[PATCH v2] 7/7] EmbeddedPkg: Fix DwEmmc driver bugs > > On Fri, May 0

Re: [edk2-devel] [PATCH v2 6/7] EmbeddedPkg: Fix DwEmmc SendCommand polling

2019-07-11 Thread Loh, Tien Hock
Leif, Some comments inlined. > -Original Message- > From: Loh, Tien Hock > Sent: Tuesday, June 11, 2019 5:12 PM > To: Leif Lindholm > Cc: 'Haojian Zhuang' ; 'devel@edk2.groups.io' > ; 'thlo...@gmail.com' ; 'Ard > Biesheuvel' > Subject: RE: [PATCH v2 6/7]

[edk2-devel] [[edk2-platforms]PATCH v5 1/1] Platform: Intel: Add Stratix 10 platform support

2019-07-16 Thread Loh, Tien Hock
From: "Tien Hock, Loh" Adds support for Intel Stratix 10 Platform. Signed-off-by: "Tien Hock, Loh" Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney --- Platform/Intel/Stratix10/Drivers/IntelPlatformDxe/IntelPlatformDxe.c

Re: [edk2-devel] [PATCH v2 0/3] add DwMmcHcDxe driver

2019-08-15 Thread Loh, Tien Hock
Hi Leif, Ard, Christopher, Haojian and I have tested the driver on 2 platforms, any further comments on this? Thanks Tien Hock > -Original Message- > From: Haojian Zhuang > Sent: Tuesday, July 30, 2019 3:33 PM > To: Loh, Tien Hock ; leif.lindh...@linaro.org; &

Re: [edk2-devel] [PATCH v6 1/1] Platform: Intel: Add Stratix 10 platform support

2019-08-12 Thread Loh, Tien Hock
Hi Leif, I'll update it and send another patch on top of the previously reviewed patch. Thanks! > -Original Message- > From: Leif Lindholm > Sent: Friday, August 9, 2019 6:16 PM > To: Loh, Tien Hock > Cc: Kinney, Michael D ; devel@edk2.groups.io; > thlo...@gmail.c

[edk2-devel] [PATCH 1/1] Platform: Intel: Update licenses to SPDX and update clock settings

2019-09-03 Thread Loh, Tien Hock
From: "Tien Hock, Loh" Update all license to SPDX. Also update UART clock to be calculated instead of hardcoded, removed some unused packages, and updated maintainers. Signed-off-by: "Tien Hock, Loh" Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Ard Biesheuvel Cc: Leif Lindholm

Re: [edk2-devel] [PATCH v2 0/3] add DwMmcHcDxe driver

2019-09-11 Thread Loh, Tien Hock
Hi Ard, Leif, Christopher, Any comments on the patches? Thanks! Tien Hock > -Original Message- > From: Haojian Zhuang > Sent: Monday, September 2, 2019 5:31 PM > To: Loh, Tien Hock > Cc: leif.lindh...@linaro.org; ard.biesheu...@linaro.org; > christopher...@microso

[edk2-devel] [PATCH 3/4] Platform: Intel: Remove unused packages and clean up

2019-09-05 Thread Loh, Tien Hock
From: "Tien Hock, Loh" Remove some unused packages in Stratix 10 packages, clean up some commented out codes Signed-off-by: "Tien Hock, Loh" Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney ---

[edk2-devel] [PATCH 0/4] Update Stratix 10 platform support

2019-09-05 Thread Loh, Tien Hock
From: "Tien Hock, Loh" Update maintainer list, SPDX license, remove unused packages and remove hardcoded UART clock Tien Hock, Loh (4): Platform: Intel: Update maintainers list for Stratix 10 device Platform: Intel: Update license to SPDX Platform: Intel: Remove unused packages and clean

[edk2-devel] [PATCH 1/4] Platform: Intel: Update maintainers list for Stratix 10 device

2019-09-05 Thread Loh, Tien Hock
From: "Tien Hock, Loh" Update maintainers list for Stratix 10 devices Signed-off-by: "Tien Hock, Loh" Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney --- Maintainers.txt | 5 + 1 file changed, 5 insertions(+) diff --git

[edk2-devel] [PATCH 4/4] Platform: Intel: Remove hardcoded Stratix 10 UART clock

2019-09-05 Thread Loh, Tien Hock
From: "Tien Hock, Loh" Added clock manager so that Stratix 10 UART clock doesn't need to be hardcoded Signed-off-by: "Tien Hock, Loh" Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney ---

[edk2-devel] [PATCH 2/4] Platform: Intel: Update license to SPDX

2019-09-05 Thread Loh, Tien Hock
From: "Tien Hock, Loh" Update licenses to SPDX Signed-off-by: "Tien Hock, Loh" Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney --- Platform/Intel/Stratix10/Drivers/IntelPlatformDxe/IntelPlatformDxe.inf | 22

Re: [edk2-devel] [PATCH v6 1/1] Platform: Intel: Add Stratix 10 platform support

2019-08-04 Thread Loh, Tien Hock
Hi Leif, Ard, Micheal, Any comments on this? Thanks! -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44890): https://edk2.groups.io/g/devel/message/44890 Mute This Topic: https://groups.io/mt/32677389/21656 Group Owner:

Re: [edk2-devel] [PATCH v6 1/1] Platform: Intel: Add Stratix 10 platform support

2019-08-04 Thread Loh, Tien Hock
Hi Leif, Ard, Micheal, Any comments on this patch? Thanks Tien Hock > -Original Message- > From: Loh, Tien Hock > Sent: Thursday, August 1, 2019 6:32 PM > To: devel@edk2.groups.io; thlo...@gmail.com > Cc: Loh, Tien Hock ; Ard Biesheuvel > ; Leif Lindholm ; > Kinney,

Re: [edk2-devel] [PATCH v6 1/1] Platform: Intel: Add Stratix 10 platform support

2019-08-05 Thread Loh, Tien Hock
Hi Leif, OK noted, I'll submit a new patch on top of the commit. I'll also try to ping Micheal. Thanks Tien Hock > -Original Message- > From: Leif Lindholm > Sent: Monday, August 5, 2019 5:26 PM > To: Loh, Tien Hock ; Kinney, Michael D > > Cc: devel@edk2.groups.io;

[edk2-devel] [PATCH v6 1/1] Platform: Intel: Add Stratix 10 platform support

2019-08-01 Thread Loh, Tien Hock
From: "Tien Hock, Loh" Adds support for Intel Stratix 10 Platform. Signed-off-by: "Tien Hock, Loh" Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney --- v5: Remove hardcoded UART clock ---

Re: [edk2-devel] [PATCH v6 1/1] Platform: Intel: Add Stratix 10 platform support

2019-08-08 Thread Loh, Tien Hock
> -Original Message- > From: Kinney, Michael D > Sent: Friday, August 9, 2019 3:50 AM > To: Leif Lindholm ; Loh, Tien Hock > ; Kinney, Michael D > > Cc: devel@edk2.groups.io; thlo...@gmail.com; Ard Biesheuvel > > Subject: RE: [PATCH v6 1/1] Platform: Int

[edk2-devel] [PATCH v2 2/3] EmbeddedPkg: add PlatformDwMmc protocol

2019-07-24 Thread Loh, Tien Hock
From: Haojian Zhuang Add PlatformDwMmc protocol. It's used to set properties of DwMmc device in platform driver. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Chris Co Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Haojian Zhuang ---

[edk2-devel] [PATCH v2 1/3] EmbeddedPkg: add NonDiscoverableDeviceDxe driver

2019-07-24 Thread Loh, Tien Hock
From: Haojian Zhuang It's used to create NonDiscoverableDevice in embedded platform. Since there's no PCI bus. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Chris Co Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Haojian Zhuang Signed-off-by: Tien Hock, Loh ---

[edk2-devel] Problem with decompression on EDK2

2019-09-26 Thread Loh, Tien Hock
Hi I have an issue while porting a new platform to EDK2. After porting the Stratix 10 platform (ARM) to EDK2 it works correctly. However, when I tried to add more INF to the FDF file, it failed to decompress the image during boot time, log as below INFO: DDR: DRAM calibration success. INFO:

[edk2-devel] Problem with decompression on EDK2

2019-09-26 Thread Loh, Tien Hock
Hi I have an issue while porting a new platform to EDK2. After porting the Stratix 10 platform (ARM) to EDK2 it works correctly. However, when I tried to add more INF to the FDF file, it failed to decompress the image during boot time, log as below INFO:DDR: DRAM calibration success. INFO:

Re: [edk2-devel] Problem with decompression on EDK2

2019-09-30 Thread Loh, Tien Hock
Hi Liming, Thanks for the quick response. Can you help show me where I can find more information on the decompression (ie. how to test the image, etc.)? Thanks Tien Hock > -Original Message- > From: Gao, Liming > Sent: Sunday, September 29, 2019 3:06 PM > To: Loh, Tien

Re: [edk2-devel] Problem with decompression on EDK2

2019-10-08 Thread Loh, Tien Hock
Ok, noted with thanks Liming. I'll try the tools out. Thanks Tien Hock > -Original Message- > From: Gao, Liming > Sent: Tuesday, October 8, 2019 10:04 PM > To: Loh, Tien Hock ; devel@edk2.groups.io; > ler...@redhat.com > Cc: leif.lindh...@linaro.org; ard.biesheu...@li

Re: [edk2-devel] [EXT] Re: [PATCH 1/1] EmbeddedPkg/MmcDxe: Added MaxBlock Transfer Limit 65535 in R/W.

2020-04-07 Thread Loh, Tien Hock
0 3:02 PM > To: Ard Biesheuvel ; Leif Lindholm > > Cc: devel@edk2.groups.io; Pankaj Bansal ; Haojian > Zhuang ; Loh, Tien Hock > > Subject: RE: [EXT] Re: [PATCH 1/1] EmbeddedPkg/MmcDxe: Added MaxBlock > Transfer Limit 65535 in R/W. > > > > > -Original Me

Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/MmcDxe: Added MaxBlock Transfer Limit 65535 in R/W.

2020-04-28 Thread Loh, Tien Hock
Pankaj Bansal > Sent: Monday, April 27, 2020 2:19 PM > To: Ard Biesheuvel ; Leif Lindholm > ; Gaurav Jain ; Meenakshi > Aggarwal > Cc: devel@edk2.groups.io; Haojian Zhuang ; Loh, > Tien Hock ; Varun Sethi > Subject: RE: [PATCH 1/1] EmbeddedPkg/MmcDxe: Added MaxBlock Tr

Re: [edk2-devel] [EXT] Re: [PATCH 1/1] EmbeddedPkg/MmcDxe: Added MaxBlock Transfer Limit 65535 in R/W.

2020-04-26 Thread Loh, Tien Hock
: Tuesday, April 21, 2020 2:40 PM > To: Loh, Tien Hock ; Ard Biesheuvel > ; Leif Lindholm > Cc: devel@edk2.groups.io; Pankaj Bansal ; Haojian > Zhuang > Subject: RE: [EXT] Re: [PATCH 1/1] EmbeddedPkg/MmcDxe: Added MaxBlock > Transfer Limit 65535 in R/W. > > Hi Tien Hock >

Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/MmcDxe: Added MaxBlock Transfer Limit 65535 in R/W.

2020-04-29 Thread Loh, Tien Hock
Hi Leif, Yes, that's a Reviewed-by. Thanks. > -Original Message- > From: Leif Lindholm > Sent: Wednesday, April 29, 2020 7:16 PM > To: Loh, Tien Hock > Cc: Pankaj Bansal ; Ard Biesheuvel > ; Gaurav Jain ; Meenakshi > Aggarwal ; devel@edk2.groups.io; Haojian &

Re: [edk2-devel] [PATCH v2 0/3] add DwMmcHcDxe driver

2020-06-16 Thread Loh, Tien Hock
me understand and fix the concern you have. Thanks > -Original Message- > From: Loh, Tien Hock > Sent: Thursday, September 12, 2019 12:59 PM > To: Haojian Zhuang ; leif.lindh...@linaro.org; > ard.biesheu...@linaro.org; christopher...@microsoft.com > Cc: devel@ed

Re: [edk2-devel] [PATCH v2 0/3] add DwMmcHcDxe driver

2020-06-19 Thread Loh, Tien Hock
Hi Leif, Ard, Can you help on the questions I have below? Thanks! > -Original Message- > From: Loh, Tien Hock > Sent: Tuesday, June 16, 2020 4:39 PM > To: 'Haojian Zhuang' ; 'leif.lindh...@linaro.org' > ; 'ard.biesheu...@linaro.org' > ; 'christopher...@microsoft.co

Re: [edk2-devel] [PATCH V5 1/1] EmbeddedPkg: DwMmcHcDxe: Add support for Designware SDMMC driver

2021-04-28 Thread Loh, Tien Hock
Andrew, Ard, In that case then I will update the patch to address Mike’s concerns and send a new version up. Thanks! From: Andrew Fish Sent: Wednesday, April 28, 2021 10:58 PM To: Ard Biesheuvel Cc: Kinney, Michael D ; edk2-devel-groups-io ; Loh, Tien Hock ; thlo...@gmail.com; Leif

[edk2-devel] [PATCH V4 1/1] EmbeddedPkg: DwMmcHcDxe: Add support for Designware SDMMC driver

2021-03-19 Thread Loh, Tien Hock
From: Loh Tien Hock This adds support for Designware SDMMC driver. The SDMMC driver depends on MdeModulePkg/Bus/Sd/, and produces EFI_SD_MMC_PASS_THRU_PROTOCOL. The driver uses MMIO to read/write, and uses gEdkiiNonDiscoverableDeviceProtocolGuid. Platform needs to register device

Re: [edk2-devel] [PATCH v1 1/1] EmbeddedPkg: DwMmcHcDxe: Add support for Designware SDMMC driver

2021-03-08 Thread Loh, Tien Hock
Please skip this patch, I missed one file in the patch. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72570): https://edk2.groups.io/g/devel/message/72570 Mute This Topic: https://groups.io/mt/81194433/21656 Group Owner:

[edk2-devel] [PATCH v1 0/1] EmbeddedPkg: DwMmcHcDxe: Add support for Designware SDMMC driver

2021-03-08 Thread Loh, Tien Hock
From: Loh Tien Hock This adds support for Designware SDMMC driver. The SDMMC driver depends on MdeModulePkg/Bus/Sd/, and produces EFI_SD_MMC_PASS_THRU_PROTOCOL. The driver uses MMIO to read/write, and uses gEdkiiNonDiscoverableDeviceProtocolGuid. Platform needs to register device

[edk2-devel] [PATCH v1 0/1] Add support for Designware SDMMC driver

2021-03-08 Thread Loh, Tien Hock
From: Loh Tien Hock This adds support for Designware SDMMC driver. The SDMMC driver depends on MdeModulePkg/Bus/Sd/, and produces EFI_SD_MMC_PASS_THRU_PROTOCOL. The driver uses MMIO to read/write, and uses gEdkiiNonDiscoverableDeviceProtocolGuid. Platform needs to register device

Re: [edk2-devel] [PATCH v2 3/3] EmbeddedPkg/Drivers: add DwMmcHcDxe driver

2021-02-19 Thread Loh, Tien Hock
Hi Leif, Ard, Sorry I've been working non EDK2 work for the past year and am now back to working on this Can you comment on the changes that is needed to get this driver upstreamed? Thank you. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply