Reviewed-by: Sami Mujawar
-Original Message-
From: Krzysztof Koch
Sent: 07 June 2019 09:48 AM
To: devel@edk2.groups.io
Cc: Sami Mujawar ; jaben.car...@intel.com;
ray...@intel.com; zhichao@intel.com; Matteo Carlini
; Stephanie Hughes-Fitt
; nd
Subject: [PATCH v2 1/1] ShellPkg
Reviewed-by: Sami Mujawar
-Original Message-
From: PierreGondois
Sent: 06 June 2019 01:29 PM
To: devel@edk2.groups.io
Cc: jaben.car...@intel.com; ray...@intel.com; zhichao@intel.com; Sami
Mujawar ; Matteo Carlini ;
Stephanie Hughes-Fitt ; Pierre Gondois
; nd
Subject: [PATCH v1
Reviewed-by: Sami Mujawar
-Original Message-
From: Krzysztof Koch
Sent: 12 June 2019 10:32 AM
To: devel@edk2.groups.io
Cc: Ard Biesheuvel ; Leif Lindholm
; Michael D Kinney ; Sami
Mujawar ; Matteo Carlini ;
Stephanie Hughes-Fitt ; nd
Subject: [edk2-platforms PATCH v1 1/1 -resend
Pushed as 98f98eb440d6..75bf10a68914
-Original Message-
From: Sami Mujawar
Sent: 10 June 2019 07:59 PM
To: devel@edk2.groups.io
Cc: nd
Subject: RE: [PATCH v1 1/1] DynamicTablesPkg: Add frame number validation to
GTDT generator
Reviewed-by: Sami Mujawar
-Original Message
Reviewed-by: Sami Mujawar
-Original Message-
From: Krzysztof Koch
Sent: 24 May 2019 01:07 PM
To: devel@edk2.groups.io
Cc: leif.lindh...@linaro.org; Sami Mujawar ; Alexei
Fedorov ; Matteo Carlini ;
Stephanie Hughes-Fitt ; nd
Subject: [PATCH v1 1/1] DynamicTablesPkg: Add dynamic PPTT
Pushed as 8349b8683640..77db115601fb
-Original Message-
From: Sami Mujawar
Sent: 11 June 2019 09:12 AM
To: devel@edk2.groups.io
Cc: nd
Subject: RE: [PATCH v1 1/1] DynamicTablesPkg: Add dynamic PPTT table generation
support
Reviewed-by: Sami Mujawar
-Original Message-
From
Reviewed-by: Sami Mujawar
-Original Message-
From: Krzysztof Koch
Sent: 16 May 2019 11:12 AM
To: devel@edk2.groups.io
Cc: leif.lindh...@linaro.org; Sami Mujawar ; Alexei
Fedorov ; Matteo Carlini ;
Stephanie Hughes-Fitt ; nd
Subject: [PATCH v1 0/3] Detect duplicate field values
Pushed as ccc97f6df415..5506701f7984
-Original Message-
From: Sami Mujawar
Sent: 10 June 2019 09:13 PM
To: devel@edk2.groups.io
Cc: nd
Subject: RE: [PATCH v1 1/1] DynamicTablesPkg: Add ACPI 6.3 SPE support to MADT
generator
Reviewed-by: Sami Mujawar
-Original Message-
From
Reviewed-by: Sami Mujawar
-Original Message-
From: Krzysztof Koch
Sent: 16 May 2019 03:53 PM
To: devel@edk2.groups.io
Cc: leif.lindh...@linaro.org; Sami Mujawar ; Alexei
Fedorov ; Matteo Carlini ;
Stephanie Hughes-Fitt ; nd
Subject: [PATCH v1 1/1] DynamicTablesPkg: Add ACPI 6.3 SPE
Reviewed-by: Sami Mujawar
-Original Message-
From: PierreGondois
Sent: 06 June 2019 10:21 AM
To: devel@edk2.groups.io
Cc: Sami Mujawar ; Alexei Fedorov
; Matteo Carlini ; Stephanie
Hughes-Fitt ; Pierre Gondois
; nd
Subject: [PATCH v1 1/1] DynamicTablesPkg: GTDT updates for ACPI 6.3
Pushed as 77db115601fb..e8015f2facff
-Original Message-
From: Sami Mujawar
Sent: 11 June 2019 09:55 AM
To: devel@edk2.groups.io
Cc: nd
Subject: RE: [PATCH v1 1/1] DynamicTablesPkg: GTDT updates for ACPI 6.3
Reviewed-by: Sami Mujawar
-Original Message-
From: PierreGondois
Reviewed-by: Sami Mujawar
-Original Message-
From: Krzysztof Koch
Sent: 12 June 2019 11:44 AM
To: Gao, Zhichao ; devel@edk2.groups.io
Cc: Sami Mujawar ; Carsey, Jaben
; Ni, Ray ; nd
Subject: RE: [PATCH v2 1/1] ShellPkg: acpiview: ACPI 6.3 update for MADT parser
Hi Zhichao,
Please
Reviewed-by: Sami Mujawar
-Original Message-
From: Krzysztof Koch
Sent: 12 June 2019 03:11 PM
To: devel@edk2.groups.io
Cc: jaben.car...@intel.com; ray...@intel.com; zhichao@intel.com;
michael.d.kin...@intel.com; liming@intel.com; Sami Mujawar
; Matteo Carlini ; Stephanie
Reviewed-by: Sami Mujawar
-Original Message-
From: Krzysztof Koch
Sent: 12 June 2019 03:11 PM
To: devel@edk2.groups.io
Cc: jaben.car...@intel.com; ray...@intel.com; zhichao@intel.com;
michael.d.kin...@intel.com; liming@intel.com; Sami Mujawar
; Matteo Carlini ; Stephanie
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-Original Message-
From: Krzysztof Koch
Sent: 08 May 2019 02:44 PM
To: devel@edk2.groups.io
Cc: jaben.car...@intel.com; ray...@intel.com; Sami Mujawar
; Girish Pathak ; Pierre Gondois
; Matteo Carlini ; Stephanie
Hughes-Fitt ; nd
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-Original Message-
From: Krzysztof Koch
Sent: 08 May 2019 02:14 PM
To: devel@edk2.groups.io
Cc: jaben.car...@intel.com; ray...@intel.com; Sami Mujawar
; Girish Pathak ; Pierre Gondois
; Matteo Carlini ; Stephanie
Hughes-Fitt ; nd
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-Original Message-
From: Krzysztof Koch
Sent: 31 January 2019 01:30 PM
To: edk2-de...@lists.01.org
Cc: jaben.car...@intel.com; ray...@intel.com; Matteo Carlini
; Stephanie Hughes-Fitt
; Sami Mujawar ; nd
Subject: [PATCH v1 1/1
Package name: DynamicTablesPkg
Change: https://edk2.groups.io/g/devel/topic/edk2_patch_v3_change_edk/30887153
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-Original Message-
From: Kinney, Michael D
Sent: 09 April 2019 11:02 AM
To: Sami Mujawar ; Kinney, Michael D
Subject: RE
to EfiBootManagerDispatchDeferredImages() for
dispatching deferred images from PlatformBootManagerLib.
Signed-off-by: Sami Mujawar
---
The changes can be seen at
https://github.com/samimujawar/edk2/tree/527_option_rom_loading_v1
ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 7 ++-
1 file
Hi Leif,
We do not use this file and am ok if this is removed. However, I will let
Thomas confirm this.
Regards,
Sami Mujawar
-Original Message-
From: Leif Lindholm
Sent: 07 May 2019 10:31 AM
To: Fan, ZhijuX
Cc: devel@edk2.groups.io; Thomas Abraham ; Sami Mujawar
; Cohen, Eugene
Reviewed-by: Sami Mujawar
-Original Message-
From: Gao, Liming
Sent: 07 May 2019 04:08 PM
To: devel@edk2.groups.io; Krzysztof Koch
Cc: Sami Mujawar ; nd
Subject: RE: [edk2-devel] [PATCH v1 1/1 -resend] MdePkg: Add ACPI 6.3 header
file
The change is good. Reviewed-by: Liming Gao
. Something like
if (LocalityCount < MAX_UINT32) {
// Validate
for (Count = 0; Count < LocalityCount; Count++) {
for (Index = 0; Index < LocalityCount; Index++) {
...
} else {
Print (L"INFO: Skipping validation of System Localities as locality count is
> MAX_UINT32\n&quo
Add DISABLE_NEW_DEPRECATED_INTERFACES macro to the Arm platform
build flags to disable the use of deprecated APIs.
Signed-off-by: Sami Mujawar
---
Notes:
v1:
- Disable the use of deprecated APIs for Arm Platforms. [SAMI]
Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 5
/deprecated APIs/macros
are not used.
- fixes the usage of unsafe/deprecated APIs/macros in the Juno platform
code.
The changes can be seen at
https://github.com/samimujawar/edk2-platforms/tree/580_disable_deprecated_interfaces_v1
Sami Mujawar (2):
Platform/ARM: Juno: Fix usage of deprecated
Replaced the use of unsafe/deprecated macros with alternate safe
options.
Signed-off-by: Sami Mujawar
---
Notes:
v1:
- Replace unsafe/deprecated macros with alternate safe options. [SAMI]
Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c | 12 +++-
1 file changed, 7
Reviewed-by: Sami Mujawar
-Original Message-
From: Krzysztof Koch
Sent: 28 June 2019 09:57 AM
To: devel@edk2.groups.io
Cc: jaben.car...@intel.com; ray...@intel.com; zhichao@intel.com; Sami
Mujawar ; Matteo Carlini ; nd
Subject: [PATCH v1 0/5] Clean up acpiview input parameters
Hi Mike, All,
I agree it will be good to add acpiview to the standard ShellPkg build.
Regards,
Sami Mujawar
-Original Message-
From: Carsey, Jaben
Sent: 01 August 2019 09:46 PM
To: Kinney, Michael D ; Sami Mujawar
; devel@edk2.groups.io
Cc: Ni, Ray ; Gao, Zhichao
Subject: RE: [edk2
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-Original Message-
From: Krzysztof Koch
Sent: 19 August 2019 09:25 AM
To: devel@edk2.groups.io
Cc: jaben.car...@intel.com; ray...@intel.com; zhichao@intel.com; Sami
Mujawar ; Matteo Carlini ; nd
Subject: [PATCH v2 03/11] ShellPkg
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-Original Message-
From: Krzysztof Koch
Sent: 15 August 2019 02:11 PM
To: devel@edk2.groups.io
Cc: jaben.car...@intel.com; ray...@intel.com; zhichao@intel.com; Sami
Mujawar ; Matteo Carlini ; nd
Subject: [PATCH v1 05/11] ShellPkg
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-Original Message-
From: Krzysztof Koch
Sent: 15 August 2019 02:11 PM
To: devel@edk2.groups.io
Cc: jaben.car...@intel.com; ray...@intel.com; zhichao@intel.com; Sami
Mujawar ; Matteo Carlini ; nd
Subject: [PATCH v1 00/11] Test
the VS2017 compiler with the static code
analysis option.
The changes can be seen at:
https://github.com/samimujawar/edk2/tree/503_vs2017_compile_issue_v1
Sami Mujawar (19):
DynamicTablesPkg: Fix entry point param definition
DynamicTablesPkg: Fix missing local header warning
DynamicTablesPkg
parameter to the constructor/destructor/DXE Entry
point) to make it compatible with the formal declaration.
Signed-off-by: Sami Mujawar
---
DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.c | 6
+++---
DynamicTablesPkg/Drivers/DynamicTableManagerDxe
On enabling the /analyse option the VS2017 compiler
reports: warning C6001: Using uninitialized memory.
This warning is reported as some variables that were
being logged were uninitialised. To fix this, moved
the logging code after the variables being logged are
initialised.
Signed-off-by: Sami
.
To fix this warning, update the CM_ARM_BOOT_ARCH_INFO struct
to make the BootArchFlags field 16-bit wide. This also makes
it compatible with the ACPI FADT specification.
Signed-off-by: Sami Mujawar
---
DynamicTablesPkg/Include/ArmNameSpaceObjects.h | 2 +-
1 file changed, 1 insertion(+), 1
that the Serial Port Subtype value
provided by the Configuration Manager is within the 8-bit
range (less than 256).
Signed-off-by: Sami Mujawar
---
DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c | 15
++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git
is size_t the VS2017 compiler reports the above warning.
To fix the warning, an explicit type cast is added. An additional
check is also performed to ensure that the calculated GT Block
length does not exceed MAX_UINT16.
Signed-off-by: Sami Mujawar
---
DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm
', possible loss of data' while assigning the
length field of the Processor Hierarchy node structure.
To fix this, a type cast is added. In addition, there is a check
to ensure that the Processor Hierarchy node size does not exceed
MAX_UINT8.
Signed-off-by: Sami Mujawar
---
DynamicTablesPkg/Library
The VS2017 compiler reports 'warning C4366: The result of
the unary '&' operator may be unaligned' if an address of
an unaligned structure member is passed as an argument to
a function.
Fix this warning by using local variables in place of
unaligned structure members.
Signed-off-by: Sami Muj
The VS2017 compiler reports 'error C2016: C requires that
a struct or union has at least one member' for the struct
CM_ARM_CPU_INFO.
Remove struct CM_ARM_CPU_INFO as this is not in use.
Signed-off-by: Sami Mujawar
---
DynamicTablesPkg/Include/ArmNameSpaceObjects.h | 4
1 file changed, 4
type casts at appropriate places and also implements
validations to ensure that the max width of the respective fields
is not exceeded.
This patch also fixes a typo in one of the local variable names.
Signed-off-by: Sami Mujawar
---
DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm
Removing GT Block frame count check from AddGTBlockTimerFrames()
as this is already validated in BuildGtdtTable().
Signed-off-by: Sami Mujawar
---
DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c | 10
--
1 file changed, 10 deletions(-)
diff --git a/DynamicTablesPkg
Add build option STATIC_ANALYSIS to enable VS2017 static
code analysis.
Signed-off-by: Sami Mujawar
---
DynamicTablesPkg/DynamicTablesPkg.dsc | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/DynamicTablesPkg/DynamicTablesPkg.dsc
b/DynamicTablesPkg
the
ACPI Table revision field usage 8-bit wide across Dynamic Tables
Framework.
Signed-off-by: Sami Mujawar
---
DynamicTablesPkg/Include/AcpiTableGenerator.h | 4 ++--
DynamicTablesPkg/Include/StandardNameSpaceObjects.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git
The Dynamic Tables Factory protocol has an erroneous
EFIAPI calling convention macro in the function
pointer declaration.
Remove the erroneous EFIAPI calling convention macro
from the interface declarations.
Signed-off-by: Sami Mujawar
---
DynamicTablesPkg/Include/Protocol
The ARM DCC serial port subtype is an option that is
supported by the DBG2 generator. However, the serial
port initialisation should only be done for PL011/SBSA
compatible UARTs.
Add check to conditionally initialise the serial port.
Signed-off-by: Sami Mujawar
---
DynamicTablesPkg/Library
On enabling the /analyse option the VS2017 compiler
reports: warning C6001: Using uninitialized memory.
This warning is reported as some variables that were
being logged were uninitialised. To fix this, moved
the logging code after the variables being logged are
initialised.
Signed-off-by: Sami
VA_LIST to be a
structure.
Signed-off-by: Sami Mujawar
---
MdePkg/Library/BaseLib/SwitchStack.c | 9 +
MdePkg/Library/BasePrintLib/PrintLib.c | 5 +
MdePkg/Library/BasePrintLib/PrintLibInternal.c | 9 +
3 files changed, 23 insertions(+)
diff --git a/MdePkg
eports the above
warning.
Fix this warning by enclosing the code in appropriate
#if .. #else .. #endif directives.
Signed-off-by: Sami Mujawar
---
ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/ArmPlatformPkg/Library/PL011U
MAX_UINT32.
Signed-off-by: Sami Mujawar
---
ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.c
b/ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.c
index
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-Original Message-
From: Leif Lindholm
Sent: 18 September 2019 11:43 PM
To: devel@edk2.groups.io
Cc: Sami Mujawar ; Alexei Fedorov
Subject: [PATCH 6/9] DynamicTablesPkg: fix .dsc line ending
Correct line ending in package .dsc.
Cc
For this patch series.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-Original Message-
From: Krzysztof Koch
Sent: 01 August 2019 09:44 AM
To: devel@edk2.groups.io
Cc: jaben.car...@intel.com; ray...@intel.com; zhichao@intel.com; Sami
Mujawar ; Matteo Carlini ; nd
Subject
For this patch series.
Tested-by: Sami Mujawar
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-Original Message-
From: devel@edk2.groups.io On Behalf Of Michael D Kinney
via Groups.Io
Sent: 03 August 2019 02:47 AM
To: devel@edk2.groups.io
Cc: Jaben Carsey ; Ray Ni ; Zhichao
Gao
Hi Zhichao,
Please see my response inline.
Regards,
Sami Mujawar
-Original Message-
From: devel@edk2.groups.io On Behalf Of Gao, Zhichao via
Groups.Io
Sent: 05 August 2019 08:23 AM
To: devel@edk2.groups.io; Krzysztof Koch
Cc: Carsey, Jaben ; Ni, Ray ; Sami
Mujawar ; Matteo Carlini
Reviewed-by: Sami Mujawar
-Original Message-
From: Krzysztof Koch
Sent: 22 July 2019 09:25 AM
To: devel@edk2.groups.io; Krzysztof Koch
Cc: jaben.car...@intel.com; ray...@intel.com; zhichao@intel.com; Sami
Mujawar ; nd
Subject: RE: [edk2-devel] [PATCH v2 0/6] Acpiview table
Reviewed-by: Sami Mujawar
-Original Message-
From: Krzysztof Koch
Sent: 18 July 2019 11:05 AM
To: devel@edk2.groups.io
Cc: jaben.car...@intel.com; ray...@intel.com; zhichao@intel.com; Sami
Mujawar ; Matteo Carlini ; nd
Subject: [PATCH v1 0/8] Remove redundant forward
Reviewed-by: Sami Mujawar
-Original Message-
From: Krzysztof Koch
Sent: 18 July 2019 01:32 PM
To: devel@edk2.groups.io
Cc: jaben.car...@intel.com; ray...@intel.com; zhichao@intel.com; Sami
Mujawar ; Matteo Carlini ; nd
Subject: [PATCH v1 0/6] Acpiview table parsers code style
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-Original Message-
From: devel@edk2.groups.io On Behalf Of PierreGondois
via Groups.Io
Sent: 30 October 2019 02:17 PM
To: devel@edk2.groups.io
Cc: Pierre Gondois ;
michael.d.kin...@intel.comliming.gao@intel.comsami.muja...@arm.com; nd
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-Original Message-
From: Krzysztof Koch
Sent: 12 November 2019 02:40 PM
To: devel@edk2.groups.io
Cc: ray...@intel.com; zhichao@intel.com; Matteo Carlini
; Sami Mujawar ; nd
Subject: [PATCH v2 1/1] ShellPkg: acpiview: Update SRAT
at:
https://github.com/samimujawar/edk2/tree/700_armplatformpkg_fix_missing_header_warning_v1
Sami Mujawar (2):
ArmPlatformPkg: PL061: Minor section alignment
ArmPlatformPkg: Fix 'missing header' warnings
ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf | 3
The Basetools scripts have been updated to report
warnings if header files are not listed in the
[Sources] section of the inf files.
Update the inf files to include the respective
header files to fix the reported warnings.
Signed-off-by: Sami Mujawar
---
Notes:
v1:
- Fix missing
Minor update to add an empty line before start of the
sources section.
Signed-off-by: Sami Mujawar
---
Notes:
v1:
- Added an empty line before the 'sources' section. [SAMI]
ArmPlatformPkg/Drivers/PL061GpioDxe/PL061GpioDxe.inf | 3 ++-
1 file changed, 2 insertions(+), 1
The Basetools scripts have been updated to report
warnings if header files are not listed in the
[Sources] section of the inf files.
Update the inf files to include the respective
header files to fix the reported warnings.
Signed-off-by: Sami Mujawar
---
The changes can be seen at:
https
Add the DISABLE_NEW_DEPRECATED_INTERFACES macro to
the StandaloneMmPkg package build flags to disable
deprecated APIs.
CC: Achin Gupta
CC: Jiewen Yao
CC: Supreeth Venkatesh
Signed-off-by: Sami Mujawar
---
The changes can be seen at:
https://github.com/samimujawar/edk2/tree
SUPPORTED_ARCHITECTURES, until support for the
respective architectures is merged into StandaloneMmPkg.
CC: Achin Gupta
CC: Jiewen Yao
CC: Supreeth Venkatesh
CC: Laszlo Ersek
Signed-off-by: Sami Mujawar
---
The changes can be seen at:
https://github.com/samimujawar/edk2/tree
The Basetools scripts have been updated to report
warnings if header files are not listed in the
[Sources] section of the inf files.
Update the inf files to include the respective
header files to fix the reported warnings.
CC: Alexei Fedorov
Signed-off-by: Sami Mujawar
---
The changes can
Update FADT table generator to support ACPI revision 6.3
CC: Alexei Fedorov
Signed-off-by: Sami Mujawar
---
The changes can be seen at:
https://github.com/samimujawar/edk2/tree/623_dynamictables_acpi6_3_fadt_v1
Notes:
v1:
- Update FADT table version to ACPI 6.3
. PMCG - added page 1 support.
CC: Ray Ni
CC: Zhichao Gao
Signed-off-by: Sami Mujawar
---
The changes can be seen at:
https://github.com/samimujawar/edk2/tree/667_acpiview_iort_rev_c_v1
Notes:
v1:
- Update parser to support IORT specification Rev D updates [SAMI]
ShellPkg/Library
-by: Sami Mujawar
---
The changes can be seen at:
https://github.com/samimujawar/edk2/tree/696_stmm_fix_include_warning_v1
Notes:
v1:
- Fix missing header warnings [SAMI]
StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf | 3 ++-
1 file
://developer.arm.com/tools-and-software/open-source-software/developer-tools/gnu-toolchain/gnu-a/downloads
So, it looks like the problem you mention may have something to do with the
toolchain shipped with Yocto.
Regards,
Sami Mujawar
-Original Message-
From: Ard Biesheuvel
Sent: 11 December 2019
Hi Vladimir,
Please find may response marked [SAMI]
Regards,
Sami Mujawar
-Original Message-
From: Vladimir Olovyannikov
Sent: 12 December 2019 05:51 PM
To: Sami Mujawar ; Ard Biesheuvel
Cc: devel@edk2.groups.io; nd
Subject: RE: Debugging aarch64 edk2 built with gcc-8.x 64-bit arm
Tested on Juno R2, the MAC address for Marvel Yukon NIC is programmed correctly.
Tested-by: Sami Mujawar
Regards,
Sami Mujawar
-Original Message-
From: Leif Lindholm
Sent: 06 December 2019 11:13 AM
To: Ard Biesheuvel
Cc: devel@edk2.groups.io; Sami Mujawar ; Laszlo Ersek
Subject: Re
Signed-off-by: Sami Mujawar
Regards,
Sami Mujawar
-Original Message-
From: Ard Biesheuvel
Sent: 06 December 2019 03:29 PM
To: devel@edk2.groups.io
Cc: leif.lindh...@linaro.org; af...@apple.com; ler...@redhat.com;
michael.d.kin...@intel.com; Ard Biesheuvel ; Achin
Gupta ; Sami
Hi Ard,
Sincere Apologies. I just realised I should have replied with a Reviewed by.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-Original Message-
From: Sami Mujawar
Sent: 06 December 2019 03:56 PM
To: Ard Biesheuvel ; devel@edk2.groups.io
Cc: leif.lindh...@linaro.org; af
of the Configuration Manager
Objects.
Signed-off-by: Sami Mujawar
---
The changes can be seen at
https://github.com/samimujawar/edk2/tree/672_dynamic_tables_srat_generator_v1
Notes:
v1:
- Added support for SRAT table generation using Dynamic Tables[SAMI]
DynamicTablesPkg
Pushed as : 61bb6eeb4d93..91f98c908627
Thanks.
Regards,
Sami Mujawar
-Original Message-
From: Ard Biesheuvel
Sent: 15 October 2019 12:08 PM
To: devel@edk2.groups.io
Cc: ler...@redhat.com; Sami Mujawar ;
leif.lindh...@linaro.org; Ard Biesheuvel
Subject: [PATCH 1/1] DynamicTablesPkg
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-Original Message-
From: Krzysztof Koch
Sent: 12 June 2019 03:10 PM
To: devel@edk2.groups.io
Cc: jaben.car...@intel.com; ray...@intel.com; zhichao@intel.com;
michael.d.kin...@intel.com; liming@intel.com; Sami Mujawar
; Matteo
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-Original Message-
From: Ard Biesheuvel
Sent: 15 October 2019 12:08 PM
To: devel@edk2.groups.io
Cc: ler...@redhat.com; Sami Mujawar ;
leif.lindh...@linaro.org; Ard Biesheuvel
Subject: [PATCH 1/1] DynamicTablesPkg: include ARM
. PMCG - added page 1 support.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Sami Mujawar
---
The changes can be seen at:
https://github.com/samimujawar/edk2/tree/667_acpiview_iort_rev_c_v1
Notes:
v2:
- Fixed patch check failure in commit message,[SAMI]
changed 'CC
-by: Sami Mujawar
---
The changes can be seen at:
https://github.com/samimujawar/edk2/tree/696_stmm_fix_include_warning_v1
Notes:
v2:
- Fixed patch check failure in commit message,[SAMI]
changed 'CC' to 'Cc'. No code change.
v1:
- Fix missing header
before invoking
the FACS parser.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Sami Mujawar
---
The changes can be seen at:
https://github.com/samimujawar/edk2/tree/656_acpiview_facs_parser_v1
Notes:
v2:
- Fixed patch check failure in commit message,[SAMI
Update FADT table generator to support ACPI revision 6.3
Cc: Alexei Fedorov
Signed-off-by: Sami Mujawar
---
The changes can be seen at:
https://github.com/samimujawar/edk2/tree/623_dynamictables_acpi6_3_fadt_v1
Notes:
v2:
- Fixed patch check failure in commit message
The Basetools scripts have been updated to report
warnings if header files are not listed in the
[Sources] section of the inf files.
Update the inf files to include the respective
header files to fix the reported warnings.
Cc: Alexei Fedorov
Signed-off-by: Sami Mujawar
---
The changes can
SUPPORTED_ARCHITECTURES, until support for the
respective architectures is merged into StandaloneMmPkg.
Cc: Achin Gupta
Cc: Jiewen Yao
Cc: Supreeth Venkatesh
Cc: Laszlo Ersek
Signed-off-by: Sami Mujawar
---
The changes can be seen at:
https://github.com/samimujawar/edk2/tree
Hi Philippe,
Apologies, I missed #28 from Laszlo's guide.
This patch has also received a r-b from:
Reviewed-by: jiewen@intel.com
Regards,
Sami Mujawar
-Original Message-
From: Philippe Mathieu-Daudé
Sent: 25 November 2019 10:48 AM
To: devel@edk2.groups.io; Sami Mujawar
Cc
Apologies, I missed #28 'Pick up the tags that you got on the list', from
Laszlo's guide.
This patch has also received a Reviewed-by from:
Reviewed-by: jiewen@intel.com
Reviewed-by: Laszlo Ersek
Regards,
Sami Mujawar
-Original Message-
From: Sami Mujawar
Sent: 25
before invoking
the FACS parser.
CC: Ray Ni
CC: Zhichao Gao
Signed-off-by: Sami Mujawar
---
The changes can be seen at:
https://github.com/samimujawar/edk2/tree/656_acpiview_facs_parser_v1
Notes:
v1:
- Add support for parsing FACS table [SAMI]
ShellPkg
) that reads the AML file and dumps the blob in a C array.
If preferred, we can post a patch that adds this support so that we don’t have
to rely on intermediate outputs of asl compilers.
Alternatively, we would be grateful if you can any suggest another option.
Regards,
Sami Mujawar
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-Original Message-
From: Krzysztof Koch
Sent: 30 January 2020 11:14
To: devel@edk2.groups.io
Cc: michael.d.kin...@intel.com; liming@intel.com; Matteo Carlini
; Sami Mujawar ; nd
Subject: [PATCH v1 1/1] MdePkg: Add PCCT table
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-Original Message-
From: Krzysztof Koch
Sent: 30 January 2020 11:43
To: devel@edk2.groups.io
Cc: ray...@intel.com; zhichao@intel.com; Matteo Carlini
; Sami Mujawar ; nd
Subject: [PATCH v1 1/1] ShellPkg: acpiview: Remove duplicate
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-Original Message-
From: Krzysztof Koch
Sent: 30 January 2020 16:20
To: devel@edk2.groups.io
Cc: ray...@intel.com; zhichao@intel.com; Matteo Carlini
; Sami Mujawar ; nd
Subject: [PATCH v1 1/1] ShellPkg: acpiview: Validate ACPI
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-Original Message-
From: Krzysztof Koch
Sent: 14 February 2020 13:59
To: devel@edk2.groups.io
Cc: ray...@intel.com; zhichao@intel.com; Sami Mujawar
; Matteo Carlini ; nd
Subject: [PATCH v1 1/1] ShellPkg: acpiview: Prevent
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#53056): https://edk2.groups.io/g/devel/message/53056
Mute This Topic: https://groups.io/mt/69576071/21656
Group Owner: devel+ow...@edk2
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#57187): https://edk2.groups.io/g/devel/message/57187
Mute This Topic: https://groups.io/mt/72648021/21656
Group Owner: devel+ow...@edk2
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#57303): https://edk2.groups.io/g/devel/message/57303
Mute This Topic: https://groups.io/mt/72923682/21656
Group Owner: devel+ow...@edk2
the specification.
Regards,
Sami Mujawar
-Original Message-
From: devel@edk2.groups.io On Behalf Of Rothman, Michael
A via groups.io
Sent: 20 April 2020 10:05 PM
To: devel@edk2.groups.io; rebe...@bsdio.com
Cc: Ni, Ray ; Gao, Zhichao
Subject: Re: [edk2-devel] ShellPkg: acpiview command doesn't
For this patch series.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-Original Message-
From: Krzysztof Koch
Sent: 25 March 2020 09:39 AM
To: devel@edk2.groups.io
Cc: ray...@intel.com; zhichao@intel.com; Sami Mujawar
; Matteo Carlini ; Laura Moretta
; nd
Subject: [PATCH v1
is the first argument to
RunAxfPivot(), which is expected to be the entry
point address; RunAxfPivot() would end up branching
to an invalid address resulting in a crash.
Therefore, initialize StartElf to the entry point
address before calling RunAxfPivot().
Signed-off-by: Sami Mujawar
removed
from the project.
Therefore, remove the deprecated 'Gm' Visual Studio
Compiler option.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2660
Signed-off-by: Sami Mujawar
---
The changes can be seen at:
https://github.com/samimujawar/edk2/tree/703_vs2017_deprecated_option_v1
Notes:
V1
://github.com/samimujawar/edk2/tree/503_vs2017_compile_issue_v2
Sami Mujawar (16):
DynamicTablesPkg: Fix entry point param definition
DynamicTablesPkg: Fix missing local header warning
DynamicTablesPkg: Remove struct CM_ARM_CPU_INFO
DynamicTablesPkg: Fix serial port subtype warning
it compatible with the formal declaration.
Signed-off-by: Sami Mujawar
---
The changes can be seen at:
https://github.com/samimujawar/edk2/tree/702_srat_vs2017_compile_warning_v2
Notes:
V2:
- Update commit message to reflect the update to the CONST [SAMI]
qualifier at 2 places
1 - 100 of 1649 matches
Mail list logo
