Reviewed-by: Siyuan Fu for NetworkPkg
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#38607): https://edk2.groups.io/g/devel/message/38607
Mute This Topic: https://groups.io/mt/30887153/21656
Group Owner: devel+ow...@edk2.groups.io
All,
You might notice that some activities about reducing edk2 repo happened or are
happening.
I propose to remove the IpSecDxe driver from NetworkPkg. Anyone who wants to
use IpSecDxe can fetch it from stable tag
https://github.com/tianocore/edk2/releases/tag/edk2-stable201903
If you have
Bugzilla created for this
https://github.com/tianocore/edk2/releases/tag/edk2-stable201903
BestRegards
Fu Siyuan
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Siyuan, Fu
Sent: Thursday, April 11, 2019 6:39 PM
To: devel@edk2.groups.io
Cc: Wu, Jiaxin ; Gao, Liming
Subject
Bugzilla created for this https://bugzilla.tianocore.org/show_bug.cgi?id=1697
BestRegards
Fu Siyuan
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Siyuan, Fu
Sent: Thursday, April 11, 2019 6:39 PM
To: devel@edk2.groups.io
Cc: Wu, Jiaxin ; Gao, Liming
Subject: [edk2-devel
Hi, Shengfeng
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Xue,
> ShengfengX
> Sent: Monday, April 15, 2019 4:14 PM
> To: devel@edk2.groups.io
> Cc: Xue; Xue, ShengfengX
> Subject: [edk2-devel] [PATCH] Edk2\NetworkPkg\UefiPxeBcDxe : Open a
Hi, Shengfeng
I gave 4 review comments to your V1 patch, but you only fixed the patch
description.
Also, an updated patch should be prefixed with [PATCH v2]
BestRegards
Fu Siyuan
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Xue,
>
Reviewed-by: Siyuan Fu
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Xue,
> ShengfengX
> Sent: Thursday, April 18, 2019 6:13 PM
> To: devel@edk2.groups.io
> Cc: Xue, ShengfengX ; Fu, Siyuan
> ; Wu, Jiaxin
> Subject
ing
mailto:liming@intel.com>>
Subject: RE: [RFC] Propose to remove IpSecDxe
Bugzilla created for this https://bugzilla.tianocore.org/show_bug.cgi?id=1697
BestRegards
Fu Siyuan
From: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
[mailto:devel@edk2.groups.io] On Behalf Of Siyua
:devel@edk2.groups.io>
[mailto:devel@edk2.groups.io] On Behalf Of Siyuan, Fu
Sent: Thursday, April 11, 2019 6:39 PM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Wu, Jiaxin mailto:jiaxin...@intel.com>>; Gao, Liming
mailto:liming@intel.com>>
Subject: [edk2-devel]
Hi, Fan
The patch is good with me. Below line is not needed in current EDK2 development.
Contributed-under: TianoCore Contribution Agreement 1.1
Reviewed-by: Siyuan Fu
> -Original Message-
> From: Wang, Fan
> Sent: Tuesday, April 23, 2019 11:17 AM
> To: devel@ed
Reviewed-by: Siyuan Fu
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Xue,
> ShengfengX
> Sent: Monday, April 29, 2019 1:56 PM
> To: devel@edk2.groups.io
> Cc: Xue, ShengfengX ; Fu, Siyuan
> ; Wu, Jiaxin
> Subj
Comments for Laszlo's question (11).
> -Original Message-
> From: Gao, Liming
> Sent: Sunday, May 5, 2019 11:22 PM
> To: Laszlo Ersek ; devel@edk2.groups.io
> Cc: Wu, Jiaxin ; Ye, Ting ; Fu, Siyuan
>
> Subject: RE: [edk2-devel] [Patch v3 2/3] NetworkPkg: Add DSC/FDF include
> segment
Reviewed-by: Siyuan Fu
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Liming
> Gao
> Sent: Tuesday, May 7, 2019 10:27 PM
> To: devel@edk2.groups.io
> Cc: Wu, Jiaxin ; Ye, Ting ; Fu, Siyuan
>
> Subject: [edk2-devel] [
Reviewed-by: Siyuan Fu
> -Original Message-
> From: Zhang, Shenglei
> Sent: 2019年8月12日 16:37
> To: devel@edk2.groups.io
> Cc: Fu, Siyuan ; Wu, Jiaxin
> Subject: [PATCH 1/3] NetworkPkg: Add Dpc protocol
>
> To move Dpc.h from MdeModulePkg to NetworkPkg,
> we
Hi, Siva
The 10ms interval was chosen just by experience. This background polling
intends to pick up the coming request (e.g. ARP request) when there is no
active polling from upper layer. The ARP time out is 1 second, so using 10ms
background polling make the network stack able to receive ARP
Reviewed-by: Siyuan Fu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Liming
> Gao
> Sent: 2019年9月17日 10:59
> To: devel@edk2.groups.io
> Cc: Fu, Siyuan ; Wu, Jiaxin ;
> Wang, Jian J ; Wu, Hao A
> Subject: [edk2-devel] [Patch 0/6] Clean up Netwo
Reviewed-by: Siyuan Fu
> -Original Message-
> From: Leif Lindholm
> Sent: 2019年9月19日 6:43
> To: devel@edk2.groups.io
> Cc: Fu, Siyuan ; Wu, Jiaxin
> Subject: [PATCH 3/9] NetworkPkg: add missing newline at end of file
>
> Add missing newline at end of WifiC
Hi, Siva
We don’t have plan for that so far.
Best Regards
Siyuan
From: Sivaraman Nainar
Sent: 2019年9月25日 18:16
To: devel@edk2.groups.io
Cc: Wu, Jiaxin ; Fu, Siyuan ; Arun
Subramanian B
Subject: reg: Redfish Package in Main Branch
Hello,
May we know when the RestEx driver will be available
Reviewed-by: Siyuan Fu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Laszlo
> Ersek
> Sent: 2019年9月18日 3:49
> To: edk2-devel-groups-io
> Cc: Wu, Jiaxin ; Fu, Siyuan
> Subject: [edk2-devel] [PATCH 21/35] NetworkPkg/TcpDxe: fix SockFreeF
Reviewed-by: Siyuan Fu
> -Original Message-
> From: Philippe Mathieu-Daudé
> Sent: 2019年9月24日 0:04
> To: devel@edk2.groups.io; ler...@redhat.com
> Cc: Wu, Jiaxin ; Fu, Siyuan
> Subject: Re: [edk2-devel] [PATCH 20/35] NetworkPkg/Ip4Dxe: fix
> NetLibDestroyServiceC
Reviewed-by: Siyuan Fu
> -Original Message-
> From: Rabeda, Maciej
> Sent: 2019年10月14日 20:37
> To: devel@edk2.groups.io
> Cc: Fu, Siyuan ; Wu, Jiaxin
> Subject: [PATCH v2 1/1] NetworkPkg/SnpDxe: Remove ExitBootServices
> event
>
> Patch address
Signed-off-by: Siyuan Fu
---
NetworkPkg/SnpDxe/Snp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/NetworkPkg/SnpDxe/Snp.c b/NetworkPkg/SnpDxe/Snp.c
index 9fb007f7ae..1099dbfa6a 100644
--- a/NetworkPkg/SnpDxe/Snp.c
+++ b/NetworkPkg/SnpDxe/Snp.c
@@ -647,7 +647,7
Reviewed-by: Siyuan Fu
> -Original Message-
> From: Maciej Rabeda
> Sent: 2019年11月28日 22:46
> To: devel@edk2.groups.io
> Cc: Wu, Jiaxin ; Fu, Siyuan
> Subject: [PATCH v1 1/1] NetworkPkg: Fixes to static code analysis hits
>
> Introducing fixes to memor
We have no such plan so far.
在 2019年9月25日，18:16，Sivaraman Nainar 写道：
Hello,
May we know when the RestEx driver will be available in EDK2 Master Branch.
https://github.com/tianocore/edk2-staging/tree/UEFI_Redfish/RedfishPkg/RestExDxe
-Siva
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You
Just return from vacation. Sorry for late response.
Reviewed-by: Siyuan Fu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Philippe
> Mathieu-Daudé
> Sent: 2019年9月24日 19:00
> To: devel@edk2.groups.io; ler...@redhat.com
> Cc: Wu, Jiaxin ; Fu, Siyuan
&g
tification function in SNP
> > only calls UNDI->Shutdown() and Stop() functions, there is no need
> > to create this event at all.
> >
> > Signed-off-by: Maciej Rabeda
> > Cc: Siyuan Fu
> > Cc: Jiaxin Wu
> > ---
> > NetworkPkg/SnpDxe/Snp.c
ExitBootServices stage, drivers should not call any
> >>> functions known to use Memory Allocation Services. One of such
> >>> functions (as per UEFI spec) is UNDI->Shutdown().
> >>>
> >>> Since UNDI drivers during ExitBootServices phase
> -Original Message-
> From: Laszlo Ersek
> Sent: 2019年10月11日 0:06
> To: Fu, Siyuan ; devel@edk2.groups.io; Rabeda,
> Maciej
> Cc: Wu, Jiaxin
> Subject: Re: [edk2-devel] [PATCH v1 1/1] NetworkPkg/SnpDxe: Remove
> ExitBootServices event
>
> On 10/10/19 11:29, Fu, Siyuan wrote:
> >>
e is no need to interface UNDI by SNP driver during
> that phase.
>
> Finally, since ExitBootServices event notification function in SNP
> only calls UNDI->Shutdown() and Stop() functions, there is no need
> to create this event at all.
>
> Signed-off-by: Maciej Rabeda
&
ailed to be allocated space.
> ReturnStatus should be EFI_OUT_OF_RESOURCES regardless of the
> content of mDpcEntryFreeList.
>
> Cc: Siyuan Fu
> Cc: Jiaxin Wu
> Signed-off-by: Shenglei Zhang
> ---
> NetworkPkg/DpcDxe/Dpc.c | 9 +++--
> 1 file changed, 3 insertions(
Reviewed-by: Siyuan Fu
> -Original Message-
> From: Zhang, Shenglei
> Sent: 2019年10月12日 15:43
> To: devel@edk2.groups.io
> Cc: Fu, Siyuan ; Wu, Jiaxin
> Subject: [PATCH] NetworkPkg/DxeNetLib: Change the order of conditions in
> IF statement
>
> The cond
=2449
Cc: Ray Ni
Cc: Rangasai V Chaganty
Signed-off-by: Siyuan Fu
---
.../ShadowMicrocode/ShadowMicrocodePei.c | 387 ++
.../ShadowMicrocode/ShadowMicrocodePei.h | 62 +++
.../ShadowMicrocode/ShadowMicrocodePei.inf| 44 ++
.../Include/Guid/MicrocodeShadowInfoHob.h
This patch fixes a potential compiler error introduced by commit
b0099a39bd since not all compiler can support empty array member.
BZ: https://tianocore.acgmultimedia.com/show_bug.cgi?id=2449
Cc: Ray Ni
Cc: Rangasai V Chaganty
Signed-off-by: Siyuan Fu
---
.../Intel/IntelSiliconPkg/Include
Acked-by: Siyuan Fu
> -Original Message-
> From: Ni, Ray
> Sent: 2020年2月26日 15:46
> To: Leo Duran ; devel@edk2.groups.io; Wu, Hao A
> ; Fu, Siyuan
> Cc: Dong, Eric ; Laszlo Ersek
> Subject: RE: [PATCH 2/2] UefiCpuPkg: MpInitLib: Exclude code no pertinen
This patch fixes compiler error introduced by commit
b0099a39bd.
BZ: https://tianocore.acgmultimedia.com/show_bug.cgi?id=2449
Cc: Ray Ni
Cc: Rangasai V Chaganty
Cc: Liming Gao
Signed-off-by: Siyuan Fu
---
.../Feature/ShadowMicrocode/ShadowMicrocodePei.c| 2 +-
.../Intel
: https://bugzilla.tianocore.org/show_bug.cgi?id=2501
Cc: Hao A Wu
Cc: Liming Gao
Signed-off-by: Siyuan Fu
---
MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleService.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/MdeModulePkg/Universal/CapsuleRuntimeDxe
Got it.
Reviewed-by: Siyuan Fu
> -Original Message-
> From: Wu, Hao A
> Sent: 2020年2月3日 9:03
> To: Fu, Siyuan ; devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Laszlo
> Ersek ; Kinney, Michael D
>
> Subject: RE: [edk2-devel] [PATCH v1] UefiCpuPkg/MpIni
process.
>
> This commit will update the logic in MicrocodeDetect() back to always
> collecting the CPUID and PlatformID information explicitly.
>
> Cc: Eric Dong
> Cc: Ray Ni
> Cc: Laszlo Ersek
> Cc: Siyuan Fu
> Cc: Michael D Kinney
> Signed-off-by: Hao A
.
This patch removes this restriction. The change is controled by a feature
PCD PcdSupportProcessCapsuleAtRuntime, and the default value is FALSE
which means not enable this feature.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2501
Cc: Hao A Wu
Cc: Liming Gao
Signed-off-by: Siyuan Fu
Reviewed-by: Siyuan Fu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Wu,
> Jiaxin
> Sent: 2020年2月18日 13:52
> To: devel@edk2.groups.io
> Cc: Fu, Siyuan ; Maciej Rabeda
> ; Wu, Jiaxin
> Subject: [edk2-devel] [PATCH v3] NetworkPkg/Ip4Dxe: Chec
Ni
Cc: Rangasai V Chaganty
Signed-off-by: Siyuan Fu
---
.../ShadowMicrocode/ShadowMicrocodePei.c | 451 ++
.../ShadowMicrocode/ShadowMicrocodePei.inf| 43 ++
.../Include/Guid/MicrocodeShadowInfoHob.h | 64 +++
.../Intel/IntelSiliconPkg/IntelSiliconPkg.dec | 8
Hi, all
I'm sorry that I pushed one of my under working patch to edk2-platforms master
incorrectly (the merge commit afb07da). I have reverted this change and sorry
for the inconvenience caused. Thanks.
Best Regards
Siyuan
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages
Thank you Ray and Laszlo for your comments, I have sent the V2 patch set for
this change.
> -Original Message-
> From: Ni, Ray
> Sent: 2020年2月11日 19:24
> To: Fu, Siyuan ; devel@edk2.groups.io
> Cc: Dong, Eric ; Laszlo Ersek ;
> Kinney, Michael D
> Subject: RE: [Patch 1/2] UefiCpuPkg:
Cc: Laszlo Ersek
Signed-off-by: Siyuan Fu
---
UefiCpuPkg/Include/Ppi/ShadowMicrocode.h | 66 +++
UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 1 -
UefiCpuPkg/Library/MpInitLib/DxeMpLib.c | 21 +++-
UefiCpuPkg/Library/MpInitLib/Microcode.c | 105
the header file added by c7c964b.
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Siyuan Fu
---
.../IndustryStandard/FirmwareInterfaceTable.h | 76 ---
1 file changed, 76 deletions(-)
delete mode 100644 MdePkg/Include/IndustryStandard/FirmwareInterfaceTable.h
diff --git
the%202nd%20Microcode%20FV%20Flash%20Region.pdf
TEST: Tested on FIT enabled platform.
BZ: https://tianocore.acgmultimedia.com/show_bug.cgi?id=2449
Cc: Ray Ni
Cc: Rangasai V Chaganty
Signed-off-by: Siyuan Fu
---
.../ShadowMicrocode/ShadowMicrocodePei.c | 391
/0214/Support%20
the%202nd%20Microcode%20FV%20Flash%20Region.pdf
TEST: Tested on FIT enabled platform.
BZ: https://tianocore.acgmultimedia.com/show_bug.cgi?id=2449
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Signed-off-by: Siyuan Fu
---
UefiCpuPkg/Include/Ppi/ShadowMicrocode.h | 66
Siyuan Fu (2):
UefiCpuPkg: Remove FIT based microcode shadow logic from MpInitLib.
MdePkg: Remove FIT table industry standard header file.
.../IndustryStandard/FirmwareInterfaceTable.h | 76 -
UefiCpuPkg/Include/Ppi/ShadowMicrocode.h | 66 +++
UefiCpuPkg/Library
the header file added by c7c964b.
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Siyuan Fu
---
.../IndustryStandard/FirmwareInterfaceTable.h | 76 ---
1 file changed, 76 deletions(-)
delete mode 100644 MdePkg/Include/IndustryStandard/FirmwareInterfaceTable.h
diff --git
://tianocore.acgmultimedia.com/show_bug.cgi?id=2449
Cc: Ray Ni
Cc: Rangasai V Chaganty
Signed-off-by: Siyuan Fu
---
.../Feature/ShadowMicrocode/ShadowMicrocodePei.c | 4
.../Feature/ShadowMicrocode/ShadowMicrocodePei.inf | 3 +++
Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec
%20Region.pdf
TEST: Tested on FIT enabled platform.
BZ: https://tianocore.acgmultimedia.com/show_bug.cgi?id=2449
Cc: Michael D Kinney
Cc: Ray Ni
Cc: Rangasai V Chaganty
Signed-off-by: Siyuan Fu
---
.../ShadowMicrocode/ShadowMicrocodePei.c | 446 ++
.../ShadowMicrocode
illa.tianocore.org/show_bug.cgi?id=2031
>
> This patch triggers the RecycleEvent for invalid ARP packets.
> Prior to this, we would just ignore invalid ARP packets,
> and never free them.
>
> Cc: Jiaxin Wu
> Cc: Maciej Rabeda
> Cc: Siyuan Fu
> Signed-off-by: Nicholas Armou
> > > > See my reply for the ASSERT and magic number around
> > FIT
> > > > table parsing code.
> > > >
> > > > > -Original Message-
> > > > > From: Kinney, Michael D
> >
> > > > > Sent: 2020年2
gt; File content into the .c file and delete the .h file.
>
> More comments inline below.
>
> Mike
>
> > -Original Message-
> > From: devel@edk2.groups.io On
> > Behalf Of Siyuan, Fu
> > Sent: Tuesday, February 11, 2020 4:48 PM
> > To: deve
t a .h file. Please merge the .h
> File content into the .c file and delete the .h file.
>
> More comments inline below.
>
> Mike
>
> > -Original Message-
> > From: devel@edk2.groups.io On
> > Behalf Of Siyuan, Fu
> > Sent: Tuesday, Feb
://tianocore.acgmultimedia.com/show_bug.cgi?id=2449
Cc: Michael D Kinney
Cc: Ray Ni
Cc: Rangasai V Chaganty
Signed-off-by: Siyuan Fu
---
.../ShadowMicrocode/ShadowMicrocodePei.c | 435 ++
.../ShadowMicrocode/ShadowMicrocodePei.inf| 43 ++
.../Include/Guid/MicrocodeShadowInfoHob.h
yuan,
> > >
> > > IntelSiliconPkg/Feature/ShadowMicrocode:
> > >
> > > For simple modules that only have a single .c file,
> > there
> > > Is not need to split out a .h file. Please merge the
> > .h
> > > File conte
Please change the Copyright year to 2020, with that:
Reviewed-by: Siyuan Fu
> -Original Message-
> From: Armour, Nicholas
> Sent: 2020年2月20日 6:53
> To: devel@edk2.groups.io
> Cc: Armour, Nicholas ; Wu, Jiaxin
> ; Maciej Rabeda ; Fu,
> Siyuan
> Subject: [PATCH v
Reviewed-by: Siyuan Fu
> -Original Message-
> From: Armour, Nicholas
> Sent: 2020年2月20日 8:23
> To: devel@edk2.groups.io
> Cc: Armour, Nicholas ; Wu, Jiaxin
> ; Maciej Rabeda ; Fu,
> Siyuan
> Subject: [PATCH v4 1/1] NetworkPkg/ArpDxe: Recycle invalid ARP p
platform.
BZ: https://tianocore.acgmultimedia.com/show_bug.cgi?id=2449
Cc: Michael D Kinney
Cc: Ray Ni
Cc: Rangasai V Chaganty
Signed-off-by: Siyuan Fu
---
.../ShadowMicrocode/ShadowMicrocodePei.c | 491 ++
.../ShadowMicrocode/ShadowMicrocodePei.inf| 43 ++
.../Include
logic from
MpInitLib.
[Patch 2/2] MdePkg: Remove FIT table industry standard header file.
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Cc: Michael D Kinney
Cc: Liming Gao
Siyuan Fu (2):
UefiCpuPkg: Remove FIT based microcode shadow logic from MpInitLib.
MdePkg: Remove FIT table industry
://tianocore.acgmultimedia.com/show_bug.cgi?id=2449
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Signed-off-by: Siyuan Fu
---
UefiCpuPkg/Include/Ppi/ShadowMicrocode.h | 66 +++
UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 1 -
UefiCpuPkg/Library/MpInitLib/DxeMpLib.c | 26
the header file added by c7c964b.
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Siyuan Fu
---
.../IndustryStandard/FirmwareInterfaceTable.h | 76 ---
1 file changed, 76 deletions(-)
delete mode 100644 MdePkg/Include/IndustryStandard/FirmwareInterfaceTable.h
diff --git
: Tested on FIT enabled platform.
BZ: https://tianocore.acgmultimedia.com/show_bug.cgi?id=2449
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Signed-off-by: Siyuan Fu
---
UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 1 +
UefiCpuPkg/Library/MpInitLib/Microcode.c | 262
://tianocore.acgmultimedia.com/show_bug.cgi?id=2449
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Siyuan Fu
---
.../IndustryStandard/FirmwareInterfaceTable.h | 76 +++
1 file changed, 76 insertions(+)
create mode 100644 MdePkg/Include/IndustryStandard/FirmwareInterfaceTable.h
diff --git a/MdePkg
/2: Update microcode loader to shadow microcode according to FIT.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Cc: Tom Lendacky
Siyuan Fu (2):
MdePkg: Add header file for Firmware Interface Table specification.
UefiCpuPkg: Shadow microcode patch according
The change looks good to me.
Reviewed-by: Siyuan Fu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Laszlo
> Ersek
> Sent: 2020年1月9日 7:43
> To: edk2-devel-groups-io
> Cc: Wu, Hao A ; Wang, Jian J ;
> Ni, Ray ; Gao, Zhichao
> Subject:
Reviewed-by: Siyuan Fu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Laszlo
> Ersek
> Sent: 2020年1月9日 7:43
> To: edk2-devel-groups-io
> Cc: Wu, Jiaxin ; Maciej Rabeda
> ; Fu, Siyuan
> Subject: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDx
: Tested on FIT enabled platform.
BZ: https://tianocore.acgmultimedia.com/show_bug.cgi?id=2449
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Signed-off-by: Siyuan Fu
Reviewed-by: Eric Dong
Reviewed-by: Laszlo Ersek
---
UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 1 +
UefiCpuPkg/Library
Send by misoperation。 This patch has already been merged, pls ignore.
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Siyuan,
> Fu
> Sent: 2020年1月10日 14:38
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Laszlo
> Ersek
> Subject: [edk2-d
Cc: Ray Ni
Cc: Laszlo Ersek
Signed-off-by: Siyuan Fu
---
UefiCpuPkg/Include/Guid/MicrocodePatchHob.h | 12 -
UefiCpuPkg/Library/MpInitLib/Microcode.c| 24 +
UefiCpuPkg/Library/MpInitLib/MpLib.h| 9
UefiCpuPkg/Library/MpInitLib/PeiMpLib.c | 54
://bugzilla.tianocore.org/show_bug.cgi?id=2431
Cc: Eric Dong
Cc: Ray Ni
Signed-off-by: Siyuan Fu
---
UefiCpuPkg/Library/MpInitLib/Microcode.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/UefiCpuPkg/Library/MpInitLib/Microcode.c
b/UefiCpuPkg/Library/MpInitLib/Microcode.c
index
NTN)MicrocodeEntryPoint + TotalSize) > MicrocodeEnd ||
(DataSize & 0x3) != 0 ||
(TotalSize & (SIZE_1KB - 1)) != 0 ||
TotalSize < DataSize
) {
Cc: Eric Dong
Cc: Ray Ni
Cc: Hao A Wu
Signed-off-by: Siyuan Fu
---
UefiCpuPkg/Library/MpInitLib
Hi, Siva
We don’t think this is a real problem. The cert is saved as NV variable just
like any other EFI variables, there are some basic checks like verify it’s a
valid DER-encoded certificate before saving the certificate, and TLS config
driver also provides a page to allow user to delete
Hi, Mike
I met a GCC failure in edk2 CI test for my pull request #275 and I’m not sure
whether it’s a CI test issue or my patch problem. Could you please help to
check it? Thanks
https://github.com/tianocore/edk2/pull/275
Failed jobs: Build_GCC5 TARGET_MDE_CPU/Update apt and Copy base tools
Yes
Best Regards
Siyuan
From: Sivaraman Nainar
Sent: 2019年12月27日 15:26
To: Fu, Siyuan ; devel@edk2.groups.io; Wu, Jiaxin
Cc: Madhan B. Santharam ; Arun Subramanian B
; Arun Sura Soundara Pandian
; Bhuvaneshwari M R ;
Ramesh R.
Subject: RE: HTTPS Certificate Validation During Enrollment
://tianocore.acgmultimedia.com/show_bug.cgi?id=2449
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Siyuan Fu
---
.../IndustryStandard/FirmwareInterfaceTable.h | 76 +++
1 file changed, 76 insertions(+)
create mode 100644 MdePkg/Include/IndustryStandard/FirmwareInterfaceTable.h
diff --git a/MdePkg
Cc: Laszlo Ersek
Signed-off-by: Siyuan Fu
---
UefiCpuPkg/Library/MpInitLib/Microcode.c | 255 +--
UefiCpuPkg/Library/MpInitLib/MpLib.c | 4 +-
UefiCpuPkg/Library/MpInitLib/MpLib.h | 7 +-
3 files changed, 200 insertions(+), 66 deletions(-)
diff --git
: Michael D Kinney
Cc: Liming Gao
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Siyuan Fu (2):
MdePkg: Add header file for Firmware Interface Table specification.
UefiCpuPkg: Shadow microcode patch according to FIT microcode entry.
.../IndustryStandard/FirmwareInterfaceTable.h | 76
to FIT microcode
> table.
>
> (+Tom)
>
> On 01/08/20 05:25, Siyuan Fu wrote:
> > The existing MpInitLib will shadow the microcode update patches from
> > flash to memory and this is done by searching microcode region
> > specified by PCD PcdCpuMicrocodePatchAddres
ode is 0x800 aligned (same as
before).
- Only "-A" means microcode is aligned with specified value (new).
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Siyuan Fu
---
Silicon/Intel/Tools/FitGen/FitGen.c | 35 +++--
1 file changed, 23 insertions(+), 12 deletions(-)
ld be
> accomplished via HII and via OS-present interfaces.
>
> Cc: Jiaxin Wu
> Cc: Siyuan Fu
> Signed-off-by: Maciej Rabeda
> ---
> .../TlsAuthConfigDxe/TlsAuthConfigDxe.inf | 1 +
> .../TlsAuthConfigDxeStrings.uni | 2 ++
> .../TlsAu
Reviewed-by: Siyuan Fu
> -Original Message-
> From: michael.kuba...@outlook.com
> Sent: 2020年4月8日 13:47
> To: devel@edk2.groups.io
> Cc: Fu, Siyuan ; Maciej Rabeda
> ; Wu, Jiaxin
> Subject: [PATCH v1 1/1] NetworkPkg/Ip6Dxe: Validate source data record
> l
Reviewed-by: Siyuan Fu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael
> Kubacki
> Sent: 2020年4月9日 11:02
> To: devel@edk2.groups.io
> Cc: Fu, Siyuan ; Maciej Rabeda
> ; Wu, Jiaxin
> Subject: [edk2-devel] [PATCH v1 1/1] NetworkPkg/SnpDxe: P
Reviewed-by: Siyuan Fu
> -Original Message-
> From: Keysound Chang
> Sent: 2020年4月9日 14:57
> To: devel@edk2.groups.io
> Cc: Keysound Chang ; Wu, Jiaxin
> ; Fu, Siyuan ; Maciej Rabeda
>
> Subject: [PATCH] NetworkPkg/TlsAuthConfigDxe: Use HiiPopUp() instead of
&
Acked-by: Siyuan Fu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chang,
> Abner (HPS SW/FW Technologist)
> Sent: 2020年4月10日 15:28
> To: devel@edk2.groups.io
> Cc: Chang, Abner (HPS SW/FW Technologist) ; Chen,
> Gilbert ; Leif Lindholm ;
>
Maciej/Laszlo,
Sorry I missed this patch. It looks good with me.
Reviewed-by: Siyuan Fu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Laszlo Ersek
> Sent: 2020年3月25日 19:36
> To: Wu, Jiaxin ; Fu, Siyuan
> Cc: devel@edk2.groups.io; maciej.rab...@
Yao, Jiewen
> > > Sent: 2020年3月27日 10:58
> > > To: devel@edk2.groups.io; Fu, Siyuan ; Gao, Zhichao
> > >
> > > Cc: Wang, Jian J ; Lu, XiaoyuX
> > ;
> > > Maciej Rabeda ; Wu, Jiaxin
> > >
> > > Subject: RE: [edk2-devel] [PATCH
t; > > will be static linked to the consumer driver, for example an iSCSI
> > > > network
> > > driver.
> > > > So actually it's not a "private" change inside CryptoPkg.
> > > >
> > > > The goal to provide a driver version of c
Subject: RE: [edk2-devel] [PATCH 0/8] CryptoPkg: Retire the deprecate function
>
> EDKII_CRYPTO_PROTOCOL is *private*.
> https://github.com/tianocore/edk2/blob/master/CryptoPkg/Private/Protocol/C
> rypto.h
>
> Why we cannot change?
>
>
>
> > -----Original Message
Reviewed-by: Siyuan Fu
> -Original Message-
> From: Gao, Zhichao
> Sent: 2020年3月27日 9:56
> To: devel@edk2.groups.io
> Cc: Maciej Rabeda ; Wu, Jiaxin
> ; Fu, Siyuan
> Subject: [PATCH 6/8] NetWorkPkg/Pcd.inc: Enable the MD5 for iSCSI
>
> REF: https://bugzilla
default value to false to indicate they are deprecated.
>
> NetWorkPkg's iSCSI driver would consume the MD5 function, so change
> the md5 pcd to TURE when iSCSI is enabled.
>
> Cc: Jian J Wang
> Cc: Xiaoyu Lu
> Cc: Maciej Rabeda
> Cc: Jiaxin Wu
> Cc: Siyuan Fu
> Signed-off-by:
Reviewed-by: Siyuan Fu
> -Original Message-
> From: michael.kuba...@outlook.com
> Sent: 2020年3月25日 11:00
> To: devel@edk2.groups.io
> Cc: Laszlo Ersek ; Fu, Siyuan ;
> Maciej Rabeda ; Wu, Jiaxin
>
> Subject: [PATCH v2 2/2] Revert "NetworkPkg/TlsAuthConf
Reviewed-by: Siyuan Fu
> -Original Message-
> From: Laszlo Ersek
> Sent: 2020年3月31日 8:48
> To: edk2-devel-groups-io
> Cc: Wu, Jiaxin ; Maciej Rabeda
> ; Philippe Mathieu-Daudé
> ; Fu, Siyuan
> Subject: [PATCH] NetworkPkg/UefiPxeBcDxe: handle competing DHCP ser
Reviewed-by: Siyuan Fu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Laszlo
> Ersek
> Sent: 2020年3月25日 19:34
> To: Ni, Ray ; Gao, Zhichao
> Cc: devel@edk2.groups.io; maciej.rab...@linux.intel.com
> Subject: Re: [edk2-devel] [PATCH v1] ShellPkg: F
t; > >
> > > > Although the protocol is private, a corresponding
> > > BaseCryptoLib instance is
> > > > not private, like PeiCryptLib.inf, RuntimeCryptLib,
> > > etc. These library instances
> > > > will be static linked to the consumer driver,
enssl.org/docs/man1.1.1/man3/EVP_EncryptIni
> > > > > t_ex.html
> > > > > https://www.openssl.org/docs/man1.1.0/man3/EVP_CIPHER_CTX
> > > > > _ctrl.html
> > > > > The cipher itself is input as parameter.
> > > > >
> > &g
With Laszlo's comments.
Reviewed-by: Siyuan Fu
> -Original Message-
> From: Laszlo Ersek
> Sent: 2020年4月1日 20:02
> To: Maciej Rabeda ; devel@edk2.groups.io
> Cc: Wu, Jiaxin ; Fu, Siyuan
> Subject: Re: [PATCH] NetworkPkg/Ip6Dxe: Fix ASSERT logic in
> Ip6ProcessRout
Reviewed-by: Siyuan Fu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Zhang,
> Shenglei
> Sent: 2020年4月24日 17:14
> To: devel@edk2.groups.io
> Cc: Maciej Rabeda ; Wu, Jiaxin
> ; Fu, Siyuan
> Subject: [edk2-devel] [PATCH] NetworkPkg/IScsiDxe: Enhan
gzilla.tianocore.org/show_bug.cgi?id=1898
>
> Update the Crypto Version to 7:
> 1. Retire below deprecated functions:
> MD4, ARC4, TDES, AES ECB MODE, HMAC MD5, HMAC SHA1
>
> Cc: Jian J Wang
> Cc: Xiaoyu Lu
> Cc: Siyuan Fu
> Cc: Michael D Kinney
> Cc: Jiewen Yao
&g
1 - 100 of 110 matches
Mail list logo
