Re: [edk2-devel] [PATCH v4 1/6] edksetup.sh: Use bash variable $PWD instead of executing pwd command
On 07/23/19 00:52, rebe...@bsdio.com wrote: > On 2019-07-22 16:16, Laszlo Ersek wrote: >> >> should we push patches #1 through #4 from this series? >> >> They are independent of python detection (which is still being discussed). > > > I think that's a good idea. Pushed patches #1 through #4 as commit range f6f1e0b7c292..cf2d8d4978e8. Thanks, Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44228): https://edk2.groups.io/g/devel/message/44228 Mute This Topic: https://groups.io/mt/32493796/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v4 1/6] edksetup.sh: Use bash variable $PWD instead of executing pwd command
On 2019-07-22 16:16, Laszlo Ersek wrote: > > should we push patches #1 through #4 from this series? > > They are independent of python detection (which is still being discussed). I think that's a good idea. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44162): https://edk2.groups.io/g/devel/message/44162 Mute This Topic: https://groups.io/mt/32493796/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v4 1/6] edksetup.sh: Use bash variable $PWD instead of executing pwd command
Hi All, On 07/16/19 18:55, rebe...@bsdio.com wrote: > This is a (very minor) optimization: `pwd` runs the command (even as a > built-in), whereas $PWD simply evaluates the value of the variable. > > ALso, modern scripts should generally use $(...) to run commands, > instead of `...`. > > Signed-off-by: Rebecca Cran > Reviewed-by: Laszlo Ersek > Reviewed-by: Leif Lindholm > --- > edksetup.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/edksetup.sh b/edksetup.sh > index 12a3e26a67..ab58fe4a6e 100755 > --- a/edksetup.sh > +++ b/edksetup.sh > @@ -71,7 +71,7 @@ function SetWorkspace() ># ># Set $WORKSPACE ># > - export WORKSPACE=`pwd` > + export WORKSPACE=$PWD >return 0 > } > > should we push patches #1 through #4 from this series? They are independent of python detection (which is still being discussed). Thanks Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44160): https://edk2.groups.io/g/devel/message/44160 Mute This Topic: https://groups.io/mt/32493796/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v4 1/6] edksetup.sh: Use bash variable $PWD instead of executing pwd command
Rebecca: The change is good. Reviewed-by: Liming Gao for 1-4, and 6. For patch 5, I see Leif sends another version update. I will give the comments on his change. Thanks Liming > -Original Message- > From: Rebecca Cran [mailto:rebe...@bsdio.com] > Sent: Wednesday, July 17, 2019 12:56 AM > To: devel@edk2.groups.io; ler...@redhat.com; Feng, Bob C > ; Gao, Liming ; Kinney, > Michael D ; af...@apple.com; Fan, ZhijuX > ; leif.lindh...@linaro.org > Cc: Rebecca Cran > Subject: [PATCH v4 1/6] edksetup.sh: Use bash variable $PWD instead of > executing pwd command > > This is a (very minor) optimization: `pwd` runs the command (even as a > built-in), whereas $PWD simply evaluates the value of the variable. > > ALso, modern scripts should generally use $(...) to run commands, > instead of `...`. > > Signed-off-by: Rebecca Cran > Reviewed-by: Laszlo Ersek > Reviewed-by: Leif Lindholm > --- > edksetup.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/edksetup.sh b/edksetup.sh > index 12a3e26a67..ab58fe4a6e 100755 > --- a/edksetup.sh > +++ b/edksetup.sh > @@ -71,7 +71,7 @@ function SetWorkspace() ># ># Set $WORKSPACE ># > - export WORKSPACE=`pwd` > + export WORKSPACE=$PWD >return 0 > } > > -- > 2.22.0 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43834): https://edk2.groups.io/g/devel/message/43834 Mute This Topic: https://groups.io/mt/32493796/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
