Re: [Guidelines Change] Change to the Packaging Guidelines

2012-08-08 Thread Garrett Holmstrom
On 2012-08-07 10:35, Lennart Poettering wrote: On Tue, 07.08.12 13:31, Gary Gatling (gsgat...@ncsu.edu) wrote: Question about new systemd policy, If your package is under review, and it enables its service by default, do you add it to the bugzilla of the systemd package or would that be one of

Re: [Guidelines Change] Change to the Packaging Guidelines

2012-08-08 Thread Petr Pisar
On 2012-08-07, Lennart Poettering mzerq...@0pointer.de wrote: For services which should not be restarted on upgrade (D-Bus, ...) we should recommend this: %postun %{systemd_postun} Current wiki text is: %post %{systemd_postun} Is this s/postun/post/ intentional? -- Petr -- devel

Re: [Guidelines Change] Change to the Packaging Guidelines

2012-08-08 Thread Tom Callaway
On 08/08/2012 06:10 AM, Petr Pisar wrote: On 2012-08-07, Lennart Poettering mzerq...@0pointer.de wrote: For services which should not be restarted on upgrade (D-Bus, ...) we should recommend this: %postun %{systemd_postun} Current wiki text is: %post %{systemd_postun} Is this

Re: [Guidelines Change] Change to the Packaging Guidelines

2012-08-08 Thread Lennart Poettering
On Wed, 08.08.12 00:17, Garrett Holmstrom (gho...@fedoraproject.org) wrote: On 2012-08-07 10:35, Lennart Poettering wrote: On Tue, 07.08.12 13:31, Gary Gatling (gsgat...@ncsu.edu) wrote: Question about new systemd policy, If your package is under review, and it enables its service by

Re: [Guidelines Change] Change to the Packaging Guidelines

2012-08-08 Thread Miloslav Trmač
On Wed, Aug 8, 2012 at 5:57 PM, Lennart Poettering mzerq...@0pointer.de wrote: Note that there are actually three kinds of services in my eyes: 1) Services that are not enabled after package installation 2) Services that are enabled after package installation 3) Services that static, i.e.

Re: [Guidelines Change] Change to the Packaging Guidelines

2012-08-08 Thread Garrett Holmstrom
On Wed, Aug 8, 2012 at 8:57 AM, Lennart Poettering mzerq...@0pointer.de wrote: On Wed, 08.08.12 00:17, Garrett Holmstrom (gho...@fedoraproject.org) wrote: I maintain a package (cloud-init) with several services that meet the runs once then goes away grant. Shall I file a bug against the

Re: [Guidelines Change] Change to the Packaging Guidelines

2012-08-08 Thread Lennart Poettering
On Wed, 08.08.12 12:16, Garrett Holmstrom (gho...@fedoraproject.org) wrote: On Wed, Aug 8, 2012 at 8:57 AM, Lennart Poettering mzerq...@0pointer.de wrote: On Wed, 08.08.12 00:17, Garrett Holmstrom (gho...@fedoraproject.org) wrote: I maintain a package (cloud-init) with several services

Re: [Guidelines Change] Change to the Packaging Guidelines

2012-08-07 Thread Tom Hughes
On 07/08/12 17:41, Tom Callaway wrote: The systemd scriptlet guidelines have been updated for Fedora 18. In Fedora 18, the systemd package now provides helper macros to simplify %post, %preun, and %postun invocations in packages with systemd unit files. Additionally, these macros enable support

Re: [Guidelines Change] Change to the Packaging Guidelines

2012-08-07 Thread Lennart Poettering
On Tue, 07.08.12 17:55, Tom Hughes (t...@compton.nu) wrote: On 07/08/12 17:41, Tom Callaway wrote: The systemd scriptlet guidelines have been updated for Fedora 18. In Fedora 18, the systemd package now provides helper macros to simplify %post, %preun, and %postun invocations in packages

Re: [Guidelines Change] Change to the Packaging Guidelines

2012-08-07 Thread Tom Callaway
On 08/07/2012 12:55 PM, Tom Hughes wrote: On 07/08/12 17:41, Tom Callaway wrote: The systemd scriptlet guidelines have been updated for Fedora 18. In Fedora 18, the systemd package now provides helper macros to simplify %post, %preun, and %postun invocations in packages with systemd unit

Re: [Guidelines Change] Change to the Packaging Guidelines

2012-08-07 Thread Tom Callaway
On 08/07/2012 01:07 PM, Lennart Poettering wrote: Spot, may I suggest adding a short paragraph about this to the guidelines? Of course, although even more valuable would be a diff from the existing guidelines. ~tom == Fedora Project -- devel mailing list devel@lists.fedoraproject.org

Re: [Guidelines Change] Change to the Packaging Guidelines

2012-08-07 Thread Tom Hughes
On 07/08/12 18:11, Tom Callaway wrote: On 08/07/2012 12:55 PM, Tom Hughes wrote: The postun macros look wrong - as written the guidelines will result in a service that is not enabled by default not being restarted on upgrade which is a change from the current behaviour. You're right. I've

Re: [Guidelines Change] Change to the Packaging Guidelines

2012-08-07 Thread Lennart Poettering
On Tue, 07.08.12 13:12, Tom Callaway (tcall...@redhat.com) wrote: On 08/07/2012 01:07 PM, Lennart Poettering wrote: Spot, may I suggest adding a short paragraph about this to the guidelines? Of course, although even more valuable would be a diff from the existing guidelines. Ok, what

Re: [Guidelines Change] Change to the Packaging Guidelines

2012-08-07 Thread Gary Gatling
On Tue, Aug 7, 2012 at 1:18 PM, Lennart Poettering mzerq...@0pointer.dewrote: Ok, what about this: If your package includes one or more systemd units that shall be enabled by default on package installation, they need to be listed in the default Fedora preset policy. [[

Re: [Guidelines Change] Change to the Packaging Guidelines

2012-08-07 Thread Tom Callaway
On 08/07/2012 01:29 PM, Lennart Poettering wrote: For services which should not be restarted on upgrade (D-Bus, ...) we should recommend this: %postun %{systemd_postun} and for services which should be restarted on upgrade, we should recommend this: %postun

Re: [Guidelines Change] Change to the Packaging Guidelines

2012-08-07 Thread Lennart Poettering
On Tue, 07.08.12 13:36, Tom Callaway (tcall...@redhat.com) wrote: On 08/07/2012 01:29 PM, Lennart Poettering wrote: For services which should not be restarted on upgrade (D-Bus, ...) we should recommend this: %postun %{systemd_postun} and for services which should be restarted

Re: [Guidelines Change] Change to the Packaging Guidelines

2012-08-07 Thread Lennart Poettering
On Tue, 07.08.12 17:35, Jóhann B. Guðmundsson (johan...@gmail.com) wrote: On 08/07/2012 05:18 PM, Lennart Poettering wrote: Ok, what about this: If your package includes one or more systemd units that shall be enabled by default on package installation, they need to be listed in the

Re: [Guidelines Change] Change to the Packaging Guidelines

2012-08-07 Thread Bill Nottingham
Lennart Poettering (mzerq...@0pointer.de) said: On Tue, 07.08.12 13:36, Tom Callaway (tcall...@redhat.com) wrote: On 08/07/2012 01:29 PM, Lennart Poettering wrote: For services which should not be restarted on upgrade (D-Bus, ...) we should recommend this: %postun

Re: [Guidelines Change] Change to the Packaging Guidelines

2012-08-07 Thread Gary Gatling
On Tue, Aug 7, 2012 at 1:35 PM, Lennart Poettering mzerq...@0pointer.dewrote: To enable a service by default after package installation you need permission from FESCO. See the last line of: https://fedoraproject.org/wiki/Starting_services_by_default If you have permission from FESCO then I

Re: [Guidelines Change] Change to the Packaging Guidelines

2012-08-07 Thread Miloslav Trmač
On Tue, Aug 7, 2012 at 7:48 PM, Gary Gatling gsgat...@ncsu.edu wrote: On Tue, Aug 7, 2012 at 1:35 PM, Lennart Poettering mzerq...@0pointer.de wrote: To enable a service by default after package installation you need permission from FESCO. See the last line of:

Re: [Guidelines Change] Change to the Packaging Guidelines

2012-08-07 Thread Gary Gatling
On Tue, Aug 7, 2012 at 2:20 PM, Miloslav Trmač m...@volny.cz wrote: Note that a package doesn't necessarily have to be explicitly listed on the wiki page to be enabled by default, the page starts with two general rules, the first being the most general one: If a service does not require