Re: Critpath karma

2018-03-07 Thread Adam Williamson
On Wed, 2018-03-07 at 14:43 -0500, Randy Barlow wrote: > On 03/06/2018 07:20 PM, Adam Williamson wrote: > > Removing it is one choice, sure. Looking at those ideas again and > > deciding if we want to actually go ahead and implement any of them is > > another choice. > > Cool thanks for the histor

Re: Critpath karma

2018-03-07 Thread Randy Barlow
On 03/06/2018 07:20 PM, Adam Williamson wrote: > Removing it is one choice, sure. Looking at those ideas again and > deciding if we want to actually go ahead and implement any of them is > another choice. Cool thanks for the history there. I actually think those ideas sound pretty cool and I'd +1

Re: Critpath karma

2018-03-07 Thread Adam Williamson
On Wed, 2018-03-07 at 08:50 +, Zbigniew Jędrzejewski-Szmek wrote: > On Tue, Mar 06, 2018 at 04:20:26PM -0800, Adam Williamson wrote: > > 1. Any update that is marked as 'critpath breaking' by a FAS-registered > > tester would be blocked from going any further in the update process > > without

Re: Critpath karma

2018-03-07 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Mar 06, 2018 at 04:20:26PM -0800, Adam Williamson wrote: > 1. Any update that is marked as 'critpath breaking' by a FAS-registered > tester would be blocked from going any further in the update process > without manual intervention (no autopushes at all) IIRC, that happens with all update

Re: Critpath karma

2018-03-06 Thread Adam Williamson
On Tue, 2018-03-06 at 08:48 -0500, Randy Barlow wrote: > Greetings! > > Does anybody here know the history and/or purpose behind Bodhi's > critical path karma? A brief grepping of Bodhi's codebase makes me think > it isn't really used by Bodhi for any purpose other than recording and > displaying

Re: Critpath karma

2018-03-06 Thread Randy Barlow
I've filed https://github.com/fedora-infra/bodhi/issues/2194 about considering removing this feature from Bodhi. I listed an example there where I thought the feature was actively harmful in a particular case, due to users not knowing that the field doesn't actually count for anything. signature

Re: Critpath karma

2018-03-06 Thread Randy Barlow
On 03/06/2018 10:30 AM, Dennis Gilmore wrote: > In the past we required a proven tester to sign off on testing a > critpath package to provide extra assurance that the update worked and > did not break critical functionality. I do not believe that we are > using proven testers any longer. Having so

Re: Critpath karma

2018-03-06 Thread Randy Barlow
On 03/06/2018 08:53 AM, Peter Robinson wrote: > Critical path were (are) packages that were in blocking deliverables, > it pre-dates the Editions, basically if it was a core blocking package > eg part of Workstaiton, it needed to get more testing/karma before it > could go stable, adamw probably h

Re: Critpath karma

2018-03-06 Thread Dennis Gilmore
El mar, 06-03-2018 a las 08:48 -0500, Randy Barlow escribió: > Greetings! > > Does anybody here know the history and/or purpose behind Bodhi's > critical path karma? A brief grepping of Bodhi's codebase makes me > think > it isn't really used by Bodhi for any purpose other than recording > and > d

Re: Critpath karma

2018-03-06 Thread Peter Robinson
On Tue, Mar 6, 2018 at 1:48 PM, Randy Barlow wrote: > Greetings! > > Does anybody here know the history and/or purpose behind Bodhi's > critical path karma? A brief grepping of Bodhi's codebase makes me think > it isn't really used by Bodhi for any purpose other than recording and > displaying peo