Re: Tor maintainership
On 10/02/13 13:12, Enrico Scholz wrote: Jamie Nguyen j...@jamielinux.com writes: Thanks very much for adding me as a co-maintainer. I guess that you probably don't have much time for updating the Tor package, so I'm glad to be on board and will be taking a very active role in maintaining the package so that you can spend time on other things. I have some package cleanup tasks lined up and will be closing the security bugs on our bugzilla very soon. I will revert most of your changes. please avoid to apply your personal style (e.g. whitespaces vs. tabs) on a package where you are a comaintainer for 1 week. Although some of the changes might be useful, it is impossible for me to distinguish between them because they were all in an huge commit. Hi Enrico, I want to clarify that my whitespace changes were an attempt to make the spec more legible for everyone, not myself. I also feel it would have been nicer for you to ask me to revert the changes rather than reverting them yourself, since I did go through the effort of making the changes and helping you to update and fix the package, but that's just a small suggestion. Anyway, I agree that it would perhaps have been better to split the commit into chunks. Thus, I post below a patch series that includes all the various changes in easily digestible chunks. http://jamielinux.fedorapeople.org/tor/0001-Remove-release_func-macro.patch http://jamielinux.fedorapeople.org/tor/0002-Cleanup-systemd-macros.patch http://jamielinux.fedorapeople.org/tor/0003-Remove-unnecessary-EPEL-5-tags-and-macros.patch http://jamielinux.fedorapeople.org/tor/0004-Unify-core-systemd-and-torify-into-one-package.patch http://jamielinux.fedorapeople.org/tor/0005-Remove-dependency-on-fedora-user-mgmt.patch http://jamielinux.fedorapeople.org/tor/0006-Remove-unnecessary-Requires-on-logrotate-directory.patch http://jamielinux.fedorapeople.org/tor/0007-Use-defaults-torrc-as-recommended-by-upstream.patch http://jamielinux.fedorapeople.org/tor/0008-Change-var-log-tor-permissions-to-match-upstream.patch All of these help to bring the package closer both to our packaging guidelines and upstream defaults and requests. Kind regards, -- Jamie Nguyen -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: Tor maintainership
On 27/02/13 18:03, Jamie Nguyen wrote: Hi Enrico, I want to clarify that my whitespace changes were an attempt to make the spec more legible for everyone, not myself. I also feel it would have been nicer for you to ask me to revert the changes rather than reverting them yourself, since I did go through the effort of making the changes and helping you to update and fix the package, but that's just a small suggestion. Anyway, I agree that it would perhaps have been better to split the commit into chunks. Thus, I post below a patch series that includes all the various changes in easily digestible chunks. I just want to clarify here the reasoning for each patch. http://jamielinux.fedorapeople.org/tor/0001-Remove-release_func-macro.patch This custom macro is rather confusing to hard to understand There's no real need for it. http://jamielinux.fedorapeople.org/tor/0002-Cleanup-systemd-macros.patch This custom macro here just makes it harder to read the spec as the bits inside are not in the place that most people would expect. http://jamielinux.fedorapeople.org/tor/0003-Remove-unnecessary-EPEL-5-tags-and-macros.patch Not needed for Fedora 17 and 18. I have adopted your orphaned EPEL 5 and EPEL 6 branches, and I'm fine with these macros not being present in the Fedora specs. http://jamielinux.fedorapeople.org/tor/0004-Unify-core-systemd-and-torify-into-one-package.patch The main tor package is empty. There is no reason for it to be, and no reason for the others to be subpackages. http://jamielinux.fedorapeople.org/tor/0005-Remove-dependency-on-fedora-user-mgmt.patch This is an unnecessary dependency and I see no benefit for it. http://jamielinux.fedorapeople.org/tor/0006-Remove-unnecessary-Requires-on-logrotate-directory.patch This is not required. http://jamielinux.fedorapeople.org/tor/0007-Use-defaults-torrc-as-recommended-by-upstream.patch This will help to make sure some sane defaults are set. This was recommended by upstream. http://jamielinux.fedorapeople.org/tor/0008-Change-var-log-tor-permissions-to-match-upstream.patch This matches the defaults in the upstream RPM packages. The SPEC is also 100 lines shorter :) -- Jamie Nguyen -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: Tor maintainership
I remembered his clamav confused a lot of people. 在 2013-2-11 PM2:06，Kevin Kofler kevin.kof...@chello.at写道： Paul Wouters wrote: On Sun, 10 Feb 2013, Enrico Scholz wrote: I will revert most of your changes. please avoid to apply your personal style Please remove tor-systemd and other personal styles that are against fedora guidelines with blocking security updates for your personal pleasure, you are endangering the lives of people who count on the functionality of tor. Seriously, this package should be taken away from you. It's been 5 years of you being a drama queen going against everyone _including_ upstream. +1 In fact, IMHO, ALL packages should be taken away from him. He's maintaining all of them the same broken personally styled and upstream-unfriendly way, just look at clamav for an example (but I think any random Enrico package will do). I'm fed up of this behavior! Kevin Kofler -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: Tor maintainership
On Seg, 2013-02-11 at 19:31 +0800, Christopher Meng wrote: I remembered his clamav confused a lot of people. yeah this explain why clamav , does not even restart by default on F16 https://bugzilla.redhat.com/show_bug.cgi?id=787434 one year later still have the problem . Also I think systemd is not implemented on clamav , not sure, neither check on F18. 在 2013-2-11 PM2:06，Kevin Kofler kevin.kof...@chello.at写道： Paul Wouters wrote: On Sun, 10 Feb 2013, Enrico Scholz wrote: I will revert most of your changes. please avoid to apply your personal style Please remove tor-systemd and other personal styles that are against fedora guidelines with blocking security updates for your personal pleasure, you are endangering the lives of people who count on the functionality of tor. Seriously, this package should be taken away from you. It's been 5 years of you being a drama queen going against everyone _including_ upstream. +1 In fact, IMHO, ALL packages should be taken away from him. He's maintaining all of them the same broken personally styled and upstream-unfriendly way, just look at clamav for an example (but I think any random Enrico package will do). I'm fed up of this behavior! Kevin Kofler -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel -- Sérgio M. B. -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: Tor maintainership
On Seg, 2013-02-11 at 12:32 +, Sérgio Basto wrote: On Seg, 2013-02-11 at 19:31 +0800, Christopher Meng wrote: I remembered his clamav confused a lot of people. yeah this explain why clamav , does not even restart by default on F16 https://bugzilla.redhat.com/show_bug.cgi?id=787434 one year later still have the problem . Also I think systemd is not implemented on clamav , not sure, neither check on F18. https://bugzilla.redhat.com/show_bug.cgi?id=801994 在 2013-2-11 PM2:06，Kevin Kofler kevin.kof...@chello.at写道： Paul Wouters wrote: On Sun, 10 Feb 2013, Enrico Scholz wrote: I will revert most of your changes. please avoid to apply your personal style Please remove tor-systemd and other personal styles that are against fedora guidelines with blocking security updates for your personal pleasure, you are endangering the lives of people who count on the functionality of tor. Seriously, this package should be taken away from you. It's been 5 years of you being a drama queen going against everyone _including_ upstream. +1 In fact, IMHO, ALL packages should be taken away from him. He's maintaining all of them the same broken personally styled and upstream-unfriendly way, just look at clamav for an example (but I think any random Enrico package will do). I'm fed up of this behavior! Kevin Kofler -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel -- Sérgio M. B. -- Sérgio M. B. -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: Tor maintainership
Jamie Nguyen j...@jamielinux.com writes: Thanks very much for adding me as a co-maintainer. I guess that you probably don't have much time for updating the Tor package, so I'm glad to be on board and will be taking a very active role in maintaining the package so that you can spend time on other things. I have some package cleanup tasks lined up and will be closing the security bugs on our bugzilla very soon. I will revert most of your changes. please avoid to apply your personal style (e.g. whitespaces vs. tabs) on a package where you are a comaintainer for 1 week. Although some of the changes might be useful, it is impossible for me to distinguish between them because they were all in an huge commit. Sorry, Enrico -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: Tor maintainership
On Dom, 2013-02-10 at 14:12 +0100, Enrico Scholz wrote: Jamie Nguyen j...@jamielinux.com writes: Thanks very much for adding me as a co-maintainer. I guess that you probably don't have much time for updating the Tor package, so I'm glad to be on board and will be taking a very active role in maintaining the package so that you can spend time on other things. I have some package cleanup tasks lined up and will be closing the security bugs on our bugzilla very soon. I will revert most of your changes. please avoid to apply your personal style (e.g. whitespaces vs. tabs) on a package where you are a comaintainer for 1 week. Although some of the changes might be useful, it is impossible for me to distinguish between them because they were all in an huge commit. If you use vim to edit spec , you may do :retab to restore tabs in your own style . Best regards, -- Sérgio M. B. -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: Tor maintainership
On Sun, 10 Feb 2013 14:12:44 +0100 Enrico Scholz enrico.sch...@informatik.tu-chemnitz.de wrote: Jamie Nguyen j...@jamielinux.com writes: Thanks very much for adding me as a co-maintainer. I guess that you probably don't have much time for updating the Tor package, so I'm glad to be on board and will be taking a very active role in maintaining the package so that you can spend time on other things. I have some package cleanup tasks lined up and will be closing the security bugs on our bugzilla very soon. I will revert most of your changes. please avoid to apply your personal style (e.g. whitespaces vs. tabs) on a package where you are a comaintainer for 1 week. While I understand this, I'd like to note that IMHO Fedora package specs should not really have any 'personal style'. If they do, it means they are harder for people to co-maintainer or provenpackages to step in and fix things in case they need to. Although some of the changes might be useful, it is impossible for me to distinguish between them because they were all in an huge commit. Well, the entire tor.spec without changelog is 245 lines. Couldn't you simply review the new version? kevin signature.asc Description: PGP signature -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: Tor maintainership
Kevin Fenzi wrote: While I understand this, I'd like to note that IMHO Fedora package specs should not really have any 'personal style'. If they do, it means they are harder for people to co-maintainer or provenpackages to step in and fix things in case they need to. This is a real problem with Enrico's packages. They're all really Enrico packages rather than Fedora packages as they're supposed to be. Just look at the bizarre Release versioning (e.g. 1800) nobody else is using. (Well, the kernel team is now using a variant of that, but the kernel has always been a bit special.) The correct way to handle the problem this is intended to solve is documented right in our guidelines: https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Minor_release_bumps_for_old_branches (but even that should only be needed in exceptional cases). Putting the systemd units for his services in a subpackage is also strange. All these things may or may not comply with the letter of the packaging guidelines, but they're definitely against the spirit, which is to have a consistent Fedora style rather than an Enrico style. And even worse, Enrico doesn't seem to know or understand the concept of upgrade path, see the discussion on: https://admin.fedoraproject.org/updates/FEDORA-2012-14635 (His Release version hack doesn't help there because it's a new upstream version.) Kevin Kofler -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: Tor maintainership
On Sun, 10 Feb 2013, Enrico Scholz wrote: I will revert most of your changes. please avoid to apply your personal style Please remove tor-systemd and other personal styles that are against fedora guidelines with blocking security updates for your personal pleasure, you are endangering the lives of people who count on the functionality of tor. Seriously, this package should be taken away from you. It's been 5 years of you being a drama queen going against everyone _including_ upstream. Paul -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: Tor maintainership
Paul Wouters wrote: On Sun, 10 Feb 2013, Enrico Scholz wrote: I will revert most of your changes. please avoid to apply your personal style Please remove tor-systemd and other personal styles that are against fedora guidelines with blocking security updates for your personal pleasure, you are endangering the lives of people who count on the functionality of tor. Seriously, this package should be taken away from you. It's been 5 years of you being a drama queen going against everyone _including_ upstream. +1 In fact, IMHO, ALL packages should be taken away from him. He's maintaining all of them the same broken personally styled and upstream-unfriendly way, just look at clamav for an example (but I think any random Enrico package will do). I'm fed up of this behavior! Kevin Kofler -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
