Re: [ovirt-devel] [VDSM] Improving vdsm logging format

2016-09-23 Thread Nir Soffer
Latest version show thread name before logger name, improving visibility. Patches in this topic: - https://gerrit.ovirt.org/64113 - logging: More standard logging format The main change, the next patches refine this change. - https://gerrit.ovirt.org/64216 - logging: Use same log format in

Re: [ovirt-devel] [VDSM] Improving vdsm logging format

2016-09-22 Thread Roman Hodain
Hi, I agree with Michal. The Thread is very important for the debugging. Obviously you can highlight what you need, but still the thread is jumping there and back which make is less readable. It would be ok if that would be on the third place as the log level is aligned. It makes huge difference

Re: [ovirt-devel] [VDSM] Improving vdsm logging format

2016-09-21 Thread Peter Portante
On Wed, Sep 21, 2016 at 6:03 PM, Nir Soffer wrote: > On Wed, Sep 21, 2016 at 1:12 PM, Peter Portante wrote: >> >> >> >> On Wed, Sep 21, 2016 at 2:54 AM, Michal Skrivanek >> wrote: >>> >>> >>> > On 20 Sep 2016, at 19:52, Nir

Re: [ovirt-devel] [VDSM] Improving vdsm logging format

2016-09-21 Thread Nir Soffer
On Wed, Sep 21, 2016 at 1:12 PM, Peter Portante wrote: > > > On Wed, Sep 21, 2016 at 2:54 AM, Michal Skrivanek < > michal.skriva...@redhat.com> wrote: > >> >> > On 20 Sep 2016, at 19:52, Nir Soffer wrote: >> > >> > Hi all, >> > >> > We are reviewing

Re: [ovirt-devel] [VDSM] Improving vdsm logging format

2016-09-21 Thread Nir Soffer
On Wed, Sep 21, 2016 at 4:47 PM, Roman Hodain wrote: > Hi, > > I agree with Michal. The Thread is very important for the debugging. > Obviously you can highlight what you need, but still the thread is jumping > there and back which make is less readable. It would be ok if

Re: [ovirt-devel] [VDSM] Improving vdsm logging format

2016-09-21 Thread Peter Portante
On Wed, Sep 21, 2016 at 2:54 AM, Michal Skrivanek < michal.skriva...@redhat.com> wrote: > > > On 20 Sep 2016, at 19:52, Nir Soffer wrote: > > > > Hi all, > > > > We are reviewing patches for improving vdsm log format. > > > > The goal is to have more standard logging format,

Re: [ovirt-devel] [VDSM] Improving vdsm logging format

2016-09-21 Thread Michal Skrivanek
> On 20 Sep 2016, at 19:52, Nir Soffer wrote: > > Hi all, > > We are reviewing patches for improving vdsm log format. > > The goal is to have more standard logging format, similar to engine > logs and other logs in the ovirt project, to make it easier to debug > and