Re: GSOC project: #4334 Replace Mongoose with Civetweb

2021-03-31 Thread Ayushman Mishra
Sir, I am trying to integrate mongoose web-server in simple rtems application (https://devel.rtems.org/wiki/Developer/Mongoose_Web_Server), for that I have to configure networking in rtems. I am using xilinx_zynq_a9_qemu for simulation bsp and following steps given here

Re: [PATCH] rld-cc: Add -target to recognised cflags

2021-03-31 Thread Hesham Almatary
Ping On Wed, 24 Mar 2021 at 09:57, Hesham Almatary wrote: > -target *-*-* flag is necessary for LLVM/Clang while cross-compiling > --- > rtemstoolkit/rld-cc.cpp | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/rtemstoolkit/rld-cc.cpp b/rtemstoolkit/rld-cc.cpp > index bb03ff6..b424214

[rtems5 PATCH 0/5] Backport zynq SPI drivers to rtems5

2021-03-31 Thread Jan Sommer
This patchset backports: - The cadence SPI driver (see: https://devel.rtems.org/ticket/4369) - The xilinx axi SPI driver (see: https://devel.rtems.org/ticket/4370) - The i2c and spi shell commands (see: https://devel.rtems.org/ticket/4371) For the SPI drivers I didn't change any code (except the

[PATCH 3/5] bsps/xilinx_zynq: Add SPI driver for xilinx-axi-spi

2021-03-31 Thread Jan Sommer
Updates #4370 --- bsps/arm/include/bsp/xilinx-axi-spi-regs.h | 88 + bsps/arm/include/bsp/xilinx-axi-spi.h | 67 bsps/arm/shared/spi/xilinx-axi-spi.c | 402 + 3 files changed, 557 insertions(+) create mode 100644

[PATCH 5/5] shell: Add i2c and spi commands

2021-03-31 Thread Jan Sommer
From: Christian Mauderer This adds some commands that are usefull for debugging simple serial interfaces. Even if they are a complete re-implementation, the i2c* commands use a simmilar call like the Linux i2c tools. Closes #4371 --- cpukit/Makefile.am| 4 +

[PATCH 2/5] bsps/xilinx_zynq: Add cadence SPI driver to build system

2021-03-31 Thread Jan Sommer
Closes #4369 --- bsps/arm/headers.am| 2 ++ c/src/lib/libbsp/arm/xilinx-zynq/Makefile.am | 3 +++ c/src/lib/libbsp/arm/xilinx-zynqmp/Makefile.am | 3 +++ 3 files changed, 8 insertions(+) diff --git a/bsps/arm/headers.am b/bsps/arm/headers.am index

[PATCH 1/5] bsps/xilinx_zynq: Add SPI driver for cadence-spi

2021-03-31 Thread Jan Sommer
Updates #4369 --- bsps/arm/include/bsp/cadence-spi-regs.h | 84 + bsps/arm/include/bsp/cadence-spi.h | 63 bsps/arm/shared/spi/cadence-spi.c | 444 3 files changed, 591 insertions(+) create mode 100644 bsps/arm/include/bsp/cadence-spi-regs.h create

[PATCH 4/5] bsps/xilinx_zynq: Add Xilinx AXI SPI driver to build

2021-03-31 Thread Jan Sommer
Closes #4370 --- bsps/arm/headers.am| 2 ++ c/src/lib/libbsp/arm/xilinx-zynq/Makefile.am | 1 + c/src/lib/libbsp/arm/xilinx-zynqmp/Makefile.am | 1 + 3 files changed, 4 insertions(+) diff --git a/bsps/arm/headers.am b/bsps/arm/headers.am index 007412fee0..69a154f6b2

GSoC Project : Packaging Programming Language for RTEMS

2021-03-31 Thread Eshan Dhawan
Hello everyone, For this GSoC I was planning to package programming language - Adding an RSB recipe - Example having at least bare-metal embedded configuration and use of custom commands - integrating with rtems shell - write test script (I would have to go through that part ) and wrap all up

[libbsd] How to install machine header files?

2021-03-31 Thread Jan.Sommer
Hello, I stumbled upon some include path problems in libbsd while looking at Chris' ptpd port and I am not sure what is the recommended way to solve it. It starts with "freebsd/sys/sys/bus.h" including "machine/_bus.h". Currently, this will be the one from within "rtemsbd" which will redirect to

Re: [PATCH 1/3] rtems-bin2c.c: Define _GNU_SOURCE for strnlen()

2021-03-31 Thread Gedare Bloom
The --subject-prefix is helpful to guide reviewers. https://docs.rtems.org/branches/master/eng/vc-users.html#creating-a-patch On Tue, Mar 30, 2021 at 3:16 PM Joel Sherrill wrote: > > --- > misc/bin2c/rtems-bin2c.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/misc/bin2c/rtems-bin2c.c

[PATCH 1/3] gen_uuid.c: Ignore return values from fcntl()

2021-03-31 Thread Ryan Long
CID 1049146: Unchecked return value from library in get_clock(). CID 1049147: Unchecked return value from library in get_random_fd(). Closes #4280 --- cpukit/libmisc/uuid/gen_uuid.c | 8 1 file changed, 8 insertions(+) diff --git a/cpukit/libmisc/uuid/gen_uuid.c

[PATCH 2/3] main_cp.c: Ignore return value from stat()

2021-03-31 Thread Ryan Long
CID 26051: Unchecked return value from library in main_cp(). Closes #4365 --- cpukit/libmisc/shell/main_cp.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/cpukit/libmisc/shell/main_cp.c b/cpukit/libmisc/shell/main_cp.c index cddbc95..bb31a35 100644 ---

[PATCH 0/3] Unchecked return value from library patches

2021-03-31 Thread Ryan Long
Hi, For these patches, I just added #ifdefs and (void)'s to get rid of the issues. Thanks, Ryan Ryan Long (3): gen_uuid.c: Ignore return values from fcntl() main_cp.c: Ignore return value from stat() main_help.c: Do not care what char is returned by getchar()

[PATCH 3/3] main_help.c: Do not care what char is returned by getchar()

2021-03-31 Thread Ryan Long
CID 1437650: Unchecked return value from library in rtems_shell_help(). Closes #4291 --- cpukit/libmisc/shell/main_help.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpukit/libmisc/shell/main_help.c b/cpukit/libmisc/shell/main_help.c index 9f59e9d..564bc30 100644 ---

Re: [PATCH 2/3] main_cp.c: Ignore return value from stat()

2021-03-31 Thread Gedare Bloom
On Wed, Mar 31, 2021 at 9:16 AM Ryan Long wrote: > > CID 26051: Unchecked return value from library in main_cp(). > > Closes #4365 > --- > cpukit/libmisc/shell/main_cp.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/cpukit/libmisc/shell/main_cp.c

Re: [PATCH] covoar: Fix off-by-one in Coverage::finalizeSymbol()

2021-03-31 Thread Gedare Bloom
On Wed, Mar 31, 2021 at 10:05 AM Alex White wrote: > > The `rangeIndex` variable is 1 higher than the index at which the first > instruction address was found. This fixes the lookup after the loop to > account for that fact. > --- > tester/covoar/ObjdumpProcessor.cc | 2 +- > 1 file changed, 1

Re: [PATCH 2/3] misc/wscript: Specify C language version

2021-03-31 Thread Gedare Bloom
On Wed, Mar 31, 2021 at 10:44 AM Joel Sherrill wrote: > > > > On Wed, Mar 31, 2021 at 9:56 AM Gedare Bloom wrote: >> >> Should we set the cstd version at the top-level? > > > That's not what was done for C++ when I looked for examples. I suppose this > lets the C++ version vary by tool or

[PATCH v2] covoar: Fix off-by-one in Coverage::finalizeSymbol()

2021-03-31 Thread Alex White
The `rangeIndex` variable is 1 higher than the index at which the first instruction address was found. This fixes the loop to set `rangeIndex` correctly. --- tester/covoar/ObjdumpProcessor.cc | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git

RE: [rtems-tools commit] rld-process: Add named tempfile constructor

2021-03-31 Thread Alex White
On Tue, Mar 30, 2021 at 10:30 PM Chris Johns wrote: > > Hi, > > When I looked at this on vc@ I saw it is broken. I am sorry I did not pick > this > up in the review. > > On 31/3/21 5:20 am, Joel Sherrill wrote: > > Module:    rtems-tools > > Branch:    master > > Commit:    

[PATCH] Revert rld-process: Add named tempfile constructor

2021-03-31 Thread Joel Sherrill
This patch reflected a temporary workaround which avoided regenerating the temporary files for each symbol set. The need for redundant processing is being eliminated in an upcoming patch series. Hash: 420d7a13672991a1480d06ac02190f2976b9253b >From 420d7a13672991a1480d06ac02190f2976b9253b Mon Sep

Re: GSOC project: #4334 Replace Mongoose with Civetweb

2021-03-31 Thread Gedare Bloom
On Wed, Mar 31, 2021 at 3:18 AM Ayushman Mishra wrote: > > Sir, > I am trying to integrate mongoose web-server in simple rtems > application (https://devel.rtems.org/wiki/Developer/Mongoose_Web_Server), > for that I have to configure networking in rtems. I am using > xilinx_zynq_a9_qemu for

Re: [PATCH v2] covoar: Fix off-by-one in Coverage::finalizeSymbol()

2021-03-31 Thread Gedare Bloom
ok On Wed, Mar 31, 2021 at 11:22 AM Alex White wrote: > > The `rangeIndex` variable is 1 higher than the index at which the first > instruction address was found. This fixes the loop to set `rangeIndex` > correctly. > --- > tester/covoar/ObjdumpProcessor.cc | 9 - > 1 file changed, 4

Re: [PATCH 2/3] misc/wscript: Specify C language version

2021-03-31 Thread Gedare Bloom
Should we set the cstd version at the top-level? On Tue, Mar 30, 2021 at 3:16 PM Joel Sherrill wrote: > > CentOS 7 has gcc 4.8 which defaults to C90 and this results in warnings > for code that is valid C99 but not C90. > --- > misc/wscript | 3 ++- > 1 file changed, 2 insertions(+), 1

RE: [PATCH 2/3] main_cp.c: Ignore return value from stat()

2021-03-31 Thread Ryan Long
I'm assuming you accidentally left the (void) in after that #endif, but that's the approach that Joel and I did first. After Joel saw it implemented, he said it made the code look too messy to him because of the if statements. -Original Message- From: Gedare Bloom Sent: Wednesday,

Re: [PATCH] covoar: Fix off-by-one in Coverage::finalizeSymbol()

2021-03-31 Thread Gedare Bloom
On Wed, Mar 31, 2021 at 10:42 AM Alex White wrote: > > On Wed, Mar 31, 2021 at 11:22 AM Gedare Bloom wrote: > > > > On Wed, Mar 31, 2021 at 10:05 AM Alex White wrote: > > > > > > The `rangeIndex` variable is 1 higher than the index at which the first > > > instruction address was found. This

Re: [PATCH] rld-cc: Add -target to recognised cflags

2021-03-31 Thread Gedare Bloom
On Wed, Mar 31, 2021 at 12:19 AM Hesham Almatary wrote: > > Ping > Go ahead if you tested with gcc also. > On Wed, 24 Mar 2021 at 09:57, Hesham Almatary > wrote: >> >> -target *-*-* flag is necessary for LLVM/Clang while cross-compiling >> --- >> rtemstoolkit/rld-cc.cpp | 1 + >> 1 file

[PATCH] covoar: Fix off-by-one in Coverage::finalizeSymbol()

2021-03-31 Thread Alex White
The `rangeIndex` variable is 1 higher than the index at which the first instruction address was found. This fixes the lookup after the loop to account for that fact. --- tester/covoar/ObjdumpProcessor.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 1/3] gen_uuid.c: Ignore return values from fcntl()

2021-03-31 Thread Gedare Bloom
On Wed, Mar 31, 2021 at 9:16 AM Ryan Long wrote: > > CID 1049146: Unchecked return value from library in get_clock(). > CID 1049147: Unchecked return value from library in get_random_fd(). > > Closes #4280 > --- > cpukit/libmisc/uuid/gen_uuid.c | 8 > 1 file changed, 8 insertions(+) > >

Re: [PATCH 1/3] gen_uuid.c: Ignore return values from fcntl()

2021-03-31 Thread Joel Sherrill
On Wed, Mar 31, 2021 at 11:13 AM Gedare Bloom wrote: > On Wed, Mar 31, 2021 at 9:16 AM Ryan Long wrote: > > > > CID 1049146: Unchecked return value from library in get_clock(). > > CID 1049147: Unchecked return value from library in get_random_fd(). > > > > Closes #4280 > > --- > >

Re: [PATCH 2/3] misc/wscript: Specify C language version

2021-03-31 Thread Joel Sherrill
On Wed, Mar 31, 2021 at 9:56 AM Gedare Bloom wrote: > Should we set the cstd version at the top-level? > That's not what was done for C++ when I looked for examples. I suppose this lets the C++ version vary by tool or library. And we did import some third-party code. --joel > > On Tue, Mar

Re: [PATCH 1/3] gen_uuid.c: Ignore return values from fcntl()

2021-03-31 Thread Gedare Bloom
On Wed, Mar 31, 2021 at 10:35 AM Joel Sherrill wrote: > > > > On Wed, Mar 31, 2021 at 11:13 AM Gedare Bloom wrote: >> >> On Wed, Mar 31, 2021 at 9:16 AM Ryan Long wrote: >> > >> > CID 1049146: Unchecked return value from library in get_clock(). >> > CID 1049147: Unchecked return value from

Re: [PATCH 2/3] main_cp.c: Ignore return value from stat()

2021-03-31 Thread Gedare Bloom
On Wed, Mar 31, 2021 at 10:21 AM Ryan Long wrote: > > I'm assuming you accidentally left the (void) in after that #endif, but > that's the approach that Joel and I did first. After Joel saw it > implemented, he said it made the code look too messy to him because of the if > statements. >

Re: [PATCH 2/3] main_cp.c: Ignore return value from stat()

2021-03-31 Thread Joel Sherrill
On Wed, Mar 31, 2021 at 11:24 AM Gedare Bloom wrote: > On Wed, Mar 31, 2021 at 10:21 AM Ryan Long wrote: > > > > I'm assuming you accidentally left the (void) in after that #endif, but > that's the approach that Joel and I did first. After Joel saw it > implemented, he said it made the code

RE: [PATCH] covoar: Fix off-by-one in Coverage::finalizeSymbol()

2021-03-31 Thread Alex White
On Wed, Mar 31, 2021 at 11:22 AM Gedare Bloom wrote: > > On Wed, Mar 31, 2021 at 10:05 AM Alex White wrote: > > > > The `rangeIndex` variable is 1 higher than the index at which the first > > instruction address was found. This fixes the lookup after the loop to > > account for that fact. > >

Re: [rtems-tools commit] rld-process: Add named tempfile constructor

2021-03-31 Thread Chris Johns
On 1/4/21 2:26 am, Alex White wrote: > On Tue, Mar 30, 2021 at 10:30 PM Chris Johns wrote: >> >> Hi, >> >> When I looked at this on vc@ I saw it is broken. I am sorry I did not pick >> this >> up in the review. >> >> On 31/3/21 5:20 am, Joel Sherrill wrote: >>> Module:    rtems-tools >>> Branch:

Re: [PATCH rtems-libbsd] libbsd.py: Build i2c shell command

2021-03-31 Thread Vijay Kumar Banerjee
On Wed, Mar 31, 2021 at 4:20 PM Chris Johns wrote: > > I am fine with this. I did not know it existed. > Thanks. Pushed. Best regards, Vijay > On 27/3/21 7:40 am, Vijay Kumar Banerjee wrote: > > --- > > libbsd.py | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/libbsd.py

Re: [rtems5 PATCH 0/5] Backport zynq SPI drivers to rtems5

2021-03-31 Thread Chris Johns
Hi Jan, This looks good. Has this been tested on zync hardware? If no then some testing is needed and if yes then please push. Thanks Chris On 31/3/21 8:06 pm, Jan Sommer wrote: > This patchset backports: > - The cadence SPI driver (see: https://devel.rtems.org/ticket/4369) > - The xilinx axi

Re: [PATCH rtems-docs] common/latex.py: use distro module for python3.5 and up

2021-03-31 Thread Vijay Kumar Banerjee
On Wed, Mar 31, 2021 at 4:19 PM Chris Johns wrote: > > Do we need to support platform as well? I have lost track of which Python we > need build doco. I suspect it is only 3. platform.dist is deprecated since 3.5 and removed in 3.7, so this was certainly a piece of code that would fail with

Re: [PATCH rtems-docs] common/latex.py: use distro module for python3.5 and up

2021-03-31 Thread Chris Johns
Do we need to support platform as well? I have lost track of which Python we need build doco. I suspect it is only 3. Chris On 24/3/21 7:05 am, Vijay Kumar Banerjee wrote: > --- > common/latex.py | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/common/latex.py

Re: [PATCH rtems-libbsd] libbsd.py: Build i2c shell command

2021-03-31 Thread Chris Johns
I am fine with this. I did not know it existed. On 27/3/21 7:40 am, Vijay Kumar Banerjee wrote: > --- > libbsd.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libbsd.py b/libbsd.py > index f7efda43..fe0566e7 100644 > --- a/libbsd.py > +++ b/libbsd.py > @@ -258,6 +258,7 @@ class

Re: [PATCH rtems-docs] common/latex.py: use distro module for python3.5 and up

2021-03-31 Thread Chris Johns
On 1/4/21 11:03 am, Vijay Kumar Banerjee wrote: > On Wed, Mar 31, 2021 at 4:19 PM Chris Johns wrote: >> >> Do we need to support platform as well? I have lost track of which Python we >> need build doco. I suspect it is only 3. > > platform.dist is deprecated since 3.5 and removed in 3.7, so

Re: [PATCH] rld-cc: Add -target to recognised cflags

2021-03-31 Thread Chris Johns
On 1/4/21 3:04 am, Gedare Bloom wrote: > On Wed, Mar 31, 2021 at 12:19 AM Hesham Almatary > wrote: >> >> Ping >> > Go ahead if you tested with gcc also. Fine with me. Chris ___ devel mailing list devel@rtems.org

Re: GSoC project: #3850 Modular Network Stacks

2021-03-31 Thread Rajiv Vaidyanathan
Dear mentors, Thank you for providing information regarding the project. I have started making the proposal for this ticket. I'll share it once I have a draft of it ready. Thanks and regards, Rajiv On Mon, 22 Mar 2021 at 21:43, Joel Sherrill wrote: > > > On Mon, Mar 22, 2021, 10:23 AM

Re: [libbsd] How to install machine header files?

2021-03-31 Thread Chris Johns
On 1/4/21 6:37 am, jan.som...@dlr.de wrote: > Hello, > > I stumbled upon some include path problems in libbsd while looking at Chris' > ptpd port and I am not sure what is the recommended way to solve it. > It starts with "freebsd/sys/sys/bus.h" including "machine/_bus.h". > Currently, this will