[developer] Re: [openzfs/openzfs] zfs holds: In scripted mode, do not pad columns with spaces (#488)

2017-11-01 Thread Allan Jude
@allanjude pushed 1 commit. df0c780 print_holds(): remove sep and sepnum entirely -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/488/files/3c7b9b717a8b9b074045fbd7b972f32438b8d370..df0c7802b85821f6509b2827ef63d1e0

[developer] Re: [openzfs/openzfs] zfs holds: In scripted mode, do not pad columns with spaces (#488)

2017-11-01 Thread Matthew Ahrens
ahrens commented on this pull request. > @@ -5596,17 +5596,23 @@ print_holds(boolean_t scripted, size_t nwidth, size_t > tagwidth, nvlist_t *nvl) uint64_t val = 0; time_t time; struct tm t; - char sep

[developer] Re: [openzfs/openzfs] 8753 linker errors don't show up in the "mail_msg" file (#490)

2017-11-01 Thread Prakash Surya
@prakashsurya pushed 1 commit. 4544f7b 8753 call function_that_does_not_exit() for testing purposes -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/490/files/93637401ad34dac6fa9656961044bf75ad2056d1..4544f7b61a2390

[developer] Re: [openzfs/openzfs] 8753 linker errors don't show up in the "mail_msg" file (#490)

2017-11-01 Thread Dan McDonald
danmcd approved this pull request. Please retest to be sure, but this looks better. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/490#pullrequestreview-73597575 ---

[developer] Re: [openzfs/openzfs] 8753 linker errors don't show up in the "mail_msg" file (#490)

2017-11-01 Thread Prakash Surya
prakashsurya commented on this pull request. > @@ -196,11 +197,14 @@ function build { echo "\n Build errors ($LABEL) \n" >> $mail_msg_file egrep ":" $SRC/${INSTALLOG}.out | - egrep -e "(^${MAKE}:|[ ]error[:\n])" | \ - egrep -v "Ignor

[developer] Re: [openzfs/openzfs] 8753 linker errors don't show up in the "mail_msg" file (#490)

2017-11-01 Thread Dan McDonald
danmcd commented on this pull request. > @@ -196,11 +197,14 @@ function build { echo "\n Build errors ($LABEL) \n" >> $mail_msg_file egrep ":" $SRC/${INSTALLOG}.out | - egrep -e "(^${MAKE}:|[ ]error[:\n])" | \ - egrep -v "Ignoring un

[developer] Re: [openzfs/openzfs] 8115 parallel zfs mount (#451)

2017-11-01 Thread Prakash Surya
@andy-js Thank you. I was hoping to get some time to focus on this, but I'm not sure I'll be able to in the short term. If you have time to open a PR that only makes libzfs and libzpool consumers of libfakekernel, and remove the current taskq implementation from libzpool, that'd be great. I appr

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2017-11-01 Thread Robert Mustacchi
@ahrens I know that @arekinath has been doing a bunch of testing of this and should be able to provide some additional details about what he's seen and done. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com

[developer] Re: [openzfs/openzfs] 8753 linker errors don't show up in the "mail_msg" file (#490)

2017-11-01 Thread Igor K
ikozhukhov approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/490#pullrequestreview-73575209 -- openzfs-developer Ar

[developer] [openzfs/openzfs] 8753 linker errors don't show up in the "mail_msg" file (#490)

2017-11-01 Thread Prakash Surya
Reviewed by: Pavel Zakharov Reviewed by: Prashanth Sreenivasa This change modifies `nightly.sh` to expose linker errors in the "mail_msg" file, making it easier to debug these sorts of issues. The following is example output taken from the "mail_msg" file with this change applied, building inte

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2017-11-01 Thread Matthew Ahrens
This is great! Can anyone share additional testing that they've done? Even just banging on it with manual testing would help build confidence. I know the Linux community did a bunch of pre-integration testing and shook out several issues with the PR. -- You are receiving this because you ar

[developer] Re: [openzfs/openzfs] 0000 arc_reclaim_thread has 2 jobs (#486)

2017-11-01 Thread Prakash Surya
prakashsurya commented on this pull request. > @@ -799,6 +801,7 @@ static arc_state_t*arc_l2c_only; #definearc_overhead_size ARCSTAT(arcstat_overhead_size) static int arc_no_grow;/* Don't try to grow cache size */ +static hrtime_tarc_grow

[developer] Re: [openzfs/openzfs] 0000 arc_reclaim_thread has 2 jobs (#486)

2017-11-01 Thread Prakash Surya
prakashsurya commented on this pull request. > @@ -282,10 +283,11 @@ boolean_t arc_watch = B_FALSE; int arc_procfd; #endif -static kmutex_tarc_reclaim_lock; -static kcondvar_t arc_reclaim_thread_cv; -static boolean_t arc_reclaim_thread_exit; -static kcondvar_t

[developer] Re: [openzfs/openzfs] zfs holds: In scripted mode, do not pad columns with spaces (#488)

2017-11-01 Thread Prakash Surya
@allanjude is your branch based off of illumos or openzfs? if it's illumos, can you rebase onto the master branch of openzfs? I think that's what's causing the tests to fail. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[developer] Re: [openzfs/openzfs] zfs holds: In scripted mode, do not pad columns with spaces (#488)

2017-11-01 Thread Allan Jude
@allanjude pushed 1 commit. 168a284 Address feedback from Matt Ahrens -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/488/files/4ffe832d4cdd55fd3d045472c88adb96b4edd8c8..168a2840808a557a5a59dd7209b44924eb65b9c9 --

[developer] Re: [openzfs/openzfs] libzfs warning fixes (#472)

2017-11-01 Thread Matthew Ahrens
ahrens commented on this pull request. > @@ -1322,7 +1322,7 @@ zfs_do_destroy(int argc, char **argv) char buf[16]; zfs_nicenum(cb.cb_snapused, buf, sizeof (buf)); if (cb.cb_parsable) { - (void)

[developer] Re: [openzfs/openzfs] 8607 zfs: variable set but not used (#479)

2017-11-01 Thread Matthew Ahrens
Closed #479. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/479#event-1321310614 -- openzfs-developer Archives: https://openzfs.topicbox.com/gr

[developer] Re: [openzfs/openzfs] 8607 zfs: variable set but not used (#479)

2017-11-01 Thread Matthew Ahrens
RTI'ed separately -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/479#issuecomment-341155261 -- openzfs-developer Archives: https://openzfs.topi

[developer] Re: [openzfs/openzfs] 8731 ASSERT3U(nui64s, <=, UINT16_MAX) fails for large blocks (#483)

2017-11-01 Thread Matthew Ahrens
ahrens approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/483#pullrequestreview-73527918 -- openzfs-developer Archiv

[developer] Re: [openzfs/openzfs] 8607 zfs: variable set but not used (#487)

2017-11-01 Thread Matthew Ahrens
Closed #487. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/487#event-1321307381 -- openzfs-developer Archives: https://openzfs.topicbox.com/gr

[developer] Re: [openzfs/openzfs] zfs holds: In scripted mode, do not pad columns with spaces (#488)

2017-11-01 Thread Matthew Ahrens
ahrens commented on this pull request. > @@ -5395,8 +5395,13 @@ print_holds(boolean_t scripted, size_t nwidth, size_t > tagwidth, nvlist_t *nvl) (void) strftime(tsbuf, DATETIME_BUF_LEN, gettext(STRFTIME_FMT_STR), &t); -

Re: [developer] ZFS user quotas with compression

2017-11-01 Thread Ben RUBSON
Just for ref, @Flefebvre started a work on this, but is currently stalled / closed : https://github.com/openzfs/openzfs/pull/250 Ben On 07 Nov 2016 19:00, Matthew Ahrens wrote: I see the use case for these "logical" quotas (variants on userquota@, quota, refquota). FYI, I added the "logica

[developer] [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2017-11-01 Thread Jorgen Lundman
Re-opening the ZOL crypto commit for final reviews and testing. Original upstream commit is https://github.com/zfsonlinux/zfs/pull/5769 This will replace, and close, PR https://github.com/openzfs/openzfs/pull/124 This commit contains all additional PRs, fixes and corrections from ZOL, in one c

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#124)

2017-11-01 Thread Jorgen Lundman
Closed #124. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/124#event-1320801076 -- openzfs-developer Archives: https://openzfs.topicbox.com/gr

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#124)

2017-11-01 Thread Jorgen Lundman
Closed in favour of https://github.com/openzfs/openzfs/pull/489 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/124#issuecomment-341079785 -- op

[developer] Re: [openzfs/openzfs] 8115 parallel zfs mount (#451)

2017-11-01 Thread Andrew Stormont
Sounds good to me. I'll look at updating libzpool to use libfakekernel. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/451#issuecomment-341067822 -