Closed #418.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/418#event-1669473683
--
openzfs: openzfs-developer
Permalink:
gwr commented on this pull request.
> @@ -34,7 +34,6 @@
*/
#define tolower(C) (((C) >= 'A' && (C) <= 'Z') ? (C) - 'A' + 'a' : (C))
#define toupper(C) (((C) >= 'a' && (C) <= 'z') ? (C) - 'a' + 'A': (C))
-#define iscntrl(C) C) >= 0) && ((C) <= 0x1f)) || ((C) == 0x7f))
I
ikozhukhov commented on this pull request.
> @@ -34,7 +34,6 @@
*/
#define tolower(C) (((C) >= 'A' && (C) <= 'Z') ? (C) - 'A' + 'a' : (C))
#define toupper(C) (((C) >= 'a' && (C) <= 'z') ? (C) - 'a' + 'A': (C))
-#define iscntrl(C) C) >= 0) && ((C) <= 0x1f)) || ((C) == 0x7f))
gwr commented on this pull request.
> @@ -34,7 +34,6 @@
*/
#define tolower(C) (((C) >= 'A' && (C) <= 'Z') ? (C) - 'A' + 'a' : (C))
#define toupper(C) (((C) >= 'a' && (C) <= 'z') ? (C) - 'a' + 'A': (C))
-#define iscntrl(C) C) >= 0) && ((C) <= 0x1f)) || ((C) == 0x7f))
ahrens approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/418#pullrequestreview-106255485
--
openzfs:
will do
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/418#issuecomment-375416490
--
openzfs: openzfs-developer
Permalink:
@ikozhukhov I think you are better able to articulate the problem that this
solves. Could you open the RTI for this?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
i'm personally still using it on my dilos-illumos fork because i have no LINT
steps and i have no sunstudio installed for LINT.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@ikozhukhov what's the status of this PR? is this change still useful/needed?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/418#issuecomment-356428993
yuripv commented on this pull request.
> @@ -61,6 +61,7 @@ CLEANFILES += $(EXTPICS)
$(LINTLIB) := SRCS=$(SRCDIR)/$(LINTSRC)
$(LINTLIB): ../common/zfs.h
That's good, but this is a OpenZFS PR, not dilos one.
--
You are receiving this because you are subscribed to this thread.
Reply to
yuripv commented on this pull request.
> @@ -34,7 +34,6 @@
*/
#define tolower(C) (((C) >= 'A' && (C) <= 'Z') ? (C) - 'A' + 'a' : (C))
#define toupper(C) (((C) >= 'a' && (C) <= 'z') ? (C) - 'a' + 'A': (C))
-#define iscntrl(C) C) >= 0) && ((C) <= 0x1f)) || ((C) == 0x7f))
ikozhukhov commented on this pull request.
> @@ -34,7 +34,6 @@
*/
#define tolower(C) (((C) >= 'A' && (C) <= 'Z') ? (C) - 'A' + 'a' : (C))
#define toupper(C) (((C) >= 'a' && (C) <= 'z') ? (C) - 'a' + 'A': (C))
-#define iscntrl(C) C) >= 0) && ((C) <= 0x1f)) || ((C) == 0x7f))
yuripv requested changes on this pull request.
> @@ -48,7 +48,7 @@ SRCDIR= ../common
# There should be a mapfile here
MAPFILES =
-LIBS +=$(LINTLIB) $(DYNLIB)
+LIBS +=$(DYNLIB) $(LINTLIB)
How about changing this to just ```LIBS += $(LINTLIB)```?
yuripv requested changes on this pull request.
> @@ -34,7 +34,6 @@
*/
#define tolower(C) (((C) >= 'A' && (C) <= 'Z') ? (C) - 'A' + 'a' : (C))
#define toupper(C) (((C) >= 'a' && (C) <= 'z') ? (C) - 'a' + 'A': (C))
-#define iscntrl(C) C) >= 0) && ((C) <= 0x1f)) || ((C) ==
14 matches
Mail list logo
