This is not ready to go yet.
I still haven't updated the code with the restructuring from ZoL. There is a
kstat memory leak that I need to narrow down in the new code before updating
this. Sorry for the delay.
--
You are receiving this because you are subscribed to this thread.
Reply to this
@sdimitro can you rebase this and then we'll get it integrated.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/664#issuecomment-425963430
--
Looks like the ZoL commit was merged. Let's move forward with this.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/664#issuecomment-416244239
Let's keep a hold on this until the ZoL PR makes it in:
https://github.com/zfsonlinux/zfs/pull/7705
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/664#issuecomment-414166806
sdimitro commented on this pull request.
> @@ -1217,18 +1352,10 @@ zvol_dumpio(zvol_state_t *zv, void *addr, uint64_t
> offset, uint64_t size,
int
zvol_strategy(buf_t *bp)
{
- zfs_soft_state_t *zs = NULL;
see my other comment (e.g. cleanup).
--
You are receiving this because you
sdimitro commented on this pull request.
> @@ -653,43 +654,28 @@ zfs_read(vnode_t *vp, uio_t *uio, int ioflag, cred_t
> *cr, caller_context_t *ct)
static int
zfs_write(vnode_t *vp, uio_t *uio, int ioflag, cred_t *cr, caller_context_t
*ct)
{
- znode_t *zp = VTOZ(vp);
Since I
allanjude commented on this pull request.
> @@ -653,43 +654,28 @@ zfs_read(vnode_t *vp, uio_t *uio, int ioflag, cred_t
> *cr, caller_context_t *ct)
static int
zfs_write(vnode_t *vp, uio_t *uio, int ioflag, cred_t *cr, caller_context_t
*ct)
{
- znode_t *zp = VTOZ(vp);
Why are
Ramzec commented on this pull request.
> + * There should not be anything wrong with having kstats for
+* snapshots. Since we are not sure how useful they would be
+* though nor how much their memory overhead would matter in
+* a filesystem with many snapshots, we
sdimitro commented on this pull request.
> + * There should not be anything wrong with having kstats for
+* snapshots. Since we are not sure how useful they would be
+* though nor how much their memory overhead would matter in
+* a filesystem with many snapshots, we
Ramzec commented on this pull request.
> + * There should not be anything wrong with having kstats for
+* snapshots. Since we are not sure how useful they would be
+* though nor how much their memory overhead would matter in
+* a filesystem with many snapshots, we
10 matches
Mail list logo
