Re: [Development] GitHub Pull requests

On Sunday, 15 March 2020 02:30:21 EST Richard Weickelt wrote: > > That's why I asked last month (and still have no official reply) on how > > the Qt Company suggests we use Qt in public CIs, if the binary build is > > locked to Qt Accounts. > > Do you seriously expect to get a reply? Yes. -- Th

Re: [Development] GitHub Pull requests

> AppVeyor supports Linux, but they support Dot Net on Linux, which isn't > interesting. Travis does not support Windows (or didn't, last I checked). > That means I need both to have the two to support three OSes. Travis supports Windows. The machines are not fast, but it is usually enough. > >

Re: [Development] GitHub Pull requests

15.03.2020, 05:30, "Thiago Macieira" : > On Saturday, 14 March 2020 09:11:39 EST Konstantin Tokarev wrote: >>  My feeling about the last item is quite opposite: >>  * UI cuts long lines, when I wanted to check if specific compiler flag is >>  actually in use, and of course it was beyond "..." >>

Re: [Development] GitHub Pull requests

On Friday, 13 March 2020 04:19:22 EST Konstantin Tokarev wrote: > 13.03.2020, 08:55, "Thiago Macieira" : > > For a complex set of needs like Qt's, you'l still need a dedicated person > > or multiple people. And this isn't free either, despite there being a lot > > of free CIs for open source projec

Re: [Development] GitHub Pull requests

On Friday, 13 March 2020 04:48:21 EST Florian Bruhin wrote: > On Thu, Mar 12, 2020 at 10:51:31PM -0700, Thiago Macieira wrote: > > I also need two CIs so I can test on just three OSes. > > Can you elaborate on that? I assume those are Linux, macOS and Windows? Correct. > Pretty much all big CI p

Re: [Development] GitHub Pull requests

On Saturday, 14 March 2020 09:11:39 EST Konstantin Tokarev wrote: > My feeling about the last item is quite opposite: > * UI cuts long lines, when I wanted to check if specific compiler flag is > actually in use, and of course it was beyond "..." > * UI doesn't allow using built-in search of browse

Re: [Development] GitHub Pull requests

12.03.2020, 23:31, "Robert Löhning" : > Hi, > > after having worked in a project in GitHub for a couple of months now > and seeing their CI from the user perspective, this sounds feasible to me. > ... > - the progress and results are comprehensible, you can look at the CI > run just like you look

Re: [Development] GitHub Pull requests

On Thu, Mar 12, 2020 at 10:51:31PM -0700, Thiago Macieira wrote: > I also need two CIs so I can test on just three OSes. Can you elaborate on that? I assume those are Linux, macOS and Windows? Pretty much all big CI providers I can think of (Travis CI, AppVeyor, GitHub Actions, Azure Pipelines) s

Re: [Development] GitHub Pull requests

13.03.2020, 08:55, "Thiago Macieira" : > For a complex set of needs like Qt's, you'l still need a dedicated person or > multiple people. And this isn't free either, despite there being a lot of free > CIs for open source projects: first, because it's meant to serve the > commercial version too an

Re: [Development] GitHub Pull requests

On Thursday, 12 March 2020 13:29:10 PDT Robert Löhning wrote: > > Why would we do that? > > Hi, > > after having worked in a project in GitHub for a couple of months now > and seeing their CI from the user perspective, this sounds feasible to me. > > - changes are CI-tested individually, not as

Re: [Development] GitHub Pull requests

Am 11.03.20 um 06:13 schrieb Thiago Macieira: > On Tuesday, 10 March 2020 07:40:41 PDT Cristian Adam wrote: >> Hi, >> >> With the “GitHub issues” E-Mail thread we made sure the Issues are gone >> from the projects. >> >> What about Pull requests? >> >> For example qtbase

Re: [Development] GitHub Pull requests

On 12/03/2020 01.55, Thiago Macieira wrote: > On Wednesday, 11 March 2020 03:48:24 PDT Edward Welbourne wrote: >> Matthew Woehlke (10 March 2020 20:24) wrote: >>> In an ideal world... >> >> [snip] >> >>> Note that I believe nothing needs to be done to "merge" the GitHub PR; >>> if the commits becom

Re: [Development] GitHub Pull requests

Hello. What about Pull requests? Git developers have an interesting take on that, although it integrates with mailing list and not Gerrit: https://gitgitgadget.github.io/ For example, here's the GitHub PR: https://github.com/git/git/pull/714 and corresponding mailing list discussion: https

Re: [Development] GitHub Pull requests

On Wednesday, 11 March 2020 03:48:24 PDT Edward Welbourne wrote: > Matthew Woehlke (10 March 2020 20:24) wrote: > > In an ideal world... > > [snip] > > > Note that I believe nothing needs to be done to "merge" the GitHub PR; > > if the commits become reachable from the target branch, it should >

Re: [Development] GitHub Pull requests

On Tuesday, 10 March 2020 07:40:41 PDT Cristian Adam wrote: > Hi, > > With the “GitHub issues” E-Mail thread we made sure the Issues are gone > from the projects. > > What about Pull requests? > > For example qtbase has 7 pull requests. > Usually people point

Re: [Development] GitHub Pull requests

11.03.2020, 15:18, "Oswald Buddenhagen" : > On Tue, Mar 10, 2020 at 02:40:41PM +, Cristian Adam wrote: >> What about Pull requests? > > before you continue reinventing the wheel, i recommend that you read the > comments on QTPM-314 (yes, all of them). "You can't view this issue It may have

Re: [Development] GitHub Pull requests

> On 11. Mar 2020, at 07:48, Richard Weickelt wrote: > >>> In an ideal world... >>> >>> - Alice opens a pull request on GitHub. >>> - A bot sees the PR and opens a corresponding request on Gerrit. >>> - Bob comments on the Gerrit request. >>> - A bot sees Bob's comment and replicates it to the

Re: [Development] GitHub Pull requests

On Tue, Mar 10, 2020 at 02:40:41PM +, Cristian Adam wrote: What about Pull requests? before you continue reinventing the wheel, i recommend that you read the comments on QTPM-314 (yes, all of them). you can open a task for the public gerrit component if you still feel revolutionary afterwa

Re: [Development] GitHub Pull requests

Matthew Woehlke (10 March 2020 20:24) wrote: > In an ideal world... [snip] > Note that I believe nothing needs to be done to "merge" the GitHub PR; > if the commits become reachable from the target branch, it should > automatically get marked as "merged". Given that gerrit cherry-picks the change

Re: [Development] GitHub Pull requests

Just wanted to chime in as a "could be" Qt dev. Lowering the barrier to entry by allowing use of familiar tools could be a benefit IF you're looking for more contributions. I'm sure there's effort involved to allow this, and maybe it's not practical in the end, but perhaps worth considering/loo

Re: [Development] GitHub Pull requests

>> In an ideal world... >> >> - Alice opens a pull request on GitHub. >> - A bot sees the PR and opens a corresponding request on Gerrit. >> - Bob comments on the Gerrit request. >> - A bot sees Bob's comment and replicates it to the GitHub PR. >> - Alice replies (on GitHub) to Bob's comment. >> -

Re: [Development] GitHub Pull requests

10.03.2020, 22:26, "Matthew Woehlke" : > On 10/03/2020 12.19, Cristián Maureira-Fredes wrote: >>  On 3/10/20 3:40 PM, Cristian Adam wrote: >>>  What stops us from accepting the contributions via GitHub? >>> >>>  Is it: >>> >>>   1. The CLA >>>   2. Qt Account >>> >>>  For the CLA one can simply a

Re: [Development] GitHub Pull requests

On 10/03/2020 12.19, Cristián Maureira-Fredes wrote: > On 3/10/20 3:40 PM, Cristian Adam wrote: >> What stops us from accepting the contributions via GitHub? >> >> Is it: >> >>  1. The CLA >>  2. Qt Account >> >> For the CLA one can simply add an instance of: >> >> https://github.com/cla-assistant/

Re: [Development] GitHub Pull requests

Hi, On Tue, Mar 10, 2020 at 05:08:39PM +, Zacruzin via Development wrote: > Please remove me from this email chain.Thank you! On the bottom of every mail you find a footer, liking to the website for this mailinglist: > Development mailing list > Development@qt-project.org > https://lists.qt-

Re: [Development] GitHub Pull requests

Hey hey, > On 10 Mar 2020, at 15:40, Cristian Adam wrote: > > What stops us from accepting the contributions via GitHub? The issues feature should be closed on those GitHub mirrors. As a project we use Gerrit today, and that’s where contributions should happen. If we change review platform, t

Re: [Development] GitHub Pull requests

Please remove me from this email chain.Thank you! -Original Message- From: Konstantin Tokarev To: Cristián Maureira-Fredes ; development@qt-project.org Sent: Tue, Mar 10, 2020 12:07 pm Subject: Re: [Development] GitHub Pull requests 10.03.2020, 19:25, "Cristián Maureira-F

Re: [Development] GitHub Pull requests

10.03.2020, 19:25, "Cristián Maureira-Fredes" : > Hello, > > On 3/10/20 3:48 PM, Konstantin Tokarev wrote: >>  I think, lowering barrier of entry at expense of reviewers' convenience >> should >>  have its limits > > Totally agree, > so we should plan to accept patches from platform and systems >

Re: [Development] GitHub Pull requests

Hello, On 3/10/20 3:48 PM, Konstantin Tokarev wrote: I think, lowering barrier of entry at expense of reviewers' convenience should have its limits Totally agree, so we should plan to accept patches from platform and systems made for code development, like Github :) , otherwise we may end up

Re: [Development] GitHub Pull requests

Hello Cristian, On 3/10/20 3:40 PM, Cristian Adam wrote: What stops us from accepting the contributions via GitHub? Is it: 1. The CLA 2. Qt Account For the CLA one can simply add an instance of: https://github.com/cla-assistant/cla-assistant I think that's a good idea, in the past I was

Re: [Development] GitHub Pull requests

> otherwise we may end up accepting contributions from Twitter :) what is the problem if they improve the code ? On Tue, Mar 10, 2020 at 3:49 PM Konstantin Tokarev wrote: > > > 10.03.2020, 17:42, "Cristian Adam" : > > Hi, > > > > With the “GitHub issues” E-Mail thread we made sure the Issues a

Re: [Development] GitHub Pull requests

10.03.2020, 17:42, "Cristian Adam" : > Hi, > > With the “GitHub issues” E-Mail thread we made sure the Issues are gone > > from the projects. > > What about Pull requests? > > For example qtbase has 7 pull requests.  Usually people point out that > > the Qt project uses a different collaboration

[Development] GitHub Pull requests

Hi, With the “GitHub issues” E-Mail thread we made sure the Issues are gone from the projects. What about Pull requests? For example qtbase has 7 pull requests. Usually people point out that the Qt project uses a different collaboration method: https://wiki.