Re: [Development] Moving Qt's undo framework out of Qt Widgets

2017-04-05 Thread Konstantin Tokarev
05.04.2017, 17:46, "Oswald Buddenhagen" : > On Wed, Apr 05, 2017 at 12:02:32PM +, Morten Sørvig wrote: >>  On 5 Apr 2017, at 12:37, Oswald Buddenhagen >> wrote: >>  > also, a plan for splitting up qtbase wouldn't be entirely off the >>  >

Re: [Development] Moving Qt's undo framework out of Qt Widgets

2017-04-05 Thread Oswald Buddenhagen
On Wed, Apr 05, 2017 at 12:02:32PM +, Morten Sørvig wrote: > On 5 Apr 2017, at 12:37, Oswald Buddenhagen wrote: > > also, a plan for splitting up qtbase wouldn't be entirely off the > > mark. untangling tests and examples would be the major effort here. > > No, we

Re: [Development] Moving Qt's undo framework out of Qt Widgets

2017-04-05 Thread Ch'Gans
On 6 April 2017 at 00:02, Morten Sørvig wrote: > > >> On 5 Apr 2017, at 12:37, Oswald Buddenhagen wrote: >> >> On Wed, Apr 05, 2017 at 09:24:15AM +, Mitch Curtis wrote: >>> So, should this get its own module, and if so, can widgets depend on >>>

Re: [Development] Moving Qt's undo framework out of Qt Widgets

2017-04-05 Thread Morten Sørvig
> On 5 Apr 2017, at 12:37, Oswald Buddenhagen wrote: > > On Wed, Apr 05, 2017 at 09:24:15AM +, Mitch Curtis wrote: >> So, should this get its own module, and if so, can widgets depend on >> it? >> > an own module just for that seems over the top - i don't think

Re: [Development] Moving Qt's undo framework out of Qt Widgets

2017-04-05 Thread Oswald Buddenhagen
On Wed, Apr 05, 2017 at 09:24:15AM +, Mitch Curtis wrote: > So, should this get its own module, and if so, can widgets depend on > it? > an own module just for that seems over the top - i don't think we want to end up with 100 micro-libraries. however, splitting up qtcore has been raised

Re: [Development] Moving Qt's undo framework out of Qt Widgets

2017-04-05 Thread Shawn Rutledge
> On 5 Apr 2017, at 11:24, Mitch Curtis wrote: > > I'd like to remove the undo framework's dependency on widgets. There's a bug > report for this here: > > https://bugreports.qt.io/browse/QTBUG-40040 > > My plan is mentioned in the commit message of the following change:

Re: [Development] Moving Qt's undo framework out of Qt Widgets

2017-04-05 Thread Mitch Curtis
> -Original Message- > From: Konstantin Tokarev [mailto:annu...@yandex.ru] > Sent: Wednesday, 5 April 2017 11:29 AM > To: Mitch Curtis <mitch.cur...@qt.io>; development@qt-project.org > Subject: Re: [Development] Moving Qt's undo framework out of Qt Widgets > &

Re: [Development] Moving Qt's undo framework out of Qt Widgets

2017-04-05 Thread Konstantin Tokarev
05.04.2017, 12:24, "Mitch Curtis" : > I'd like to remove the undo framework's dependency on widgets. There's a bug > report for this here: > > https://bugreports.qt.io/browse/QTBUG-40040 > > My plan is mentioned in the commit message of the following change: > >

[Development] Moving Qt's undo framework out of Qt Widgets

2017-04-05 Thread Mitch Curtis
I'd like to remove the undo framework's dependency on widgets. There's a bug report for this here: https://bugreports.qt.io/browse/QTBUG-40040 My plan is mentioned in the commit message of the following change: https://codereview.qt-project.org/#/c/190704/ To summarise: - Introduce QGuiUndo*